Skip to content

feat(website): show each model example with the prompt that made it - #19385

Closed
MaanilVerma wants to merge 14 commits into
maanil/fe-2942-model-page-ssrfrom
maanil/fe-2930-example-gallery
Closed

MaanilVerma wants to merge 14 commits into
maanil/fe-2942-model-page-ssrfrom
maanil/fe-2930-example-gallery

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Every model page now shows each example output with the prompt that produced it, in the server-rendered HTML, so searchers and AI assistants can read the prompt next to the result. Example images are named after the model instead of "Output" or "Sample N".

Fixes FE-2930 (https://linear.app/comfyorg/issue/FE-2930/example-gallery-on-every-model-page-the-prompt-next-to-the-result)

Stacked on #18899 (FE-2942). The base moves to main once that merges.

Changes

  • ExamplesTab wraps each example in a <figure>, with the prompt verbatim as its <figcaption> under the card, clamped to three lines. Examples without a prompt get no caption, and a page with no examples still renders no gallery.
  • The prompt comes from the display data only: the sample's prompt, or the paired example's values.prompt when the sample has none (workshop-router-content.ts). It rides through GeneratedExample and PlaygroundExample as a new optional prompt.
  • The new exampleAlt() names each example image {model}: {title}, or {model} example output {n} for the Sample N fallback titles. The output pane uses it too while it shows a shipped example, so no model page has alt="Output" any more. Real run results still say "Output".
  • Gallery videos render with preload="none" and switch to metadata once the gallery is near the screen, so their first frame no longer competes with the output above it. They never autoplay.
  • check:models-html now also fails when a built page captions a prompt more or fewer times than the data has it, renders a gallery with no examples, or has an image with no alt, alt="Output" or alt="Sample N".

Changed from the ticket:

  • The gallery is the existing examples list inside the model page island rather than a separate block outside it, because feat(website): render each model page in the static HTML #18899 made the whole page one server-rendered island. The prompt is in real elements (not only the island props), and each one appears once.
  • Settings stay in the card overlay where they already were, rather than moving into the caption.
  • No width/height on gallery images: the aspect-video frame already reserves the space, and the sizes aren't in the data.

QA

  • Unit: exampleAlt, prompt passthrough, prompt source on three real models, ExamplesTab caption, alt and video preload cases, and the new gallery audit rules
  • check:models-html passes on all 148 model pages and fails on the base build
  • Raw HTML of FLUX, Seedance, Luma Photon and a no-example page checked with curl as GPTBot
  • CLS flag on and off, 1440 and 390, on FLUX, Seedance, Luma Photon and the no-example Bria page: no shift from the gallery
  • Workshop e2e specs pass against a local preview
  • WORKSHOP_IN_BUILD=0 build still succeeds
  • Preview: curl -s -A GPTBot <preview>/models/bfl--flux-2-max--generate-images/ | grep -c '<figcaption' returns 1
  • Not covered: workflow pages under /models/workflows/, which have their own example UI

The example gallery on model pages now wraps each output in a figure with
the prompt from the display data as its caption, so the prompt ships in the
server-rendered HTML. Example images and the output pane name the model
instead of "Output" or "Sample N", and gallery videos wait at
preload=none until the gallery nears the screen.
check:models-html now also fails when a page captions an example's prompt
more or fewer times than the data has it, renders a gallery with no
examples, or has an image with no alt, alt "Output" or alt "Sample N".
@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 29, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 29, 2026
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 6:34pm UTC
billing-web-test Ignored Ignored Sep 29, 2026 6:34pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: cb982cb0-d817-40a7-b614-5e65b90b67ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@MaanilVerma

MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA

Local production builds of this branch (head 9ba689ae61 + audit + helper commits) and of the base #18899 (a6024e4bf2), with the CI e2e env (WORKSHOP_IN_BUILD=1 PUBLIC_WORKSHOP_ROUTER_RUN=1 PUBLIC_WORKSHOP_CLOUD_ENV=test).

# Check Proof Result
1 Every built model page captions each prompt once and has no bad alt pnpm check:models-html here: [models-html] 148 model pages carry their model in the HTML. Same script on the base build: exit 1, 250 problem(s): 164 prompts not captioned, 77 alt="Output", 9 alt="Sample N" pass
2 Raw HTML, curl as GPTBot, prompt next to each sample (3 pages) and nothing on a no-example page grep -c '<figcaption' after / before: FLUX 2 Max 1 / 0, Seedance 2.5 T2V 1 / 0, Luma Photon 1 2 / 0, Bria Remove Video Background 0 / 0 with no examples-section at all. FLUX figure: <img alt="FLUX 2 Max Text-to-Image: Object Swap"> + figcaption Replace the current sofa with the one in Image 2, …. Seedance: <video preload="none">, no autoplay, figcaption Three-shot downhill mountain-bike sequence… pass
3 All 148 pages (props, template, noscript, script stripped) Before: gallery on 144 pages, 0 figcaptions, 77 alt="Output", 9 alt="Sample N", 77 gallery media at preload="metadata". After: gallery on 144, prompt captions on 134 pages (165 figcaptions), 0 alt="Output", 0 alt="Sample N", 0 <img> without alt, gallery videos 72 × preload="none" (the 5 left at metadata are audio) pass
4 Alt helper red→green Removed the Sample N branch of exampleAlt: × names the model and the example: 'Sample 2' Expected: "FLUX 2 Max example output 2" Received: "FLUX 2 Max: Sample 2". Restored: 3 passed pass
5 Prompt source is the display data only workshop-router-content.test.ts "example prompts": FLUX takes the sample's prompt, Runway Aleph 2 the example's values.prompt (no sample prompt), Bria Remove Image Background none pass
6 CLS, 6 s after load plus 3 s after scrolling the gallery into view, flag on and off, 1440 and 390 (iPhone 13) FLUX / Seedance / Luma / Bria. Load CLS: desktop flag on 0.0041 all four on both branches, flag off 0 both; 390 flag off 0 both; 390 flag on 0–0.0041 on both branches. Shift source on repeat runs is only mobile-nav-cta: Sign in (header, pre-existing), including on Bria, which has no gallery. CLS after scrolling to the gallery: 0 on every run, both branches. No hydration warnings pass
7 LCP not hurt Desktop 1440, 5 runs each, median: FLUX 656 → 576 ms, Seedance 888 → 936 ms (ranges 696–1036 vs 532–1132, overlapping; network to media.comfy.org). LCP element on image pages is now IMG[alt=FLUX 2 Max Text-to-Image: Object Swap] instead of IMG[alt=Output] pass
8 Video first frame still loads After hydration and scroll, Seedance gallery video: preload=metadata readyState=4 videoWidth=1280. JS off: preload=none, dark card with title and caption (no poster exists yet) pass
9 Unit Touched suites: 9 files, 371 passed. Full website suite: only failures are pre-existing (workshop-contract timeout, VideoMaskScene), which fail the same way on the base pass
10 e2e workshop.spec.ts, workshop-frame-ratio, workshop-visibility, workshop-loading-flash, workshop-input-feedback against astro preview: 54 passed (includes the examples refill, replace-dialog and phone sizing tests) pass
11 Other validators validate:jsonld, check:hreflang, validate:llms-txt-links exit 0 pass
12 WORKSHOP_IN_BUILD=0 Build exits 0; dist/models/ has only index.html pass
13 Gates website typecheck 0 errors, eslint + oxlint + oxfmt clean on touched files, pnpm knip clean, fallow audit scoped to the base: pass, 0 introduced pass
14 Page weight Model page HTML median 110.9 → 111.8 KB (max 165.1 → 167.2) pass
15 Screenshots 1440 and 390 (JS on and off) Taken locally for FLUX, Seedance, Luma, FLUX Erase (Sample-N, no prompts) and Bria (no gallery); caption sits under each card in text-primary-warm-gray, clamped to 3 lines pass
16 Preview deploy curl, GPTBot and Googlebot comfy-website-preview-pr-19385.vercel.app, grep -c '<figcaption': FLUX 1, Seedance 1, Luma Photon 2, Bria 0 (no gallery), same for both UAs. FLUX alt="FLUX 2 Max Text-to-Image: Object Swap", Seedance gallery <video preload="none">, 0 alt="Output" pass
17 Automated review follow-up (fa9522b04a, b8b103621c, e37ed05cff) Video frames latch once the gallery has been near the screen and load at metadata where IntersectionObserver is missing: new tests fail with the old binding (3 failed) and pass with the fix (4 passed). Alt fill is literal ($' {n} $& model name test). Audit now counts example-item cards and names the src of a bad alt; re-run on the saved builds: this branch 148 model pages carry their model in the HTML., base still 250 problem(s). Touched suites 231 passed, vue-tsc 0 errors, eslint/oxlint/oxfmt clean, scoped fallow pass pass
18 CI build red at e37ed05cff: video cards missing from the server HTML (window read during SSR by the no-observer fallback). Fixed in 5bb9db9529 (support read only after mount) New ExamplesTab.ssr.test.ts: ReferenceError: window is not defined without the fix, passes with it. Fresh build: [models-html] 148 model pages carry their model in the HTML.; FLUX 3 T2V 2 figcaptions, 2 preload="none" pass
19 Structured JSON prompt (Ideogram v4, the only one in the data) captions only its text field, 4258fefbbf Keys in the data: high_level_description (string), style_description and compositional_deconstruction (objects); no prompt/text, so promptText reads prompt, text, then high_level_description, and renders no caption when none is text. Table test (string, JSON with text, JSON without text, blank) passes. Caption before: { "high_level_description": "A surreal, retro-futuristic…; after: A surreal, retro-futuristic vintage collage poster featuring a vintage orange train carriage…. Fresh build: [models-html] 148 model pages carry their model in the HTML. pass
20 Ben's review, 84f22a5dd6 + 5a983a986a: shipped example video and lightbox use the example alt, audit covers <video aria-label> in its own auditMediaLabels, t() interpolation, galleryLabel prop, no initialValue, unparseable JSON gives no caption Fresh build: [models-html] 148 model pages carry their model in the HTML.; 63 output-pane videos in static HTML, 0 aria-label="Output", 0 <img alt="Output">; relabelling one back to "Output" fails the audit (has a video labelled "Output"). New PlaygroundOutput tests (video label, lightbox alt) and the "unparseable JSON" promptText row fail on the old code, pass now. Real data: 434 prompts, 2 start with {, both valid JSON. Touched suites 390 passed + ReshootExamples, vue-tsc 0 errors, eslint/oxfmt clean pass

CI: all checks were green on 82a73c27e1 (68 pass, 41 skipped). Not watched to a verdict after the review-fix pushes.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (25 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 72, CRAP undefined apps/website/src/components/workshop/PlaygroundOutput.vue:295 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 49, CRAP undefined apps/website/src/components/workshop/ModelDetail.vue:874 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 14, CRAP undefined apps/website/src/components/workshop/ExamplesTab.vue:76 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 426f1563577c736496bd42adfe02bfca134f2176

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19385.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-d5ijee6ki-comfyui.vercel.app

Last updated: 2026-09-29T18:40:39Z for 5a983a9

📦 Bundle Size

⏳ Size data collection in progress…

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/website/src/config/workshop-router-content.ts 92.85% 0 Missing and 1 partial ⚠️
@@                        Coverage Diff                        @@
##           maanil/fe-2942-model-page-ssr   #19385      +/-   ##
=================================================================
- Coverage                          84.15%   84.05%   -0.11%     
=================================================================
  Files                               3189     3158      -31     
  Lines                             155090   154305     -785     
  Branches                           42475    39960    -2515     
=================================================================
- Hits                              130515   129698     -817     
- Misses                             22902    22990      +88     
+ Partials                            1673     1617      -56     
Flag Coverage Δ
website-unit 78.91% <98.03%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ps/website/src/components/workshop/ExamplesTab.vue 98.07% <100.00%> (+0.57%) ⬆️
...ps/website/src/components/workshop/ModelDetail.vue 90.60% <ø> (ø)
...bsite/src/components/workshop/PlaygroundOutput.vue 91.34% <100.00%> (+0.11%) ⬆️
...kshop/cinematic-studio/reshoot/ReshootExamples.vue 100.00% <ø> (ø)
apps/website/src/config/models-catalogue.ts 89.68% <ø> (ø)
...ps/website/src/config/workshop-generated-models.ts 100.00% <ø> (ø)
apps/website/src/config/workshop-playground.ts 98.87% <100.00%> (+0.02%) ⬆️
apps/website/src/config/workshop-run.ts 93.75% <ø> (ø)
apps/website/src/i18n/translations.ts 100.00% <ø> (ø)
apps/website/src/config/workshop-router-content.ts 78.43% <92.85%> (+5.45%) ⬆️

... and 304 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 9 finding(s).

Severity Count
🟡 Medium 1
🟢 Low 6
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Careful, well-tested change. The <figure>/<figcaption> markup is right (caption is the last child, so it stays valid), the prompt does ride through real server-rendered elements rather than island props, the prompt-count audit correctly normalises entities and whitespace on both sides, and the galleryReached latch is the right primitive here. I verified the audit's assumptions hold: model pages resolve through getWorkshopPageDetail -> getRouterWorkshopModelDetail, the same map the check reads; showsExamples is !slots.details && examples.length > 0 and ModelPage.vue passes no details slot, so card counts line up; examplesForModel is 1:1 with detail.examples; and Tailwind preflight is active, so the new <figure> gets no default 40px margin.

No blockers. Two things worth fixing before merge, both one-liners.

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 3

Main point

The alt plumbing stops at the image branch of PlaygroundOutput. The video renderer (L464) and the expanded lightbox (L715) still label the shipped example "Output", and the new audit structurally cannot catch either — it reads <img> only, and the dialog is never in the static HTML. Worth widening the audit to <video>/aria-label too, otherwise the guard advertises more coverage than it has.

Nit not worth a thread

ReshootExamples.vue passes rc('reshoot.title', locale) ("Re-shoot a video") as modelName, producing alt="Re-shoot a video: Neon street". It works, but the prop name no longer describes what callers pass; galleryLabel or similar would age better.

Reviewed against the PR head b0ffd00. Base is maanil/fe-2942-model-page-ssr, so this needs #18899 in first.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — nothing blocking in this diff.

The two SHOULD FIX items from my earlier review are non-blocking but worth picking up before this lands:

  • PlaygroundOutput.vue L464 (VideoPlayer aria-label) and L715 (expanded lightbox alt) still say "Output" for shipped examples. exampleOutput() already supplies alt for every kind, so both are the same one-liner as L477. Worth widening auditExampleGallery past <img> at the same time, otherwise the guard keeps advertising coverage it doesn't have.
  • exampleAlt hand-rolls interpolation that t(key, locale, named) already does via the shared interpolate() helper.

Verified rather than assumed: model pages resolve through the same detail map the audit reads, showsExamples can't be false while examples exist (no details slot on ModelPage.vue), examplesForModel is 1:1 with detail.examples, the caption comparison normalises entities and whitespace consistently on both sides, and Tailwind preflight is active so the new <figure> picks up no default margin. The explicit galleryReached latch is also the correct choice — VueUse's once: true would have un-latched an element that starts visible and later scrolls away.

Reminder that the base is maanil/fe-2942-model-page-ssr, so #18899 needs to land first.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the two new commits (84f22a5, 5a983a9). All five threads addressed; resolved them. Approving.

I verified the fixes rather than taking the replies at face value:

Video label (84f22a5) — the part I actually doubted was whether :aria-label on <VideoPlayer> reaches a real <video> tag, since a fallthrough attr would have landed on the component's root <div> and made the new audit rule vacuous for the exact element it was added for. It doesn't: ariaLabel is a declared prop (VideoPlayer.vue:82) bound onto the <video> at :315, so the label is in the static HTML and auditMediaLabels genuinely sees it. The new "labels a shipped example video by its example" test pins that end to end. shown?.alt in the lightbox is right too — shown is files[selectedFile] ?? primary, nullable, and the dialog sits outside the v-else-if="shown" block, so the optional chain is load-bearing rather than defensive noise.

promptText catch (5a983a9) — checked the claim against the content myself: 438 string prompts in workshop-display.json, exactly 2 start with { (both ideogram--v4--generate-images), both parse to objects carrying high_level_description. Zero captions regress from returning undefined on unparseable JSON.

auditMediaLabels move — correctly filed now, and net coverage went up rather than sideways: the table gained video labels and a <template>-exclusion case. attributeOf handles the cases that matter (data-alt still reads as a missing alt, bare alt reads as decorative ''). Note the video rule is "no placeholder label" rather than "must be labelled" — deliberate and right for decorative video, just worth knowing it won't catch a label being dropped entirely.

exampleAlt — now t(key, locale, { name, n }). Dropping the replacement-pattern test was the right call; a function replacer never reinterprets $&, so that test was asserting JavaScript, not this code.

galleryLabel rename — thanks for taking the nit. Rename is complete across both call sites and all five test props, no stragglers.

Only thing left is cosmetic and not worth another round: exampleAlt's first parameter is still named modelName while its callers now pass a gallery label.

Still stacked on maanil/fe-2942-model-page-ssr — #18899 needs to land first.

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
## Summary

**Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its
follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it
to a /workflows 404) must be deployed before this merges. After the
merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30
workflow names in `hub-workflow-names.json`. The redirects ship as 307;
FE-3083 flips them to 308 later.**

This branch combines every Workshop /models SEO PR, so merging it to
main replaces merging them one by one. It also launches: Comfy-Org#19405 commits
`launchedModelPages = 'all'`, so all 148 model pages become indexable in
the same deploy as the URL move.

Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is
FE-3087)
Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977,
FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935,
FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921,
FE-2922, FE-2947

## Changes

Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324
router tests), deploy before this merges.


The included PRs, in merge order. Every head was checked as contained at
the final tip.

| PR | Ticket | What | Ben |
|---|---|---|---|
| Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate`
| approved |
| Comfy-Org#18889 | FE-2989 | A unique meta description on every model page |
approved |
| Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts |
approved |
| Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate
summaries | approved |
| Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title,
Organization data. The FE-2977 title was confirmed by the owner |
approved |
| Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved |
| Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" |
approved |
| Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI
check | approved |
| Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale
| approved |
| Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for
serverless-animation | approved; re-approval pending on a one-line
follow-up (CodeRabbit approved) |
| Comfy-Org#19359 | FE-2974 | One typed redirect list that generates
`vercel.json` | approved |
| Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved |
| Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says |
approved |
| Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved |
| Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML |
approved |
| Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved |
| Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved
|
| Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift |
approved |
| Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles |
approved |
| Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page |
approved (a CodeRabbit changes-requested review is still open) |
| Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved |
| Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved |
| Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved |
| Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with
redirects | approved |
| Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing
| approved |
| Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved |
| Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page |
approved |
| comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and
routes `/hub/workflows` by manifest. Merged and live | merged |

These fixes exist only on this branch, because they only break once two
PRs meet:

- `scripts/check-models-html.ts` reads each page at `model.href` and
skips models without a page (f1df1e4).
- `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models`
(f87bb4c).
- `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made
it optional and Comfy-Org#19405 no longer typechecked (9783819).
- `ModelStatus` links a successor only when it has a page, for the same
reason on Comfy-Org#18899 (c4761d8).
- The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/`
instead of the `/models/` redirect (eb985b6). Its label still says
"Models" while the nav says "Hub".
- Twin, meta-description and entry tests use the hub pages and the new
tag set (86ac3b0, d4ffc0f).
- The render guard finds the catalogue through `getRoutes().workshop`,
and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f).
- A new test renders a real model page and checks its markdown twin has
the model's h1 (9a6c5cb).
- Main's newer catalogue and workflow e2e cases use the hub addresses
(2aeda77).
- `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of
main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer
exists (c28c7a7).

The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays
deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real
catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the
`WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's
figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing
tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer
builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test
imports `PROVIDER_NAMES` from its new home. The full table of 47
resolutions is in the integration report.

## Review Focus

- Launch rides along with the URL move. If launch should stay a separate
step, set `launchedModelPages` in
`apps/website/src/config/model-page-launch.ts` to `new Set()` before
merging.
- Main's Comfy-Org#19320 gives the catalogue island its own h1 through
`WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only
the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1.

- Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion
for serverless-animation). One of them should be closed once this lands.

## QA

- [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0
errors, eslint on `apps/website` clean, `pnpm knip` clean
- [x] Website unit: 547 files, 10347 passed, 4 skipped
- [x] Build A (`build:e2e`, CI env): 1193 pages; release gate,
`check:hreflang`, `validate:llms-txt-links` (225 links),
`validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html`
(148 pages) all pass
- [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on
build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no
Run, no Hub nav and no Firebase requests
- [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals
except redirect stubs, no hreflang in the sitemap
- [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed
on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network
isolation, render guard) all passed when rerun alone
- [x] Launch: 148 model pages indexable with canonicals, 149 hub entries
in the sitemap, 148 non-empty twins with the model h1, 148 in
`llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex
- [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307,
every /hub destination built
- [x] comfy-router#46 under `wrangler dev` in front of this build: 312
router tests pass; 148 old model URLs (both slash forms) 307 then 200;
30 workflow names served by the website and their old URLs 307; a
non-manifest workflow 302 with no-store; `manifest.json` passes through;
`/workflows/` and bare `/hub` unchanged
- [x] After the router deploys and this merges: purge Cloudflare, then
curl `https://comfy.org/hub/models/` for a 200 and three old
`/models/<slug>/` URLs for one 307 each
- [x] Rich Results Test on `/pricing/` and
`/learning/animations/character-sheet/`, then "Validate fix" on Merchant
listings and Videos
- [x] Rich Results Test on two live model pages: breadcrumbs valid and
the breadcrumb URL returns 200 with no redirect
- [x] GPTBot and Googlebot curls on the hub and one model page, then a
GSC live test on both
- [x] Resubmit the sitemap in Search Console and URL-inspect about 20
model pages on day 0 and day 14
- Not covered: Rich Results and GSC need production; the redirect matrix
used a local shim for `vercel.json`, since `astro preview` ignores it

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants