Skip to content

fix(website): clean model page tags and block new duplicate summaries - #18892

Closed
MaanilVerma wants to merge 8 commits into
mainfrom
maanil/fe-2990-model-tags-summaries
Closed

MaanilVerma wants to merge 8 commits into
mainfrom
maanil/fe-2990-model-tags-summaries

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Model pages stop showing internal Router tags like "bfl · flux · flux-2" in the tag row, and a unit test now blocks any new duplicate model summary while the 24 existing duplicate groups can only shrink.

Fixes FE-2990

Changes

  • prepareModelPage in routes/models/model-page.ts now leaves out tags that name the model's provider (by Router ID or name, so gemini and google both go on a Google page), bare versions like v4.1 or 1.5, and tags whose words all appear in the model name (flux, flux-2 on FLUX 2 Max).
  • Only the model page's tag row and its overflow are filtered. capabilities is untouched, so catalogue search, filters and cards behave as before.
  • providerName moved into lib/workshop/provider-name.ts so the model page can reuse it without importing the catalogue module.
  • workshop-browse-content.test.ts groups published models by normalised summary (trimmed, lower case, collapsed spaces). A new or grown group fails with every slug named. An allowlist entry whose group shrank or vanished fails with "Stale entry, remove it".
  • One change from the ticket: I skipped the optional near-duplicate warning. A warning in a unit test never fails and nobody reads it, so it would be noise.

Testing

  • Tag table in model-page.test.ts (FLUX 2 Max, Nano Banana Pro, Recraft V4.1, Grok Imagine Video 1.5) fails on main and passes here
  • Duplicate-summary test fails when a new duplicate is added and when an allowlisted summary is rewritten, passes on current data
  • Website typecheck, eslint, oxfmt and knip are clean
  • After deploy, check that shownTags in /models/bfl--flux-2-max--generate-images/page.json on comfy.org is ["premium"]
  • Not covered: 38 pages now show no tag pills because every tag they had was a provider, version or name echo. The row is hidden when empty, which is the existing behaviour.

Known duplicate groups are listed so they can only shrink; a new or grown
group, or a stale entry, fails the unit tests.
…odel page tags

The model page showed raw Router tags such as "bfl · flux · flux-2". Only the
page's tags are filtered; catalogue search, filters and cards are unchanged.
@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 25, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 25, 2026
@MaanilVerma
MaanilVerma requested review from a team September 25, 2026 16:57
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 1:26pm UTC
billing-web-test Ignored Ignored Sep 29, 2026 1:26pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c3e6f85b27b6535ed457766efc23fbbdf5005701

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-18892.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-h8ql8zmal-comfyui.vercel.app

Last updated: 2026-09-29T16:39:59Z for d6b765d

@MaanilVerma

MaanilVerma commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA

I checked the tag row on four model pages against prod, ran both new tests red then green, and forced a new duplicate and a stale allowlist entry to confirm the guard fails the right way.

1. Tag row, prod (before) vs this branch (after). Pass

for s in bfl--flux-2-max--generate-images vertexai--gemini-3-pro-image--edit-images recraft--v4.1-text-to-vector--generate-images xai--grok-imagine-video-1.5-reference--animate-images; do
  curl -s $HOST/models/$s/page.json | python3 -c 'import sys,json; d=json.load(sys.stdin); print(d["model"]["slug"], [t["label"] for t in d["shownTags"]], "+", d["restTagCount"])'
done

Before (https://comfy.org):

bfl--flux-2-max--generate-images ['bfl', 'flux', 'flux-2'] + 2
vertexai--gemini-3-pro-image--edit-images ['gemini', 'google', 'pro'] + 6
recraft--v4.1-text-to-vector--generate-images ['recraft', 'v4.1', 'svg'] + 1
xai--grok-imagine-video-1.5-reference--animate-images ['grok', 'xai', 'video'] + 3

After (local astro dev on this branch):

bfl--flux-2-max--generate-images ['premium'] + 0
vertexai--gemini-3-pro-image--edit-images ['high-quality', 'multimodal', 'text-to-image'] + 0
recraft--v4.1-text-to-vector--generate-images ['svg'] + 0
xai--grok-imagine-video-1.5-reference--animate-images ['voice'] + 0

In the browser with the workshop flag on, the FLUX 2 Max header tag list has one link, premium (href /models?q=premium). The related-model cards below still show bfl; catalogue cards are out of scope (separate ticket).

2. Tag table in model-page.test.ts. Pass (red on main, green here)

On main:

× hides provider IDs, bare versions and name echoes on 'FLUX 2 Max Text-to-Image'       received: bfl, flux, flux-2, text-to-image, premium
× hides provider IDs, bare versions and name echoes on 'Nano Banana Pro Image Edit'     received: gemini, google, pro, high-quality, edit
× hides provider IDs, bare versions and name echoes on 'Recraft V4.1 Text-to-Vector'    received: recraft, v4.1, svg
× hides provider IDs, bare versions and name echoes on 'Grok Imagine Video 1.5 Reference-to-Video'  received: grok, xai, video, 1.5, reference, voice
Tests  4 failed | 8 passed (12)

On this branch: Tests 12 passed (12).

3. Duplicate-summary guard fails on a new duplicate. Pass

Changed Ideogram V4's description to " generates a PHOTOREAL image with strong text rendering (Ideogram V4)." (Ideogram V3's text with case and whitespace changes):

+   "Duplicate summary on ideogram--v3--generate-images, ideogram--v4--generate-images: \"generates a photoreal image with strong text rendering.\". (message at the time; round 2 changes it)",

4. Stale allowlist check. Removed in round 2 (8e63867); see below.

5. Gates. Pass

Website pnpm typecheck 0 errors, eslint and oxfmt clean on touched files, pnpm knip clean. The full website unit run had a few timeouts under local load (for example WorkshopFilterMenu.test.ts), none in touched files; they pass when re-run alone. CI is the verdict.

Edge cases checked

  • A model with no tags, or only internal tags, gets an empty list and the row is hidden (11 published pages after round 3).
  • Tags in upper case (V4.1, Google) are caught the same way.
  • Workflow pages have no provider; the filter handles that.

Review follow-up (56e9087). Pass

  • Name-echo check now requires the tag's words in name order, so image-to-image comes back on the four Seedream Text-to-Image pages; nothing else changes on real data. New tag table row: red on 5246bbc (1 failed), green now (13 passed).
  • Tags with no matchable words (for example 写实) are kept; providerName ignores inherited object keys.
  • A shrinking duplicate group named the slugs to drop (superseded in round 2, which removes the shrink check).
  • The Veo summary finding was declined as editorial scope (FE-2968).

Review follow-up, round 2 (147beaf, 8e63867). Pass

  • Tag rules moved to lib/workshop/model-tags.ts and share words() with model-summary.ts. A tag word may span name words (wan2 is "Wan 2"), and only a numeric word may sit between echoed words.
  • New table in model-tags.test.ts: under the 56e9087 rules, 3 rows fail (GPT Image 2 image-to-image, Hunyuan3D 3d, Rodin 3d); now 19/19 pass. seedream-5-pro, seedance-2-mini, wan2.7 and gen4 are still dropped. provider-name.test.ts added.
  • Real data, all authored models, 56e9087 vs now: published pages that change are GPT Image 2, 2.5 Flare and 2.5 Sunburst Text-to-Image (image-to-image comes back). Unpublished Hunyuan3D Part, Texture Edit, UV Unfold and Smart Retopology get 3d back (e.g. fbx, model-to-model -> 3d, fbx, model-to-model). Published pages with no tag pills: 36 of 148, unchanged.
  • Duplicate guard: a forced new duplicate still fails and now points at scripts/generate-workshop-catalog.ts. Shrinking the Recraft raster group now passes. A duplicated allowlist row fails on known.size.
  • Typecheck 0 errors, eslint and oxfmt clean, pre-push knip and fallow clean.

Owner decision: keep task tags (8a23319). Pass

  • Tags that name a task (anything splitTask in models-catalogue.ts accepts: text-to-image, image-to-video and so on) are now exempt from the name-echo rule. Provider tags, bare versions and other name echoes like flux-2 and seedream-5-pro are still hidden.
  • Tests: under the 8e63867 rules, 3 fail (FLUX 2 Max text-to-image, Veo 3 image-to-video, and the model page wiring test that expects high-detail, text-to-image, premium). Now 153 pass across lib/workshop and routes/models.
  • Real data: 69 of 148 published pages gain a task tag. For example, FLUX 2 Max goes from premium to text-to-image, premium, and FLUX 2 Pro goes from no tags to text-to-image. Published pages with no tag pills: 36 before, 11 now.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 25, 2026
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6aa19f2e-8fdf-448d-8f8a-410336db5819

📥 Commits

Reviewing files that changed from the base of the PR and between 8a23319 and d6b765d.

📒 Files selected for processing (1)
  • apps/website/e2e/workshop.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The changes add shared provider-name formatting, filter model-page capability tags, validate published summary duplicates, and update the premium-tag deep-link test.

Changes

Workshop model metadata

Layer / File(s) Summary
Shared provider-name formatting
apps/website/src/lib/workshop/provider-name.ts, apps/website/src/lib/workshop/provider-name.test.ts, apps/website/src/config/workshop-browse-content.ts
A shared formatter maps known provider keys to display names and formats other keys. Workshop browse content imports it instead of defining a local formatter. Tests cover mapped names and fallback formatting.
Model-page capability tags
apps/website/src/lib/workshop/model-summary.ts, apps/website/src/lib/workshop/model-tags.ts, apps/website/src/lib/workshop/model-tags.test.ts, apps/website/src/routes/models/model-page.ts, apps/website/src/routes/models/model-page.test.ts, apps/website/e2e/workshop.spec.ts
Model-page tag preparation excludes bare versions, provider-matching capabilities, and capabilities whose words echo the model name. Tests check retained tags and premium-tag search results.

Duplicate-summary checks

Layer / File(s) Summary
Duplicate-summary validation
apps/website/src/config/workshop-browse-content.test.ts
A test normalizes published summaries and checks duplicate groups against listed summaries and model slugs.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: benjcooley

Merge Risk: ⚪ Minimal · up to d6b76

The premium-tag deep link remains covered, and no merge-blocking issue is established by the supplied evidence.

Architecture Summary

Architecture risk: 🔵 Low · up to d6b76

The change affects 1 system.

Changed systems: apps/website

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/website (service) was modified; 10 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/website/src/config/workshop-browse-content.ts: Adds an import of providerName from the shared workshop provider-name module.
  • observed — Modified behavior in apps/website/src/config/workshop-browse-content.ts: Removes the local PROVIDER_NAMES mapping and providerName formatter, including its known-provider labels and fallback that title-cased hyphen-separated provider IDs.
  • observed — Modified behavior in apps/website/src/lib/workshop/provider-name.ts: Adds a read-only provider-name mapping, including aliases for ByteDance and Google.
  • observed — Modified behavior in apps/website/src/lib/workshop/provider-name.ts: Adds exported providerName, which returns a mapped name when the key is present; otherwise it splits on hyphens, removes empty parts, capitalizes each part’s first character, and joins them with spaces.
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes both primary changes: cleaning model-page tags and preventing new duplicate summaries.
Description check ✅ Passed The description explains the purpose, implementation, scope, testing, issue reference, and known limitation. The optional Breaking, Dependencies, Review Focus, and Screenshots sections are either not …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR uses bug-fix language, including fix in the title and commit subjects. However, all listed changes are under apps/website, and the check explicitly excludes PRs exclusively in `apps/website…
Website End-To-End Regression Coverage ✅ Passed The PR changes website runtime behavior in apps/website/src/routes/models/model-page.ts by filtering model-page tags. It also updates apps/website/e2e/workshop.spec.ts to exercise the model-tag de…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are limited to website configuration, model-page, workshop library, test, and e2e paths. None are under src/lib/litegraph/, src/ecs/, or related graph-entity files. The check is …
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #18892      +/-   ##
==========================================
- Coverage   84.14%   84.05%   -0.10%     
==========================================
  Files        3227     3160      -67     
  Lines      155871   154256    -1615     
  Branches    40287    41847    +1560     
==========================================
- Hits       131162   129654    -1508     
- Misses      22980    22988       +8     
+ Partials     1729     1614     -115     
Flag Coverage Δ
billing-web-unit ?
website-unit 78.79% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/workshop-browse-content.ts 83.59% <ø> (-0.50%) ⬇️
apps/website/src/lib/workshop/model-summary.ts 100.00% <ø> (ø)
apps/website/src/lib/workshop/model-tags.ts 100.00% <100.00%> (ø)
apps/website/src/lib/workshop/provider-name.ts 100.00% <100.00%> (ø)
apps/website/src/routes/models/model-page.ts 95.45% <100.00%> (+0.45%) ⬆️

... and 338 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 5 finding(s).

Severity Count
🟠 High 1
🟡 Medium 1
🟢 Low 3

Panel: 8/8 reviewers contributed findings.

FLUX 2 Max no longer shows the flux tag, so the deep-link check follows
premium and checks each result card's tags.
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 25, 2026 17:14 Inactive
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

QA follow-up: the first CI run failed e2e/workshop.spec.ts "model tags deep-link into a filtered catalog", because it clicked the flux tag on FLUX 2 Max and that tag is now hidden by design. 5246bbc switches it to the premium tag and checks that every result card lists premium among its tags. It passed locally against a CI-style build (1 passed), and all checks are green on the new head, including the four website-e2e shards and website-unit. Pass.

… slugs

A tag now counts as a name echo only when its words appear in the name in
order, so image-to-image stays on a Text-to-Image page, and a tag with no
matchable words is kept. providerName ignores inherited object keys. The
duplicate-summary guard names the slugs to drop when a group only shrinks.
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 25, 2026 18:43 Inactive
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 25, 2026

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the tag filter against the shipped catalogue data (simulated describesCapability over workshop-models.json + workshop-display.json) rather than just reading the diff. The direction is right and the code is clean; two things I'd change before merge.

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 3

The two that matter

  1. isInOrder allows gaps, so image-to-image is dropped from the three GPT Image Text-to-Image pages ("GPT Image 2 Text-to-Image"). Their Image Edit siblings keep it, so the same model advertises img2img on one page and not the other. Your own test case (image-to-image on Seedream 4.0 Text-to-Image) is asserting exactly this and passes only by word-order luck.

  2. The duplicate-summary ratchet tells the reader to "Write a distinct summary", but summaries come from entry.description, which generate-workshop-catalog.ts writes verbatim from the partner export and there is no override in this repo. The only local fix is editing the 180-line literal — and the Stale entry branch means the test also fails when a duplicate gets fixed upstream. The new/grown-group half is worth keeping; the shrink half buys churn.

Worth a product call, not a code change

By the PR's own count 38 model pages will render no tag pills at all (my rough pass over the data puts it in the 40-60 range out of ~280). The row hides when empty, so nothing breaks, but "a fifth of model pages have no pills" is a design decision someone should sign off on rather than a side effect of the filter.

Checked and fine

  • q=premium is a sound replacement for q=flux in the e2e: premium only reaches searchText via capabilities, and overflowed capability chips land in the +N trigger's aria-label, so toHaveAccessibleName holds for every matching card.
  • flux-2-max keeps exactly ["premium"], matching the PR description.
  • The Object.hasOwn guard in the extracted providerName is a real (if latent) improvement over the old PROVIDER_NAMES[provider] ??.
  • Filtering is confined to the model page; capabilities on cards, search and facets are untouched.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on the first SHOULD FIX only; the second is negotiable.

Blocking: the gappy subsequence match drops a real tag on live pages.

image-to-image disappears from openai--gpt-image-2--generate-images, openai--gpt-image-2.5-flare--generate-images and openai--gpt-image-2.5-sunburst--generate-images, because [image, to, image] threads through "GPT Image 2 Text-to-Image" with gaps. Their --edit-images siblings keep it, so the same model advertises img2img on one page and not the other.

I'm holding the PR on this rather than filing a follow-up for two reasons: it is a regression in the exact surface this PR exists to improve, and the unit test added here (image-to-image kept on Seedream 4.0 Text-to-Image) asserts the case works — it passes only because image falls after to in that particular name. Merged as-is, the next reader has a green test telling them this is handled.

Fix is small: when walking the name, allow a skipped word between two matched words only if the skipped word is numeric. That preserves the drops you want (seedance-2-mini vs "Seedance 2.0 Mini ...", seedream-5-pro vs "Seedream 5.0 Pro ...", where the gap is the .0) and keeps image-to-image, where the gap contains text. Please extend the test table with a GPT Image 2 Text-to-Image row so the rule is actually pinned.

Not blocking: the duplicate-summary ratchet.

I still think the shrink half (Stale entry / Stale slugs) costs more than it returns, given summaries are copied verbatim from the partner export and cannot be authored in this repo. But that is a judgement call about maintenance cost, not a defect — if you want to keep it, say so and I'll drop the objection. The new/grown-group half is good and I'd keep it either way.

The three TRIVIAL comments are take-them-or-leave-them.

Move the model page tag rules into lib/workshop/model-tags.ts, share the
tokenizer with modelSummary, and let a tag word span name words. Only a
numeric word may sit between echoed words, so image-to-image stays on the
GPT Image Text-to-Image pages and 3d stays on Hunyuan3D pages.
Summaries are imported from partner descriptions, so a shrinking group is
not an error here. The allowlist must not collapse two rows into one.
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 29, 2026
…s them

Tags that name a task (text-to-image, image-to-video and the rest of the
catalogue's task vocabulary) are exempt from the name-echo rule. Provider
tags, bare versions and other name echoes are still hidden.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. All five of my comments are addressed in code, not just acknowledged — I re-ran the tag rules over the shipped catalogue data to confirm rather than taking the replies at face value.

Verified against real data

  • image-to-image is back on all three GPT Image Text-to-Image pages. The version-gap rule does what it claims: seedream-5-pro and seedance-2-mini are still dropped.
  • Sharing words() from model-summary.ts brings 3d back on the Hunyuan3D pages, as you said.
  • The new word-spanning match is a net win I didn't ask for and didn't expect: it now catches viduq2 on "Vidu Q2 Pro ..." and dalle on "DALL·E 2 ..." (15 pages), which the old rule missed. I diffed old rule vs new rule across the whole catalogue and those are the only tags the new rule drops that the old one kept — all correct drops, no regressions.
  • Empty tag rows drop a long way. On my pass over the data the count falls from ~64 to ~22, mostly thanks to the splitTask exemption.
  • known.size assertion, the shrink-half removal, and the upstream-pointing failure message are all in. model-tags.ts + the 21-row table test is a much better home for these rules than a route module behind four mocks.

On the splitTask exemption (8a23319)

I didn't ask for this and it partly reverses the PR's opening premise, so I looked at it hard. It's sound: splitTask is an existing, tested parser over a closed vocabulary (4 inputs x 6 outputs), not a loose x-to-y pattern match, and it sits after the provider and bare-version checks so it can't resurrect those. Keeping a real capability that happens to be restated in the title is the right call, and it's the main reason the empty-row problem shrank. No objection.

One consequence worth knowing: the hero now carries both the use-case pill ("Generate images") and a text-to-image tag, which is close to saying the same thing twice in one header block. They deep-link differently (?useCase= vs ?q=), so it's defensible — just flagging it in case design has a view.

Please update the PR description before merging — it is the squash-merge message, and it now describes a version of this PR that no longer exists:

  • "the 24 existing duplicate groups can only shrink" and the "Stale entry, remove it" bullet describe the rule you deleted in 8e63867.
  • The tag table moved to model-tags.test.ts; the description still points at model-page.test.ts.
  • The shownTags check is ticked [x] but it is a post-deploy step that cannot have run yet, and the expected value is now wrong: bfl--flux-2-max--generate-images yields ["text-to-image", "premium"], not ["premium"].
  • "38 pages now show no tag pills" predates the task-tag change and is now materially too high.
  • The splitTask exemption is the most interesting behaviour change in the PR and is not mentioned at all.

Nothing above blocks the merge; CI is green across unit, e2e and build on the merged head.

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
## Summary

**Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its
follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it
to a /workflows 404) must be deployed before this merges. After the
merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30
workflow names in `hub-workflow-names.json`. The redirects ship as 307;
FE-3083 flips them to 308 later.**

This branch combines every Workshop /models SEO PR, so merging it to
main replaces merging them one by one. It also launches: Comfy-Org#19405 commits
`launchedModelPages = 'all'`, so all 148 model pages become indexable in
the same deploy as the URL move.

Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is
FE-3087)
Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977,
FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935,
FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921,
FE-2922, FE-2947

## Changes

Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324
router tests), deploy before this merges.


The included PRs, in merge order. Every head was checked as contained at
the final tip.

| PR | Ticket | What | Ben |
|---|---|---|---|
| Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate`
| approved |
| Comfy-Org#18889 | FE-2989 | A unique meta description on every model page |
approved |
| Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts |
approved |
| Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate
summaries | approved |
| Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title,
Organization data. The FE-2977 title was confirmed by the owner |
approved |
| Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved |
| Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" |
approved |
| Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI
check | approved |
| Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale
| approved |
| Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for
serverless-animation | approved; re-approval pending on a one-line
follow-up (CodeRabbit approved) |
| Comfy-Org#19359 | FE-2974 | One typed redirect list that generates
`vercel.json` | approved |
| Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved |
| Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says |
approved |
| Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved |
| Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML |
approved |
| Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved |
| Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved
|
| Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift |
approved |
| Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles |
approved |
| Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page |
approved (a CodeRabbit changes-requested review is still open) |
| Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved |
| Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved |
| Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved |
| Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with
redirects | approved |
| Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing
| approved |
| Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved |
| Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page |
approved |
| comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and
routes `/hub/workflows` by manifest. Merged and live | merged |

These fixes exist only on this branch, because they only break once two
PRs meet:

- `scripts/check-models-html.ts` reads each page at `model.href` and
skips models without a page (f1df1e4).
- `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models`
(f87bb4c).
- `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made
it optional and Comfy-Org#19405 no longer typechecked (9783819).
- `ModelStatus` links a successor only when it has a page, for the same
reason on Comfy-Org#18899 (c4761d8).
- The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/`
instead of the `/models/` redirect (eb985b6). Its label still says
"Models" while the nav says "Hub".
- Twin, meta-description and entry tests use the hub pages and the new
tag set (86ac3b0, d4ffc0f).
- The render guard finds the catalogue through `getRoutes().workshop`,
and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f).
- A new test renders a real model page and checks its markdown twin has
the model's h1 (9a6c5cb).
- Main's newer catalogue and workflow e2e cases use the hub addresses
(2aeda77).
- `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of
main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer
exists (c28c7a7).

The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays
deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real
catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the
`WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's
figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing
tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer
builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test
imports `PROVIDER_NAMES` from its new home. The full table of 47
resolutions is in the integration report.

## Review Focus

- Launch rides along with the URL move. If launch should stay a separate
step, set `launchedModelPages` in
`apps/website/src/config/model-page-launch.ts` to `new Set()` before
merging.
- Main's Comfy-Org#19320 gives the catalogue island its own h1 through
`WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only
the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1.

- Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion
for serverless-animation). One of them should be closed once this lands.

## QA

- [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0
errors, eslint on `apps/website` clean, `pnpm knip` clean
- [x] Website unit: 547 files, 10347 passed, 4 skipped
- [x] Build A (`build:e2e`, CI env): 1193 pages; release gate,
`check:hreflang`, `validate:llms-txt-links` (225 links),
`validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html`
(148 pages) all pass
- [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on
build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no
Run, no Hub nav and no Firebase requests
- [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals
except redirect stubs, no hreflang in the sitemap
- [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed
on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network
isolation, render guard) all passed when rerun alone
- [x] Launch: 148 model pages indexable with canonicals, 149 hub entries
in the sitemap, 148 non-empty twins with the model h1, 148 in
`llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex
- [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307,
every /hub destination built
- [x] comfy-router#46 under `wrangler dev` in front of this build: 312
router tests pass; 148 old model URLs (both slash forms) 307 then 200;
30 workflow names served by the website and their old URLs 307; a
non-manifest workflow 302 with no-store; `manifest.json` passes through;
`/workflows/` and bare `/hub` unchanged
- [x] After the router deploys and this merges: purge Cloudflare, then
curl `https://comfy.org/hub/models/` for a 200 and three old
`/models/<slug>/` URLs for one 307 each
- [x] Rich Results Test on `/pricing/` and
`/learning/animations/character-sheet/`, then "Validate fix" on Merchant
listings and Videos
- [x] Rich Results Test on two live model pages: breadcrumbs valid and
the breadcrumb URL returns 200 with no redirect
- [x] GPTBot and Googlebot curls on the hub and one model page, then a
GSC live test on both
- [x] Resubmit the sitemap in Search Console and URL-inspect about 20
model pages on day 0 and day 14
- Not covered: Rich Results and GSC need production; the redirect matrix
used a local shim for `vercel.json`, since `astro preview` ignores it

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants