Skip to content

feat(website): move workflow pages to /hub/workflows (step B3): redirect every old URL (307 first, 308 after router #46, FE-3083) - #19424

Closed
MaanilVerma wants to merge 18 commits into
maanil/fe-2972-hub-redirectsfrom
maanil/fe-2972-hub-workflows
Closed

MaanilVerma wants to merge 18 commits into
maanil/fe-2972-hub-redirectsfrom
maanil/fe-2972-hub-workflows

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The 30 workflow pages move from /models/workflows/<name>/ to /hub/workflows/<name>/, and each old URL answers with one 307 straight to its new page. The site also publishes /hub/workflows/manifest.json, which comfy-router#46 fetches to decide who answers each /hub/workflows/* URL. For /workflows/* the router uses its own bundled copy.

Deploy together with comfy-router#46. Until the router reads the manifest, /hub/workflows/* keeps going to the workflows site.

Stacked on #19422 (step B2). Fixes FE-2972: https://linear.app/comfyorg/issue/FE-2972

Changes

  • The workflow pages build at /hub/workflows/[slug]. /models keeps only the showcase, apps and the page.json data files. Every workflow URL (routes, registry, redirects, card links and hubWorkflowPath) comes from one helper, hubWorkflowHref.
  • siteRedirects gets 30 rows (60 Vercel rules), temporary (307) like B2's model rows, since a 308 is cached by browsers and can't be retracted if the router change slips. vercel.json now has 853 redirects plus 4 headers, 857 of the 2,048 route limit.
  • /hub/workflows/manifest.json is built by a static endpoint and served as application/json. It's registered as reserved, so it stays out of the sitemap and gets no markdown twin. Its shape is { "version": 1, "defaultOwner": "workflows-site", "pages": [...sorted], "legacyRedirects": {} }.
    • pages comes from hub-workflow-names.json, the same list the redirects, the URL registry and the stale-link gate use. A file-snapshot test keeps it equal to the built pages, and the endpoint fails the build if they differ.
    • defaultOwner and legacyRedirects come from src/config/hub-workflows-routing.ts.
    • A zod schema validates the manifest during the build, so an invalid one fails the build.
  • Moving more workflows later: adding pages and flipping defaultOwner are data only, because /hub/workflows/* reads the live manifest. Redirecting an old /workflows/<slug>/ URL is not: the router reads legacyRedirects for /workflows/* from its bundled src/hub-workflow-manifest.js, so each entry also needs a router edit and redeploy. This is written up in apps/website/README.md ("Hub workflows routing"), along with the fetch contract: comfy-router#46 reads the manifest from the website origin directly and passes the public /hub/workflows/manifest.json through to the website.
  • Fix: the name list is imported with with { type: 'json' }, so Playwright can load it.

Safety

  • The manifest can't route all workflows to the website by accident. Every legacyRedirects key must be an exact /workflows/<slug>/ path (no wildcards, prefixes or nested paths), every target must be a /hub/workflows/<name>/ page the site builds, and defaultOwner must be workflows-site or website. Anything else fails the build.
  • It ships with defaultOwner: "workflows-site" and legacyRedirects: {}. Changing either is the reviewed migration step (noted in hub-workflows-routing.ts).
  • The website adds no /workflows/* redirects, and a redirect-list test asserts that no source starts with /workflows/.

Review Focus

  • Follow-up: after comfy-router#46 is live and verified on prod, flip the old model and workflow rows to permanent (drop temporaryBecause: HUB_ROUTER_PENDING in redirects.ts), run sync:redirects and redeploy.
  • Workflow pages stay noindex; lifting that is a feat(website): lift noindex on every canonical model page #19405 change.

@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 29, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 09c1319c-1cf2-4615-b4a0-779fb5e82836

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2160 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2139 / ❌ 0 / ⚠️ 0 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 356ea8f7073ae8a039be920ef0172bbcfdbf2f67

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19424.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-ljtcegs01-comfyui.vercel.app

Last updated: 2026-09-29T22:09:32Z for c61e5a3

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.8 MB heap
dom-widget-order-dense-n200-w200-i120: · 33.0 avg FPS · 30.1 P5 FPS ❌ (target: ≥52) · 377ms TBT · 80.2 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 43.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 160ms TBT · 85.2 MB heap
extension-clean-combined-draw: · 40.3 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 30ms TBT · 79.4 MB heap
extension-rgthree-prototype-draw: · 40.0 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 87ms TBT · 75.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
legacy-node-drag: · 59.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
subgraph-transition-enter: · 50.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 86ms TBT · 96.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.7 MB heap
vue-large-graph-idle: · 45.6 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 185.1 MB heap
vue-large-graph-pan: · 31.1 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 5ms TBT · 176.8 MB heap
vue-node-resize-workload: · 31.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 193ms TBT · 190.7 MB heap
vue-zoom-out-idle: · 36.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 177.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.9 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.6 MB heap
agent-composer-long-conversation-typing: · 56.5 avg FPS · 40.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 124.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 12
canvas-idle: task duration 325ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.8 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -164
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 653ms
canvas-mouse-sweep: script duration 120ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 73.3 MB
canvas-mouse-sweep: DOM nodes -229
canvas-mouse-sweep: event listeners -169
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 8ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 265ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 76.6 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 365ms
dom-widget-clipping: script duration 134ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 92.8 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 30ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 33ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 623ms
dom-widget-order-dense-n200-w200-i120: script duration 48ms
dom-widget-order-dense-n200-w200-i120: TBT 377ms
dom-widget-order-dense-n200-w200-i120: heap used 80.2 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 368ms
dom-widget-order-sparse-n1000-w20-i120: script duration 114ms
dom-widget-order-sparse-n1000-w20-i120: TBT 160ms
dom-widget-order-sparse-n1000-w20-i120: heap used 85.2 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 25ms
extension-clean-combined-draw: p95 frame time 42ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 6591ms
extension-clean-combined-draw: script duration 5285ms
extension-clean-combined-draw: TBT 30ms
extension-clean-combined-draw: heap used 79.4 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 25ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 6324ms
extension-rgthree-prototype-draw: script duration 5077ms
extension-rgthree-prototype-draw: TBT 87ms
extension-rgthree-prototype-draw: heap used 75.9 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 443ms
large-graph-idle: script duration 28ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.1 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1231ms
large-graph-pan: script duration 638ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.7 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1330ms
large-graph-zoom: script duration 615ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.7 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1495ms
legacy-node-drag: script duration 771ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.8 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 430ms
minimap-idle: script duration 28ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.8 MB
minimap-idle: DOM nodes -228
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 49
subgraph-dom-widget-clipping: task duration 314ms
subgraph-dom-widget-clipping: script duration 116ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 89.7 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 356ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.1 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -199
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 608ms
subgraph-mouse-sweep: script duration 83ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.7 MB
subgraph-mouse-sweep: DOM nodes -244
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 687ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 86ms
subgraph-transition-enter: heap used 96.2 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4492ms
viewport-pan-sweep: script duration 2192ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.7 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -71
vue-large-graph-idle: avg frame time 22ms
vue-large-graph-idle: p95 frame time 42ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11965ms
vue-large-graph-idle: script duration 184ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 185.1 MB
vue-large-graph-idle: DOM nodes -3046
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 32ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 115
vue-large-graph-pan: task duration 16402ms
vue-large-graph-pan: script duration 693ms
vue-large-graph-pan: TBT 5ms
vue-large-graph-pan: heap used 176.8 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14911
vue-node-resize-workload: avg frame time 31ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 60ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5014ms
vue-node-resize-workload: script duration 83ms
vue-node-resize-workload: TBT 193ms
vue-node-resize-workload: heap used 190.7 MB
vue-node-resize-workload: DOM nodes -4025
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 28ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6999ms
vue-zoom-out-idle: script duration 98ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 177.2 MB
vue-zoom-out-idle: DOM nodes -1523
vue-zoom-out-idle: event listeners -7458
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 5
workflow-execution: style recalc count 16
workflow-execution: task duration 107ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 77.9 MB
workflow-execution: DOM nodes 123
workflow-execution: event listeners 49
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 16ms
agent-composer-empty-conversation-typing: style recalc duration 80ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 483ms
agent-composer-empty-conversation-typing: script duration 180ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 87.6 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 18ms
agent-composer-long-conversation-typing: p95 frame time 25ms
agent-composer-long-conversation-typing: layout duration 21ms
agent-composer-long-conversation-typing: style recalc duration 236ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1095ms
agent-composer-long-conversation-typing: script duration 345ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 124.0 MB
agent-composer-long-conversation-typing: DOM nodes -3954
agent-composer-long-conversation-typing: event listeners -311
Raw data
{
  "timestamp": "2026-09-29T22:19:27.097Z",
  "gitSha": "269de08582b1ce20fd6807ca534817436e0428b5",
  "branch": "maanil/fe-2972-hub-workflows",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2019.7329999999738,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.2320000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 360.425,
      "heapDeltaBytes": -2383524,
      "heapUsedBytes": 76364852,
      "domNodes": -228,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 8.241999999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2009.0040000000045,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.373000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 289.421,
      "heapDeltaBytes": -22566456,
      "heapUsedBytes": 76403988,
      "domNodes": -228,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 8.122,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1705.0389999999425,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 14.576,
      "layouts": 12,
      "layoutDurationMs": 3.7300000000000004,
      "taskDurationMs": 654.8609999999999,
      "heapDeltaBytes": -1758828,
      "heapUsedBytes": 77033456,
      "domNodes": -230,
      "jsHeapTotalBytes": -262144,
      "scriptDurationMs": 122.23299999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1726.854000000003,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 14.281,
      "layouts": 12,
      "layoutDurationMs": 3.62,
      "taskDurationMs": 651.16,
      "heapDeltaBytes": -21971340,
      "heapUsedBytes": 76791116,
      "domNodes": -228,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 117.34100000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.3160000000162,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 8.515,
      "layouts": 6,
      "layoutDurationMs": 1.004,
      "taskDurationMs": 263.913,
      "heapDeltaBytes": 1694580,
      "heapUsedBytes": 80795652,
      "domNodes": 53,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 10.18,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.5780000000032,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 8.432,
      "layouts": 6,
      "layoutDurationMs": 1.086,
      "taskDurationMs": 265.71,
      "heapDeltaBytes": -18762564,
      "heapUsedBytes": 79839800,
      "domNodes": 53,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 10.278000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665048543689316,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 545.223999999962,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 4.024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.413,
      "heapDeltaBytes": 18293568,
      "heapUsedBytes": 97126800,
      "domNodes": 0,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 134.873,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 545.0149999999212,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.7370000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.815,
      "heapDeltaBytes": 18355652,
      "heapUsedBytes": 97428964,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 132.17000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1001.2669999999844,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 622.42,
      "heapDeltaBytes": 9343016,
      "heapUsedBytes": 85145116,
      "domNodes": 0,
      "jsHeapTotalBytes": 3309568,
      "scriptDurationMs": 47.512,
      "eventListeners": 0,
      "totalBlockingTimeMs": 377,
      "frameDurationMs": 30.303030303030305,
      "p95FrameDurationMs": 33.19999999999982
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1000.9469999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 623.41,
      "heapDeltaBytes": 7214252,
      "heapUsedBytes": 83139008,
      "domNodes": 0,
      "jsHeapTotalBytes": 4096000,
      "scriptDurationMs": 49.16,
      "eventListeners": 0,
      "totalBlockingTimeMs": 377,
      "frameDurationMs": 30.303030303030305,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 784.6409999999651,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 361.66100000000023,
      "heapDeltaBytes": 15569852,
      "heapUsedBytes": 89457108,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 112.30999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 23.03823529411765,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 800.8839999999964,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.962,
      "heapDeltaBytes": 15707948,
      "heapUsedBytes": 89256448,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 115.205,
      "eventListeners": 0,
      "totalBlockingTimeMs": 160,
      "frameDurationMs": 22.85428571428573,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7405.124999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6580.329,
      "heapDeltaBytes": 639412,
      "heapUsedBytes": 80957404,
      "domNodes": 0,
      "jsHeapTotalBytes": -9699328,
      "scriptDurationMs": 5246.608,
      "eventListeners": 0,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 25.083389830508477,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7338.039999999978,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6601.374000000001,
      "heapDeltaBytes": 4810752,
      "heapUsedBytes": 85515900,
      "domNodes": 0,
      "jsHeapTotalBytes": -6815744,
      "scriptDurationMs": 5323.867,
      "eventListeners": 0,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 24.52541806020067,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7038.830000000018,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.03300000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6316.478,
      "heapDeltaBytes": -14521268,
      "heapUsedBytes": 67531960,
      "domNodes": 0,
      "jsHeapTotalBytes": -12845056,
      "scriptDurationMs": 5051.295999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 25.208243727598564,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7020.698999999922,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.03799999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6330.983,
      "heapDeltaBytes": 11459464,
      "heapUsedBytes": 91647256,
      "domNodes": 0,
      "jsHeapTotalBytes": -17825792,
      "scriptDurationMs": 5103.115,
      "eventListeners": 0,
      "totalBlockingTimeMs": 62,
      "frameDurationMs": 24.79257950530035,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.0649999999841,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.536,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.75600000000003,
      "heapDeltaBytes": -37822268,
      "heapUsedBytes": 82347568,
      "domNodes": -228,
      "jsHeapTotalBytes": -622592,
      "scriptDurationMs": 27.337999999999994,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2014.1089999999622,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.855,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.84599999999983,
      "heapDeltaBytes": 21444332,
      "heapUsedBytes": 83450004,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 27.686999999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2108.060999999907,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.179,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1226.506,
      "heapDeltaBytes": 19077676,
      "heapUsedBytes": 82597320,
      "domNodes": 0,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 628.465,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666667,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2109.649999999988,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.06,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1235.91,
      "heapDeltaBytes": 19427048,
      "heapUsedBytes": 82346628,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 647.123,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665354330708663,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3141.369999999938,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.491999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.899999999999999,
      "taskDurationMs": 1330.489,
      "heapDeltaBytes": 9760888,
      "heapUsedBytes": 73181172,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 612.521,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66595744680851,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3160.6120000000146,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.459999999999999,
      "layouts": 60,
      "layoutDurationMs": 12.830000000000002,
      "taskDurationMs": 1329.925,
      "heapDeltaBytes": 9462360,
      "heapUsedBytes": 72897864,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 617.833,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66578947368421,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2203.901999999971,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.877999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1491.728,
      "heapDeltaBytes": 17218420,
      "heapUsedBytes": 81524872,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 767.395,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.79236641221374,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2284.4690000000583,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.312999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1499.0670000000002,
      "heapDeltaBytes": 17291176,
      "heapUsedBytes": 81650400,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 774.923,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.788235294117648,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.361999999982,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.6399999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.75699999999995,
      "heapDeltaBytes": 21063312,
      "heapUsedBytes": 83671680,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.326000000000004,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.4180000000488,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.6390000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.7639999999999,
      "heapDeltaBytes": 21098164,
      "heapUsedBytes": 83699064,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.058,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 515.7780000000685,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 5.571,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 310.59,
      "heapDeltaBytes": 12673676,
      "heapUsedBytes": 94083752,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 113.641,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664516129032254,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 516.8139999999539,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 5.8069999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 316.94599999999997,
      "heapDeltaBytes": 12399820,
      "heapUsedBytes": 94014540,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 117.40899999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.9909999999763,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.0959999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 361.811,
      "heapDeltaBytes": -15554256,
      "heapUsedBytes": 65726896,
      "domNodes": -244,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 7.523999999999999,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.0209999999142,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.244,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.029,
      "heapDeltaBytes": -2263100,
      "heapUsedBytes": 79224584,
      "domNodes": -244,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 7.198000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.8619999999673,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 15.277,
      "layouts": 16,
      "layoutDurationMs": 5.182,
      "taskDurationMs": 613.0310000000001,
      "heapDeltaBytes": -7938168,
      "heapUsedBytes": 73665436,
      "domNodes": -244,
      "jsHeapTotalBytes": -1048576,
      "scriptDurationMs": 84.742,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666667,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.5169999999816,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 14.579000000000002,
      "layouts": 16,
      "layoutDurationMs": 4.729,
      "taskDurationMs": 603.496,
      "heapDeltaBytes": -3960428,
      "heapUsedBytes": 76631100,
      "domNodes": -244,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 80.446,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 851.175000000012,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 22.464,
      "layouts": 5,
      "layoutDurationMs": 9.442,
      "taskDurationMs": 686.7569999999998,
      "heapDeltaBytes": 21400676,
      "heapUsedBytes": 100881028,
      "domNodes": 13667,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 21.195999999999998,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 86,
      "frameDurationMs": 19.767441860465116,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8180.039999999963,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 37.745,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4457.751,
      "heapDeltaBytes": -36111628,
      "heapUsedBytes": 84000200,
      "domNodes": -228,
      "jsHeapTotalBytes": 389120,
      "scriptDurationMs": 2155.3759999999997,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666191446028513,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8135.745000000043,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 31.612000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4525.585,
      "heapDeltaBytes": 16746712,
      "heapUsedBytes": 78875484,
      "domNodes": -228,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2229.374,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66618852459016,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14383.31299999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13775.15,
      "heapDeltaBytes": -24740992,
      "heapUsedBytes": 188007440,
      "domNodes": -3045,
      "jsHeapTotalBytes": 12836864,
      "scriptDurationMs": 204.55,
      "eventListeners": -14914,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.30650263620387,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10537.594000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10155.085,
      "heapDeltaBytes": -12153464,
      "heapUsedBytes": 200189756,
      "domNodes": -3046,
      "jsHeapTotalBytes": 13361152,
      "scriptDurationMs": 163.698,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.511423550087876,
      "p95FrameDurationMs": 33.30000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16638.67300000004,
      "styleRecalcs": 113,
      "styleRecalcDurationMs": 13.043,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16332.211000000001,
      "heapDeltaBytes": -15741028,
      "heapUsedBytes": 179943948,
      "domNodes": -3045,
      "jsHeapTotalBytes": 12566528,
      "scriptDurationMs": 690.9879999999999,
      "eventListeners": -14907,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.898279158699808,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16783.79999999993,
      "styleRecalcs": 117,
      "styleRecalcDurationMs": 12.996000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16471.98,
      "heapDeltaBytes": -4765808,
      "heapUsedBytes": 190917980,
      "domNodes": -3045,
      "jsHeapTotalBytes": 12349440,
      "scriptDurationMs": 694.962,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 32.42920696324952,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5030.537999999979,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.82899999999999,
      "layouts": 20,
      "layoutDurationMs": 21.185999999999996,
      "taskDurationMs": 4976.277,
      "heapDeltaBytes": 7801940,
      "heapUsedBytes": 204962472,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 82.723,
      "eventListeners": 0,
      "totalBlockingTimeMs": 193,
      "frameDurationMs": 31.26149068322981,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5092.409999999973,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.833,
      "layouts": 20,
      "layoutDurationMs": 20.803,
      "taskDurationMs": 5052.641,
      "heapDeltaBytes": -5842364,
      "heapUsedBytes": 194994340,
      "domNodes": -8049,
      "jsHeapTotalBytes": 14155776,
      "scriptDurationMs": 82.746,
      "eventListeners": 0,
      "totalBlockingTimeMs": 192,
      "frameDurationMs": 31.480864197530863,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7145.004999999969,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7052.634000000001,
      "heapDeltaBytes": -2936612,
      "heapUsedBytes": 183488304,
      "domNodes": 0,
      "jsHeapTotalBytes": -25690112,
      "scriptDurationMs": 97.89500000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.260079051383396,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7147.545000000036,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6945.714000000001,
      "heapDeltaBytes": -41839212,
      "heapUsedBytes": 188039588,
      "domNodes": -3046,
      "jsHeapTotalBytes": 4390912,
      "scriptDurationMs": 98.94500000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 26.74029850746268,
      "p95FrameDurationMs": 50
    },
    {
      "name": "workflow-execution",
      "durationMs": 474.7780000000148,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 20.884,
      "layouts": 5,
      "layoutDurationMs": 1.9009999999999998,
      "taskDurationMs": 140.133,
      "heapDeltaBytes": -14104928,
      "heapUsedBytes": 82602984,
      "domNodes": 133,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 18.9,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668965517241368,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 99.47399999998652,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.103000000000002,
      "layouts": 4,
      "layoutDurationMs": 1.344,
      "taskDurationMs": 72.896,
      "heapDeltaBytes": -16260100,
      "heapUsedBytes": 80843676,
      "domNodes": 113,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 4.712000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 473.82100000004357,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 77.444,
      "layouts": 76,
      "layoutDurationMs": 15.554,
      "taskDurationMs": 436.982,
      "heapDeltaBytes": 13477864,
      "heapUsedBytes": 91094884,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 156.85,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66785714285717,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 559.6199999999953,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 81.71499999999999,
      "layouts": 76,
      "layoutDurationMs": 16.746000000000002,
      "taskDurationMs": 528.889,
      "heapDeltaBytes": 14607492,
      "heapUsedBytes": 92693504,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 203.25799999999998,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66470588235295,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1048.720000000003,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 218.69,
      "layouts": 76,
      "layoutDurationMs": 21.187,
      "taskDurationMs": 1024.5739999999998,
      "heapDeltaBytes": 12104508,
      "heapUsedBytes": 139743080,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 316.543,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1194.262999999978,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 252.766,
      "layouts": 76,
      "layoutDurationMs": 21.258,
      "taskDurationMs": 1166.2079999999999,
      "heapDeltaBytes": -3447192,
      "heapUsedBytes": 120382664,
      "domNodes": -7983,
      "jsHeapTotalBytes": -3448832,
      "scriptDurationMs": 373.06,
      "eventListeners": -1498,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.749999999999986,
      "p95FrameDurationMs": 33.30000000000018
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52981 80724 65.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.3% 388
src/platform/workspace/stores/billingOperationStore.ts 8.0% 345
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.2% 252
src/core/webSessionIdentity.ts 3.4% 224

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@MaanilVerma

MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA

Check Proof Result
Preview: old workflow URLs, both slash forms, go through one 308 to a 200 curl on comfy-website-preview-pr-19424 (below) pass
30 workflow pages build under dist/hub/workflows; canonical = the new URL ls; href="https://comfy.org/hub/workflows/change-material/" pass
No page left under dist/models except the showcase and apps find dist/models -name index.html pass
No built page links to an old model or workflow address (the release gate also enforces it) grep over dist = 0 pass
Redirect rows +60 rules; 853 redirects + 4 headers = 857 of 2,048 pass
The router list matches the published pages hub-workflow-names.json (30 names) file-snapshot test pass
Touched tests / typecheck / eslint / oxfmt 251 passed / 0 errors / clean pass
Fix: the JSON import attribute lets Playwright collect the suite (it failed on all 4 shards in run 36577768105). #19421 and #19422 were checked too: they have no new JSON import and collect fine pnpm exec playwright test --list: Total: 664 tests in 81 files on B1, B2 and B3 pass
hubWorkflowPath builds /hub/workflows/<name>/ through hubWorkflowHref src/lib/hub tests pass
Preview: /hub/workflows/manifest.json is served as JSON with the right shape curl -D -: HTTP/2 200, content-type: application/json; charset=utf-8, version 1, defaultOwner workflows-site, 30 sorted pages, legacyRedirects {} pass
Manifest is out of the sitemap and gets no twin grep -c manifest dist/sitemap-0.xml = 0; no dist/hub/workflows/manifest.md pass
Manifest validation (wildcard, prefix, no trailing slash, nested, unbuilt target, target outside /hub/workflows, bad owner), pinned shipped config, pages = built pages, no /workflows/* redirect sources vitest: manifest 10 + redirects/registry/gate/hub-models 101 passed pass
One build after the change exit 0; 30 pages + manifest.json under dist/hub/workflows; old-href grep = 0 pass
/models/workflows/change-material -> 308 /hub/workflows/change-material/ -> 200
/models/workflows/change-material/ -> 308 /hub/workflows/change-material/ -> 200
/models/workflows/remove-background/ -> 308 /hub/workflows/remove-background/ -> 200
/models/bfl--flux-2-max--generate-images/ -> 308 /hub/models/flux-2-max-text-to-image/ -> 200

Round 2 (7821cc8, merges #19422): the website-unit failure (run 36580239960) was llms-txt.test.ts > covers every static page, which treated /hub/workflows/manifest.json as a page that needed an llms.txt link. It's now excluded next to /models/catalogue.json. The merge also combines the old-link guard: workflows plus /models plus absolute hrefs. Proof: unit tests 118 passed; typecheck 0 errors; one build; playwright test api-keys-onboarding canonical-redirects = 8 passed.

Round 3 (Ben's review; ca15caa and de902dd merge #19422, 1a27a03 fixes):

Check Proof Result
Workflow rows ship as 307 vercel.json: 853 redirects, 64 permanent, 789 temporary; all 60 /models/workflows/* rules temporary pass
Workflow row test goes red if made permanent dropping temporaryBecause from the workflow rows: 2 failing (drift + the change-material 307 case); restored: passing pass
One workflow-page list registry, stale-link gate and redirects all use hubWorkflowSlugs; same 30 names as the old displaySlugs path, vercel.json unchanged pass
Redirect, hub-models, registry, manifest, llms-txt, workflow-detail, names and gate tests vitest: 93 passed pass
One build after the merge WORKSHOP_IN_BUILD=1 astro build: complete, the release gate passed pass
typecheck 0 errors pass

The preview was still on the previous deploy when I checked (308), so it does not reflect this round yet.

Round 3b (ead8376, merges #19422 at 45bd0e1): clean merge. Proof: the 9 affected test files pass (106 tests). Typecheck: 0 errors. PR is MERGEABLE.

Round 4 (1074f98, cascade, merges #19422 at acd5f67): registry roots are /models, /hub/models and /hub/workflows. #19360's kill-switch gate test now drops /hub/workflows/[slug], since /models/[...slug] no longer exists here. Proof: website vitest 9900 passed; typecheck 0 errors; eslint, oxlint and knip clean; builds with Workshop on and off both pass the gate; vercel.json has 853 redirects, 782 hub-bound, 0 of them permanent, and the minimax rows are 307; every hub destination exists in dist.

Round 5 (963d4a7, cascade, merges #19422 at d92f80e): clean merge, bringing in the recorded-name drift check from #19369. Proof: regenerating the URL map changes nothing; URL map, redirects and registry tests: 89 passed; typecheck 0 errors; one build, the gate passed; sync:redirects leaves vercel.json unchanged, with 853 redirects, 782 hub-bound, 0 of them permanent, and all four minimax rows permanent: false (307).

Round 6 (e441a70, cascade, merges #19422 at a531ba3): clean merge, bringing in the string-escaping fix from #19369. Proof: regenerating the URL map changes nothing; sync-vercel-redirects leaves vercel.json unchanged, with 782 hub-bound redirects, 0 of them permanent, and all four minimax rows permanent: false (307); URL map, redirects and hub-models tests: 68 passed; typecheck 0 errors.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/website/src/config/hub-workflows-manifest.ts 83.33% 1 Missing and 1 partial ⚠️
@@                       Coverage Diff                        @@
##           maanil/fe-2972-hub-redirects   #19424      +/-   ##
================================================================
+ Coverage                         84.13%   84.16%   +0.03%     
================================================================
  Files                              3204     3206       +2     
  Lines                            155914   155874      -40     
  Branches                          42224    42212      -12     
================================================================
+ Hits                             131172   131187      +15     
+ Misses                            23031    22975      -56     
- Partials                           1711     1712       +1     
Flag Coverage Δ
e2e 65.63% <ø> (+<0.01%) ⬆️
unit 81.42% <ø> (ø)
website-unit 79.11% <92.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/hub-models.ts 100.00% <100.00%> (ø)
apps/website/src/config/hub-workflows-routing.ts 100.00% <100.00%> (ø)
apps/website/src/config/models-url-registry.ts 100.00% <100.00%> (ø)
apps/website/src/config/redirects.ts 100.00% <100.00%> (ø)
apps/website/src/config/workshop-workflow-pages.ts 76.00% <ø> (ø)
.../website/src/integrations/workshop-release-gate.ts 94.73% <ø> (ø)
apps/website/src/lib/hub/workflow-detail.ts 75.86% <100.00%> (+0.42%) ⬆️
apps/website/src/config/hub-workflows-manifest.ts 83.33% <83.33%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 10 finding(s).

Severity Count
🟡 Medium 4
🟢 Low 5
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

Comment thread apps/website/src/config/hub-models.ts Resolved
Comment thread apps/website/src/config/redirects.ts Resolved
Comment thread apps/website/src/config/hub-models.ts Resolved
Comment thread apps/website/src/config/hub-models.ts Resolved
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 10:07pm UTC
billing-web-test Ignored Ignored Sep 29, 2026 10:07pm UTC

Request Review

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Integration check: URL stack + content stack combined

Throwaway local branch, never pushed: this PR's tip (6804ccb977) with maanil/fe-2942-model-page-ssr (#18899, which carries #18891) merged in, then maanil/fe-2950-catalogue-ssr (#18898). One WORKSHOP_IN_BUILD=1 build, then tested against that build.

Short version: once combined, the model and catalogue pages have real content at their /hub addresses. All 9 conflicts are in tests or test helpers, and routes/models/[slug].astro merged on its own with both the /hub routing and the SSR ModelPage branch intact. Two helper scripts still read the old dist/models/ folder and need a one-line fix each (see below). #19405 does not merge cleanly, so I left it out.

Conflicts and how I resolved them

# Merge File What clashed Resolution
1 #18899 e2e/workshop-input-feedback.spec.ts URL side moved the goto to /hub/models/flux-pro-1-1-ultra-text-to-image/, content side added waitForIsland before opening Advanced Kept both: the hub URL plus the island wait
2 #18899 e2e/workshop-loading-flash.spec.ts URL side looped ['/hub/models/', MODEL_PATH], content side dropped MODEL_PATH because the model page is now SSR ['/hub/models/']. The model page is covered by "paints the model, not a loader"
3 #18899 e2e/workshop-visibility.spec.ts (4 hunks) URL side asserted the old gated behaviour at /hub paths, content side rewrote the file to "content visible, Run hidden" Took the content-side tests and moved their paths to /hub/models/. The related link expectation is now /hub/models/flux-2-pro-text-to-image/. Removed MODEL_PATH from the "HTML has no model-hero" list, since SSR renders it now
4 #18899 src/components/workshop/ModelsPage.test.ts URL side edited the flag-enable test, content side replaced it with a flag table Took the table and changed the expected href from /models?useCase=generate-images to /hub/models/?useCase=generate-images
5 #18898 e2e/models-catalogue-corrections.spec.ts URL side used the hub URL regex, catalogue side scoped the click to workshop-models-grid because the directory repeats the link Kept both
6 #18898 e2e/workshop-loading-flash.spec.ts #18898 sits beside #18899, not on top of it, so it still expects a model page that shows only the loader. It also adds a catalogue SSR test Dropped the model-page loader test because it contradicts #18899. Kept the catalogue test, pointed at /hub/models/ with a /hub/models/<slug>/ href regex
7 #18898 e2e/workshop-visibility.spec.ts (no-JS block) Catalogue side added the directory tests and looped ['/models/', MODEL_PATH] Kept the directory tests at /hub/models/ and looped ['/hub/models/'] only, because the model page no longer shows the Grok fallback
8 #18898 src/integrations/markdown-twins.ts URL side re-keyed ALTERNATE_TWIN_SOURCES to hub/models, catalogue side deleted the alternate-source mechanism Took the deletion. The catalogue page now has its own content
9 #18898 src/lib/markdown-twin.test.ts Same as #8 Took the "twin from the catalogue page itself" test and moved it to hub/models paths and the new slug

These two needed a fix even though git didn't flag them:

  • scripts/check-models-html.ts:11,13 reads dist/models/<old slug>/index.html and fails with ENOENT once the pages live at dist/hub/models/<new slug>/. Fix: join(DIST, model.href, 'index.html') and label errors with model.href.
  • e2e/fixtures/modelsCatalogue.ts:5,9-10 reads dist/models. It must read dist/hub/models. Otherwise publishedModelSlugs finds no pages and the fixture throws.

#19405 (lift model noindex) conflicts in src/config/indexing.test.ts and routes/models/[slug].astro. isIndexableModelPage also classifies pages by their old /models/... paths, so it needs a rebase onto the URL stack before it can land. I skipped it.

Checks

Check Result
pnpm build (WORKSHOP_IN_BUILD=1), including the release gate's "no links to old /models addresses" Pass
check:models-html as written Fail: ENOENT on dist/models/... (the path issue above)
check:models-html with the path moved to /hub/models Pass, 148 model pages
validate:jsonld Pass, 947 pages
check:hreflang Pass
validate:llms-txt-links Pass, 225 links
Unit tests for the conflicted files and src/config Pass, except llms-txt.test.ts "covers every static page" (/hub/workflows/manifest.json). That test already fails in this PR's own CI, so the merge didn't cause it

Built HTML (template, noscript and script stripped)

  • Model pages: all 148 exist under dist/hub/models/<slug>/. Each has exactly 1 h1 and it matches the model name (0 mismatches). None contain "Grok Imagine in ComfyUI". All 148 canonicals point at https://comfy.org/hub/models/<slug>/. They are all still noindex, nofollow, which is expected until feat(website): lift noindex on every canonical model page #19405 lands.
  • Catalogue (/hub/models/): the h1 is "ComfyUI models". The directory has 148 unique /hub/models/<slug>/ links, the same set as the registry, and 0 old /models/<slug>/ links. The canonical is https://comfy.org/hub/models/ and there is no robots meta, so it is indexable.
  • Workflow pages (/hub/workflows/<name>/): all 30 have 0 h1 in the live DOM, just the loader. Raw HTML has 2 "Grok Imagine in ComfyUI" h1s, one in the fallback template and one in noscript, so a no-JS crawler still sees the Grok fallback. That's expected because workflow SSR isn't built yet. Canonicals are correct and all 30 are noindex.
  • The old dist/models/<old slug>/ folders now hold only page.json. Redirects to the new pages come from vercel.json.

E2E against this build (desktop, astro preview)

Spec Result
canonical-redirects 5/5
workshop-input-feedback 10/10
models-catalogue-corrections 3/3
workshop-loading-flash 5/6
workshop-visibility 6/8
models-render-guard Doesn't exist on this branch

The 3 failures all stop at the same line, run-rollout-note not found. In each one the model h1 and model-detail checks earlier in the test passed. My build didn't set PUBLIC_WORKSHOP_ROUTER_RUN=1 (CI's e2e build does), and without it canRunModel is false and the Run gate shows unavailable instead of rollingOut. So this comes from my local setup, not from the merge.

Real integration breaks: only the two dist/models path helpers above. No product code broke.

…to maanil/fe-2972-hub-workflows

# Conflicts:
#	apps/website/src/config/hub-models.test.ts
#	apps/website/src/config/hub-models.ts

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Clean, well-factored step: one hubWorkflowHref helper drives routes, registry, redirects and card links; the manifest is schema-validated at build time; the sitemap/markdown-twin/llms.txt exclusions all fall out of modelsUrlKind rather than a second hand-maintained list. I traced the page.json data path (ModelsPage.vue still keys off the workflows/<name> slug prop, so /models/workflows/<name>/page.json keeps working and the feature gate keeps gating) and the build gates (unregisteredModelsPaths, oldModelLinks, isWorkshopRoute) — those all hold.

The one thing I'd not merge without a clear answer is deploy ordering.

Severity Count
BLOCKER 1
SHOULD FIX 2
TRIVIAL 4

BLOCKER

The 308s ship before the router can honour them. redirects.ts emits permanent: true for all 30 old URLs. The description states /hub/workflows/* keeps going to the workflows site until comfy-router#46 lands, so a website-first deploy permanently redirects 30 live URLs at a destination this origin doesn't own yet. 308s are cached hard — and this list already carries 'a campaign link; a 301 stuck in the edge cache (#18611)' as evidence the team has been burned by exactly this. SiteRedirect.temporaryBecause makes the 307 one line; flip to 308 in the follow-up. If the deploys are atomic, say so and this goes away.

Mitigating: these pages are noindex and behind the workflows flag, so there's no SEO exposure — the exposure is flagged users and cached redirects, not crawlers.

SHOULD FIX

  • /hub/workflows/manifest.json is not in the manifest's own pages, so a router honouring defaultOwner: 'workflows-site' routes the manifest's public URL to the workflows site. Fine if #46 reads it from the website origin directly — but that contract isn't written down anywhere.
  • llms-txt.test.ts:169 matches path.includes('/workflows'), which will catch /hub/workflows/* and validate it against the external workflows-app route shapes. Harmless while these pages are noindex; breaks when #19405 lifts that.

TRIVIAL

Two derivations of "which workflow pages exist" (hub-workflow-names.json vs displaySlugs); a change-detector test pinning the shipped routing defaults; the kind === 'redirect' throw sharpening a build edge; the hubWorkflowPath = hubWorkflowHref alias conflating name and slug.

Verified, no issue

  • Registry collisions, alias→page resolution, and the /models/workflows/<name>/page.json reserved entries all still line up.
  • manifest.json doesn't collide with /hub/workflows/[slug] (not in getStaticPaths).
  • routePattern.startsWith(HUB_MODELS_PATH) correctly sends /hub/workflows/[slug] down the workflow branch.
  • HubBrowse.vue (the one place emitting /hub/workflows/ links for all 610 hub templates) is unreferenced by any page, so the "links to workflows the site doesn't build" concern isn't live.
  • Manifest zod guards (wildcard/prefix/no-trailing-slash/nested/unknown-target/unknown-owner) are all covered by tests and are genuinely airtight for the safety claim in the description.

Comment thread apps/website/src/config/redirects.ts Resolved
Comment thread apps/website/src/config/hub-models.ts Resolved
…to wt-2972b3-review

# Conflicts:
#	apps/website/src/config/hub-models.ts
#	apps/website/src/config/redirects.test.ts
#	apps/website/src/config/redirects.ts
#	apps/website/vercel.json

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — all seven threads addressed, approving

Scoped to 1a27a032f plus the two base-branch merges. I verified each fix against the tree rather than taking the replies at face value.

Thread Verified
BLOCKER: 308 before the router lands Fixed (via B2 merge). All 60 /models/workflows/* rules are permanent: false; every hub-destined redirect in vercel.json is temporary (64 permanent / 789 temporary / 853 total, and the only non-/models temporaries are the four pre-existing ones). HUB_ROUTER_PENDING names the exact flip condition, and redirects.test.ts asserts permanent: false on the workflow row under a test name that cites comfy-router#46 — so a silent regression back to 308 fails the suite.
Manifest reachability Documented in README.md and on the endpoint: #46 fetches from the website origin directly and passes the public path through. Cross-repo contract, so documentation is the right resolution.
llms-txt.test.ts /workflows matcher Fixed exactly as suggested. /hub/workflows/<name> now falls through to the normal matcher, and /hub/workflows/[slug] is in dynamic via modelsBuildRoutes, so the #19405 noindex lift won't trip it.
Two sources of truth for the workflow list Fixed, and better than I asked: the registry now derives from hubWorkflowSlugs instead of displaySlugs(['CLOUD','SERVERLESS']), so the registry, the redirects and the stale-link gate all read the same list the page builder reads. Strictly safer — a disabled or uncatalogued CLOUD entry can no longer be registered as a workflow page that nothing builds.
Change-detector test Removed; intent moved into the hub-workflows-routing.ts doc comment.
kind === 'redirect' throw Agreed, no change needed.
hubWorkflowPath / hubWorkflowHref conflation Fixed — hubWorkflowPath takes a template name, hubWorkflowHref takes a workflows/<name> page slug, and the two shapes no longer alias.

Nothing new found in the fix commit. No new findings this round.

Two notes, neither blocking

  • The 307 flip lives in the base PR (#19422), not this one. That's the right place — it applies to every hub redirect — but it means the "flip to permanent once #46 is live on prod" follow-up is tracked over there. Worth making sure that item doesn't get lost when B2 merges, since it's now the only thing standing between this stack and a permanent redirect.
  • CI on de902ddd7 was still running when I looked (no failures, but website-unit and website-build hadn't reported). The registry source swap is the one change that would show up as a build-gate failure rather than a unit failure, so worth a glance at website-build before merging.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third pass — base-branch merge only, approval stands

ead837695 is a merge of maanil/fe-2972-hub-redirects (a6e8610cc3 → 45bd0e1edf) with no authored changes. Additions/deletions/files are unchanged at 639/39/26. Since my approval rested on a fix that lives in the base PR, I re-checked the invariants rather than assuming the merge was inert:

  • All 60 /models/workflows/* rules are still permanent: false; 853 redirects total, no rule touching a page.json path.
  • The registry still derives workflows from hubWorkflowSlugs (models-url-registry.ts:127), not displaySlugs.
  • The llms-txt.test.ts /workflows matcher fix is intact.

The base merge brings hubModelHref throwing for unbuilt slugs, href becoming optional on RouterWorkshopModel, and modelSlides filtering hrefless models. None of it touches the workflow path: WorkflowWorkshopModel.href stays required, hubModelHref has exactly one caller and it is guarded by isWorkshopModelDisabled, and the base's workshop.spec.ts edit is in a different describe block from this PR's. Clean merge.

One non-blocking observation, really for #19422

The base replaced the old "never adds a /models catch-all" assertion with a much better guard — sourcePattern() turns each redirect source into a regex and asserts no redirect swallows a data path. But dataPaths is built only from modelPageUrls:

const dataPaths = [
  '/models/catalogue.json',
  ...modelPageUrls.map(({ oldSlug }) => `/models/${oldSlug}/page.json`)
]

The workflow pages this PR moves to /hub/workflows/<name>/ still fetch their data from /models/workflows/<name>/page.json (fetchModelsPage builds it from the workflows/<name> slug prop), and those paths aren't in dataPaths. The test name even says "since /hub/models pages fetch it" — it predates the workflow move.

No live exposure: every source is literal today, and llms-txt.test.ts:210 independently enforces that. It matters for the future the PR description sets up — 857 of 2,048 routes used, with 60 of those being these workflow rules. Collapsing them into one /models/workflows/:name* rule is the obvious route-budget move later, and that would break every workflow page's data fetch with this guard staying green.

hubWorkflowSlugs is already exported and redirects.test.ts already imports from ./hub-models, so it's one line:

  ...hubWorkflowSlugs.map((slug) => `/models/${slug}/page.json`)

Fine as a follow-up on #19422 rather than here, since the guard is that PR's code.

…orkflows

# Conflicts:
#	apps/website/e2e/workshop-workflow-runs.spec.ts
#	apps/website/src/config/llms-txt.test.ts
#	apps/website/src/config/models-url-registry.test.ts
#	apps/website/src/config/models-url-registry.ts

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fourth pass — base merge with real adaptation, approval stands

1074f9822 merges maanil/fe-2972-hub-redirects (45bd0e1edf → acd5f676b2), which pulled in a large amount of unrelated work. Unlike the last merge this one was not inert — the diff grew 639/39 → 648/48 — so I checked rather than assumed.

Every core B3 file is unchanged from what I approved. Only two test files grew, both correct adaptations to base refactors:

  • The base changed buildModelsUrlRegistry to take an explicit roots argument instead of a hardcoded isUnderModels. B3 threads HUB_WORKFLOWS_PATH through as a third root and updated models-url-registry.test.ts to match. I checked there's no leftover hardcoded root list — unregisteredModelsPaths reads registry.roots, so built /hub/workflows/* pages are still gate-checked.
  • The base added a "every declared models route actually built" assertion. B3 retargeted it from /models/[...slug] to /hub/workflows/[slug], so the new route is now covered by that guard too. Nice side effect of the merge.
  • navigableKinds (new in the base) includes 'workflow', so the /models/workflows/<name> → /hub/workflows/<name>/ aliases still resolve. 'reserved' is not navigable and nothing aliases the manifest, so that's consistent.

I verified the riskiest interaction by hand, since CI hadn't reached website-unit/website-build. The base churned workshop-display.json (56 lines) and workshop-workflows.jsonl (54 lines) — the two files that feed workflowModels, which hub-workflow-names.json snapshots. I recomputed all four gates in workflowPagesFor (missing catalog entry, type mismatch, status === 'unavailable', isWorkshopModelDisabled) against the new data: all 30 entries survive and the resulting names match the snapshot exactly, with nothing on either side. So neither the snapshot test nor the build-time endpoint guard will fire. Redirect permanence also re-confirmed: 853 rules, 60 workflow rows, all permanent: false.

One new thing, non-blocking, root cause in the base

The base rewrote the llms.txt route collection:

for (const { pattern } of modelsBuildRoutes(false))
  if (!pattern.includes('[')) staticPages.add(pattern)
const modelsPages = new Set([
  ...workshopPagePaths.map((slug) => `/models/${slug}`),
  ...appPagePaths().map(({ params }) => `/models/apps/${params.app}`)
])

Two consequences for this PR:

  1. Dynamic modelsBuildRoutes patterns are no longer pushed into dynamic. The round-2 fix here (path.startsWith('/workflows') instead of .includes) correctly stops /hub/workflows/... being judged against the external workflows-app shapes — but the matcher it now falls through to no longer has an entry for /hub/workflows/[slug]. So the trap that fix was meant to close is open again, just one layer further down.
  2. modelsPages is built from /models/${slug}, i.e. the addresses this PR turns into redirect sources. After this PR the real pages are /hub/workflows/<name>/.

Nothing breaks today — llms.txt links exactly one path in this space (/hub/models/, a static pattern), and the workflow pages are noindex so coverage doesn't demand them. It bites on #19405 when noindex lifts, which is the next step in this sequence. Cheap fix in the same spirit as the other cleanups here:

  ...workshopPagePaths.map(hubWorkflowHref),

Worth raising on #19422 alongside the still-open dataPaths gap from my last pass, rather than expanding this PR.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fifth pass — base merge only, approval stands

963d4a7aa merges the base (acd5f676b2 → d92f80e330), a tightly scoped change: model-urls.ts regenerated plus its generator and MODEL_URL_MAP.md. No authored changes here; B3's diff is byte-for-byte identical to what I approved across all eight core files, and the 60 workflow redirects are still permanent: false.

One thing was worth chasing. model-urls.ts churned 302/149, and vercel.json is generated from it — but vercel.json did not change in that base step. That is exactly the shape of a stale-generated-file bug, so I checked rather than assumed:

  • Every (oldSlug → newSlug) page pair and every (alias → newSlug) pair is semantically identical across the step. Zero added, zero removed, zero retargeted. The churn is a pure generator reformat.
  • End-to-end validation of the redirect table against its inputs: 391 expected /models/* sources (1 root + 148 model pages + 212 aliases + 30 workflows), 391 actual, nothing missing, nothing extra, no wrong destinations, 30 workflow rows.

So no drift, and vercel.json correctly did not need regenerating.

Worth noting as a good sign: the base's rewritten generator now documents the boundary explicitly — "The /models/workflows/<name>/ pages are not in this table: they move to /hub/workflows/<name>/ from their own list in FE-2972 B3." The two lists are deliberately disjoint, and buildModelsUrlRegistry's duplicate-path check would catch it if they ever weren't.

Still open, both on #19422

Neither was touched by this base step, as expected:

  1. redirects.test.ts — dataPaths in the model page data guard still covers only modelPageUrls, not the /models/workflows/<name>/page.json paths these pages fetch.
  2. llms-txt.test.ts:139 — modelsPages is still built from /models/${slug}, the addresses this PR turns into redirect sources, and dynamic modelsBuildRoutes patterns are still unregistered. Latent until #19405 lifts noindex.

Neither blocks this PR. CI had not reached website-unit/website-build when I looked, with no failures so far.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sixth pass — base merge only, approval stands

e441a703d merges the base (d92f80e330 → a531ba39f6). The base change is two files, both in the model URL map generator: generate-model-url-map.ts (+10) and its test (+28). No authored changes here, and B3's diff is byte-for-byte identical to what I approved, including all 302 lines of vercel.json. The 60 workflow redirects are still permanent: false.

One thing was worth checking. The base rewrote how the generator emits string literals — it now picks the quote character by frequency and escapes via JSON.stringify rather than a naive replace(/[\\']/g, '\\$&'). generate-model-url-map.test.ts:78-81 asserts the committed model-urls.ts and MODEL_URL_MAP.md equal generator output exactly, so a change in emission with no regeneration would fail CI on this PR.

The two emitters diverge only when a value contains an apostrophe, a double quote, or a backslash — the old one always single-quoted and escaped ', the new one would switch to ". I checked the committed data: zero values contain any of those characters. Old and new output byte-identical for the current table, so model-urls.ts correctly needed no regeneration and the drift test passes. The change is a latent-correctness fix for strings the data does not yet contain.

Still open, both on #19422

Untouched by this base step, as expected:

  1. redirects.test.ts — dataPaths in the model page data guard still covers only modelPageUrls, not the /models/workflows/<name>/page.json paths these pages fetch.
  2. llms-txt.test.ts:139 — modelsPages still built from /models/${slug}, and dynamic modelsBuildRoutes patterns still unregistered. Latent until #19405 lifts noindex.

Neither blocks this PR. CI had not reached the website jobs when I looked, with no failures so far.

For what it's worth: this is the fourth consecutive re-review on a base merge with no changes to this PR's own code. B3 has been stable since 1a27a032f. If the stack is just waiting on #19422 to land, there is no need to re-request review on each merge — I will re-check if B3 itself changes or if #19422's shape shifts under it.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seventh pass — no new commits, but CI has a real gap worth closing before merge

To be precise: the head is still e441a703d, the base tip is still a531ba39f6, and the merge-base is unchanged. No commits were pushed since my last pass, and B3's diff is byte-for-byte identical. So there was nothing new to read.

But checking CI turned up something concrete, and it partly walks back the "no need to re-request" note I left last round — there is something left to do, it just isn't code.

The current head has essentially no CI

On e441a703d: 18 check runs total, 3 actually executed (Socket x2, Vercel comments), 12 stuck in queued since 20:44:41Z, never reaching in_progress. For contrast, 7821cc859 earlier in this PR had 125 check runs with 28 executed. The changes path-filter jobs are queued, and since website-unit, website-build, website-e2e, lint and typecheck are all gated behind changes, they were never created at all — which is why they read as absent rather than pending.

So the green-looking check list on this PR is external integrations and skips, not gates.

What that leaves unvalidated, specifically

Tracing the website gates across every head since the fix commit:

head website-unit website-build
1a27a032f never ran never ran
de902ddd7 cancelled cancelled
ead837695 success success
1074f9822 cancelled absent
963d4a7aa cancelled cancelled
e441a703d absent absent

The last genuinely green run was ead837695. That is good news for most of this PR — it covers the round-2 fixes (the hubWorkflowSlugs registry swap, the llms-txt matcher change, the hubWorkflowPath split, the removed change-detector test).

The gap is narrow but real: the base step at 1074f9822 refactored buildModelsUrlRegistry to take an explicit roots argument and added the route-parity assertion, and B3 adapted two test files in response. Those adaptations landed after the last green run:

  • models-url-registry.test.ts — 9 changed lines at the green run, 23 now
  • workshop-release-gate.test.ts — 5 changed lines at the green run, 9 now

I reviewed both by reading and they look correct — roots threaded through as a third entry, registry.roots consumed by unregisteredModelsPaths, route patterns retargeted to /hub/workflows/[slug]. But test adaptations to a refactored helper signature are exactly the sort of thing that fails on a detail, and these two files have never executed in their current form.

Recommendation: get website-unit and website-build green on the current head before merging. Re-running the queued workflows should be enough — this looks like a stalled runner queue, not anything about the change. My approval stands on the code; I just would not treat the current check list as evidence it passes.

Still open, both on #19422

  1. redirects.test.ts — dataPaths covers only modelPageUrls, not the /models/workflows/<name>/page.json paths these pages fetch.
  2. llms-txt.test.ts:139 — modelsPages built from /models/${slug}, dynamic modelsBuildRoutes patterns unregistered. Latent until #19405 lifts noindex.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eighth pass — base merge only; the CI gap I flagged is clearing on its own

Closing out my last comment, since leaving "the current head has essentially no CI" as the last word would be misleading now.

The runner queue has cleared. On 7107801e1: 38 check runs, 18 passing, 16 pending, zero failures. UNSTABLE is just pending checks, not a failure. More to the point, the website workflows are genuinely scheduled and moving on this head:

  • CI: Website E2E — in progress
  • CI: Website Build — queued
  • CI: Website Unit — queued
  • CI: Vercel Website Preview — success

That is a real change from last round, where nothing had even been created and the queue sat stalled with zero progress. The website-unit / website-build check runs haven't materialised yet only because their changes gate job is still working through the queue inside those runs. No action needed — the untested window I flagged should close by itself. Still worth a glance at website-unit and website-build before merge, for the two test files that adapted to the roots refactor after the last green run.

The base change is one file and does not touch this PR. generate-model-url-map.test.ts gained three round-trip cases for the string-literal emitter — 'Veo "3" Text-to-Video', 'back\\"quote', and "''\\\"". Those are well-chosen: they exercise exactly the branches where the new stringLiteral helper could go wrong (quote-frequency selection, and the JSON.stringify then .replace(/\\"/g, '"') round trip with a backslash immediately before a quote). I traced all three by hand and they round-trip correctly.

Good follow-through, too — last round I noted the emitter rewrite was "a latent-correctness fix for strings the data does not yet contain," and this adds the coverage for exactly those latent paths rather than leaving them untested.

model-urls.ts, MODEL_URL_MAP.md and vercel.json are all untouched, confirming no regeneration was needed. B3's diff is byte-for-byte identical across every file including all 302 lines of vercel.json, the 60 workflow redirects are still permanent: false, and there are no unresolved threads.

Still open, both on #19422

  1. redirects.test.ts — dataPaths covers only modelPageUrls, not the /models/workflows/<name>/page.json paths these pages fetch.
  2. llms-txt.test.ts:139 — modelsPages built from /models/${slug}, dynamic modelsBuildRoutes patterns unregistered. Latent until #19405 lifts noindex.

comfy-router reads legacyRedirects for /workflows/* from its bundled
manifest, not the live one the website publishes.
@MaanilVerma MaanilVerma changed the title feat(website): move workflow pages to /hub/workflows with a 308 from each old URL (step B3) feat(website): move workflow pages to /hub/workflows (step B3): redirect every old URL (307 first, 308 after router #46, FE-3083) Sep 29, 2026
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

QA (b30a4e2): built with the CI e2e env (WORKSHOP_IN_BUILD=1 PUBLIC_WORKSHOP_ROUTER_RUN=1 WEBSITE_INDEXABLE=1 PUBLIC_WORKSHOP_CLOUD_ENV=test), and the release gate passed. vercel.json has 853 redirects: 782 hub-bound, 0 permanent. /minimax and /minimax/ are 307. list:models-pages now covers 149 hub/models + 30 hub/workflows. e2e/workshop.spec.ts passed 33/33 on port 4620. README and hub-workflows-routing.ts now say a /workflows/* redirect also needs a router edit and redeploy. Unit tests 80/80, typecheck, eslint and knip pass.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ninth pass — CI finally ran, the untested window is closed, and the one failure was not this PR

First authored commit in five rounds (b30a4e2fb, docs only) plus a base merge. Three things actually happened.

1. The round-7 gap is closed

website-unit and website-build both succeeded on 7107801e1. That matters specifically because the two test files that adapted to the base's roots refactor — the ones I flagged as never having executed — are byte-identical between that head and this one:

file at green head now content
models-url-registry.test.ts 23 changed lines 23 identical
workshop-release-gate.test.ts 9 changed lines 9 identical

So the adaptation I could previously only verify by reading has now actually run green. Withdrawing that caveat.

2. The one e2e failure is #19422's, and it is already fixed here

website-e2e failed on 7107801e1 — the first real failure in this sequence. Shards 1, 2 and 3 passed; only shard 4 failed, on exactly one test:

workshop.spec.ts:406 › Models catalog › a static compatibility alias reaches its canonical model page
  > 410 |     expect(response?.status()).toBe(200)

That is the models alias test doing page.goto('/models/bfl--flux-2-max/') and expecting to land on the hub page. It broke because of the 307 flip — the thing I asked for in round 1. Following a temporary redirect to a /hub/models/* URL the router does not own yet does not resolve in preview.

The base already fixed it, and the fix is in this head: the test is now an old alias address redirects temporarily to its canonical model page, asserting the vercel.json row is permanent: false and navigating straight to the destination rather than following the redirect. Correct fix for the right reason.

Worth stating plainly: none of this PR's e2e changes failed. The workflow specs on shards 1-3 passed, and this PR's own edit inside workshop.spec.ts (the /hub/workflows/video_minimax_h3_i2v/ 404 assertion) passed too.

3. The docs commit corrects something that was genuinely wrong

The old README step 2 said listing a URL in legacyRedirects was all it took. It was not — comfy-router reads legacyRedirects for /workflows/* from its own bundled src/hub-workflow-manifest.js, not from the live manifest. Only pages and defaultOwner for /hub/workflows/* come from the live one. Anyone following the old instructions would have added an entry, deployed, and seen nothing happen. Good catch, and the new step 2 spells out the router edit and redeploy.

Also good: the title now carries 307 first, 308 after router #46, FE-3083, so the flip-to-permanent follow-up I worried about losing in round 2 is a tracked ticket rather than a comment string.

One design observation, non-blocking and really for the follow-up: the manifest still publishes legacyRedirects, and the schema validates it rigorously, but the router ignores that field for /workflows/*. So it is a validated staging copy of data whose effective source of truth lives in another repo, with nothing able to detect divergence between the two. Harmless today — it ships {} — but the first entry added creates a silent two-copy drift risk that only the README guards. If the router could read legacyRedirects live the way it reads pages, the duplication would go away entirely.

Unchanged

B3's code diff is byte-for-byte identical across every file including all 302 lines of vercel.json; 60 workflow redirects still permanent: false; legacyRedirects still {}; no unresolved threads. Current head has website-unit, lint and typecheck in progress with no failures.

Incidentally, the base merge also made the CI Workshop-parity scan registry-driven (list-models-pages.ts over modelsUrlRoots) instead of hardcoding dist/models. Since this PR adds HUB_WORKFLOWS_PATH as a third root, that gate now covers the 30 new workflow pages — it would not have before.

Still open, both on #19422

  1. redirects.test.ts — dataPaths covers only modelPageUrls, not the /models/workflows/<name>/page.json paths these pages fetch.
  2. llms-txt.test.ts:139 — modelsPages built from /models/${slug}, dynamic modelsBuildRoutes patterns unregistered. Latent until #19405 lifts noindex.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenth pass — every website gate is green on this head; merge-ready from my side

Base merge only (c61e5a304); B3's code is byte-for-byte identical, 60 workflow redirects still permanent: false, no unresolved threads.

The e2e prediction from last round held. On b30a4e2fb and again on the current head c61e5a304:

gate result
website-unit success
website-build success
website-e2e success (all 4 shards)
lint success
typecheck success

Zero website-related checks pending, zero failures. The 35 still running are ecosystem-matrix, perf-tests and playwright-tests-* — main-frontend suites that run on every PR and are orthogonal to a change confined to apps/website/**.

That closes both outstanding process concerns: the round-7 untested window (the test files that adapted to the roots refactor have now executed green) and the round-9 website-e2e failure (the models alias test, broken by the 307 flip, fixed in the base).

On the base's further rework of that test — it dropped the vercel.json assertion and is now just "the hub page an old alias points at renders". That is the right call, not a coverage loss: redirects.test.ts already asserts permanent: false on those exact rows as a unit test, so reading vercel.json from disk inside a Playwright spec was duplicating a unit concern in a browser test. The e2e now covers only what needs a browser.

The list-models-pages.ts change is also a genuine robustness fix — resolving dist from import.meta.url instead of process.cwd() makes it invocation-independent. It happened to work because pnpm --filter sets cwd to the package directory.

Still open, both on #19422, neither blocking this PR

  1. redirects.test.ts — dataPaths covers only modelPageUrls, not the /models/workflows/<name>/page.json paths these pages fetch. A future /models/workflows/:name* rule to save route budget would break the data fetch with this guard staying green.
  2. llms-txt.test.ts:139 — modelsPages built from /models/${slug}, dynamic modelsBuildRoutes patterns unregistered. Latent until #19405 lifts noindex, which is the next step in this sequence.

Nothing further from me. Approval stands, now backed by a fully green website suite on this exact commit rather than static analysis.

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
## Summary

**Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its
follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it
to a /workflows 404) must be deployed before this merges. After the
merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30
workflow names in `hub-workflow-names.json`. The redirects ship as 307;
FE-3083 flips them to 308 later.**

This branch combines every Workshop /models SEO PR, so merging it to
main replaces merging them one by one. It also launches: Comfy-Org#19405 commits
`launchedModelPages = 'all'`, so all 148 model pages become indexable in
the same deploy as the URL move.

Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is
FE-3087)
Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977,
FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935,
FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921,
FE-2922, FE-2947

## Changes

Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324
router tests), deploy before this merges.


The included PRs, in merge order. Every head was checked as contained at
the final tip.

| PR | Ticket | What | Ben |
|---|---|---|---|
| Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate`
| approved |
| Comfy-Org#18889 | FE-2989 | A unique meta description on every model page |
approved |
| Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts |
approved |
| Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate
summaries | approved |
| Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title,
Organization data. The FE-2977 title was confirmed by the owner |
approved |
| Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved |
| Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" |
approved |
| Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI
check | approved |
| Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale
| approved |
| Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for
serverless-animation | approved; re-approval pending on a one-line
follow-up (CodeRabbit approved) |
| Comfy-Org#19359 | FE-2974 | One typed redirect list that generates
`vercel.json` | approved |
| Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved |
| Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says |
approved |
| Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved |
| Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML |
approved |
| Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved |
| Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved
|
| Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift |
approved |
| Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles |
approved |
| Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page |
approved (a CodeRabbit changes-requested review is still open) |
| Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved |
| Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved |
| Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved |
| Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with
redirects | approved |
| Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing
| approved |
| Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved |
| Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page |
approved |
| comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and
routes `/hub/workflows` by manifest. Merged and live | merged |

These fixes exist only on this branch, because they only break once two
PRs meet:

- `scripts/check-models-html.ts` reads each page at `model.href` and
skips models without a page (f1df1e4).
- `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models`
(f87bb4c).
- `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made
it optional and Comfy-Org#19405 no longer typechecked (9783819).
- `ModelStatus` links a successor only when it has a page, for the same
reason on Comfy-Org#18899 (c4761d8).
- The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/`
instead of the `/models/` redirect (eb985b6). Its label still says
"Models" while the nav says "Hub".
- Twin, meta-description and entry tests use the hub pages and the new
tag set (86ac3b0, d4ffc0f).
- The render guard finds the catalogue through `getRoutes().workshop`,
and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f).
- A new test renders a real model page and checks its markdown twin has
the model's h1 (9a6c5cb).
- Main's newer catalogue and workflow e2e cases use the hub addresses
(2aeda77).
- `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of
main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer
exists (c28c7a7).

The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays
deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real
catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the
`WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's
figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing
tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer
builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test
imports `PROVIDER_NAMES` from its new home. The full table of 47
resolutions is in the integration report.

## Review Focus

- Launch rides along with the URL move. If launch should stay a separate
step, set `launchedModelPages` in
`apps/website/src/config/model-page-launch.ts` to `new Set()` before
merging.
- Main's Comfy-Org#19320 gives the catalogue island its own h1 through
`WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only
the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1.

- Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion
for serverless-animation). One of them should be closed once this lands.

## QA

- [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0
errors, eslint on `apps/website` clean, `pnpm knip` clean
- [x] Website unit: 547 files, 10347 passed, 4 skipped
- [x] Build A (`build:e2e`, CI env): 1193 pages; release gate,
`check:hreflang`, `validate:llms-txt-links` (225 links),
`validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html`
(148 pages) all pass
- [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on
build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no
Run, no Hub nav and no Firebase requests
- [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals
except redirect stubs, no hreflang in the sitemap
- [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed
on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network
isolation, render guard) all passed when rerun alone
- [x] Launch: 148 model pages indexable with canonicals, 149 hub entries
in the sitemap, 148 non-empty twins with the model h1, 148 in
`llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex
- [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307,
every /hub destination built
- [x] comfy-router#46 under `wrangler dev` in front of this build: 312
router tests pass; 148 old model URLs (both slash forms) 307 then 200;
30 workflow names served by the website and their old URLs 307; a
non-manifest workflow 302 with no-store; `manifest.json` passes through;
`/workflows/` and bare `/hub` unchanged
- [x] After the router deploys and this merges: purge Cloudflare, then
curl `https://comfy.org/hub/models/` for a 200 and three old
`/models/<slug>/` URLs for one 307 each
- [x] Rich Results Test on `/pricing/` and
`/learning/animations/character-sheet/`, then "Validate fix" on Merchant
listings and Videos
- [x] Rich Results Test on two live model pages: breadcrumbs valid and
the breadcrumb URL returns 200 with no redirect
- [x] GPTBot and Googlebot curls on the hub and one model page, then a
GSC live test on both
- [x] Resubmit the sitemap in Search Console and URL-inspect about 20
model pages on day 0 and day 14
- Not covered: Rich Results and GSC need production; the redirect matrix
used a local shim for `vercel.json`, since `astro preview` ignores it

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants