Repository navigation
fix(website): let NOINDEX_ROUTES decide noindex for /platform/serverless-animation - #19476
MaanilVerma wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
QAHead
After deploy: Update 2026-09-30 at
Update at
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe serverless animation route is listed in the noindex configuration, and the page no longer sets a page-level ChangesServerless animation indexing
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The route remains excluded from search indexing and the sitemap. No actionable merge risk remains beyond normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change centralizes an existing noindex decision without changing authorization or direct page access. The inspected consumers consistently exclude the route from discovery outputs. Production cleanup and publication behavior were not verified, so some uncertainty remains. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ac7bbadccc33baec07e4d467ac17c1befdfc6442
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19476.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-mee13wfcm-comfyui.vercel.app Last updated: 2026-09-29T22:49:29Z for |
benjcooley
left a comment
There was a problem hiding this comment.
Review
Traced the change through every consumer of isNoindexPathname / isExcludedFromSitemap: BaseLayout (robots meta, hreflang alternates, JSON-LD), astro.config.ts sitemap filter, markdown-twins.ts (.md twins + llms-full.txt), hreflang.ts, and the llms.txt coverage tests. The fix is correct and the mechanism is already proven in production by list-only pages like /case-studies and /videos, which carry no noindex prop and still ship noindex, nofollow. Behaviour after the change: robots meta preserved, page dropped from sitemap-0.xml, no .md twin, out of llms-full.txt — which is the stated goal. The added test row genuinely fails on main.
No blockers. Two cleanups below plus one scoping question.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 1 |
| TRIVIAL | 2 |
TRIVIAL — the page itself is the temporary thing, the list entry is permanent. The description calls this a "temporary side-by-side serverless animation study". Adding it to NOINDEX_ROUTES is the right immediate fix, but the entry will outlive the study and NOINDEX_ROUTES accumulates. Worth a follow-up to delete the page (or build-gate it the way the Workshop pages are) once the study is done — and note that per apps/website/AGENTS.md, noindex only hides it from search engines, anyone with the link can still reach it.
Not an issue, just confirming for the record: the path is now listed in three places — NOINDEX_ROUTES, LOCALE_INVARIANT_EXTRA_PATHS in routes.ts, and EXCLUDED_PAGES in llms-txt.test.ts. The first two are orthogonal (noindex vs. English-only) so that overlap is fine; only the third is now redundant.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19476 +/- ##
==========================================
- Coverage 84.25% 84.15% -0.10%
==========================================
Files 3282 3212 -70
Lines 157963 155894 -2069
Branches 41014 40334 -680
==========================================
- Hits 133086 131189 -1897
+ Misses 23048 22981 -67
+ Partials 1829 1724 -105
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 70 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@coderabbitai on the failed "Website End-To-End Regression Coverage" check: not adding a Playwright test here, and the reason is now in the PR description. The rendered HTML doesn't change (the robots meta was already |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review (scoped to db3bbcd, 6e70fde, and the main merge)
Both items from the first pass are genuinely addressed, not just acknowledged. Approving.
db3bbcd — redundant llms.txt exclusion removed. Verified the page stays out of llms.txt through the derived path: isExcludedPage ORs in isNoindexPathname, /platform/serverless-animation is not in LLMS_TXT_NOINDEX_EXCEPTIONS, and nothing links it, so covers every static page in src/pages and does not list excluded pages by accident both still hold.
6e70fde — recurrence guard. I ran the scan's logic against the real page tree rather than trusting it. It matches all 13 noindex occurrences under src/pages, across every form in use: multi-line prop (privacy-policy), same-line prop (zh-CN/payment/failed), and component pass-through (<AgentPage noindex />). /404/ is correctly dropped as the documented exception. Every remaining route resolves true — /comfy-agent/ via the literal in NOINDEX_PATHNAMES, the zh-CN pages via prefix expansion. No false positives today, since noindex appears nowhere else in that tree. The finds the pages that set the prop sentinel is the detail that makes this hold up: without it, a regex that quietly stops matching would leave it.for with an empty case list and a green suite proving nothing.
The merge from main touches unrelated website files (Hub nav rename, homepage specs) and does not collide with indexing.ts; the route list at head is as intended.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 1 |
One residual gap noted inline, non-blocking. Approving on the logic; website-unit was still running when I reviewed, so please confirm it goes green before merging — it is the job that actually exercises the new scan.
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
git rev-parse --short HEAD
for file in apps/website/src/config/indexing.ts apps/website/src/config/indexing.test.ts apps/website/src/config/llms-txt.test.ts apps/website/src/pages/platform/serverless-animation.astro; do
ast-grep outline "$file" || true
sed -n '1,240p' "$file"
done
rg -n -C3 'isNoindexPathname|isExcludedFromSitemap|llms-full\.txt' apps/website --glob '!**/pnpm-lock.yaml'
gh pr view 19476 --repo Comfy-Org/ComfyUI_frontend --json body --jq '.body'Length of output: 43431
I checked the source at Those tests, together with your reported build checks, provide appropriate coverage for this change. The post-deploy sitemap check remains pending. This reply does not change the failed check’s status. ✏️ Learnings added
You are interacting with an AI system. |
benjcooley
left a comment
There was a problem hiding this comment.
Third pass (scoped to 96994c2)
Approving. The AuthLayout gap is closed, and the extra staleness test is a good call I did not ask for.
AuthLayout arm. /\bAuthLayout\b/ over the unstripped source picks up /login/, /signup/ and /forgot-password/. All three are already in NOINDEX_ROUTES, so the suite stays green while the hole closes, and the sentinel now pins /login/ so this arm can't silently stop matching either. Hoisting astroFiles/pageRoute to module scope so both describes share them is the right shape.
NOINDEX_ROUTES is a route this site builds — the inverse check. This is the part worth calling out: it catches drift in the other direction, a list entry whose route no longer builds. That is exactly the failure mode I flagged in the first pass, where a temporary page like this one gets deleted and its NOINDEX_ROUTES entry quietly outlives it. Good connection to make unprompted.
I checked every entry resolves rather than trusting CI. The four routes with no file under src/pages — /models/showcase, /cinematic-studio, /checkout-opening, /checkout-return — are injected by the release-gate integration, which is why modelsBuildRoutes(true) has to be in builtRoutes; true rather than false is also the correct argument, since a workshop-disabled build still carries those entries harmlessly. /models/apps/cinematic-studio and /models/apps/reshoot resolve through the /models/apps/[app] pattern, /demos through demos/index.astro. workshop-release-gate importing cleanly under Vitest is already proven by llms-txt.test.ts. website-unit (6m5s) and all four e2e shards are green on this head, matching the analysis. No knip exposure from the new export — knip runs without --production here and the Vitest plugin makes test files entries.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 2 |
One trivial note inline. The other, purely a follow-up thought: astroFiles is now the third copy of the page-tree walker, after hreflang.test.ts and llms-txt.test.ts. src/utils/hreflangRoutes.ts already describes itself as the shared page-tree helper and already owns routeOf, so that walker has an obvious home whenever someone touches these three files again. Not for this PR.
Also noting for the record that the bot's comment on the .astro file was wrong and your reply was right: the whole point of the change is that one list decides noindex, the sitemap and the twins, and /case-studies and /videos have shipped on that mechanism alone for a while.
1241ba8
benjcooley
left a comment
There was a problem hiding this comment.
Fourth pass (scoped to 1241ba8)
Approving. One-line change, exactly the trivial note from the last pass, and nothing else moved.
NOINDEX_ROUTES is now as const, matching PAYMENT_STATUSES and PLACEHOLDER_PATHNAMES directly above it. The thing worth checking here was whether the assertion survives the leading ...PAYMENT_STATUSES.map(...) spread, since .map returns string[] rather than a tuple — it does: TypeScript infers a variadic tuple, .map still resolves where NOINDEX_PATHNAMES builds the prefixed set, and it.for accepts the readonly array with no cast at the call site. typecheck, lint, website-unit (5m26s), website-build and all four e2e shards are green on this head. The assertion erases, so runtime behaviour is identical.
To be precise about what this buys: mutation is blocked at the type level, not at runtime — the array is not frozen. That is what I asked for and it is sufficient here; no follow-up wanted.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
All review threads resolved. Good to merge.
The only thing still worth doing after merge is the deploy check already in the PR description: curl -s https://comfy.org/sitemap-0.xml | grep -c serverless-animation should print 0.
## Summary **Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it to a /workflows 404) must be deployed before this merges. After the merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30 workflow names in `hub-workflow-names.json`. The redirects ship as 307; FE-3083 flips them to 308 later.** This branch combines every Workshop /models SEO PR, so merging it to main replaces merging them one by one. It also launches: Comfy-Org#19405 commits `launchedModelPages = 'all'`, so all 148 model pages become indexable in the same deploy as the URL move. Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is FE-3087) Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977, FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935, FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921, FE-2922, FE-2947 ## Changes Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324 router tests), deploy before this merges. The included PRs, in merge order. Every head was checked as contained at the final tip. | PR | Ticket | What | Ben | |---|---|---|---| | Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate` | approved | | Comfy-Org#18889 | FE-2989 | A unique meta description on every model page | approved | | Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts | approved | | Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate summaries | approved | | Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title, Organization data. The FE-2977 title was confirmed by the owner | approved | | Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved | | Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" | approved | | Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI check | approved | | Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale | approved | | Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for serverless-animation | approved; re-approval pending on a one-line follow-up (CodeRabbit approved) | | Comfy-Org#19359 | FE-2974 | One typed redirect list that generates `vercel.json` | approved | | Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved | | Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says | approved | | Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved | | Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML | approved | | Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved | | Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved | | Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift | approved | | Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles | approved | | Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page | approved (a CodeRabbit changes-requested review is still open) | | Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved | | Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved | | Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved | | Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with redirects | approved | | Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing | approved | | Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved | | Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page | approved | | comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and routes `/hub/workflows` by manifest. Merged and live | merged | These fixes exist only on this branch, because they only break once two PRs meet: - `scripts/check-models-html.ts` reads each page at `model.href` and skips models without a page (f1df1e4). - `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models` (f87bb4c). - `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made it optional and Comfy-Org#19405 no longer typechecked (9783819). - `ModelStatus` links a successor only when it has a page, for the same reason on Comfy-Org#18899 (c4761d8). - The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/` instead of the `/models/` redirect (eb985b6). Its label still says "Models" while the nav says "Hub". - Twin, meta-description and entry tests use the hub pages and the new tag set (86ac3b0, d4ffc0f). - The render guard finds the catalogue through `getRoutes().workshop`, and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f). - A new test renders a real model page and checks its markdown twin has the model's h1 (9a6c5cb). - Main's newer catalogue and workflow e2e cases use the hub addresses (2aeda77). - `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer exists (c28c7a7). The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the `WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test imports `PROVIDER_NAMES` from its new home. The full table of 47 resolutions is in the integration report. ## Review Focus - Launch rides along with the URL move. If launch should stay a separate step, set `launchedModelPages` in `apps/website/src/config/model-page-launch.ts` to `new Set()` before merging. - Main's Comfy-Org#19320 gives the catalogue island its own h1 through `WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1. - Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion for serverless-animation). One of them should be closed once this lands. ## QA - [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0 errors, eslint on `apps/website` clean, `pnpm knip` clean - [x] Website unit: 547 files, 10347 passed, 4 skipped - [x] Build A (`build:e2e`, CI env): 1193 pages; release gate, `check:hreflang`, `validate:llms-txt-links` (225 links), `validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html` (148 pages) all pass - [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no Run, no Hub nav and no Firebase requests - [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals except redirect stubs, no hreflang in the sitemap - [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network isolation, render guard) all passed when rerun alone - [x] Launch: 148 model pages indexable with canonicals, 149 hub entries in the sitemap, 148 non-empty twins with the model h1, 148 in `llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex - [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307, every /hub destination built - [x] comfy-router#46 under `wrangler dev` in front of this build: 312 router tests pass; 148 old model URLs (both slash forms) 307 then 200; 30 workflow names served by the website and their old URLs 307; a non-manifest workflow 302 with no-store; `manifest.json` passes through; `/workflows/` and bare `/hub` unchanged - [x] After the router deploys and this merges: purge Cloudflare, then curl `https://comfy.org/hub/models/` for a 200 and three old `/models/<slug>/` URLs for one 307 each - [x] Rich Results Test on `/pricing/` and `/learning/animations/character-sheet/`, then "Validate fix" on Merchant listings and Videos - [x] Rich Results Test on two live model pages: breadcrumbs valid and the breadcrumb URL returns 200 with no redirect - [x] GPTBot and Googlebot curls on the hub and one model page, then a GSC live test on both - [x] Resubmit the sitemap in Search Console and URL-inspect about 20 model pages on day 0 and day 14 - Not covered: Rich Results and GSC need production; the redirect matrix used a local shim for `vercel.json`, since `astro preview` ignores it --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
|
Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one. |
Summary
/platform/serverless-animationwas noindexed by its ownnoindexprop, so prod servednoindex, nofollowwhile the sitemap listed it andllms-full.txtcarried it. It now lives inNOINDEX_ROUTES, so one list decides noindex, the sitemap and the markdown twins.Fixes FE-3085 (https://linear.app/comfyorg/issue/FE-3085)
Found while reviewing #19404.
Changes
NOINDEX_ROUTESinconfig/indexing.tsnow includes/platform/serverless-animation. BaseLayout still adds the robots meta becauseshouldNoindexalready ORs inisNoindexPathname.noindexprop.indexing.test.tsadds the path to the existing noindex table, and a scan oversrc/pages/**/*.astrofails if any page passesnoindexor usesAuthLayoutwithout being inNOINDEX_ROUTES(/404is the one allowed exception). That's the drift this PR fixes, so it can't come back silently. EveryNOINDEX_ROUTESentry must also match a built page or injected route, so renaming a listed page can't leave a stale entry behind.llms-txt.test.tsdrops its hand-written exclusion for this page;isNoindexPathnamenow covers it.noindexwithout list coverage./404has its own exclusion, and the/models/*Workshop pages are covered byisWorkshopRoute.No new Playwright test: this page has no spec, it's a temporary motion study, and the rendered HTML doesn't change (the robots meta was already there). What changes is build output (sitemap,
.mdtwin,llms-full.txt), which all read the one policy that the unit tests pin, and the build check below confirms it.QA
sitemap-0.xml, the.mdtwins andllms-full.txtcurl -s https://comfy.org/sitemap-0.xml | grep -c serverless-animationprints 0