Repository navigation
[backport cloud/1.54] perf: cut lint and typecheck time and memory (manual, lint-staged, CI) - #18644
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 1948 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-24T02:41:33.308Z",
"gitSha": "fd4ca2f113f5bdd77900bf4e4756c7ddcb868111",
"branch": "backport-18495-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.0219999999777,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.5699999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.14599999999996,
"heapDeltaBytes": -2939476,
"heapUsedBytes": 67243512,
"domNodes": -285,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.443000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2077.8909999999655,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.202,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.759,
"heapDeltaBytes": 9756104,
"heapUsedBytes": 79988104,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 12.445999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1935.2349999999774,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.159000000000006,
"layouts": 14,
"layoutDurationMs": 4.757,
"taskDurationMs": 947.8610000000001,
"heapDeltaBytes": 12935424,
"heapUsedBytes": 83152220,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 151.01799999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.644000000007,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.572999999999997,
"layouts": 14,
"layoutDurationMs": 4.510999999999999,
"taskDurationMs": 878.439,
"heapDeltaBytes": -1515040,
"heapUsedBytes": 68681160,
"domNodes": -278,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 146.48600000000002,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9460000000495,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.092000000000002,
"layouts": 6,
"layoutDurationMs": 1.183,
"taskDurationMs": 389.327,
"heapDeltaBytes": 4595316,
"heapUsedBytes": 75992060,
"domNodes": 75,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 15.19,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.224000000083,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.106,
"layouts": 6,
"layoutDurationMs": 1.3580000000000003,
"taskDurationMs": 357.143,
"heapDeltaBytes": 4690880,
"heapUsedBytes": 75709860,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.624999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 656.5110000000232,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.43,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.056,
"heapDeltaBytes": -7856152,
"heapUsedBytes": 62987272,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 144.175,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 743.142999999975,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.26599999999996,
"heapDeltaBytes": -7567744,
"heapUsedBytes": 63229640,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 164.159,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.175999999984,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.539999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.5869999999999,
"heapDeltaBytes": 8715228,
"heapUsedBytes": 85285324,
"domNodes": -270,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 39.510999999999996,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2053.288000000066,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.514,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.3969999999999,
"heapDeltaBytes": 11197864,
"heapUsedBytes": 86994012,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 42.966,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2599.028999999973,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.945999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1675.9660000000003,
"heapDeltaBytes": 8759224,
"heapUsedBytes": 85138344,
"domNodes": -273,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 786.6750000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2281.1699999999746,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.268,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1593.1229999999998,
"heapDeltaBytes": 8117628,
"heapUsedBytes": 85539360,
"domNodes": -275,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 750.544,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3879.263999999978,
"styleRecalcs": 60,
"styleRecalcDurationMs": 14.237,
"layouts": 60,
"layoutDurationMs": 16.296000000000003,
"taskDurationMs": 1787.8410000000001,
"heapDeltaBytes": 8479768,
"heapUsedBytes": 76503952,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 759.225,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3654.0149999999585,
"styleRecalcs": 60,
"styleRecalcDurationMs": 13.971,
"layouts": 60,
"layoutDurationMs": 16.201,
"taskDurationMs": 1718.785,
"heapDeltaBytes": 12098328,
"heapUsedBytes": 79989724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 732.2259999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3100.136999999961,
"styleRecalcs": 40,
"styleRecalcDurationMs": 7.4719999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2028.974,
"heapDeltaBytes": 22509812,
"heapUsedBytes": 90136172,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 974.0459999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3121.929000000023,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.789,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1870.6100000000001,
"heapDeltaBytes": 17674632,
"heapUsedBytes": 85055424,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 871.1940000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1996.5250000000196,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.772,
"heapDeltaBytes": 21659980,
"heapUsedBytes": 88778444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.619,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.829999999989,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.5600000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.687,
"heapDeltaBytes": 21411016,
"heapUsedBytes": 87904548,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.731,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 676.1020000000144,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.707999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.803,
"heapDeltaBytes": 15038868,
"heapUsedBytes": 88342004,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.289,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.8199999999642,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.464000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.359,
"heapDeltaBytes": 14940080,
"heapUsedBytes": 88410396,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 125.331,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.4689999999773,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.207999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.92999999999995,
"heapDeltaBytes": -9158172,
"heapUsedBytes": 63410896,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.335999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2040.409000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.823999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.074,
"heapDeltaBytes": -4340196,
"heapUsedBytes": 69036120,
"domNodes": -298,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 11.948,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.7810000000022,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.189999999999998,
"layouts": 18,
"layoutDurationMs": 5.006,
"taskDurationMs": 803.0120000000001,
"heapDeltaBytes": -8884412,
"heapUsedBytes": 63733256,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 100.05799999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.0149999999767,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.852,
"layouts": 18,
"layoutDurationMs": 5.633,
"taskDurationMs": 862.0689999999998,
"heapDeltaBytes": -8373668,
"heapUsedBytes": 64225848,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.982,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.4769999999667,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.770999999999997,
"layouts": 14,
"layoutDurationMs": 13.508,
"taskDurationMs": 928.9070000000002,
"heapDeltaBytes": 21080280,
"heapUsedBytes": 110697488,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 34.706,
"eventListeners": 2387,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9219.528000000026,
"styleRecalcs": 246,
"styleRecalcDurationMs": 48.74000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6021.159,
"heapDeltaBytes": 17156496,
"heapUsedBytes": 93787792,
"domNodes": -272,
"jsHeapTotalBytes": -1482752,
"scriptDurationMs": 2752.3089999999997,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8202.55899999995,
"styleRecalcs": 248,
"styleRecalcDurationMs": 49.69800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5450.6230000000005,
"heapDeltaBytes": 13610208,
"heapUsedBytes": 89697220,
"domNodes": -271,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2464.465,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15049.509999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14706.410000000002,
"heapDeltaBytes": -27129888,
"heapUsedBytes": 184917408,
"domNodes": -8067,
"jsHeapTotalBytes": -9756672,
"scriptDurationMs": 296.516,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15239.029000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14846.154999999999,
"heapDeltaBytes": -20551936,
"heapUsedBytes": 191411060,
"domNodes": -8068,
"jsHeapTotalBytes": -10072064,
"scriptDurationMs": 276.59799999999996,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18918.64099999998,
"styleRecalcs": 132,
"styleRecalcDurationMs": 24.283000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18832.492000000002,
"heapDeltaBytes": -49999464,
"heapUsedBytes": 168878700,
"domNodes": -8065,
"jsHeapTotalBytes": -12640256,
"scriptDurationMs": 935.426,
"eventListeners": -14927,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18032.340999999975,
"styleRecalcs": 134,
"styleRecalcDurationMs": 23.858999999999963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17779,
"heapDeltaBytes": -25599580,
"heapUsedBytes": 192441752,
"domNodes": -8068,
"jsHeapTotalBytes": -11661312,
"scriptDurationMs": 962.12,
"eventListeners": -14929,
"totalBlockingTimeMs": 64,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5624.944999999969,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.78600000000002,
"layouts": 20,
"layoutDurationMs": 29.770999999999994,
"taskDurationMs": 5593.3189999999995,
"heapDeltaBytes": -37629200,
"heapUsedBytes": 175158164,
"domNodes": -8067,
"jsHeapTotalBytes": 16224256,
"scriptDurationMs": 121.75299999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 208,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5549.516999999923,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.39400000000002,
"layouts": 20,
"layoutDurationMs": 39.977,
"taskDurationMs": 5445.354000000001,
"heapDeltaBytes": -60362292,
"heapUsedBytes": 170237560,
"domNodes": -8068,
"jsHeapTotalBytes": 2969600,
"scriptDurationMs": 111.926,
"eventListeners": -14931,
"totalBlockingTimeMs": 428,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7552.746999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7427.334000000002,
"heapDeltaBytes": -7393484,
"heapUsedBytes": 176699176,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 159.24899999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7279.259000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7179.903000000001,
"heapDeltaBytes": 7946228,
"heapUsedBytes": 187201284,
"domNodes": 0,
"jsHeapTotalBytes": -24379392,
"scriptDurationMs": 175.22800000000004,
"eventListeners": 18,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 123.6669999999549,
"styleRecalcs": 8,
"styleRecalcDurationMs": 20.859,
"layouts": 3,
"layoutDurationMs": 2.496,
"taskDurationMs": 97.028,
"heapDeltaBytes": 3281784,
"heapUsedBytes": 72214576,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.165,
"eventListeners": 38,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.41599999994287,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.88,
"layouts": 3,
"layoutDurationMs": 1.806,
"taskDurationMs": 113.484,
"heapDeltaBytes": 4754104,
"heapUsedBytes": 74093492,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.841000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18644 +/- ##
=============================================
Coverage ? 82.25%
=============================================
Files ? 2540
Lines ? 132836
Branches ? 33590
=============================================
Hits ? 109264
Misses ? 23058
Partials ? 514
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… window (#18674) <!-- ccr-slack-attribution --> Automated backport of #18599 to `cloud/1.54`, after the backport bot's automated cherry-pick attempt failed on a merge conflict. ## Summary Cherry-picks e346ef9 (#18599) onto `cloud/1.54`. That PR gives the unified-remint post-401 retry fetch a fresh timeout window instead of letting it inherit whatever was left of the original request's 60s deadline (Sentry `CLOUD-FRONTEND-STAGING-4MF`/`4MG`). ## Conflict and resolution - `src/scripts/api.ts` and `src/platform/auth/unified/remintRetry.ts` cherry-picked cleanly with no conflicts. - `src/scripts/api.fetchApi.test.ts` conflicted because three other open PRs (#18644, #18479, #18370) are stacked on `cloud/1.54` touching the same file, and because `cloud/1.54`'s mocking setup for this file predates several refactors that already landed on `main` (`fromPartial`/`vi.mock(import(...))` typed mocks, and a `firebaseIdentity` auth wrapper that doesn't exist on `cloud/1.54`). Resolved by keeping `cloud/1.54`'s existing plain `vi.mock('module', factory)` style and layering in only the additions the new `post-401 retry timeout budget` test needs (the `trackUnifiedAuthRetry` mock, the `mockDistribution`/`isCloud` toggle, a `useFeatureFlags` mock, and `vuefire`/`firebase/auth` stubs matching the convention already used in `authStore.test.ts`), instead of pulling over `main`'s newer typed-mock plumbing verbatim. - Also fixed two latent issues surfaced while getting the cherry-picked tests to actually pass on this branch (not part of the original PR's intent, but required for the cherry-pick to work): - `src/platform/auth/unified/remintRetry.test.ts`'s new test referenced `useWorkspaceAuthStore()` directly (that's `main`'s current test style), but `cloud/1.54`'s version of this file mocks the store via a `mockRemint` const instead and never imports `useWorkspaceAuthStore` — fixed to use `mockRemint.mockResolvedValue(...)`. - `src/scripts/api.ts`'s new retry-timeout breadcrumb called a bare `addBreadcrumb(...)`, but this file imports Sentry as `import * as Sentry from '@sentry/vue'` — fixed to `Sentry.addBreadcrumb(...)`. ## Verification - `pnpm vitest run src/scripts/api.fetchApi.test.ts src/platform/auth/unified/remintRetry.test.ts` — 41/41 tests pass. - `pnpm exec eslint` on the four touched files — clean (pre-existing, unrelated `api.ts` lint findings elsewhere in the file are untouched by this diff). - `pnpm run typecheck` (`vue-tsc --noEmit`) — clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com>
… assets flag, retire Comfy.Assets.UseAssetAPI (#18728) Manual backport of #17117 to `cloud/1.54`. Cherry-picked from dffad2d (`git cherry-pick -x`). ## Why Retires the hidden `Comfy.Assets.UseAssetAPI` setting and the `Comfy.ToggleAssetAPI` command. Asset surfaces (model library, sidebar routing, model store) follow `useFeatureFlags().flags.assetsEnabled`, and widget asset pickers are cloud-only under `isWidgetAssetPickerEnabled` / `shouldUseWidgetAssetPicker`. On the cloud build `assetsEnabled` is always true, so asset surfaces stay on, including for users who had set the hidden setting to `false`. That opt-out is retired on purpose. ## Dependency check The bot suggested this might be a stacking conflict with #18723 and #18644. It is not. Neither PR touches any of the conflicted files: #18723 changes agent workflow-resolver files, and #18644 changes lint/typecheck config and a few UI components. The conflict is real. All 7 conflicts are in test files, because `main` went through test-infra migrations that `cloud/1.54` doesn't have (global Pinia, `vi.mock(import())`, i18n mock cleanup: #17175, #17176, #17178, #17231, #17234–#17237, #17270, #16891). All production files, locales, e2e specs, `scripts/checkAssetsFlagArtifact.*` and `.github/actions/build-cloud-frontend/action.yaml` applied cleanly. ## Conflict resolution Test files kept the target branch's mocking style. Only the setting-to-flag change was ported. - `src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts`: kept the target's `settingState`/`modelsState`/`mockLoadModels` harness. Removed `useAssetAPI` from the settings mock, added a hoisted `featureFlagState` and a `useFeatureFlags` mock, and switched the two asset-mode tests to `featureFlagState.assetsEnabled = true`. - `src/composables/useCoreCommands.test.ts`: took #17117's `browseModelAssets()` helper. The auto-merged tests below it already use it and the existing `mockFeatureFlagState`. - `src/platform/assets/services/assetService.test.ts`: kept the target's module mocks and renamed the describe to `shouldUseWidgetAssetPicker`. Removed the now-dead `settingStore` mock, which referenced the dropped `mockSettingStoreGet`. `assetService` no longer reads settings. - `src/platform/assets/utils/assetPreviewUtil.test.ts`: added #17117's `useFeatureFlags` mock and kept the target's string-form `assetService` mock. - `src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts`: kept the target's `axios` import and its two target-only tests (first-load lifecycle, loading inventory). Took #17117's renamed "widget asset picker is disabled" test. Dropped the unused `settingStore` mock, as #17117 did. - `src/stores/modelStore.test.ts`: took #17117's `remoteConfigHolder` + `featureState` mocks and the `enableMocks(assetsEnabled)` body. The auto-merged `beforeEach` depends on them, and they avoid cross-test leakage. - `src/stores/workspace/sidebarTabStore.test.ts`: kept the target's `mockGetSetting`/`registeredCommands` harness. Replaced the `commandStore.commands` / `mockBrowseModelAssets` stubs with #17117's `featureFlagState` and `openModelLibraryBrowser` mocks, and ported each routing test to set the flag instead of `Comfy.Assets.UseAssetAPI`. No remaining references to `Comfy.Assets.UseAssetAPI`, `isAssetAPIEnabled`, `shouldUseAssetBrowser`, `ToggleAssetAPI` or `usesAssetApi`. ## Validation - `pnpm typecheck`: clean - `eslint`, `oxlint`, `oxfmt --check` on changed files: clean - Vitest: touched tests plus `src/stores`, `src/platform/assets`, `src/components/sidebar`, `src/composables`, `src/renderer/extensions/vueNodes/widgets`, `src/platform/missingModel`, `src/extensions/core`, `scripts`. All pass (130 + 332 files). - `pnpm build:cloud` (`VITE_USE_LEGACY_DEFAULT_GRAPH=true`), then `EXPECTED_DISTRIBUTION=cloud pnpm test:assets-flag-artifact` against HEAD: pass. The same cloud dist checked with `EXPECTED_DISTRIBUTION=localhost` correctly fails. - `pnpm build`, then `EXPECTED_DISTRIBUTION=localhost pnpm test:assets-flag-artifact`: pass - Playwright, cloud project on the cloud dist (`browseModelAssets`, `cloud-asset-promoted-widget`, `errorsTabCloudMissingModels`, `checkoutRecovery`, `pricingTableDeepLink`): 30/30. The first run had one timing failure in `cloud-asset-promoted-widget`. It passed 3/3 in isolation and on a full rerun. - `knip` (pre-push hook): clean - Playwright, chromium project on the localhost dist (`modelLibraryAssetMode`, `modelLibraryRouting`, `browseModelAssets`): 19/19
Summary
Backports #18495 to
cloud/1.54.Changes
cloud/1.54; files belonging to absent upstream prerequisites remain absent.Review Focus
Verify the release-branch-specific lint and typecheck project routing.