Skip to content

[backport cloud/1.54] refactor(assets): gate asset surfaces on server assets flag, retire Comfy.Assets.UseAssetAPI - #18728

Merged
comfy-pr-bot merged 3 commits into
cloud/1.54from
backport-17117-to-cloud-1.54
Sep 25, 2026
Merged

comfy-pr-bot merged 3 commits into
cloud/1.54from
backport-17117-to-cloud-1.54

Conversation

@synap5e

@synap5e synap5e commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #17117 to cloud/1.54.

Cherry-picked from dffad2d (git cherry-pick -x).

Why

Retires the hidden Comfy.Assets.UseAssetAPI setting and the Comfy.ToggleAssetAPI command. Asset surfaces (model library, sidebar routing, model store) follow useFeatureFlags().flags.assetsEnabled, and widget asset pickers are cloud-only under isWidgetAssetPickerEnabled / shouldUseWidgetAssetPicker. On the cloud build assetsEnabled is always true, so asset surfaces stay on, including for users who had set the hidden setting to false. That opt-out is retired on purpose.

Dependency check

The bot suggested this might be a stacking conflict with #18723 and #18644. It is not. Neither PR touches any of the conflicted files: #18723 changes agent workflow-resolver files, and #18644 changes lint/typecheck config and a few UI components. The conflict is real. All 7 conflicts are in test files, because main went through test-infra migrations that cloud/1.54 doesn't have (global Pinia, vi.mock(import()), i18n mock cleanup: #17175, #17176, #17178, #17231, #17234–#17237, #17270, #16891). All production files, locales, e2e specs, scripts/checkAssetsFlagArtifact.* and .github/actions/build-cloud-frontend/action.yaml applied cleanly.

Conflict resolution

Test files kept the target branch's mocking style. Only the setting-to-flag change was ported.

No remaining references to Comfy.Assets.UseAssetAPI, isAssetAPIEnabled, shouldUseAssetBrowser, ToggleAssetAPI or usesAssetApi.

Validation

  • pnpm typecheck: clean
  • eslint, oxlint, oxfmt --check on changed files: clean
  • Vitest: touched tests plus src/stores, src/platform/assets, src/components/sidebar, src/composables, src/renderer/extensions/vueNodes/widgets, src/platform/missingModel, src/extensions/core, scripts. All pass (130 + 332 files).
  • pnpm build:cloud (VITE_USE_LEGACY_DEFAULT_GRAPH=true), then EXPECTED_DISTRIBUTION=cloud pnpm test:assets-flag-artifact against HEAD: pass. The same cloud dist checked with EXPECTED_DISTRIBUTION=localhost correctly fails.
  • pnpm build, then EXPECTED_DISTRIBUTION=localhost pnpm test:assets-flag-artifact: pass
  • Playwright, cloud project on the cloud dist (browseModelAssets, cloud-asset-promoted-widget, errorsTabCloudMissingModels, checkoutRecovery, pricingTableDeepLink): 30/30. The first run had one timing failure in cloud-asset-promoted-widget. It passed 3/3 in isolation and on a full rerun.
  • knip (pre-push hook): clean
  • Playwright, chromium project on the localhost dist (modelLibraryAssetMode, modelLibraryRouting, browseModelAssets): 19/19

…omfy.Assets.UseAssetAPI (#17117)

Retires the hidden `Comfy.Assets.UseAssetAPI` setting. Asset surfaces
now follow the backend's `assets` capability flag. Widget-embedded model
pickers stay cloud-only, under a name that says so.

The backend already advertises `assets` support, so a hidden client
override was redundant — and on core it could force asset mode against a
server with no `/assets` endpoints.

The gate functions were misleadingly named. `isAssetAPIEnabled` /
`shouldUseAssetBrowser` read as "is the asset API on", but actually
gated *widget* pickers — which are cloud-only because
`MODEL_NODE_MAPPINGS` is only maintained for cloud. They're now
`isWidgetAssetPickerEnabled` / `shouldUseWidgetAssetPicker`, hardcoded
to `isCloud`.

67 files, small surface: **18 production**, 30 one-line locale
deletions, 19 test migration. Commit 1 is production, commits 2–3 are
tests.

Unchanged for default settings on cloud, and on core without
`--enable-assets`.

**Core+ (`--enable-assets`)** — the model library enters asset mode. Six
deliberate consequences, each already asserted by
`modelLibraryAssetMode.spec.ts`:

1. Tree data from `/assets` instead of `api.getModels`
2. `visibleModelFolders` hides loaded-but-empty folders
3. The `supportsModelTypeTags` watcher goes live
4. Refresh issues `POST /assets/seed` via `requestModelScan()`
5. The per-folder extension allowlist applies client-side
6. The tab hides "Load all folders" and eager-loads on mount, bypassing
`Comfy.ModelLibrary.AutoLoadAll` — the most visible off-cloud change

**Anyone who had flipped the hidden setting:**

- Cloud, set `false` → asset surfaces return; that opt-out is
deliberately retired
- Core, set `true` → no longer forces asset mode at servers that can't
serve it (broken by construction)
- Core−, palette command → silent no-op instead of a dialog offering to
enable an API the server lacks

**Deliberately untouched:** `Comfy.ModelLibrary.UseAssetBrowser`
(sidebar-vs-modal), `Comfy.Assets.Sidebar.ViewMode`,
`MODEL_NODE_MAPPINGS`.

This PR edits `scripts/checkAssetsFlagArtifact.ts`, which statically
proves non-cloud bundles strip the widget gate. Its non-cloud invariant
is byte-identical — only the cloud regex and the function locator
changed, tracking the rename. Verified against real builds for all three
distributions, and mutation-tested: reverting the gate to a runtime
setting read, or flipping its polarity, both still fail the check.

Full unit suite and all touched e2e specs pass.

`Comfy_ToggleAssetAPI` and its `menuLabels` mirror are removed from all
15 locales. The command is gone, so the keys are unreachable — a pure
deletion, no translation pass. `pnpm locale:check`: 0 prunable keys, was
28.

(cherry picked from commit dffad2d)

Claude-Session: https://claude.ai/code/session_01HuX1AgffdgzXY3BBDuEi6u
@synap5e synap5e added the backport Backporting a PR onto a release candidate label Sep 24, 2026
@synap5e
synap5e requested a review from ltdrdata as a code owner September 24, 2026 20:56
@synap5e synap5e added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 24, 2026
@synap5e
synap5e requested review from a team and comfyui-wiki as code owners September 24, 2026 20:56
@synap5e synap5e added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 24, 2026
@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 25, 2026 11:32am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 25, 2026 11:32am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 7b30d176-dfb2-499e-8195-efd2d2ac2d7c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T20:59:24.658370Z 8d5915c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/25/2026, 11:34:28 AM UTC

Links

🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1937 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 142ms TBT · 82.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.0 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.6 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 68ms TBT · 166.7 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 406ms TBT · 172.0 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 481ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 68.5 MB
canvas-idle: DOM nodes -133
canvas-idle: event listeners -79
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 34ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 977ms
canvas-mouse-sweep: script duration 173ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 61.7 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 378ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.2 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 454ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.1 MB
dom-widget-clipping: DOM nodes 15
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 639ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.1 MB
large-graph-idle: DOM nodes -279
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1645ms
large-graph-pan: script duration 831ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.5 MB
large-graph-pan: DOM nodes -262
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1743ms
large-graph-zoom: script duration 786ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.6 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 2001ms
legacy-node-drag: script duration 973ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.3 MB
legacy-node-drag: DOM nodes -127
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 603ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.8 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -194
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 421ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.2 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 516ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.4 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 823ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 74.2 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 979ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 142ms
subgraph-transition-enter: heap used 82.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6066ms
viewport-pan-sweep: script duration 2835ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.0 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16940ms
vue-large-graph-idle: script duration 308ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.6 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 20982ms
vue-large-graph-pan: script duration 944ms
vue-large-graph-pan: TBT 68ms
vue-large-graph-pan: heap used 166.7 MB
vue-large-graph-pan: DOM nodes -8070
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6208ms
vue-node-resize-workload: script duration 114ms
vue-node-resize-workload: TBT 406ms
vue-node-resize-workload: heap used 172.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14927
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8521ms
vue-zoom-out-idle: script duration 149ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 17
workflow-execution: task duration 107ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.9 MB
workflow-execution: DOM nodes 145
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-25T11:44:02.417Z",
  "gitSha": "5589e5defa22e10d9d222e9a2c1ca332462057d8",
  "branch": "backport-17117-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2062.6199999999812,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.143,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.7420000000001,
      "heapDeltaBytes": 8578872,
      "heapUsedBytes": 78724320,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 10.379,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2033.3360000000766,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.558,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 433.24600000000004,
      "heapDeltaBytes": 692508,
      "heapUsedBytes": 64920476,
      "domNodes": 14,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 7.8409999999999975,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2084.828000000016,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 36.94500000000001,
      "layouts": 14,
      "layoutDurationMs": 4.33,
      "taskDurationMs": 1028.486,
      "heapDeltaBytes": -6906164,
      "heapUsedBytes": 62692552,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 181.501,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1856.9150000000718,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 30.835999999999995,
      "layouts": 14,
      "layoutDurationMs": 4.353999999999999,
      "taskDurationMs": 925.4859999999999,
      "heapDeltaBytes": -4271436,
      "heapUsedBytes": 66699708,
      "domNodes": -281,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 164.522,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1732.2749999999587,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.65,
      "layouts": 6,
      "layoutDurationMs": 1.345,
      "taskDurationMs": 395.29800000000006,
      "heapDeltaBytes": 4548344,
      "heapUsedBytes": 75955584,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 14.449,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.133999999969,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.354,
      "layouts": 6,
      "layoutDurationMs": 0.9930000000000002,
      "taskDurationMs": 361.43600000000004,
      "heapDeltaBytes": 4608980,
      "heapUsedBytes": 75418492,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.508,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 639.9499999999989,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.74,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.157,
      "heapDeltaBytes": -7556356,
      "heapUsedBytes": 63680784,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 161.295,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 688.5800000000017,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.553000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.547,
      "heapDeltaBytes": -6612252,
      "heapUsedBytes": 64504776,
      "domNodes": 12,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 169.276,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2070.7800000000134,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.363000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 673.8,
      "heapDeltaBytes": 7208200,
      "heapUsedBytes": 83780184,
      "domNodes": -274,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 38.586999999999996,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.302999999957,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.364999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.3340000000001,
      "heapDeltaBytes": 5703208,
      "heapUsedBytes": 82135344,
      "domNodes": -283,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 32.428,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2258.423999999991,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 9.944999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1627.844,
      "heapDeltaBytes": 24036544,
      "heapUsedBytes": 90274544,
      "domNodes": -274,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 816.196,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2259.243999999967,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.754000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1661.6529999999998,
      "heapDeltaBytes": 3004424,
      "heapUsedBytes": 80576648,
      "domNodes": -249,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 846.6909999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3587.865000000079,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.957,
      "layouts": 60,
      "layoutDurationMs": 11.951,
      "taskDurationMs": 1725.884,
      "heapDeltaBytes": 9477660,
      "heapUsedBytes": 76055644,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 777.1519999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3660.299000000009,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.059000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.065999999999999,
      "taskDurationMs": 1760.373,
      "heapDeltaBytes": 8195596,
      "heapUsedBytes": 76244012,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 795.437,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3201.0099999999966,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.611999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2065.6020000000003,
      "heapDeltaBytes": 7404952,
      "heapUsedBytes": 88186548,
      "domNodes": -253,
      "jsHeapTotalBytes": -208896,
      "scriptDurationMs": 989.93,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3091.8669999999793,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.703000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1937.082,
      "heapDeltaBytes": 24894700,
      "heapUsedBytes": 92875544,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 956.6680000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.2600000000084,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.9559999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 628.067,
      "heapDeltaBytes": 6721852,
      "heapUsedBytes": 84422896,
      "domNodes": -277,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 34.014999999999986,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.185999999996,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 577.6199999999999,
      "heapDeltaBytes": 9357540,
      "heapUsedBytes": 87065684,
      "domNodes": -278,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 37.95700000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.1979999999821,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.790999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.9700000000001,
      "heapDeltaBytes": 15101608,
      "heapUsedBytes": 88153672,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 142.853,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.0899999999947,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.284,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.287,
      "heapDeltaBytes": 15141564,
      "heapUsedBytes": 88415636,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 144.091,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.5620000000226,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.438999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 509.957,
      "heapDeltaBytes": -8675108,
      "heapUsedBytes": 63090840,
      "domNodes": -296,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 9.020999999999997,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.2459999999337,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.098,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 521.682,
      "heapDeltaBytes": -7747960,
      "heapUsedBytes": 65730716,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 9.306000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.9260000000295,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.733,
      "layouts": 18,
      "layoutDurationMs": 4.539,
      "taskDurationMs": 828.1030000000001,
      "heapDeltaBytes": -2160664,
      "heapUsedBytes": 71395924,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 112.02,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1750.5479999999807,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.987999999999996,
      "layouts": 18,
      "layoutDurationMs": 4.567,
      "taskDurationMs": 818.538,
      "heapDeltaBytes": 10783880,
      "heapUsedBytes": 84139856,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 109.81800000000001,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.6580000000504,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.497,
      "layouts": 14,
      "layoutDurationMs": 16.119,
      "taskDurationMs": 979.2290000000002,
      "heapDeltaBytes": -5387012,
      "heapUsedBytes": 86902880,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 31.304,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8969.310000000063,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.749,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6122.831,
      "heapDeltaBytes": 11183372,
      "heapUsedBytes": 87805000,
      "domNodes": -273,
      "jsHeapTotalBytes": -696320,
      "scriptDurationMs": 2836.6049999999996,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8663.749999999936,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.045,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6009.284,
      "heapDeltaBytes": -11438412,
      "heapUsedBytes": 92611336,
      "domNodes": -268,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 2833.532,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17768.283999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16993.766,
      "heapDeltaBytes": -54152820,
      "heapUsedBytes": 181637620,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14856192,
      "scriptDurationMs": 295.27500000000003,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17598.44799999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16886.496000000003,
      "heapDeltaBytes": -39709940,
      "heapUsedBytes": 178261196,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10498048,
      "scriptDurationMs": 321.113,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21396.822000000044,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 19.29900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21051.456000000002,
      "heapDeltaBytes": -48052464,
      "heapUsedBytes": 179749492,
      "domNodes": -8072,
      "jsHeapTotalBytes": -17498112,
      "scriptDurationMs": 976.497,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 53,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21264.391000000047,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 17.926,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20912.114,
      "heapDeltaBytes": -69554308,
      "heapUsedBytes": 169815772,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19312640,
      "scriptDurationMs": 912.3110000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 83,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6379.31500000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.58999999999999,
      "layouts": 20,
      "layoutDurationMs": 22.776000000000003,
      "taskDurationMs": 6275.008000000001,
      "heapDeltaBytes": -55743864,
      "heapUsedBytes": 182837928,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12681216,
      "scriptDurationMs": 119.67699999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 387,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6253.472000000102,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.017,
      "layouts": 20,
      "layoutDurationMs": 21.744999999999987,
      "taskDurationMs": 6141.249000000001,
      "heapDeltaBytes": -31327424,
      "heapUsedBytes": 177771776,
      "domNodes": -8068,
      "jsHeapTotalBytes": 5668864,
      "scriptDurationMs": 107.95100000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 425,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8760.085000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8450.634,
      "heapDeltaBytes": 8256524,
      "heapUsedBytes": 180097516,
      "domNodes": 0,
      "jsHeapTotalBytes": -9175040,
      "scriptDurationMs": 140.07899999999995,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9044.841000000019,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8591.306999999999,
      "heapDeltaBytes": 4662288,
      "heapUsedBytes": 178852764,
      "domNodes": 0,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 158.033,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 470.6499999999778,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 20.317,
      "layouts": 3,
      "layoutDurationMs": 1.213,
      "taskDurationMs": 111.88999999999999,
      "heapDeltaBytes": 5023276,
      "heapUsedBytes": 74442668,
      "domNodes": 147,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 12.064000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 473.5519999999269,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 18.571,
      "layouts": 3,
      "layoutDurationMs": 1.1869999999999996,
      "taskDurationMs": 102.557,
      "heapDeltaBytes": 4916944,
      "heapUsedBytes": 74294320,
      "domNodes": 142,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.028999999999998,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50597 75768 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...components/sidebar/tabs/ModelLibrarySidebarTab.vue 71.42% 2 Missing ⚠️
src/stores/modelStore.ts 83.33% 2 Missing ⚠️
src/platform/assets/services/assetService.ts 87.50% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18728   +/-   ##
=============================================
  Coverage              ?   83.82%           
=============================================
  Files                 ?     2114           
  Lines                 ?   125694           
  Branches              ?    31874           
=============================================
  Hits                  ?   105367           
  Misses                ?    20149           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.78% <64.28%> (?)
unit 78.88% <88.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/graph/useErrorClearingHooks.ts 96.68% <ø> (ø)
src/composables/useCoreCommands.ts 61.70% <100.00%> (ø)
src/extensions/core/widgetInputs.ts 96.07% <100.00%> (ø)
...form/assets/composables/openModelLibraryBrowser.ts 100.00% <100.00%> (ø)
src/platform/assets/utils/assetPreviewUtil.ts 90.47% <100.00%> (ø)
src/platform/missingModel/missingModelPipeline.ts 88.67% <100.00%> (ø)
src/platform/settings/constants/coreSettings.ts 83.60% <ø> (ø)
...sions/vueNodes/widgets/components/WidgetSelect.vue 96.00% <100.00%> (ø)
...ons/vueNodes/widgets/composables/useComboWidget.ts 76.19% <100.00%> (ø)
src/schemas/apiSchema.ts 100.00% <ø> (ø)
... and 5 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@synap5e synap5e added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 24, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @synap5e.

Found 7 finding(s).

Severity Count
🟠 High 1
🟡 Medium 2
🟢 Low 4

Panel: 8/8 reviewers contributed findings.

watch(
() => flags.assetsEnabled,
async (enabled) => {
if (enabled) await withLoadFailureToast(() => modelStore.loadModels())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — This watcher duplicates the watch(() => flags.assetsEnabled) that modelStore now registers, so a single late feature_flags handshake runs both. The store watcher (registered first) snapshots previouslyLoaded and then commits a freshly built, all-Uninitialized folder map, while this callback calls loadModels() on the pre-flip folder objects that still hold the legacy getModelsFunc — wasting a full legacy library walk and discarding the eager load, so folders can render empty with nothing pending to retry. Fold the eager load into the store's reload path (or await the rebuild) instead of watching the flag in two places. Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case, gemini-3.1-pro edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected for this backport: the same code is on main from #17117. Being fixed on main, and that fix will be offered as its own backport.

// Cloud always has assets enabled, so the unmocked asset endpoints would 403
// and workflow restore would throw uncaught. One glob covers every shape boot
// asks for: `/api/assets`, `?query`, `/seed`, `/<id>`.
await page.route('**/api/assets**', (route) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — **/api/assets** answers every GET under the namespace with the list shape, but /api/assets/<id> is parsed against assetItemSchema in getAssetDetails, so it throws "Invalid asset response against zod schema" — reproducing the same uncaught boot-chain abort this mock exists to prevent — and /api/assets/<id>/content, the URL getAssetFileUrl builds for <img>/<video>, serves JSON instead of binary. Scope this route to the list endpoint and mock detail/content separately; the same block is duplicated in checkoutRecovery.spec.ts and pricingTableDeepLink.spec.ts. Raised by 3 of 8 reviewers (gemini-3.1-pro edge-case, claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport. The fixture is identical on main, and no current test fetches those paths.

Comment thread src/stores/modelStore.ts

function createGetModelsFunc(): (folder: string) => Promise<ModelFile[]> {
return usesAssetApi()
return flags.assetsEnabled

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The library's data source (and requestModelScan()'s server-side scan trigger) now follows flags.assetsEnabled alone, while this PR deletes Comfy.Assets.UseAssetAPI — the only user-side opt-out. Per the e2e comments this PR removes, a 403 from the asset endpoints makes workflow restore throw uncaught and abort the GraphCanvas onMounted chain, so after this change there is no kill switch to recover from backend/frontend deploy skew or an asset-service outage; consider retaining a hidden override that forces the legacy source. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, claude-opus-5-thinking-max adversarial).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: retiring Comfy.Assets.UseAssetAPI is the intent of #17117.

Comment thread src/stores/modelStore.ts
watch(
() => flags.assetsEnabled,
() => {
reloadModels().catch((error) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This reload fires during the WS handshake, which is typically while GraphView's boot loadModelFolders() is still in flight; prepareModelFolders() bumps the shared modelFoldersRequestId synchronously, so the boot load is immediately superseded and commits nothing. If api.getModelFolders() rejects here, the catch only reports — neither load commits, leaving modelFolderNames empty with no retry and zero folders in the library until a manual refresh. Retry (or re-run loadModelFolders()) on failure. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport (identical to #17117 on main); noted for main.

import { useToastStore } from '@/platform/updates/common/toastStore'

export async function openModelLibraryBrowser(): Promise<void> {
if (!useFeatureFlags().flags.assetsEnabled) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — When the capability is absent this returns with no dialog, toast, or log, yet Comfy.BrowseModelAssets stays registered unconditionally in useCoreCommands — so invoking it from the command palette or a keybinding against a backend that doesn't advertise assets does nothing at all, where it previously prompted the user. Either surface the unsupported case or gate the command's registration/enabled state on the capability. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: deliberate in #17117. The command does nothing when the server doesn't advertise assets.

Comment thread src/stores/modelStore.ts
* safe by design: prepareModelFolders()'s request-id discipline makes the
* stale response a no-op, so no debouncing is needed here.
*/
watch(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Unlike the scan-completion subscription just above, which skips reloading when nothing has read the store (if (!modelDataConsumed) return), this watcher reloads unconditionally: every install whose handshake advertises assets: true pays a getModelFolders() round-trip plus a bucket-cache invalidation at boot even when no UI has touched the model library, and a backend that flaps the flag across reconnects drives repeated full asset walks. Reusing the modelDataConsumed guard here would cover both. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport (identical to #17117 on main). A modelDataConsumed guard would also leave the boot-built folders on the wrong data source.

EXPECTED_FRONTEND_COMMIT="${EXPECTED_FRONTEND_COMMIT:-$(git rev-parse HEAD)}" \
pnpm test:assets-flag-artifact || {
echo "::error::Cloud frontend failed the Asset API build gate. This check runs on every caller of build-cloud-frontend, including callers unrelated to assets. If your change legitimately affects isAssetAPIEnabled, the build output, or test fixture markers, update scripts/checkAssetsFlagArtifact.ts (see its own error message above for which assertion failed) rather than treating this as an unrelated CI failure."
echo "::error::Cloud frontend failed the widget asset-picker build gate. This check runs on every caller of build-cloud-frontend, including callers unrelated to assets. If your change legitimately affects isWidgetAssetPickerEnabled, the build output, or test fixture markers, update scripts/checkAssetsFlagArtifact.ts (see its own error message above for which assertion failed) rather than treating this as an unrelated CI failure."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The artifact this gate checks is built without ENABLE_MINIFY, while the release workflows build with it on, so the checker's minifier-dependent assumptions (keepNames preserving the declaration name, the !0/!1 body spellings) are never exercised in CI — a minifier change that renames or inlines isWidgetAssetPickerEnabled passes here and only breaks the release artifact. Verify at least one artifact built with the release minification setting. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport. The CI config is identical on main.

christian-byrne pushed a commit that referenced this pull request Sep 25, 2026
…ve node/title/widget state (#18075) (#18759)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789514768597649)_

Manual backport of #18075 to `cloud/1.54`. The automated backport failed
with merge conflicts:
#18075 (comment)

Cherry-picked from `96821ace03bc81d7a29965751a401fcf1818cae3` (`git
cherry-pick -x -m 1`).

## Dependency check

The bot flagged a possible stacking conflict with #18728, #18723 (both
still open against `cloud/1.54`). Neither touches `graphMutations.ts`,
`graphMutations.test.ts`, or `agentConversationFixture.ts` — they are
not the cause of this conflict.

The real causes (same underlying gap as the `core/1.54` backport,
#18758):

- **`graphMutations.ts`** — `cloud/1.54` predates #18191 ("keep the
ghost placement flag out of the document"), which hoisted node flags
into a local `flags` variable (`cloneNodeFlags`) that
`lastSerialization` also started reusing. #18191 is merged to `main` but
carries no `needs-backport` label and was never backported to
`cloud/1.54`. Resolved by keeping `cloud/1.54`'s existing flags handling
(`flags: cloneRecord(payload.flags)` / `lastSerialization:
structuredClone(payload)`) and porting only #18075's actual change:
`resolveNodeTitle(payload, incumbent)` for the title, plus the new
`titleReconcileBaseline` field feeding it.
- **`graphMutations.test.ts`** — pure insertion (no code on the `HEAD`
side of the conflict), accepted the new test cases as-is.
- **`browser_tests/fixtures/agentConversationFixture.ts`** and the new
**`browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts`** —
this Playwright fixture (and the wider main-only agent-test scaffolding
it depends on, e.g. `agentTabSwitchCatchUp.spec.ts`) does not exist on
`cloud/1.54` at all; it isn't introduced by either PR above. Dropped
from this backport, along with the `Topbar.ts#openBlankTabAndReturn()`
helper added only for that spec, so the branch keeps compiling. The
runtime fix ships with its Vitest regression coverage
(`graphMutations.test.ts`, `agentNodeMaterializer.test.ts`); the e2e
visual-proof spec is left for a follow-up once the agent Playwright
fixture infrastructure itself is backported.

## Validation

- `pnpm exec vitest run src/workbench/extensions/agent/crdt` — 827
passed, 5 expected-fail (the intentional `it.fails` cases this PR
introduces/carries).
- `pnpm exec eslint` / `pnpm exec oxfmt --check` clean on all touched
files.
- `pnpm typecheck` clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19

---
_Generated by [Claude
Code](https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19)_

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
comfy-pr-bot pushed a commit that referenced this pull request Sep 25, 2026
…assets flag, retire Comfy.Assets.UseAssetAPI (#18729)

Manual backport of #17117 to `core/1.53`. The automated backport failed
with merge conflicts
(#17117 (comment)).

Cherry-picked from dffad2d (`git
cherry-pick -x`).

## Why

On `core/1.53`, the hidden `Comfy.Assets.UseAssetAPI` setting and the
`Comfy.ToggleAssetAPI` / `Comfy.BrowseModelAssets` palette commands can
put the model library in asset mode against a server that doesn't
advertise the `assets` feature, so it calls `/api/assets` on a backend
that doesn't serve it. This ties the model library, sidebar tab, model
store and those commands to the server assets flag
(`useFeatureFlags().flags.assetsEnabled`) and removes the setting and
toggle command.

## Dependency check

No open PRs target `core/1.53`. As with #18727 (`core/1.54`) and #18728
(`cloud/1.54`), the conflicts are real and come from main-only test-mock
migrations and files that don't exist on this branch.

## Conflict resolution

14 files:

- `.github/actions/build-cloud-frontend/action.yaml`: kept `core/1.53`.
#17117 only reworded a step that isn't present here.
- `scripts/checkAssetsFlagArtifact.ts`,
`scripts/checkAssetsFlagArtifact.test.ts`: not carried. They, and the CI
wiring and build manifest they depend on, come from #16480 and #16570,
which aren't on `core/1.53`. Verified locally that the gate still
compiles to the expected per-distribution constant on this branch.
Adding the check to 1.53 would be a separate backport of those PRs.
- `src/stores/modelStore.ts`, `src/stores/workspace/sidebarTabStore.ts`,
`src/composables/useCoreCommands.ts`: took #17117. `usesAssetApi` and
`Comfy.ToggleAssetAPI` are removed, and `Comfy.BrowseModelAssets` opens
through `openModelLibraryBrowser()`.
- `src/platform/assets/services/assetService.ts`: took the
`isWidgetAssetPickerEnabled` rename and dropped `EXPERIMENTAL_WARNING`.
Kept `core/1.53`'s `result.error ? … : 'Unknown validation error'` guard
in `getAssetDetails`.
- Unit tests (`ModelLibrarySidebarTab.test.ts`,
`useCoreCommands.test.ts`, `assetService.test.ts`,
`assetPreviewUtil.test.ts`, `useComboWidget.test.ts`,
`modelStore.test.ts`, `sidebarTabStore.test.ts`): kept `core/1.53`'s
mocking style and ported only the setting-to-flag change.
`modelStore.test.ts` also takes #17117's `remoteConfig` holder mock so
state doesn't leak between tests.

No other changes from main are included.

## Validation

- `pnpm typecheck` and `pnpm typecheck:browser`: clean
- `eslint` on changed files: clean
- `vitest run` on the touched tests: 292 passed (`modelStore.test.ts`
46/46)
- Local e2e against a real ComfyUI backend without `--enable-assets`,
with a temporary request guard that is not included in this PR:
- Targeted spec: 10/10 passed with no `/api/assets*` requests, including
a user with a stale persisted `Comfy.Assets.UseAssetAPI=true`.
  - Full non-cloud e2e run: no unexpected `/api/assets*` requests.
- Negative control: the same guard on unpatched `core/1.53` recorded
`/api/assets` and `/api/assets/seed` requests with the server flag off.
@synap5e-bot

synap5e-bot Bot commented Sep 25, 2026

Copy link
Copy Markdown

Please hold approval for now: backport-labelled PRs auto-merge as soon as they're approved. This should land together with its backport of #18781, which fixes a model-library load race that #17117 introduced (the folders can stay unloaded when the assets flag arrives late). #18781 is in review on main, and I'll link its backport here once it's up.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.

I force-pushed this branch to strip Co-authored-by trailers for claude/Amp from the commit messages, which is what Check for AI agent co-author trailers was failing on. Message-only rewrite: the tree hash is identical to before, so the code is untouched.

@comfy-pr-bot
comfy-pr-bot merged commit ec1ff25 into cloud/1.54 Sep 25, 2026
98 of 99 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-17117-to-cloud-1.54 branch September 25, 2026 12:12
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 28, 2026
…Comfy-Org#18920)

## The gap

`check-ai-co-authors.sh` reads `%(trailers:key=Co-authored-by)`, so it
only sees what is written in the commit **message**. GitHub regenerates
`Co-authored-by` trailers from the **authors** of the squashed commits
at merge time. A branch with clean messages but AI-authored commits
therefore passes the check and still lands the trailers on the squash
commit.

It is a guardrail that cannot see the artifact that lands.

## Evidence

I hit this directly. Four backports failed the check, I rewrote their
commit messages to strip the trailers (tree hashes identical,
message-only), the check went green, and the squash commits came out
with the trailers restored:

| squash | trailers after merge | commit author |
|---|---|---|
| `7a91c98bf` | 1 | `claude[bot]` |
| `6b182a122` | 1 | `claude[bot]` |
| `a86aef141` | 2 | `Claude <noreply@anthropic.com>` |
| `be9f7c239` | 2 | `Claude <noreply@anthropic.com>` |

The control is the fifth PR in the same batch, Comfy-Org#18728. Same message
rewrite, but its commits are authored by humans, and its squash commit
has **zero** trailers. That is the mechanism confirmed both ways.

## The change

Adds an identity check over `%an <%ae>` and `%cn <%ce>` beside the
existing trailer check, and fixes the remediation advice, which
currently tells you to do the thing that does not work:

```diff
-  git rebase -i <base>            # edit messages — trailers come back on squash
+  git rebase <base> --exec 'git commit --amend --no-edit --reset-author'
```

## Scale, measured on `origin/main`

The two paths are independent and both live:

| window | AI-authored identities | AI trailers in messages |
|---|---|---|
| last 50 | 4 | 15 |
| last 200 | 32 | 113 |
| last 500 | 90 | 251 |

So roughly a third as much again slips through the path the check is
blind to.

## False positives

None found. The last 12 commits on `main` are all human-authored and
pass. Validated against the five real branches above: the four
AI-authored ones exit 1, the human-authored control exits 0. This PR's
own commit passes.

## Not included, deliberately

`Check for AI agent co-author trailers` is **not a required check** on
`main` or on any release branch. This PR only makes it see correctly; it
does not make it block. Given 251 trailer hits in the last 500 commits
on main, turning it into a gate is a separate policy decision with real
in-flight cost, and it should be someone's explicit call rather than a
side effect of a bug fix.

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 7e2b7b1c Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants