Skip to content

[backport cloud/1.54] fix: subgraph-interior widgets don't render in Vue mode after insert_workflow - #18656

Merged
comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-18634-to-cloud-1.54
Sep 24, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-18634-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18634 to cloud/1.54

Automatically created by backport workflow.

…workflow (#18634)

## Summary

Fixes missing Vue widgets on nodes inside a subgraph inserted through
`insert_workflow`.

Multiplayer assigns inserted nodes colon-bearing local IDs. Those IDs
cannot be represented safely as colon-delimited locator or execution
paths, so widget rendering now resolves live nodes from the existing
`(graphId, nodeId)` state instead.

## Changes

- Resolve widget hosts directly within their owning graph without
parsing the local node ID.
- Continue rendering and updating stored widgets when no valid execution
ID exists, while skipping execution-keyed error operations.
- Prevent `LGraph.getNodeById` from returning inherited object
properties.
- Cover the real insert/projection/widget-model path, the
pre-graph-ready fallback, scope collisions, and inherited registry keys.

## Verification

- `pnpm exec vitest run src/lib/litegraph/src/LGraph.test.ts
src/utils/graphTraversalUtil.test.ts
src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts
src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts`
(280 passed)
- `pnpm typecheck:app`
- ESLint, type-aware oxlint, formatting, and Knip passed on the changed
files.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner September 24, 2026 00:25
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 24, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 24, 2026 00:25
@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 24, 2026 12:50am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 24, 2026 12:50am UTC

Request Review

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/24/2026, 12:52:36 AM UTC

Links

🎭 Playwright: ✅ 1945 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1924 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 87ms TBT · 101.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.4 MB heap
vue-large-graph-pan: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 60ms TBT · 173.5 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 221ms TBT · 171.4 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 397ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.7 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 22ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 713ms
canvas-mouse-sweep: script duration 120ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 68.1 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 286ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.0 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 354ms
dom-widget-clipping: script duration 123ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.2 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 518ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.0 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -190
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1290ms
large-graph-pan: script duration 629ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.0 MB
large-graph-pan: DOM nodes -119
large-graph-pan: event listeners -92
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1344ms
large-graph-zoom: script duration 606ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.1 MB
large-graph-zoom: DOM nodes -136
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1625ms
legacy-node-drag: script duration 795ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.3 MB
legacy-node-drag: DOM nodes -278
legacy-node-drag: event listeners -12
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 484ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.8 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -175
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 327ms
subgraph-dom-widget-clipping: script duration 111ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.8 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 406ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.3 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -226
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 21ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 644ms
subgraph-mouse-sweep: script duration 84ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.0 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 713ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 87ms
subgraph-transition-enter: heap used 101.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4582ms
viewport-pan-sweep: script duration 2081ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.7 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14070ms
vue-large-graph-idle: script duration 241ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 136
vue-large-graph-pan: task duration 16889ms
vue-large-graph-pan: script duration 736ms
vue-large-graph-pan: TBT 60ms
vue-large-graph-pan: heap used 173.5 MB
vue-large-graph-pan: DOM nodes -8107
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 61ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5096ms
vue-node-resize-workload: script duration 92ms
vue-node-resize-workload: TBT 221ms
vue-node-resize-workload: heap used 171.4 MB
vue-node-resize-workload: DOM nodes -8070
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6924ms
vue-zoom-out-idle: script duration 101ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 3
workflow-execution: style recalc count 7
workflow-execution: task duration 64ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.9 MB
workflow-execution: DOM nodes 106
workflow-execution: event listeners 33
Raw data
{
  "timestamp": "2026-09-24T01:00:48.195Z",
  "gitSha": "80314e5ce3e6ba855af765a607993bc3670a49f4",
  "branch": "backport-18634-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2020.058000000006,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.395000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.208,
      "heapDeltaBytes": -12155604,
      "heapUsedBytes": 57470480,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.373999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2008.0389999999966,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.654,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.077,
      "heapDeltaBytes": 3039340,
      "heapUsedBytes": 73984612,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.168999999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1762.0860000000107,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 20.941000000000003,
      "layouts": 14,
      "layoutDurationMs": 3.393,
      "taskDurationMs": 720.731,
      "heapDeltaBytes": 8451276,
      "heapUsedBytes": 79231212,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 118.36700000000002,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1742.7050000000008,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 22.105,
      "layouts": 14,
      "layoutDurationMs": 3.49,
      "taskDurationMs": 706.1510000000001,
      "heapDeltaBytes": -6811096,
      "heapUsedBytes": 63581564,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 121.16799999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1657.5789999999984,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.218,
      "layouts": 6,
      "layoutDurationMs": 1.067,
      "taskDurationMs": 292.58399999999995,
      "heapDeltaBytes": 4620016,
      "heapUsedBytes": 75873132,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.557999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.9399999999605,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 11.95,
      "layouts": 6,
      "layoutDurationMs": 0.9530000000000001,
      "taskDurationMs": 280.338,
      "heapDeltaBytes": 4634940,
      "heapUsedBytes": 75116640,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.464,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 532.1880000000192,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.639000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 345.33599999999996,
      "heapDeltaBytes": -8221564,
      "heapUsedBytes": 62904660,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 120.59800000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 541.6129999999839,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.846999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.59200000000004,
      "heapDeltaBytes": 18024516,
      "heapUsedBytes": 88504268,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 124.512,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2036.1489999999662,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.071000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.95199999999994,
      "heapDeltaBytes": 9839284,
      "heapUsedBytes": 86025900,
      "domNodes": -270,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 29.429999999999996,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.4620000000477,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.334000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.97,
      "heapDeltaBytes": 9866304,
      "heapUsedBytes": 86028844,
      "domNodes": -266,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 31.054,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2122.288000000026,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 9.674000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1241.605,
      "heapDeltaBytes": 17405996,
      "heapUsedBytes": 84350384,
      "domNodes": 8,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 616.645,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2161.852999999951,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.009,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1337.713,
      "heapDeltaBytes": 4253188,
      "heapUsedBytes": 81242764,
      "domNodes": -246,
      "jsHeapTotalBytes": 647168,
      "scriptDurationMs": 641.957,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3122.0159999999737,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.316000000000003,
      "layouts": 60,
      "layoutDurationMs": 11.049,
      "taskDurationMs": 1342.7310000000002,
      "heapDeltaBytes": 9161148,
      "heapUsedBytes": 76560436,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 607.831,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3127.8520000000185,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 10.867,
      "layouts": 60,
      "layoutDurationMs": 11.032,
      "taskDurationMs": 1345.885,
      "heapDeltaBytes": 9515132,
      "heapUsedBytes": 76701888,
      "domNodes": -275,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 604.7779999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2272.063000000003,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.192000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1563.3799999999999,
      "heapDeltaBytes": -688016,
      "heapUsedBytes": 81211640,
      "domNodes": -276,
      "jsHeapTotalBytes": -1519616,
      "scriptDurationMs": 758.667,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2566.163999999958,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.674,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1687.344,
      "heapDeltaBytes": 3447856,
      "heapUsedBytes": 85183300,
      "domNodes": -280,
      "jsHeapTotalBytes": -1781760,
      "scriptDurationMs": 831.953,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.699000000031,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.2920000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.35100000000006,
      "heapDeltaBytes": 10029664,
      "heapUsedBytes": 87533552,
      "domNodes": -277,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 27.415000000000003,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.8840000001046,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.981999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.84399999999994,
      "heapDeltaBytes": 4258844,
      "heapUsedBytes": 81934800,
      "domNodes": -279,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 27.269999999999996,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 512.9949999999894,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.98,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 332.94800000000004,
      "heapDeltaBytes": 14230336,
      "heapUsedBytes": 86869616,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 113.20100000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 529.6319999999923,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.046000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 320.82,
      "heapDeltaBytes": 13912832,
      "heapUsedBytes": 86766168,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 109.74400000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.2639999999928,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.405999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 392.47300000000007,
      "heapDeltaBytes": -8556700,
      "heapUsedBytes": 63940116,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.8980000000000015,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.8159999999912,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.269000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.76900000000006,
      "heapDeltaBytes": 7085492,
      "heapUsedBytes": 79345496,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.802999999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.969000000015,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 20.503,
      "layouts": 18,
      "layoutDurationMs": 3.568,
      "taskDurationMs": 633.7470000000001,
      "heapDeltaBytes": -10241612,
      "heapUsedBytes": 62311844,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 82.29299999999999,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.8210000000336,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 21.913999999999994,
      "layouts": 18,
      "layoutDurationMs": 3.803,
      "taskDurationMs": 654.451,
      "heapDeltaBytes": -15859824,
      "heapUsedBytes": 57171812,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 84.889,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 917.1640000000139,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 24.992000000000008,
      "layouts": 17,
      "layoutDurationMs": 11.605999999999998,
      "taskDurationMs": 713.4040000000001,
      "heapDeltaBytes": 21887596,
      "heapUsedBytes": 106231156,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 21.223,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 87,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8176.259000000016,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 33.918,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4561.643999999999,
      "heapDeltaBytes": 4386008,
      "heapUsedBytes": 80715576,
      "domNodes": -274,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 2065.138,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8256.38600000002,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.497,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4602.5650000000005,
      "heapDeltaBytes": 10828300,
      "heapUsedBytes": 86531048,
      "domNodes": -264,
      "jsHeapTotalBytes": 909312,
      "scriptDurationMs": 2097.757,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14749.762999999974,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14185.819,
      "heapDeltaBytes": -40972984,
      "heapUsedBytes": 176637592,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14413824,
      "scriptDurationMs": 240.151,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14631.80699999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13953.474999999999,
      "heapDeltaBytes": -41546212,
      "heapUsedBytes": 176421664,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14938112,
      "scriptDurationMs": 242.19000000000003,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17116.424999999992,
      "styleRecalcs": 128,
      "styleRecalcDurationMs": 14.625,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16824.192000000003,
      "heapDeltaBytes": -36122980,
      "heapUsedBytes": 181573908,
      "domNodes": -8146,
      "jsHeapTotalBytes": -8122368,
      "scriptDurationMs": 732.7099999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 57,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17355.634999999893,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 14.329999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16954.558,
      "heapDeltaBytes": -42187596,
      "heapUsedBytes": 182385216,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17244160,
      "scriptDurationMs": 739.2749999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 62,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5148.143000000005,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.45599999999998,
      "layouts": 20,
      "layoutDurationMs": 21.572000000000006,
      "taskDurationMs": 5060.861999999999,
      "heapDeltaBytes": -42579628,
      "heapUsedBytes": 181836720,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12640256,
      "scriptDurationMs": 85.829,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 255,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5258.644000000004,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.74199999999996,
      "layouts": 20,
      "layoutDurationMs": 20.840999999999998,
      "taskDurationMs": 5130.86,
      "heapDeltaBytes": -62028376,
      "heapUsedBytes": 177521932,
      "domNodes": -8072,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 98.261,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 186,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7244.901999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6936.864,
      "heapDeltaBytes": 18367564,
      "heapUsedBytes": 179154012,
      "domNodes": 0,
      "jsHeapTotalBytes": -13893632,
      "scriptDurationMs": 102.48899999999999,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7303.206000000046,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6910.360999999998,
      "heapDeltaBytes": 7498476,
      "heapUsedBytes": 178577588,
      "domNodes": 0,
      "jsHeapTotalBytes": -21757952,
      "scriptDurationMs": 100.447,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.61600000001681,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.334,
      "layouts": 3,
      "layoutDurationMs": 1.3499999999999999,
      "taskDurationMs": 77.217,
      "heapDeltaBytes": 3181864,
      "heapUsedBytes": 72578332,
      "domNodes": 108,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.397999999999998,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 77.93099999992137,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.237,
      "layouts": 2,
      "layoutDurationMs": 0.6040000000000001,
      "taskDurationMs": 51.565,
      "heapDeltaBytes": 2999504,
      "heapUsedBytes": 71845056,
      "domNodes": 104,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 3.5189999999999997,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50455 75671 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@datadog-official

This comment has been minimized.

src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts
(added by the #18634 backport) imports AgentCrdtProjection from
@/workbench/extensions/agent/crdt/agentCrdtProjection. That module only
exists on main; this release branch's crdt subsystem still uses the
older EcsFollowerAdapter design that predates the AgentCrdtProjection
refactor, so the import fails to resolve here.

This broke typecheck (validate-fonts, e2e build/setup), lint
(import-x/no-unresolved in lint-and-format), and therefore the e2e
Playwright deployment (merge-reports/e2e-status had nothing to merge
because the build never got that far).

The runtime fix in this PR (LGraph.ts, graphTraversalUtil.ts,
processedWidgetRenderModel.ts, useProcessedWidgets.ts and their
existing test files) does not depend on this test. Equivalent
subgraph-interior insert_workflow regression coverage already exists
on this branch via agentSubgraphInsertWorkflow.regression.test.ts and
agentInsertWorkflowWidgets.regression.test.ts, so dropping this one
test file is safe.
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18656   +/-   ##
=============================================
  Coverage              ?   83.75%           
=============================================
  Files                 ?     2110           
  Lines                 ?   125132           
  Branches              ?    33854           
=============================================
  Hits                  ?   104800           
  Misses                ?    20153           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.68% <100.00%> (?)
unit 78.81% <94.44%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraph.ts 77.56% <100.00%> (ø)
...vueNodes/composables/processedWidgetRenderModel.ts 97.20% <100.00%> (ø)
...nsions/vueNodes/composables/useProcessedWidgets.ts 86.66% <100.00%> (ø)
src/utils/graphTraversalUtil.ts 99.40% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit ba16aee into cloud/1.54 Sep 24, 2026
90 of 92 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18634-to-cloud-1.54 branch September 24, 2026 01:13
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 134717f3 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants