Repository navigation
fix: subgraph-interior widgets don't render in Vue mode after insert_workflow - #18634
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2127 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3567e6c570d3f8550f4aad3038cbbd9da37293c5
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.99 MB gzip 🟢 -37 BDetailsSummary
Category Glance App Entry Points — 3.83 kB (baseline 3.83 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • 🟢 -143 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.96 MB (baseline 3.96 MB) • 🔴 +205 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T23:35:41.893Z",
"gitSha": "bf11f82b0796736c891d17d14018135a3b05e301",
"branch": "claude/fix-subgraph-interior-widgets-vue-rendering",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.4779999999919,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.248,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.0899999999999,
"heapDeltaBytes": 11584600,
"heapUsedBytes": 79022368,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.579,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.1300000000083,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.030999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.0970000000001,
"heapDeltaBytes": 4386800,
"heapUsedBytes": 72221408,
"domNodes": -263,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.416,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.0129999999817,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 809.466,
"heapDeltaBytes": -6289156,
"heapUsedBytes": 61264828,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 164.516,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1752.2940000000062,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.251,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.927,
"heapDeltaBytes": 6752528,
"heapUsedBytes": 74361448,
"domNodes": -263,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 160.55999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.1609999999746,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.479000000000001,
"layouts": 6,
"layoutDurationMs": 1.151,
"taskDurationMs": 322.91400000000004,
"heapDeltaBytes": 3112064,
"heapUsedBytes": 70660044,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.359,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.934999999893,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.769000000000002,
"layouts": 6,
"layoutDurationMs": 1.092,
"taskDurationMs": 345.773,
"heapDeltaBytes": 2079624,
"heapUsedBytes": 63158476,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.362999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 691.5329999999926,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.123999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.2699999999999,
"heapDeltaBytes": 18335060,
"heapUsedBytes": 86265400,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 166.738,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 694.0670000000182,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.034000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.59400000000005,
"heapDeltaBytes": 18901736,
"heapUsedBytes": 86555804,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 165.39100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.228999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 864.839,
"heapDeltaBytes": -17469664,
"heapUsedBytes": 72608552,
"domNodes": -294,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 70.614,
"eventListeners": -217,
"totalBlockingTimeMs": 566,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1171.212999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 837.685,
"heapDeltaBytes": 38262500,
"heapUsedBytes": 106191140,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 70.64000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 563,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 881.8569999999681,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.73699999999985,
"heapDeltaBytes": 14917488,
"heapUsedBytes": 89967516,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.93199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 251,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.0970000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.04099999999994,
"heapDeltaBytes": 14259320,
"heapUsedBytes": 90841076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.48499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9730.28800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9001.232000000002,
"heapDeltaBytes": 11195392,
"heapUsedBytes": 93314216,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7671.758,
"eventListeners": 0,
"totalBlockingTimeMs": 1297,
"frameDurationMs": 20.003333333333345,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9248.644000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8499.912,
"heapDeltaBytes": -17060,
"heapUsedBytes": 81912108,
"domNodes": -16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7169.696999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1003,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10230.255,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9317.168,
"heapDeltaBytes": -9853628,
"heapUsedBytes": 72626096,
"domNodes": -14,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7696.003,
"eventListeners": 0,
"totalBlockingTimeMs": 882,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8779.95999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8158.034000000001,
"heapDeltaBytes": -8472188,
"heapUsedBytes": 68995640,
"domNodes": -271,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 6853.599,
"eventListeners": -174,
"totalBlockingTimeMs": 832,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2024.70500000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.544999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.7159999999999,
"heapDeltaBytes": -3718468,
"heapUsedBytes": 83131512,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.138,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.101000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.411999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.304,
"heapDeltaBytes": -6956192,
"heapUsedBytes": 80275948,
"domNodes": -248,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 39.52399999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2349.153000000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.871999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.516,
"heapDeltaBytes": -3713972,
"heapUsedBytes": 84330400,
"domNodes": -245,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 842.1070000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2399.9610000000757,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.437000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1671.0479999999998,
"heapDeltaBytes": -12724860,
"heapUsedBytes": 75169180,
"domNodes": -246,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 829.9960000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3632.684999999981,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.342999999999998,
"layouts": 60,
"layoutDurationMs": 13.101,
"taskDurationMs": 1679.8280000000002,
"heapDeltaBytes": 8283196,
"heapUsedBytes": 74509980,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 794.073,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3640.865000000076,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.850999999999996,
"layouts": 60,
"layoutDurationMs": 12.926,
"taskDurationMs": 1680.464,
"heapDeltaBytes": 11655724,
"heapUsedBytes": 78254208,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.5360000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3141.5890000000104,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.397,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1934.541,
"heapDeltaBytes": 465904,
"heapUsedBytes": 66629588,
"domNodes": 6,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 999.273,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3152.4730000001,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.477999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1853.7769999999998,
"heapDeltaBytes": 31349440,
"heapUsedBytes": 97471348,
"domNodes": 2,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1094.692,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.0539999999878,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.666000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.1029999999998,
"heapDeltaBytes": -4491128,
"heapUsedBytes": 84230016,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.234,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.7260000000388,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.393000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.9659999999999,
"heapDeltaBytes": 20528732,
"heapUsedBytes": 84606636,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.93199999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.0989999999815,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.736999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.299,
"heapDeltaBytes": 13746924,
"heapUsedBytes": 83416748,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.524,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.2660000000769,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.783000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.80400000000003,
"heapDeltaBytes": 14042368,
"heapUsedBytes": 83024340,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.265,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.7649999999535,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.057,
"heapDeltaBytes": -6826116,
"heapUsedBytes": 63287880,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.292000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1998.269999999934,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.802,
"heapDeltaBytes": -9881700,
"heapUsedBytes": 60212396,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.871999999999997,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.3729999999669,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 742.431,
"heapDeltaBytes": 9478416,
"heapUsedBytes": 79181312,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 107.168,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.068000000073,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.603,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.2510000000001,
"heapDeltaBytes": 6527316,
"heapUsedBytes": 76522048,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 104.631,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1366.706000000022,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.125000000000004,
"layouts": 5,
"layoutDurationMs": 13.304,
"taskDurationMs": 874.7689999999999,
"heapDeltaBytes": -6239908,
"heapUsedBytes": 82217632,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.987000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8452.306000000022,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.897999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5769.1669999999995,
"heapDeltaBytes": -10299372,
"heapUsedBytes": 76251540,
"domNodes": -247,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 2787.5679999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8445.474999999988,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.954,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5738.32,
"heapDeltaBytes": -6604384,
"heapUsedBytes": 80254800,
"domNodes": -242,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 2779.994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16796.31599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16378.511000000002,
"heapDeltaBytes": -36672772,
"heapUsedBytes": 197695956,
"domNodes": -8061,
"jsHeapTotalBytes": -9973760,
"scriptDurationMs": 250.645,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17309.200000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16809.987,
"heapDeltaBytes": -73490164,
"heapUsedBytes": 170351688,
"domNodes": -8061,
"jsHeapTotalBytes": -18743296,
"scriptDurationMs": 262.964,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20855.616999999995,
"styleRecalcs": 160,
"styleRecalcDurationMs": 17.941999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20657.291,
"heapDeltaBytes": -37210468,
"heapUsedBytes": 180673272,
"domNodes": -8061,
"jsHeapTotalBytes": -19857408,
"scriptDurationMs": 913.3679999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20438.406999999985,
"styleRecalcs": 162,
"styleRecalcDurationMs": 16.380000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20105.512000000002,
"heapDeltaBytes": -60048524,
"heapUsedBytes": 180830308,
"domNodes": -8061,
"jsHeapTotalBytes": -21172224,
"scriptDurationMs": 865.645,
"eventListeners": -14928,
"totalBlockingTimeMs": 126,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6081.07700000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.772,
"layouts": 20,
"layoutDurationMs": 22.255999999999997,
"taskDurationMs": 5956.002,
"heapDeltaBytes": -73515500,
"heapUsedBytes": 180991788,
"domNodes": -8061,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 102.35100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 382,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6173.110999999949,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.30799999999999,
"layouts": 20,
"layoutDurationMs": 24.514000000000006,
"taskDurationMs": 6082.244000000001,
"heapDeltaBytes": -44698640,
"heapUsedBytes": 177149104,
"domNodes": -8061,
"jsHeapTotalBytes": 10690560,
"scriptDurationMs": 145.47299999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 560,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8469.740000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8329.648000000003,
"heapDeltaBytes": 24850516,
"heapUsedBytes": 200837424,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 128.425,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8445.580000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8249.625999999998,
"heapDeltaBytes": 70860,
"heapUsedBytes": 190065972,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 154.138,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 121.970000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 22.278999999999996,
"layouts": 6,
"layoutDurationMs": 2.5989999999999998,
"taskDurationMs": 104.91199999999998,
"heapDeltaBytes": 3331076,
"heapUsedBytes": 68868340,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.329,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 106.07000000004518,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.583,
"layouts": 2,
"layoutDurationMs": 1.153,
"taskDurationMs": 74.70199999999998,
"heapDeltaBytes": 3055312,
"heapUsedBytes": 68644320,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.169,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
…low nodes Widgets on nodes inside a subgraph inserted via insert_workflow did not render in Vue mode once the subgraph was entered (litegraph rendering and execution were unaffected, since both read node.widgets directly). Root cause: comfy-multi-player's insert_workflow remaps every node id it inserts, including a subgraph DEFINITION's interior nodes, to a derived string carrying colons unrelated to subgraph scoping (e.g. insert:<opId>:root/definition:<defId>:node:<originalId>, remap.ts's derivedId). PR #18604/#18616 (PM-1580) already made createLeafNodeExecutionId/createLeafNodeLocatorId tolerate such a colon-bearing id for a ROOT-owned node, but both explicitly fell back to the strict, delimiter-aware path once the node was subgraph-owned, returning null. computeProcessedWidgets treats a null execution id as "nothing to render" and bails with an empty widget list. Fix: extend the leaf-tolerant handling to a subgraph-owned node too. - nodeIdentification.ts: createLeafNodeLocatorId now encodes a colon-bearing local id as `${subgraphUuid}:${nodeId}` instead of rejecting it; the new parseLeafNodeLocatorId decodes it back by splitting on the first colon only (mirroring stripGraphPrefix's existing technique for widget ids). - graphTraversalUtil.ts: getNodeByLocatorId uses the new leaf-tolerant parser; executionIdFromState's fallback and createExecutionIdFromPath's leaf segment are likewise leaf-tolerant regardless of subgraph ownership; getExecutionIdByNode's root branch uses createLeafNodeExecutionId for symmetry. Verified against real nightly CRDT captures of the "Text to Image (Z-Image-Turbo)" template (Jo Zhang) showing the exact insert:<opId>:root/definition:... id shape at the moment the bug reproduced. Adds insertWorkflowSubgraphInteriorWidgets.regression.test.ts: drives the real insert_workflow pipeline to materialize a subgraph-interior node and asserts computeProcessedWidgets renders it in Vue mode, covering combo, int, float, text and toggle widgets on a synthetic node plus the real CLIPTextEncode/EmptySD3LatentImage/KSampler widget shapes from the Z-Image-Turbo capture.
…s follow-up Extends insertWorkflowSubgraphInteriorWidgets.regression.test.ts with cases Christian asked for after the initial fix: - A second real production template (Jo Zhang's nightly CRDT capture, subgraph definition b0e5ca93-2731-42b9-8e0a-d28ea851ff81): primitive/ utility nodes (PrimitiveStringMultiline, StringConcatenate, PrimitiveBoolean) rather than diffusion-pipeline nodes, covering a different node category. The permutation table is derived from a widgets-by-type data map via Object.entries rather than hand-listed. - A dedicated case for a node the real capture flags `"collapsed": true` on, confirming a collapsed interior node's widgets still resolve in Vue mode. - A subgraph nested two levels deep (host -> outer subgraph -> inner subgraph instance -> leaf), which exercises the execution-id ANCESTOR chain rather than just the leaf id createLeafNodeLocatorId/ createLeafNodeExecutionId cover -- confirmed passing with the existing fix, no further code change needed. - An A -> B -> A live-value-toggle case on a plain interior widget, confirming the fix keeps resolving the current value on repeated changes rather than only at initial materialization. 3D, video/audio, and VHS nodes were checked against the full workflow_templates corpus and do not appear inside any subgraph interior in real templates today (only on the main canvas), so no real fixture exists for them; building one would require synthetic node classes with no more evidentiary value than the widget-type coverage already in this file, so they were left out rather than added as low-value synthetic cases.
f1829d7 to
1886d9c
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
the current head f1829d7c86 is mergeable with zero unresolved review threads, but Check for AI agent co-author trailers fails because both PR commits (4509a69333 and f1829d7c86) contain Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>. The hosted log requires rewriting both messages and force-updating the branch; this lane cannot rewrite another author’s branch. Would you remove those two trailers at the current head and rerun CI? The remaining hosted checks are still active.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18634 +/- ##
==========================================
+ Coverage 83.66% 84.64% +0.97%
==========================================
Files 3019 2294 -725
Lines 148883 131375 -17508
Branches 38451 33647 -4804
==========================================
- Hits 124565 111199 -13366
+ Misses 23015 19876 -3139
+ Partials 1303 300 -1003
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 757 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @DrJKL.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
…interior widgets
Christian asked that every attachment/case from Jo's captures in the
Slack thread be used as test fixtures, not a subset. Adds one describe
block per distinct real production template among the 6 debug reports:
- report 1: "Text to Image (Z-Image-Turbo)" (CLIPTextEncode,
EmptySD3LatentImage, KSampler), including the real prompt text.
- report 4: "Text to Image (Qwen Image 2.1)" (TextEncodeQwenImage21's
two-string-widget shape, a differently-configured KSampler).
- report 2: "Image to Video (MiniMax H3)" - a video-generation node with
a long real production prompt, not a short caption.
- report 3: "Text to Image (Krea-2 Turbo)" prompt-tooling nodes
(StringConcatenate/PrimitiveStringMultiline/PrimitiveBoolean), incl. a
genuinely collapsed StringConcatenate node (id 17) from the capture.
- report 5: "Video Generation (LTX-2.3)", a second real collapsed node
(ComfyMathExpression id 301) from an unrelated template/node type.
report 6 is skipped: its workflow was too large for the debug report to
embed ("omitted: 215626 characters"), and the accompanying event-log
JSON redacts every operation payload (widget values as "[REDACTED]",
other strings as "String(N)" placeholders, no node `type` field), so no
real node type or widget value is recoverable from it at all.
Adds a shared insertRealTemplateSubgraph/renderInteriorWidgetInVueMode
helper pair so each template's fixture is a short node-spec list rather
than five near-duplicate subgraph-building functions.
Leaves nodeIdentification.ts/graphTraversalUtil.ts and the existing
synthetic single test untouched - this is test-only coverage on top of
the current fix.
DrJKL
left a comment
There was a problem hiding this comment.
No blockers remain.
Verified the graph-scoped opaque-ID lookup, null execution-metadata path, live widget updates, scope collisions, inherited registry keys, and the focused regression coverage. The stale description and redundant capture permutations were corrected directly.
src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts (added by the #18634 backport) imports AgentCrdtProjection from @/workbench/extensions/agent/crdt/agentCrdtProjection. That module only exists on main; this release branch's crdt subsystem still uses the older EcsFollowerAdapter design that predates the AgentCrdtProjection refactor, so the import fails to resolve here. This broke typecheck (validate-fonts, e2e build/setup), lint (import-x/no-unresolved in lint-and-format), and therefore the e2e Playwright deployment (merge-reports/e2e-status had nothing to merge because the build never got that far). The runtime fix in this PR (LGraph.ts, graphTraversalUtil.ts, processedWidgetRenderModel.ts, useProcessedWidgets.ts and their existing test files) does not depend on this test. Equivalent subgraph-interior insert_workflow regression coverage already exists on this branch via agentSubgraphInsertWorkflow.regression.test.ts and agentInsertWorkflowWidgets.regression.test.ts, so dropping this one test file is safe.
src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts (added by the #18634 backport) imports AgentCrdtProjection from @/workbench/extensions/agent/crdt/agentCrdtProjection. That module only exists on main; this release branch's crdt subsystem still uses the older EcsFollowerAdapter design that predates the AgentCrdtProjection refactor, so the import fails to resolve here. This broke typecheck (validate-fonts, e2e build/setup), lint (import-x/no-unresolved in lint-and-format), and therefore the e2e Playwright deployment (merge-reports/e2e-status had nothing to merge because the build never got that far). The runtime fix in this PR (LGraph.ts, graphTraversalUtil.ts, processedWidgetRenderModel.ts, useProcessedWidgets.ts and their existing test files) does not depend on this test. Equivalent subgraph-interior insert_workflow regression coverage already exists on this branch via agentSubgraphInsertWorkflow.regression.test.ts and agentInsertWorkflowWidgets.regression.test.ts, so dropping this one test file is safe.
Cursor review follow-ups on #18679 (backport of #18634): - LGraph._nodes_by_id was a plain object literal, so a node id of "__proto__" (accepted by parseNodeId) would repoint the object's prototype on add() instead of creating an own key, permanently hiding that node from getNodeById's new Object.hasOwn guard. Use Object.create(null) so every node id, including "__proto__", is a normal own property. - widgetNodeLocatorId rejected every colon-bearing bareWidgetId, but createLeafNodeLocatorId already tolerates a colon for root-owned ids (no subgraph to disambiguate from) while rejecting it for subgraph-owned ones. Restore that tolerant constructor plus its `?? undefined` normalization so root-owned opaque ids (comfy-multi- player's insert_workflow remapped ids) keep a working nodeLocatorId instead of losing it, and no null return value leaks past this function's NodeLocatorId | undefined contract.
…workflow (#18634) ## Summary Fixes missing Vue widgets on nodes inside a subgraph inserted through `insert_workflow`. Multiplayer assigns inserted nodes colon-bearing local IDs. Those IDs cannot be represented safely as colon-delimited locator or execution paths, so widget rendering now resolves live nodes from the existing `(graphId, nodeId)` state instead. ## Changes - Resolve widget hosts directly within their owning graph without parsing the local node ID. - Continue rendering and updating stored widgets when no valid execution ID exists, while skipping execution-keyed error operations. - Prevent `LGraph.getNodeById` from returning inherited object properties. - Cover the real insert/projection/widget-model path, the pre-graph-ready fallback, scope collisions, and inherited registry keys. ## Verification - `pnpm exec vitest run src/lib/litegraph/src/LGraph.test.ts src/utils/graphTraversalUtil.test.ts src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts` (280 passed) - `pnpm typecheck:app` - ESLint, type-aware oxlint, formatting, and Knip passed on the changed files. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Amp <amp@ampcode.com>
Cursor review follow-ups on #18679 (backport of #18634): - LGraph._nodes_by_id was a plain object literal, so a node id of "__proto__" (accepted by parseNodeId) would repoint the object's prototype on add() instead of creating an own key, permanently hiding that node from getNodeById's new Object.hasOwn guard. Use Object.create(null) so every node id, including "__proto__", is a normal own property. - widgetNodeLocatorId rejected every colon-bearing bareWidgetId, but createLeafNodeLocatorId already tolerates a colon for root-owned ids (no subgraph to disambiguate from) while rejecting it for subgraph-owned ones. Restore that tolerant constructor plus its `?? undefined` normalization so root-owned opaque ids (comfy-multi- player's insert_workflow remapped ids) keep a working nodeLocatorId instead of losing it, and no null return value leaks past this function's NodeLocatorId | undefined contract.
…workflow (#18634) ## Summary Fixes missing Vue widgets on nodes inside a subgraph inserted through `insert_workflow`. Multiplayer assigns inserted nodes colon-bearing local IDs. Those IDs cannot be represented safely as colon-delimited locator or execution paths, so widget rendering now resolves live nodes from the existing `(graphId, nodeId)` state instead. ## Changes - Resolve widget hosts directly within their owning graph without parsing the local node ID. - Continue rendering and updating stored widgets when no valid execution ID exists, while skipping execution-keyed error operations. - Prevent `LGraph.getNodeById` from returning inherited object properties. - Cover the real insert/projection/widget-model path, the pre-graph-ready fallback, scope collisions, and inherited registry keys. ## Verification - `pnpm exec vitest run src/lib/litegraph/src/LGraph.test.ts src/utils/graphTraversalUtil.test.ts src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts` (280 passed) - `pnpm typecheck:app` - ESLint, type-aware oxlint, formatting, and Knip passed on the changed files. ---------
Cursor review follow-ups on #18679 (backport of #18634): - LGraph._nodes_by_id was a plain object literal, so a node id of "__proto__" (accepted by parseNodeId) would repoint the object's prototype on add() instead of creating an own key, permanently hiding that node from getNodeById's new Object.hasOwn guard. Use Object.create(null) so every node id, including "__proto__", is a normal own property. - widgetNodeLocatorId rejected every colon-bearing bareWidgetId, but createLeafNodeLocatorId already tolerates a colon for root-owned ids (no subgraph to disambiguate from) while rejecting it for subgraph-owned ones. Restore that tolerant constructor plus its `?? undefined` normalization so root-owned opaque ids (comfy-multi- player's insert_workflow remapped ids) keep a working nodeLocatorId instead of losing it, and no null return value leaks past this function's NodeLocatorId | undefined contract.
…workflow (#18634) ## Summary Fixes missing Vue widgets on nodes inside a subgraph inserted through `insert_workflow`. Multiplayer assigns inserted nodes colon-bearing local IDs. Those IDs cannot be represented safely as colon-delimited locator or execution paths, so widget rendering now resolves live nodes from the existing `(graphId, nodeId)` state instead. ## Changes - Resolve widget hosts directly within their owning graph without parsing the local node ID. - Continue rendering and updating stored widgets when no valid execution ID exists, while skipping execution-keyed error operations. - Prevent `LGraph.getNodeById` from returning inherited object properties. - Cover the real insert/projection/widget-model path, the pre-graph-ready fallback, scope collisions, and inherited registry keys. ## Verification - `pnpm exec vitest run src/lib/litegraph/src/LGraph.test.ts src/utils/graphTraversalUtil.test.ts src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts` (280 passed) - `pnpm typecheck:app` - ESLint, type-aware oxlint, formatting, and Knip passed on the changed files. ---------
Summary
Fixes missing Vue widgets on nodes inside a subgraph inserted through
insert_workflow.Multiplayer assigns inserted nodes colon-bearing local IDs. Those IDs cannot be represented safely as colon-delimited locator or execution paths, so widget rendering now resolves live nodes from the existing
(graphId, nodeId)state instead.Changes
LGraph.getNodeByIdfrom returning inherited object properties.Verification
pnpm exec vitest run src/lib/litegraph/src/LGraph.test.ts src/utils/graphTraversalUtil.test.ts src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts src/renderer/extensions/vueNodes/composables/insertWorkflowSubgraphInteriorWidgets.regression.test.ts(280 passed)pnpm typecheck:app