Repository navigation
fix(agent): defer the consent offer past the first-run screen instead of dropping it - #18966
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2157 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 05e11df67758f0bfcc3853adefb5aa2aaa7717cb
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip 🟢 -5.29 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.45 MB) • 🔴 +4.4 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • 🔴 +22 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 4.02 MB (baseline 4.04 MB) • 🟢 -23 kBStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • 🟢 -141 BBundles that do not match a named category
Status: 82 added / 82 removed / 218 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-28T21:26:06.949Z",
"gitSha": "cae5fc406882e0e5202db958961ffb478ca3e09a",
"branch": "fix/agent-consent-defer-first-run-screen",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.137000000016,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.406,
"heapDeltaBytes": -660176,
"heapUsedBytes": 78062088,
"domNodes": -228,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 13.756999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2056.4749999999776,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.404,
"heapDeltaBytes": -30536396,
"heapUsedBytes": 67786500,
"domNodes": -228,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 16.741,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80327868852459,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1935.498999999993,
"styleRecalcs": 73,
"styleRecalcDurationMs": 20.825999999999997,
"layouts": 12,
"layoutDurationMs": 5.481,
"taskDurationMs": 844.8849999999999,
"heapDeltaBytes": 340932,
"heapUsedBytes": 79023024,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 192.93600000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.811304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1877.179999999953,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.88,
"layouts": 12,
"layoutDurationMs": 5.001,
"taskDurationMs": 939.376,
"heapDeltaBytes": -36038572,
"heapUsedBytes": 62350064,
"domNodes": -228,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 178.15800000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665178571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1775.8759999999825,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.974000000000002,
"layouts": 6,
"layoutDurationMs": 1.3610000000000002,
"taskDurationMs": 464.33699999999993,
"heapDeltaBytes": -22806460,
"heapUsedBytes": 75653752,
"domNodes": -175,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 16.589999999999996,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.8889999999483,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.647,
"layouts": 6,
"layoutDurationMs": 1.3479999999999999,
"taskDurationMs": 398.14000000000004,
"heapDeltaBytes": -18846788,
"heapUsedBytes": 79739404,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 15.712,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 687.135000000012,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.215999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.60600000000005,
"heapDeltaBytes": 18188632,
"heapUsedBytes": 96870536,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 178.72899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926843,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 751.5879999999697,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.515,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.486,
"heapDeltaBytes": -1913904,
"heapUsedBytes": 96323300,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 179.19600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909075,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1205.7099999999537,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 858.924,
"heapDeltaBytes": 6627040,
"heapUsedBytes": 82530868,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 76.74900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 559,
"frameDurationMs": 35.294117647058826,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1221.037000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.814,
"heapDeltaBytes": 8917628,
"heapUsedBytes": 86103500,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 69.989,
"eventListeners": 0,
"totalBlockingTimeMs": 589,
"frameDurationMs": 35.782352941176484,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.7329999999683,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.4720000000004,
"heapDeltaBytes": 15443440,
"heapUsedBytes": 90026052,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 178.12499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 25.23714285714289,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 893.3379999999715,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.3370000000001,
"heapDeltaBytes": 13990280,
"heapUsedBytes": 93137844,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 175.118,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.237142857142835,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10525.721999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9664.384,
"heapDeltaBytes": 1409808,
"heapUsedBytes": 81997404,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 8205.886,
"eventListeners": 0,
"totalBlockingTimeMs": 1515,
"frameDurationMs": 35.648474576271184,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10986.323000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9999.352,
"heapDeltaBytes": -13977576,
"heapUsedBytes": 66611676,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 8270.56,
"eventListeners": 0,
"totalBlockingTimeMs": 1277,
"frameDurationMs": 32.686904761904756,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11708.976000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10634.500000000002,
"heapDeltaBytes": -5201272,
"heapUsedBytes": 69539792,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 8841.532,
"eventListeners": 0,
"totalBlockingTimeMs": 1691,
"frameDurationMs": 33.81387283236994,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9375.377999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8670.989,
"heapDeltaBytes": -792872,
"heapUsedBytes": 79163816,
"domNodes": 0,
"jsHeapTotalBytes": -15728640,
"scriptDurationMs": 7339.594,
"eventListeners": 0,
"totalBlockingTimeMs": 1067,
"frameDurationMs": 34.43492647058824,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2054.052000000013,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.484000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.129,
"heapDeltaBytes": -36183876,
"heapUsedBytes": 81945264,
"domNodes": -228,
"jsHeapTotalBytes": 688128,
"scriptDurationMs": 36.512,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.742999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7009999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 717.145,
"heapDeltaBytes": -36810184,
"heapUsedBytes": 81837044,
"domNodes": -228,
"jsHeapTotalBytes": -98304,
"scriptDurationMs": 41.489,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3011.4869999999883,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.177000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1781.278,
"heapDeltaBytes": 339844,
"heapUsedBytes": 63040000,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 909.4300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666111111111114,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2644.903999999997,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1570.085,
"heapDeltaBytes": 23235436,
"heapUsedBytes": 85944824,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 884.1999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77261146496816,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3981.2410000000114,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.225,
"layouts": 60,
"layoutDurationMs": 14.623,
"taskDurationMs": 1876.066,
"heapDeltaBytes": 10210880,
"heapUsedBytes": 73894240,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 865.958,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66569037656904,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3630.4569999999785,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.272000000000002,
"layouts": 60,
"layoutDurationMs": 13.841,
"taskDurationMs": 1579.114,
"heapDeltaBytes": 5720448,
"heapUsedBytes": 69786052,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 803.7149999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666513761467886,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3124.4950000000244,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.868999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2022.3460000000002,
"heapDeltaBytes": 411768,
"heapUsedBytes": 64545032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1015.7669999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846486486486484,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3146.0739999999987,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.951000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2060.137,
"heapDeltaBytes": 25825584,
"heapUsedBytes": 89580304,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1044.319,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.844385026737967,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.3929999999746,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.568,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.12,
"heapDeltaBytes": 20521580,
"heapUsedBytes": 82916556,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.33500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.7220000000261,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.963,
"heapDeltaBytes": -38410912,
"heapUsedBytes": 82720480,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 35.62399999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 642.5440000000435,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.507000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.37899999999996,
"heapDeltaBytes": 12351768,
"heapUsedBytes": 93554440,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 148.703,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 722.6499999999305,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.979999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.49399999999997,
"heapDeltaBytes": -19896288,
"heapUsedBytes": 60606324,
"domNodes": -214,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 150.49400000000003,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06428571428571,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2036.5620000000035,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.1919999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.1830000000001,
"heapDeltaBytes": -19606560,
"heapUsedBytes": 61603316,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 12.221,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2031.53999999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.511,
"heapDeltaBytes": -18014832,
"heapUsedBytes": 63297396,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.31,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1765.4830000000175,
"styleRecalcs": 58,
"styleRecalcDurationMs": 19.346,
"layouts": 16,
"layoutDurationMs": 6.668,
"taskDurationMs": 872,
"heapDeltaBytes": -3262528,
"heapUsedBytes": 76063548,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 127.161,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.824761904761907,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1748.3670000000302,
"styleRecalcs": 60,
"styleRecalcDurationMs": 19.268,
"layouts": 16,
"layoutDurationMs": 6.003,
"taskDurationMs": 866.043,
"heapDeltaBytes": -18147568,
"heapUsedBytes": 61714780,
"domNodes": -215,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 122.293,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.5679999999365,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.504,
"layouts": 5,
"layoutDurationMs": 12.807999999999996,
"taskDurationMs": 918.4169999999998,
"heapDeltaBytes": 21725468,
"heapUsedBytes": 102976268,
"domNodes": 13667,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 29.938,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 19.36621621621621,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10860.478999999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.897,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6680.046,
"heapDeltaBytes": -35565632,
"heapUsedBytes": 82950376,
"domNodes": -228,
"jsHeapTotalBytes": -430080,
"scriptDurationMs": 3177.136,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9614.593000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.694,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6231.089,
"heapDeltaBytes": -39530600,
"heapUsedBytes": 78458312,
"domNodes": -228,
"jsHeapTotalBytes": -430080,
"scriptDurationMs": 2933.9300000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69513043478261,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17288.577000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16848.734999999997,
"heapDeltaBytes": -61667052,
"heapUsedBytes": 163011528,
"domNodes": -3045,
"jsHeapTotalBytes": 8617984,
"scriptDurationMs": 289.294,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.309239130434783,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 17232.297000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17037.707000000002,
"heapDeltaBytes": -53628360,
"heapUsedBytes": 169042144,
"domNodes": -3046,
"jsHeapTotalBytes": 7704576,
"scriptDurationMs": 304.562,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.92263779527559,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 20924.992999999973,
"styleRecalcs": 161,
"styleRecalcDurationMs": 17.405000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20611.77,
"heapDeltaBytes": -18331208,
"heapUsedBytes": 179211120,
"domNodes": -3045,
"jsHeapTotalBytes": 8593408,
"scriptDurationMs": 909.664,
"eventListeners": -14915,
"totalBlockingTimeMs": 66,
"frameDurationMs": 39.71992409867173,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 21109.084000000053,
"styleRecalcs": 148,
"styleRecalcDurationMs": 20.273000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20984.323,
"heapDeltaBytes": -32133444,
"heapUsedBytes": 167388528,
"domNodes": -3051,
"jsHeapTotalBytes": 7442432,
"scriptDurationMs": 925.9519999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 153,
"frameDurationMs": 41.2744140625,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5936.0499999999665,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.30699999999999,
"layouts": 20,
"layoutDurationMs": 23.114999999999995,
"taskDurationMs": 5834.267,
"heapDeltaBytes": -5989768,
"heapUsedBytes": 173624320,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 104.691,
"eventListeners": 0,
"totalBlockingTimeMs": 398,
"frameDurationMs": 34.696491228070165,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4839.350000000081,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.75899999999997,
"layouts": 20,
"layoutDurationMs": 25.750999999999998,
"taskDurationMs": 4725.763,
"heapDeltaBytes": 14353320,
"heapUsedBytes": 211499320,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 94.78899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 165,
"frameDurationMs": 29.0144578313253,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8589.470000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8263.189,
"heapDeltaBytes": -28564256,
"heapUsedBytes": 185970204,
"domNodes": -3046,
"jsHeapTotalBytes": 12324864,
"scriptDurationMs": 129.62700000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.49484536082474,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8880.625999999893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8774.421000000002,
"heapDeltaBytes": -61927304,
"heapUsedBytes": 167025716,
"domNodes": -3046,
"jsHeapTotalBytes": 6787072,
"scriptDurationMs": 227.36200000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 36,
"frameDurationMs": 34.84133858267715,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 490.8950000000232,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.106,
"layouts": 3,
"layoutDurationMs": 1.0040000000000002,
"taskDurationMs": 171.49299999999997,
"heapDeltaBytes": -43884084,
"heapUsedBytes": 52468204,
"domNodes": -201,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.130999999999998,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 217.28800000005322,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.192000000000002,
"layouts": 3,
"layoutDurationMs": 1.526,
"taskDurationMs": 196.546,
"heapDeltaBytes": -43797732,
"heapUsedBytes": 52540176,
"domNodes": 94,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.505000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1148.0700000000752,
"styleRecalcs": 78,
"styleRecalcDurationMs": 122.524,
"layouts": 76,
"layoutDurationMs": 27.525000000000002,
"taskDurationMs": 1133.4920000000002,
"heapDeltaBytes": -4514444,
"heapUsedBytes": 67300572,
"domNodes": 76,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 486.389,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1079.1380000000572,
"styleRecalcs": 78,
"styleRecalcDurationMs": 119.287,
"layouts": 76,
"layoutDurationMs": 27.413,
"taskDurationMs": 1040.666,
"heapDeltaBytes": 19347076,
"heapUsedBytes": 91795156,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 427.962,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.195238095238114,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1495.3460000000405,
"styleRecalcs": 78,
"styleRecalcDurationMs": 280.596,
"layouts": 76,
"layoutDurationMs": 27.546,
"taskDurationMs": 1481.405,
"heapDeltaBytes": -18353832,
"heapUsedBytes": 110888628,
"domNodes": 76,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 491.589,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.9873417721519,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1401.2050000000045,
"styleRecalcs": 78,
"styleRecalcDurationMs": 247.295,
"layouts": 76,
"layoutDurationMs": 25.564,
"taskDurationMs": 1378.6100000000001,
"heapDeltaBytes": 9008048,
"heapUsedBytes": 115639284,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 460.007,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.487654320987655,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe Getting Started screen now hands off to the first-run tour through the first-run entry composable. The entry holds the screen during the handoff and cancels pending tour starts when the signed-in user changes. The agent panel defers automatic offers while the screen hold or another blocker is active. ChangesFirst-run handoff and consent offer
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant GettingStartedScreen
participant useFirstRunEntry
participant useFirstRunTourController
GettingStartedScreen->>useFirstRunEntry: dismissIntoFirstRunTour(templateId)
useFirstRunEntry->>useFirstRunTourController: beginTour(templateId)
useFirstRunTourController-->>useFirstRunEntry: resolve or reject
useFirstRunEntry-->>GettingStartedScreen: resolve or propagate rejection
Suggested reviewers: Merge Risk: 🔵 Low · up to If sign-in completes during first-run tour startup, the tour may stop while the renderer setting remains enabled. This is a bounded issue to address or explicitly accept before merging. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR title and commit subjects use the bug-fix signal ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18966 +/- ##
==========================================
+ Coverage 84.21% 85.12% +0.91%
==========================================
Files 3197 2341 -856
Lines 156127 134780 -21347
Branches 42427 34570 -7857
==========================================
- Hits 131480 114736 -16744
+ Misses 23000 19690 -3310
+ Partials 1647 354 -1293
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 870 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Found this while adding the dismissal event that supplies this PR's missing denominator (#18973) — I The template path dismisses the screen ~500 ms before the tour becomes active. const result = await loadWorkflowTemplate(id, 'default')
if (result === 'loaded') {
await dismissGettingStarted() // gettingStartedVisible = false
await beginTour(id) // ...and only thenand So for those 500 ms The test does not catch it because it encodes the opposite ordering. activeTour.value = 'firstRun' // tour active *first*
gettingStartedVisible.value = false // then dismissedProduction dismisses first and starts the tour 500 ms later, so the sequence the test is named for is I have not verified this in a browser — it is read off the code and the test, so treat it as a Tracked on our side as |
|
Fixed in The mechanism, re-derived at
So on the One thing the original report understated: the window is not only the 500 ms preview. It opens before The fix. Deliberately not a debounce on The test named for this behaviour was part of the defect and is rewritten. What the handoff does across the preview is pinned with real code and fake timers in One correction to this PR's first commit message, worth having on the record before review. It says the
Checks: full unit suite green (1705 files, 24,303 passed, 32 expected-fail), Merge is still yours. |
… can reach `records an unsettled consent read when identity changes before a held card mounts` took the first-run screen *inside* the `withConsent` mock. No production ordering does that: `showFirstRunScreen` runs once per page load, from `handleStartupOutcome`, and always before it sets `startupDecided` — which every automatic offer waits on. So once an offer is in flight the first-run hold can only fall, never rise, and `tourHandoffs` only rises from a template click on the rendered screen, which holds the offer before it is ever made. The test needs *some* holder so `canShow` calls `holdOffer` and the `consent_read_outcome` can be asserted; it does not need that one. A coachmark tour opening over an in-flight offer is a real ordering and is already used by `withholds a card whose tour started while the offer was in flight`, so the arrange uses it and the reported reason becomes `tour_active`. What the test pins is unchanged: an identity change before `canShow` is recorded as `not_yet_determined`. Forcing `consentStore.isChecking` to read false still fails exactly this test and nothing else. This also removes this PR's only reference to the mock ref `firstRunTookScreen`, which #18966 renames to `firstRunHoldsScreen`, so the rebase onto #18966 no longer has a rename to carry here.
Merge order for the four open PRs on
|
| PR | head | merge-base | contains 0e72565c8b (the handoff guard)? |
|---|---|---|---|
| #18966 | 0e72565c8b |
45ef910992 (main) |
— it is it |
| #18975 | c838834aae |
384f6eb03e |
no |
| #18976 | 12f63a8edc |
45ef910992 (main) |
no |
| #18977 | 0c10ad2875 |
0e72565c8b |
yes |
This repo is squash-merge only with delete_branch_on_merge, so when #18966 lands its branch goes
away and #18975/#18977 are retargeted to main with a stale merge-base — each one needs a rebase onto
main before it can land, whatever order is chosen. The order below is picked to make those rebases
cheap and to keep every guard in the file.
Recommended order
1. #18966 — nothing needed. It is the only one of the four whose base is main and whose content
the others build on (firstRunHoldsScreen, and the mock-ref rename in the test file). #18975 and
#18977 are branched off it, so it cannot go later.
2. #18977 — rebase onto main, no content change. Test-only, so zero production risk, and it puts
the reason-precedence pin and the renamed unreachable-arrange guard into the file before the two PRs
that add to it. (Order 2↔3 is free: #18975-then-#18977 was also verified clean, 72 green either way.)
3. #18975 — rebase onto main, no content change. Note it is currently missing 0e72565c8b: its
merge-base is 384f6eb03e, so no branch today shows both its release-watcher change and the handoff
guard together. That combination is now verified (below).
4. #18976 — rebase onto main, carrying 3 lines. It is the only PR that has to touch every
notOffered() assertion in the file (consent_read_outcome is a required property), so landing it last
concentrates that work into one rebase on the PR that owns the property. Measured the other way round:
#18976-first costs 4 assertion edits spread across the other three PRs plus resolving its own arrange.
The exact residual patch is in a comment on #18976.
What was verified, and in which combinations
Composed locally in a worktree off the canonical clone. Every run npx vitest run src/extensions/core/agentPanel.test.ts, --testTimeout=30000 (see the note at the end).
| tree | result |
|---|---|
0e72565c8b (#18966 alone) |
70 passed |
0c10ad2875 (+#18977) |
71 passed |
| +#18975 cherry-picked (no conflict) | 72 passed |
| +#18976 rebased, before the fix below | 4 failed / 69 passed, 73 total |
| +#18976 rebased, after the fix and the 3-line residual | 73 passed |
| #18966 → #18975 → #18977 (2↔3 swapped) | 72 passed |
| #18976 → #18966 (reverse order probe) | 2 failed / 69 passed |
On the full stack: vue-tsc --noEmit exit 0, and 258 files / 4,318 passed / 17 expected-fail across
src/extensions/core/, src/renderer/extensions/firstRunTour/, src/workbench/extensions/agent/,
src/platform/telemetry/, src/stores/dialogStore.test.ts, src/views/GraphView.test.ts,
src/components/graph/GraphCanvas.test.ts.
The four mutation probes that #18977's audit used all still isolate exactly one test each in the
composition with #18975 (i.e. gc-17's release-watcher rewrite does not blunt them):
| mutation | fails |
|---|---|
canShow's heldAtMount = screenHolder() → screenBusyReason() |
1 — withholds a card the first run comes to own mid-offer |
screenHolder reads gettingStartedVisible instead of firstRunHoldsScreen |
1 — keeps waiting when Getting Started closes straight into the first-run tour |
| reason precedence swapped | 1 — reports the first-run screen over a dialog sitting on top of it |
restore offerHeld.value = false in the release watcher |
1 — keeps the held offer when the retry cannot be made |
The one real hazard, and it is silent
#18976 added a second arrange of the ordering #18977 audited out — firstRunTookScreen.value = true
inside the withConsent mock, which no production ordering reaches. Under the natural rebase
resolution (rename the ref the way #18966 renames it) the suite is 73 passed, fully green, with the
unreachable arrange back in the file. Demonstrated locally. That is why it was fixed on #18976's
branch now rather than left to the rebase: a rebase conflict is loud, but this one is not a conflict.
Not done here
No merges, no force-pushes, no production change, and no rewriting of anyone's commits. The only push
was one follow-up commit to #18976's branch (12f63a8edc, fast-forward). Precondition re-checked
immediately before it: open, non-draft, not a fork, same author, no human approval to dismiss
(reviewDecision empty; the only review on any of the four is a bot).
Note on the local test runs: under machine load the default 5s vitest timeout makes two cases in this
file (attributes automatic acceptance with a restored open preference…, keeps the panel closed if the feature is disabled before acceptance) time out rather than fail. Both pass in 160ms and 112ms when run
alone. Every figure above is from --testTimeout=30000 so load could not be mistaken for a result.
Correction to the merge-base table above, and one more verified tree#18966's merge-base with
The key fact is unchanged and is a merge-base against the branch, not against Nothing in the recommended order moves. All four are behind One more tree, since the tables above all sit on |
Merge order refreshed: the set is eleven PRs, not fourFollow-up to #18966#issuecomment-5845318276 (and its correction #18966#issuecomment-5845377646). That Everything below is measured in one worktree off 1. The set, and the topology as it actually is
Two chains hang off #18966, and they fork at different commits. The earlier note said #18975 lacks git merge-base --is-ancestor 0e72565c8b 4674bdf340 # exit 1
git merge-base --is-ancestor 0e72565c8b 1ad757e290 # exit 12. Which PRs interact, by fileNone of the eleven is independent. Every one touches at least one file another touches — which is the
So there are two shared surfaces. The first pass ordered the 3. The order
10 ↔ 11 is free — verified both ways, same end tree, same single resolution. Still true and still the thing to carry: this repo is squash-merge only with 4. Verification — the whole set composed in one tree, in this orderNot each PR against its own base. That is what hid the problem the first time.
The 92 is exact rather than merely green: A symbol-level audit of the composed tree as well, because a green suite is not a completeness proof here Cost of this order: three resolution points plus the residual.
The alternative I checked — group the first-run family early (#18966 → #18973 → #18986 → …) — reaches an 5. One hazard worth more than the order itself
Dropping that one entry costs one test out of 574 and nothing else says a word. Four of the five files And 6. Review state, re-checked rather than citedNo human review exists on any of the eleven. Every review on every one of them is Nothing was merged, approved, rebased or force-pushed for this. No branch was pushed to — every tree above Method reused from #18966#issuecomment-5845318276. Full receipt, including the two instrument failures |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: approved at 6b8274a254.
I found no unresolved correctness, maintainability, type-safety, test-design, or documentation blocker on the final head.
Current documentation receipt
- The reviewed head is
6b8274a254; its base is40a2b58225. - First-run screen ownership is now one
FirstRunScreenState(released,visible, orhandoff), not separate visible-screen and durable-hold refs. - Tour startup likewise uses one
TourStartStatefor ownership, renderer restoration, in-flight persistence, and preview state.
Checked and cleared
- Consolidated correlated tour-start fields into the discriminated state and removed the duplicated claim/cancel transfer path.
- Added the missing ownership check before a delayed preview starts the tour; the overlapping-preview regression now proves that only the latest owner reaches the engine.
- Removed the 20-call startup-decision escape hatch that could hide retry loops.
- Replaced repeated renderer-setting race doubles with one stateful deferred fake and covered successful successor adoption.
- Removed redundant screen/tour cross-product, simple account-change, and browser Skip/reload coverage while retaining the stronger falsifiers.
- Replaced call-order and copied 500 ms tests with observable screen state and a deferred tour boundary.
- Removed narrative comments and assertion prose that repeated the code or test title.
- Split handoff completion into a small pure transition; changed-line Fallow reports complexity 0 and no findings.
Exact-head verification
- Focused Vitest: 4 files, 230 tests passed.
- Cloud Playwright regression: 5/5 passed from a fresh cloud build.
pnpm build,pnpm build:cloud, app and browser typechecks, full lint, full format check, Knip,git diff --check, and the pre-push changed-line Fallow gate passed.
|
|
|
|
Releasing a held consent offer also consumed the hold, before anything had checked whether the retry could actually happen. Everything the release triggers is asynchronous and exits early in several transient ways — the consent read rejecting, an offer already in flight, a workspace mid-switch, an account not resolved yet — and none of those exits re-armed the hold. Any one of them therefore lost the offer for the rest of the page load, silently: no card, and no second `agent_consent_not_offered` either, because the reason is deduplicated per page load. The hold is now dropped only where the offer has been made or has become moot (consent already accepted, the card already seen this page load, the one-shot key already burned). A transient exit leaves it armed, so the next clear screen retries. An attempt that was refused by the in-flight guard also gets a wake-up when that attempt settles, since `whenever` only fires on a transition and the screen may have gone clear again in the meantime. Stacked on #18966, which arms the hold for `first_run_screen` as well and so routes a fourth reason through this same release path. Consent semantics are untouched: same copy, same recorded decision, still required before the panel opens, and the panel is not auto-opened.
… of dropping it (#18966) Defers the automatic Agent consent offer while Getting Started owns the screen, then re-offers it in the same session after that ownership ends. The template path keeps first-run ownership across the dismissal-to-tour preview gap, so the consent card cannot open underneath the tour. The first-session entry-button/feature-flag timing question is separate and is not changed here. - Arms the consent retry for `first_run_screen` instead of dropping that offer. - Uses live first-run screen ownership, including pending screen-to-tour handoffs, when deciding whether consent can be shown. - Cancels and releases an in-flight handoff when the authenticated identity changes, preventing the previous account tour or hold from crossing sessions. - Removes the obsolete `firstRunTookScreen` latch. - Keeps failed template loads on Getting Started and removes duplicate no-tour coverage. - `dismissIntoFirstRunTour` snapshots the owner, passes an identity-change cancellation predicate to `beginTour`, and invalidates pending holds at the auth boundary. - Per-call symbols keep concurrent handoff ownership distinct, while `authGeneration` separately invalidates stale continuations across authenticated-session changes. - Bare dismissal releases consent; template selection retains ownership until the tour has either started, declined, or failed. At current head `e93ee8410e`, rebased directly on `main` at `4ff3690047` (eleven-file base-to-head diff): - `pnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts --testTimeout=30000` — 4 files, 226 tests passed. - `bash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer until Getting Started releases the screen' --workers=1 --repeat-each=5` — 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution Vite process; the scenario-only 90-second budget covers both application boots. - ESLint, Oxlint, oxfmt, `git diff --check`, pre-push Knip, and changed-line Fallow passed. Fallow excluded 17 inherited dependency findings and reported two inherited styling advisories. The branch retains the test-only changes from #18977 and #18989. Those PRs were merged into this PR's branch (their GitHub base was `fix/agent-consent-defer-first-run-screen`), not into `main`; dropping them during reconciliation would lose their approved coverage. The rebase preserves the eleven-file product/browser patch while removing the stale `main` ancestry. --------- Co-authored-by: Amp <amp@ampcode.com>
… of dropping it (#18966) Defers the automatic Agent consent offer while Getting Started owns the screen, then re-offers it in the same session after that ownership ends. The template path keeps first-run ownership across the dismissal-to-tour preview gap, so the consent card cannot open underneath the tour. The first-session entry-button/feature-flag timing question is separate and is not changed here. - Arms the consent retry for `first_run_screen` instead of dropping that offer. - Uses live first-run screen ownership, including pending screen-to-tour handoffs, when deciding whether consent can be shown. - Cancels and releases an in-flight handoff when the authenticated identity changes, preventing the previous account tour or hold from crossing sessions. - Removes the obsolete `firstRunTookScreen` latch. - Keeps failed template loads on Getting Started and removes duplicate no-tour coverage. - `dismissIntoFirstRunTour` snapshots the owner, passes an identity-change cancellation predicate to `beginTour`, and invalidates pending holds at the auth boundary. - Per-call symbols keep concurrent handoff ownership distinct, while `authGeneration` separately invalidates stale continuations across authenticated-session changes. - Bare dismissal releases consent; template selection retains ownership until the tour has either started, declined, or failed. At current head `e93ee8410e`, rebased directly on `main` at `4ff3690047` (eleven-file base-to-head diff): - `pnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts --testTimeout=30000` — 4 files, 226 tests passed. - `bash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer until Getting Started releases the screen' --workers=1 --repeat-each=5` — 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution Vite process; the scenario-only 90-second budget covers both application boots. - ESLint, Oxlint, oxfmt, `git diff --check`, pre-push Knip, and changed-line Fallow passed. Fallow excluded 17 inherited dependency findings and reported two inherited styling advisories. The branch retains the test-only changes from #18977 and #18989. Those PRs were merged into this PR's branch (their GitHub base was `fix/agent-consent-defer-first-run-screen`), not into `main`; dropping them during reconciliation would lose their approved coverage. The rebase preserves the eleven-file product/browser patch while removing the stale `main` ancestry. --------- Co-authored-by: Amp <amp@ampcode.com>
… of dropping it (#18966) Defers the automatic Agent consent offer while Getting Started owns the screen, then re-offers it in the same session after that ownership ends. The template path keeps first-run ownership across the dismissal-to-tour preview gap, so the consent card cannot open underneath the tour. The first-session entry-button/feature-flag timing question is separate and is not changed here. - Arms the consent retry for `first_run_screen` instead of dropping that offer. - Uses live first-run screen ownership, including pending screen-to-tour handoffs, when deciding whether consent can be shown. - Cancels and releases an in-flight handoff when the authenticated identity changes, preventing the previous account tour or hold from crossing sessions. - Removes the obsolete `firstRunTookScreen` latch. - Keeps failed template loads on Getting Started and removes duplicate no-tour coverage. - `dismissIntoFirstRunTour` snapshots the owner, passes an identity-change cancellation predicate to `beginTour`, and invalidates pending holds at the auth boundary. - Per-call symbols keep concurrent handoff ownership distinct, while `authGeneration` separately invalidates stale continuations across authenticated-session changes. - Bare dismissal releases consent; template selection retains ownership until the tour has either started, declined, or failed. At current head `e93ee8410e`, rebased directly on `main` at `4ff3690047` (eleven-file base-to-head diff): - `pnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts --testTimeout=30000` — 4 files, 226 tests passed. - `bash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer until Getting Started releases the screen' --workers=1 --repeat-each=5` — 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution Vite process; the scenario-only 90-second budget covers both application boots. - ESLint, Oxlint, oxfmt, `git diff --check`, pre-push Knip, and changed-line Fallow passed. Fallow excluded 17 inherited dependency findings and reported two inherited styling advisories. The branch retains the test-only changes from #18977 and #18989. Those PRs were merged into this PR's branch (their GitHub base was `fix/agent-consent-defer-first-run-screen`), not into `main`; dropping them during reconciliation would lose their approved coverage. The rebase preserves the eleven-file product/browser patch while removing the stale `main` ancestry. --------- Co-authored-by: Amp <amp@ampcode.com>
…st-run screen instead of dropping it (#19351) Backport of #18966. Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included. Validation: focused unit suite (199/199); application and browser typechecks; staged lint/format checks. --------- Co-authored-by: Amp <amp@ampcode.com>
…rst-run screen instead of dropping it (#19353) Backport of #18966. Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included. Validation: focused unit suite (199/199); application and browser typechecks; staged lint/format checks. Co-authored-by: Amp <amp@ampcode.com>
…st-run screen instead of dropping it (#19352) Backport of #18966. Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included. Validation: focused unit suite (193/193); application and browser typechecks; staged lint/format checks. Co-authored-by: Amp <amp@ampcode.com>
…rst-run screen instead of dropping it (#19354) Backport of #18966. Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included. Validation: focused unit suite (193/193); application and browser typechecks; staged lint/format checks. Co-authored-by: Amp <amp@ampcode.com>
…omfy-Org#18975) Stacked on Comfy-Org#18966. **Rebased at `75278fe3a0` onto current parent `977f9cb140`; base is `fix/agent-consent-defer-first-run-screen`, not `main`** — review that one first. ## The row this came from, and the correction it carries This lane was opened on the reading that `dialog_open` consent offers *never* recover: 0 of 185 people were ever shown the card after a `dialog_open` hold though 162 came back, while the retry machinery passes its unit tests. **That reading does not survive checking, and the correction matters more than the patch.** `app:agent_consent_shown` is the wrong success signal. The automatic offer path completes *without* showing the card whenever consent is already stored — `requestConsentForCurrentUser` skips `showConsentDialog` when `accepted` is true and calls `onAccept` straight through, and `onAccept` is the only caller of `agentPanelStore.open('automatic_consent')` anywhere in the tree. So the honest recovery signal is that panel-open event, not the card. Read that way, over a 7-day window (PostHog project 204330): of **197 people** held with `reason=dialog_open`, **69 (35%) had `app:agent_panel_opened` with `source=automatic_consent` after their hold** — 0 shown, 0 resolved. Session-level, **41 of 205** held sessions had that panel open on the **same page load** as the hold, no `app:page_view` in between, median 18s after it, 33 of them inside 30s. The release fires, promptly, for at least a third of the cohort. I also could not reproduce a broken release: driving the held-then-cleared sequence against the real `useAgentConsent` and the real `agentConsentStore` (rather than the suite's mock) recovers in every ordering I tried, including the production ordering where the holding dialog appears *after* the extension's `setup()`. ## What is actually wrong There is a real defect on this path, found while checking the premise rather than derived from it, and it is a lost wake-up: ```ts whenever( () => offerHeld.value && screenIsClear.value, () => { offerHeld.value = false // <- the hold is consumed here loadConsentIfEligible() // <- and everything this reaches can bail } ) ``` `loadConsentIfEligible` and `offerConsentUnprompted` between them exit early at six points, and only one of them (`screenHolder()` returning a reason) re-arms the hold. The other five — `consentStore.load()` rejecting (`agentPanel.ts` `loadConsentIfEligible`), `autoShowInFlight`, `!offerEligible()`, an unresolved account or `workspaceStore.isSwitching`, and `agentPanelStore.enabled` having gone false — all return having already thrown the hold away. Each one loses the offer for the rest of the page load, and loses it **silently**: no card, and no second `agent_consent_not_offered` either, because `reportedWithheld` deduplicates the reason per page load. A user in that state is indistinguishable in telemetry from one who was simply never offered. ## The change `src/extensions/core/agentPanel.ts`: 1. The release watcher no longer clears `offerHeld`; it only re-drives the offer. 2. A new `dropHold()` clears it at the points where the offer has genuinely been made or become moot: immediately before `withConsent` is called, when the consent read comes back accepted, when the card has already been seen this page load, and when `prepareAutoShow` reports the one-shot key is already burned. `canShow` can still re-arm it from under the in-flight attempt, which is the existing in-flight behaviour and is unchanged. 3. `withConsent`'s `.finally` re-drives when a hold is armed and the screen is clear. An attempt refused by the `autoShowInFlight` guard cannot rely on the watcher, because `whenever` only fires on a transition and the screen may have gone clear again while the guard was up. A transient exit now leaves the hold armed, so the next clear screen retries it. The trade-off is one extra `consentStore.load()` per clear-screen transition while a hold is outstanding and the read keeps failing; `load()` is memoised per identity, and the existing `does not re-read consent on every dialog close while the read keeps failing` case is untouched, because there the hold is never armed in the first place. **This composes with Comfy-Org#18966 rather than duplicating it.** Comfy-Org#18966 arms the hold for `first_run_screen` too, which routes a fourth reason through this same release path — so the loss this fixes applies to more traffic after that lands than before it. ## Tests `src/extensions/core/agentPanel.test.ts` — **75 passing at rebased head `75278fe3a0`** (74 on the current parent). New: `keeps the held offer when the retry cannot be made, and offers on the next clear screen`. A dialog holds the offer; the screen clears but the retry's consent read fails, which is the ordinary shape for a cloud session whose auth is still settling; a later dialog comes and goes and the read works. Red-then-green is isolated to the behaviour — restoring only the `offerHeld.value = false` line in the watcher and changing nothing else fails **exactly** this test; the retained denominator is 75/75 on the rebased head. At the original approved head, also green: 236 files / 3,933 cases across `src/extensions/core/`, `src/renderer/extensions/firstRunTour/`, `src/workbench/extensions/agent/`, `src/stores/dialogStore.test.ts` and `src/components/dialog/`. At rebased head `75278fe3a0`, `pnpm typecheck`, changed-file `eslint`, type-aware `oxlint`, and `oxfmt --check` are all clean. The pre-push `knip` and `fallow` gates also pass with no introduced issues. ## What this PR does not claim - **No attribution of a production number to this fix.** 69 of 197 provably recovered; the remaining 128 are not explained, and the current events cannot tell "the retry was dropped" from "the retry ran and correctly showed nothing because consent already existed". No expected lift is quoted. - **`tour_active` is not measured here.** It is n=2 over 7 days with no later page load, which is a coin flip, so nothing is concluded from data. From code it shares `dialog_open`'s branch of `screenBusyReason` and therefore the same release path, so it gets the same fix — that is an inference from code, stated as one. - **Consent semantics are untouched**: same copy, same recorded decision, still required before the panel opens, only the moment of the offer changes. The panel is not auto-opened. No flag, exposure or flag configuration was touched. Comfy-Org#18966 is not reverted or reworked. ## Follow-up worth having `app:agent_consent_not_offered` cannot say whether consent was *known* absent or merely *unknown* at the moment of the hold, and it is the event this whole cohort is counted from. 69 of the 197 it counts turned out to already have consent. One property on that event — the consent-read outcome at hold time — would stop the next person measuring this the way it was measured here.
|
|
|
|
Summary
Defers the automatic Agent consent offer while Getting Started owns the screen, then re-offers it in the same session after that ownership ends. The template path keeps first-run ownership across the dismissal-to-tour preview gap, so the consent card cannot open underneath the tour.
The first-session entry-button/feature-flag timing question is separate and is not changed here.
Changes
first_run_screeninstead of dropping that offer.firstRunTookScreenlatch.Review focus
dismissIntoFirstRunToursnapshots the owner, passes an identity-change cancellation predicate tobeginTour, and invalidates pending holds at the auth boundary.authGenerationseparately invalidates stale continuations across authenticated-session changes.Verification
At current head
e93ee8410e, rebased directly onmainat4ff3690047(eleven-file base-to-head diff):pnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts --testTimeout=30000— 4 files, 226 tests passed.bash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer until Getting Started releases the screen' --workers=1 --repeat-each=5— 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution Vite process; the scenario-only 90-second budget covers both application boots.git diff --check, pre-push Knip, and changed-line Fallow passed. Fallow excluded 17 inherited dependency findings and reported two inherited styling advisories.The branch retains the test-only changes from #18977 and #18989. Those PRs were merged into this PR's branch (their GitHub base was
fix/agent-consent-defer-first-run-screen), not intomain; dropping them during reconciliation would lose their approved coverage. The rebase preserves the eleven-file product/browser patch while removing the stalemainancestry.