Skip to content

feat(telemetry): say whether the tour a template close handed off to actually started - #18986

Open
christian-byrne wants to merge 4 commits into
feat/agent-first-run-screen-dismissed-eventfrom
gc-27/first-run-tour-outcome
Open

christian-byrne wants to merge 4 commits into
feat/agent-first-run-screen-dismissed-eventfrom
gc-27/first-run-tour-outcome

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

method=template_selected on app:first_run_screen_dismissed covers two opposite outcomes: the first-run coachmark tour took the screen, so anything held behind it was right to keep waiting — or the tour declined, and the screen was free from that moment. The event cannot tell them apart, so that method is excluded from the first-run consent recovery rate entirely (#18973's §3 query keys off method in ('start_blank','escape')).

beginTour already computes the answer and threw it away as a boolean. This records it.

What changed

  • beginTour returns which refusal declined the tour instead of false: tour_already_active, no_canvas_context, canvas_context_lost, cancelled, tour_declined — or started.
  • dismissIntoFirstRunTour reports that on the dismissal event as a new tour_outcome property. Every other method reports not_attempted, so the field is exhaustive rather than nullable and an absent value means "event predates this property", not "no tour".
  • Its two call sites compare === 'started'. Noted in the JSDoc, because every refusal is a non-empty string and a caller left testing truthiness would read every one of them as success.

Why four of these are worth naming

app:onboarding_tour_not_started cannot stand in. It is emitted from inside startTour, so it only ever speaks for the tour_declined branch — and it is deduplicated per entry path for the life of the page load. Counting from the screen, there are nine ways no tour opens; two of them report anything today. tour_outcome names four of the seven silent ones directly, buckets the remaining three into tour_declined, and is not deduplicated.

The one behavioural consequence

On the template_selected path the event is now reported when the handoff settles, not when the screen hides — the outcome is not knowable before then. visible_duration_ms is still measured to the hide, so it does not absorb the ~500 ms intro preview (pinned by a test). The exits (start_blank, escape) are unchanged and still report ahead of the Comfy.TutorialCompleted write. The cost is that a page torn down inside the handoff loses that row; it is bounded to the one method whose rows are excluded from the recovery rate today.

template_selected is now unreachable from dismissGettingStarted's parameter type — a close reported from there would have no tour outcome to report, and a hand-written not_attempted would be a lie. Same shape as #18973 excluding user_changed.

Stacking

This needs both #18973 (the event) and #18966 (the handoff seam dismissIntoFirstRunTour, which is the only place that can answer for this method), and neither is merged. The first commit here is the merge of #18966 into #18973; the second is the change. Base is set to #18973, so #18966's diff shows up as context.

Tests

beginTour's existing tests already exercised each refusal against its real condition — they now assert the named outcome rather than false, so the values are pinned to real control flow rather than to a mock. On top of that, in firstRunEntry.test.ts: the close is not reported until the tour answers; the duration is measured to the hide, not the end of the handoff; each of the five refusals is carried through; a handoff that throws still reports, as error; and a handoff with no screen to close reports nothing.

Each mutation-checked in isolation — reporting at the hide instead of at the handoff fails 7; collapsing the four silent refusals into tour_declined fails 5; dropping the report on a throw fails exactly 1.

pnpm vitest run → 1705 files, 24,323 passed, 32 expected-fail, 7 skipped. pnpm typecheck, eslint, oxlint --type-aware, oxfmt --check clean on the changed files.

… of dropping it

The automatic "Meet Comfy Agent" card is withheld while a blocking surface
is up and re-offered when that surface closes. `first_run_screen` was the
one reason excluded from that release path, so for users who met the agent
during first run the offer was dropped rather than deferred.

Two things made it terminal for the rest of the page's life:

- `holdOffer` armed the `offerHeld` retry latch for every reason except
  `first_run_screen`, so the release watcher could never fire for it.
- `screenHolder` read `firstRunTookScreen`, which is a latch cleared only by
  a change of user - `dismissGettingStarted` hides the screen without
  clearing it. Even with the latch armed, the retry would have re-held every
  time.

`screenHolder` now reads `gettingStartedVisible`, the ref that actually
renders the screen and clears on dismissal, and `screenIsClear` is the
negation of `screenHolder` rather than of `screenBusyReason` so that hold
and release agree on what "the screen" means. Without that second change,
releasing a first-run hold would re-hold on the same tick.

The template/share-link path previously reported `first_run_screen` via
`firstRunTookScreen`; it sets that only once `beginTour` has started the
first-run tour, so it is now reported as `tour_active`, which is both more
accurate and already had a working release path. Expect a small shift in
`app:agent_consent_not_offered` volume between those two reasons.

Consent semantics are unchanged: the card asks the same thing, records the
same thing, and is still required before the panel opens. Only the moment
it is offered changes.

`firstRunTookScreen` now has no production consumer. Left in place here to
keep this diff to the behaviour change; it can be removed separately.
… to the tour

The release path added in the previous commit opens one window it should not.
On the template path `GettingStartedScreen` dismissed the screen and then
called `beginTour`, which registers the tour, shows the chosen workflow
undimmed for `INTRO_PREVIEW_MS` (500 ms), and only then starts it.
`onboardingTourStore.activeTour` stays `null` until the start, so for those
500 ms `gettingStartedVisible` was already `false` and no tour was active:
`screenHolder` returned `null`, `screenIsClear` was true, and the armed
`offerHeld` released the card into the intro preview, immediately before the
coachmark tour opened over it. That is the case the first-run hold was built
for in #18431 — the card must not land on the tour over a hidden canvas.

The fix is not a longer wait but a signal for the thing actually being asked
about. `useFirstRunEntry` now exposes `firstRunHoldsScreen`: whether the first
run still owns the screen, which is a different question from whether the
screen is rendered. The dismissal and the tour it hands over to move behind one
call, `dismissIntoFirstRunTour`, so the gap between them cannot be observed as
a free screen; `firstRunHoldsScreen` stays true for exactly as long as that
handoff is in flight, and once the tour is up `screenBusyReason`'s
`tour_active` branch takes over. The handoff count is decremented in a
`finally`, so a tour that declines to open or throws releases the screen rather
than leaving a latch behind - which was the failure mode of `firstRunTookScreen`.

This corrects one claim in the previous commit message: the `template_selected`
path is **not** reported as `tour_active`. It is reported as `first_run_screen`
while the screen and its handoff hold, and only a tour that is genuinely up
reports `tour_active`. `app:agent_consent_not_offered` volume therefore stays on
`first_run_screen` for that path.

The test named for this behaviour did not pin it. `keeps waiting when Getting
Started closes straight into the first-run tour` set `activeTour` on the line
*before* clearing `gettingStartedVisible`, so the tour was already active at the
instant of dismissal and the tour alone held the offer. Production dismisses
first and starts the tour 500 ms later. It now runs in the production order and
fails without the guard above. What the handoff does across the intro preview is
pinned in `firstRunEntry.test.ts`; that the preview exists at all, and that no
tour is active until it is over, was already pinned by
`useFirstRunTourController.test.ts`.

The `url-intent` path calls `beginTour` directly and is deliberately left alone:
the screen is never shown there, its offer waits on `whenStartupDecided`, which
only resolves after `beginTour` settles, and routing it through this handoff
would report `first_run_screen` for users who never saw the screen.
gc-15's `app:first_run_screen_dismissed` and gc-26's `dismissIntoFirstRunTour`
are on two open branches and both are needed to say whether the tour that
follows a `template_selected` close actually started.

Conflicts resolved in favour of the handoff: the template path reports
`template_selected` from inside `dismissIntoFirstRunTour` instead of the
component, and the screen's own exits keep their methods.
…started

`method=template_selected` on `app:first_run_screen_dismissed` covers two
opposite outcomes: the coachmark tour took the screen, so anything held behind
it was right to keep waiting, or the tour declined and the screen was free from
that moment. The event could not tell them apart, so the method was excluded
from the first-run recovery rate entirely.

`beginTour` already computes the answer and threw it away as a boolean. It now
returns which refusal declined the tour, and the handoff reports that on the
dismissal event as `tour_outcome`.

Four of the five refusals — a tour already active, no canvas context, the canvas
lost during the intro preview, and the caller cancelling — are reported nowhere
else: `app:onboarding_tour_not_started` fires from inside `startTour`, so it
only ever speaks for the fifth.

Because the outcome is not knowable until the handoff settles, the template
path reports its close then rather than at the hide. The duration is still
measured to the hide, and the exits keep reporting immediately, ahead of the
completion write.
@christian-byrne
christian-byrne requested a review from a team as a code owner September 26, 2026 09:54
@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: cd9dce63-df96-4ad3-a551-61e95f3b4320

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2130 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2109 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/26/2026, 09:56:11 AM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since d02e1c1c15ab79fe9eb7af70e1e6630684cf9591

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 569ms TBT · 69.1 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 233ms TBT · 87.3 MB heap
extension-clean-combined-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1795ms TBT · 78.8 MB heap
extension-rgthree-prototype-draw: · 52.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1467ms TBT · 84.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 144ms TBT · 77.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.4 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 56ms TBT · 177.7 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 434ms TBT · 186.3 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 463ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.6 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -153
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 17ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 70
canvas-mouse-sweep: task duration 853ms
canvas-mouse-sweep: script duration 174ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.9 MB
canvas-mouse-sweep: DOM nodes -228
canvas-mouse-sweep: event listeners -142
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 342ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 64.2 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 465ms
dom-widget-clipping: script duration 174ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 77.1 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 918ms
dom-widget-order-dense-n200-w200-i120: script duration 71ms
dom-widget-order-dense-n200-w200-i120: TBT 569ms
dom-widget-order-dense-n200-w200-i120: heap used 69.1 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -259
dom-widget-order-dense-n200-w200-i120: event listeners -207
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 463ms
dom-widget-order-sparse-n1000-w20-i120: script duration 164ms
dom-widget-order-sparse-n1000-w20-i120: TBT 233ms
dom-widget-order-sparse-n1000-w20-i120: heap used 87.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 10156ms
extension-clean-combined-draw: script duration 8580ms
extension-clean-combined-draw: TBT 1795ms
extension-clean-combined-draw: heap used 78.8 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 19ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9128ms
extension-rgthree-prototype-draw: script duration 7769ms
extension-rgthree-prototype-draw: TBT 1467ms
extension-rgthree-prototype-draw: heap used 84.2 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 542ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 76.6 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -153
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1702ms
large-graph-pan: script duration 892ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.0 MB
large-graph-pan: DOM nodes -114
large-graph-pan: event listeners -71
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1785ms
large-graph-zoom: script duration 822ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.7 MB
large-graph-zoom: DOM nodes -114
large-graph-zoom: event listeners -82
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1948ms
legacy-node-drag: script duration 989ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 89.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 536ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 76.4 MB
minimap-idle: DOM nodes -228
minimap-idle: event listeners -153
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 402ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 76.3 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 481ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.8 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -199
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 18ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 66
subgraph-mouse-sweep: task duration 792ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.4 MB
subgraph-mouse-sweep: DOM nodes -244
subgraph-mouse-sweep: event listeners -188
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 926ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 144ms
subgraph-transition-enter: heap used 77.3 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5920ms
viewport-pan-sweep: script duration 2836ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.4 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -142
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16610ms
vue-large-graph-idle: script duration 261ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.7 MB
vue-large-graph-idle: DOM nodes -8049
vue-large-graph-idle: event listeners -14923
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 144
vue-large-graph-pan: task duration 20288ms
vue-large-graph-pan: script duration 895ms
vue-large-graph-pan: TBT 56ms
vue-large-graph-pan: heap used 177.7 MB
vue-large-graph-pan: DOM nodes -8050
vue-large-graph-pan: event listeners -14923
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 78ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6138ms
vue-node-resize-workload: script duration 109ms
vue-node-resize-workload: TBT 434ms
vue-node-resize-workload: heap used 186.3 MB
vue-node-resize-workload: DOM nodes -8051
vue-node-resize-workload: event listeners -14923
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8323ms
vue-zoom-out-idle: script duration 136ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 166.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 4
workflow-execution: style recalc count 8
workflow-execution: task duration 86ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.1 MB
workflow-execution: DOM nodes 116
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-09-26T10:07:35.771Z",
  "gitSha": "26dcee57ecb2db383e18b46bd67f3cdfe4e212bd",
  "branch": "gc-27/first-run-tour-outcome",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2006.4519999999675,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.269,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.743,
      "heapDeltaBytes": 10652512,
      "heapUsedBytes": 72893196,
      "domNodes": -228,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.889000000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2005.6319999999914,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.836999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.048,
      "heapDeltaBytes": -6100728,
      "heapUsedBytes": 56268396,
      "domNodes": -228,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.926999999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1821.0129999999936,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 17.166,
      "layouts": 12,
      "layoutDurationMs": 4.317,
      "taskDurationMs": 846.6990000000001,
      "heapDeltaBytes": 6683824,
      "heapUsedBytes": 69050056,
      "domNodes": -228,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 174.123,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1810.5369999999539,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.39,
      "layouts": 12,
      "layoutDurationMs": 4.3629999999999995,
      "taskDurationMs": 859.2180000000001,
      "heapDeltaBytes": 8709420,
      "heapUsedBytes": 71180292,
      "domNodes": -228,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 173.791,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.164999999975,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 10.408,
      "layouts": 6,
      "layoutDurationMs": 1.1720000000000002,
      "taskDurationMs": 337.30499999999995,
      "heapDeltaBytes": 2638372,
      "heapUsedBytes": 70167352,
      "domNodes": 53,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.524000000000001,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.4930000000622,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.133000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.4160000000000001,
      "taskDurationMs": 346.11,
      "heapDeltaBytes": 2126968,
      "heapUsedBytes": 64466556,
      "domNodes": 53,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 12.901000000000003,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 714.0120000000252,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.6450000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.01900000000006,
      "heapDeltaBytes": 19333148,
      "heapUsedBytes": 80911228,
      "domNodes": 0,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 176.429,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 728.7589999999682,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 4.4159999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.587,
      "heapDeltaBytes": 18401504,
      "heapUsedBytes": 80821680,
      "domNodes": 0,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 172.32,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1242.7749999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 921.3449999999999,
      "heapDeltaBytes": -14033096,
      "heapUsedBytes": 72545648,
      "domNodes": -259,
      "jsHeapTotalBytes": 20054016,
      "scriptDurationMs": 72.26100000000001,
      "eventListeners": -207,
      "totalBlockingTimeMs": 572,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1222.7689999999711,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 914.0300000000001,
      "heapDeltaBytes": -15672008,
      "heapUsedBytes": 72309856,
      "domNodes": -259,
      "jsHeapTotalBytes": 21102592,
      "scriptDurationMs": 69.46100000000001,
      "eventListeners": -207,
      "totalBlockingTimeMs": 566,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 846.2430000000154,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.66100000000023,
      "heapDeltaBytes": 15410088,
      "heapUsedBytes": 91554784,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 161.572,
      "eventListeners": 0,
      "totalBlockingTimeMs": 233,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 849.0130000000136,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.40500000000026,
      "heapDeltaBytes": 14692948,
      "heapUsedBytes": 91580816,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 166.69899999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 233,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10464.468000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9601.874,
      "heapDeltaBytes": 11281260,
      "heapUsedBytes": 94396240,
      "domNodes": 0,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 8195.288,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1757,
      "frameDurationMs": 19.996666666666655,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11738.501000000042,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10710.487,
      "heapDeltaBytes": -4438952,
      "heapUsedBytes": 70881556,
      "domNodes": 0,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 8964.447,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1833,
      "frameDurationMs": 18.886666666666617,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10308.515999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9576.027,
      "heapDeltaBytes": 21446652,
      "heapUsedBytes": 95690516,
      "domNodes": 0,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 8175.907,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1743,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9370.632999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8679.593,
      "heapDeltaBytes": 6429452,
      "heapUsedBytes": 80950332,
      "domNodes": 0,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 7361.732,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1191,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2030.1469999999995,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.386,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 469.233,
      "heapDeltaBytes": 476188,
      "heapUsedBytes": 81999208,
      "domNodes": -228,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 34.57800000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.7519999999931,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.9190000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.9879999999999,
      "heapDeltaBytes": -2841232,
      "heapUsedBytes": 78677028,
      "domNodes": -228,
      "jsHeapTotalBytes": -233472,
      "scriptDurationMs": 34.208000000000006,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2515.784999999994,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.135999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1659.9599999999998,
      "heapDeltaBytes": 23493636,
      "heapUsedBytes": 88627172,
      "domNodes": 0,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 869.872,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2613.4790000000976,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.546,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1744.896,
      "heapDeltaBytes": 7496016,
      "heapUsedBytes": 89699456,
      "domNodes": -228,
      "jsHeapTotalBytes": 253952,
      "scriptDurationMs": 914.024,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3803.2850000000167,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.624999999999996,
      "layouts": 60,
      "layoutDurationMs": 14.303999999999998,
      "taskDurationMs": 1844.1850000000002,
      "heapDeltaBytes": -1734168,
      "heapUsedBytes": 81988652,
      "domNodes": -228,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 830.526,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3699.4929999999613,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 10.877999999999998,
      "layouts": 60,
      "layoutDurationMs": 13.620999999999999,
      "taskDurationMs": 1725.6689999999999,
      "heapDeltaBytes": 8549960,
      "heapUsedBytes": 74631536,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 813.0379999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3105.3039999999896,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.391,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1927.9960000000003,
      "heapDeltaBytes": 25827884,
      "heapUsedBytes": 91664896,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 965.5770000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3131.6359999999577,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.774000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1967.6110000000003,
      "heapDeltaBytes": 29741224,
      "heapUsedBytes": 96550452,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1013.4110000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.7580000000194,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.363999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.82200000000006,
      "heapDeltaBytes": -4089888,
      "heapUsedBytes": 84680496,
      "domNodes": -228,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 36.14800000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.991999999932,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.245000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 629.3539999999999,
      "heapDeltaBytes": -12839068,
      "heapUsedBytes": 75533524,
      "domNodes": -228,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 34.941,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 612.5690000000077,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.596000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.566,
      "heapDeltaBytes": 14180300,
      "heapUsedBytes": 83149856,
      "domNodes": 0,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 144.972,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 596.0720000000492,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.175999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.50800000000004,
      "heapDeltaBytes": 12976900,
      "heapUsedBytes": 76820680,
      "domNodes": 0,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 148.51600000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.1990000000042,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.222999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.87,
      "heapDeltaBytes": 3494164,
      "heapUsedBytes": 66235328,
      "domNodes": -244,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.711,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2014.6290000000135,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.271000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.592,
      "heapDeltaBytes": 539232,
      "heapUsedBytes": 63309304,
      "domNodes": -244,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.430000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1714.445000000012,
      "styleRecalcs": 59,
      "styleRecalcDurationMs": 17.773,
      "layouts": 16,
      "layoutDurationMs": 5.64,
      "taskDurationMs": 784.157,
      "heapDeltaBytes": 5369648,
      "heapUsedBytes": 68204092,
      "domNodes": -244,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 115.315,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1720.3739999999925,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 18.971999999999998,
      "layouts": 16,
      "layoutDurationMs": 5.755,
      "taskDurationMs": 799.846,
      "heapDeltaBytes": 11768268,
      "heapUsedBytes": 75288968,
      "domNodes": -244,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 116.586,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1385.7870000000503,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.01,
      "layouts": 5,
      "layoutDurationMs": 13.174000000000001,
      "taskDurationMs": 926.4030000000001,
      "heapDeltaBytes": -6289208,
      "heapUsedBytes": 81033980,
      "domNodes": 13667,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 30.755,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8889.485999999977,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 33.169000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5980.371,
      "heapDeltaBytes": -685188,
      "heapUsedBytes": 80697076,
      "domNodes": -228,
      "jsHeapTotalBytes": -303104,
      "scriptDurationMs": 2849.964,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8616.847000000007,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 32.334,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5858.7210000000005,
      "heapDeltaBytes": 406972,
      "heapUsedBytes": 81563760,
      "domNodes": -228,
      "jsHeapTotalBytes": 1564672,
      "scriptDurationMs": 2821.191,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16962.55700000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16669.034,
      "heapDeltaBytes": -69614348,
      "heapUsedBytes": 169939404,
      "domNodes": -8049,
      "jsHeapTotalBytes": -16896000,
      "scriptDurationMs": 262.38,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16844.840999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16550.791,
      "heapDeltaBytes": -48802084,
      "heapUsedBytes": 171251128,
      "domNodes": -8049,
      "jsHeapTotalBytes": -17956864,
      "scriptDurationMs": 259.397,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20499.35800000003,
      "styleRecalcs": 141,
      "styleRecalcDurationMs": 17.715000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20414.885,
      "heapDeltaBytes": -59056940,
      "heapUsedBytes": 180926704,
      "domNodes": -8050,
      "jsHeapTotalBytes": -20078592,
      "scriptDurationMs": 891.741,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 72,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20375.88900000003,
      "styleRecalcs": 147,
      "styleRecalcDurationMs": 16.861999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20161.670000000002,
      "heapDeltaBytes": -26488372,
      "heapUsedBytes": 191782108,
      "domNodes": -8049,
      "jsHeapTotalBytes": -19214336,
      "scriptDurationMs": 898.0980000000001,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 40,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6193.875000000048,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.44199999999998,
      "layouts": 20,
      "layoutDurationMs": 24.325,
      "taskDurationMs": 6134.063,
      "heapDeltaBytes": -22218316,
      "heapUsedBytes": 195772768,
      "domNodes": -8053,
      "jsHeapTotalBytes": 13885440,
      "scriptDurationMs": 111.14399999999999,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 468,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6181.790999999976,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.10199999999998,
      "layouts": 20,
      "layoutDurationMs": 24.45299999999999,
      "taskDurationMs": 6141.94,
      "heapDeltaBytes": -42921100,
      "heapUsedBytes": 194912676,
      "domNodes": -8049,
      "jsHeapTotalBytes": 13434880,
      "scriptDurationMs": 107.118,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 399,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8565.93399999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8383.694999999998,
      "heapDeltaBytes": -23123068,
      "heapUsedBytes": 170919048,
      "domNodes": 0,
      "jsHeapTotalBytes": -28573696,
      "scriptDurationMs": 135.93900000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8417.179999999917,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8261.427999999998,
      "heapDeltaBytes": 7145160,
      "heapUsedBytes": 178578536,
      "domNodes": 0,
      "jsHeapTotalBytes": -15466496,
      "scriptDurationMs": 136.12999999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 120.85700000000088,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 15.947000000000003,
      "layouts": 4,
      "layoutDurationMs": 2.242,
      "taskDurationMs": 89.51799999999999,
      "heapDeltaBytes": 3138712,
      "heapUsedBytes": 65086068,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.620000000000003,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 115.58899999999994,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 9.877,
      "layouts": 3,
      "layoutDurationMs": 1.3359999999999999,
      "taskDurationMs": 82.018,
      "heapDeltaBytes": 3045620,
      "heapUsedBytes": 65118980,
      "domNodes": 114,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.205,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52521 79589 66.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.2% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.8% 320
src/LGraph.ts 78.7% 272
src/scripts/app.ts 72.1% 259
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.3% 232
src/scripts/pnginfo.ts 20.8% 221

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Two corrections to the query work this stack depends on, both measured, neither applied to another lane's artifact from here.

1. The recovery signal in #18973's denominator query is the one that was retired. It counts app:agent_consent_shown, which is emitted from the card's onVnodeMounted — so it is absent both when the offer is lost and when the offer succeeds without a card needing to mount (consent already accepted). Read that way, a real 35% recovery reads as 0%. The correct signal is app:agent_panel_opened with properties.source='automatic_consent', whose only producer is agentPanel.ts:295. The widened query in this PR's receipt uses it in both arms, so the comparison inside it is sound — but it is not numerically comparable to any figure previously computed off agent_consent_shown.

2. An absent PostHog property is NULL, so properties.x = '' matches it never and properties.x not in (...) matches it always. Measured on a property that exists in the schema and is carried by no production event yet (consent_state, from #18976, unmerged):

n=994 | properties.consent_state = ''                      ->   0
      | isNull(properties.consent_state)                   -> 994
      | ifNull(properties.consent_state,'') = ''           -> 994
      | properties.consent_state not in ('known_present','') -> 994
      | properties.reason = 'first_run_screen' (control)   -> 762

So the coverage guard #18973's receipt recommends — countIf(properties.method = '') — reports full coverage of a property nothing carries. And the obvious way to write "the tour declined" for the property this PR adds, tour_outcome not in ('started',''), would fail open: every pre-deploy template_selected close would be classified as a refusal and would land in a published numerator. Coverage guards need ifNull(properties.x,'') = ''; refusal filters need the wanted values enumerated positively. Both are done in the query shipped with this PR.

Same family as the left join … is not null trap, and strictly more dangerous — that one over-reports a match, this one over-reports a mismatch.

Relevant to this PR because tour_outcome is the first property in this stack that a query has to filter negatively to be useful.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 26, 2026
@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sions/firstRunTour/gettingStarted/firstRunEntry.ts 91.66% 2 Missing ⚠️
@@                              Coverage Diff                              @@
##           feat/agent-first-run-screen-dismissed-event   #18986    +/-   ##
=============================================================================
  Coverage                                        84.92%   84.92%            
=============================================================================
  Files                                             2308     2308            
  Lines                                           132890   132906    +16     
  Branches                                         35910    35631   -279     
=============================================================================
+ Hits                                            112862   112876    +14     
- Misses                                           19716    19718     +2     
  Partials                                           312      312            
Flag Coverage Δ
e2e 65.98% <9.67%> (-0.04%) ⬇️
unit 81.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extensions/core/agentPanel.ts 99.00% <100.00%> (ø)
src/platform/telemetry/types.ts 96.07% <ø> (ø)
...rstRunTour/gettingStarted/GettingStartedScreen.vue 80.76% <100.00%> (-0.49%) ⬇️
...ons/firstRunTour/tour/useFirstRunTourController.ts 99.15% <100.00%> (+0.85%) ⬆️
...sions/firstRunTour/gettingStarted/firstRunEntry.ts 95.45% <91.66%> (-1.32%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-onboarding Agent consent, first-use tour or onboarding gates agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 27, 2026

@MaanilVerma MaanilVerma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read 7e5e5c9677 against the controller and entry at this head, ran the eight touched suites (317/317) and one probe. Turning beginTour's false into a named refusal is a clean change, and making the field exhaustive with not_attempted instead of nullable makes the event much easier to query.

Check Result
named refusals, === 'started' callers pass
report after the handoff, duration to the hide pass
hung Comfy.TutorialCompleted write template row lost, inline A below
cancelled reachable on this event not yet, inline B below
merges with main no, the base conflicts

This can't land as stacked: #18973's own commit conflicts with main in six files, mostly firstRunEntry.ts, which #18966's squash rewrote around the firstRunScreen phase machine. So the review is of this PR's commit, not a main-merged tree. Once #18973 is rebased, happy to re-run the probe on the rebased branch.

// anywhere in the handoff reports itself rather than a refusal it invented.
let tourOutcome: FirstRunTourOutcome = 'error'
try {
await markTutorialCompleted()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A

issue: the report now waits behind await markTutorialCompleted(), so if that write never settles, finally never runs and the template_selected row is lost. dismissGettingStarted's new JSDoc gives that exact failure as the reason the exits report before the write. Probe inside "what the close reports about the tour it handed off to": with useSettingStore().set never resolving, start_blank still reports once, the template handoff reports 0 times. Could the write start without gating the tour (const completed = markTutorialCompleted(), then beginTour, then await completed in the finally after reporting), so set-before-beginTour still holds for the ordering test, plus that hung-write case as a test?

/** The canvas went away during the intro preview, between the ask and the open. */
| 'canvas_context_lost'
/** The caller withdrew during the intro preview — today, the account changing under it. */
| 'cancelled'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B

question: "today, the account changing under it" is only true of handleUrlWorkflow, which does not report a dismissal. On this event the only caller is dismissIntoFirstRunTour, which calls beginTour(templateId) with no cancel predicate here, so cancelled cannot appear yet. Main's dismissIntoFirstRunTour (from #18966's squash) does pass one, so I think this lines up after the rebase. Could the rebase keep that predicate and add a tour_outcome: 'cancelled' case for an account change during the preview?

Comment on lines +620 to +637
/**
* What became of the first-run coachmark tour the close handed the screen to.
*
* `method` alone cannot answer this. A `template_selected` close covers two
* opposite outcomes — the tour took the screen and anything held behind it was
* right to keep waiting, or the tour declined and the screen was free from that
* moment — and they are indistinguishable without this.
*
* `not_attempted` is the value for every other `method`: those closes never ask
* for a tour, so the field is exhaustive rather than nullable, and an absent
* value means the event predates this property rather than "no tour".
*
* The four refusals between `started` and `tour_declined` are the ones nothing
* else in the product reports. `app:onboarding_tour_not_started` only covers
* what happens *inside* `startTour` (`no_steps`, `already_seen`), which is the
* `tour_declined` bucket here; the rest are refused before `startTour` is ever
* reached and emit nothing at all.
*/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C

nitpick (non-blocking): this block, plus the ones on beginTour and dismissIntoFirstRunTour, retell the reasoning from the PR description, and they will drift once #18973's rebase moves things around. The per-value comments on the union already say what each one means. Could the type keep just those, and the functions keep one line each on the non-obvious bit (report on settle, measure to the hide)?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-onboarding Agent consent, first-use tour or onboarding gates agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants