Repository navigation
feat(agent): name every ending of a consent request and every outcome of a shown card - #18992
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2159 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T07:56:31.291Z",
"gitSha": "d8e99b9c5d7ccbf78072a45121b8ff52b4ca77b9",
"branch": "feat/gc-36-consent-request-outcomes",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.6990000000264,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.541999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.231,
"heapDeltaBytes": -2327128,
"heapUsedBytes": 76619152,
"domNodes": -228,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 7.808000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2035.270999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.412,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.133,
"heapDeltaBytes": -2011620,
"heapUsedBytes": 77294324,
"domNodes": -228,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 7.322,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1738.8850000000389,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.711,
"layouts": 12,
"layoutDurationMs": 3.3150000000000004,
"taskDurationMs": 554.279,
"heapDeltaBytes": -8531252,
"heapUsedBytes": 70265992,
"domNodes": -228,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 108.969,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1737.3399999999606,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.684000000000001,
"layouts": 12,
"layoutDurationMs": 3.21,
"taskDurationMs": 593.9399999999999,
"heapDeltaBytes": -22232932,
"heapUsedBytes": 57185588,
"domNodes": -228,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 104.723,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.9719999999802,
"styleRecalcs": 33,
"styleRecalcDurationMs": 7.4110000000000005,
"layouts": 6,
"layoutDurationMs": 1.049,
"taskDurationMs": 259.672,
"heapDeltaBytes": 1432956,
"heapUsedBytes": 80964452,
"domNodes": 53,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.922999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.1899999999878,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.356,
"layouts": 6,
"layoutDurationMs": 1.419,
"taskDurationMs": 262.20899999999995,
"heapDeltaBytes": 1826592,
"heapUsedBytes": 81146396,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.328000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 558.8309999999979,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.223,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.575,
"heapDeltaBytes": 18294512,
"heapUsedBytes": 97205568,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 114.08600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 543.8179999999875,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.634,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.956,
"heapDeltaBytes": 18289168,
"heapUsedBytes": 97406356,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 116.862,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1013.9009999999757,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.325,
"heapDeltaBytes": 6620836,
"heapUsedBytes": 82691868,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 46.45100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 386,
"frameDurationMs": 29.90000000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 997.948000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.848,
"heapDeltaBytes": 10454968,
"heapUsedBytes": 87933556,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 45.534000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 395,
"frameDurationMs": 30.29999999999999,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 749.0129999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.57,
"heapDeltaBytes": 13764996,
"heapUsedBytes": 91655960,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 103.85399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 119,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 732.8370000000177,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.02499999999986,
"heapDeltaBytes": 14921500,
"heapUsedBytes": 88789348,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 95.244,
"eventListeners": 0,
"totalBlockingTimeMs": 112,
"frameDurationMs": 21.567647058823535,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7003.852999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6150.291,
"heapDeltaBytes": -13950584,
"heapUsedBytes": 66920768,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 4794.47,
"eventListeners": 0,
"totalBlockingTimeMs": 38,
"frameDurationMs": 25.17913669064748,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6402.300000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5671.884,
"heapDeltaBytes": -1025456,
"heapUsedBytes": 79011348,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 4416.206000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 31,
"frameDurationMs": 25.097254901960785,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6570.721000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5918.326999999999,
"heapDeltaBytes": 12144624,
"heapUsedBytes": 92685096,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 4623.882999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 25.352509652509653,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6476.065000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5837.757,
"heapDeltaBytes": -12844832,
"heapUsedBytes": 68533288,
"domNodes": 0,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 4567.259,
"eventListeners": 0,
"totalBlockingTimeMs": 26,
"frameDurationMs": 24.966795366795367,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2039.3880000000308,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.159999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.18299999999994,
"heapDeltaBytes": -37563884,
"heapUsedBytes": 82821440,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 26.814000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.2140000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8200000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.779,
"heapDeltaBytes": 20670912,
"heapUsedBytes": 83551444,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 23.139999999999993,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2132.5689999999895,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.861999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1185.9350000000002,
"heapDeltaBytes": 20315328,
"heapUsedBytes": 82541844,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 580.1590000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2134.375000000091,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.556000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1184.585,
"heapDeltaBytes": -33102844,
"heapUsedBytes": 87911180,
"domNodes": -228,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 569.457,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3084.9759999999833,
"styleRecalcs": 63,
"styleRecalcDurationMs": 7.792000000000001,
"layouts": 60,
"layoutDurationMs": 10.331999999999999,
"taskDurationMs": 1208.328,
"heapDeltaBytes": 6977708,
"heapUsedBytes": 74330796,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 523.139,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666486486486487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3107.7699999999595,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.018,
"layouts": 60,
"layoutDurationMs": 9.999,
"taskDurationMs": 1205.866,
"heapDeltaBytes": 12227484,
"heapUsedBytes": 76635384,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 522.775,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2168.2289999999966,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.260999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1321.7069999999999,
"heapDeltaBytes": 17574444,
"heapUsedBytes": 82320888,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 633.7660000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793846153846154,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2176.2200000000576,
"styleRecalcs": 45,
"styleRecalcDurationMs": 3.7760000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1338.849,
"heapDeltaBytes": 17898172,
"heapUsedBytes": 86666804,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 646.9110000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793846153846154,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2025.936999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.9710000000001,
"heapDeltaBytes": -37634924,
"heapUsedBytes": 84040424,
"domNodes": -228,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 27.148,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.431000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2129999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.28400000000005,
"heapDeltaBytes": -39067780,
"heapUsedBytes": 82800776,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 24.785,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 492.91799999997465,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.206999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.79599999999994,
"heapDeltaBytes": 12420540,
"heapUsedBytes": 93475352,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 103.091,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 498.99200000004384,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.461999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.11800000000005,
"heapDeltaBytes": -20453964,
"heapUsedBytes": 60960332,
"domNodes": -214,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 100.66,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2010.6490000000008,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.947,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.9770000000001,
"heapDeltaBytes": -26665992,
"heapUsedBytes": 54945180,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 7.762000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.0739999999887,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8409999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.548,
"heapDeltaBytes": -2377696,
"heapUsedBytes": 79108136,
"domNodes": -244,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.418,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.6809999999891,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.574000000000002,
"layouts": 16,
"layoutDurationMs": 4.643,
"taskDurationMs": 586.1560000000001,
"heapDeltaBytes": -2442912,
"heapUsedBytes": 79214464,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 70.93299999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.3309999999728,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.645999999999999,
"layouts": 16,
"layoutDurationMs": 4.176,
"taskDurationMs": 585.8100000000001,
"heapDeltaBytes": -4161308,
"heapUsedBytes": 77512736,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 70.41900000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.8190000000168,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.926000000000002,
"layouts": 5,
"layoutDurationMs": 8.319,
"taskDurationMs": 685.346,
"heapDeltaBytes": 21457420,
"heapUsedBytes": 96354352,
"domNodes": 13667,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 27.533,
"eventListeners": 2383,
"totalBlockingTimeMs": 102,
"frameDurationMs": 20.541860465116283,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "viewport-pan-sweep",
"durationMs": 8163.378000000022,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.793999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4138.0560000000005,
"heapDeltaBytes": -36844576,
"heapUsedBytes": 82919404,
"domNodes": -228,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 1849.7930000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8165.843999999993,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4162.785000000001,
"heapDeltaBytes": -37672716,
"heapUsedBytes": 82808396,
"domNodes": -228,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 1881.804,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612244897959,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 8392.404999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7421.147,
"heapDeltaBytes": -18673768,
"heapUsedBytes": 167732752,
"domNodes": -8049,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 121.72400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.28432989690722,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10880.44400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10368.867000000002,
"heapDeltaBytes": -48727644,
"heapUsedBytes": 162963312,
"domNodes": -8049,
"jsHeapTotalBytes": -14925824,
"scriptDurationMs": 140.013,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.355067567567566,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 13978.023000000008,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.781999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13172.697,
"heapDeltaBytes": 5626732,
"heapUsedBytes": 172698696,
"domNodes": -8049,
"jsHeapTotalBytes": -25165824,
"scriptDurationMs": 667.924,
"eventListeners": 0,
"totalBlockingTimeMs": 76,
"frameDurationMs": 24.631393298059965,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 13691.648999999983,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.752999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13038.112000000001,
"heapDeltaBytes": -16220064,
"heapUsedBytes": 184223816,
"domNodes": -3045,
"jsHeapTotalBytes": 8400896,
"scriptDurationMs": 622.46,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.105799648506153,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 3917.8380000000175,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.553,
"layouts": 20,
"layoutDurationMs": 19.360000000000003,
"taskDurationMs": 3820.459,
"heapDeltaBytes": 13548008,
"heapUsedBytes": 220489628,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 61.43599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.73526011560694,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-node-resize-workload",
"durationMs": 3886.0990000000584,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.76200000000001,
"layouts": 20,
"layoutDurationMs": 18.235,
"taskDurationMs": 3756.6750000000006,
"heapDeltaBytes": 7692416,
"heapUsedBytes": 204248108,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 55.59900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.33626373626374,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5821.9119999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5436.705999999999,
"heapDeltaBytes": -13220144,
"heapUsedBytes": 182266824,
"domNodes": 0,
"jsHeapTotalBytes": -28573696,
"scriptDurationMs": 75.17400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.518120805369133,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4500.3619999999955,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09599999999998499,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4124.594999999999,
"heapDeltaBytes": -30907668,
"heapUsedBytes": 165395104,
"domNodes": 0,
"jsHeapTotalBytes": -34340864,
"scriptDurationMs": 63.154000000000046,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.0710843373494,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 444.4080000000099,
"styleRecalcs": 17,
"styleRecalcDurationMs": 10.845,
"layouts": 3,
"layoutDurationMs": 0.6999999999999998,
"taskDurationMs": 97.37700000000002,
"heapDeltaBytes": -14446788,
"heapUsedBytes": 82867744,
"domNodes": 102,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.914999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 116.21099999990747,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.907,
"layouts": 3,
"layoutDurationMs": 1.4820000000000002,
"taskDurationMs": 75.80699999999999,
"heapDeltaBytes": -17010524,
"heapUsedBytes": 80125140,
"domNodes": 114,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.765999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 431.8140000000312,
"styleRecalcs": 78,
"styleRecalcDurationMs": 70.991,
"layouts": 76,
"layoutDurationMs": 13.643,
"taskDurationMs": 388.08,
"heapDeltaBytes": -9778900,
"heapUsedBytes": 78344076,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 133.056,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923079,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 435.27099999994334,
"styleRecalcs": 78,
"styleRecalcDurationMs": 72.977,
"layouts": 76,
"layoutDurationMs": 13.68,
"taskDurationMs": 396.379,
"heapDeltaBytes": -9914132,
"heapUsedBytes": 78091212,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 134.625,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 712.5939999999673,
"styleRecalcs": 78,
"styleRecalcDurationMs": 174.203,
"layouts": 76,
"layoutDurationMs": 13.495999999999999,
"taskDurationMs": 670.147,
"heapDeltaBytes": 8593620,
"heapUsedBytes": 138057364,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 188.75699999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 710.7470000000831,
"styleRecalcs": 78,
"styleRecalcDurationMs": 177.095,
"layouts": 76,
"layoutDurationMs": 13.523,
"taskDurationMs": 668.654,
"heapDeltaBytes": 8627748,
"heapUsedBytes": 138202520,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 179.392,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## feat/gc-16-consent-offer-exit-reasons #18992 +/- ##
======================================================================
Coverage 85.09% 85.09%
======================================================================
Files 2342 2342
Lines 134738 134757 +19
Branches 34444 34448 +4
======================================================================
+ Hits 114659 114678 +19
Misses 19726 19726
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ne arrange production cannot produce (#18977) ## Summary Audits every `agentPanel.test.ts` arrangement that directly writes `gettingStartedVisible`, `firstRunHoldsScreen`, or `activeTour`, after two regressions hid behind impossible test state. Adds one reachable reason-precedence regression. Test-only; no production change. ## Changes - Classified 24 arrangements against production writers and orderings: 23 reachable; one impossible arrangement removed after review. - Pins `first_run_screen` over `dialog_open` when both hold the automatic consent offer. Reversing `screenHolder()` precedence makes this test fail with `dialog_open`; restored production code passes. - Keeps no test for the impossible mid-offer first-run transition. `showFirstRunScreen` runs before `startupDecided`, and every automatic offer waits for that decision, so the first-run hold cannot rise while an offer is in flight. <details> <summary>Audited arrangement inventory and counting rule</summary> Count one row per setup or transition sequence that directly writes one or more audited refs; a row may write multiple refs. Dialog-only rows are included where they compose with an audited ref or establish a comparison reason. 1. beforeEach idle baseline - reachable 2. Getting Started screen up - reachable 3. coachmark tour active - reachable 4. screen and tour active - reachable 5. desktop sign-in dialog open - reachable 6. screen closes - reachable 7. screen closes into first-run tour - reachable 8. holding tour ends - reachable 9. startup decision remains pending after tour ends - reachable 10. tour ends while an offer remains in flight - reachable 11. tour starts while an offer is in flight - reachable 12. tour ends while consent cannot be read - reachable 13. first-run reason deduplication - reachable 14. tour reason deduplication - reachable 15. dialog reason deduplication - reachable 16. undecided-boot reason deduplication - reachable 17. in-flight tour plus workspace switch - reachable 18. second workspace repeats a tour reason - reachable 19. held offer emits no reason after consent resolves - reachable 20. tour ends while Getting Started remains up - reachable 21. tour ends while a dialog remains open - reachable 22. dialog opens while an offer is in flight - reachable 23. first-run hold rises while an offer is in flight - impossible; removed 24. manual consent dialog per identity scope - reachable </details> ## Verification - `pnpm test:unit src/extensions/core/agentPanel.test.ts --testTimeout=30000` - 74 passed. - Precedence mutation `screenBusyReason() ?? (firstRunHoldsScreen ? 'first_run_screen' : null)` - focused regression fails with received reason `dialog_open`. - ESLint, oxfmt, and `git diff --check` pass for the changed file. - CI was green on the rebased parent; fresh CI is running for the review repair. ## Dependency Stacked on #18966 because `firstRunHoldsScreen` is introduced there. Required order remains #18966 -> #18977 -> #18989 -> #18975 -> #18978 -> #18992. --------- Co-authored-by: Amp <amp@ampcode.com>
…ne arrange production cannot produce (#18977) ## Summary Audits every `agentPanel.test.ts` arrangement that directly writes `gettingStartedVisible`, `firstRunHoldsScreen`, or `activeTour`, after two regressions hid behind impossible test state. Adds one reachable reason-precedence regression. Test-only; no production change. ## Changes - Classified 24 arrangements against production writers and orderings: 23 reachable; one impossible arrangement removed after review. - Pins `first_run_screen` over `dialog_open` when both hold the automatic consent offer. Reversing `screenHolder()` precedence makes this test fail with `dialog_open`; restored production code passes. - Keeps no test for the impossible mid-offer first-run transition. `showFirstRunScreen` runs before `startupDecided`, and every automatic offer waits for that decision, so the first-run hold cannot rise while an offer is in flight. <details> <summary>Audited arrangement inventory and counting rule</summary> Count one row per setup or transition sequence that directly writes one or more audited refs; a row may write multiple refs. Dialog-only rows are included where they compose with an audited ref or establish a comparison reason. 1. beforeEach idle baseline - reachable 2. Getting Started screen up - reachable 3. coachmark tour active - reachable 4. screen and tour active - reachable 5. desktop sign-in dialog open - reachable 6. screen closes - reachable 7. screen closes into first-run tour - reachable 8. holding tour ends - reachable 9. startup decision remains pending after tour ends - reachable 10. tour ends while an offer remains in flight - reachable 11. tour starts while an offer is in flight - reachable 12. tour ends while consent cannot be read - reachable 13. first-run reason deduplication - reachable 14. tour reason deduplication - reachable 15. dialog reason deduplication - reachable 16. undecided-boot reason deduplication - reachable 17. in-flight tour plus workspace switch - reachable 18. second workspace repeats a tour reason - reachable 19. held offer emits no reason after consent resolves - reachable 20. tour ends while Getting Started remains up - reachable 21. tour ends while a dialog remains open - reachable 22. dialog opens while an offer is in flight - reachable 23. first-run hold rises while an offer is in flight - impossible; removed 24. manual consent dialog per identity scope - reachable </details> ## Verification - `pnpm test:unit src/extensions/core/agentPanel.test.ts --testTimeout=30000` - 74 passed. - Precedence mutation `screenBusyReason() ?? (firstRunHoldsScreen ? 'first_run_screen' : null)` - focused regression fails with received reason `dialog_open`. - ESLint, oxfmt, and `git diff --check` pass for the changed file. - CI was green on the rebased parent; fresh CI is running for the review repair. ## Dependency Stacked on #18966 because `firstRunHoldsScreen` is introduced there. Required order remains #18966 -> #18977 -> #18989 -> #18975 -> #18978 -> #18992. --------- Co-authored-by: Amp <amp@ampcode.com>
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed the consent-request exit and shown-card outcome instrumentation, including the stacked-base context, telemetry contracts, dialog lifecycle, identity-change/error paths, provider mappings, and unit/browser coverage. I found no blocking issues. The request-stage events remain frontend telemetry rather than a server/API response contract, so generated API types are not implicated.
4674bdf to
f064b71
Compare
Releasing a held consent offer also consumed the hold, before anything had checked whether the retry could actually happen. Everything the release triggers is asynchronous and exits early in several transient ways — the consent read rejecting, an offer already in flight, a workspace mid-switch, an account not resolved yet — and none of those exits re-armed the hold. Any one of them therefore lost the offer for the rest of the page load, silently: no card, and no second `agent_consent_not_offered` either, because the reason is deduplicated per page load. The hold is now dropped only where the offer has been made or has become moot (consent already accepted, the card already seen this page load, the one-shot key already burned). A transient exit leaves it armed, so the next clear screen retries. An attempt that was refused by the in-flight guard also gets a wake-up when that attempt settles, since `whenever` only fires on a transition and the screen may have gone clear again in the meantime. Stacked on Comfy-Org#18966, which arms the hold for `first_run_screen` as well and so routes a fourth reason through this same release path. Consent semantics are untouched: same copy, same recorded decision, still required before the panel opens, and the panel is not auto-opened.
`agent_consent_not_offered` reports the surface a deferred consent offer is queued behind. An attempt that stops for a reason of its own reports nothing at all, so a user whose offer was lost is indistinguishable in telemetry from one who was never offered - 307 of 554 users held on `first_run_screen` return and emit neither a card nor a second suppression, and only 45 of those can be shown to have had consent already. Adds `app:agent_consent_offer_exited`, carrying `exit`, `stage` and `retry_armed`. The pair (`exit`, `stage`) identifies one exit in the code, because the same condition is checked at more than one link of the chain: `loadConsentIfEligible`, the startup probe, and `offerConsentUnprompted`. Three values mean the offer was correctly not needed (`consent_already_accepted`, `card_already_seen`, `already_offered`) and the rest mean it was owed and did not happen, so a query over this event must split by `exit`; a total is not a quantity. The type's doc comment says so. Deliberately a new event rather than new `reason` values, for three reasons. `withholdOffer` returns without emitting when either id is missing - and a missing id is one of the endings that has to be reportable. It also returns without emitting once the one-shot auto-show key is burned, which would silence every later page load of every user who has seen the card. And its reason enum means "a named surface is holding the offer", which none of these endings are; reusing it would redefine an event several published figures are counted against. Two exits stay unreported on purpose. An off feature flag would emit once per page load for the whole population outside the rollout - a count of exposure rather than of the mechanism - and it is already on every event as a `$feature` property. An account that has not resolved yet is not a lost offer: the identity watcher re-drives the chain the moment it does, so that exit has a guaranteed wake-up, and it would have been present on nearly every flagged page load while discriminating nothing. No change to the offer's behaviour. `offerEligible` is unchanged and `offerIneligibility` is a separate expression from it so that naming a cause cannot alter a decision; the two split `if`s are split for naming only. All 71 pre-existing cases pass untouched.
Naming each silent exit put three more branches inside `offerConsentUnprompted`, which took its cognitive complexity over the threshold - `fallow audit` fails on newly introduced findings and this was one. No behaviour change. The missing-scope label moves to `missingScopeExit`, and the two non-`ready` auto-show outcomes become one if/else instead of three separate conditions, which is the shape the code had before the reporting was added.
f064b71 to
614bc9d
Compare
… of a shown card `requestConsentForCurrentUser` returned null without emitting on three paths, and a card dismissed with Escape or the overlay mask emitted `agent_consent_shown` and then nothing — so "shown and walked away" was indistinguishable from "shown and the accept failed". In the last three days 5 of 26 card impressions ended with no outcome at all, and the silent catch fired 23 times for 9 people, visible in Sentry and invisible to product analytics because `reportError` has no PostHog sink. `app:agent_consent_offer_exited` gains a fourth stage, `request`, with four endings: `scope_changed_before_read`, `scope_probe_failed`, `scope_changed_after_read`, and `card_closed_before_mount`, plus the existing `consent_read_failed` reused for the same condition one link later. The catch tracks which call was in flight because it cannot be read from the error: `ensureScope` and the read's `requireAuthHeader` raise the same `AgentConsentAuthenticationError` message, and 6 of those 23 production events are that message. A `trigger` property is set only at this stage, which is the only one reachable from the topbar button as well as the automatic offer. `app:agent_consent_resolved` becomes total over shown cards: `dismissed`, `accept_not_persisted` (the acceptance resolved false without raising, so no error is shown and the user believes they consented) and `accepted_pending_sign_in` join the two deciding values, with `save_error_shown` separating a give-up after a failed save from a walk-away. Only `accepted` still means consent is stored, and the type says so: a query that counted this event as a decision that stuck must now filter on it. Consent semantics are unchanged — same copy, same stored decision, still required before the panel opens.
1ad757e to
0b19c9d
Compare
614bc9d to
50f3019
Compare
Replaces automatically closed stacked PR #18992 after parent #18978 merged. Reconstructed root-first as the same two PR-owned commits on current `main`. Tracks every ending of a consent request and every outcome of a shown consent card. Preserves the test-only allowlist fixture repair. Validation: focused unit denominator 3 files / 168 tests passed; pre-push Knip and changed-file Fallow passed. No exposure or feature flags changed.
Stacked on #18978 (→ #18975 → #18966). Fourth PR in the consent-instrument stack; review that one first.
The gap
requestConsentForCurrentUserreturnednullwithout emitting on three paths, and a card dismissed with Escape or the overlay mask emittedapp:agent_consent_shownand then nothing — so "the card was shown and the user walked away" was indistinguishable from "the card was shown and the accept failed". After #18978, this composable was the only remaining place an automatic consent offer could end in silence.Both halves are sized from production rather than asserted, over
2026-09-23 00:00→2026-09-26 03:00project-local:app:agent_consent_shownagainst 21app:agent_consent_resolved, and all five silent impressions belong to one person who was shown the card five times and emits no otherapp:agent_*event at all. n=1, so nothing is inferred from why; that is the point.error_type:agent_consent_setting_load_failureoncloud-frontend-prodover the same window (a 14-day query returns the identical 23, so every occurrence is inside it). It was invisible to product analytics becausereportErrorfans out to Sentry, Datadog RUM and the desktop bridge and has no PostHog sink. For comparison, 21 people were ever shown a card in that window.The change
app:agent_consent_offer_exitedgains a fourthstage,request— extending #18978's contract rather than minting a second event, which is what its own decision table names a new stage for. Four endings, plus one existing value reused for the same condition one link later:exit:198ensureScope()resolved null — the scope moved during workspace initscope_changed_before_read:200-210ensureScope()raisedscope_probe_failed:200-210consentStore.load()raisedconsent_read_failed(reused fromstage: 'load'):212scope_changed_after_readcard_closed_before_mountThe catch tracks which call was in flight, because the error cannot carry it:
ensureScopeand the read'srequireAuthHeaderboth raiseAgentConsentAuthenticationError('Comfy account authentication is required'), and 6 of those 23 production events are exactly that message. Atriggerproperty is set only at this stage — the one stage reachable from the topbar button as well as the automatic offer, so without it a user-initiated click would land in the automatic-offer denominator.retry_armedisfalsehere structurally: the offer callsdropHold()immediately before requesting and onlycanShowre-arms, after every exit reported here.app:agent_consent_resolvedbecomes total over shown cards.dismissed,accept_not_persisted(the acceptance resolved false without raising, so no error is shown and the user believes they consented) andaccepted_pending_sign_injoin the two deciding values, plussave_error_shownto separate giving up after a failed save from walking away.Only
acceptedstill means consent is stored, and the type says so: a query that counted this event as "a decision that stuck" must now filter on it. The cost of that was measured, not assumed — all 1,271 insights in the project were scanned and exactly one references the event (an orphan on no dashboard) and it already filtersdecision = 'accepted'exactly.Consent semantics are unchanged. Same copy, same stored decision, still required before the panel opens;
agentPanel.tsand the hold/release machinery are untouched.Tests
useAgentConsent.test.ts: 31 passing (24 before). Three existing tests encoded the old silence and now assert the new outcome. Seven isolated reverts, one behaviour each — removing thedismissedoutcome fails exactly 2; collapsingaccept_not_persistedintoaccepted, collapsing the scope-probe/read distinction, collapsing the twoscope_changed_*values, reporting the pre-mount close as a dismissal, and hard-codingsave_error_showneach fail exactly 1; droppingaccepted_pending_sign_infails exactly 2. No revert failed zero tests.Full suite: 1,705 files, 24,329 passed, 32 expected-fail, 0 failures.
vue-tscapp + browser projects, changed-file type-awareoxlint,eslint,oxfmt --check,stylelintand the push-timefallowgate (✓ No issues in 13 changed files) all clean.New browser coverage —
browser_tests/tests/agent/agentConsentOutcome.spec.ts, 4 cases, run on abuild:clouddist through the offline runner with--retries=0: 4 passed, 40/40 with--repeat-each=10, and 19 passed alongside the existingagentConsent.spec.ts. It exists because a unit test arranges a dismissal by calling the dialog'sonCloseprop directly, which cannot tell whether a real Escape key or overlay click reaches that handler through the renderer and the dialog stack's escape bookkeeping. Each case was verified able to fail: reverting thedismissedemission fails exactly the two dismissal cases and leaves the acceptance case green; reverting the catch's emission fails exactly the request-stage case.The fourth case needed the mechanism understood first — with every read failing, the automatic chain exits at #18978's
loadstage and never reaches this function, because the store caches a successful read. The request-stage failure is reached by the entry button after a failed background read, which is the realistic shape of the 9 people above, and the case asserts the (request,consent_read_failed) pair against theload-stage exit from the same condition.Telemetry is captured at the host bridge (
window.__comfyDesktop2.Telemetryplusenable_telemetry), whichmain.tsalready supports alongside cloud — so the browser proves which events a real interaction produces and with which properties, through the sameTelemetryRegistrythe PostHog provider registers on. The registry→PostHog mapping stays asserted byPostHogTelemetryProvider.test.ts.Reading rules for anything built on these events
app:agent_consent_offer_exitedbyexit; a total is not a quantity. Counts are comparable within one (stage,exit) pair and never across stages — therequeststage counts attempts, the others report presence once per page load.stage = 'request', split bytriggerbefore comparing to anything about automatic offers.app:agent_consent_resolved:decision = 'accepted'for "consent is stored",decision in ('accepted', 'rejected')for "the user answered".