Repository navigation
Record consent state when automatic offers are held - #18976
christian-byrne wants to merge 2 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2140 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e968f0043081656295e79ced6f1e8a5243866595
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.98 MB (baseline 3.98 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 15 unchanged Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-26T10:05:04.039Z",
"gitSha": "d15eeb3eba8cc9be6deed9b7046d81277092d59c",
"branch": "feat/gc-29-consent-read-outcome",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.094000000042,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.096999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.46500000000003,
"heapDeltaBytes": -1454976,
"heapUsedBytes": 61164880,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 5.564999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1993.6840000000302,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.294,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 265.399,
"heapDeltaBytes": -1476264,
"heapUsedBytes": 61193720,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5.195,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1713.0869999999732,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.255,
"layouts": 12,
"layoutDurationMs": 2.6020000000000003,
"taskDurationMs": 482.71,
"heapDeltaBytes": -3093708,
"heapUsedBytes": 59332904,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 96.149,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.8700000000654,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.346999999999998,
"layouts": 12,
"layoutDurationMs": 2.426,
"taskDurationMs": 513.9849999999999,
"heapDeltaBytes": 22412292,
"heapUsedBytes": 84995212,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 90.875,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.5699999999988,
"styleRecalcs": 30,
"styleRecalcDurationMs": 7.487,
"layouts": 6,
"layoutDurationMs": 1.0879999999999999,
"taskDurationMs": 232.58800000000002,
"heapDeltaBytes": 2156728,
"heapUsedBytes": 64517028,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.855,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.2990000000245,
"styleRecalcs": 28,
"styleRecalcDurationMs": 6.789,
"layouts": 6,
"layoutDurationMs": 1.046,
"taskDurationMs": 223.413,
"heapDeltaBytes": 1853488,
"heapUsedBytes": 64456000,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.368000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 428.9019999999937,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.3350000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.673,
"heapDeltaBytes": 18461780,
"heapUsedBytes": 80700576,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 96.618,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 418.0549999999812,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.2909999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.753,
"heapDeltaBytes": 18442452,
"heapUsedBytes": 80879140,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 100.127,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1120.4219999999623,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 763.977,
"heapDeltaBytes": -13980576,
"heapUsedBytes": 72207612,
"domNodes": -259,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 38.205,
"eventListeners": -185,
"totalBlockingTimeMs": 448,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1017.9560000000265,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.036,
"heapDeltaBytes": 11624380,
"heapUsedBytes": 97674044,
"domNodes": -240,
"jsHeapTotalBytes": 26103808,
"scriptDurationMs": 37.026999999999994,
"eventListeners": -184,
"totalBlockingTimeMs": 411,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 684.3830000000253,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.06799999999976,
"heapDeltaBytes": 13647608,
"heapUsedBytes": 90718376,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 77.07,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.4730000000682,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.79700000000014,
"heapDeltaBytes": 15370368,
"heapUsedBytes": 91490932,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.52600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 95,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5383.66400000001,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3960000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4548.307000000001,
"heapDeltaBytes": 12179264,
"heapUsedBytes": 94869856,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 3643.3469999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5660.798,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.33399999999999924,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4769.5740000000005,
"heapDeltaBytes": 1801376,
"heapUsedBytes": 85201936,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 3830.639,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5666.639000000032,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.02499999999999898,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4942.261,
"heapDeltaBytes": -12816672,
"heapUsedBytes": 70673340,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 3821.126,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5570.3379999999925,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6519999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4960.3769999999995,
"heapDeltaBytes": 18916212,
"heapUsedBytes": 95770620,
"domNodes": -228,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 3814.947,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2019.06699999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.67400000000004,
"heapDeltaBytes": 2939924,
"heapUsedBytes": 83607336,
"domNodes": -228,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 17.735,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.0609999999933,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.105000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.679,
"heapDeltaBytes": 2936564,
"heapUsedBytes": 83128140,
"domNodes": -228,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 17.906000000000006,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2088.6359999999513,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.268000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1013.004,
"heapDeltaBytes": 19539548,
"heapUsedBytes": 84411252,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 501.7710000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2106.809999999996,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.167000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1023.39,
"heapDeltaBytes": -15664444,
"heapUsedBytes": 65470704,
"domNodes": -228,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 479.573,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3103.929999999991,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.367,
"layouts": 60,
"layoutDurationMs": 8.543999999999999,
"taskDurationMs": 1063.8960000000002,
"heapDeltaBytes": -15769732,
"heapUsedBytes": 65659808,
"domNodes": 0,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 446.023,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3075.0490000000354,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.3950000000000005,
"layouts": 60,
"layoutDurationMs": 8.566999999999998,
"taskDurationMs": 1051.9720000000002,
"heapDeltaBytes": 12740148,
"heapUsedBytes": 94554968,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 439.87899999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2096.0569999999734,
"styleRecalcs": 45,
"styleRecalcDurationMs": 3.5989999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1141.901,
"heapDeltaBytes": 17728240,
"heapUsedBytes": 83746940,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 538.315,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2118.7290000000303,
"styleRecalcs": 46,
"styleRecalcDurationMs": 3.6640000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1159.574,
"heapDeltaBytes": 18072816,
"heapUsedBytes": 84063964,
"domNodes": -228,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 544.357,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.324000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.45399999999995,
"heapDeltaBytes": -4721148,
"heapUsedBytes": 83915240,
"domNodes": -228,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 19.138,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2002.2579999999834,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5599999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.665,
"heapDeltaBytes": -5056052,
"heapUsedBytes": 83949756,
"domNodes": -228,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 18.793000000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 382.0860000000721,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.8539999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 249.26600000000002,
"heapDeltaBytes": 13687316,
"heapUsedBytes": 76699920,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 86.335,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 381.83699999990495,
"styleRecalcs": 49,
"styleRecalcDurationMs": 3.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 247.38,
"heapDeltaBytes": 13816300,
"heapUsedBytes": 77181112,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 85.29100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1988.0040000000463,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 271.522,
"heapDeltaBytes": -1693412,
"heapUsedBytes": 61410340,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4.831,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.7919999999285,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4600000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.77299999999997,
"heapDeltaBytes": -5578800,
"heapUsedBytes": 58265096,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 4.950000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1683.0079999999725,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.619000000000002,
"layouts": 16,
"layoutDurationMs": 3.556,
"taskDurationMs": 474.93100000000004,
"heapDeltaBytes": 18831404,
"heapUsedBytes": 81967260,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 59.929,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.0930000000235,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.870999999999999,
"layouts": 16,
"layoutDurationMs": 3.5320000000000005,
"taskDurationMs": 507.3599999999999,
"heapDeltaBytes": 5821948,
"heapUsedBytes": 68792400,
"domNodes": -244,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 60.138,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 782.9040000000305,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.030000000000005,
"layouts": 5,
"layoutDurationMs": 7.339999999999999,
"taskDurationMs": 555.553,
"heapDeltaBytes": 21623440,
"heapUsedBytes": 103706364,
"domNodes": 13667,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 16.79,
"eventListeners": 2383,
"totalBlockingTimeMs": 84,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8140.957000000071,
"styleRecalcs": 252,
"styleRecalcDurationMs": 18.478,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3556.3589999999995,
"heapDeltaBytes": 3364508,
"heapUsedBytes": 84630176,
"domNodes": -228,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 1612.4350000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8122.498000000064,
"styleRecalcs": 251,
"styleRecalcDurationMs": 18.899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3618.5,
"heapDeltaBytes": -13480200,
"heapUsedBytes": 68263036,
"domNodes": -228,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 1640.6009999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 9629.539000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8711.329000000002,
"heapDeltaBytes": -47652252,
"heapUsedBytes": 179891164,
"domNodes": -8049,
"jsHeapTotalBytes": -17240064,
"scriptDurationMs": 107.40200000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 7472.912000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6674.1539999999995,
"heapDeltaBytes": -68195788,
"heapUsedBytes": 172507924,
"domNodes": -8049,
"jsHeapTotalBytes": -10948608,
"scriptDurationMs": 84.55700000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 11712.014999999952,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.801000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10994.109999999999,
"heapDeltaBytes": -31645116,
"heapUsedBytes": 193510612,
"domNodes": -8049,
"jsHeapTotalBytes": -11874304,
"scriptDurationMs": 520.959,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12124.34200000007,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.14699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11351.582999999999,
"heapDeltaBytes": -44487892,
"heapUsedBytes": 195328776,
"domNodes": -8049,
"jsHeapTotalBytes": -18538496,
"scriptDurationMs": 537.001,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 2620.6489999999576,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.44399999999999,
"layouts": 20,
"layoutDurationMs": 15.597000000000007,
"taskDurationMs": 2490.431,
"heapDeltaBytes": -37811536,
"heapUsedBytes": 196815036,
"domNodes": -8049,
"jsHeapTotalBytes": 34217984,
"scriptDurationMs": 37.448,
"eventListeners": -14923,
"totalBlockingTimeMs": 30,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 2615.468000000078,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.536,
"layouts": 20,
"layoutDurationMs": 16.246000000000002,
"taskDurationMs": 2436.975,
"heapDeltaBytes": -37710896,
"heapUsedBytes": 189826620,
"domNodes": -8049,
"jsHeapTotalBytes": 14217216,
"scriptDurationMs": 38.323,
"eventListeners": -14923,
"totalBlockingTimeMs": 53,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4710.70700000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.11799999999997923,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4305.808000000001,
"heapDeltaBytes": 2515564,
"heapUsedBytes": 194594032,
"domNodes": 0,
"jsHeapTotalBytes": -22544384,
"scriptDurationMs": 42.654000000000025,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5004.998999999998,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.12499999999998623,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4393.289999999998,
"heapDeltaBytes": 32858248,
"heapUsedBytes": 202287564,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 50.89700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 75.6059999999934,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.882000000000001,
"layouts": 4,
"layoutDurationMs": 1.2129999999999996,
"taskDurationMs": 57.540000000000006,
"heapDeltaBytes": 3370932,
"heapUsedBytes": 65518060,
"domNodes": 100,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.010000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 76.40300000002753,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.426,
"layouts": 3,
"layoutDurationMs": 0.9859999999999999,
"taskDurationMs": 46.002,
"heapDeltaBytes": 3004080,
"heapUsedBytes": 64965148,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.468999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughConsent-not-offered telemetry now requires a consent-read outcome. The agent panel reports whether consent is known absent, known present, or not yet determined. Tests cover these outcomes and their telemetry payloads. ChangesConsent Read Telemetry
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change updates tests to verify a new consent-read-outcome telemetry field; no behavioral risk is introduced to production code. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18976 +/- ##
==========================================
+ Coverage 84.02% 84.92% +0.90%
==========================================
Files 3157 2308 -849
Lines 154214 132883 -21331
Branches 41858 34007 -7851
==========================================
- Hits 129574 112854 -16720
+ Misses 23041 19717 -3324
+ Partials 1599 312 -1287
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 860 files with indirect coverage changes 🚀 New features to boost your workflow:
|
… can reach `records an unsettled consent read when identity changes before a held card mounts` took the first-run screen *inside* the `withConsent` mock. No production ordering does that: `showFirstRunScreen` runs once per page load, from `handleStartupOutcome`, and always before it sets `startupDecided` — which every automatic offer waits on. So once an offer is in flight the first-run hold can only fall, never rise, and `tourHandoffs` only rises from a template click on the rendered screen, which holds the offer before it is ever made. The test needs *some* holder so `canShow` calls `holdOffer` and the `consent_read_outcome` can be asserted; it does not need that one. A coachmark tour opening over an in-flight offer is a real ordering and is already used by `withholds a card whose tour started while the offer was in flight`, so the arrange uses it and the reported reason becomes `tour_active`. What the test pins is unchanged: an identity change before `canShow` is recorded as `not_yet_determined`. Forcing `consentStore.isChecking` to read false still fails exactly this test and nothing else. This also removes this PR's only reference to the mock ref `firstRunTookScreen`, which #18966 renames to `firstRunHoldsScreen`, so the rebase onto #18966 no longer has a rename to carry here.
|
|
Order refreshed — you are still last of the consent stack, and the residual grew from three sites to four. Follow-up to #18976#issuecomment-5845321482, which said "land it last of the four" and quoted a three-site Current order: #18966 → #18977 → #18989 → #18975 → #18978 → #18992 → #18976 → #18973 → #18986 → #18985 → #18991. The residual is four sites now. #18978 added a fourth
Each is One more thing this PR's rebase now hits that it did not before: a one-hunk conflict on Full evidence and the per-file interaction matrix: #18966#issuecomment-5846101342 |
MaanilVerma
left a comment
There was a problem hiding this comment.
Merged main in locally and probed the mapping against the real agentConsentStore. Coverage is complete, since withholdOffer is the only place trackAgentConsentNotOffered is called, and the identity case holds up: the store's identity watcher is flush: 'sync', so isChecking is already true in the same tick as a switch.
| Check | Result |
|---|---|
| every hold carries the property | pass |
| same-tick identity switch | pass, against the real store |
| failed consent read | reported as known_absent, inline A below |
| tests with main merged | 5 red, inline B below |
| lint, format | pass |
This conflicts with main now (#18975 and #18978 landed on the same imports and tests). After resolving it, four of main's newer tests assert the exact { reason } payload and go red on the new required field, and "records an unsettled consent read when identity changes before a held card mounts" no longer reaches withConsent at all, so it fails on its first waitFor.
| const consentReadOutcome = (): AgentConsentReadOutcome => | ||
| consentStore.isChecking | ||
| ? 'not_yet_determined' | ||
| : consentStore.accepted | ||
| ? 'known_present' | ||
| : 'known_absent' |
There was a problem hiding this comment.
A
issue: a consent read that failed lands in known_absent. readConsent sets checkSettled in its finally, so after a missing auth header or a rejected settings call the store reads isChecking: false, accepted: false, and this maps that to "known not opted in". Running the mapping against the real store after both failures gives known_absent 2/2. Since the point of the property is to size who had already opted in when their card was held, those rows skew it. Could the store expose that the last read failed (a readFailed flag, or checkSettled only on success), with this reporting not_yet_determined or a fourth read_failed, and a test that fails the read before a hold?
| // The holder is a coachmark tour rather than the first-run screen because | ||
| // this test only needs *some* holder, and the first run cannot become one | ||
| // here: the screen is shown once per page load, before the startup decision | ||
| // every automatic offer waits on, so by the time an offer is in flight the | ||
| // first-run hold can only fall. A tour opening over an in-flight offer is a | ||
| // real ordering (see "withholds a card whose tour started while the offer was | ||
| // in flight"). What this test pins is the consent-read outcome, not the | ||
| // reason. | ||
| it('records an unsettled consent read when identity changes before a held card mounts', async () => { |
There was a problem hiding this comment.
B
suggestion: this test sets isChecking: true on the mocked store by hand, so it pins the mapping rather than the reset it is named for; the reset itself lives in agentConsentStore and is already flush: 'sync'. With main merged in, the arrange also no longer reaches withConsent (0 calls), so it fails before its assertion. When you rebase, could the identity case move to a store-level test (switch workspace, read isChecking in the same tick), and the eight-line comment above it shrink to one line?
Summary
consent_read_outcomeproperty toapp:agent_consent_not_offeredknown_absent,known_present, andnot_yet_determinedconsent readsTesting
pnpm test:unit src/extensions/core/agentPanel.test.ts src/platform/telemetry/TelemetryRegistry.test.ts src/platform/telemetry/providers/host/HostTelemetrySink.test.ts src/platform/telemetry/providers/cloud/PostHogTelemetryProvider.test.tspnpm format:checkNODE_OPTIONS=--max-old-space-size=8192 pnpm typecheckpnpm lint