Repository navigation
[backport core/1.55] fix(agent): defer the consent offer past the first-run screen instead of dropping it - #19352
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (14 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6c3a7ea63d14a02b74537801d8b88ae52580db53
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2125 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T05:37:18.413Z",
"gitSha": "9736fb21fdff00fbb9d537235e4bfa4537449b7f",
"branch": "backport-18966-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.354999999975,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.446999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.67300000000006,
"heapDeltaBytes": -8526592,
"heapUsedBytes": 59267300,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.964000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.716000000073,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.389,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.788,
"heapDeltaBytes": -6243440,
"heapUsedBytes": 56312744,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.106000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.5560000000064,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.797,
"heapDeltaBytes": 10743436,
"heapUsedBytes": 78199992,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.12899999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.8740000000653,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.713000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.9820000000001,
"heapDeltaBytes": -6066156,
"heapUsedBytes": 62080896,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.765,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.3010000000195,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.911,
"layouts": 6,
"layoutDurationMs": 1.0639999999999998,
"taskDurationMs": 275.549,
"heapDeltaBytes": 3141720,
"heapUsedBytes": 70694320,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.196,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.61599999993,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.166,
"layouts": 6,
"layoutDurationMs": 0.913,
"taskDurationMs": 274.982,
"heapDeltaBytes": 2168184,
"heapUsedBytes": 64611760,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.067,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 553.1259999999634,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.882000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.55,
"heapDeltaBytes": 18673952,
"heapUsedBytes": 86161040,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 127.53299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 532.7030000000832,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.163,
"heapDeltaBytes": 18888364,
"heapUsedBytes": 86580060,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 125.45800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1110.087999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 766.591,
"heapDeltaBytes": -14876840,
"heapUsedBytes": 72652772,
"domNodes": -294,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 46.29900000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 459,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1099.7220000000425,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.261,
"heapDeltaBytes": 11460708,
"heapUsedBytes": 101180224,
"domNodes": -291,
"jsHeapTotalBytes": 26365952,
"scriptDurationMs": 48.719,
"eventListeners": -195,
"totalBlockingTimeMs": 473,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 746.15399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.3789999999998,
"heapDeltaBytes": 15742948,
"heapUsedBytes": 91280284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.64099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 733.0459999999448,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.50199999999984,
"heapDeltaBytes": 14071092,
"heapUsedBytes": 90801372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.77399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7193.789000000038,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.5810000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6307.55,
"heapDeltaBytes": -8147948,
"heapUsedBytes": 69076384,
"domNodes": -269,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 4899.17,
"eventListeners": -174,
"totalBlockingTimeMs": 58,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6533.685999999989,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.08199999999999874,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5806.846,
"heapDeltaBytes": -1387592,
"heapUsedBytes": 80896720,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 4677.333,
"eventListeners": 0,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6803.877999999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.7080000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6018.453,
"heapDeltaBytes": 8549788,
"heapUsedBytes": 85774500,
"domNodes": -263,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 4688.005999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 86,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.19999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7507.122999999979,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06600000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6683.454000000001,
"heapDeltaBytes": 5751420,
"heapUsedBytes": 87930116,
"domNodes": -16,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 5262.686,
"eventListeners": 0,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2042.8800000000251,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.138000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.36800000000005,
"heapDeltaBytes": -5860108,
"heapUsedBytes": 81429208,
"domNodes": -243,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 28.690999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2048.6590000000433,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.956,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.9119999999999,
"heapDeltaBytes": -603172,
"heapUsedBytes": 79234196,
"domNodes": -244,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 33.235,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2122.014999999976,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.043999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1251.8090000000002,
"heapDeltaBytes": -3251820,
"heapUsedBytes": 84593752,
"domNodes": -239,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 612.712,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2086.061000000086,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.515,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1218.937,
"heapDeltaBytes": 15705772,
"heapUsedBytes": 79909244,
"domNodes": -240,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 597.977,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3144.2069999999944,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.962,
"layouts": 60,
"layoutDurationMs": 11.536,
"taskDurationMs": 1306.976,
"heapDeltaBytes": -15277288,
"heapUsedBytes": 74253088,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 552.427,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3149.6219999999084,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.592999999999998,
"layouts": 60,
"layoutDurationMs": 11.967,
"taskDurationMs": 1201.961,
"heapDeltaBytes": 8545000,
"heapUsedBytes": 74494080,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 589.919,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2267.402000000004,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.289,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1462.6019999999999,
"heapDeltaBytes": 17927428,
"heapUsedBytes": 84034148,
"domNodes": 10,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 703.183,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2302.7150000000347,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.725000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1514.8,
"heapDeltaBytes": -17204708,
"heapUsedBytes": 74069492,
"domNodes": -250,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 724.576,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2039.27699999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.6640000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.9230000000001,
"heapDeltaBytes": -5941852,
"heapUsedBytes": 83515968,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 29.348,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2050.021000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.130999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.468,
"heapDeltaBytes": -8522368,
"heapUsedBytes": 80884284,
"domNodes": -246,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 29.525999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.849000000017,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.299000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.765,
"heapDeltaBytes": 14027892,
"heapUsedBytes": 83954652,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 108.81,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.8559999999525,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.891,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.67599999999993,
"heapDeltaBytes": 14098764,
"heapUsedBytes": 84033400,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 109.752,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.4949999999958,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.783000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.129,
"heapDeltaBytes": 11764620,
"heapUsedBytes": 81584000,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.300000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.5509999999585,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.787000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.31299999999993,
"heapDeltaBytes": 9910620,
"heapUsedBytes": 79756368,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.581999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.815000000006,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.718999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.0120000000001,
"heapDeltaBytes": -6803024,
"heapUsedBytes": 63065888,
"domNodes": -273,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 70.229,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.8559999999588,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.956000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.775,
"heapDeltaBytes": -6931948,
"heapUsedBytes": 63014040,
"domNodes": -276,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 70.79599999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.2789999999591,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.032000000000004,
"layouts": 5,
"layoutDurationMs": 8.794000000000002,
"taskDurationMs": 693.2529999999999,
"heapDeltaBytes": 20170508,
"heapUsedBytes": 103397468,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 21.773999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 121,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8190.833999999995,
"styleRecalcs": 252,
"styleRecalcDurationMs": 34.769,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4446.927000000001,
"heapDeltaBytes": -7210636,
"heapUsedBytes": 80171192,
"domNodes": -238,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 2036.0819999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8145.053000000075,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.107000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4405.6230000000005,
"heapDeltaBytes": -19367200,
"heapUsedBytes": 67934156,
"domNodes": -213,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 1998.5560000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12453.802999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11705.831999999997,
"heapDeltaBytes": -42777196,
"heapUsedBytes": 182695068,
"domNodes": -8062,
"jsHeapTotalBytes": -8658944,
"scriptDurationMs": 188.03599999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12140.137999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11247.831000000002,
"heapDeltaBytes": -23717588,
"heapUsedBytes": 196604704,
"domNodes": -8062,
"jsHeapTotalBytes": -18743296,
"scriptDurationMs": 174.88600000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15198.452999999972,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.075000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14731.107000000002,
"heapDeltaBytes": -60484700,
"heapUsedBytes": 180588764,
"domNodes": -8062,
"jsHeapTotalBytes": -18153472,
"scriptDurationMs": 754.9290000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 11643.62399999993,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.527999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11066.116,
"heapDeltaBytes": -44045112,
"heapUsedBytes": 189132200,
"domNodes": -8062,
"jsHeapTotalBytes": -6868992,
"scriptDurationMs": 632.8979999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4343.62299999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.26599999999999,
"layouts": 20,
"layoutDurationMs": 21.627000000000006,
"taskDurationMs": 4214.441000000001,
"heapDeltaBytes": -59861928,
"heapUsedBytes": 180582028,
"domNodes": -8062,
"jsHeapTotalBytes": 10330112,
"scriptDurationMs": 76.603,
"eventListeners": -14928,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4251.027000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.59099999999998,
"layouts": 20,
"layoutDurationMs": 20.45699999999999,
"taskDurationMs": 4136.594000000001,
"heapDeltaBytes": -44049700,
"heapUsedBytes": 196141644,
"domNodes": -8062,
"jsHeapTotalBytes": 10330112,
"scriptDurationMs": 76.06799999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6279.086000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5945.654000000001,
"heapDeltaBytes": 12048088,
"heapUsedBytes": 195403684,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 110.59399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6204.905999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5734.686999999999,
"heapDeltaBytes": -13751932,
"heapUsedBytes": 169942692,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 86.21200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 450.9689999999864,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.168,
"layouts": 5,
"layoutDurationMs": 4.356999999999999,
"taskDurationMs": 112.13199999999999,
"heapDeltaBytes": 5281824,
"heapUsedBytes": 70882208,
"domNodes": 154,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.081000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 439.25400000000536,
"styleRecalcs": 18,
"styleRecalcDurationMs": 18.392,
"layouts": 4,
"layoutDurationMs": 1.624,
"taskDurationMs": 95.828,
"heapDeltaBytes": 5039872,
"heapUsedBytes": 70834304,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.319000000000003,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
… of dropping it (#18966) Defers the automatic Agent consent offer while Getting Started owns the screen, then re-offers it in the same session after that ownership ends. The template path keeps first-run ownership across the dismissal-to-tour preview gap, so the consent card cannot open underneath the tour. The first-session entry-button/feature-flag timing question is separate and is not changed here. - Arms the consent retry for `first_run_screen` instead of dropping that offer. - Uses live first-run screen ownership, including pending screen-to-tour handoffs, when deciding whether consent can be shown. - Cancels and releases an in-flight handoff when the authenticated identity changes, preventing the previous account tour or hold from crossing sessions. - Removes the obsolete `firstRunTookScreen` latch. - Keeps failed template loads on Getting Started and removes duplicate no-tour coverage. - `dismissIntoFirstRunTour` snapshots the owner, passes an identity-change cancellation predicate to `beginTour`, and invalidates pending holds at the auth boundary. - Per-call symbols keep concurrent handoff ownership distinct, while `authGeneration` separately invalidates stale continuations across authenticated-session changes. - Bare dismissal releases consent; template selection retains ownership until the tour has either started, declined, or failed. At current head `e93ee8410e`, rebased directly on `main` at `4ff3690047` (eleven-file base-to-head diff): - `pnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts --testTimeout=30000` — 4 files, 226 tests passed. - `bash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer until Getting Started releases the screen' --workers=1 --repeat-each=5` — 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution Vite process; the scenario-only 90-second budget covers both application boots. - ESLint, Oxlint, oxfmt, `git diff --check`, pre-push Knip, and changed-line Fallow passed. Fallow excluded 17 inherited dependency findings and reported two inherited styling advisories. The branch retains the test-only changes from #18977 and #18989. Those PRs were merged into this PR's branch (their GitHub base was `fix/agent-consent-defer-first-run-screen`), not into `main`; dropping them during reconciliation would lose their approved coverage. The rebase preserves the eleven-file product/browser patch while removing the stale `main` ancestry. --------- Co-authored-by: Amp <amp@ampcode.com>
fcf9ac0 to
1b06bc8
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19352 +/- ##
=============================================
- Coverage 84.70% 84.70% -0.01%
=============================================
Files 2322 2322
Lines 132720 132841 +121
Branches 33704 35638 +1934
=============================================
+ Hits 112419 112521 +102
- Misses 19949 19968 +19
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Backport of #18966.
Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included.
Validation: focused unit suite (193/193); application and browser typechecks; staged lint/format checks.