Repository navigation
[backport cloud/1.55] fix(agent): defer the consent offer past the first-run screen instead of dropping it - #19354
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
… of dropping it (#18966) Defers the automatic Agent consent offer while Getting Started owns the screen, then re-offers it in the same session after that ownership ends. The template path keeps first-run ownership across the dismissal-to-tour preview gap, so the consent card cannot open underneath the tour. The first-session entry-button/feature-flag timing question is separate and is not changed here. - Arms the consent retry for `first_run_screen` instead of dropping that offer. - Uses live first-run screen ownership, including pending screen-to-tour handoffs, when deciding whether consent can be shown. - Cancels and releases an in-flight handoff when the authenticated identity changes, preventing the previous account tour or hold from crossing sessions. - Removes the obsolete `firstRunTookScreen` latch. - Keeps failed template loads on Getting Started and removes duplicate no-tour coverage. - `dismissIntoFirstRunTour` snapshots the owner, passes an identity-change cancellation predicate to `beginTour`, and invalidates pending holds at the auth boundary. - Per-call symbols keep concurrent handoff ownership distinct, while `authGeneration` separately invalidates stale continuations across authenticated-session changes. - Bare dismissal releases consent; template selection retains ownership until the tour has either started, declined, or failed. At current head `e93ee8410e`, rebased directly on `main` at `4ff3690047` (eleven-file base-to-head diff): - `pnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts --testTimeout=30000` — 4 files, 226 tests passed. - `bash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer until Getting Started releases the screen' --workers=1 --repeat-each=5` — 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution Vite process; the scenario-only 90-second budget covers both application boots. - ESLint, Oxlint, oxfmt, `git diff --check`, pre-push Knip, and changed-line Fallow passed. Fallow excluded 17 inherited dependency findings and reported two inherited styling advisories. The branch retains the test-only changes from #18977 and #18989. Those PRs were merged into this PR's branch (their GitHub base was `fix/agent-consent-defer-first-run-screen`), not into `main`; dropping them during reconciliation would lose their approved coverage. The rebase preserves the eleven-file product/browser patch while removing the stale `main` ancestry. --------- Co-authored-by: Amp <amp@ampcode.com>
9eaed50 to
ed8d240
Compare
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (14 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b90370ea0074ed0f732673042bb9f13a5a3c379a
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T05:10:34.367Z",
"gitSha": "558dbd15f3312c78293f7b5cfdb93fa559d52b77",
"branch": "backport-18966-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.5979999999827,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.956999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.253,
"heapDeltaBytes": -6276856,
"heapUsedBytes": 61333956,
"domNodes": -256,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5.351000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1988.5799999999563,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.499,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.565,
"heapDeltaBytes": -11000124,
"heapUsedBytes": 56788200,
"domNodes": -256,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.403999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.5259999999766,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.565,
"heapDeltaBytes": 10436980,
"heapUsedBytes": 77942256,
"domNodes": -256,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 94.75500000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.372000000044,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.045,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.1840000000001,
"heapDeltaBytes": -7672196,
"heapUsedBytes": 60240696,
"domNodes": -258,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 91.333,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.228,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.388000000000002,
"layouts": 6,
"layoutDurationMs": 0.838,
"taskDurationMs": 179.77700000000002,
"heapDeltaBytes": 2172356,
"heapUsedBytes": 64618616,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.6869999999999985,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.6470000001027,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.296,
"layouts": 6,
"layoutDurationMs": 1.009,
"taskDurationMs": 203.04500000000004,
"heapDeltaBytes": 2076356,
"heapUsedBytes": 64573632,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.719,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 432.3100000000295,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.844999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.622,
"heapDeltaBytes": 18337872,
"heapUsedBytes": 80666016,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 99.105,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 431.09199999997827,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.346999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.41299999999995,
"heapDeltaBytes": 18227796,
"heapUsedBytes": 86289756,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 104.96600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 855.7319999999891,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.73300000000006,
"heapDeltaBytes": 38475596,
"heapUsedBytes": 106868324,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 33.443000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 263,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 876.3260000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.612,
"heapDeltaBytes": -17001364,
"heapUsedBytes": 73110156,
"domNodes": -290,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 32.50000000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 264,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 671.4649999999551,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 239.2209999999997,
"heapDeltaBytes": 14888852,
"heapUsedBytes": 91796624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 79.791,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 671.4880000000107,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 260.8990000000002,
"heapDeltaBytes": 14335304,
"heapUsedBytes": 90773844,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.257,
"eventListeners": 0,
"totalBlockingTimeMs": 80,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5847.726000000022,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.083999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4808.356,
"heapDeltaBytes": 8886948,
"heapUsedBytes": 86166200,
"domNodes": -271,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 3765.623,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5589.570999999978,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1390000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4540.732999999999,
"heapDeltaBytes": 326200,
"heapUsedBytes": 72311908,
"domNodes": -7,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 3712.808,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5173.047999999994,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.4990000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4362.765,
"heapDeltaBytes": -2369408,
"heapUsedBytes": 73605548,
"domNodes": -254,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 3587.4449999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 20,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5464.265999999952,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.8030000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4521.7210000000005,
"heapDeltaBytes": 436548,
"heapUsedBytes": 82559916,
"domNodes": -12,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 3571.549,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.3749999999914,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.623999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.952,
"heapDeltaBytes": -6249092,
"heapUsedBytes": 80106100,
"domNodes": -237,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 18.983,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2014.5880000000034,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.27000000000004,
"heapDeltaBytes": -2449036,
"heapUsedBytes": 83523028,
"domNodes": -233,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 18.84999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2134.051999999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.593000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1028.233,
"heapDeltaBytes": 15719104,
"heapUsedBytes": 79928836,
"domNodes": -234,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 518.777,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2080.426999999986,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.750000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 972.128,
"heapDeltaBytes": 19535636,
"heapUsedBytes": 84065184,
"domNodes": -240,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 522.772,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3072.3560000000134,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.075000000000001,
"layouts": 60,
"layoutDurationMs": 13.799000000000001,
"taskDurationMs": 1096.614,
"heapDeltaBytes": -23086104,
"heapUsedBytes": 65347784,
"domNodes": -211,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 498.58,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3070.3020000000265,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.974000000000002,
"layouts": 60,
"layoutDurationMs": 14.275999999999998,
"taskDurationMs": 1136.167,
"heapDeltaBytes": -19439564,
"heapUsedBytes": 69067620,
"domNodes": -238,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 507.34000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2238.570999999979,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1206.0149999999999,
"heapDeltaBytes": -8254292,
"heapUsedBytes": 83022636,
"domNodes": -238,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 607.408,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2252.5829999999587,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1269.131,
"heapDeltaBytes": 1036,
"heapUsedBytes": 83730708,
"domNodes": -245,
"jsHeapTotalBytes": 1196032,
"scriptDurationMs": 657.122,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2016.522000000009,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.125000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.53899999999993,
"heapDeltaBytes": -3647548,
"heapUsedBytes": 84215276,
"domNodes": -231,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 18.523999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.7480000000114,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.8359999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.364,
"heapDeltaBytes": 20609336,
"heapUsedBytes": 84579084,
"domNodes": -237,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.589999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.0990000000256,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.444999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 253.548,
"heapDeltaBytes": 13693916,
"heapUsedBytes": 83720784,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 92.66499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.07899999996243,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.474000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 252.79000000000002,
"heapDeltaBytes": 13406772,
"heapUsedBytes": 83705460,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 91.806,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1993.6660000000188,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.689999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 255.788,
"heapDeltaBytes": 6084392,
"heapUsedBytes": 69283796,
"domNodes": -272,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 4.7010000000000005,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1990.3770000000236,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 271.75300000000004,
"heapDeltaBytes": -6476852,
"heapUsedBytes": 63290580,
"domNodes": -271,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 4.805000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1661.4799999999832,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.42199999999997,
"heapDeltaBytes": 8728572,
"heapUsedBytes": 78478080,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 70.501,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.494000000001,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.104000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.844,
"heapDeltaBytes": -6977652,
"heapUsedBytes": 63004268,
"domNodes": -273,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 72.09,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 783.9860000000272,
"styleRecalcs": 18,
"styleRecalcDurationMs": 17.479000000000003,
"layouts": 5,
"layoutDurationMs": 7.463999999999999,
"taskDurationMs": 504.286,
"heapDeltaBytes": 20189964,
"heapUsedBytes": 103065412,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 18.092,
"eventListeners": 2383,
"totalBlockingTimeMs": 55,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8118.235000000027,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.512,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3414.2389999999996,
"heapDeltaBytes": -9127644,
"heapUsedBytes": 77414856,
"domNodes": -209,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 1748.609,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8207.270999999992,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.846999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3649.465,
"heapDeltaBytes": -18207820,
"heapUsedBytes": 68110996,
"domNodes": -212,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 1892.7420000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10708.501000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9597.482,
"heapDeltaBytes": -53397144,
"heapUsedBytes": 168738032,
"domNodes": -8062,
"jsHeapTotalBytes": -17358848,
"scriptDurationMs": 146.37900000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10682.581000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9791.32,
"heapDeltaBytes": -69222952,
"heapUsedBytes": 172491116,
"domNodes": -8062,
"jsHeapTotalBytes": -24408064,
"scriptDurationMs": 131.53300000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13415.92399999996,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12862.404,
"heapDeltaBytes": -52584484,
"heapUsedBytes": 184066296,
"domNodes": -8062,
"jsHeapTotalBytes": -15122432,
"scriptDurationMs": 527.441,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13579.533999999967,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.981999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13023.735999999997,
"heapDeltaBytes": -21692208,
"heapUsedBytes": 193665596,
"domNodes": -8062,
"jsHeapTotalBytes": -14807040,
"scriptDurationMs": 549.982,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3772.82299999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.485,
"layouts": 20,
"layoutDurationMs": 18.099999999999998,
"taskDurationMs": 3696.4919999999997,
"heapDeltaBytes": -43558588,
"heapUsedBytes": 179038912,
"domNodes": -8062,
"jsHeapTotalBytes": 21700608,
"scriptDurationMs": 56.768,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3844.1440000000284,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.675999999999995,
"layouts": 20,
"layoutDurationMs": 17.91399999999999,
"taskDurationMs": 3746.743,
"heapDeltaBytes": -44663668,
"heapUsedBytes": 178188096,
"domNodes": -8066,
"jsHeapTotalBytes": 20389888,
"scriptDurationMs": 56.33,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5213.724000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4755.475,
"heapDeltaBytes": 5183300,
"heapUsedBytes": 195126472,
"domNodes": 0,
"jsHeapTotalBytes": -28049408,
"scriptDurationMs": 82.779,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5374.114999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4871.555,
"heapDeltaBytes": 17729276,
"heapUsedBytes": 202917704,
"domNodes": 0,
"jsHeapTotalBytes": -29884416,
"scriptDurationMs": 65.02400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 440.75000000003683,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.616000000000001,
"layouts": 4,
"layoutDurationMs": 1.596,
"taskDurationMs": 89.254,
"heapDeltaBytes": 5330392,
"heapUsedBytes": 67307108,
"domNodes": 150,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.207,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 417.64200000000073,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.386999999999999,
"layouts": 3,
"layoutDurationMs": 0.825,
"taskDurationMs": 75.47099999999999,
"heapDeltaBytes": 4787300,
"heapUsedBytes": 66861564,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.804000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19354 +/- ##
=============================================
Coverage ? 84.69%
=============================================
Files ? 2322
Lines ? 132914
Branches ? 35949
=============================================
Hits ? 112574
Misses ? 19988
Partials ? 352
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Backport of #18966.
Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included.
Validation: focused unit suite (193/193); application and browser typechecks; staged lint/format checks.