Skip to content

[backport cloud/1.54] fix(agent): defer the consent offer past the first-run screen instead of dropping it - #19353

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18966-to-cloud-1.54
Sep 29, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18966-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #18966.

Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included.

Validation: focused unit suite (199/199); application and browser typechecks; staged lint/format checks.

@christian-byrne
christian-byrne requested a review from a team as a code owner September 29, 2026 04:44
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 29, 2026
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 4:46am UTC
billing-web-test Ignored Ignored Sep 29, 2026 4:46am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 5c489d05-48a8-4069-a1e8-d68fccf75f29

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

… of dropping it (#18966)

Defers the automatic Agent consent offer while Getting Started owns the
screen, then re-offers it in the same session after that ownership ends.
The template path keeps first-run ownership across the dismissal-to-tour
preview gap, so the consent card cannot open underneath the tour.

The first-session entry-button/feature-flag timing question is separate
and is not changed here.

- Arms the consent retry for `first_run_screen` instead of dropping that
offer.
- Uses live first-run screen ownership, including pending screen-to-tour
handoffs, when deciding whether consent can be shown.
- Cancels and releases an in-flight handoff when the authenticated
identity changes, preventing the previous account tour or hold from
crossing sessions.
- Removes the obsolete `firstRunTookScreen` latch.
- Keeps failed template loads on Getting Started and removes duplicate
no-tour coverage.

- `dismissIntoFirstRunTour` snapshots the owner, passes an
identity-change cancellation predicate to `beginTour`, and invalidates
pending holds at the auth boundary.
- Per-call symbols keep concurrent handoff ownership distinct, while
`authGeneration` separately invalidates stale continuations across
authenticated-session changes.
- Bare dismissal releases consent; template selection retains ownership
until the tour has either started, declined, or failed.

At current head `e93ee8410e`, rebased directly on `main` at `4ff3690047`
(eleven-file base-to-head diff):

- `pnpm test:unit src/extensions/core/agentPanel.test.ts
src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts
src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts
src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts
--testTimeout=30000` — 4 files, 226 tests passed.
- `bash scripts/test-browser-offline.sh --project=cloud
browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer
until Getting Started releases the screen' --workers=1 --repeat-each=5`
— 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution
Vite process; the scenario-only 90-second budget covers both application
boots.
- ESLint, Oxlint, oxfmt, `git diff --check`, pre-push Knip, and
changed-line Fallow passed. Fallow excluded 17 inherited dependency
findings and reported two inherited styling advisories.

The branch retains the test-only changes from #18977 and #18989. Those
PRs were merged into this PR's branch (their GitHub base was
`fix/agent-consent-defer-first-run-screen`), not into `main`; dropping
them during reconciliation would lose their approved coverage. The
rebase preserves the eleven-file product/browser patch while removing
the stale `main` ancestry.

---------

Co-authored-by: Amp <amp@ampcode.com>
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 05:09:09 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 150ms TBT · 81.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.8 MB heap
vue-large-graph-idle: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.8 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 121ms TBT · 180.6 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 247ms TBT · 176.9 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 565ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.2 MB
canvas-idle: DOM nodes -133
canvas-idle: event listeners -79
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 35ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 1020ms
canvas-mouse-sweep: script duration 178ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.4 MB
canvas-mouse-sweep: DOM nodes -284
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 420ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 473ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.5 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 691ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 77.5 MB
large-graph-idle: DOM nodes -278
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1798ms
large-graph-pan: script duration 881ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 86.0 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -176
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1851ms
large-graph-zoom: script duration 810ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.6 MB
large-graph-zoom: DOM nodes -142
large-graph-zoom: event listeners -89
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2073ms
legacy-node-drag: script duration 1011ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.6 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 710ms
minimap-idle: script duration 39ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.2 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 444ms
subgraph-dom-widget-clipping: script duration 151ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 556ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.9 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 887ms
subgraph-mouse-sweep: script duration 121ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 79.1 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1029ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 150ms
subgraph-transition-enter: heap used 81.3 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6360ms
viewport-pan-sweep: script duration 2905ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.8 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -175
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17005ms
vue-large-graph-idle: script duration 294ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.8 MB
vue-large-graph-idle: DOM nodes -8070
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 164
vue-large-graph-pan: task duration 21150ms
vue-large-graph-pan: script duration 944ms
vue-large-graph-pan: TBT 121ms
vue-large-graph-pan: heap used 180.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14925
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 84ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5532ms
vue-node-resize-workload: script duration 110ms
vue-node-resize-workload: TBT 247ms
vue-node-resize-workload: heap used 176.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8541ms
vue-zoom-out-idle: script duration 154ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 100ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.2 MB
workflow-execution: DOM nodes 125
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-29T05:13:13.190Z",
  "gitSha": "dd9b625a8f6f636c8e800ea92137ea5681be528c",
  "branch": "backport-18966-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2085.9229999999798,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.596,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 636.892,
      "heapDeltaBytes": 2812760,
      "heapUsedBytes": 73750024,
      "domNodes": -283,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 12.329999999999997,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2035.2039999999647,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.088000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.0369999999999,
      "heapDeltaBytes": 1761192,
      "heapUsedBytes": 71410232,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.629,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2102.028999999959,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 38.483000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.324000000000001,
      "taskDurationMs": 1095.744,
      "heapDeltaBytes": 11327296,
      "heapUsedBytes": 82537904,
      "domNodes": -286,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 188.45999999999998,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1882.5300000000311,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 32.09,
      "layouts": 14,
      "layoutDurationMs": 4.06,
      "taskDurationMs": 944.428,
      "heapDeltaBytes": -3128476,
      "heapUsedBytes": 67248964,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 168.12199999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1750.564000000054,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.995,
      "layouts": 6,
      "layoutDurationMs": 1.261,
      "taskDurationMs": 417.80300000000005,
      "heapDeltaBytes": 4548212,
      "heapUsedBytes": 75631532,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 14.779,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.6260000000302,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.739,
      "layouts": 6,
      "layoutDurationMs": 0.9740000000000001,
      "taskDurationMs": 422.178,
      "heapDeltaBytes": 4301940,
      "heapUsedBytes": 74518988,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 15.410000000000004,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 725.8209999999963,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.522999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.791,
      "heapDeltaBytes": 18388412,
      "heapUsedBytes": 88648548,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 168.26,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 684.2739999999594,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.93,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.52,
      "heapDeltaBytes": -7589836,
      "heapUsedBytes": 63434324,
      "domNodes": 20,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 165.282,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.760999999979,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.9819999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 715.982,
      "heapDeltaBytes": -2006908,
      "heapUsedBytes": 74952636,
      "domNodes": -285,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 36.041000000000004,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.7059999999437,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.093,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 666.1590000000001,
      "heapDeltaBytes": 11051280,
      "heapUsedBytes": 87539124,
      "domNodes": -271,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 36.163000000000004,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2642.1339999999987,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.604999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1807.867,
      "heapDeltaBytes": 11907468,
      "heapUsedBytes": 89430604,
      "domNodes": -273,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 867.2379999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2703.0710000000227,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.121000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1787.4769999999999,
      "heapDeltaBytes": 24784108,
      "heapUsedBytes": 90863260,
      "domNodes": -277,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 895.644,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3850.7549999999924,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 13.457,
      "layouts": 60,
      "layoutDurationMs": 12.421999999999999,
      "taskDurationMs": 1913.271,
      "heapDeltaBytes": -2917788,
      "heapUsedBytes": 76136136,
      "domNodes": -283,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 832.2080000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3643.1910000000016,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.116,
      "layouts": 60,
      "layoutDurationMs": 12.184000000000001,
      "taskDurationMs": 1788.2959999999998,
      "heapDeltaBytes": 8022852,
      "heapUsedBytes": 76165288,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 786.815,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3180.7039999999915,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.727999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2101.9480000000003,
      "heapDeltaBytes": 10305544,
      "heapUsedBytes": 91954756,
      "domNodes": -283,
      "jsHeapTotalBytes": -733184,
      "scriptDurationMs": 1006.0880000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3203.4340000000157,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.316000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2043.7050000000002,
      "heapDeltaBytes": 907156,
      "heapUsedBytes": 68612656,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 1016.8770000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.6530000000294,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.3209999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 724.3690000000001,
      "heapDeltaBytes": 9705892,
      "heapUsedBytes": 88043820,
      "domNodes": -276,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 37.586999999999996,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2064.236000000051,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 10.586000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 696.184,
      "heapDeltaBytes": 8045992,
      "heapUsedBytes": 86489916,
      "domNodes": -275,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 41.400000000000006,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 676.890999999955,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 14.016999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.464,
      "heapDeltaBytes": 15253460,
      "heapUsedBytes": 88359148,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 152.79,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 621.7049999999062,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 10.395000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.333,
      "heapDeltaBytes": 15195976,
      "heapUsedBytes": 88465724,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 148.483,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2056.6289999999867,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.485000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 535.237,
      "heapDeltaBytes": -8010288,
      "heapUsedBytes": 64653072,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.925000000000002,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2036.750999999981,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.733,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.901,
      "heapDeltaBytes": -7484664,
      "heapUsedBytes": 65191460,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 11.861999999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1757.4970000000008,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 29.674,
      "layouts": 18,
      "layoutDurationMs": 5.055,
      "taskDurationMs": 871.6630000000001,
      "heapDeltaBytes": 9640804,
      "heapUsedBytes": 83044924,
      "domNodes": -299,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 117.68400000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1773.4889999999268,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 32.03,
      "layouts": 18,
      "layoutDurationMs": 5.394,
      "taskDurationMs": 902.7620000000001,
      "heapDeltaBytes": 9458728,
      "heapUsedBytes": 82858912,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 123.759,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1402.3960000000102,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 34.385,
      "layouts": 15,
      "layoutDurationMs": 16.864,
      "taskDurationMs": 1028.7050000000002,
      "heapDeltaBytes": -5113468,
      "heapUsedBytes": 85196880,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 34.278000000000006,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 150,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9176.430999999979,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.443,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6269.403,
      "heapDeltaBytes": 1722056,
      "heapUsedBytes": 77727216,
      "domNodes": -282,
      "jsHeapTotalBytes": 90112,
      "scriptDurationMs": 2847.5650000000005,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9608.224999999948,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6450.54,
      "heapDeltaBytes": 16863976,
      "heapUsedBytes": 93844104,
      "domNodes": -270,
      "jsHeapTotalBytes": 1400832,
      "scriptDurationMs": 2961.897,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17667.253000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16948.557,
      "heapDeltaBytes": -59395848,
      "heapUsedBytes": 179134900,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16416768,
      "scriptDurationMs": 289.512,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17701.711000000047,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17060.611999999997,
      "heapDeltaBytes": -28815676,
      "heapUsedBytes": 183198192,
      "domNodes": -8072,
      "jsHeapTotalBytes": -13795328,
      "scriptDurationMs": 299.295,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21295.075999999994,
      "styleRecalcs": 162,
      "styleRecalcDurationMs": 19.97700000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21086.498,
      "heapDeltaBytes": -43199868,
      "heapUsedBytes": 185056648,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17252352,
      "scriptDurationMs": 920.4110000000001,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21466.377999999964,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 21.05800000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21212.51,
      "heapDeltaBytes": -32081136,
      "heapUsedBytes": 193640096,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20074496,
      "scriptDurationMs": 968.401,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 110,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6336.262000000033,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 86.07900000000002,
      "layouts": 20,
      "layoutDurationMs": 25.189000000000018,
      "taskDurationMs": 6247.596,
      "heapDeltaBytes": -43068280,
      "heapUsedBytes": 182861664,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11595776,
      "scriptDurationMs": 120.431,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 380,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4909.22999999998,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.10400000000001,
      "layouts": 20,
      "layoutDurationMs": 24.314000000000004,
      "taskDurationMs": 4815.567000000001,
      "heapDeltaBytes": -32842680,
      "heapUsedBytes": 188201692,
      "domNodes": -8068,
      "jsHeapTotalBytes": 19636224,
      "scriptDurationMs": 100.176,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 113,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8931.551000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8599.959,
      "heapDeltaBytes": 3067280,
      "heapUsedBytes": 179111672,
      "domNodes": 0,
      "jsHeapTotalBytes": -8912896,
      "scriptDurationMs": 140.59299999999996,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8762.591000000044,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8482.613000000001,
      "heapDeltaBytes": 16720564,
      "heapUsedBytes": 178424188,
      "domNodes": 0,
      "jsHeapTotalBytes": -12845056,
      "scriptDurationMs": 167.307,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 105.9759999999983,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 16.653000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.694,
      "taskDurationMs": 82.9,
      "heapDeltaBytes": 3068924,
      "heapUsedBytes": 71373940,
      "domNodes": 131,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.527000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 453.17399999999,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 24.06,
      "layouts": 4,
      "layoutDurationMs": 1.828,
      "taskDurationMs": 116.378,
      "heapDeltaBytes": 4761492,
      "heapUsedBytes": 73807604,
      "domNodes": 119,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.813,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50745 76021 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.56204% with 28 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ons/firstRunTour/tour/useFirstRunTourController.ts 68.91% 23 Missing ⚠️
...sions/firstRunTour/gettingStarted/firstRunEntry.ts 90.90% 5 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19353   +/-   ##
=============================================
  Coverage              ?   83.97%           
=============================================
  Files                 ?     2119           
  Lines                 ?   126653           
  Branches              ?    32095           
=============================================
  Hits                  ?   106355           
  Misses                ?    20120           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.77% <8.00%> (?)
unit 79.11% <83.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extensions/core/agentPanel.ts 97.16% <100.00%> (ø)
...rstRunTour/gettingStarted/GettingStartedScreen.vue 81.01% <100.00%> (ø)
...sions/firstRunTour/gettingStarted/firstRunEntry.ts 95.45% <90.90%> (ø)
...ons/firstRunTour/tour/useFirstRunTourController.ts 87.00% <68.91%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 302c8cb into cloud/1.54 Sep 29, 2026
96 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18966-to-cloud-1.54 branch September 29, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants