Repository navigation
[backport cloud/1.54] fix(agent): defer the consent offer past the first-run screen instead of dropping it - #19353
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
… of dropping it (#18966) Defers the automatic Agent consent offer while Getting Started owns the screen, then re-offers it in the same session after that ownership ends. The template path keeps first-run ownership across the dismissal-to-tour preview gap, so the consent card cannot open underneath the tour. The first-session entry-button/feature-flag timing question is separate and is not changed here. - Arms the consent retry for `first_run_screen` instead of dropping that offer. - Uses live first-run screen ownership, including pending screen-to-tour handoffs, when deciding whether consent can be shown. - Cancels and releases an in-flight handoff when the authenticated identity changes, preventing the previous account tour or hold from crossing sessions. - Removes the obsolete `firstRunTookScreen` latch. - Keeps failed template loads on Getting Started and removes duplicate no-tour coverage. - `dismissIntoFirstRunTour` snapshots the owner, passes an identity-change cancellation predicate to `beginTour`, and invalidates pending holds at the auth boundary. - Per-call symbols keep concurrent handoff ownership distinct, while `authGeneration` separately invalidates stale continuations across authenticated-session changes. - Bare dismissal releases consent; template selection retains ownership until the tour has either started, declined, or failed. At current head `e93ee8410e`, rebased directly on `main` at `4ff3690047` (eleven-file base-to-head diff): - `pnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts --testTimeout=30000` — 4 files, 226 tests passed. - `bash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer until Getting Started releases the screen' --workers=1 --repeat-each=5` — 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution Vite process; the scenario-only 90-second budget covers both application boots. - ESLint, Oxlint, oxfmt, `git diff --check`, pre-push Knip, and changed-line Fallow passed. Fallow excluded 17 inherited dependency findings and reported two inherited styling advisories. The branch retains the test-only changes from #18977 and #18989. Those PRs were merged into this PR's branch (their GitHub base was `fix/agent-consent-defer-first-run-screen`), not into `main`; dropping them during reconciliation would lose their approved coverage. The rebase preserves the eleven-file product/browser patch while removing the stale `main` ancestry. --------- Co-authored-by: Amp <amp@ampcode.com>
46a949c to
0105ae8
Compare
🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T05:13:13.190Z",
"gitSha": "dd9b625a8f6f636c8e800ea92137ea5681be528c",
"branch": "backport-18966-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2085.9229999999798,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.596,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.892,
"heapDeltaBytes": 2812760,
"heapUsedBytes": 73750024,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.329999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2035.2039999999647,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.088000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.0369999999999,
"heapDeltaBytes": 1761192,
"heapUsedBytes": 71410232,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.629,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2102.028999999959,
"styleRecalcs": 81,
"styleRecalcDurationMs": 38.483000000000004,
"layouts": 14,
"layoutDurationMs": 4.324000000000001,
"taskDurationMs": 1095.744,
"heapDeltaBytes": 11327296,
"heapUsedBytes": 82537904,
"domNodes": -286,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 188.45999999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1882.5300000000311,
"styleRecalcs": 76,
"styleRecalcDurationMs": 32.09,
"layouts": 14,
"layoutDurationMs": 4.06,
"taskDurationMs": 944.428,
"heapDeltaBytes": -3128476,
"heapUsedBytes": 67248964,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 168.12199999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1750.564000000054,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.995,
"layouts": 6,
"layoutDurationMs": 1.261,
"taskDurationMs": 417.80300000000005,
"heapDeltaBytes": 4548212,
"heapUsedBytes": 75631532,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.779,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.6260000000302,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.739,
"layouts": 6,
"layoutDurationMs": 0.9740000000000001,
"taskDurationMs": 422.178,
"heapDeltaBytes": 4301940,
"heapUsedBytes": 74518988,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.410000000000004,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 725.8209999999963,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.522999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.791,
"heapDeltaBytes": 18388412,
"heapUsedBytes": 88648548,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.26,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 684.2739999999594,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.93,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.52,
"heapDeltaBytes": -7589836,
"heapUsedBytes": 63434324,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 165.282,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.760999999979,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.9819999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 715.982,
"heapDeltaBytes": -2006908,
"heapUsedBytes": 74952636,
"domNodes": -285,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 36.041000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2052.7059999999437,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.093,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 666.1590000000001,
"heapDeltaBytes": 11051280,
"heapUsedBytes": 87539124,
"domNodes": -271,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 36.163000000000004,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2642.1339999999987,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.604999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1807.867,
"heapDeltaBytes": 11907468,
"heapUsedBytes": 89430604,
"domNodes": -273,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 867.2379999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2703.0710000000227,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.121000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1787.4769999999999,
"heapDeltaBytes": 24784108,
"heapUsedBytes": 90863260,
"domNodes": -277,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 895.644,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3850.7549999999924,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.457,
"layouts": 60,
"layoutDurationMs": 12.421999999999999,
"taskDurationMs": 1913.271,
"heapDeltaBytes": -2917788,
"heapUsedBytes": 76136136,
"domNodes": -283,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 832.2080000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3643.1910000000016,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.116,
"layouts": 60,
"layoutDurationMs": 12.184000000000001,
"taskDurationMs": 1788.2959999999998,
"heapDeltaBytes": 8022852,
"heapUsedBytes": 76165288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.815,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3180.7039999999915,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.727999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2101.9480000000003,
"heapDeltaBytes": 10305544,
"heapUsedBytes": 91954756,
"domNodes": -283,
"jsHeapTotalBytes": -733184,
"scriptDurationMs": 1006.0880000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3203.4340000000157,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.316000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2043.7050000000002,
"heapDeltaBytes": 907156,
"heapUsedBytes": 68612656,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1016.8770000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.6530000000294,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.3209999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.3690000000001,
"heapDeltaBytes": 9705892,
"heapUsedBytes": 88043820,
"domNodes": -276,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 37.586999999999996,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2064.236000000051,
"styleRecalcs": 5,
"styleRecalcDurationMs": 10.586000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.184,
"heapDeltaBytes": 8045992,
"heapUsedBytes": 86489916,
"domNodes": -275,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 41.400000000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 676.890999999955,
"styleRecalcs": 48,
"styleRecalcDurationMs": 14.016999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.464,
"heapDeltaBytes": 15253460,
"heapUsedBytes": 88359148,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 152.79,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.7049999999062,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.395000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.333,
"heapDeltaBytes": 15195976,
"heapUsedBytes": 88465724,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.483,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.6289999999867,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.485000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.237,
"heapDeltaBytes": -8010288,
"heapUsedBytes": 64653072,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.925000000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2036.750999999981,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.901,
"heapDeltaBytes": -7484664,
"heapUsedBytes": 65191460,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 11.861999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.4970000000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.674,
"layouts": 18,
"layoutDurationMs": 5.055,
"taskDurationMs": 871.6630000000001,
"heapDeltaBytes": 9640804,
"heapUsedBytes": 83044924,
"domNodes": -299,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 117.68400000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.4889999999268,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.03,
"layouts": 18,
"layoutDurationMs": 5.394,
"taskDurationMs": 902.7620000000001,
"heapDeltaBytes": 9458728,
"heapUsedBytes": 82858912,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 123.759,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.3960000000102,
"styleRecalcs": 19,
"styleRecalcDurationMs": 34.385,
"layouts": 15,
"layoutDurationMs": 16.864,
"taskDurationMs": 1028.7050000000002,
"heapDeltaBytes": -5113468,
"heapUsedBytes": 85196880,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 34.278000000000006,
"eventListeners": 2385,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9176.430999999979,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.443,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6269.403,
"heapDeltaBytes": 1722056,
"heapUsedBytes": 77727216,
"domNodes": -282,
"jsHeapTotalBytes": 90112,
"scriptDurationMs": 2847.5650000000005,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9608.224999999948,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6450.54,
"heapDeltaBytes": 16863976,
"heapUsedBytes": 93844104,
"domNodes": -270,
"jsHeapTotalBytes": 1400832,
"scriptDurationMs": 2961.897,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17667.253000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16948.557,
"heapDeltaBytes": -59395848,
"heapUsedBytes": 179134900,
"domNodes": -8068,
"jsHeapTotalBytes": -16416768,
"scriptDurationMs": 289.512,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17701.711000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17060.611999999997,
"heapDeltaBytes": -28815676,
"heapUsedBytes": 183198192,
"domNodes": -8072,
"jsHeapTotalBytes": -13795328,
"scriptDurationMs": 299.295,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21295.075999999994,
"styleRecalcs": 162,
"styleRecalcDurationMs": 19.97700000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21086.498,
"heapDeltaBytes": -43199868,
"heapUsedBytes": 185056648,
"domNodes": -8068,
"jsHeapTotalBytes": -17252352,
"scriptDurationMs": 920.4110000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21466.377999999964,
"styleRecalcs": 165,
"styleRecalcDurationMs": 21.05800000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21212.51,
"heapDeltaBytes": -32081136,
"heapUsedBytes": 193640096,
"domNodes": -8068,
"jsHeapTotalBytes": -20074496,
"scriptDurationMs": 968.401,
"eventListeners": -14925,
"totalBlockingTimeMs": 110,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6336.262000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.07900000000002,
"layouts": 20,
"layoutDurationMs": 25.189000000000018,
"taskDurationMs": 6247.596,
"heapDeltaBytes": -43068280,
"heapUsedBytes": 182861664,
"domNodes": -8068,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 120.431,
"eventListeners": -14929,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4909.22999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.10400000000001,
"layouts": 20,
"layoutDurationMs": 24.314000000000004,
"taskDurationMs": 4815.567000000001,
"heapDeltaBytes": -32842680,
"heapUsedBytes": 188201692,
"domNodes": -8068,
"jsHeapTotalBytes": 19636224,
"scriptDurationMs": 100.176,
"eventListeners": -14933,
"totalBlockingTimeMs": 113,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8931.551000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8599.959,
"heapDeltaBytes": 3067280,
"heapUsedBytes": 179111672,
"domNodes": 0,
"jsHeapTotalBytes": -8912896,
"scriptDurationMs": 140.59299999999996,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8762.591000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8482.613000000001,
"heapDeltaBytes": 16720564,
"heapUsedBytes": 178424188,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 167.307,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 105.9759999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.653000000000002,
"layouts": 3,
"layoutDurationMs": 1.694,
"taskDurationMs": 82.9,
"heapDeltaBytes": 3068924,
"heapUsedBytes": 71373940,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.527000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 453.17399999999,
"styleRecalcs": 15,
"styleRecalcDurationMs": 24.06,
"layouts": 4,
"layoutDurationMs": 1.828,
"taskDurationMs": 116.378,
"heapDeltaBytes": 4761492,
"heapUsedBytes": 73807604,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.813,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19353 +/- ##
=============================================
Coverage ? 83.97%
=============================================
Files ? 2119
Lines ? 126653
Branches ? 32095
=============================================
Hits ? 106355
Misses ? 20120
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #18966.
Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included.
Validation: focused unit suite (199/199); application and browser typechecks; staged lint/format checks.