Repository navigation
[backport core/1.54] fix(agent): defer the consent offer past the first-run screen instead of dropping it - #19351
Conversation
… of dropping it (#18966) Defers the automatic Agent consent offer while Getting Started owns the screen, then re-offers it in the same session after that ownership ends. The template path keeps first-run ownership across the dismissal-to-tour preview gap, so the consent card cannot open underneath the tour. The first-session entry-button/feature-flag timing question is separate and is not changed here. - Arms the consent retry for `first_run_screen` instead of dropping that offer. - Uses live first-run screen ownership, including pending screen-to-tour handoffs, when deciding whether consent can be shown. - Cancels and releases an in-flight handoff when the authenticated identity changes, preventing the previous account tour or hold from crossing sessions. - Removes the obsolete `firstRunTookScreen` latch. - Keeps failed template loads on Getting Started and removes duplicate no-tour coverage. - `dismissIntoFirstRunTour` snapshots the owner, passes an identity-change cancellation predicate to `beginTour`, and invalidates pending holds at the auth boundary. - Per-call symbols keep concurrent handoff ownership distinct, while `authGeneration` separately invalidates stale continuations across authenticated-session changes. - Bare dismissal releases consent; template selection retains ownership until the tour has either started, declined, or failed. At current head `e93ee8410e`, rebased directly on `main` at `4ff3690047` (eleven-file base-to-head diff): - `pnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/GettingStartedScreen.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/renderer/extensions/firstRunTour/tour/useFirstRunTourController.test.ts --testTimeout=30000` — 4 files, 226 tests passed. - `bash scripts/test-browser-offline.sh --project=cloud browser_tests/tests/agent/agentConsent.spec.ts -g 'defers the offer until Getting Started releases the screen' --workers=1 --repeat-each=5` — 5/5 passed in 43.2 seconds from a freshly restarted cloud-distribution Vite process; the scenario-only 90-second budget covers both application boots. - ESLint, Oxlint, oxfmt, `git diff --check`, pre-push Knip, and changed-line Fallow passed. Fallow excluded 17 inherited dependency findings and reported two inherited styling advisories. The branch retains the test-only changes from #18977 and #18989. Those PRs were merged into this PR's branch (their GitHub base was `fix/agent-consent-defer-first-run-screen`), not into `main`; dropping them during reconciliation would lose their approved coverage. The rebase preserves the eleven-file product/browser patch while removing the stale `main` ancestry. --------- Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1959 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T07:51:14.997Z",
"gitSha": "f564173f12fe63332df7c1e8f9feda11643592e9",
"branch": "backport-18966-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2046.9819999999572,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.362999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.4699999999999,
"heapDeltaBytes": 3094308,
"heapUsedBytes": 73548132,
"domNodes": -276,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 9.206000000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2017.6369999999224,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.768,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.84299999999996,
"heapDeltaBytes": -7277352,
"heapUsedBytes": 63046264,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.276000000000002,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1989.4130000000132,
"styleRecalcs": 76,
"styleRecalcDurationMs": 24.596000000000004,
"layouts": 14,
"layoutDurationMs": 3.9690000000000003,
"taskDurationMs": 953.857,
"heapDeltaBytes": -11249272,
"heapUsedBytes": 59822600,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 112.21199999999999,
"eventListeners": -166,
"totalBlockingTimeMs": 212,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1715.5119999999897,
"styleRecalcs": 73,
"styleRecalcDurationMs": 20.958000000000002,
"layouts": 14,
"layoutDurationMs": 3.8059999999999996,
"taskDurationMs": 670.119,
"heapDeltaBytes": -4050328,
"heapUsedBytes": 60198428,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 112.36699999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.050000000003,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.158000000000001,
"layouts": 6,
"layoutDurationMs": 1.1949999999999998,
"taskDurationMs": 287.819,
"heapDeltaBytes": 4205884,
"heapUsedBytes": 75030096,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.328,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.4019999999482,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.11,
"layouts": 6,
"layoutDurationMs": 0.9960000000000001,
"taskDurationMs": 277.584,
"heapDeltaBytes": 4739232,
"heapUsedBytes": 75530688,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.176,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 586.6669999999772,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.361999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.267,
"heapDeltaBytes": 18363080,
"heapUsedBytes": 88509068,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 127.75200000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 559.0849999999818,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.695000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.909,
"heapDeltaBytes": -7806368,
"heapUsedBytes": 62834340,
"domNodes": 22,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 123.725,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2026.7369999999687,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.529999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.81199999999995,
"heapDeltaBytes": 6409244,
"heapUsedBytes": 82258260,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 27.962000000000007,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.1919999999946,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.695999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.82899999999995,
"heapDeltaBytes": 10825636,
"heapUsedBytes": 87173676,
"domNodes": -266,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 26.916000000000004,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2172.9009999999676,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.097,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1291.794,
"heapDeltaBytes": 2514984,
"heapUsedBytes": 79834172,
"domNodes": -272,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 585.689,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.3259999999445,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1270.6499999999999,
"heapDeltaBytes": -10187400,
"heapUsedBytes": 67090688,
"domNodes": -285,
"jsHeapTotalBytes": 1208320,
"scriptDurationMs": 587.5079999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3193.4350000000222,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.959999999999999,
"layouts": 60,
"layoutDurationMs": 13.723,
"taskDurationMs": 1433.135,
"heapDeltaBytes": -4781992,
"heapUsedBytes": 74246564,
"domNodes": -288,
"jsHeapTotalBytes": 2781184,
"scriptDurationMs": 584.017,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3218.977999999993,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.199999999999998,
"layouts": 60,
"layoutDurationMs": 14.159999999999998,
"taskDurationMs": 1442.291,
"heapDeltaBytes": -4330256,
"heapUsedBytes": 74629336,
"domNodes": -292,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 589.678,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2169.374000000005,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.983000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1437.573,
"heapDeltaBytes": 14157756,
"heapUsedBytes": 81849200,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 671.19,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2195.5899999999247,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.403,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1480.829,
"heapDeltaBytes": -8051304,
"heapUsedBytes": 72356524,
"domNodes": -254,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 680.338,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2018.177000000037,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.524000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.29999999999995,
"heapDeltaBytes": 5900692,
"heapUsedBytes": 83139372,
"domNodes": -276,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 28.134,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.449999999978,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.348000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.6489999999999,
"heapDeltaBytes": 10188204,
"heapUsedBytes": 87830716,
"domNodes": -270,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 33.659,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.0739999999942,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.48,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.39699999999993,
"heapDeltaBytes": 14565352,
"heapUsedBytes": 86859324,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 108.715,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.7720000000136,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.727999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.58299999999997,
"heapDeltaBytes": 13915628,
"heapUsedBytes": 86774452,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 110.80100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2002.6149999999916,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.302999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.2560000000001,
"heapDeltaBytes": -7768684,
"heapUsedBytes": 65700400,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.752999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1990.8609999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.355000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.11100000000005,
"heapDeltaBytes": 8674492,
"heapUsedBytes": 81297340,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.999999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.0399999999922,
"styleRecalcs": 78,
"styleRecalcDurationMs": 24.077,
"layouts": 18,
"layoutDurationMs": 5.1419999999999995,
"taskDurationMs": 691.0219999999999,
"heapDeltaBytes": -9953108,
"heapUsedBytes": 62323552,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 89.206,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.4619999999486,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.323,
"layouts": 18,
"layoutDurationMs": 3.7929999999999997,
"taskDurationMs": 641.7570000000001,
"heapDeltaBytes": -5210316,
"heapUsedBytes": 60995660,
"domNodes": -296,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 80.025,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.6659999999524,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.889999999999993,
"layouts": 15,
"layoutDurationMs": 9.985000000000001,
"taskDurationMs": 651.88,
"heapDeltaBytes": 22044292,
"heapUsedBytes": 106104876,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.246000000000002,
"eventListeners": 2385,
"totalBlockingTimeMs": 94,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8140.331000000004,
"styleRecalcs": 247,
"styleRecalcDurationMs": 41.163,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4466.86,
"heapDeltaBytes": 12786224,
"heapUsedBytes": 89347480,
"domNodes": -275,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 1977.9329999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8132.8150000000505,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4365.3550000000005,
"heapDeltaBytes": 8219528,
"heapUsedBytes": 84878752,
"domNodes": -271,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 1942.115,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12790.69400000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12134.275,
"heapDeltaBytes": -38684292,
"heapUsedBytes": 180257676,
"domNodes": -8068,
"jsHeapTotalBytes": -17309696,
"scriptDurationMs": 200.20399999999998,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12877.354999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12292.883,
"heapDeltaBytes": -34389008,
"heapUsedBytes": 177311000,
"domNodes": -8068,
"jsHeapTotalBytes": -19886080,
"scriptDurationMs": 226.08,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14577.440999999964,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.238000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14084.016,
"heapDeltaBytes": -46720808,
"heapUsedBytes": 186031252,
"domNodes": -8068,
"jsHeapTotalBytes": -20430848,
"scriptDurationMs": 725.143,
"eventListeners": -14933,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15064.64900000003,
"styleRecalcs": 73,
"styleRecalcDurationMs": 20.605999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14604.682999999997,
"heapDeltaBytes": -41124548,
"heapUsedBytes": 179786072,
"domNodes": -8068,
"jsHeapTotalBytes": -17481728,
"scriptDurationMs": 810.837,
"eventListeners": -14931,
"totalBlockingTimeMs": 66,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4535.431999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.59900000000001,
"layouts": 20,
"layoutDurationMs": 25.00100000000001,
"taskDurationMs": 4425.342,
"heapDeltaBytes": -41570672,
"heapUsedBytes": 182734604,
"domNodes": -8068,
"jsHeapTotalBytes": 13361152,
"scriptDurationMs": 80.578,
"eventListeners": -14929,
"totalBlockingTimeMs": 133,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4357.68900000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.806999999999995,
"layouts": 20,
"layoutDurationMs": 23.034,
"taskDurationMs": 4212.538000000001,
"heapDeltaBytes": -41066552,
"heapUsedBytes": 177513180,
"domNodes": -8068,
"jsHeapTotalBytes": 18878464,
"scriptDurationMs": 75.18199999999999,
"eventListeners": -14935,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6318.022000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5925.3060000000005,
"heapDeltaBytes": 32965716,
"heapUsedBytes": 198267292,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 92.82799999999996,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6345.5940000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6055.624999999999,
"heapDeltaBytes": 29503904,
"heapUsedBytes": 192438084,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 97.864,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 441.675000000032,
"styleRecalcs": 18,
"styleRecalcDurationMs": 18.341000000000005,
"layouts": 4,
"layoutDurationMs": 1.9180000000000001,
"taskDurationMs": 95.59600000000002,
"heapDeltaBytes": 4976044,
"heapUsedBytes": 73131536,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.993,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 85.86300000001756,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.987,
"layouts": 2,
"layoutDurationMs": 1.0540000000000003,
"taskDurationMs": 47.60199999999999,
"heapDeltaBytes": 2982480,
"heapUsedBytes": 71813224,
"domNodes": 122,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 3.1589999999999985,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19351 +/- ##
=============================================
+ Coverage 83.84% 83.87% +0.03%
=============================================
Files 2109 2109
Lines 125512 125661 +149
Branches 31799 33732 +1933
=============================================
+ Hits 105230 105404 +174
+ Misses 20103 20078 -25
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #18966.
Conflict resolution preserves the release branch package/version state and adapts only the first-run ownership handoff needed by this fix. No feature flags, exposure, or configuration changes are included.
Validation: focused unit suite (199/199); application and browser typechecks; staged lint/format checks.