Repository navigation
chore(agent): remove the dead firstRunTookScreen latch - #18998
christian-byrne wants to merge 3 commits into
Conversation
… of dropping it The automatic "Meet Comfy Agent" card is withheld while a blocking surface is up and re-offered when that surface closes. `first_run_screen` was the one reason excluded from that release path, so for users who met the agent during first run the offer was dropped rather than deferred. Two things made it terminal for the rest of the page's life: - `holdOffer` armed the `offerHeld` retry latch for every reason except `first_run_screen`, so the release watcher could never fire for it. - `screenHolder` read `firstRunTookScreen`, which is a latch cleared only by a change of user - `dismissGettingStarted` hides the screen without clearing it. Even with the latch armed, the retry would have re-held every time. `screenHolder` now reads `gettingStartedVisible`, the ref that actually renders the screen and clears on dismissal, and `screenIsClear` is the negation of `screenHolder` rather than of `screenBusyReason` so that hold and release agree on what "the screen" means. Without that second change, releasing a first-run hold would re-hold on the same tick. The template/share-link path previously reported `first_run_screen` via `firstRunTookScreen`; it sets that only once `beginTour` has started the first-run tour, so it is now reported as `tour_active`, which is both more accurate and already had a working release path. Expect a small shift in `app:agent_consent_not_offered` volume between those two reasons. Consent semantics are unchanged: the card asks the same thing, records the same thing, and is still required before the panel opens. Only the moment it is offered changes. `firstRunTookScreen` now has no production consumer. Left in place here to keep this diff to the behaviour change; it can be removed separately.
… to the tour The release path added in the previous commit opens one window it should not. On the template path `GettingStartedScreen` dismissed the screen and then called `beginTour`, which registers the tour, shows the chosen workflow undimmed for `INTRO_PREVIEW_MS` (500 ms), and only then starts it. `onboardingTourStore.activeTour` stays `null` until the start, so for those 500 ms `gettingStartedVisible` was already `false` and no tour was active: `screenHolder` returned `null`, `screenIsClear` was true, and the armed `offerHeld` released the card into the intro preview, immediately before the coachmark tour opened over it. That is the case the first-run hold was built for in #18431 — the card must not land on the tour over a hidden canvas. The fix is not a longer wait but a signal for the thing actually being asked about. `useFirstRunEntry` now exposes `firstRunHoldsScreen`: whether the first run still owns the screen, which is a different question from whether the screen is rendered. The dismissal and the tour it hands over to move behind one call, `dismissIntoFirstRunTour`, so the gap between them cannot be observed as a free screen; `firstRunHoldsScreen` stays true for exactly as long as that handoff is in flight, and once the tour is up `screenBusyReason`'s `tour_active` branch takes over. The handoff count is decremented in a `finally`, so a tour that declines to open or throws releases the screen rather than leaving a latch behind - which was the failure mode of `firstRunTookScreen`. This corrects one claim in the previous commit message: the `template_selected` path is **not** reported as `tour_active`. It is reported as `first_run_screen` while the screen and its handoff hold, and only a tour that is genuinely up reports `tour_active`. `app:agent_consent_not_offered` volume therefore stays on `first_run_screen` for that path. The test named for this behaviour did not pin it. `keeps waiting when Getting Started closes straight into the first-run tour` set `activeTour` on the line *before* clearing `gettingStartedVisible`, so the tour was already active at the instant of dismissal and the tour alone held the offer. Production dismisses first and starts the tour 500 ms later. It now runs in the production order and fails without the guard above. What the handoff does across the intro preview is pinned in `firstRunEntry.test.ts`; that the preview exists at all, and that no tour is active until it is over, was already pinned by `useFirstRunTourController.test.ts`. The `url-intent` path calls `beginTour` directly and is deliberately left alone: the screen is never shown there, its offer waits on `whenStartupDecided`, which only resolves after `beginTour` settles, and routing it through this handoff would report `first_run_screen` for users who never saw the screen.
`firstRunTookScreen` has had no production reader since the consent guard moved to `firstRunHoldsScreen`. What is left is a session-sticky latch that still reads like a live signal - and reading it as one is exactly the bug #18966's first commit fixed: it is only ever cleared by a change of user, so a guard built on it reports `first_run_screen` for the rest of the page's life and the hold can never release. Verified dead at this base (0e72565) rather than assumed: the only four production callers of `useFirstRunEntry` destructure `handleStartupOutcome`/ `handleUrlWorkflow` (GraphCanvas.vue), `firstRunHoldsScreen`/ `whenStartupDecided` (agentPanel.ts), `gettingStartedVisible` (FirstRunTour.vue) and `dismissGettingStarted`/`dismissIntoFirstRunTour` (GettingStartedScreen.vue). None reads the latch, and nothing accesses the composable's result dynamically. Removed: the declaration, the reset on user change, both writers (`showFirstRunScreen`, `handleUrlWorkflow`) and the export. The six test blocks that asserted on it went two ways. Four were testing real behaviour through the latch and now assert it through `firstRunHoldsScreen`, the signal the consent guard actually reads: - "records that Getting Started took the screen" -> "holds the screen once Getting Started is up" - "records that a url-intent tour took the screen" -> "holds nothing for a url-intent tour, which never took the screen". The polarity flips because the latch and the hold disagree here, and the hold is right: that path never renders the screen, so a first-run hold would withhold the consent offer from users who never saw one. This pins a behaviour that was previously unpinned. - "reports no first-run screen for $label" (3 cases) -> same assertion on the hold - "hides an active replay when the account changes" -> adds the hold alongside the existing `gettingStartedVisible` assertion Two were incidental: "stays undecided while a url-intent tour is still starting" and "settles the startup decision even when the tour fails to start" are about `whenStartupDecided`, and their latch lines pinned nothing their names claim. Those lines are dropped; both tests keep their subject. All four rewritten assertions were mutation-checked rather than assumed meaningful - dropping `gettingStartedVisible` from `firstRunHoldsScreen`, leaking a hold on the url-intent path, and removing the account-change reset each fail exactly the intended assertions. Suite: 1705 files, 24,303 passed, 32 expected-fail, 7 skipped at --testTimeout=30000. vue-tsc, eslint, oxlint --type-aware and oxfmt clean.
🎭 Playwright: ✅ 2126 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0e72565c8b0bbe18a7b73f99d97b3b07727f969c
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-26T12:44:39.630Z",
"gitSha": "843039d1f868bac0cd5b9e1313aee0e3ef4776ed",
"branch": "chore/gc-18-remove-dead-first-run-latch",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.1580000000413,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5919999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.34,
"heapDeltaBytes": -1782684,
"heapUsedBytes": 60717328,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.057000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.208000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.947,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 282.40700000000004,
"heapDeltaBytes": 25147736,
"heapUsedBytes": 87328060,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.443,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.157999999998,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.113000000000001,
"layouts": 12,
"layoutDurationMs": 3.798,
"taskDurationMs": 718.4569999999999,
"heapDeltaBytes": -3169352,
"heapUsedBytes": 59235184,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 133.602,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1714.5899999999301,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.794000000000002,
"layouts": 12,
"layoutDurationMs": 4.1049999999999995,
"taskDurationMs": 714.881,
"heapDeltaBytes": -6505160,
"heapUsedBytes": 56065928,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 129.136,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.7639999999874,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.405,
"layouts": 6,
"layoutDurationMs": 1.4989999999999999,
"taskDurationMs": 241.50900000000001,
"heapDeltaBytes": 2547352,
"heapUsedBytes": 70082068,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.085,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.6280000000152,
"styleRecalcs": 33,
"styleRecalcDurationMs": 9.347000000000001,
"layouts": 6,
"layoutDurationMs": 1.36,
"taskDurationMs": 298.134,
"heapDeltaBytes": 2633708,
"heapUsedBytes": 70195584,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.822,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 609.7369999999955,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9760000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.79999999999995,
"heapDeltaBytes": 18526084,
"heapUsedBytes": 81023388,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.77,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 620.9780000000364,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.5589999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.90799999999996,
"heapDeltaBytes": 19030772,
"heapUsedBytes": 86353460,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 151.21699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1067.483999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.4300000000001,
"heapDeltaBytes": 34494768,
"heapUsedBytes": 106169496,
"domNodes": 0,
"jsHeapTotalBytes": 20869120,
"scriptDurationMs": 52.88500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 472,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.3580000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 836.3369999999999,
"heapDeltaBytes": -17516632,
"heapUsedBytes": 72699972,
"domNodes": -259,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 62.42600000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 543,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 763.0650000000401,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.07299999999987,
"heapDeltaBytes": 15739664,
"heapUsedBytes": 92118600,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.27100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 762.5009999999293,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.3949999999999,
"heapDeltaBytes": 15807312,
"heapUsedBytes": 91717228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.644,
"eventListeners": 0,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7780.143000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7049.768999999999,
"heapDeltaBytes": -13553544,
"heapUsedBytes": 70508716,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 5726.93,
"eventListeners": 0,
"totalBlockingTimeMs": 141,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8521.742000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7675.130999999999,
"heapDeltaBytes": -6976176,
"heapUsedBytes": 75444788,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 6098.865,
"eventListeners": 0,
"totalBlockingTimeMs": 72,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7734.2310000000225,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3230000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6900.047,
"heapDeltaBytes": 13757636,
"heapUsedBytes": 90620684,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5427.875,
"eventListeners": -164,
"totalBlockingTimeMs": 139,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7259.496000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6562.361,
"heapDeltaBytes": 15475812,
"heapUsedBytes": 90381488,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 5111.6900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 8,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2056.1460000000125,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1000000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.1639999999999,
"heapDeltaBytes": 282348,
"heapUsedBytes": 81496296,
"domNodes": -228,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.013,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.9319999999843,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9289999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.47,
"heapDeltaBytes": -993896,
"heapUsedBytes": 80217452,
"domNodes": -228,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 32.065000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2172.4720000000275,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.897,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1445.9050000000002,
"heapDeltaBytes": -14340936,
"heapUsedBytes": 68102940,
"domNodes": -198,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 734.6080000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2225.0159999999823,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.232000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1490.755,
"heapDeltaBytes": -16491604,
"heapUsedBytes": 65488812,
"domNodes": -228,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 728.477,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3542.8810000000226,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.165999999999999,
"layouts": 60,
"layoutDurationMs": 15.536000000000001,
"taskDurationMs": 1544.956,
"heapDeltaBytes": 10950868,
"heapUsedBytes": 94743036,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 690.858,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3611.282000000074,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.094999999999999,
"layouts": 60,
"layoutDurationMs": 14.548,
"taskDurationMs": 1611.565,
"heapDeltaBytes": -14169988,
"heapUsedBytes": 69581872,
"domNodes": -228,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 681.6880000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3009.796999999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.401000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1742.312,
"heapDeltaBytes": -1879076,
"heapUsedBytes": 83195292,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 861.793,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2959.278999999924,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.808,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1716.453,
"heapDeltaBytes": -6419216,
"heapUsedBytes": 78906344,
"domNodes": 0,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 838.249,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.925999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5200000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.9670000000001,
"heapDeltaBytes": -6649644,
"heapUsedBytes": 74890024,
"domNodes": -228,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 32.342,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.737000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3099999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.1949999999999,
"heapDeltaBytes": -4662824,
"heapUsedBytes": 83938340,
"domNodes": -228,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.917,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.2019999999943,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.196999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.18300000000005,
"heapDeltaBytes": 13582880,
"heapUsedBytes": 77207352,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 127.06200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.4749999999676,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.092,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.61699999999996,
"heapDeltaBytes": 13510724,
"heapUsedBytes": 77150280,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 123.54599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1989.4950000000335,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.555,
"heapDeltaBytes": -4856920,
"heapUsedBytes": 58135852,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.565000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.221999999946,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.3859999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.087,
"heapDeltaBytes": -5018288,
"heapUsedBytes": 58709956,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.092000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.5910000000408,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.478,
"layouts": 16,
"layoutDurationMs": 4.478000000000001,
"taskDurationMs": 682.849,
"heapDeltaBytes": -4738112,
"heapUsedBytes": 59248016,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 84.30399999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.8359999999902,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.518,
"layouts": 16,
"layoutDurationMs": 4.981,
"taskDurationMs": 678.319,
"heapDeltaBytes": 664696,
"heapUsedBytes": 64444768,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 86.95,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.7659999999914,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.066999999999997,
"layouts": 5,
"layoutDurationMs": 9.541,
"taskDurationMs": 767.1099999999998,
"heapDeltaBytes": 19521612,
"heapUsedBytes": 98085380,
"domNodes": 13667,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 23.226000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 127,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8192.530000000033,
"styleRecalcs": 248,
"styleRecalcDurationMs": 30.973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4964.045999999999,
"heapDeltaBytes": 3399540,
"heapUsedBytes": 84674508,
"domNodes": -228,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2283.1430000000005,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8310.519999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.85000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5100.962,
"heapDeltaBytes": 511476,
"heapUsedBytes": 82014472,
"domNodes": -228,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 2339.536,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14073.775000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13101.628,
"heapDeltaBytes": -35571692,
"heapUsedBytes": 189564152,
"domNodes": -8049,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 208.865,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14316.90500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13833.386,
"heapDeltaBytes": -41137932,
"heapUsedBytes": 183885388,
"domNodes": -8049,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 243.89299999999997,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16663.618000000042,
"styleRecalcs": 120,
"styleRecalcDurationMs": 15.815999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16249.071,
"heapDeltaBytes": -72294352,
"heapUsedBytes": 167869384,
"domNodes": -8049,
"jsHeapTotalBytes": -16371712,
"scriptDurationMs": 777.9050000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14262.425000000007,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.225000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13724.961,
"heapDeltaBytes": -33929100,
"heapUsedBytes": 191082124,
"domNodes": -8049,
"jsHeapTotalBytes": -16855040,
"scriptDurationMs": 784.634,
"eventListeners": -14923,
"totalBlockingTimeMs": 13,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4883.017999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.024,
"layouts": 20,
"layoutDurationMs": 22.972000000000005,
"taskDurationMs": 4778.141,
"heapDeltaBytes": -35898796,
"heapUsedBytes": 181662648,
"domNodes": -8049,
"jsHeapTotalBytes": 12124160,
"scriptDurationMs": 83.49800000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5013.811000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.161,
"layouts": 20,
"layoutDurationMs": 23.223999999999993,
"taskDurationMs": 4922.963,
"heapDeltaBytes": -49653364,
"heapUsedBytes": 175713896,
"domNodes": -8049,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 87.391,
"eventListeners": -14923,
"totalBlockingTimeMs": 161,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7155.823999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6633.607000000002,
"heapDeltaBytes": -27553548,
"heapUsedBytes": 169364424,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 109.81299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7195.11399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6849.258000000001,
"heapDeltaBytes": -13476412,
"heapUsedBytes": 182245544,
"domNodes": 0,
"jsHeapTotalBytes": -33030144,
"scriptDurationMs": 112.42599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 105.63400000000911,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.396,
"layouts": 3,
"layoutDurationMs": 1.438,
"taskDurationMs": 81.38400000000001,
"heapDeltaBytes": 3198440,
"heapUsedBytes": 65223068,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.587,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 97.362999999973,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.718,
"layouts": 3,
"layoutDurationMs": 1.65,
"taskDurationMs": 66.99,
"heapDeltaBytes": 2989836,
"heapUsedBytes": 65085968,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.663000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe first-run entry flow now tracks when the screen is held, including while Getting Started hands off to a tour. Getting Started starts template tours through that flow. The agent panel uses the hold state to defer automatic consent offers. ChangesFirst-run screen flow
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant GettingStartedScreen
participant useFirstRunEntry
participant beginTour
GettingStartedScreen->>useFirstRunEntry: dismissIntoFirstRunTour(templateId)
useFirstRunEntry->>useFirstRunEntry: dismiss Getting Started and record completion
useFirstRunEntry->>beginTour: start template tour
beginTour-->>useFirstRunEntry: tour result
useFirstRunEntry-->>GettingStartedScreen: resolve or propagate error
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The consent offer remains deferred while Getting Started hands off to a tour. No actionable merge-blocking risk is established beyond normal checks. 🚥 Pre-merge checks | ✅ 6 | ❓ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR includes bug-fix commit subjects ( ✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18998 +/- ##
==========================================
+ Coverage 84.01% 84.92% +0.90%
==========================================
Files 3157 2308 -849
Lines 154228 132876 -21352
Branches 39953 34001 -5952
==========================================
- Hits 129581 112847 -16734
+ Misses 23048 19717 -3331
+ Partials 1599 312 -1287
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 856 files with indirect coverage changes 🚀 New features to boost your workflow:
|
204483d to
977f9cb
Compare
There was a problem hiding this comment.
The deletion already landed: #18966's squash (faf9bb6c18) removed firstRunTookScreen, and git grep firstRunTookScreen origin/main -- src is empty. This branch still carries #18966's two pre-squash commits, so it conflicts on all six files, and the body's "base is fix/agent-consent-defer-first-run-screen" no longer matches (base is main).
The tests are still worth landing, though. On main, if firstRunHoldsScreen stops counting phase visible (Getting Started on screen), every test under firstRunTour, agentPanel and workbench/extensions/agent stays green: 149 files. That is the PM-1497 shape, the consent card opening on top of Getting Started. I ported your five firstRunHoldsScreen tests onto main's firstRunEntry.test.ts: they pass (76/76), and holds the screen once Getting Started is up fails on exactly that mutation.
| Check | Result |
|---|---|
| latch removal | already on main via #18966 |
| main guards Getting Started's hold | no, 149 files green under the mutation |
| your tests on main | pass, and catch it |
| mergeable | no, conflicts on 6 files |
Stacked on #18966. Base is
fix/agent-consent-defer-first-run-screen, notmain, deliberately — atmainthis deletion would be wrong, becauseagentPanel.ts:192still readsfirstRunTookScreenthere. #18966's second commit (0e72565c8b) is what moves the guard tofirstRunHoldsScreenand leaves the latch with no production reader. So this needs #18966 first; after that it is order-free against the rest of the open set (checked below).What it removes
firstRunTookScreeninfirstRunEntry.ts: the declaration, the reset on user change, both writers (showFirstRunScreen,handleUrlWorkflow) and the export.It is a session-sticky latch whose name describes a past event (
took) while every guard reading it needs a present one (holds). That mismatch is the bug #18966's first commit fixed — the latch is only ever cleared by a change of user, so a guard on it reportsfirst_run_screenfor the rest of the page's life and the hold can never release.firstRunHoldsScreenwas named for the difference. Leaving the dead one in place keeps the trap loaded for the next reader.Proof it is dead, at this base rather than by assertion
All four production callers of
useFirstRunEntry()at0e72565c8b, read rather than assumed:GraphCanvas.vue:589,612handleStartupOutcome,handleUrlWorkflowagentPanel.ts:171firstRunHoldsScreen,whenStartupDecidedFirstRunTour.vue:12gettingStartedVisibleGettingStartedScreen.vue:166dismissGettingStarted,dismissIntoFirstRunTourNone reads the latch; none spreads or dynamically indexes the composable's result. A whole-repo
git grep firstRunTookScreen 0e72565c8boutside tests returns onlyfirstRunEntry.ts's own five lines plus one prose mention inagentPanel.ts, which this PR rewrites into the past tense.The six test blocks
Four were testing real behaviour through the latch and now assert it through
firstRunHoldsScreen, which is the signal the consent guard actually reads:records that Getting Started took the screen→holds the screen once Getting Started is uprecords that a url-intent tour took the screen→holds nothing for a url-intent tour, which never took the screen. The polarity flips, because this is the one place the latch and the hold genuinely disagree and the hold is right: the share/template-link path never renders the screen (fix(agent): defer the consent offer past the first-run screen instead of dropping it #18966's own Decision 3 keeps it off the handoff on purpose), so reporting a first-run hold there would withhold the consent offer from users who never saw a screen. That behaviour was not pinned anywhere before this.reports no first-run screen for $label(3 cases) → same assertion, on the holdhides an active replay when the account changes→ adds the hold next to the existinggettingStartedVisibleassertionTwo were incidental.
stays undecided while a url-intent tour is still startingandsettles the startup decision even when the tour fails to startare aboutwhenStartupDecided; their latch lines pinned nothing either test's name claims, and both tests keep their subject and their other assertions. No test was deleted.Mutation-checked, not eyeballed
A rewritten assertion that cannot fail is worse than the dead latch. Each was checked against a plausible regression:
firstRunHoldsScreendropsgettingStartedVisibleholds the screen once Getting Started is up, and #18966's handoff testholds nothing for a url-intent tour,reports no first-run screen for 'a url-intent boot whose tour did not start'hides an active replay when the account changesreports no first-run screen for 'a boot that only deferred'+ 6 othersChecks
npx vitest run --testTimeout=30000— 1705 files, 24,303 passed, 32 expected-fail, 7 skipped, exit 0firstRunTour/,agentPanel.test.ts,GraphCanvas.test.ts,GraphView.test.ts) — 14 files, 373 passedvue-tsc --noEmit(needsNODE_OPTIONS=--max-old-space-size=8192on this host) — exit 0oxlint --type-aware,eslint,oxfmt --checkon the three changed files — clean. oxlint's silence was round-tripped against an injected violation, since a silent linter and a clean one look identical.Merge-order note for the rest of the stack
0e72565c8bis the only hard constraint. Of the other ten open PRs in this set, none touches afirstRunTookScreencode line — #18976, #18985 and #18991 do not mention it at all, and the+hits on #18977/#18989/#18975/#18978/#18992 are all inherited comment text. One thing to watch: #18975 adds a new comment namingfirstRunTookScreen(agentPanel.ts:199-202atc838834aae), so if it lands after this it reintroduces a reference to a symbol that no longer exists. #18975 already has to rebase in the recommended order; that comment should go with the rebase.Not merged —
AGENTS.mdreserves merge on this repo for the owning team.