Repository navigation
feat(cloud): dark theme, brand tokens and PP Formula pipeline - #14694
Conversation
Adds the brand colour tokens and the white-transparency steps the cloud auth surface needs, and ships PP Formula on the same cloud-only rails ABC ROM already used: faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS dist. Drops ABC ROM Extended and its .hero-title/.font-abcrom rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit.
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-14694.vercel.app This commit: https://website-frontend-193u9d7k2-comfyui.vercel.app Last updated: 2026-08-04T14:15:51Z for |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1784 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle: 8.25 MB gzip 🔴 +5 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed / 15 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 2 added / 2 removed / 279 unchanged ⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T14:33:51.023Z",
"gitSha": "13ae9975d972be42fc75d8f0adda696a2e21b609",
"branch": "feat/cloud-auth-shell",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.5629999999574,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.097999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.036,
"heapDeltaBytes": 5565548,
"heapUsedBytes": 69685132,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 14.253,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2034.0830000000096,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.644,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.72300000000007,
"heapDeltaBytes": -17915924,
"heapUsedBytes": 46146240,
"domNodes": -285,
"jsHeapTotalBytes": 22790144,
"scriptDurationMs": 14.069,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.7040000000516,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.369,
"layouts": 12,
"layoutDurationMs": 3.078,
"taskDurationMs": 873.586,
"heapDeltaBytes": -11886396,
"heapUsedBytes": 52242104,
"domNodes": -281,
"jsHeapTotalBytes": 23314432,
"scriptDurationMs": 103.99900000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1732.0130000000518,
"styleRecalcs": 72,
"styleRecalcDurationMs": 25.959999999999997,
"layouts": 12,
"layoutDurationMs": 2.523,
"taskDurationMs": 707.091,
"heapDeltaBytes": -14932904,
"heapUsedBytes": 48995196,
"domNodes": -278,
"jsHeapTotalBytes": 24363008,
"scriptDurationMs": 86.331,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.3980000000038,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.31,
"layouts": 6,
"layoutDurationMs": 0.6900000000000001,
"taskDurationMs": 348.67499999999995,
"heapDeltaBytes": 8603820,
"heapUsedBytes": 72764604,
"domNodes": 79,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 15.702,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.0629999999046,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.337,
"layouts": 6,
"layoutDurationMs": 0.568,
"taskDurationMs": 328.351,
"heapDeltaBytes": 8512044,
"heapUsedBytes": 72596012,
"domNodes": 79,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.192,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 547.9279999999562,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.083999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.19399999999996,
"heapDeltaBytes": -11321240,
"heapUsedBytes": 52753752,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 48.53,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 526.2539999999944,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.169,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.34099999999995,
"heapDeltaBytes": -12320392,
"heapUsedBytes": 51852280,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 42.857000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.4860000000863,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.14,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.5149999999999,
"heapDeltaBytes": 7192848,
"heapUsedBytes": 66973220,
"domNodes": -282,
"jsHeapTotalBytes": 3256320,
"scriptDurationMs": 74.16300000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2025.8689999999433,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.666999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.2840000000001,
"heapDeltaBytes": 6680944,
"heapUsedBytes": 66472660,
"domNodes": -282,
"jsHeapTotalBytes": 3518464,
"scriptDurationMs": 71.154,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2140.839000000028,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.109,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1044.742,
"heapDeltaBytes": 15949004,
"heapUsedBytes": 76949132,
"domNodes": -282,
"jsHeapTotalBytes": 3973120,
"scriptDurationMs": 320.75,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2114.9689999999737,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.014999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1031.519,
"heapDeltaBytes": 3434336,
"heapUsedBytes": 64184928,
"domNodes": -284,
"jsHeapTotalBytes": 3186688,
"scriptDurationMs": 322.07,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3108.045000000061,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11,
"layouts": 60,
"layoutDurationMs": 5.76,
"taskDurationMs": 1190.513,
"heapDeltaBytes": -9120044,
"heapUsedBytes": 53237360,
"domNodes": 14,
"jsHeapTotalBytes": 5091328,
"scriptDurationMs": 382.45700000000005,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3051.3260000000173,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.095,
"layouts": 60,
"layoutDurationMs": 6.132000000000001,
"taskDurationMs": 1149.4279999999999,
"heapDeltaBytes": 20167272,
"heapUsedBytes": 82273776,
"domNodes": 14,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 374.782,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.1950000000152,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.789,
"heapDeltaBytes": 6953544,
"heapUsedBytes": 67699972,
"domNodes": -284,
"jsHeapTotalBytes": 3780608,
"scriptDurationMs": 72.168,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2017.9900000000544,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.694000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.256,
"heapDeltaBytes": 4224280,
"heapUsedBytes": 64738300,
"domNodes": -284,
"jsHeapTotalBytes": 3780608,
"scriptDurationMs": 71.954,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.8409999999394,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.337000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.24499999999995,
"heapDeltaBytes": -10858700,
"heapUsedBytes": 53348480,
"domNodes": 22,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 93.374,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.1100000000188,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.819,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.45300000000003,
"heapDeltaBytes": -10875772,
"heapUsedBytes": 53338384,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 101.678,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.4389999999903,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.844,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.899,
"heapDeltaBytes": -18050200,
"heapUsedBytes": 46045956,
"domNodes": 20,
"jsHeapTotalBytes": 23576576,
"scriptDurationMs": 11.944,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.5479999999852,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.911999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.44499999999994,
"heapDeltaBytes": 5100124,
"heapUsedBytes": 69215012,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 12.331,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.947999999932,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.449,
"layouts": 16,
"layoutDurationMs": 3.615999999999999,
"taskDurationMs": 689.822,
"heapDeltaBytes": -16238652,
"heapUsedBytes": 47883040,
"domNodes": -280,
"jsHeapTotalBytes": 23576576,
"scriptDurationMs": 65.74000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1684.4480000000885,
"styleRecalcs": 75,
"styleRecalcDurationMs": 25.519999999999996,
"layouts": 16,
"layoutDurationMs": 3.1010000000000004,
"taskDurationMs": 669.0450000000001,
"heapDeltaBytes": -16490232,
"heapUsedBytes": 47490408,
"domNodes": -281,
"jsHeapTotalBytes": 23838720,
"scriptDurationMs": 63.155,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1166.1100000000033,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.777,
"layouts": 15,
"layoutDurationMs": 9.137,
"taskDurationMs": 775.1120000000001,
"heapDeltaBytes": 5000780,
"heapUsedBytes": 93592488,
"domNodes": 13673,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 26.918,
"eventListeners": 2373,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8116.028000000028,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3541.4700000000003,
"heapDeltaBytes": 10409976,
"heapUsedBytes": 70155284,
"domNodes": -283,
"jsHeapTotalBytes": 5283840,
"scriptDurationMs": 1003.711,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8110.915000000091,
"styleRecalcs": 248,
"styleRecalcDurationMs": 24.941000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3575.2129999999997,
"heapDeltaBytes": 7873440,
"heapUsedBytes": 67691212,
"domNodes": -279,
"jsHeapTotalBytes": 6332416,
"scriptDurationMs": 1030.512,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12205.882999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12190.975,
"heapDeltaBytes": -32253356,
"heapUsedBytes": 172366968,
"domNodes": -8312,
"jsHeapTotalBytes": -5967872,
"scriptDurationMs": 443.22499999999997,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12072.140999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12058.119999999999,
"heapDeltaBytes": -54920340,
"heapUsedBytes": 165481944,
"domNodes": -8312,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 452.77399999999994,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14890.181999999983,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.852000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14866.583,
"heapDeltaBytes": -48491988,
"heapUsedBytes": 173697656,
"domNodes": -8312,
"jsHeapTotalBytes": -8925184,
"scriptDurationMs": 723.136,
"eventListeners": -16389,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14895.616000000018,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.767,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14873.697,
"heapDeltaBytes": -40700728,
"heapUsedBytes": 166599356,
"domNodes": -8312,
"jsHeapTotalBytes": -10952704,
"scriptDurationMs": 701.9200000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 452.780999999959,
"styleRecalcs": 18,
"styleRecalcDurationMs": 18.721999999999998,
"layouts": 3,
"layoutDurationMs": 1.0820000000000003,
"taskDurationMs": 98.65400000000001,
"heapDeltaBytes": 5331064,
"heapUsedBytes": 68668576,
"domNodes": 138,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.327000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 435.0970000000416,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.608,
"layouts": 3,
"layoutDurationMs": 0.5660000000000001,
"taskDurationMs": 90.631,
"heapDeltaBytes": 5068132,
"heapUsedBytes": 68416988,
"domNodes": 125,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.141000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
📝 WalkthroughWalkthroughThe PR replaces onboarding ABC ROM Extended styling with PP Formula fonts, adds design-system font and color tokens, and updates bundling and OSS validation to handle both proprietary font families. ChangesFont asset integration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14694 +/- ##
==========================================
+ Coverage 78.64% 79.27% +0.62%
==========================================
Files 1790 1790
Lines 104690 115158 +10468
Branches 32118 35980 +3862
==========================================
+ Hits 82335 91286 +8951
- Misses 21916 23326 +1410
- Partials 439 546 +107
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed the cloud-only font pipeline, design tokens, and OSS asset guard. The Vite exclusion and CI validation cover both proprietary font families, the bundled PP Formula face metadata matches the declared weights, and the current checks are green.
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to Comfy-Org#14696, carousel keys to Comfy-Org#14698), so no intermediate merge renders raw i18n keys. Stacked on Comfy-Org#14694.
…Org#14696) > **Stacked PR 3 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Rebuilds the login, sign-up and forgot-password panels on real design-system variants instead of a hand-pasted class string. ## Changes - **What**: Adds the auth copy keys (`cloudNewUser`, `cloudSignUp`, `freeRunsSuffix`) this PR's views consume, plus `brand-ghost`, `brand-solid`, `brand-ghost-accent` variants and `brand` / `brand-icon` sizes to the shared `Button`. The same long class string was previously pasted at six sites with `size="unset"` — every one of those buttons was opting out of the design system it was meant to use. - Extracts `useCloudAuthPage` and `CloudSocialAuthButtons` from the near-identical login and sign-up views (~85% duplicated markup plus identical OAuth handlers). - `SignUpForm` / `PasswordFields` take typed `ButtonVariants` props instead of opaque class strings. Defaults are unchanged, so the desktop sign-in dialog and update-password dialog render exactly as before. ## Review Focus - **Shared-component blast radius**: `SignUpForm` and `PasswordFields` are also used by `SignInContent.vue` and `UpdatePasswordContent.vue`. The `h-10` field default is deliberately preserved — those two dialogs have no test coverage. - The variants and the views ship together on purpose: `button.variants.ts` has zero consumers on its own, so splitting them would merge dead code. The panel is width-bounded here so this PR is visually valid on its own; Comfy-Org#14697 relocates that constraint onto its own wrapper. Stacked on the button a11y PR.
> **Stacked PR 4 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary The logo sat in its own padded header while the content column centred independently, so the two never lined up — measured 96px apart at 1600w. ## Changes - **What**: One wrapper now owns the horizontal bounds, giving the three-zone layout the design asks for: logo pinned top, content centred, terms pinned bottom, all sharing a single left edge. - Moves the terms copy — previously duplicated verbatim in both auth views — into `CloudTermsNotice`, shown via a `showTermsNotice` route meta. Other cloud routes keep the existing link footer. ## Review Focus `route.meta.showTermsNotice` swaps the footer for the terms notice on login and sign-up only. Every other cloud route — survey, user-check, forgot-password — keeps `CloudTemplateFooter` exactly as before, asserted at the route level in `onboardingCloudRoutes.test.ts`. Verified logo x === headline x at 1600 / 1280 / 1024 / 768 / 390, with no horizontal overflow at any width. Stacked on the auth panel PR.
> **Stacked PR 5 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Replaces the static jpg collage with an auto-advancing video reel: playback-synced progress bar, chevron controls, per-slide captions. ## Changes - **What**: New `CloudHeroCarousel` built on `useVideoCarousel` (slide state, preload ladder, failure handling) and `useProgressBarPainter` (rAF bar writing straight to the DOM, so a 60Hz value never re-renders the component). - Slides rotate their flex `order` rather than translating one strip, so wrapping last→first travels the same direction as any other step instead of rewinding across every slide. The composable reports the direction it was asked to move, so skipping a failed slide still animates forwards. - Media is served from `media.comfy.org` rather than bundled, so no video bytes ship in the repo or the build. - The hero card takes its height from the row instead of a fixed aspect ratio, which is what kept the logo and terms pinned to the video's edges as the viewport grew. ## Review Focus - **Playback stops when it should**: verified paused with frozen decoder frame counts when the tab is hidden and when the panel scrolls offscreen. No leak across 5 mount/unmount cycles (heap and node counts flat). - **Gated above `xl`** via `v-if`, not CSS — confirmed against a production build that phones and tablets fetch **0 bytes** of video. - **A11y**: axe (WCAG 2.0/2.1 A+AA) reports no violations in the carousel subtree. One slide exposed at a time via `aria-hidden` + `inert`, carousel landmark with a polite live region that announces user-driven moves only — the auto-advance stays silent so it never talks over the form. - **Reduced motion**: no playback, no auto-advance, chevrons still work without starting video. Screenshots. <img width="1440" height="900" alt="forgot-1-default" src="https://github.com/user-attachments/assets/2710d4f9-dc5e-41a4-bbfc-2fd895b9df47" /> <img width="1440" height="900" alt="forgot-2-required" src="https://github.com/user-attachments/assets/254893ed-ad94-4a08-91fa-fabb107e167c" /> <img width="1440" height="900" alt="forgot-3-filled" src="https://github.com/user-attachments/assets/ac6d6431-c678-4fd2-b69b-67801345150c" /> <img width="1440" height="900" alt="forgot-4-long-email-overflow" src="https://github.com/user-attachments/assets/b91c8a67-cc84-43de-8d78-087b0c546ccd" /> <img width="1440" height="900" alt="forgot-no-footer" src="https://github.com/user-attachments/assets/c18ac4ef-d5dc-4437-b1ff-b687210d465f" /> <img width="1440" height="900" alt="login-1-social" src="https://github.com/user-attachments/assets/f1a5a889-9631-4603-8da7-3e21f1ca68e8" /> <img width="1440" height="900" alt="login-2-email-empty" src="https://github.com/user-attachments/assets/a4eaead2-350a-4140-be4e-2ea79bf4d1ff" /> <img width="1440" height="900" alt="login-3-invalid-email" src="https://github.com/user-attachments/assets/80943f8f-7ddb-438e-b641-9d6b97388d94" /> <img width="1440" height="900" alt="login-4-required" src="https://github.com/user-attachments/assets/66f9835e-f511-4993-81b7-1d49dd4cd9ea" /> <img width="1440" height="900" alt="login-with-fixed-logo" src="https://github.com/user-attachments/assets/52ee9097-7b5d-4eef-9049-b1ce69eccde1" /> <img width="400" height="90" alt="LOGO-fixed" src="https://github.com/user-attachments/assets/b28d4f75-af83-41bc-9aeb-9fc187bc49a4" /> <img width="1440" height="900" alt="signup-1-social" src="https://github.com/user-attachments/assets/36f353a1-a66f-434f-91f6-0825a76025e1" /> <img width="1440" height="900" alt="signup-2-email-empty" src="https://github.com/user-attachments/assets/a5c9e2a1-667d-41f5-b15f-287ccb963e93" /> <img width="1440" height="900" alt="signup-3-weak-password" src="https://github.com/user-attachments/assets/ffa00431-1d33-43f8-9968-2ecb53268d2b" /> <img width="1440" height="900" alt="signup-4-password-mismatch" src="https://github.com/user-attachments/assets/3b81508d-06b7-40b4-b884-3342bb892265" /> --------- Co-authored-by: Deep Mehta <deepme987@gmail.com>
|
@MaanilVerma Successfully backported to #14845 |
> **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
|
@MaanilVerma Successfully backported to #14898 |
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to #14696, carousel keys to #14698), so no intermediate merge renders raw i18n keys. Stacked on #14694.
Summary
Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only.
Changes
--color-primary-comfy-yellow,--color-primary-warm-white,--color-primary-warm-grayand two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSSdist/..hero-title/.font-abcromrules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit.Review Focus
The font guard is the thing to check. Both directions are verified:
First of 5 stacked PRs — see the stack table in #1 of the series.