Skip to content

[backport cloud/1.49] feat(cloud): dark theme, brand tokens and PP Formula pipeline - #14845

Closed
comfy-pr-bot wants to merge 1 commit into
cloud/1.49from
backport-14694-to-cloud-1.49
Closed

comfy-pr-bot wants to merge 1 commit into
cloud/1.49from
backport-14694-to-cloud-1.49

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14694 to cloud/1.49

Automatically created by backport workflow.

> **Stacked PR 1 of 5** — cloud auth redesign. Merge in order,
bottom-up.
>
> | | PR | What it does |
> |---|---|---|
> | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only
|
> | 2 | #14695 | Button keeps its label for screen readers while loading
|
> | 3 | #14696 | Brand button variants; login, sign-up and
forgot-password rebuilt on them |
> | 4 | #14697 | Logo, content and terms share one left edge |
> | 5 | #14698 | Static hero collage becomes a video carousel |

## Summary

Lands the shell the cloud auth redesign sits on: brand colour tokens,
the white-transparency steps, and PP Formula shipped cloud-only.

## Changes

- **What**: Adds `--color-primary-comfy-yellow`,
`--color-primary-warm-white`, `--color-primary-warm-gray` and two
white-transparency tokens to the design system. Ships three PP Formula
faces on the same rails ABC ROM already used — faces live under the
onboarding assets, the Vite plugin strips them from non-cloud bundles,
and CI fails the build if they reach an OSS `dist/`.
- Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules.
Nothing referenced them, so they were proprietary bytes bundled for no
visual benefit.

## Review Focus

The font guard is the thing to check. Both directions are verified:

```
DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*"   # empty
DISTRIBUTION=cloud     pnpm build && find dist -iname "*ppformula*"                        # 3 files
```

First of 5 stacked PRs — see the stack table in #1 of the series.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 6, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 6, 2026 16:34
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance

⚠️ Performance tests failed. Check the CI workflow logs.

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/07/2026, 03:26:58 AM UTC

Links

@github-actions
github-actions Bot requested a review from benceruleanlu August 6, 2026 20:10
@MaanilVerma MaanilVerma closed this Aug 7, 2026
auto-merge was automatically disabled August 7, 2026 04:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants