Repository navigation
fix(ui): keep the button label readable while loading - #14695
Conversation
Adds the brand colour tokens and the white-transparency steps the cloud auth surface needs, and ships PP Formula on the same cloud-only rails ABC ROM already used: faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS dist. Drops ABC ROM Extended and its .hero-title/.font-abcrom rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit.
The loading state replaced the slot with a spinner, so assistive tech lost the button's name for as long as the request was in flight. Keep the label in the accessibility tree via sr-only, hide the decorative spinner, and mark the control aria-busy. Also lands the i18n for the cloud auth redesign: the new sign-up sub-line and free-run copy, the carousel's slide and control labels, and removal of the marketing-pillar slide strings the carousel no longer renders.
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
📝 WalkthroughWalkthroughThe button now exposes ChangesButton loading accessibility
Estimated code review effort: 2 (Simple) | ~10 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1782 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.25 MB gzip 🔴 +38 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 3 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed UI Components — 70.2 kB (baseline 70 kB) • 🔴 +196 BReusable component library chunks
Status: 10 added / 10 removed / 5 unchanged Data & Services — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 20 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 82 added / 82 removed / 199 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T20:01:27.649Z",
"gitSha": "2d5d01a3d19af8ea16b2db1c787de0806de0f09a",
"branch": "fix/button-loading-a11y",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2154.4159999999692,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.093,
"heapDeltaBytes": 5513880,
"heapUsedBytes": 69674932,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 21.192,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.9730000000081,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.299,
"heapDeltaBytes": 5618564,
"heapUsedBytes": 69655980,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 15.562000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2070.8250000000135,
"styleRecalcs": 78,
"styleRecalcDurationMs": 47.510999999999996,
"layouts": 12,
"layoutDurationMs": 3.9019999999999997,
"taskDurationMs": 1068.659,
"heapDeltaBytes": -12566916,
"heapUsedBytes": 51679292,
"domNodes": -282,
"jsHeapTotalBytes": 24625152,
"scriptDurationMs": 134.576,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1870.0849999999036,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.506,
"layouts": 12,
"layoutDurationMs": 3.633,
"taskDurationMs": 898.635,
"heapDeltaBytes": -11839532,
"heapUsedBytes": 52175532,
"domNodes": -282,
"jsHeapTotalBytes": 23052288,
"scriptDurationMs": 126.73500000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.583999999999,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.347999999999995,
"layouts": 6,
"layoutDurationMs": 0.673,
"taskDurationMs": 433.034,
"heapDeltaBytes": 8460432,
"heapUsedBytes": 72785324,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 24.922,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.732999999972,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.768999999999998,
"layouts": 6,
"layoutDurationMs": 0.5189999999999999,
"taskDurationMs": 394.888,
"heapDeltaBytes": 8657152,
"heapUsedBytes": 72740252,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 21.058,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 622.8679999999827,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.328,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.23199999999997,
"heapDeltaBytes": -10917852,
"heapUsedBytes": 53072140,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 60.82299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 613.578000000075,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.642999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.17300000000006,
"heapDeltaBytes": -11165500,
"heapUsedBytes": 53104928,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 61.643,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2042.8869999999506,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.451000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.692,
"heapDeltaBytes": -20775408,
"heapUsedBytes": 60462556,
"domNodes": -281,
"jsHeapTotalBytes": 7557120,
"scriptDurationMs": 107.99899999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.0510000000095,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.592000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.2559999999999,
"heapDeltaBytes": 6368356,
"heapUsedBytes": 65743788,
"domNodes": -283,
"jsHeapTotalBytes": 3256320,
"scriptDurationMs": 118.254,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2169.813999999974,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.119,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1306.5500000000002,
"heapDeltaBytes": 3310060,
"heapUsedBytes": 64049016,
"domNodes": -285,
"jsHeapTotalBytes": 3973120,
"scriptDurationMs": 438.67,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2136.7539999999963,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.674999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1280.3719999999998,
"heapDeltaBytes": -4996160,
"heapUsedBytes": 55422296,
"domNodes": -285,
"jsHeapTotalBytes": 4304896,
"scriptDurationMs": 431.981,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3176.8789999999854,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.078999999999997,
"layouts": 60,
"layoutDurationMs": 7.17,
"taskDurationMs": 1471.7839999999999,
"heapDeltaBytes": 23588700,
"heapUsedBytes": 85878868,
"domNodes": 10,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 537.501,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3192.723000000001,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.357000000000001,
"layouts": 60,
"layoutDurationMs": 7.143,
"taskDurationMs": 1455.752,
"heapDeltaBytes": 23536660,
"heapUsedBytes": 85768428,
"domNodes": 8,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 519.932,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2033.5439999999494,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.0239999999999,
"heapDeltaBytes": 6247520,
"heapUsedBytes": 66687452,
"domNodes": -284,
"jsHeapTotalBytes": 3780608,
"scriptDurationMs": 127.803,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.7720000000845,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.854999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.9639999999999,
"heapDeltaBytes": 7661948,
"heapUsedBytes": 70176680,
"domNodes": -280,
"jsHeapTotalBytes": 4304896,
"scriptDurationMs": 106.632,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.401000000038,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.636000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.39000000000004,
"heapDeltaBytes": -10701056,
"heapUsedBytes": 53373680,
"domNodes": 14,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 124.357,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.3389999999536,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.30699999999996,
"heapDeltaBytes": -10468556,
"heapUsedBytes": 53612308,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 120.89699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2009.6790000000055,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.991000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.6070000000001,
"heapDeltaBytes": -17314692,
"heapUsedBytes": 46683776,
"domNodes": -278,
"jsHeapTotalBytes": 24363008,
"scriptDurationMs": 17.375999999999998,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.4039999999886,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.609,
"heapDeltaBytes": 5154116,
"heapUsedBytes": 69281024,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 15.236999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.1809999999964,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.377,
"layouts": 16,
"layoutDurationMs": 4.827999999999999,
"taskDurationMs": 823.913,
"heapDeltaBytes": -4217988,
"heapUsedBytes": 59930056,
"domNodes": 63,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 96.042,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.4549999999244,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.411,
"layouts": 16,
"layoutDurationMs": 4.877000000000001,
"taskDurationMs": 833.421,
"heapDeltaBytes": -3890996,
"heapUsedBytes": 60324268,
"domNodes": 63,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 98.576,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.0300000000111,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.721999999999998,
"layouts": 13,
"layoutDurationMs": 12.601,
"taskDurationMs": 940.8570000000001,
"heapDeltaBytes": 8854632,
"heapUsedBytes": 100544496,
"domNodes": 13673,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 35.007,
"eventListeners": 2375,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8554.50499999995,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.193000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4755.629,
"heapDeltaBytes": 14258388,
"heapUsedBytes": 74676132,
"domNodes": -284,
"jsHeapTotalBytes": 5283840,
"scriptDurationMs": 1488.134,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8371.534999999994,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4551.945,
"heapDeltaBytes": 10637460,
"heapUsedBytes": 69907044,
"domNodes": -282,
"jsHeapTotalBytes": 3710976,
"scriptDurationMs": 1420.576,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17328.209999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17312.24,
"heapDeltaBytes": -48479912,
"heapUsedBytes": 165664404,
"domNodes": -8312,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 578.138,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17321.54700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17297.938,
"heapDeltaBytes": -56538784,
"heapUsedBytes": 166604656,
"domNodes": -8312,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 574.536,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20811.75999999999,
"styleRecalcs": 140,
"styleRecalcDurationMs": 17.771000000000036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20788.725000000002,
"heapDeltaBytes": -26620996,
"heapUsedBytes": 178703832,
"domNodes": -8312,
"jsHeapTotalBytes": -8396800,
"scriptDurationMs": 897.363,
"eventListeners": -16385,
"totalBlockingTimeMs": 358,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21388.0979999999,
"styleRecalcs": 146,
"styleRecalcDurationMs": 17.647999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21344.324,
"heapDeltaBytes": -45815128,
"heapUsedBytes": 162146024,
"domNodes": -8312,
"jsHeapTotalBytes": -12263424,
"scriptDurationMs": 922.889,
"eventListeners": -16387,
"totalBlockingTimeMs": 395,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 118.63199999999097,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.926,
"layouts": 3,
"layoutDurationMs": 1.6640000000000001,
"taskDurationMs": 92.10799999999998,
"heapDeltaBytes": 3468872,
"heapUsedBytes": 66765684,
"domNodes": 144,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 7.381,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 150.85899999996855,
"styleRecalcs": 11,
"styleRecalcDurationMs": 16.039,
"layouts": 2,
"layoutDurationMs": 0.45699999999999996,
"taskDurationMs": 83.10600000000001,
"heapDeltaBytes": 3219428,
"heapUsedBytes": 66561156,
"domNodes": 113,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.908000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14695 +/- ##
==========================================
+ Coverage 78.28% 79.28% +0.99%
==========================================
Files 1790 1791 +1
Lines 108911 115207 +6296
Branches 29888 35988 +6100
==========================================
+ Hits 85258 91337 +6079
- Misses 23163 23324 +161
- Partials 490 546 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 215 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Found one blocking regression in the locale cleanup: the current stacked revision still renders translation keys removed here.
| "cloudStart_desc": "Zero setup required. Works on any device.", | ||
| "cloudStart_explain": "Generate multiple outputs at once. Share workflows with ease.", | ||
| "cloudStart_learnAboutButton": "Learn about Cloud", | ||
| "cloudStart_wantToRun": "Want to run ComfyUI locally instead?", |
There was a problem hiding this comment.
issue: These deletions leave the current revision's CloudHeroCarousel.vue with four missing messages: it still calls cloudStart_wantToRun, cloudStart_download, cloudHero.slides.cloud.title, and cloudHero.slides.cloud.description. Vue-i18n will render the key names on every cloud auth page until PR 5 lands, so merging this stack bottom-up introduces a visible regression between PRs. Could we keep the still-consumed keys in this PR and remove them in the PR that replaces CloudHeroCarousel?
There was a problem hiding this comment.
Good catch, fixed. You were right that removing them here broke the intermediate state, and there was a second half to it: this PR was also adding cloudNewUser, cloudSignUp, freeRunsSuffix and the four cloudHero a11y keys, none of which have a consumer until PR 3 and PR 5.
Every key now lives in the PR whose code uses it:
- This PR — no locale changes at all, just
Button.vueand its test. - PR 3 (auth panel) — adds the three auth copy keys that
CloudLoginView.vueconsumes. - PR 5 (carousel) — removes
cloudStart_wantToRun/cloudStart_download/cloudHero.slides.*in the same commit that replacesCloudHeroCarousel.vue, and adds the a11y keys the new one needs.
Verified by walking each tip of the stack, flattening en/main.json and diffing it against every t(...) reference under src/: zero missing messages at all five tips, where before the carousel keys went missing from this PR onward.
dante01yoon
left a comment
There was a problem hiding this comment.
Re-review complete: the four messages still consumed by CloudHeroCarousel.vue are restored at this stack tip, while locale changes without consumers were moved to the PRs that introduce those consumers. The live PR diff is now limited to Button.vue and its focused test, and all reported CI checks pass.
…Org#14694) > **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
…Org#14696) > **Stacked PR 3 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Rebuilds the login, sign-up and forgot-password panels on real design-system variants instead of a hand-pasted class string. ## Changes - **What**: Adds the auth copy keys (`cloudNewUser`, `cloudSignUp`, `freeRunsSuffix`) this PR's views consume, plus `brand-ghost`, `brand-solid`, `brand-ghost-accent` variants and `brand` / `brand-icon` sizes to the shared `Button`. The same long class string was previously pasted at six sites with `size="unset"` — every one of those buttons was opting out of the design system it was meant to use. - Extracts `useCloudAuthPage` and `CloudSocialAuthButtons` from the near-identical login and sign-up views (~85% duplicated markup plus identical OAuth handlers). - `SignUpForm` / `PasswordFields` take typed `ButtonVariants` props instead of opaque class strings. Defaults are unchanged, so the desktop sign-in dialog and update-password dialog render exactly as before. ## Review Focus - **Shared-component blast radius**: `SignUpForm` and `PasswordFields` are also used by `SignInContent.vue` and `UpdatePasswordContent.vue`. The `h-10` field default is deliberately preserved — those two dialogs have no test coverage. - The variants and the views ship together on purpose: `button.variants.ts` has zero consumers on its own, so splitting them would merge dead code. The panel is width-bounded here so this PR is visually valid on its own; Comfy-Org#14697 relocates that constraint onto its own wrapper. Stacked on the button a11y PR.
> **Stacked PR 4 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary The logo sat in its own padded header while the content column centred independently, so the two never lined up — measured 96px apart at 1600w. ## Changes - **What**: One wrapper now owns the horizontal bounds, giving the three-zone layout the design asks for: logo pinned top, content centred, terms pinned bottom, all sharing a single left edge. - Moves the terms copy — previously duplicated verbatim in both auth views — into `CloudTermsNotice`, shown via a `showTermsNotice` route meta. Other cloud routes keep the existing link footer. ## Review Focus `route.meta.showTermsNotice` swaps the footer for the terms notice on login and sign-up only. Every other cloud route — survey, user-check, forgot-password — keeps `CloudTemplateFooter` exactly as before, asserted at the route level in `onboardingCloudRoutes.test.ts`. Verified logo x === headline x at 1600 / 1280 / 1024 / 768 / 390, with no horizontal overflow at any width. Stacked on the auth panel PR.
> **Stacked PR 5 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Replaces the static jpg collage with an auto-advancing video reel: playback-synced progress bar, chevron controls, per-slide captions. ## Changes - **What**: New `CloudHeroCarousel` built on `useVideoCarousel` (slide state, preload ladder, failure handling) and `useProgressBarPainter` (rAF bar writing straight to the DOM, so a 60Hz value never re-renders the component). - Slides rotate their flex `order` rather than translating one strip, so wrapping last→first travels the same direction as any other step instead of rewinding across every slide. The composable reports the direction it was asked to move, so skipping a failed slide still animates forwards. - Media is served from `media.comfy.org` rather than bundled, so no video bytes ship in the repo or the build. - The hero card takes its height from the row instead of a fixed aspect ratio, which is what kept the logo and terms pinned to the video's edges as the viewport grew. ## Review Focus - **Playback stops when it should**: verified paused with frozen decoder frame counts when the tab is hidden and when the panel scrolls offscreen. No leak across 5 mount/unmount cycles (heap and node counts flat). - **Gated above `xl`** via `v-if`, not CSS — confirmed against a production build that phones and tablets fetch **0 bytes** of video. - **A11y**: axe (WCAG 2.0/2.1 A+AA) reports no violations in the carousel subtree. One slide exposed at a time via `aria-hidden` + `inert`, carousel landmark with a polite live region that announces user-driven moves only — the auto-advance stays silent so it never talks over the form. - **Reduced motion**: no playback, no auto-advance, chevrons still work without starting video. Screenshots. <img width="1440" height="900" alt="forgot-1-default" src="https://github.com/user-attachments/assets/2710d4f9-dc5e-41a4-bbfc-2fd895b9df47" /> <img width="1440" height="900" alt="forgot-2-required" src="https://github.com/user-attachments/assets/254893ed-ad94-4a08-91fa-fabb107e167c" /> <img width="1440" height="900" alt="forgot-3-filled" src="https://github.com/user-attachments/assets/ac6d6431-c678-4fd2-b69b-67801345150c" /> <img width="1440" height="900" alt="forgot-4-long-email-overflow" src="https://github.com/user-attachments/assets/b91c8a67-cc84-43de-8d78-087b0c546ccd" /> <img width="1440" height="900" alt="forgot-no-footer" src="https://github.com/user-attachments/assets/c18ac4ef-d5dc-4437-b1ff-b687210d465f" /> <img width="1440" height="900" alt="login-1-social" src="https://github.com/user-attachments/assets/f1a5a889-9631-4603-8da7-3e21f1ca68e8" /> <img width="1440" height="900" alt="login-2-email-empty" src="https://github.com/user-attachments/assets/a4eaead2-350a-4140-be4e-2ea79bf4d1ff" /> <img width="1440" height="900" alt="login-3-invalid-email" src="https://github.com/user-attachments/assets/80943f8f-7ddb-438e-b641-9d6b97388d94" /> <img width="1440" height="900" alt="login-4-required" src="https://github.com/user-attachments/assets/66f9835e-f511-4993-81b7-1d49dd4cd9ea" /> <img width="1440" height="900" alt="login-with-fixed-logo" src="https://github.com/user-attachments/assets/52ee9097-7b5d-4eef-9049-b1ce69eccde1" /> <img width="400" height="90" alt="LOGO-fixed" src="https://github.com/user-attachments/assets/b28d4f75-af83-41bc-9aeb-9fc187bc49a4" /> <img width="1440" height="900" alt="signup-1-social" src="https://github.com/user-attachments/assets/36f353a1-a66f-434f-91f6-0825a76025e1" /> <img width="1440" height="900" alt="signup-2-email-empty" src="https://github.com/user-attachments/assets/a5c9e2a1-667d-41f5-b15f-287ccb963e93" /> <img width="1440" height="900" alt="signup-3-weak-password" src="https://github.com/user-attachments/assets/ffa00431-1d33-43f8-9968-2ecb53268d2b" /> <img width="1440" height="900" alt="signup-4-password-mismatch" src="https://github.com/user-attachments/assets/3b81508d-06b7-40b4-b884-3342bb892265" /> --------- Co-authored-by: Deep Mehta <deepme987@gmail.com>
|
@MaanilVerma Successfully backported to #14846 |
> **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to #14696, carousel keys to #14698), so no intermediate merge renders raw i18n keys. Stacked on #14694.
|
@MaanilVerma Successfully backported to #14899 |
Summary
The shared
Buttondropped its label while loading, so assistive tech lost the control name for as long as the request was in flight.Changes
sr-only, hides the decorative spinner from screen readers, and marks the controlaria-busywhile loading. Visually unchanged.Review Focus
Button.vueis used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs.This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to #14696, carousel keys to #14698), so no intermediate merge renders raw i18n keys.
Stacked on #14694.