Skip to content

feat(cloud): align logo, content and terms on one edge - #14697

Merged
MaanilVerma merged 17 commits into
mainfrom
feat/cloud-auth-layout
Aug 5, 2026
Merged

MaanilVerma merged 17 commits into
mainfrom
feat/cloud-auth-layout

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Aug 4, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked PR 4 of 5 — cloud auth redesign. Merge in order, bottom-up.

PR What it does
1 #14694 Dark theme, brand tokens, PP Formula shipped cloud-only
2 #14695 Button keeps its label for screen readers while loading
3 #14696 Brand button variants; login, sign-up and forgot-password rebuilt on them
4 #14697 Logo, content and terms share one left edge
5 #14698 Static hero collage becomes a video carousel

Summary

The logo sat in its own padded header while the content column centred independently, so the two never lined up — measured 96px apart at 1600w.

Changes

  • What: One wrapper now owns the horizontal bounds, giving the three-zone layout the design asks for: logo pinned top, content centred, terms pinned bottom, all sharing a single left edge.
  • Moves the terms copy — previously duplicated verbatim in both auth views — into CloudTermsNotice, shown via a showTermsNotice route meta. Other cloud routes keep the existing link footer.

Review Focus

route.meta.showTermsNotice swaps the footer for the terms notice on login and sign-up only. Every other cloud route — survey, user-check, forgot-password — keeps CloudTemplateFooter exactly as before, asserted at the route level in onboardingCloudRoutes.test.ts.

Verified logo x === headline x at 1600 / 1280 / 1024 / 768 / 390, with no horizontal overflow at any width.

Stacked on the auth panel PR.

Adds the brand colour tokens and the white-transparency steps the cloud auth
surface needs, and ships PP Formula on the same cloud-only rails ABC ROM
already used: faces live under the onboarding assets, the Vite plugin strips
them from non-cloud bundles, and CI fails the build if they reach an OSS dist.

Drops ABC ROM Extended and its .hero-title/.font-abcrom rules. Nothing
referenced them, so they were proprietary bytes bundled for no visual benefit.
The loading state replaced the slot with a spinner, so assistive tech lost the
button's name for as long as the request was in flight. Keep the label in the
accessibility tree via sr-only, hide the decorative spinner, and mark the
control aria-busy.

Also lands the i18n for the cloud auth redesign: the new sign-up sub-line and
free-run copy, the carousel's slide and control labels, and removal of the
marketing-pillar slide strings the carousel no longer renders.
Adds brand variants and sizes to the shared Button, replacing a class string
that was pasted at six sites with size="unset".

Extracts useCloudAuthPage and CloudSocialAuthButtons from the near-identical
login and sign-up views. SignUpForm takes typed variant props instead of class
strings; defaults are unchanged, so the desktop dialogs render as before.
The logo sat in its own padded header while the slot centred independently, so
the two never lined up. One wrapper now owns the horizontal bounds, giving the
three-zone layout the design asks for.

Moves the terms copy, previously duplicated in both auth views, into
CloudTermsNotice behind a showTermsNotice route meta.
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Cloud onboarding now uses a responsive two-column layout. Route metadata controls terms notices. Wide viewports display the hero. Login and signup routes enable localized legal notices.

Changes

Cloud onboarding experience

Layer / File(s) Summary
Route notice metadata
src/platform/cloud/onboarding/onboardingCloudRoutes.ts, src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts
Login and signup routes enable showTermsNotice. The forgot-password route test confirms that the metadata remains disabled.
Responsive template and notices
src/platform/cloud/onboarding/components/CloudTemplate.vue, src/platform/cloud/onboarding/components/CloudTermsNotice.vue, src/platform/cloud/onboarding/components/CloudTemplateFooter.vue
The template uses viewport state and route metadata for hero, terms-notice, and footer rendering. The terms notice contains localized legal and support links. The footer uses the updated full-width layout.
Template behavior tests
src/platform/cloud/onboarding/components/CloudTemplate.test.ts
Tests configure i18n and viewport matching. They verify wide and tablet hero behavior and exclusive terms-notice or footer rendering.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CloudRoute
  participant CloudTemplate
  participant CloudHeroCarousel
  participant CloudTermsNotice
  participant CloudTemplateFooter
  CloudRoute->>CloudTemplate: provide route metadata
  CloudTemplate->>CloudHeroCarousel: render on wide viewport unless hideHero is true
  CloudTemplate->>CloudTermsNotice: render when showTermsNotice is true
  CloudTemplate->>CloudTemplateFooter: render when showTermsNotice is false
Loading

Possibly related PRs

Suggested labels: cloud/1.49

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The PR title and commit subjects are not available in the review context, so the required bug-fix signal cannot be verified. Provide the PR title and commit subjects to determine whether the end-to-end regression coverage check applies.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main layout change: aligning the logo, content, and terms on one edge.
Description check ✅ Passed The description covers the summary, changes, review focus, route behavior, and verification details; the optional screenshots section is omitted.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are cloud onboarding Vue and test files. None are under src/lib/litegraph/, src/ecs/, or graph-entity files.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/cloud-auth-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/05/2026, 01:41:10 AM UTC

Links

🎭 Playwright: ✅ 1792 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1771 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 8.26 MB gzip 🔴 +488 B

Details

Summary

  • Raw size: 34.7 MB baseline 34.7 MB — 🔴 +2.82 kB
  • Gzip: 8.26 MB baseline 8.25 MB — 🔴 +488 B
  • Brotli: 5.71 MB baseline 5.71 MB — 🔴 +436 B
  • Bundles: 428 current • 428 baseline • 4 added / 4 removed

Category Glance
Views & Navigation 🔴 +2.75 kB (114 kB) · Other 🔴 +74 B (12.8 MB) · Vendor & Third-Party ⚪ 0 B (15.7 MB) · Data & Services ⚪ 0 B (3.48 MB) · Graph Workspace ⚪ 0 B (1.35 MB) · Panels & Settings ⚪ 0 B (551 kB) · + 5 more

App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-CFAfUR1Z.js (removed) 3.64 kB — 🟢 -3.64 kB 🟢 -1.82 kB 🟢 -1.58 kB
assets/index-Dg5UtlAC.js (new) — 3.64 kB 🔴 +3.64 kB 🔴 +1.82 kB 🔴 +1.57 kB

Status: 1 added / 1 removed

Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 2 unchanged

Views & Navigation — 114 kB (baseline 112 kB) • 🔴 +2.75 kB

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudLayoutView-g1IteV9e.js (new) — 12.3 kB 🔴 +12.3 kB 🔴 +2.81 kB 🔴 +2.45 kB
assets/CloudLayoutView-DJa-NZiW.js (removed) 9.6 kB — 🟢 -9.6 kB 🟢 -2.34 kB 🟢 -2.02 kB

Status: 1 added / 1 removed / 16 unchanged

Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 10 unchanged

Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 7 unchanged

UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.48 MB (baseline 3.48 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 36 unchanged

Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 12.8 MB (baseline 12.8 MB) • 🔴 +74 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-CeAdkzbh.js (new) — 47 kB 🔴 +47 kB 🔴 +13.9 kB 🔴 +12 kB
assets/main-Da5gWrDP.js (removed) 47 kB — 🟢 -47 kB 🟢 -13.9 kB 🟢 -12 kB
assets/onboardingCloudRoutes-C9XSXuMm.js (new) — 9.12 kB 🔴 +9.12 kB 🔴 +2.78 kB 🔴 +2.4 kB
assets/onboardingCloudRoutes-B6J3Y9us.js (removed) 9.05 kB — 🟢 -9.05 kB 🟢 -2.76 kB 🟢 -2.38 kB

Status: 2 added / 2 removed / 279 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 143ms TBT · 93.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.8 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 146ms TBT · 164.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap

⚠️ 6 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 521ms 523ms +0% ⚠️ z=4.1
large-graph-idle: task duration 797ms 654ms -18% ⚠️ z=2.1
large-graph-pan: task duration 1350ms 1231ms -9% ⚠️ z=3.5
minimap-idle: task duration 723ms 653ms -10% ⚠️ z=2.6
subgraph-idle: task duration 534ms 451ms -16% ⚠️ z=2.6
workflow-execution: event listeners 49 98 +100% ⚠️ z=10.6
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.5
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 8ms -10% z=-3.7
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 8 7 -13% z=-7.4
canvas-idle: task duration 521ms 523ms +0% ⚠️ z=4.1
canvas-idle: script duration 21ms 15ms -30% z=-4.6
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 66.4 MB 66.6 MB +0% —
canvas-idle: DOM nodes 16 14 -13% z=-6.7
canvas-idle: event listeners 4 5 +25% z=-1.4
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms -1% —
canvas-mouse-sweep: layout duration 4ms 3ms -22% z=-2.2
canvas-mouse-sweep: style recalc duration 47ms 31ms -33% z=-3.6
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 77 72 -6% z=-2.8
canvas-mouse-sweep: task duration 978ms 839ms -14% z=-0.5
canvas-mouse-sweep: script duration 128ms 119ms -7% z=-2.6
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 48.7 MB 48.0 MB -1% —
canvas-mouse-sweep: DOM nodes -280 -283 +1% z=-133.3
canvas-mouse-sweep: event listeners -153 -153 +0% z=-38.7
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms -0% —
canvas-zoom-sweep: layout duration 1ms 1ms -10% z=-0.4
canvas-zoom-sweep: style recalc duration 19ms 15ms -21% z=-2.7
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 30 33 +10% z=3.8
canvas-zoom-sweep: task duration 420ms 350ms -17% z=1.0
canvas-zoom-sweep: script duration 23ms 17ms -27% z=-3.4
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.4 MB 69.5 MB +0% —
canvas-zoom-sweep: DOM nodes 76 79 +3% z=-0.9
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.5
dom-widget-clipping: p95 frame time 17ms 17ms -1% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 7ms 7ms +2% z=-3.1
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 12 +5% z=-3.2
dom-widget-clipping: task duration 393ms 371ms -6% z=0.4
dom-widget-clipping: script duration 59ms 59ms +1% z=-2.6
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 50.6 MB 50.6 MB +0% —
dom-widget-clipping: DOM nodes 18 19 +6% z=-2.2
dom-widget-clipping: event listeners 0 2 — variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 8ms 8ms +2% z=-4.3
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 8 9 +13% z=-8.3
large-graph-idle: task duration 797ms 654ms -18% ⚠️ z=2.1
large-graph-idle: script duration 125ms 102ms -18% z=-0.1
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 64.0 MB 63.5 MB -1% —
large-graph-idle: DOM nodes -283 -282 -1% z=-338.8
large-graph-idle: event listeners -147 -149 +1% z=-28.7
large-graph-pan: avg frame time 17ms 17ms -0% z=-0.8
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 15ms 14ms -10% z=-4.5
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-0.9
large-graph-pan: task duration 1350ms 1231ms -9% ⚠️ z=3.5
large-graph-pan: script duration 422ms 425ms +1% z=0.8
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 62.2 MB 59.0 MB -5% —
large-graph-pan: DOM nodes -284 -284 -0% z=-183.3
large-graph-pan: event listeners -149 -163 +9% z=-202.8
large-graph-zoom: avg frame time 17ms 17ms -0% —
large-graph-zoom: p95 frame time 17ms 17ms +1% —
large-graph-zoom: layout duration 9ms 7ms -19% —
large-graph-zoom: style recalc duration 16ms 14ms -13% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 64 66 +2% —
large-graph-zoom: task duration 1621ms 1440ms -11% —
large-graph-zoom: script duration 563ms 511ms -9% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 63.1 MB 54.1 MB -14% —
large-graph-zoom: DOM nodes -287 -287 +0% —
large-graph-zoom: event listeners -153 -153 +0% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 7ms 8ms +2% z=-2.5
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 10 +19% z=-0.1
minimap-idle: task duration 723ms 653ms -10% ⚠️ z=2.6
minimap-idle: script duration 107ms 100ms -7% z=0.2
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 64.3 MB 64.5 MB +0% —
minimap-idle: DOM nodes -283 -283 -0% z=-220.5
minimap-idle: event listeners -177 -148 -16% z=-231.1
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 10ms -5% z=-2.7
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 47 +0% z=-1.6
subgraph-dom-widget-clipping: task duration 424ms 387ms -9% z=0.5
subgraph-dom-widget-clipping: script duration 126ms 117ms -7% z=-1.8
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.0 MB 51.2 MB +0% —
subgraph-dom-widget-clipping: DOM nodes 20 20 +0% z=-1.9
subgraph-dom-widget-clipping: event listeners 8 6 -25% z=-1.7
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 9ms -4% z=-2.3
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 11 +5% z=-0.6
subgraph-idle: task duration 534ms 451ms -16% ⚠️ z=2.6
subgraph-idle: script duration 20ms 12ms -36% z=-2.9
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 66.0 MB 66.0 MB +0% —
subgraph-idle: DOM nodes 20 21 +5% z=-0.5
subgraph-idle: event listeners 4 4 +0% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 5ms 4ms -16% z=-2.7
subgraph-mouse-sweep: style recalc duration 39ms 35ms -10% z=-2.1
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 77 +0% z=-1.6
subgraph-mouse-sweep: task duration 844ms 724ms -14% z=-0.6
subgraph-mouse-sweep: script duration 94ms 82ms -14% z=-2.9
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 45.7 MB 51.2 MB +12% —
subgraph-mouse-sweep: DOM nodes -279 -109 -61% z=-78.5
subgraph-mouse-sweep: event listeners -153 -75 -51% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 12ms 12ms +0% —
subgraph-transition-enter: style recalc duration 31ms 29ms -6% —
subgraph-transition-enter: layout count 14 15 +7% —
subgraph-transition-enter: style recalc count 18 19 +6% —
subgraph-transition-enter: task duration 1006ms 877ms -13% —
subgraph-transition-enter: script duration 40ms 37ms -7% —
subgraph-transition-enter: TBT 127ms 143ms +13% —
subgraph-transition-enter: heap used 94.7 MB 93.5 MB -1% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2375 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 41ms 35ms -17% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 250 -0% —
viewport-pan-sweep: task duration 4617ms 4260ms -8% —
viewport-pan-sweep: script duration 1409ms 1354ms -4% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 68.1 MB 68.0 MB -0% —
viewport-pan-sweep: DOM nodes -282 -282 +0% —
viewport-pan-sweep: event listeners -133 -133 +0% —
vue-large-graph-idle: avg frame time 18ms 17ms -2% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 18275ms 15547ms -15% —
vue-large-graph-idle: script duration 594ms 546ms -8% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 148.3 MB 161.8 MB +9% —
vue-large-graph-idle: DOM nodes -8312 -8329 +0% —
vue-large-graph-idle: event listeners -16385 -16386 +0% —
vue-large-graph-pan: avg frame time 18ms 17ms -5% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 25ms 14ms -45% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 165 133 -19% —
vue-large-graph-pan: task duration 22523ms 19679ms -13% —
vue-large-graph-pan: script duration 933ms 868ms -7% —
vue-large-graph-pan: TBT 638ms 146ms -77% —
vue-large-graph-pan: heap used 158.7 MB 164.2 MB +3% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16381 -16382 +0% —
workflow-execution: avg frame time 17ms 17ms +0% z=1.1
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 1ms 1ms +30% z=-4.1
workflow-execution: style recalc duration 13ms 20ms +52% z=-1.8
workflow-execution: layout count 2 4 +75% z=-2.7
workflow-execution: style recalc count 7 13 +86% z=-2.3
workflow-execution: task duration 85ms 114ms +35% z=-0.8
workflow-execution: script duration 8ms 10ms +24% z=-6.5
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 63.5 MB 65.3 MB +3% —
workflow-execution: DOM nodes 125 129 +3% z=-4.5
workflow-execution: event listeners 49 98 +100% ⚠️ z=10.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-05T01:51:09.885Z",
  "gitSha": "4e4d9e18093d0137ae4584fb0ceb7ed8533494b4",
  "branch": "feat/cloud-auth-layout",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2159.6779999999853,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.384999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 610.958,
      "heapDeltaBytes": 5594628,
      "heapUsedBytes": 69801496,
      "domNodes": 10,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 15.903999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2010.9820000000127,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.656,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.861,
      "heapDeltaBytes": 5521656,
      "heapUsedBytes": 69863628,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 13.977999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1823.6699999999928,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 32.14,
      "layouts": 12,
      "layoutDurationMs": 3.383,
      "taskDurationMs": 842.311,
      "heapDeltaBytes": -13732668,
      "heapUsedBytes": 50574560,
      "domNodes": -284,
      "jsHeapTotalBytes": 24358912,
      "scriptDurationMs": 119.081,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1804.7300000000632,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 30.414,
      "layouts": 12,
      "layoutDurationMs": 2.9770000000000003,
      "taskDurationMs": 834.833,
      "heapDeltaBytes": -13994612,
      "heapUsedBytes": 50074580,
      "domNodes": -281,
      "jsHeapTotalBytes": 23048192,
      "scriptDurationMs": 118.53800000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.799000000009,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 14.432000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.6190000000000001,
      "taskDurationMs": 353.55,
      "heapDeltaBytes": 8427844,
      "heapUsedBytes": 72762360,
      "domNodes": 78,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 16.756,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.316000000068,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 15.529,
      "layouts": 6,
      "layoutDurationMs": 0.628,
      "taskDurationMs": 346.472,
      "heapDeltaBytes": 8697344,
      "heapUsedBytes": 72995224,
      "domNodes": 79,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 16.936,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 594.916000000012,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.6610000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.36400000000003,
      "heapDeltaBytes": -11099432,
      "heapUsedBytes": 53031316,
      "domNodes": 18,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 61.434000000000005,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 608.3149999999478,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.195999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.49399999999997,
      "heapDeltaBytes": -11122184,
      "heapUsedBytes": 53156400,
      "domNodes": 20,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 57.497,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.1830000000127,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.846999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 652.9110000000001,
      "heapDeltaBytes": 7286596,
      "heapUsedBytes": 67175208,
      "domNodes": -283,
      "jsHeapTotalBytes": 2990080,
      "scriptDurationMs": 101.02600000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.7600000000339,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.570000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.7520000000001,
      "heapDeltaBytes": 7394648,
      "heapUsedBytes": 66087372,
      "domNodes": -280,
      "jsHeapTotalBytes": 2465792,
      "scriptDurationMs": 102.03500000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2143.1460000000015,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.941000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1220.2499999999998,
      "heapDeltaBytes": 1864960,
      "heapUsedBytes": 62035136,
      "domNodes": -284,
      "jsHeapTotalBytes": 3444736,
      "scriptDurationMs": 418.545,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2164.278000000081,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.524999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1241.7830000000001,
      "heapDeltaBytes": 1087136,
      "heapUsedBytes": 61671100,
      "domNodes": -283,
      "jsHeapTotalBytes": 3444736,
      "scriptDurationMs": 430.584,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3163.7790000000336,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.290000000000003,
      "layouts": 60,
      "layoutDurationMs": 6.801,
      "taskDurationMs": 1438.919,
      "heapDeltaBytes": -5443216,
      "heapUsedBytes": 56580532,
      "domNodes": -287,
      "jsHeapTotalBytes": 6135808,
      "scriptDurationMs": 506.628,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3163.756000000035,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.165000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.062,
      "taskDurationMs": 1442.039,
      "heapDeltaBytes": -5253604,
      "heapUsedBytes": 56899112,
      "domNodes": -287,
      "jsHeapTotalBytes": 5087232,
      "scriptDurationMs": 516.039,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.7859999999687,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.688000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 652.1190000000001,
      "heapDeltaBytes": 7106984,
      "heapUsedBytes": 68047920,
      "domNodes": -282,
      "jsHeapTotalBytes": 2727936,
      "scriptDurationMs": 101.084,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.6610000000373,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.3169999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 652.9850000000001,
      "heapDeltaBytes": 6558972,
      "heapUsedBytes": 67138024,
      "domNodes": -283,
      "jsHeapTotalBytes": 3776512,
      "scriptDurationMs": 98.32300000000001,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 557.4910000000273,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.308,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 393.979,
      "heapDeltaBytes": -10458932,
      "heapUsedBytes": 53719124,
      "domNodes": 22,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 119.51399999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 560.2839999999105,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.026000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 379.069,
      "heapDeltaBytes": -10588896,
      "heapUsedBytes": 53654908,
      "domNodes": 18,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 113.95,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2012.8419999999778,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.827000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 457.48,
      "heapDeltaBytes": 5127944,
      "heapUsedBytes": 69263164,
      "domNodes": 20,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 12.509999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1994.0930000000208,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.403,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.92699999999996,
      "heapDeltaBytes": 5074912,
      "heapUsedBytes": 69220084,
      "domNodes": 22,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 12.373,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.3359999999939,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 39.837,
      "layouts": 16,
      "layoutDurationMs": 4.213,
      "taskDurationMs": 766.681,
      "heapDeltaBytes": -16670752,
      "heapUsedBytes": 47517524,
      "domNodes": -281,
      "jsHeapTotalBytes": 24096768,
      "scriptDurationMs": 82.476,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1678.2309999999825,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 31.072999999999997,
      "layouts": 16,
      "layoutDurationMs": 3.438,
      "taskDurationMs": 682.1969999999999,
      "heapDeltaBytes": -4236304,
      "heapUsedBytes": 59870832,
      "domNodes": 64,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 80.93599999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.0159999999742,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 29.149999999999995,
      "layouts": 15,
      "layoutDurationMs": 11.940000000000003,
      "taskDurationMs": 876.506,
      "heapDeltaBytes": 29074832,
      "heapUsedBytes": 98091224,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15990784,
      "scriptDurationMs": 37.007,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 143,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8308.965,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 35.00300000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4269.764,
      "heapDeltaBytes": 12129568,
      "heapUsedBytes": 71375612,
      "domNodes": -281,
      "jsHeapTotalBytes": 5541888,
      "scriptDurationMs": 1359.0490000000002,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8214.259999999967,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 34.066,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4250.5199999999995,
      "heapDeltaBytes": 10928484,
      "heapUsedBytes": 71332380,
      "domNodes": -283,
      "jsHeapTotalBytes": 6590464,
      "scriptDurationMs": 1349.831,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15600.119000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15538.516999999998,
      "heapDeltaBytes": -39357664,
      "heapUsedBytes": 168163032,
      "domNodes": -8316,
      "jsHeapTotalBytes": -7544832,
      "scriptDurationMs": 535.5060000000001,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15584.72900000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15555.215999999999,
      "heapDeltaBytes": -55239220,
      "heapUsedBytes": 171208608,
      "domNodes": -8341,
      "jsHeapTotalBytes": -1777664,
      "scriptDurationMs": 556.3789999999999,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19732.52199999996,
      "styleRecalcs": 132,
      "styleRecalcDurationMs": 13.64399999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19689.032,
      "heapDeltaBytes": -51037192,
      "heapUsedBytes": 164410972,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9904128,
      "scriptDurationMs": 910.9730000000001,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 92,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19701.68799999999,
      "styleRecalcs": 134,
      "styleRecalcDurationMs": 13.74499999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19669.569000000003,
      "heapDeltaBytes": -45665408,
      "heapUsedBytes": 179930172,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9711616,
      "scriptDurationMs": 824.851,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 200,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.116999999992,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 23.529,
      "layouts": 4,
      "layoutDurationMs": 1.3280000000000003,
      "taskDurationMs": 127.216,
      "heapDeltaBytes": 5370804,
      "heapUsedBytes": 68669912,
      "domNodes": 134,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.985999999999997,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 446.34899999994104,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 16.839,
      "layouts": 3,
      "layoutDurationMs": 0.568,
      "taskDurationMs": 101.472,
      "heapDeltaBytes": 5069448,
      "heapUsedBytes": 68328432,
      "domNodes": 123,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 8.594,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🎭 Playwright: ⏳ Running...

@codecov

codecov Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...m/cloud/onboarding/components/CloudTermsNotice.vue 50.00% 3 Missing ⚠️
@@            Coverage Diff             @@
##             main   #14697      +/-   ##
==========================================
+ Coverage   78.42%   79.37%   +0.95%     
==========================================
  Files        1795     1796       +1     
  Lines      106396   115360    +8964     
  Branches    30392    36868    +6476     
==========================================
+ Hits        83437    91572    +8135     
- Misses      22506    23242     +736     
- Partials      453      546      +93     
Flag Coverage Δ
unit 70.99% <84.21%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...form/cloud/onboarding/components/CloudTemplate.vue 100.00% <100.00%> (ø)
...loud/onboarding/components/CloudTemplateFooter.vue 50.00% <100.00%> (+16.66%) ⬆️
...platform/cloud/onboarding/onboardingCloudRoutes.ts 31.42% <ø> (ø)
...m/cloud/onboarding/components/CloudTermsNotice.vue 50.00% <50.00%> (ø)

... and 220 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking regression conflicts with the PR’s stated intent that non-login/signup routes retain the existing link footer.

component: () =>
import('@/platform/cloud/onboarding/CloudForgotPasswordView.vue')
import('@/platform/cloud/onboarding/CloudForgotPasswordView.vue'),
meta: { hideFooter: true }

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This newly suppresses CloudTemplateFooter on the forgot-password route. Before this patch, CloudTemplate rendered the footer unconditionally, and the PR description explicitly says forgot-password should keep the existing link footer. With the new template condition, hideFooter: true removes Terms, Privacy, and Help from this page. Could we omit this flag (and add the route-level regression assertion alongside the new footer/terms tests) so forgot-password preserves its prior footer?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag was intentional at first, but agreed on keeping the footer here. Dropped hideFooter from the route so forgot-password keeps Terms, Privacy and Help, and removed the now-unused condition from CloudTemplate. Added the route-level assertion you asked for in onboardingCloudRoutes.test.ts.

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 5, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/platform/cloud/onboarding/components/CloudTemplate.test.ts`:
- Around line 48-52: Update the CloudTemplate tests to render CloudTermsNotice
and CloudTemplateFooter directly instead of replacing them with data-testid
stubs. Extend the assertions to verify the visible notice text and
footer/support link accessible names, including auth.login.termsLink,
auth.login.privacyLink, and cloudFooter_needHelp under the existing i18n setup;
retain the existing CloudHeroCarousel stub.

In `@src/platform/cloud/onboarding/components/CloudTermsNotice.vue`:
- Around line 23-35: Remove the whitespace between the closing privacy and
support link elements and their following periods in the CloudTermsNotice
template, preserving the existing translated text and link structure.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 097f939b-ddfe-42cb-b5e0-990c2f260ea8

📥 Commits

Reviewing files that changed from the base of the PR and between cc2bff0 and 292b193.

⛔ Files ignored due to path filters (1)
  • public/icons/logo.svg is excluded by !**/*.svg
📒 Files selected for processing (6)
  • src/platform/cloud/onboarding/components/CloudTemplate.test.ts
  • src/platform/cloud/onboarding/components/CloudTemplate.vue
  • src/platform/cloud/onboarding/components/CloudTemplateFooter.vue
  • src/platform/cloud/onboarding/components/CloudTermsNotice.vue
  • src/platform/cloud/onboarding/onboardingCloudRoutes.test.ts
  • src/platform/cloud/onboarding/onboardingCloudRoutes.ts

@MaanilVerma
MaanilVerma added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit 8a3e9c9 Aug 5, 2026
76 of 78 checks passed
@MaanilVerma
MaanilVerma deleted the feat/cloud-auth-layout branch August 5, 2026 02:56
balpreetgrowthnatives pushed a commit to balpreetgrowthnatives/ComfyUI_frontend that referenced this pull request Aug 5, 2026
> **Stacked PR 5 of 5** — cloud auth redesign. Merge in order,
bottom-up.
>
> | | PR | What it does |
> |---|---|---|
> | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only
|
> | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading
|
> | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and
forgot-password rebuilt on them |
> | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge |
> | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel |

## Summary

Replaces the static jpg collage with an auto-advancing video reel:
playback-synced progress bar, chevron controls, per-slide captions.

## Changes

- **What**: New `CloudHeroCarousel` built on `useVideoCarousel` (slide
state, preload ladder, failure handling) and `useProgressBarPainter`
(rAF bar writing straight to the DOM, so a 60Hz value never re-renders
the component).
- Slides rotate their flex `order` rather than translating one strip, so
wrapping last→first travels the same direction as any other step instead
of rewinding across every slide. The composable reports the direction it
was asked to move, so skipping a failed slide still animates forwards.
- Media is served from `media.comfy.org` rather than bundled, so no
video bytes ship in the repo or the build.
- The hero card takes its height from the row instead of a fixed aspect
ratio, which is what kept the logo and terms pinned to the video's edges
as the viewport grew.

## Review Focus

- **Playback stops when it should**: verified paused with frozen decoder
frame counts when the tab is hidden and when the panel scrolls
offscreen. No leak across 5 mount/unmount cycles (heap and node counts
flat).
- **Gated above `xl`** via `v-if`, not CSS — confirmed against a
production build that phones and tablets fetch **0 bytes** of video.
- **A11y**: axe (WCAG 2.0/2.1 A+AA) reports no violations in the
carousel subtree. One slide exposed at a time via `aria-hidden` +
`inert`, carousel landmark with a polite live region that announces
user-driven moves only — the auto-advance stays silent so it never talks
over the form.
- **Reduced motion**: no playback, no auto-advance, chevrons still work
without starting video.


Screenshots.

<img width="1440" height="900" alt="forgot-1-default"
src="https://github.com/user-attachments/assets/2710d4f9-dc5e-41a4-bbfc-2fd895b9df47"
/>
<img width="1440" height="900" alt="forgot-2-required"
src="https://github.com/user-attachments/assets/254893ed-ad94-4a08-91fa-fabb107e167c"
/>
<img width="1440" height="900" alt="forgot-3-filled"
src="https://github.com/user-attachments/assets/ac6d6431-c678-4fd2-b69b-67801345150c"
/>
<img width="1440" height="900" alt="forgot-4-long-email-overflow"
src="https://github.com/user-attachments/assets/b91c8a67-cc84-43de-8d78-087b0c546ccd"
/>
<img width="1440" height="900" alt="forgot-no-footer"
src="https://github.com/user-attachments/assets/c18ac4ef-d5dc-4437-b1ff-b687210d465f"
/>
<img width="1440" height="900" alt="login-1-social"
src="https://github.com/user-attachments/assets/f1a5a889-9631-4603-8da7-3e21f1ca68e8"
/>
<img width="1440" height="900" alt="login-2-email-empty"
src="https://github.com/user-attachments/assets/a4eaead2-350a-4140-be4e-2ea79bf4d1ff"
/>
<img width="1440" height="900" alt="login-3-invalid-email"
src="https://github.com/user-attachments/assets/80943f8f-7ddb-438e-b641-9d6b97388d94"
/>
<img width="1440" height="900" alt="login-4-required"
src="https://github.com/user-attachments/assets/66f9835e-f511-4993-81b7-1d49dd4cd9ea"
/>
<img width="1440" height="900" alt="login-with-fixed-logo"
src="https://github.com/user-attachments/assets/52ee9097-7b5d-4eef-9049-b1ce69eccde1"
/>
<img width="400" height="90" alt="LOGO-fixed"
src="https://github.com/user-attachments/assets/b28d4f75-af83-41bc-9aeb-9fc187bc49a4"
/>
<img width="1440" height="900" alt="signup-1-social"
src="https://github.com/user-attachments/assets/36f353a1-a66f-434f-91f6-0825a76025e1"
/>
<img width="1440" height="900" alt="signup-2-email-empty"
src="https://github.com/user-attachments/assets/a5c9e2a1-667d-41f5-b15f-287ccb963e93"
/>
<img width="1440" height="900" alt="signup-3-weak-password"
src="https://github.com/user-attachments/assets/ffa00431-1d33-43f8-9968-2ecb53268d2b"
/>
<img width="1440" height="900" alt="signup-4-password-mismatch"
src="https://github.com/user-attachments/assets/3b81508d-06b7-40b4-b884-3342bb892265"
/>

---------

Co-authored-by: Deep Mehta <deepme987@gmail.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 5, 2026
…#14805)

## Summary

The Comfy logo on the Cloud login/signup/forgot-password pages is broken
on nightly, testcloud, stagingcloud, and prod-cloud — it only renders
correctly in local dev.

## Changes

- **What**: `CloudTemplate.vue` loads the logo via ``&#39;&lt;img
src=&#34;/icons/logo.svg&#34;&gt;&#39;``. That asset lived at
`public/icons/logo.svg`, a top-level `public/` path that Cloud&#39;s
nginx-frontend does not proxy through to the GCS asset bucket (nginx
only proxies `/assets/`, `/fonts/`, `/cursor/`, `/scripts/`,
`/extensions/core/`, `/extensions/cloud/`, plus the exact-match files
`/materialdesignicons.min.css` and `/favicon.ico`). The request falls
through to the SPA catch-all and gets `index.html` back with a 200, so
the browser shows a broken image with no console error and no 404 —
nothing to signal the failure. This was introduced by Comfy-Org#14697
(Comfy-Org#14697), which
swapped an iconify class for this `` tag.
- Moved the SVG to `public/assets/images/comfy-logo-wordmark.svg`, a
path nginx already proxies, matching the naming convention of the other
logo assets already in that directory (`comfy-logo-single.svg`,
`comfy-logo-mono.svg`).
- Updated the `img src` in `CloudTemplate.vue` to point at the new path.
- **Breaking**: none
- **Dependencies**: none

## Review Focus

- `apps/website/public/icons/logo.svg` is a separate, unrelated asset
for the standalone website app (different deployment, not served through
Cloud&#39;s nginx-frontend) — intentionally left untouched.

## Screenshots (if applicable)

N/A — this is a one-line path fix; no visual change to verify beyond the
logo now loading.


---
_Generated by [Claude
Code](https://claude.ai/code/session_01QsWQFqb9nLeijU1F6WdhWS)_

Co-authored-by: Claude <noreply@anthropic.com>
@MaanilVerma MaanilVerma added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.49 and removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.49 labels Aug 6, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Backport to cloud/1.49 failed

Reason: Merge conflicts detected during cherry-pick of 8a3e9c9

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-14697-to-cloud-1.49 (from origin/cloud/1.49) and
open a PR to cloud/1.49.

📄 Conflicting files
src/platform/cloud/onboarding/components/CloudTemplate.vue
🤖 Prompt for AI Agents
Backport PR #14697 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/14697) to cloud/1.49.
Cherry-pick merge commit 8a3e9c90856c2e9cc1108ed748c9eb3a09dbc4cd onto new branch
backport-14697-to-cloud-1.49 from origin/cloud/1.49.
Resolve conflicts in: src/platform/cloud/onboarding/components/CloudTemplate.vue .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.49] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @MaanilVerma

1 similar comment
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Backport to cloud/1.49 failed

Reason: Merge conflicts detected during cherry-pick of 8a3e9c9

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-14697-to-cloud-1.49 (from origin/cloud/1.49) and
open a PR to cloud/1.49.

📄 Conflicting files
src/platform/cloud/onboarding/components/CloudTemplate.vue
🤖 Prompt for AI Agents
Backport PR #14697 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/14697) to cloud/1.49.
Cherry-pick merge commit 8a3e9c90856c2e9cc1108ed748c9eb3a09dbc4cd onto new branch
backport-14697-to-cloud-1.49 from origin/cloud/1.49.
Resolve conflicts in: src/platform/cloud/onboarding/components/CloudTemplate.vue .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.49] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @MaanilVerma

comfy-pr-bot pushed a commit that referenced this pull request Aug 7, 2026
> **Stacked PR 1 of 5** — cloud auth redesign. Merge in order,
bottom-up.
>
> | | PR | What it does |
> |---|---|---|
> | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only
|
> | 2 | #14695 | Button keeps its label for screen readers while loading
|
> | 3 | #14696 | Brand button variants; login, sign-up and
forgot-password rebuilt on them |
> | 4 | #14697 | Logo, content and terms share one left edge |
> | 5 | #14698 | Static hero collage becomes a video carousel |

## Summary

Lands the shell the cloud auth redesign sits on: brand colour tokens,
the white-transparency steps, and PP Formula shipped cloud-only.

## Changes

- **What**: Adds `--color-primary-comfy-yellow`,
`--color-primary-warm-white`, `--color-primary-warm-gray` and two
white-transparency tokens to the design system. Ships three PP Formula
faces on the same rails ABC ROM already used — faces live under the
onboarding assets, the Vite plugin strips them from non-cloud bundles,
and CI fails the build if they reach an OSS `dist/`.
- Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules.
Nothing referenced them, so they were proprietary bytes bundled for no
visual benefit.

## Review Focus

The font guard is the thing to check. Both directions are verified:

```
DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*"   # empty
DISTRIBUTION=cloud     pnpm build && find dist -iname "*ppformula*"                        # 3 files
```

First of 5 stacked PRs — see the stack table in #1 of the series.
comfy-pr-bot pushed a commit that referenced this pull request Aug 7, 2026
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order,
bottom-up.
>
> | | PR | What it does |
> |---|---|---|
> | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only
|
> | 2 | #14695 | Button keeps its label for screen readers while loading
|
> | 3 | #14696 | Brand button variants; login, sign-up and
forgot-password rebuilt on them |
> | 4 | #14697 | Logo, content and terms share one left edge |
> | 5 | #14698 | Static hero collage becomes a video carousel |

## Summary

The shared `Button` dropped its label while loading, so assistive tech
lost the control name for as long as the request was in flight.

## Changes

- **What**: Keeps the label in the accessibility tree via `sr-only`,
hides the decorative spinner from screen readers, and marks the control
`aria-busy` while loading. Visually unchanged.

## Review Focus

`Button.vue` is used app-wide, so the loading change is worth a look
beyond the cloud pages — the rendered output is identical, only the
accessibility tree differs.

This PR is now two files. The locale changes it originally carried moved
to the PRs that consume them (auth copy to #14696, carousel keys to
#14698), so no intermediate merge renders raw i18n keys.

Stacked on #14694.
@MaanilVerma MaanilVerma added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.49 and removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.49 labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Backport to cloud/1.49 failed

Reason: Merge conflicts detected during cherry-pick of 8a3e9c9

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-14697-to-cloud-1.49 (from origin/cloud/1.49) and
open a PR to cloud/1.49.

📄 Conflicting files
src/platform/cloud/onboarding/components/CloudTemplate.vue
🤖 Prompt for AI Agents
Backport PR #14697 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/14697) to cloud/1.49.
Cherry-pick merge commit 8a3e9c90856c2e9cc1108ed748c9eb3a09dbc4cd onto new branch
backport-14697-to-cloud-1.49 from origin/cloud/1.49.
Resolve conflicts in: src/platform/cloud/onboarding/components/CloudTemplate.vue .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.49] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @MaanilVerma

1 similar comment
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Backport to cloud/1.49 failed

Reason: Merge conflicts detected during cherry-pick of 8a3e9c9

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-14697-to-cloud-1.49 (from origin/cloud/1.49) and
open a PR to cloud/1.49.

📄 Conflicting files
src/platform/cloud/onboarding/components/CloudTemplate.vue
🤖 Prompt for AI Agents
Backport PR #14697 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/14697) to cloud/1.49.
Cherry-pick merge commit 8a3e9c90856c2e9cc1108ed748c9eb3a09dbc4cd onto new branch
backport-14697-to-cloud-1.49 from origin/cloud/1.49.
Resolve conflicts in: src/platform/cloud/onboarding/components/CloudTemplate.vue .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.49] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @MaanilVerma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants