Repository navigation
feat(cloud): align logo, content and terms on one edge - #14697
Conversation
Adds the brand colour tokens and the white-transparency steps the cloud auth surface needs, and ships PP Formula on the same cloud-only rails ABC ROM already used: faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS dist. Drops ABC ROM Extended and its .hero-title/.font-abcrom rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit.
The loading state replaced the slot with a spinner, so assistive tech lost the button's name for as long as the request was in flight. Keep the label in the accessibility tree via sr-only, hide the decorative spinner, and mark the control aria-busy. Also lands the i18n for the cloud auth redesign: the new sign-up sub-line and free-run copy, the carousel's slide and control labels, and removal of the marketing-pillar slide strings the carousel no longer renders.
Adds brand variants and sizes to the shared Button, replacing a class string that was pasted at six sites with size="unset". Extracts useCloudAuthPage and CloudSocialAuthButtons from the near-identical login and sign-up views. SignUpForm takes typed variant props instead of class strings; defaults are unchanged, so the desktop dialogs render as before.
The logo sat in its own padded header while the slot centred independently, so the two never lined up. One wrapper now owns the horizontal bounds, giving the three-zone layout the design asks for. Moves the terms copy, previously duplicated in both auth views, into CloudTermsNotice behind a showTermsNotice route meta.
📝 WalkthroughWalkthroughCloud onboarding now uses a responsive two-column layout. Route metadata controls terms notices. Wide viewports display the hero. Login and signup routes enable localized legal notices. ChangesCloud onboarding experience
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CloudRoute
participant CloudTemplate
participant CloudHeroCarousel
participant CloudTermsNotice
participant CloudTemplateFooter
CloudRoute->>CloudTemplate: provide route metadata
CloudTemplate->>CloudHeroCarousel: render on wide viewport unless hideHero is true
CloudTemplate->>CloudTermsNotice: render when showTermsNotice is true
CloudTemplate->>CloudTemplateFooter: render when showTermsNotice is false
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1792 passed, 0 failed📊 Browser Reports
📦 Bundle: 8.26 MB gzip 🔴 +488 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 114 kB (baseline 112 kB) • 🔴 +2.75 kBTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed / 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🔴 +74 BBundles that do not match a named category
Status: 2 added / 2 removed / 279 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T01:51:09.885Z",
"gitSha": "4e4d9e18093d0137ae4584fb0ceb7ed8533494b4",
"branch": "feat/cloud-auth-layout",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2159.6779999999853,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.384999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.958,
"heapDeltaBytes": 5594628,
"heapUsedBytes": 69801496,
"domNodes": 10,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 15.903999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2010.9820000000127,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.656,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.861,
"heapDeltaBytes": 5521656,
"heapUsedBytes": 69863628,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 13.977999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.6699999999928,
"styleRecalcs": 72,
"styleRecalcDurationMs": 32.14,
"layouts": 12,
"layoutDurationMs": 3.383,
"taskDurationMs": 842.311,
"heapDeltaBytes": -13732668,
"heapUsedBytes": 50574560,
"domNodes": -284,
"jsHeapTotalBytes": 24358912,
"scriptDurationMs": 119.081,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1804.7300000000632,
"styleRecalcs": 72,
"styleRecalcDurationMs": 30.414,
"layouts": 12,
"layoutDurationMs": 2.9770000000000003,
"taskDurationMs": 834.833,
"heapDeltaBytes": -13994612,
"heapUsedBytes": 50074580,
"domNodes": -281,
"jsHeapTotalBytes": 23048192,
"scriptDurationMs": 118.53800000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.799000000009,
"styleRecalcs": 33,
"styleRecalcDurationMs": 14.432000000000002,
"layouts": 6,
"layoutDurationMs": 0.6190000000000001,
"taskDurationMs": 353.55,
"heapDeltaBytes": 8427844,
"heapUsedBytes": 72762360,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 16.756,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.316000000068,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.529,
"layouts": 6,
"layoutDurationMs": 0.628,
"taskDurationMs": 346.472,
"heapDeltaBytes": 8697344,
"heapUsedBytes": 72995224,
"domNodes": 79,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 16.936,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 594.916000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.6610000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.36400000000003,
"heapDeltaBytes": -11099432,
"heapUsedBytes": 53031316,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 61.434000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 608.3149999999478,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.195999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.49399999999997,
"heapDeltaBytes": -11122184,
"heapUsedBytes": 53156400,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 57.497,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.1830000000127,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.846999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.9110000000001,
"heapDeltaBytes": 7286596,
"heapUsedBytes": 67175208,
"domNodes": -283,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 101.02600000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.7600000000339,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.570000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.7520000000001,
"heapDeltaBytes": 7394648,
"heapUsedBytes": 66087372,
"domNodes": -280,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 102.03500000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2143.1460000000015,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.941000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1220.2499999999998,
"heapDeltaBytes": 1864960,
"heapUsedBytes": 62035136,
"domNodes": -284,
"jsHeapTotalBytes": 3444736,
"scriptDurationMs": 418.545,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2164.278000000081,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.524999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1241.7830000000001,
"heapDeltaBytes": 1087136,
"heapUsedBytes": 61671100,
"domNodes": -283,
"jsHeapTotalBytes": 3444736,
"scriptDurationMs": 430.584,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3163.7790000000336,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.290000000000003,
"layouts": 60,
"layoutDurationMs": 6.801,
"taskDurationMs": 1438.919,
"heapDeltaBytes": -5443216,
"heapUsedBytes": 56580532,
"domNodes": -287,
"jsHeapTotalBytes": 6135808,
"scriptDurationMs": 506.628,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3163.756000000035,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.165000000000001,
"layouts": 60,
"layoutDurationMs": 7.062,
"taskDurationMs": 1442.039,
"heapDeltaBytes": -5253604,
"heapUsedBytes": 56899112,
"domNodes": -287,
"jsHeapTotalBytes": 5087232,
"scriptDurationMs": 516.039,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.7859999999687,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.688000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.1190000000001,
"heapDeltaBytes": 7106984,
"heapUsedBytes": 68047920,
"domNodes": -282,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 101.084,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2024.6610000000373,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.3169999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.9850000000001,
"heapDeltaBytes": 6558972,
"heapUsedBytes": 67138024,
"domNodes": -283,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 98.32300000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.4910000000273,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.979,
"heapDeltaBytes": -10458932,
"heapUsedBytes": 53719124,
"domNodes": 22,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 119.51399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.2839999999105,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.026000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.069,
"heapDeltaBytes": -10588896,
"heapUsedBytes": 53654908,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 113.95,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2012.8419999999778,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.827000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.48,
"heapDeltaBytes": 5127944,
"heapUsedBytes": 69263164,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 12.509999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1994.0930000000208,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.403,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.92699999999996,
"heapDeltaBytes": 5074912,
"heapUsedBytes": 69220084,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 12.373,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.3359999999939,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.837,
"layouts": 16,
"layoutDurationMs": 4.213,
"taskDurationMs": 766.681,
"heapDeltaBytes": -16670752,
"heapUsedBytes": 47517524,
"domNodes": -281,
"jsHeapTotalBytes": 24096768,
"scriptDurationMs": 82.476,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.2309999999825,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.072999999999997,
"layouts": 16,
"layoutDurationMs": 3.438,
"taskDurationMs": 682.1969999999999,
"heapDeltaBytes": -4236304,
"heapUsedBytes": 59870832,
"domNodes": 64,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 80.93599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0159999999742,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.149999999999995,
"layouts": 15,
"layoutDurationMs": 11.940000000000003,
"taskDurationMs": 876.506,
"heapDeltaBytes": 29074832,
"heapUsedBytes": 98091224,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 37.007,
"eventListeners": 2375,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8308.965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.00300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4269.764,
"heapDeltaBytes": 12129568,
"heapUsedBytes": 71375612,
"domNodes": -281,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 1359.0490000000002,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8214.259999999967,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.066,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4250.5199999999995,
"heapDeltaBytes": 10928484,
"heapUsedBytes": 71332380,
"domNodes": -283,
"jsHeapTotalBytes": 6590464,
"scriptDurationMs": 1349.831,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15600.119000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15538.516999999998,
"heapDeltaBytes": -39357664,
"heapUsedBytes": 168163032,
"domNodes": -8316,
"jsHeapTotalBytes": -7544832,
"scriptDurationMs": 535.5060000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15584.72900000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15555.215999999999,
"heapDeltaBytes": -55239220,
"heapUsedBytes": 171208608,
"domNodes": -8341,
"jsHeapTotalBytes": -1777664,
"scriptDurationMs": 556.3789999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19732.52199999996,
"styleRecalcs": 132,
"styleRecalcDurationMs": 13.64399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19689.032,
"heapDeltaBytes": -51037192,
"heapUsedBytes": 164410972,
"domNodes": -8312,
"jsHeapTotalBytes": -9904128,
"scriptDurationMs": 910.9730000000001,
"eventListeners": -16379,
"totalBlockingTimeMs": 92,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19701.68799999999,
"styleRecalcs": 134,
"styleRecalcDurationMs": 13.74499999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19669.569000000003,
"heapDeltaBytes": -45665408,
"heapUsedBytes": 179930172,
"domNodes": -8312,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 824.851,
"eventListeners": -16385,
"totalBlockingTimeMs": 200,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 459.116999999992,
"styleRecalcs": 14,
"styleRecalcDurationMs": 23.529,
"layouts": 4,
"layoutDurationMs": 1.3280000000000003,
"taskDurationMs": 127.216,
"heapDeltaBytes": 5370804,
"heapUsedBytes": 68669912,
"domNodes": 134,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.985999999999997,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 446.34899999994104,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.839,
"layouts": 3,
"layoutDurationMs": 0.568,
"taskDurationMs": 101.472,
"heapDeltaBytes": 5069448,
"heapUsedBytes": 68328432,
"domNodes": 123,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.594,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
🎭 Playwright: ⏳ Running... |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14697 +/- ##
==========================================
+ Coverage 78.42% 79.37% +0.95%
==========================================
Files 1795 1796 +1
Lines 106396 115360 +8964
Branches 30392 36868 +6476
==========================================
+ Hits 83437 91572 +8135
- Misses 22506 23242 +736
- Partials 453 546 +93
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 220 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
One blocking regression conflicts with the PR’s stated intent that non-login/signup routes retain the existing link footer.
| component: () => | ||
| import('@/platform/cloud/onboarding/CloudForgotPasswordView.vue') | ||
| import('@/platform/cloud/onboarding/CloudForgotPasswordView.vue'), | ||
| meta: { hideFooter: true } |
There was a problem hiding this comment.
issue: This newly suppresses CloudTemplateFooter on the forgot-password route. Before this patch, CloudTemplate rendered the footer unconditionally, and the PR description explicitly says forgot-password should keep the existing link footer. With the new template condition, hideFooter: true removes Terms, Privacy, and Help from this page. Could we omit this flag (and add the route-level regression assertion alongside the new footer/terms tests) so forgot-password preserves its prior footer?
There was a problem hiding this comment.
The flag was intentional at first, but agreed on keeping the footer here. Dropped hideFooter from the route so forgot-password keeps Terms, Privacy and Help, and removed the now-unused condition from CloudTemplate. Added the route-level assertion you asked for in onboardingCloudRoutes.test.ts.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/cloud/onboarding/components/CloudTemplate.test.ts`:
- Around line 48-52: Update the CloudTemplate tests to render CloudTermsNotice
and CloudTemplateFooter directly instead of replacing them with data-testid
stubs. Extend the assertions to verify the visible notice text and
footer/support link accessible names, including auth.login.termsLink,
auth.login.privacyLink, and cloudFooter_needHelp under the existing i18n setup;
retain the existing CloudHeroCarousel stub.
In `@src/platform/cloud/onboarding/components/CloudTermsNotice.vue`:
- Around line 23-35: Remove the whitespace between the closing privacy and
support link elements and their following periods in the CloudTermsNotice
template, preserving the existing translated text and link structure.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 097f939b-ddfe-42cb-b5e0-990c2f260ea8
⛔ Files ignored due to path filters (1)
public/icons/logo.svgis excluded by!**/*.svg
📒 Files selected for processing (6)
src/platform/cloud/onboarding/components/CloudTemplate.test.tssrc/platform/cloud/onboarding/components/CloudTemplate.vuesrc/platform/cloud/onboarding/components/CloudTemplateFooter.vuesrc/platform/cloud/onboarding/components/CloudTermsNotice.vuesrc/platform/cloud/onboarding/onboardingCloudRoutes.test.tssrc/platform/cloud/onboarding/onboardingCloudRoutes.ts
> **Stacked PR 5 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Replaces the static jpg collage with an auto-advancing video reel: playback-synced progress bar, chevron controls, per-slide captions. ## Changes - **What**: New `CloudHeroCarousel` built on `useVideoCarousel` (slide state, preload ladder, failure handling) and `useProgressBarPainter` (rAF bar writing straight to the DOM, so a 60Hz value never re-renders the component). - Slides rotate their flex `order` rather than translating one strip, so wrapping last→first travels the same direction as any other step instead of rewinding across every slide. The composable reports the direction it was asked to move, so skipping a failed slide still animates forwards. - Media is served from `media.comfy.org` rather than bundled, so no video bytes ship in the repo or the build. - The hero card takes its height from the row instead of a fixed aspect ratio, which is what kept the logo and terms pinned to the video's edges as the viewport grew. ## Review Focus - **Playback stops when it should**: verified paused with frozen decoder frame counts when the tab is hidden and when the panel scrolls offscreen. No leak across 5 mount/unmount cycles (heap and node counts flat). - **Gated above `xl`** via `v-if`, not CSS — confirmed against a production build that phones and tablets fetch **0 bytes** of video. - **A11y**: axe (WCAG 2.0/2.1 A+AA) reports no violations in the carousel subtree. One slide exposed at a time via `aria-hidden` + `inert`, carousel landmark with a polite live region that announces user-driven moves only — the auto-advance stays silent so it never talks over the form. - **Reduced motion**: no playback, no auto-advance, chevrons still work without starting video. Screenshots. <img width="1440" height="900" alt="forgot-1-default" src="https://github.com/user-attachments/assets/2710d4f9-dc5e-41a4-bbfc-2fd895b9df47" /> <img width="1440" height="900" alt="forgot-2-required" src="https://github.com/user-attachments/assets/254893ed-ad94-4a08-91fa-fabb107e167c" /> <img width="1440" height="900" alt="forgot-3-filled" src="https://github.com/user-attachments/assets/ac6d6431-c678-4fd2-b69b-67801345150c" /> <img width="1440" height="900" alt="forgot-4-long-email-overflow" src="https://github.com/user-attachments/assets/b91c8a67-cc84-43de-8d78-087b0c546ccd" /> <img width="1440" height="900" alt="forgot-no-footer" src="https://github.com/user-attachments/assets/c18ac4ef-d5dc-4437-b1ff-b687210d465f" /> <img width="1440" height="900" alt="login-1-social" src="https://github.com/user-attachments/assets/f1a5a889-9631-4603-8da7-3e21f1ca68e8" /> <img width="1440" height="900" alt="login-2-email-empty" src="https://github.com/user-attachments/assets/a4eaead2-350a-4140-be4e-2ea79bf4d1ff" /> <img width="1440" height="900" alt="login-3-invalid-email" src="https://github.com/user-attachments/assets/80943f8f-7ddb-438e-b641-9d6b97388d94" /> <img width="1440" height="900" alt="login-4-required" src="https://github.com/user-attachments/assets/66f9835e-f511-4993-81b7-1d49dd4cd9ea" /> <img width="1440" height="900" alt="login-with-fixed-logo" src="https://github.com/user-attachments/assets/52ee9097-7b5d-4eef-9049-b1ce69eccde1" /> <img width="400" height="90" alt="LOGO-fixed" src="https://github.com/user-attachments/assets/b28d4f75-af83-41bc-9aeb-9fc187bc49a4" /> <img width="1440" height="900" alt="signup-1-social" src="https://github.com/user-attachments/assets/36f353a1-a66f-434f-91f6-0825a76025e1" /> <img width="1440" height="900" alt="signup-2-email-empty" src="https://github.com/user-attachments/assets/a5c9e2a1-667d-41f5-b15f-287ccb963e93" /> <img width="1440" height="900" alt="signup-3-weak-password" src="https://github.com/user-attachments/assets/ffa00431-1d33-43f8-9968-2ecb53268d2b" /> <img width="1440" height="900" alt="signup-4-password-mismatch" src="https://github.com/user-attachments/assets/3b81508d-06b7-40b4-b884-3342bb892265" /> --------- Co-authored-by: Deep Mehta <deepme987@gmail.com>
…#14805) ## Summary The Comfy logo on the Cloud login/signup/forgot-password pages is broken on nightly, testcloud, stagingcloud, and prod-cloud — it only renders correctly in local dev. ## Changes - **What**: `CloudTemplate.vue` loads the logo via ``'<img src="/icons/logo.svg">'``. That asset lived at `public/icons/logo.svg`, a top-level `public/` path that Cloud's nginx-frontend does not proxy through to the GCS asset bucket (nginx only proxies `/assets/`, `/fonts/`, `/cursor/`, `/scripts/`, `/extensions/core/`, `/extensions/cloud/`, plus the exact-match files `/materialdesignicons.min.css` and `/favicon.ico`). The request falls through to the SPA catch-all and gets `index.html` back with a 200, so the browser shows a broken image with no console error and no 404 — nothing to signal the failure. This was introduced by Comfy-Org#14697 (Comfy-Org#14697), which swapped an iconify class for this `` tag. - Moved the SVG to `public/assets/images/comfy-logo-wordmark.svg`, a path nginx already proxies, matching the naming convention of the other logo assets already in that directory (`comfy-logo-single.svg`, `comfy-logo-mono.svg`). - Updated the `img src` in `CloudTemplate.vue` to point at the new path. - **Breaking**: none - **Dependencies**: none ## Review Focus - `apps/website/public/icons/logo.svg` is a separate, unrelated asset for the standalone website app (different deployment, not served through Cloud's nginx-frontend) — intentionally left untouched. ## Screenshots (if applicable) N/A — this is a one-line path fix; no visual change to verify beyond the logo now loading. --- _Generated by [Claude Code](https://claude.ai/code/session_01QsWQFqb9nLeijU1F6WdhWS)_ Co-authored-by: Claude <noreply@anthropic.com>
|
1 similar comment
|
> **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to #14696, carousel keys to #14698), so no intermediate merge renders raw i18n keys. Stacked on #14694.
|
1 similar comment
|
Summary
The logo sat in its own padded header while the content column centred independently, so the two never lined up — measured 96px apart at 1600w.
Changes
CloudTermsNotice, shown via ashowTermsNoticeroute meta. Other cloud routes keep the existing link footer.Review Focus
route.meta.showTermsNoticeswaps the footer for the terms notice on login and sign-up only. Every other cloud route — survey, user-check, forgot-password — keepsCloudTemplateFooterexactly as before, asserted at the route level inonboardingCloudRoutes.test.ts.Verified logo x === headline x at 1600 / 1280 / 1024 / 768 / 390, with no horizontal overflow at any width.
Stacked on the auth panel PR.