Repository navigation
fix: align Cloud login/signup with dark onboarding theme - #14086
mariana953 wants to merge 1 commit into
Conversation
Several elements across the Cloud login/signup/forgot-password flow were still using desktop/light-theme fallback styling (workbench button and message tokens, text-muted, hardcoded fills) that clashed with the dark comfy-ink background, plus a non-uniform aspect-ratio on the wordmark logo that stretched it slightly. Brings every screen in the flow to the same flat, bordered look already used elsewhere in Cloud onboarding.
🎨 Storybook: 🚧 Building...🎭 Playwright: ✅ 1722 passed, 0 failed · 5 flaky📊 Browser Reports
📦 Bundle: 8.08 MB gzip 🟢 -9 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • 🔴 +493 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 29.3 kB (baseline 29.1 kB) • 🔴 +183 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 2 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 1 unchanged UI Components — 64.7 kB (baseline 64.7 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.37 MB (baseline 3.37 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 357 kB (baseline 357 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 15 added / 15 removed / 20 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.4 MB (baseline 12.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 67 added / 67 removed / 207 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-24T11:27:38.192Z",
"gitSha": "9951a465ad8a72e9fb233fe38eb275cfebfeebc3",
"branch": "feat/login-page-redesign",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.2129999999465,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.684000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.83200000000005,
"heapDeltaBytes": -21807264,
"heapUsedBytes": 45479236,
"domNodes": 20,
"jsHeapTotalBytes": 19927040,
"scriptDurationMs": 17.577,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2024.6700000000146,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.154,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.864,
"heapDeltaBytes": 3553656,
"heapUsedBytes": 71019164,
"domNodes": 20,
"jsHeapTotalBytes": 20848640,
"scriptDurationMs": 19.662,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2027.0810000000097,
"styleRecalcs": 81,
"styleRecalcDurationMs": 48.266,
"layouts": 12,
"layoutDurationMs": 3.6789999999999994,
"taskDurationMs": 1017.2979999999998,
"heapDeltaBytes": -16672648,
"heapUsedBytes": 50724600,
"domNodes": -260,
"jsHeapTotalBytes": 21762048,
"scriptDurationMs": 132.36,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.969999999962,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.946,
"layouts": 12,
"layoutDurationMs": 3.8519999999999994,
"taskDurationMs": 900.9300000000001,
"heapDeltaBytes": -16380784,
"heapUsedBytes": 51039592,
"domNodes": -267,
"jsHeapTotalBytes": 22286336,
"scriptDurationMs": 126.3,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.5999999999667,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.222,
"layouts": 6,
"layoutDurationMs": 0.7030000000000001,
"taskDurationMs": 385.70400000000006,
"heapDeltaBytes": 7238936,
"heapUsedBytes": 74570280,
"domNodes": 79,
"jsHeapTotalBytes": 20324352,
"scriptDurationMs": 21.689,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.198999999895,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.434,
"layouts": 6,
"layoutDurationMs": 0.7570000000000001,
"taskDurationMs": 403.00800000000004,
"heapDeltaBytes": 7073308,
"heapUsedBytes": 74731692,
"domNodes": 77,
"jsHeapTotalBytes": 20586496,
"scriptDurationMs": 22.351999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 702.3220000000379,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.339,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.273,
"heapDeltaBytes": -12174200,
"heapUsedBytes": 55442976,
"domNodes": 16,
"jsHeapTotalBytes": 20848640,
"scriptDurationMs": 66.637,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 625.5190000000539,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.438999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.049,
"heapDeltaBytes": -12170432,
"heapUsedBytes": 55321688,
"domNodes": 18,
"jsHeapTotalBytes": 21110784,
"scriptDurationMs": 61.67399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.2669999999857,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.603999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.35,
"heapDeltaBytes": 6597912,
"heapUsedBytes": 65073984,
"domNodes": -267,
"jsHeapTotalBytes": 4530176,
"scriptDurationMs": 109.699,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2030.589999999961,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.436000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.0229999999999,
"heapDeltaBytes": 6526832,
"heapUsedBytes": 65092628,
"domNodes": -268,
"jsHeapTotalBytes": 4268032,
"scriptDurationMs": 104.551,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2197.554000000025,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.579999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1342.822,
"heapDeltaBytes": 4341544,
"heapUsedBytes": 63984940,
"domNodes": -270,
"jsHeapTotalBytes": 5259264,
"scriptDurationMs": 487.313,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2158.0109999999877,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.251,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1272.1039999999998,
"heapDeltaBytes": -6541212,
"heapUsedBytes": 55803528,
"domNodes": -267,
"jsHeapTotalBytes": 6365184,
"scriptDurationMs": 430.337,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3166.9769999999744,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.293999999999997,
"layouts": 60,
"layoutDurationMs": 7.188,
"taskDurationMs": 1476.6680000000001,
"heapDeltaBytes": 22930596,
"heapUsedBytes": 84164628,
"domNodes": 12,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 530.804,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3247.7830000000267,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.750999999999998,
"layouts": 60,
"layoutDurationMs": 7.5569999999999995,
"taskDurationMs": 1520.712,
"heapDeltaBytes": 1896848,
"heapUsedBytes": 63161772,
"domNodes": -271,
"jsHeapTotalBytes": 7938048,
"scriptDurationMs": 540.913,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.2870000000062,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.17,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 692.735,
"heapDeltaBytes": 6317364,
"heapUsedBytes": 68653764,
"domNodes": -269,
"jsHeapTotalBytes": 4792320,
"scriptDurationMs": 113.572,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.3589999999376,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.643999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.8459999999999,
"heapDeltaBytes": 4511836,
"heapUsedBytes": 64581532,
"domNodes": -269,
"jsHeapTotalBytes": 5840896,
"scriptDurationMs": 106.60300000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.0649999999669,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.254000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.618,
"heapDeltaBytes": -11821676,
"heapUsedBytes": 55681096,
"domNodes": 20,
"jsHeapTotalBytes": 21897216,
"scriptDurationMs": 118.776,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.4570000000149,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.245999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.916,
"heapDeltaBytes": -11774640,
"heapUsedBytes": 55889064,
"domNodes": 20,
"jsHeapTotalBytes": 21897216,
"scriptDurationMs": 121.05999999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2016.5489999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.218000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.84599999999995,
"heapDeltaBytes": 3639424,
"heapUsedBytes": 71158136,
"domNodes": 16,
"jsHeapTotalBytes": 21110784,
"scriptDurationMs": 16.922,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.9940000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.888000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.5569999999999,
"heapDeltaBytes": -20272528,
"heapUsedBytes": 47108324,
"domNodes": -264,
"jsHeapTotalBytes": 21762048,
"scriptDurationMs": 14.393999999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.5449999999914,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.49,
"layouts": 16,
"layoutDurationMs": 3.79,
"taskDurationMs": 827.6719999999999,
"heapDeltaBytes": -20884488,
"heapUsedBytes": 46582624,
"domNodes": -266,
"jsHeapTotalBytes": 20713472,
"scriptDurationMs": 92.82700000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1746.7589999999973,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.586999999999996,
"layouts": 16,
"layoutDurationMs": 3.992,
"taskDurationMs": 799.371,
"heapDeltaBytes": -18723068,
"heapUsedBytes": 48884924,
"domNodes": -265,
"jsHeapTotalBytes": 21499904,
"scriptDurationMs": 92.52499999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0400000000272,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.555,
"layouts": 13,
"layoutDurationMs": 12.743,
"taskDurationMs": 918.62,
"heapDeltaBytes": 29048048,
"heapUsedBytes": 95696720,
"domNodes": 13673,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 35.269999999999996,
"eventListeners": 2371,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8303.58199999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4465.071,
"heapDeltaBytes": 11185336,
"heapUsedBytes": 69744244,
"domNodes": -267,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 1412.3700000000001,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8386.060999999927,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.842,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4582.6140000000005,
"heapDeltaBytes": 393272,
"heapUsedBytes": 59466192,
"domNodes": -269,
"jsHeapTotalBytes": 6103040,
"scriptDurationMs": 1415.683,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17260.886000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17214.694,
"heapDeltaBytes": -46441796,
"heapUsedBytes": 166825460,
"domNodes": -8311,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 562.6750000000001,
"eventListeners": -16382,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17236.323999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17214.201,
"heapDeltaBytes": -44837648,
"heapUsedBytes": 165351228,
"domNodes": -8311,
"jsHeapTotalBytes": -13570048,
"scriptDurationMs": 578.3249999999999,
"eventListeners": -16380,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20875.966000000004,
"styleRecalcs": 146,
"styleRecalcDurationMs": 17.373000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20831.851,
"heapDeltaBytes": -64278464,
"heapUsedBytes": 163849004,
"domNodes": -8315,
"jsHeapTotalBytes": -16191488,
"scriptDurationMs": 900.237,
"eventListeners": -16376,
"totalBlockingTimeMs": 216,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21720.146999999997,
"styleRecalcs": 153,
"styleRecalcDurationMs": 20.25900000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21670.882,
"heapDeltaBytes": -69305604,
"heapUsedBytes": 155600468,
"domNodes": -8311,
"jsHeapTotalBytes": -17240064,
"scriptDurationMs": 951.5319999999999,
"eventListeners": -16378,
"totalBlockingTimeMs": 407,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 477.0300000000134,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.375999999999998,
"layouts": 3,
"layoutDurationMs": 1.09,
"taskDurationMs": 122.244,
"heapDeltaBytes": -15708160,
"heapUsedBytes": 50910384,
"domNodes": 154,
"jsHeapTotalBytes": 8790016,
"scriptDurationMs": 11.556000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 486.26500000000306,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.877000000000006,
"layouts": 2,
"layoutDurationMs": 0.325,
"taskDurationMs": 115.43999999999998,
"heapDeltaBytes": -16123876,
"heapUsedBytes": 50444280,
"domNodes": 117,
"jsHeapTotalBytes": 8265728,
"scriptDurationMs": 10.51,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
📝 WalkthroughWalkthroughUpdated signup dialog and cloud onboarding presentation styles, including spacing, typography, themed controls, links, PrimeVue messages, input surfaces, authentication buttons, download-link hover states, and responsive logo sizing. Authentication logic and form submission behavior remain unchanged. ChangesSignup dialog styling
Cloud onboarding presentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Suggested reviewers: Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/cloud/onboarding/CloudLoginView.vue`:
- Around line 164-169: Replace the scoped .p-message-warn override in
CloudLoginView.vue with Tailwind classes applied directly to the PrimeVue
Message component, or use the existing reusable PrimeVue theming/pass-through
mechanism. Remove the component-level style block and preserve the current
warning background, border, and text colors.
- Around line 166-168: Remove blanket !important from the auth-theme CSS
overrides, replacing it with non-important base selectors and explicit
invalid-state selectors or supported theming hooks. Update CloudLoginView.vue
lines 166-168 warning styles; CloudSignupView.vue lines 213-215 base input
styles and lines 225-243 password, checkbox, and warning styles; preserve
.p-invalid styling in CloudSignInForm.vue lines 118-148 and
CloudForgotPasswordView.vue lines 125-140 so PrimeVue invalid borders remain
visible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e474528b-7e7d-4e80-adca-2837087e716f
📒 Files selected for processing (9)
src/components/dialog/content/signin/PasswordFields.vuesrc/components/dialog/content/signin/SignUpForm.vuesrc/platform/cloud/onboarding/CloudForgotPasswordView.vuesrc/platform/cloud/onboarding/CloudLoginView.vuesrc/platform/cloud/onboarding/CloudSignupView.vuesrc/platform/cloud/onboarding/components/CloudHeroCarousel.vuesrc/platform/cloud/onboarding/components/CloudSignInForm.vuesrc/platform/cloud/onboarding/components/CloudTemplate.vuesrc/platform/cloud/onboarding/components/OAuthLayoutView.vue
| <style scoped> | ||
| :deep(.p-message-warn) { | ||
| background: rgb(from var(--color-gold-500) r g b / 0.12) !important; | ||
| border-color: rgb(from var(--color-gold-500) r g b / 0.3) !important; | ||
| color: var(--color-gold-500) !important; | ||
| } |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Avoid introducing a new scoped <style> block for this override.
Prefer Tailwind classes on Message or a reusable PrimeVue theming/pass-through hook. As per coding guidelines: “Use Tailwind 4 for styling and avoid adding <style> blocks in Vue components.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/cloud/onboarding/CloudLoginView.vue` around lines 164 - 169,
Replace the scoped .p-message-warn override in CloudLoginView.vue with Tailwind
classes applied directly to the PrimeVue Message component, or use the existing
reusable PrimeVue theming/pass-through mechanism. Remove the component-level
style block and preserve the current warning background, border, and text
colors.
Source: Coding guidelines
| background: rgb(from var(--color-gold-500) r g b / 0.12) !important; | ||
| border-color: rgb(from var(--color-gold-500) r g b / 0.3) !important; | ||
| color: var(--color-gold-500) !important; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Locate files and relevant selectors"
for f in \
src/platform/cloud/onboarding/CloudLoginView.vue \
src/platform/cloud/onboarding/CloudSignupView.vue \
src/platform/cloud/onboarding/components/CloudSignInForm.vue \
src/platform/cloud/onboarding/CloudForgotPasswordView.vue
do
if [ -f "$f" ]; then
echo "--- $f ($(wc -l < "$f") lines) ---"
rg -n "p-input|p-password|p-checkbox|p-message|p-invalid|important|color-primary-comfy-canvas|color-gold|color-coral|color-jade" "$f" || true
else
echo "missing: $f"
fi
done
echo "--- style.css color aliases/context ---"
fd -a 'style\.css$' . | sed 's#^\./##' | while read -r f; do
echo "--- $f ---"
rg -n "color-primary-comfy-canvas|color-gold-500|color-coral-500|color-jade-400|:root|:p-invalid|p-invalid" "$f" || true
done
echo "--- search for existing p-invalid styling in repo (non-git tracked artifacts ignored) ---"
git ls-files | grep -E '\.(vue|scss|sass|css|ts)$' | xargs rg -n "p-invalid|\.invalid|is-invalid|:invalid" | head -200Repository: Comfy-Org/ComfyUI_frontend
Length of output: 16961
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "--- CloudSignInForm.vue relevant sections ---"
sed -n '1,70p' src/platform/cloud/onboarding/components/CloudSignInForm
sed -n '105,155p' src/platform/cloud/onboarding/components/CloudSignInForm
echo "--- CloudForgotPasswordView.vue relevant sections ---"
sed -n '20,55p' src/platform/cloud/onboarding/CloudForgotPasswordView
sed -n '115,145p' src/platform/cloud/onboarding/CloudForgotPasswordView
echo "--- CloudSignupView.vue relevant sections ---"
sed -n '20,50p' src/platform/cloud/onboarding/CloudSignupView
sed -n '205,245p' src/platform/cloud/onboarding/CloudSignupView
echo "--- PrimeVue CSS source availability and p-invalid declarations ---"
git ls-files | grep -E 'node_modules/@primevue|primevue|theme|primeflex' | head -100 || true
rg -n --hidden --glob '!node_modules/**' '\b\.p-invalid\b|\.p-?inputtext.p-invalid|border-color|outline' packages/src node_modules 2>/dev/null | head -200 || true
echo "--- CSS parser simulation for target rules ---"
python3 - <<'PY'
from pathlib import Path
import re
for p in [
'src/platform/cloud/onboarding/CloudLoginView.vue',
'src/platform/cloud/onboarding/CloudSignupView.vue',
'src/platform/cloud/onboarding/components/CloudSignInForm.vue',
'src/platform/cloud/onboarding/CloudForgotPasswordView.vue',
'packages/design-system/src/css/style.css',
]:
text = Path(p).read_text()
print(f'--- {p} ---')
for sel in ['.p-inputtext', '.p-password input', '.p-invalid', '.p-message-warn', '.p-message-error', '.p-message-success', '.p-checkbox-checked .p-checkbox-box']:
idx = text.find(sel)
if idx != -1:
start = max(0, text.rfind('}', 0, idx))
end = text.find('}', idx + len(sel))
print(text[start:end].strip())
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 310
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "--- CloudSignInForm.vue relevant sections ---"
sed -n '1,70p' src/platform/cloud/onboarding/components/CloudSignInForm.vue
sed -n '105,155p' src/platform/cloud/onboarding/components/CloudSignInForm.vue
echo "--- CloudSignupView.vue relevant sections ---"
sed -n '20,50p' src/platform/cloud/onboarding/CloudSignupView.vue
sed -n '205,245p' src/platform/cloud/onboarding/CloudSignupView.vue
echo "--- CSS parser simulation for target rules ---"
python3 - <<'PY'
from pathlib import Path
import re
paths = [
'src/platform/cloud/onboarding/CloudLoginView.vue',
'src/platform/cloud/onboarding/CloudSignupView.vue",
'src/platform/cloud/onboarding/components/CloudSignInForm.vue',
'src/platform/cloud/onboarding/CloudForgotPasswordView.vue',
]
for path in paths:
text = Path(path).read_text()
print(f'--- {path} ---')
for selector in ['.p-inputtext', '.p-password input', '.p-invalid', '.p-message-warn', '.p-message-error', '.p-message-success', '.p-checkbox-checked .p-checkbox-box']:
idx = text.find(selector)
if idx != -1:
start = max(0, text.rfind('}', 0, idx))
end = text.find('}', idx + len(selector))
block = text[start:end].strip()
important = ' !important' in block
print(f'selector={selector} important={important}')
print(block)
PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 6221
Remove blanket !important from the auth-theme overrides.
These declarations violate the repository styling rule and can suppress PrimeVue invalid borders when :invalid/p-invalid is applied to the auth inputs. Use non-important base selectors plus explicit invalid-state selectors or supported theming hooks.
src/platform/cloud/onboarding/CloudLoginView.vue#L166-L168: replace warning-message forced overrides.src/platform/cloud/onboarding/CloudSignupView.vue#L213-L215: replace the base input override.src/platform/cloud/onboarding/CloudSignupView.vue#L225-L243: replace password, checkbox, and warning overrides.src/platform/cloud/onboarding/components/CloudSignInForm.vue#L118-L148: preserve.p-invalidstyling.src/platform/cloud/onboarding/CloudForgotPasswordView.vue#L125-L140: preserve the reset field’s invalid styling.
📍 Affects 4 files
src/platform/cloud/onboarding/CloudLoginView.vue#L166-L168(this comment)src/platform/cloud/onboarding/CloudSignupView.vue#L213-L215src/platform/cloud/onboarding/CloudSignupView.vue#L225-L243src/platform/cloud/onboarding/components/CloudSignInForm.vue#L118-L148src/platform/cloud/onboarding/CloudForgotPasswordView.vue#L125-L140
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/cloud/onboarding/CloudLoginView.vue` around lines 166 - 168,
Remove blanket !important from the auth-theme CSS overrides, replacing it with
non-important base selectors and explicit invalid-state selectors or supported
theming hooks. Update CloudLoginView.vue lines 166-168 warning styles;
CloudSignupView.vue lines 213-215 base input styles and lines 225-243 password,
checkbox, and warning styles; preserve .p-invalid styling in CloudSignInForm.vue
lines 118-148 and CloudForgotPasswordView.vue lines 125-140 so PrimeVue invalid
borders remain visible.
Source: Coding guidelines
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #14086 +/- ##
==========================================
- Coverage 78.85% 78.85% -0.01%
==========================================
Files 1698 1698
Lines 110220 110219 -1
Branches 34624 34623 -1
==========================================
- Hits 86911 86909 -2
+ Misses 22712 22708 -4
- Partials 597 602 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing — superseded. The cloud auth screens were rebuilt in #14694–#14698 (merged 2026-08-04/05), which rewrote 7 of the 9 files here, and June is taking this area forward. The only parts that don't overlap with the merged redesign are the form spacing tweaks in |
ELI5
The Cloud login, signup, and forgot-password screens are supposed to look like a sleek dark app, but several pieces (buttons, borders, links, warning banners) were secretly still wearing their light-mode/desktop-app clothes underneath, so they showed up as mismatched grey or pastel blobs instead of blending into the dark background. This PR strips off those leftover light-mode styles and makes every screen in the flow consistently dark, flat, and legible.
Summary
azure-600) and brand-yellow link colors with the plain canvas text color + underline, so links read as "clickable" without clashing with the dark background; surrounding plain text is dimmed slightly for contrastMessagebanners (previously near-opaque pastel light-mode backgrounds) to translucent, on-brand tinted banners (gold/coral/jade) with a subtle borderfont-semibold; fixed the "Sign up" submit button rendering at a smaller font size than its siblingsTest plan
/cloud/login(social buttons, email form, links, insecure-context warning) looks correct in both collapsed and email-form states/cloud/signup(social buttons, email form with free-tier/China warnings, links) looks correct/cloud/forgot-password(email input, Send reset link, Back to login, success message)