Repository navigation
fix(design-system): correct brand yellow and consume tokens - #14484
christian-byrne wants to merge 14 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.7 MB gzip 🔴 +12.5 kBDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.74 kB) • 🟢 -8 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.42 MB) • 🔴 +3.34 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • 🟢 -9 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • 🟢 -1 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.59 MB) • 🔴 +6.11 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 559 kB (baseline 560 kB) • 🟢 -1.24 kBHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 15 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • 🔴 +34.4 kBBundles that do not match a named category
Status: 112 added / 112 removed / 184 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T03:10:45.479Z",
"gitSha": "a3c6d2fe260415938d3423855b8e499a805df192",
"branch": "glary/design-system-brand-yellow-f2ff59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1995.051999999987,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.928000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.356,
"heapDeltaBytes": 74716,
"heapUsedBytes": 69928188,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.1930000000000005,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2003.0040000000326,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.111,
"heapDeltaBytes": 5432364,
"heapUsedBytes": 76246456,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.102000000000002,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.2519999999731,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.180999999999997,
"layouts": 14,
"layoutDurationMs": 2.7590000000000003,
"taskDurationMs": 582.495,
"heapDeltaBytes": -8501400,
"heapUsedBytes": 61887824,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 84.112,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.6400000000503,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.798,
"layouts": 14,
"layoutDurationMs": 2.992,
"taskDurationMs": 611.099,
"heapDeltaBytes": 6389776,
"heapUsedBytes": 77173928,
"domNodes": -281,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 93.076,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.2310000000152,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.429,
"layouts": 6,
"layoutDurationMs": 1.132,
"taskDurationMs": 267.19800000000004,
"heapDeltaBytes": 4739448,
"heapUsedBytes": 74777640,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.153,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.597000000007,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.752,
"layouts": 6,
"layoutDurationMs": 0.8310000000000001,
"taskDurationMs": 244.21599999999998,
"heapDeltaBytes": 5109932,
"heapUsedBytes": 75766844,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.562999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 526.61599999999,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.465,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.028,
"heapDeltaBytes": -8118964,
"heapUsedBytes": 62531896,
"domNodes": 24,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 99.569,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 516.6380000000572,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.055,
"heapDeltaBytes": -8127324,
"heapUsedBytes": 62619600,
"domNodes": 20,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 98.283,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2031.154000000015,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.620999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.65700000000004,
"heapDeltaBytes": 10533348,
"heapUsedBytes": 85770260,
"domNodes": -269,
"jsHeapTotalBytes": -1163264,
"scriptDurationMs": 24.416999999999994,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2018.9980000000105,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.867999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.16,
"heapDeltaBytes": -14626768,
"heapUsedBytes": 87117088,
"domNodes": -263,
"jsHeapTotalBytes": -339968,
"scriptDurationMs": 20.352,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2073.1759999999895,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.858000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1129.207,
"heapDeltaBytes": 20743936,
"heapUsedBytes": 87089360,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 541.222,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2113.849000000073,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.588,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1049.351,
"heapDeltaBytes": 23249472,
"heapUsedBytes": 88931136,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 477.799,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3171.318000000042,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.906,
"layouts": 60,
"layoutDurationMs": 13.168,
"taskDurationMs": 1334.879,
"heapDeltaBytes": 9089584,
"heapUsedBytes": 76463540,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 579.72,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3079.6289999999544,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.983,
"layouts": 60,
"layoutDurationMs": 9.108999999999998,
"taskDurationMs": 1100.422,
"heapDeltaBytes": 8530480,
"heapUsedBytes": 75901980,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 462.45599999999996,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2174.65100000004,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.165,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1301.561,
"heapDeltaBytes": 14320648,
"heapUsedBytes": 81635320,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 612.9089999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2166.844000000083,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.675999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1176.5309999999997,
"heapDeltaBytes": 13946576,
"heapUsedBytes": 81223444,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 546.988,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.7990000000018,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.4600000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.132,
"heapDeltaBytes": 21937152,
"heapUsedBytes": 87971568,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.426,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2005.1839999999856,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.548999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.11699999999996,
"heapDeltaBytes": 22285508,
"heapUsedBytes": 88457404,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.07700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 476.09699999998156,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.127999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.896,
"heapDeltaBytes": 15131116,
"heapUsedBytes": 88089108,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 90.708,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 377.6579999999967,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.265999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 240.806,
"heapDeltaBytes": 14994076,
"heapUsedBytes": 87337036,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 81.81,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.9979999999296,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.80100000000004,
"heapDeltaBytes": -5276492,
"heapUsedBytes": 67414956,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.174,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.9659999999103,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.357000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.65999999999997,
"heapDeltaBytes": -8048192,
"heapUsedBytes": 64792348,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.009999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.8159999999743,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.263,
"layouts": 18,
"layoutDurationMs": 2.972,
"taskDurationMs": 557.5029999999999,
"heapDeltaBytes": 2861512,
"heapUsedBytes": 75735496,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 61.03699999999999,
"eventListeners": -224,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.3460000000005,
"styleRecalcs": 79,
"styleRecalcDurationMs": 21.91,
"layouts": 18,
"layoutDurationMs": 2.9839999999999995,
"taskDurationMs": 553.28,
"heapDeltaBytes": -15082280,
"heapUsedBytes": 57587736,
"domNodes": -293,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 60.925,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 865.5019999999922,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.327999999999996,
"layouts": 16,
"layoutDurationMs": 10.004,
"taskDurationMs": 654.5989999999999,
"heapDeltaBytes": 21003152,
"heapUsedBytes": 109006284,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 21.554999999999996,
"eventListeners": 2385,
"totalBlockingTimeMs": 101,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8146.162000000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.12,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4159.152000000001,
"heapDeltaBytes": -11335548,
"heapUsedBytes": 89407072,
"domNodes": -265,
"jsHeapTotalBytes": -901120,
"scriptDurationMs": 1817.399,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8151.944000000071,
"styleRecalcs": 251,
"styleRecalcDurationMs": 24.353,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3717.544,
"heapDeltaBytes": -10307560,
"heapUsedBytes": 90765792,
"domNodes": -261,
"jsHeapTotalBytes": -1687552,
"scriptDurationMs": 1638.806,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12004.071000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11208.394999999999,
"heapDeltaBytes": -31032468,
"heapUsedBytes": 179223420,
"domNodes": -6548,
"jsHeapTotalBytes": -8355840,
"scriptDurationMs": 178.52599999999998,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 11663.61799999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10712.229,
"heapDeltaBytes": -26486300,
"heapUsedBytes": 174541636,
"domNodes": -6548,
"jsHeapTotalBytes": -7380992,
"scriptDurationMs": 172.43499999999997,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14012.417000000027,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.547000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13358.253999999999,
"heapDeltaBytes": -30754760,
"heapUsedBytes": 183130380,
"domNodes": -6548,
"jsHeapTotalBytes": -8941568,
"scriptDurationMs": 698.927,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12978.044999999951,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.83200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12419.534,
"heapDeltaBytes": -30978516,
"heapUsedBytes": 182881208,
"domNodes": -6548,
"jsHeapTotalBytes": -9465856,
"scriptDurationMs": 689.201,
"eventListeners": -7473,
"totalBlockingTimeMs": 46,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3978.488000000084,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.40400000000001,
"layouts": 20,
"layoutDurationMs": 31.42299999999999,
"taskDurationMs": 3830.66,
"heapDeltaBytes": -33241828,
"heapUsedBytes": 176572444,
"domNodes": -6548,
"jsHeapTotalBytes": 6369280,
"scriptDurationMs": 68.62,
"eventListeners": -7475,
"totalBlockingTimeMs": 101,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3874.0470000000187,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.99399999999999,
"layouts": 20,
"layoutDurationMs": 31.955,
"taskDurationMs": 3780.2830000000004,
"heapDeltaBytes": -25512752,
"heapUsedBytes": 176024728,
"domNodes": -6548,
"jsHeapTotalBytes": 10203136,
"scriptDurationMs": 62.86800000000001,
"eventListeners": -7475,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5928.168000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5388.380999999999,
"heapDeltaBytes": 8044168,
"heapUsedBytes": 176746280,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 72.70600000000005,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5831.389000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5396.286,
"heapDeltaBytes": 6785704,
"heapUsedBytes": 187234832,
"domNodes": 0,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 74.27499999999998,
"eventListeners": 14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 430.0420000000713,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.884,
"layouts": 3,
"layoutDurationMs": 1.124,
"taskDurationMs": 79.085,
"heapDeltaBytes": 4904224,
"heapUsedBytes": 73490612,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.456000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 435.3560000000698,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.190999999999995,
"layouts": 3,
"layoutDurationMs": 1.323,
"taskDurationMs": 74.6,
"heapDeltaBytes": 4906656,
"heapUsedBytes": 72978836,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.036000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-14484.vercel.app This commit: https://website-frontend-o9sc7oi9b-comfyui.vercel.app Last updated: 2026-09-04T03:03:13Z for |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR centralizes brand colors and fonts in design-system tokens. It adds browser-safe token readers and brand consistency tests. Website illustrations, forms, canvas rendering, charts, onboarding views, and content styling now consume shared tokens. ChangesDesign-system token adoption
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
Full details: Description checkExplanation The description clearly explains the brand-yellow update, token-consumption changes, deliberate literals, verification results, known test timeout, and screenshots. It does not use every template heading verbatim, but it provides the required information and is sufficiently complete. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/website/src/data/brandColors.test.ts`:
- Around line 77-80: Update the SVG validation loop in the brand color test to
assert that each lowercased file does not contain the stale yellow value
`#f0ff41`, alongside the existing assertion for the current yellow value.
In `@apps/website/src/styles/global.css`:
- Line 81: Update the --color-transparency-white-t4 declaration to derive its
RGB value from the existing --color-white design-system token instead of the
hardcoded white literal, preserving the current 0.04 alpha.
In `@src/platform/cloud/onboarding/CloudForgotPasswordView.vue`:
- Line 126: Remove !important from the input background declarations in
src/platform/cloud/onboarding/CloudForgotPasswordView.vue lines 126-126,
src/platform/cloud/onboarding/CloudSignupView.vue lines 215-215, and
src/platform/cloud/onboarding/components/CloudSignInForm.vue lines 120-120.
Preserve the PrimeVue overrides by increasing selector specificity or using
scoped :deep() selectors in each component.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ee14eaa0-c0c4-450d-9e75-dbf3a6d91366
⛔ Files ignored due to path filters (2)
apps/desktop-ui/public/assets/images/comfy-brand-mark.svgis excluded by!**/*.svgpublic/assets/images/comfy-cloud-logo.svgis excluded by!**/*.svg
📒 Files selected for processing (24)
AGENTS.mdapps/website/src/components/contact/HubspotFormEmbed.vueapps/website/src/components/product/api/HeroSection.vueapps/website/src/components/product/cloud/HeroSection.vueapps/website/src/components/product/enterprise/HeroSection.vueapps/website/src/components/product/enterprise/OrchestrationSection.vueapps/website/src/components/product/local/HeroSection.vueapps/website/src/composables/useHeroLogo.tsapps/website/src/data/brandColors.test.tsapps/website/src/pages/404.astroapps/website/src/scripts/snakeGame.tsapps/website/src/styles/global.cssapps/website/src/templates/brand/BrandBackground.vueapps/website/src/templates/drops/LaunchesHeroLogo.vueapps/website/src/utils/designTokens.tspackages/design-system/src/css/_palette.csspackages/design-system/src/css/style.csssrc/components/loader/LogoComfyWaveLoader.stories.tssrc/components/ui/chart/useChart.tssrc/platform/cloud/onboarding/CloudForgotPasswordView.vuesrc/platform/cloud/onboarding/CloudSignupView.vuesrc/platform/cloud/onboarding/components/CloudSignInForm.vuesrc/platform/cloud/subscription/components/SubscriptionRequiredDialogContent.vuesrc/platform/updates/components/WhatsNewPopup.vue
💤 Files with no reviewable changes (1)
- packages/design-system/src/css/style.css
|
Thanks — the comment currently on the PR is the auto-generated "Currently processing new changes in this PR" placeholder (Run ID I did use the wait productively on the one gate I had not run locally, since it is the most relevant one to a colour refactor. Website visual snapshot suite
The viewport pattern was the tell: a colour change would shift The same 8 fail identically on a clean base — pre-existing baseline drift, most likely because the committed For the colour question specifically, the evidence in the PR body is stronger than these snapshots anyway — token-colour pixel counts are unchanged across nine pages ( Happy to work through the real review once it posts. |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #14484 +/- ##
==========================================
+ Coverage 81.16% 81.17% +0.01%
==========================================
Files 2460 2461 +1
Lines 126662 126682 +20
Branches 31944 33762 +1818
==========================================
+ Hits 102801 102832 +31
+ Misses 23345 23334 -11
Partials 516 516
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/website/src/data/brandColors.test.ts`:
- Around line 26-33: The yellowsIn helper function only extracts six-digit
hexadecimal colors and ignores other color syntaxes like three-digit hex (`#fff`)
or RGB values, causing the test at line 87 to pass incorrectly when extra
yellows are present in alternate formats. Determine which color syntaxes the SVG
asset contract allows, then either update the regex pattern and parsing logic in
yellowsIn to extract all valid color formats, or add explicit validation to
assert the SVG contains only six-digit hex colors. Add negative-control test
cases that verify yellowsIn correctly handles SVG inputs containing shorthand
hex codes and RGB color values to ensure edge cases are properly covered.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2fe0df99-9d46-4cbc-952e-f620bebf3f6d
📒 Files selected for processing (5)
apps/website/src/data/brandColors.test.tsapps/website/src/styles/global.csssrc/platform/cloud/onboarding/CloudForgotPasswordView.vuesrc/platform/cloud/onboarding/CloudSignupView.vuesrc/platform/cloud/onboarding/components/CloudSignInForm.vue
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/website/src/data/brandColors.test.ts`:
- Around line 154-187: Update the brand color test fixtures around yellowsIn to
derive the active Comfy Yellow and Comfy Ink values from the design-system token
source instead of hardcoding them, including the expected active-color results.
Preserve the existing stale-color literals as deliberate negative controls, and
keep the unreadable-colour assertions unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b208f546-7306-4053-ae21-fde01f6b6176
📒 Files selected for processing (1)
apps/website/src/data/brandColors.test.ts
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/website/src/data/brandColors.test.ts (1)
169-204: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAdd missing and malformed color-input cases.
The helper tests cover supported hex and RGB forms, non-yellow values, and unsupported syntax. They do not cover empty input, elements without color attributes, or malformed color literals. Add behavioral assertions for
yellowsIn()andunreadableColoursIn()so invalid color data cannot pass silently.As per path instructions,
.agents/checks/test-quality.mdrequires coverage for missing, empty, invalid, and unsupported color values.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/website/src/data/brandColors.test.ts` around lines 169 - 204, Add tests around yellowsIn and unreadableColoursIn covering empty input, elements without fill or stroke color attributes, malformed color literals, and unsupported color syntax. Assert that missing or empty color data produces no yellow matches, while malformed and unsupported literals are reported as unreadable rather than ignored, preserving the existing valid-color behavior.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@apps/website/src/data/brandColors.test.ts`:
- Around line 169-204: Add tests around yellowsIn and unreadableColoursIn
covering empty input, elements without fill or stroke color attributes,
malformed color literals, and unsupported color syntax. Assert that missing or
empty color data produces no yellow matches, while malformed and unsupported
literals are reported as unreadable rather than ignored, preserving the existing
valid-color behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 13686cc7-063d-4082-ad2f-2e7049191045
📒 Files selected for processing (1)
apps/website/src/data/brandColors.test.ts
|
Thanks for the approval. I took the outside-diff suggestion anyway, because chasing it turned up a real bug in the helper rather than just a gap in coverage. Pushed as
None of the nine covered assets use
The boundary coverage you asked for came along with it:
One thing I did skip: I didn't add a case for named colours ( Website suite now 288 passing. |
|
CodeRabbit has approved with no outstanding findings. All four rounds are addressed across commits Two corrections to the PR description above — it was written before the review rounds and now understates the branch:
The rest of the description still holds. Everything else about the production changes is unchanged since Where the review landed thingsWorth recording, since the diff alone doesn't show it. Rounds 2–4 were all about the guard test rather than the refactor, and each closed a way it could have failed silently:
Round 4 is the one I'd flag to a human reviewer: it was raised as a coverage gap, but investigating it exposed an actual defect. No covered asset uses Still wanting a human decision
Icon tokens stay a separate change: five icons the package already ships are duplicated in |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
347cc09
|
Addressed the review — one structural note, since it moves a file the comments are anchored to.
Docs split: the Spelling: Americanised throughout Also pinned the two brand SVGs this PR touched outside the website — Verified: website + root typecheck, Screenshots |
|
Merged The version bump is the point. The merge conflict was a real one, not a textual one. --color-primary-comfy-ink, --color-primary-comfy-canvas,
--color-primary-warm-white, --color-primary-warm-grayTwo of those this branch had already promoted into One unrelated fix, needed to commit at all. Also note the three cloud onboarding Gates on I resolved the outstanding threads from the last round — they had replies but no resolution, since CodeRabbit will not resolve threads authored by a bot. @DrJKL your approval was auto-dismissed by the push that followed it, so this needs a fresh look. |
33499bb to
a7475d2
Compare
|
Rebased cleanly onto current Local gates are green. Hosted checks are running; no merge action taken. Full context for agent readersPreserved the 14-commit brand-token series while moving its base from Verification on the rebased tree:
The full website run passed 1,022/1,023 tests; |
|
|
DrJKL
left a comment
There was a problem hiding this comment.
The source changes and current checks look sound. I found one non-blocking test defect: the new scan-order assertion compares a value with itself, so it cannot detect an order-dependent implementation.
The prior dismissed human review comments appear addressed. Install, root and website typechecks, changed-file format/ESLint/Stylelint, design-token tests, 908 website tests, Knip, and git diff --check passed. Added-line scans found no dark:, !important, array class merging, or listed type escapes.
The Figma MCP is not available in this review environment, and the public Figma URL did not expose the file, so I could not independently verify #f2ff59 against the live source of truth. I verified that the PR consistently aliases brand yellow to electric-400; current main still contains the old #f0ff41 value.
|
|
||
| it('reads paint attributes independently of scan order', () => { | ||
| const svg = `<path fill="gold"/><path fill="${yellow}"/><path stroke="gold"/>` | ||
| expect(unreadableColorsIn(svg)).toEqual(unreadableColorsIn(svg)) |
There was a problem hiding this comment.
This compares the result with itself, so it passes for every implementation and does not test scan-order independence. Call the helper with two differently ordered SVG inputs and compare those results, or assert each expected result directly.
Stacked on #14484. That PR stops surfaces from restating token values; this one moves the brand layer itself into the package, so there is a single file that owns every brand colour and the brand typeface. - **What**: `_brand.css` (all brand colours + both brand font tokens) and `brand-fonts.css` (the PP Formula faces). `base.css` becomes the brand surface — brand, brand fonts, shared ramps; `style.css` is that plus everything product. `apps/website/src/styles/global.css` drops the 10 brand colours, the 6 PP Formula `@font-face` blocks, both font tokens and the dead Google Fonts Inter import, keeping only site-specific values. 82 mauve stroke literals across three HeroSections, 12 PP Formula literals in `HubspotFormEmbed` and `404.astro`, and the `--brand-yellow` indirection in `style.css` are gone. - **Breaking**: `_palette.css` no longer carries brand tokens and `base.css` no longer loads Inter. Nothing consumes either today — checked. `platform` imports `_palette.css` for the neutral ramps only, and the website never used Inter (its body is `font-formula`), which is what made the Google Fonts import dead. Version bumped to `1.1.0`; platform should move its import to `base.css` when it takes the upgrade. **Why the brand yellow could drift at all.** It was declared in three places under different names, so no single change could keep them equal. The same was true of `--font-formula`, and worse: `_palette.css` said `'PP Formula', 'Inter', sans-serif` while the website said `'PP Formula', sans-serif`, and the website silently won. I kept the Inter fallback in the unified token, because the app bundles only three of the six PP Formula weights (`src/platform/cloud/onboarding/assets`) and leans on Inter for the rest. On comfy.org the fallback is inert — no Inter is served there — so rendering is unchanged on both surfaces. **The test is the part that lasts.** `brandColors.test.ts` now fails if any `--color-*` or `--font-*` token is declared in more than one of `_brand.css`, `_palette.css`, and the website's `@theme`. Documentation alone would not have prevented this; the second declaration always looks reasonable in isolation. **SVG strokes went to utility classes, not `var()`.** `stroke="#4D3762"` became `class="stroke-secondary-mauve"` rather than `stroke="var(--color-secondary-mauve)"` — substitution in SVG presentation attributes was only resolved into SVG2 in Nov 2025 and Chromium is uneven. The two occurrences inside `@keyframes` are real declarations, so those use `var()`. **Verification.** Diffed every emitted `--color-*` / `--font-*` in the built website CSS against the pre-change build: same 34 tokens, same values, only ordering differs plus the intended Inter fallback. Converted stroke counts match one-for-one in the built HTML (cloud 36, cloud/enterprise 39, download 5, zero leftover attributes). Both builds still resolve the full yellow chain to `#f2ff59`, all six PP Formula faces are present in the output, and no `fonts.googleapis` reference survives anywhere in `dist`. Gates: `lint` (0 errors), `format:check`, `typecheck`, `typecheck:website` (0 errors), `knip`, website build (581 pages), 345 website tests, 672 tests across `src/platform/cloud`, `packages/shared-frontend-utils` and `src/components/ui`. **Answers Alexis's question in-repo.** The README now says outright that the package holds two design systems, that the file is what distinguishes them, and that no naming convention reliably does — several token names predate the split. `primary-` is still overloaded across app-semantic roles and brand colours, and `plum-600` / `primary-comfy-plum` remain the same hex under two names. Renaming them is deliberately not in this PR; it is a breaking change for consumers and wants its own decision. **Deliberately left alone.** `--text-2xs` still disagrees between `style.css` (`0.625rem`) and the website (`0.6875rem`). The website's value wins on comfy.org, so aligning it is a visible type change across the site — a designer's call, not a refactor's. The duplicate-declaration test is scoped to the files `base.css` actually pulls in, so it does not paper over this.
a7475d2 to
53e1fc9
Compare
`--color-electric-400` held `#f0ff41`, the pre-2026 brand yellow. The Figma Design System and the live comfy.org both use `#f2ff59`, confirmed against the Brand Guidelines 2026 page. Correcting the token fixes every consumer of `brand-yellow` / `electric-400` at once, including the newly published `@comfyorg/design-system` package. Audit of hardcoded copies of the same color: - apps/website hand-copied `#f2ff59` into `--color-primary-comfy-yellow`; it now aliases `--color-brand-yellow`, so the site follows the package instead of holding its own copy. - The cloud onboarding views carried `#f0ff41` in `:deep(.p-checkbox-checked .p-checkbox-box)` rules. Neither view — nor anything in their subtrees — renders a PrimeVue Checkbox, and none ever did; the rules arrived wholesale in #6564. Removed as dead CSS rather than updated. - `comfy-cloud-logo.svg` and `comfy-brand-mark.svg` still filled with the old yellow, while `comfy-logo-single.svg` beside them already used the new one. Standalone assets can't read a CSS token, so the value is corrected in place. - The LogoComfyWaveLoader brand story labelled its swatches with literal hexes, one of them stale. Labels now name the tokens. AGENTS.md gains a matching rule so new code reaches for the token.
Follow-up to the brand-yellow correction. Matching a token's value is not enough — a literal that merely equals the token today drifts the day the token changes, invisibly. These call sites now read the value from @comfyorg/design-system rather than restating it. Design system: --color-primary-comfy-ink and --color-primary-comfy-canvas moved from style.css into _palette.css. They are brand colours, but they only shipped through style.css, which carries the PrimeVue and node-editor theme. base.css — the entry point marketing sites are told to import — did not expose them, so apps/website had no way to reference them and had hand-copied both. The package now serves the consumer it documents. apps/website: - global.css stops redeclaring comfy-ink/comfy-canvas and inherits them, aliases comfy-plum to plum-600, and derives transparency-ink-t80 from the ink token instead of a pre-mixed rgb(). This is the leveraged fix: every bg-/text-/fill-primary-comfy-* utility across the site now resolves through the package. - 96 illustration fills across four product heroes, OrchestrationSection and 404 became fill-*/stroke-* utilities. OrchestrationSection tiles are keyed by tone rather than by hex, since the hex doubled as a glow-map key. Its glow values stay literal on purpose — they are brighter than the fills, so deriving them from the tokens would change the visuals. - Canvas and three.js need a concrete string, so useHeroLogo, api/HeroSection and BrandBackground read the token at runtime via a new readDesignToken helper; snakeGame drops its literal fallbacks. - Gradient stop-colors and the Hubspot style map use var() directly. Frontend src/: charcoal-500 input surfaces in cloud onboarding, azure-600 on the subscribe button (its --color-accent-blue fallback never resolved — that token does not exist), --font-inter in WhatsNewPopup, and token-valued fallbacks in useChart in place of #ffffff/#8a8a8a. Three literals stay, deliberately. brandColors.ts is copyable text and the theme-color meta is parsed by the browser, so neither can hold a var(); brandColors.test.ts pins both, plus the standalone brand SVGs, to the token values so CI catches the drift instead. The minimap's #d9d9d9 is left alone: it coincidentally equals smoke-400 but is not a brand colour, and coupling it would change the minimap on the next brand tweak. Verified pixel-identical: token-colour pixel counts across nine pages are unchanged (ratios 0.986-1.002, within animation noise measured by an after-vs-after control).
draw() runs on every animation frame, so reading the token there meant two getComputedStyle calls and a parse per frame.
Three follow-ups from review. brandColors.test.ts asserted only that a brand SVG contained the current yellow, which still passes if a stale one survives on another path — exactly how #f0ff41 lingered. Generalised to assert the only yellow-family colour in the file IS the token, so any stale or near-duplicate value fails, without a denylist to maintain. Containment is implied and was dropped as redundant. global.css derived --color-transparency-white-t4 from a white literal while its sibling --color-transparency-ink-t80 three lines below derived from a token. Now reads --color-white. Renders pixel-identical: (41, 34, 47) over the ink backdrop either way, the computed form just shifts to color(srgb). Dropped !important from the three input backgrounds this branch touched. Measured it first: with the declaration demoted, the background is rgb(45, 46, 50) at rest, on hover, on focus, when filled and after blur — identical, so nothing in PrimeVue was relying on it. The remaining !important on border, box-shadow and color in those blocks predates this branch and is left alone rather than removed unverified.
yellowsIn only matched six-digit hex, so a stale yellow written as #ff0, rgb(240 255 65) or #f0ff41ff was invisible to it and the assertion passed with two yellows in the file. A guard a format change can slip past is a weak guard, which matters here because these assets cannot reference the token and this test is the only thing holding them to it. Colour literals are now parsed from 3-, 4-, 6- and 8-digit hex plus rgb()/rgba(), normalised to six-digit hex before comparison. Parsing every CSS colour syntax is unbounded, so instead of attempting it the readable set is pinned: unreadableColoursIn reports any colour literal the parser does not understand, and a new test asserts brand SVGs contain none. If an export or an SVGO pass introduces hsl() or a named colour, CI says so rather than silently skipping it. The nine covered assets use only six-digit hex and `none` today, so the contract is real. Verified against a real asset by injecting each format into favicon.svg: #fd4 -> yellows [#f2ff59, #ffdd44] fails rgb(240, 255, 65) -> yellows [#f0ff41, #f2ff59] fails #f0ff41ff -> yellows [#f0ff41, #f2ff59] fails hsl(65 100% 67%) -> colour syntax [hsl(...)] fails Five unit tests cover the same cases directly.
The helper tests hardcoded the active brand yellow and ink. That is the rule
this branch introduces, applied to its own test, and it had a real failure
mode: had the palette moved, these tests would have kept asserting the old
value and passed while validating a colour the design system no longer ships.
Active values now come from token(); the retired yellow and the synthetic
second yellow stay literal because they are the negative controls. Expected
arrays are built with .sort() so a token whose value sorts differently does
not break them.
Demonstrated by moving --color-electric-400 to #f5ff70:
yellowsIn (5 tests) pass - they follow the token
brand palette table fail - brandColors.ts still holds the old hex
standalone brand SVGs fail - assets still hold the old fill
The helper keeps working, and the two drift detectors fire, which is the
split the file is for.
Also moves the comfy-ink two-tone test back into the brand-colours describe.
A stray closing brace from the previous commit had left it nested inside
describe('yellowsIn').
Chasing the request for malformed-input coverage turned up a real bug in the helper rather than just a gap in the tests. coloursIn scanned the raw markup, so an SVG reference like url(#ffee00) was matched as a six-digit hex and counted as a colour: <path fill="#f2ff59"/><path fill="url(#ffee00)"/> yellowsIn -> [ '#f2ff59', '#ffee00' ] None of the covered assets use url() today, so nothing was failing, but Figma and Illustrator emit it for gradients and clip paths — the first re-export with a gradient whose id happened to look like hex would have failed the brand-yellow check for a colour that was never in the file. A guard that cries wolf gets deleted, so this matters as much as a miss. url(...) is now stripped before colour scanning, and the case is pinned: reverting the strip fails the new test with the exact output above. Boundary coverage added alongside it — empty input, markup with no colour attribute, path data, fill="none", and a malformed five-digit hex, which is reported as unreadable rather than silently skipped.
…n-system - move readDesignToken/readDesignTokenRgba into @comfyorg/shared-frontend-utils so the chart, the website canvases and the snake game read tokens the same way - readDesignToken takes fallback token names, so a fallback stays a token - extract DesignTokenName, name the regex matches in parseRgb - shrink the AGENTS.md rule to three lines and document consuming tokens in the design-system README - American spellings in brandColors.test.ts
--site-bg and --site-bg-soft already read tokens; --site-border-subtle restated white beside them.
_palette.css declares white-t8 and white-t20 with the same values, so the site @theme was shadowing them. Tailwind still emits both utilities from the package.
…bsite tests in CI The brand-colour assertions read --color-electric-400, the primitive, while everything downstream consumes --color-brand-yellow. Repointing the semantic alias would have left the suite green while every standalone SVG drifted, so token() now follows var() chains and the assertions name the semantic token. The suite that guards this never ran in CI: root vitest only includes src, packages and scripts, and the website workflow built without testing.
Stacked on #14484. That PR stops surfaces from restating token values; this one moves the brand layer itself into the package, so there is a single file that owns every brand colour and the brand typeface. - **What**: `_brand.css` (all brand colours + both brand font tokens) and `brand-fonts.css` (the PP Formula faces). `base.css` becomes the brand surface — brand, brand fonts, shared ramps; `style.css` is that plus everything product. `apps/website/src/styles/global.css` drops the 10 brand colours, the 6 PP Formula `@font-face` blocks, both font tokens and the dead Google Fonts Inter import, keeping only site-specific values. 82 mauve stroke literals across three HeroSections, 12 PP Formula literals in `HubspotFormEmbed` and `404.astro`, and the `--brand-yellow` indirection in `style.css` are gone. - **Breaking**: `_palette.css` no longer carries brand tokens and `base.css` no longer loads Inter. Nothing consumes either today — checked. `platform` imports `_palette.css` for the neutral ramps only, and the website never used Inter (its body is `font-formula`), which is what made the Google Fonts import dead. Version bumped to `1.1.0`; platform should move its import to `base.css` when it takes the upgrade. **Why the brand yellow could drift at all.** It was declared in three places under different names, so no single change could keep them equal. The same was true of `--font-formula`, and worse: `_palette.css` said `'PP Formula', 'Inter', sans-serif` while the website said `'PP Formula', sans-serif`, and the website silently won. I kept the Inter fallback in the unified token, because the app bundles only three of the six PP Formula weights (`src/platform/cloud/onboarding/assets`) and leans on Inter for the rest. On comfy.org the fallback is inert — no Inter is served there — so rendering is unchanged on both surfaces. **The test is the part that lasts.** `brandColors.test.ts` now fails if any `--color-*` or `--font-*` token is declared in more than one of `_brand.css`, `_palette.css`, and the website's `@theme`. Documentation alone would not have prevented this; the second declaration always looks reasonable in isolation. **SVG strokes went to utility classes, not `var()`.** `stroke="#4D3762"` became `class="stroke-secondary-mauve"` rather than `stroke="var(--color-secondary-mauve)"` — substitution in SVG presentation attributes was only resolved into SVG2 in Nov 2025 and Chromium is uneven. The two occurrences inside `@keyframes` are real declarations, so those use `var()`. **Verification.** Diffed every emitted `--color-*` / `--font-*` in the built website CSS against the pre-change build: same 34 tokens, same values, only ordering differs plus the intended Inter fallback. Converted stroke counts match one-for-one in the built HTML (cloud 36, cloud/enterprise 39, download 5, zero leftover attributes). Both builds still resolve the full yellow chain to `#f2ff59`, all six PP Formula faces are present in the output, and no `fonts.googleapis` reference survives anywhere in `dist`. Gates: `lint` (0 errors), `format:check`, `typecheck`, `typecheck:website` (0 errors), `knip`, website build (581 pages), 345 website tests, 672 tests across `src/platform/cloud`, `packages/shared-frontend-utils` and `src/components/ui`. **Answers Alexis's question in-repo.** The README now says outright that the package holds two design systems, that the file is what distinguishes them, and that no naming convention reliably does — several token names predate the split. `primary-` is still overloaded across app-semantic roles and brand colours, and `plum-600` / `primary-comfy-plum` remain the same hex under two names. Renaming them is deliberately not in this PR; it is a breaking change for consumers and wants its own decision. **Deliberately left alone.** `--text-2xs` still disagrees between `style.css` (`0.625rem`) and the website (`0.6875rem`). The website's value wins on comfy.org, so aligning it is a visible type change across the site — a designer's call, not a refactor's. The duplicate-declaration test is scoped to the files `base.css` actually pulls in, so it does not paper over this.
53e1fc9 to
5e1c8ea
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|




PR Created by the Glary-Bot Agent
1. The brand yellow was stale
--color-electric-400held#f0ff41, the pre-2026 brand yellow. The Figma Design System and the live comfy.org both use#f2ff59— confirmed against Brand Guidelines 2026.#f0ff41came from the old branding in use when comfy.org was first built.Also fixed alongside it: the two brand marks still filled with the old yellow (
comfy-cloud-logo.svg,comfy-brand-mark.svg— notecomfy-logo-single.svgbeside the first already used the new one), and theLogoComfyWaveLoaderstory whose swatch labels were literal hexes, one of them stale. Labels now name tokens.The
:deep(.p-checkbox-checked .p-checkbox-box)rules inCloudSignupView/CloudSignInFormalso carried#f0ff41, but no PrimeVueCheckboxexists in either subtree andgit log -Sshows none ever did — they arrived wholesale with the onboarding mainification in #6564. Removed as dead CSS rather than updated.2. Matching the value isn't enough
The drift only existed because copies existed. So the second commit makes the call sites read the value from the package rather than restate it. An audit script matched every hex/rgb literal in the frontend, website and desktop-ui against the package's palette vocabulary: 123 convertible duplications across 20 files, now 6, each of the remaining ones deliberate.
The design system couldn't serve its own consumer.
--color-primary-comfy-inkand--color-primary-comfy-canvasare brand colours but shipped only throughstyle.css, which carries the PrimeVue and node-editor theme.base.css— the entry point marketing sites are told to import — didn't expose them, soapps/websitehad no way to reference them and had hand-copied both. Moved into_palette.css.The leveraged fix.
global.cssstops redeclaringcomfy-ink/comfy-canvasand inherits them, aliasescomfy-plumtoplum-600, and derivestransparency-ink-t80from the ink token instead of a pre-mixedrgb(33 25 39 / 0.8). Everybg-/text-/fill-primary-comfy-*utility across the site now resolves through the package.OrchestrationSection,404)fill-*/stroke-*utilitiesvar(--token)in a declarationuseHeroLogo,api/HeroSection,BrandBackground)readDesignToken()at runtimesnakeGamesrc/var(--color-charcoal-500),var(--color-azure-600),var(--font-inter), token-valueduseChartfallbacksTwo findings worth flagging: the subscribe button's
var(--color-accent-blue, #0B8CE9)always fell through to the literal because--color-accent-bluedoesn't exist, andOrchestrationSectionkeyed its glow map by hex, so the tiles are now keyed by tone.I did not use
fill="var(--token)". Substitution functions in SVG presentation attributes were only resolved into SVG2 in Nov 2025 and Chromium support is uneven, so every conversion is a real CSS declaration.3. What deliberately stays literal
brandColors.tsis copyable text on /brand and thetheme-colormeta is parsed by the browser — neither can hold avar().brandColors.test.tspins both, plus the standalone brand SVGs, to the token values so CI catches drift instead. Verified it fails: reverting the token to#f0ff41breaks 2 of 5 assertions.#d9d9d9coincidentally equalssmoke-400but is a minimap node fill, not a brand colour. Rewriting it would couple unrelated UI to the brand and change the minimap on the next brand tweak. The rule is "if you mean the token, reference the token" — not "rewrite every value collision".OrchestrationSection's glow values are brighter than the tile fills; deriving them from the tokens would change the visuals.Verification
Pixel-identical. Token-colour pixel counts across nine pages are unchanged (ratios 0.986–1.002).
cloud, where 28 fills were converted, is byte-identical. Raw full-page diffs are non-zero on animated pages, but an after-vs-after control shows equal or larger variance (launches 1.81% control vs 0.53% before/after), so that's animation nondeterminism;cloud-enterpriseandcontactare 0.0000% in both.In-browser.
electric-400→brand-yellow→primary-comfy-yellowall compute torgb(242, 255, 89); the /brand swatch matches its printed#F2FF59label; 28 token-backed fills on /cloud;charcoal-500→rgb(45,46,50)on the signup input;--font-inter→'Inter', sans-serif; the BrandBackground canvas still paints yellow after hoisting its reads.Gates:
stylelint,typecheck,typecheck:website,lint(0 errors),format:check,knip, website build, 279 website unit tests — all pass.onboardingCloudRoutes.test.ts > lazily resolves the /oauth layouttimes out, identically on a stashed tree — pre-existing.Not included
Icon tokens need their own change:
apps/websitekeeps local copies of five icons the package already ships (grok,bytedance,openai,wan,gemini), but consuming them means adopting the Tailwind icon plugin, whichbase.cssdeliberately excludes.litegraph'sNODE_FONT = 'Inter'is a class-field constant in a canvas renderer with no DOM to read from.AGENTS.mdgains the rule, reworded from "don't hardcode" to "consume the token", covering all token classes and both non-obvious exceptions above — mirroring Comfy-Org/platform#481.Screenshots