Repository navigation
feat(cloud): video hero carousel - #14698
Conversation
Adds the brand colour tokens and the white-transparency steps the cloud auth surface needs, and ships PP Formula on the same cloud-only rails ABC ROM already used: faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS dist. Drops ABC ROM Extended and its .hero-title/.font-abcrom rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit.
The loading state replaced the slot with a spinner, so assistive tech lost the button's name for as long as the request was in flight. Keep the label in the accessibility tree via sr-only, hide the decorative spinner, and mark the control aria-busy. Also lands the i18n for the cloud auth redesign: the new sign-up sub-line and free-run copy, the carousel's slide and control labels, and removal of the marketing-pillar slide strings the carousel no longer renders.
Adds brand variants and sizes to the shared Button, replacing a class string that was pasted at six sites with size="unset". Extracts useCloudAuthPage and CloudSocialAuthButtons from the near-identical login and sign-up views. SignUpForm takes typed variant props instead of class strings; defaults are unchanged, so the desktop dialogs render as before.
The logo sat in its own padded header while the slot centred independently, so the two never lined up. One wrapper now owns the horizontal bounds, giving the three-zone layout the design asks for. Moves the terms copy, previously duplicated in both auth views, into CloudTermsNotice behind a showTermsNotice route meta.
Replaces the static jpg collage with an auto-advancing video reel: a playback-synced progress bar, chevron controls, and per-slide captions. Slides rotate their flex order rather than translating one strip, so wrapping last to first travels the same direction as any other step instead of rewinding across every slide. Playback stops when the tab is hidden or the panel scrolls out of view, and the whole component is gated above xl so phones and tablets never fetch the videos.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCloud onboarding now uses a responsive video carousel with video playback management, progress tracking, accessibility announcements, and navigation. The template adds conditional hero and terms rendering. Obsolete cloud translations were removed across locales. ChangesCloud onboarding experience
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant CloudHeroCarousel
participant useVideoCarousel
participant useProgressBarPainter
participant VideoElement
CloudHeroCarousel->>useVideoCarousel: navigate or provide video refs
useVideoCarousel->>VideoElement: play, pause, preload, and track media
useVideoCarousel->>useProgressBarPainter: provide active progress
useProgressBarPainter->>CloudHeroCarousel: update progress scale
useVideoCarousel->>CloudHeroCarousel: expose active slide and direction
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1782 passed, 0 failed · 5 flaky📊 Browser Reports
📦 Bundle: 8.26 MB gzip 🔴 +482 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 124 kB (baseline 114 kB) • 🔴 +9.35 kBTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 9 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • 🔴 +170 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🟢 -12.8 kBBundles that do not match a named category
Status: 90 added / 90 removed / 191 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T03:14:28.418Z",
"gitSha": "ba77a75fc3e740d94eb9af04f0c07d317cd3fe0f",
"branch": "feat/cloud-hero-carousel",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.6170000000216,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.332,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.377,
"heapDeltaBytes": 5354544,
"heapUsedBytes": 69342408,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 28.078000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2052.059999999983,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.852999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.05,
"heapDeltaBytes": 5576004,
"heapUsedBytes": 69795832,
"domNodes": 14,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 28.237,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1981.5419999999904,
"styleRecalcs": 78,
"styleRecalcDurationMs": 52.436,
"layouts": 12,
"layoutDurationMs": 4.2509999999999994,
"taskDurationMs": 1071.2189999999998,
"heapDeltaBytes": -12591176,
"heapUsedBytes": 51407828,
"domNodes": -281,
"jsHeapTotalBytes": 25145344,
"scriptDurationMs": 136.48300000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1978.9690000000064,
"styleRecalcs": 78,
"styleRecalcDurationMs": 46.745,
"layouts": 12,
"layoutDurationMs": 3.965,
"taskDurationMs": 1019.8719999999998,
"heapDeltaBytes": -235252,
"heapUsedBytes": 63820872,
"domNodes": 60,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 138.07899999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1746.7190000000414,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.901000000000003,
"layouts": 6,
"layoutDurationMs": 0.793,
"taskDurationMs": 477.088,
"heapDeltaBytes": 8681408,
"heapUsedBytes": 72687704,
"domNodes": 75,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 29.544,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.9910000000418,
"styleRecalcs": 33,
"styleRecalcDurationMs": 22.186,
"layouts": 6,
"layoutDurationMs": 0.9319999999999999,
"taskDurationMs": 502.074,
"heapDeltaBytes": 8553664,
"heapUsedBytes": 72682676,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 30.662000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 862.041999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.397,
"heapDeltaBytes": -11348552,
"heapUsedBytes": 52787368,
"domNodes": 14,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 76.64800000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 698.3229999999594,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.248999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.291,
"heapDeltaBytes": -11033228,
"heapUsedBytes": 53044820,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 65.884,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.8139999999785,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.704,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 934.241,
"heapDeltaBytes": 6746704,
"heapUsedBytes": 66162100,
"domNodes": -284,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 139.443,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2033.0089999999927,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.762999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 920.881,
"heapDeltaBytes": 5634116,
"heapUsedBytes": 66131404,
"domNodes": -282,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 134.05599999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2196.5269999999464,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.825,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1450.6480000000001,
"heapDeltaBytes": 4536464,
"heapUsedBytes": 65131056,
"domNodes": -287,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 445.707,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2349.3670000000293,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.184000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1499.158,
"heapDeltaBytes": 7523092,
"heapUsedBytes": 68230536,
"domNodes": -288,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 482.0450000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3459.756999999968,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.176000000000002,
"layouts": 60,
"layoutDurationMs": 9.259,
"taskDurationMs": 1773.097,
"heapDeltaBytes": 10062708,
"heapUsedBytes": 72099056,
"domNodes": -287,
"jsHeapTotalBytes": 6135808,
"scriptDurationMs": 623.068,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3530.078000000003,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.634000000000004,
"layouts": 60,
"layoutDurationMs": 9.166,
"taskDurationMs": 1781.567,
"heapDeltaBytes": 14910740,
"heapUsedBytes": 76991112,
"domNodes": -288,
"jsHeapTotalBytes": 6135808,
"scriptDurationMs": 620.87,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2040.288999999973,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.061000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 869.364,
"heapDeltaBytes": 7198748,
"heapUsedBytes": 68038168,
"domNodes": -285,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 130.67999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2073.8850000000184,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.453,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 910.695,
"heapDeltaBytes": 7610912,
"heapUsedBytes": 68012644,
"domNodes": -283,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 136.68999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 660.7460000000174,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.722999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.649,
"heapDeltaBytes": -10652084,
"heapUsedBytes": 53773680,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 127.987,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 716.2550000000465,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.96100000000007,
"heapDeltaBytes": -10580008,
"heapUsedBytes": 53709492,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 130.064,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.1890000000299,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.277999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 650.267,
"heapDeltaBytes": 5120276,
"heapUsedBytes": 69266616,
"domNodes": 16,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 24.980000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.409000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.357999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.6500000000001,
"heapDeltaBytes": 5354824,
"heapUsedBytes": 69519776,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 23.618,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1809.6780000000194,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.536,
"layouts": 16,
"layoutDurationMs": 5.042,
"taskDurationMs": 952.292,
"heapDeltaBytes": -16772960,
"heapUsedBytes": 47678440,
"domNodes": -280,
"jsHeapTotalBytes": 23572480,
"scriptDurationMs": 108.527,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1799.8499999999922,
"styleRecalcs": 76,
"styleRecalcDurationMs": 44.415000000000006,
"layouts": 16,
"layoutDurationMs": 4.982,
"taskDurationMs": 949.9799999999999,
"heapDeltaBytes": -18190300,
"heapUsedBytes": 45904240,
"domNodes": 63,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 105.912,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.085000000072,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.054,
"layouts": 14,
"layoutDurationMs": 12.059000000000001,
"taskDurationMs": 1042.28,
"heapDeltaBytes": 32914172,
"heapUsedBytes": 99339352,
"domNodes": 13673,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 42.491,
"eventListeners": 2375,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8677.087000000029,
"styleRecalcs": 250,
"styleRecalcDurationMs": 47.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5145.018,
"heapDeltaBytes": 17072824,
"heapUsedBytes": 76414600,
"domNodes": -282,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 1496.57,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9502.41900000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 47.410000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5511.354,
"heapDeltaBytes": 24058168,
"heapUsedBytes": 83536284,
"domNodes": -281,
"jsHeapTotalBytes": 8163328,
"scriptDurationMs": 1757.529,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19099.973999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19073.81,
"heapDeltaBytes": -41202324,
"heapUsedBytes": 165912260,
"domNodes": -8312,
"jsHeapTotalBytes": -9117696,
"scriptDurationMs": 572.2270000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18354.686000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18339.028,
"heapDeltaBytes": -35806932,
"heapUsedBytes": 167491996,
"domNodes": -8317,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 522.619,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 24074.432999999997,
"styleRecalcs": 179,
"styleRecalcDurationMs": 30.84699999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24024.235999999997,
"heapDeltaBytes": -57085800,
"heapUsedBytes": 156647968,
"domNodes": -8312,
"jsHeapTotalBytes": -10428416,
"scriptDurationMs": 989.3740000000001,
"eventListeners": -16375,
"totalBlockingTimeMs": 933,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 23961.5839999999,
"styleRecalcs": 180,
"styleRecalcDurationMs": 30.48799999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23935.009000000002,
"heapDeltaBytes": -41363024,
"heapUsedBytes": 164280236,
"domNodes": -8312,
"jsHeapTotalBytes": -7806976,
"scriptDurationMs": 972.8240000000001,
"eventListeners": -16379,
"totalBlockingTimeMs": 1091,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "workflow-execution",
"durationMs": 462.5700000000279,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.475,
"layouts": 3,
"layoutDurationMs": 0.7750000000000001,
"taskDurationMs": 128.269,
"heapDeltaBytes": 5312148,
"heapUsedBytes": 68533188,
"domNodes": 136,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.457,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 485.09899999999107,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.834,
"layouts": 3,
"layoutDurationMs": 0.712,
"taskDurationMs": 126.17200000000001,
"heapDeltaBytes": 5086340,
"heapUsedBytes": 68389832,
"domNodes": 123,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.884,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14698 +/- ##
==========================================
+ Coverage 78.62% 79.56% +0.93%
==========================================
Files 1796 1799 +3
Lines 107051 115502 +8451
Branches 30020 36081 +6061
==========================================
+ Hits 84169 91895 +7726
- Misses 22419 23063 +644
- Partials 463 544 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 218 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
One blocking pre-merge requirement remains: the temporary WebMs must be moved out of the repository, as the PR description notes and the binary-size check confirms. I also left one non-blocking failure-path animation note. The focused unit, lint/format, E2E, performance, and patch-coverage checks are otherwise green.
| @@ -0,0 +1,54 @@ | |||
| import heroPoster1 from '@/platform/cloud/onboarding/assets/videos/hero-1.webp' | |||
| import heroVideo1 from '@/platform/cloud/onboarding/assets/videos/hero-1.webm' | |||
There was a problem hiding this comment.
issue: This still imports the temporary in-repo WebM, so the branch fails the required binary-size check (hero-1.webm 1.3 MiB, hero-2.webm 2.6 MiB, hero-3.webm 1.0 MiB). The PR description also explicitly says these files must not land. Please switch the slide sources to the hosted media URLs and remove the bundled WebMs before merge.
| const track = trackEl.value | ||
| if (!track || to === from) return | ||
|
|
||
| const isForwards = wrapIndex(to - from, slides.length) === 1 |
There was a problem hiding this comment.
suggestion: Inferring direction from index adjacency flips the animation when failure handling skips a slide. For example, after slide 1 fails, next() moves 0 → 2, but wrapIndex(2 - 0, 3) is 2, so this animates backward even though navigation was forward. Could the composable expose/preserve the requested step direction (or otherwise cover skipped slides) so recovery keeps the chevron/auto-advance direction?
There was a problem hiding this comment.
Good catch, fixed. useVideoCarousel now records the requested delta as lastStep and the component reads that instead of inferring from the index gap.
Both cases were broken: skipping a failed slide (wrapIndex(2-0, 3) === 2, read as backwards) and a two-slide carousel, where wrapIndex(±1, 2) === 1 always reads as forwards so previous() animated the wrong way. Two regression tests added.
dante01yoon
left a comment
There was a problem hiding this comment.
Re-approved after the stack was retargeted to main. The previously reviewed hosted-media and carousel-direction fixes remain present, with the subsequent layout/spacing commits included at this head.
…Org#14694) > **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to Comfy-Org#14696, carousel keys to Comfy-Org#14698), so no intermediate merge renders raw i18n keys. Stacked on Comfy-Org#14694.
…Org#14696) > **Stacked PR 3 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Rebuilds the login, sign-up and forgot-password panels on real design-system variants instead of a hand-pasted class string. ## Changes - **What**: Adds the auth copy keys (`cloudNewUser`, `cloudSignUp`, `freeRunsSuffix`) this PR's views consume, plus `brand-ghost`, `brand-solid`, `brand-ghost-accent` variants and `brand` / `brand-icon` sizes to the shared `Button`. The same long class string was previously pasted at six sites with `size="unset"` — every one of those buttons was opting out of the design system it was meant to use. - Extracts `useCloudAuthPage` and `CloudSocialAuthButtons` from the near-identical login and sign-up views (~85% duplicated markup plus identical OAuth handlers). - `SignUpForm` / `PasswordFields` take typed `ButtonVariants` props instead of opaque class strings. Defaults are unchanged, so the desktop sign-in dialog and update-password dialog render exactly as before. ## Review Focus - **Shared-component blast radius**: `SignUpForm` and `PasswordFields` are also used by `SignInContent.vue` and `UpdatePasswordContent.vue`. The `h-10` field default is deliberately preserved — those two dialogs have no test coverage. - The variants and the views ship together on purpose: `button.variants.ts` has zero consumers on its own, so splitting them would merge dead code. The panel is width-bounded here so this PR is visually valid on its own; Comfy-Org#14697 relocates that constraint onto its own wrapper. Stacked on the button a11y PR.
# Conflicts: # src/platform/cloud/onboarding/components/CloudTemplate.vue
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/locales/en/main.json`:
- Around line 3474-3477: Complete the cloudHero localization entries in
src/locales/en/main.json, src/locales/ar/main.json:449,
src/locales/es/main.json:449, src/locales/fa/main.json:449,
src/locales/tr/main.json:449, src/locales/zh-TW/main.json:449, and
src/locales/zh/main.json:449, plus every other locale containing only
previousSlide/nextSlide. Add localized nextSlide, slideRoleDescription,
carouselRoleDescription, carouselLabel, and slideStatus values consumed by
CloudHeroCarousel.vue, preserving the {title}, {current}, and {total}
placeholders in slideStatus.
In `@src/platform/cloud/onboarding/components/CloudHeroCarousel.test.ts`:
- Around line 131-133: Update the live-region assertion in the CloudHeroCarousel
test to use screen.getByRole('status') instead of container.querySelector.
Remove the testing-library eslint suppression and both container accesses while
preserving the existing in-document assertion.
In `@src/platform/cloud/onboarding/components/CloudHeroCarousel.vue`:
- Around line 80-112: Add a pause/play toggle in the controls rendered by
CloudHeroCarousel, wired to a reactive paused state and an accessible
label/icon. Pass that state into useVideoCarousel, and update its
`@ended/useTimeoutFn` playback and watchdog logic so both video advancement and
auto-advance stop while paused, then resume correctly when unpaused.
In `@src/platform/cloud/onboarding/components/CloudTemplate.test.ts`:
- Around line 57-59: Update the test cleanup hook in CloudTemplate.test.ts so
mock state is reset before globals are restored: call vi.resetAllMocks() before
vi.unstubAllGlobals() within afterEach.
In `@src/platform/cloud/onboarding/components/CloudTermsNotice.vue`:
- Around line 5-35: Update CloudTermsNotice.vue so the complete terms/privacy
sentence and cloud waitlist contact sentence, including punctuation, come from
translation entries rather than hard-coded template text. Use vue-i18n
interpolation components to render each linked URL with the existing localized
link labels, preserving the current URLs, target, rel, and styling.
In `@src/platform/cloud/onboarding/composables/useVideoCarousel.test.ts`:
- Around line 274-310: Add a colocated useProgressBarPainter.test.ts covering
the composable’s no-target early return, target-change painting, and
pause/resume transitions when active changes. Mount it within an effectScope,
drive reactive active and target values, assert the resulting style.scale, and
include timing/cleanup edge cases with proper scope disposal.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2ff29ef8-86b4-4511-9845-1b6faa7ac1cc
⛔ Files ignored due to path filters (7)
public/icons/logo.svgis excluded by!**/*.svgsrc/platform/cloud/onboarding/assets/hero/bottom-left.jpgis excluded by!**/*.jpgsrc/platform/cloud/onboarding/assets/hero/bottom-right.jpgis excluded by!**/*.jpgsrc/platform/cloud/onboarding/assets/hero/center-image.jpgis excluded by!**/*.jpgsrc/platform/cloud/onboarding/assets/hero/top-left.jpgis excluded by!**/*.jpgsrc/platform/cloud/onboarding/assets/videos/thumbnail.pngis excluded by!**/*.pngsrc/platform/cloud/onboarding/assets/videos/video.mp4is excluded by!**/*.mp4
📒 Files selected for processing (28)
src/locales/ar/main.jsonsrc/locales/en/main.jsonsrc/locales/es/main.jsonsrc/locales/fa/main.jsonsrc/locales/fr/main.jsonsrc/locales/he/main.jsonsrc/locales/ja/main.jsonsrc/locales/ko/main.jsonsrc/locales/pt-BR/main.jsonsrc/locales/ru/main.jsonsrc/locales/tr/main.jsonsrc/locales/zh-TW/main.jsonsrc/locales/zh/main.jsonsrc/platform/cloud/onboarding/assets/css/heroVideo.csssrc/platform/cloud/onboarding/components/CloudHeroCarousel.test.tssrc/platform/cloud/onboarding/components/CloudHeroCarousel.vuesrc/platform/cloud/onboarding/components/CloudTemplate.test.tssrc/platform/cloud/onboarding/components/CloudTemplate.vuesrc/platform/cloud/onboarding/components/CloudTemplateFooter.vuesrc/platform/cloud/onboarding/components/CloudTermsNotice.vuesrc/platform/cloud/onboarding/composables/useProgressBarPainter.tssrc/platform/cloud/onboarding/composables/useVideoCarousel.test.tssrc/platform/cloud/onboarding/composables/useVideoCarousel.tssrc/platform/cloud/onboarding/constants/heroSlides.tssrc/platform/cloud/onboarding/onboardingCloudRoutes.test.tssrc/platform/cloud/onboarding/onboardingCloudRoutes.tssrc/utils/mathUtil.test.tssrc/utils/mathUtil.ts
# Conflicts: # src/platform/cloud/onboarding/components/CloudTemplate.vue # src/platform/cloud/onboarding/components/CloudTermsNotice.vue
> **Stacked PR 4 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary The logo sat in its own padded header while the content column centred independently, so the two never lined up — measured 96px apart at 1600w. ## Changes - **What**: One wrapper now owns the horizontal bounds, giving the three-zone layout the design asks for: logo pinned top, content centred, terms pinned bottom, all sharing a single left edge. - Moves the terms copy — previously duplicated verbatim in both auth views — into `CloudTermsNotice`, shown via a `showTermsNotice` route meta. Other cloud routes keep the existing link footer. ## Review Focus `route.meta.showTermsNotice` swaps the footer for the terms notice on login and sign-up only. Every other cloud route — survey, user-check, forgot-password — keeps `CloudTemplateFooter` exactly as before, asserted at the route level in `onboardingCloudRoutes.test.ts`. Verified logo x === headline x at 1600 / 1280 / 1024 / 768 / 390, with no horizontal overflow at any width. Stacked on the auth panel PR.
> **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to #14696, carousel keys to #14698), so no intermediate merge renders raw i18n keys. Stacked on #14694.
Summary
Replaces the static jpg collage with an auto-advancing video reel: playback-synced progress bar, chevron controls, per-slide captions.
Changes
CloudHeroCarouselbuilt onuseVideoCarousel(slide state, preload ladder, failure handling) anduseProgressBarPainter(rAF bar writing straight to the DOM, so a 60Hz value never re-renders the component).orderrather than translating one strip, so wrapping last→first travels the same direction as any other step instead of rewinding across every slide. The composable reports the direction it was asked to move, so skipping a failed slide still animates forwards.media.comfy.orgrather than bundled, so no video bytes ship in the repo or the build.Review Focus
xlviav-if, not CSS — confirmed against a production build that phones and tablets fetch 0 bytes of video.aria-hidden+inert, carousel landmark with a polite live region that announces user-driven moves only — the auto-advance stays silent so it never talks over the form.Screenshots.