Repository navigation
feat(cloud): brand button variants and redesigned auth panels - #14696
Conversation
Adds the brand colour tokens and the white-transparency steps the cloud auth surface needs, and ships PP Formula on the same cloud-only rails ABC ROM already used: faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS dist. Drops ABC ROM Extended and its .hero-title/.font-abcrom rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit.
The loading state replaced the slot with a spinner, so assistive tech lost the button's name for as long as the request was in flight. Keep the label in the accessibility tree via sr-only, hide the decorative spinner, and mark the control aria-busy. Also lands the i18n for the cloud auth redesign: the new sign-up sub-line and free-run copy, the carousel's slide and control labels, and removal of the marketing-pillar slide strings the carousel no longer renders.
Adds brand variants and sizes to the shared Button, replacing a class string that was pasted at six sites with size="unset". Extracts useCloudAuthPage and CloudSocialAuthButtons from the near-identical login and sign-up views. SignUpForm takes typed variant props instead of class strings; defaults are unchanged, so the desktop dialogs render as before.
📝 WalkthroughWalkthroughCloud onboarding now uses shared authentication state, social-login controls, styling constants, and branded buttons. Login, signup, and password recovery views receive redesigned layouts. Tests cover loading, routing, regional restrictions, email mode switching, free-run messaging, and embedded-browser notices. ChangesShared authentication controls
Cloud onboarding views
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant CloudLoginView
participant CloudSocialAuthButtons
participant useCloudAuthPage
participant AuthProvider
CloudLoginView->>CloudSocialAuthButtons: render social controls
CloudSocialAuthButtons->>CloudLoginView: emit provider event
CloudLoginView->>useCloudAuthPage: invoke sign-in handler
useCloudAuthPage->>AuthProvider: start provider authentication
AuthProvider-->>useCloudAuthPage: return authentication result
useCloudAuthPage->>CloudLoginView: update state and redirect
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1786 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.25 MB gzip 🔴 +538 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 111 kB) • 🔴 +915 BTop-level views, pages, and routed surfaces
Status: 16 added / 15 removed / 1 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed / 14 unchanged User & Accounts — 27 kB (baseline 28.7 kB) • 🟢 -1.75 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 1 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed UI Components — 70.8 kB (baseline 70.2 kB) • 🔴 +653 BReusable component library chunks
Status: 15 added / 15 removed Data & Services — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 17 added / 17 removed Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 26 added / 26 removed / 10 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • 🔴 +19 BExternal libraries and shared vendor chunks
Status: 6 added / 6 removed / 10 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🔴 +63 BBundles that do not match a named category
Status: 115 added / 115 removed / 166 unchanged ⚡ Performance
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #14696 +/- ##
==========================================
+ Coverage 78.28% 79.36% +1.07%
==========================================
Files 1790 1794 +4
Lines 108913 115180 +6267
Branches 30770 36794 +6024
==========================================
+ Hits 85260 91407 +6147
- Misses 23163 23228 +65
- Partials 490 545 +55
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 215 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Blocking layout regression found in the auth-panel rebuild. CI is green, and the focused static comparison against the current CloudTemplate confirms the panel no longer has a horizontal bound.
| </h1> | ||
| <p | ||
| class="my-0 text-base/6 tracking-[-0.02em] text-primary-comfy-canvas" | ||
| <div class="flex w-full flex-col"> |
There was a problem hiding this comment.
issue: This removes the login panel’s only max-w-md constraint, while the current CloudTemplate merely centers its slot and supplies no horizontal bound. Because this new root is w-full, the login controls now stretch across the entire left pane; the same regression is present in the signup and forgot-password roots. I see that stacked follow-up #14697 introduces a bounded wrapper, but this PR’s merged state is still unshippable on its own. Could we retain a max-width wrapper here (and relocate it in #14697) so each stacked merge remains visually valid?
dante01yoon
left a comment
There was a problem hiding this comment.
The blocking full-pane auth-control width regression is resolved at this head. CloudTemplate now owns a responsive w-full max-w-md px-6 lg:max-w-lg 2xl:max-w-xl wrapper around the slot, so login, signup, and forgot-password remain bounded in this PR independently of the stacked follow-ups. All current checks are complete with no failures.
…Org#14694) > **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to Comfy-Org#14696, carousel keys to Comfy-Org#14698), so no intermediate merge renders raw i18n keys. Stacked on Comfy-Org#14694.
> **Stacked PR 4 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary The logo sat in its own padded header while the content column centred independently, so the two never lined up — measured 96px apart at 1600w. ## Changes - **What**: One wrapper now owns the horizontal bounds, giving the three-zone layout the design asks for: logo pinned top, content centred, terms pinned bottom, all sharing a single left edge. - Moves the terms copy — previously duplicated verbatim in both auth views — into `CloudTermsNotice`, shown via a `showTermsNotice` route meta. Other cloud routes keep the existing link footer. ## Review Focus `route.meta.showTermsNotice` swaps the footer for the terms notice on login and sign-up only. Every other cloud route — survey, user-check, forgot-password — keeps `CloudTemplateFooter` exactly as before, asserted at the route level in `onboardingCloudRoutes.test.ts`. Verified logo x === headline x at 1600 / 1280 / 1024 / 768 / 390, with no horizontal overflow at any width. Stacked on the auth panel PR.
> **Stacked PR 5 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | Comfy-Org#14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | Comfy-Org#14695 | Button keeps its label for screen readers while loading | > | 3 | Comfy-Org#14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | Comfy-Org#14697 | Logo, content and terms share one left edge | > | 5 | Comfy-Org#14698 | Static hero collage becomes a video carousel | ## Summary Replaces the static jpg collage with an auto-advancing video reel: playback-synced progress bar, chevron controls, per-slide captions. ## Changes - **What**: New `CloudHeroCarousel` built on `useVideoCarousel` (slide state, preload ladder, failure handling) and `useProgressBarPainter` (rAF bar writing straight to the DOM, so a 60Hz value never re-renders the component). - Slides rotate their flex `order` rather than translating one strip, so wrapping last→first travels the same direction as any other step instead of rewinding across every slide. The composable reports the direction it was asked to move, so skipping a failed slide still animates forwards. - Media is served from `media.comfy.org` rather than bundled, so no video bytes ship in the repo or the build. - The hero card takes its height from the row instead of a fixed aspect ratio, which is what kept the logo and terms pinned to the video's edges as the viewport grew. ## Review Focus - **Playback stops when it should**: verified paused with frozen decoder frame counts when the tab is hidden and when the panel scrolls offscreen. No leak across 5 mount/unmount cycles (heap and node counts flat). - **Gated above `xl`** via `v-if`, not CSS — confirmed against a production build that phones and tablets fetch **0 bytes** of video. - **A11y**: axe (WCAG 2.0/2.1 A+AA) reports no violations in the carousel subtree. One slide exposed at a time via `aria-hidden` + `inert`, carousel landmark with a polite live region that announces user-driven moves only — the auto-advance stays silent so it never talks over the form. - **Reduced motion**: no playback, no auto-advance, chevrons still work without starting video. Screenshots. <img width="1440" height="900" alt="forgot-1-default" src="https://github.com/user-attachments/assets/2710d4f9-dc5e-41a4-bbfc-2fd895b9df47" /> <img width="1440" height="900" alt="forgot-2-required" src="https://github.com/user-attachments/assets/254893ed-ad94-4a08-91fa-fabb107e167c" /> <img width="1440" height="900" alt="forgot-3-filled" src="https://github.com/user-attachments/assets/ac6d6431-c678-4fd2-b69b-67801345150c" /> <img width="1440" height="900" alt="forgot-4-long-email-overflow" src="https://github.com/user-attachments/assets/b91c8a67-cc84-43de-8d78-087b0c546ccd" /> <img width="1440" height="900" alt="forgot-no-footer" src="https://github.com/user-attachments/assets/c18ac4ef-d5dc-4437-b1ff-b687210d465f" /> <img width="1440" height="900" alt="login-1-social" src="https://github.com/user-attachments/assets/f1a5a889-9631-4603-8da7-3e21f1ca68e8" /> <img width="1440" height="900" alt="login-2-email-empty" src="https://github.com/user-attachments/assets/a4eaead2-350a-4140-be4e-2ea79bf4d1ff" /> <img width="1440" height="900" alt="login-3-invalid-email" src="https://github.com/user-attachments/assets/80943f8f-7ddb-438e-b641-9d6b97388d94" /> <img width="1440" height="900" alt="login-4-required" src="https://github.com/user-attachments/assets/66f9835e-f511-4993-81b7-1d49dd4cd9ea" /> <img width="1440" height="900" alt="login-with-fixed-logo" src="https://github.com/user-attachments/assets/52ee9097-7b5d-4eef-9049-b1ce69eccde1" /> <img width="400" height="90" alt="LOGO-fixed" src="https://github.com/user-attachments/assets/b28d4f75-af83-41bc-9aeb-9fc187bc49a4" /> <img width="1440" height="900" alt="signup-1-social" src="https://github.com/user-attachments/assets/36f353a1-a66f-434f-91f6-0825a76025e1" /> <img width="1440" height="900" alt="signup-2-email-empty" src="https://github.com/user-attachments/assets/a5c9e2a1-667d-41f5-b15f-287ccb963e93" /> <img width="1440" height="900" alt="signup-3-weak-password" src="https://github.com/user-attachments/assets/ffa00431-1d33-43f8-9968-2ecb53268d2b" /> <img width="1440" height="900" alt="signup-4-password-mismatch" src="https://github.com/user-attachments/assets/3b81508d-06b7-40b4-b884-3342bb892265" /> --------- Co-authored-by: Deep Mehta <deepme987@gmail.com>
|
@MaanilVerma Successfully backported to #14851 |
> **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to #14696, carousel keys to #14698), so no intermediate merge renders raw i18n keys. Stacked on #14694.
Summary
Rebuilds the login, sign-up and forgot-password panels on real design-system variants instead of a hand-pasted class string.
Changes
cloudNewUser,cloudSignUp,freeRunsSuffix) this PR's views consume, plusbrand-ghost,brand-solid,brand-ghost-accentvariants andbrand/brand-iconsizes to the sharedButton. The same long class string was previously pasted at six sites withsize="unset"— every one of those buttons was opting out of the design system it was meant to use.useCloudAuthPageandCloudSocialAuthButtonsfrom the near-identical login and sign-up views (~85% duplicated markup plus identical OAuth handlers).SignUpForm/PasswordFieldstake typedButtonVariantsprops instead of opaque class strings. Defaults are unchanged, so the desktop sign-in dialog and update-password dialog render exactly as before.Review Focus
SignUpFormandPasswordFieldsare also used bySignInContent.vueandUpdatePasswordContent.vue. Theh-10field default is deliberately preserved — those two dialogs have no test coverage.button.variants.tshas zero consumers on its own, so splitting them would merge dead code.The panel is width-bounded here so this PR is visually valid on its own; #14697 relocates that constraint onto its own wrapper.
Stacked on the button a11y PR.