Repository navigation
[backport cloud/1.49] feat(cloud): dark theme, brand tokens and PP Formula pipeline - #14898
comfy-pr-bot wants to merge 1 commit into
Conversation
> **Stacked PR 1 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary Lands the shell the cloud auth redesign sits on: brand colour tokens, the white-transparency steps, and PP Formula shipped cloud-only. ## Changes - **What**: Adds `--color-primary-comfy-yellow`, `--color-primary-warm-white`, `--color-primary-warm-gray` and two white-transparency tokens to the design system. Ships three PP Formula faces on the same rails ABC ROM already used — faces live under the onboarding assets, the Vite plugin strips them from non-cloud bundles, and CI fails the build if they reach an OSS `dist/`. - Deletes ABC ROM Extended and its `.hero-title` / `.font-abcrom` rules. Nothing referenced them, so they were proprietary bytes bundled for no visual benefit. ## Review Focus The font guard is the thing to check. Both directions are verified: ``` DISTRIBUTION=localhost pnpm build && find dist -iname "*ppformula*" -o -iname "*abcrom*" # empty DISTRIBUTION=cloud pnpm build && find dist -iname "*ppformula*" # 3 files ``` First of 5 stacked PRs — see the stack table in #1 of the series.
🎭 Playwright: ✅ 1785 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-07T09:10:50.223Z",
"gitSha": "27193c121343a8b51f521b05e5174e522bdced49",
"branch": "backport-14694-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.746999999934,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.389,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.786,
"heapDeltaBytes": 5146376,
"heapUsedBytes": 73399356,
"domNodes": 20,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 17.159999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1998.9850000001752,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.864,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.193,
"heapDeltaBytes": 5354752,
"heapUsedBytes": 73584372,
"domNodes": 20,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 12.849999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.870000000039,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.109,
"layouts": 12,
"layoutDurationMs": 3.0880000000000005,
"taskDurationMs": 664.6220000000001,
"heapDeltaBytes": -645840,
"heapUsedBytes": 67479796,
"domNodes": 56,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 96.588,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.1739999999463,
"styleRecalcs": 71,
"styleRecalcDurationMs": 26.763,
"layouts": 12,
"layoutDurationMs": 3.091,
"taskDurationMs": 638.0799999999999,
"heapDeltaBytes": -465448,
"heapUsedBytes": 67798480,
"domNodes": 52,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 89.38,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.9300000000094,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.210000000000003,
"layouts": 6,
"layoutDurationMs": 0.554,
"taskDurationMs": 303.86400000000003,
"heapDeltaBytes": 7938376,
"heapUsedBytes": 76249024,
"domNodes": 77,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 15.69,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.4550000000054,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.772000000000002,
"layouts": 6,
"layoutDurationMs": 0.6219999999999999,
"taskDurationMs": 301.23,
"heapDeltaBytes": 7864956,
"heapUsedBytes": 75967192,
"domNodes": 77,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 15.389999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 546.820999999909,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.3149999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.426,
"heapDeltaBytes": -12567056,
"heapUsedBytes": 55587896,
"domNodes": 20,
"jsHeapTotalBytes": 22663168,
"scriptDurationMs": 50.288999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 508.2280000001447,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.334999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.961,
"heapDeltaBytes": -12546652,
"heapUsedBytes": 55554384,
"domNodes": 20,
"jsHeapTotalBytes": 22663168,
"scriptDurationMs": 43.766,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.2710000000316,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.821000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.496,
"heapDeltaBytes": 8586388,
"heapUsedBytes": 69515012,
"domNodes": -280,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 73.50899999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2010.2469999999357,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.186,
"heapDeltaBytes": 5464464,
"heapUsedBytes": 64509160,
"domNodes": -282,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 77.035,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2084.3959999999697,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.350000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 960.102,
"heapDeltaBytes": 4428260,
"heapUsedBytes": 64309200,
"domNodes": -283,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 311.44100000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2075.5979999999,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.535,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 972.8759999999999,
"heapDeltaBytes": 837132,
"heapUsedBytes": 61238376,
"domNodes": -282,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 311.42900000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3152.9160000000047,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.411,
"layouts": 60,
"layoutDurationMs": 6.734,
"taskDurationMs": 1219.522,
"heapDeltaBytes": -4429652,
"heapUsedBytes": 56945240,
"domNodes": -284,
"jsHeapTotalBytes": 6610944,
"scriptDurationMs": 422.76599999999996,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3075.0390000000607,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.662999999999998,
"layouts": 60,
"layoutDurationMs": 6.7589999999999995,
"taskDurationMs": 1158.818,
"heapDeltaBytes": 22907884,
"heapUsedBytes": 84634628,
"domNodes": 14,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 408.965,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2001.164000000017,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.8679999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.675,
"heapDeltaBytes": 8137564,
"heapUsedBytes": 69125972,
"domNodes": -282,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 73.07900000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1998.2800000000225,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.249000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.034,
"heapDeltaBytes": 8391544,
"heapUsedBytes": 69155000,
"domNodes": -281,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 75.46700000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 509.3130000000201,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.318,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.012,
"heapDeltaBytes": -10933472,
"heapUsedBytes": 57320628,
"domNodes": 22,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 92.187,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 504.79600000016944,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.946000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.964,
"heapDeltaBytes": -12508284,
"heapUsedBytes": 55960912,
"domNodes": 24,
"jsHeapTotalBytes": 22138880,
"scriptDurationMs": 93.101,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1995.4729999999472,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.002999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.156,
"heapDeltaBytes": 4926820,
"heapUsedBytes": 73123960,
"domNodes": 22,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 11.417000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.8289999998397,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.54600000000005,
"heapDeltaBytes": 4725268,
"heapUsedBytes": 73106408,
"domNodes": 20,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 11.402000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.0530000000817,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.928,
"layouts": 16,
"layoutDurationMs": 3.382,
"taskDurationMs": 592.36,
"heapDeltaBytes": -4390688,
"heapUsedBytes": 63905560,
"domNodes": 65,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 71.84899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.2339999999895,
"styleRecalcs": 79,
"styleRecalcDurationMs": 27.703999999999997,
"layouts": 16,
"layoutDurationMs": 3.2780000000000005,
"taskDurationMs": 628.2860000000001,
"heapDeltaBytes": -21430964,
"heapUsedBytes": 46850740,
"domNodes": -279,
"jsHeapTotalBytes": 19906560,
"scriptDurationMs": 73.488,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.2410000001037,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.604999999999993,
"layouts": 14,
"layoutDurationMs": 9.02,
"taskDurationMs": 702.258,
"heapDeltaBytes": 8237768,
"heapUsedBytes": 100601788,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 21.367000000000004,
"eventListeners": 2373,
"totalBlockingTimeMs": 77,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.2070000000185,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.18,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3392.7450000000003,
"heapDeltaBytes": 9428584,
"heapUsedBytes": 70280732,
"domNodes": -279,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 1034.716,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8136.167999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.097,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3486.747,
"heapDeltaBytes": 6900280,
"heapUsedBytes": 66267336,
"domNodes": -280,
"jsHeapTotalBytes": 8671232,
"scriptDurationMs": 1109.128,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14333.145000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14318.168,
"heapDeltaBytes": -47441592,
"heapUsedBytes": 166209756,
"domNodes": -8312,
"jsHeapTotalBytes": -14098432,
"scriptDurationMs": 465.81399999999996,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13995.137999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13975.73,
"heapDeltaBytes": -44485004,
"heapUsedBytes": 167331408,
"domNodes": -8312,
"jsHeapTotalBytes": -11210752,
"scriptDurationMs": 412.97799999999995,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17009.913999999982,
"styleRecalcs": 116,
"styleRecalcDurationMs": 12.996000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16971.444,
"heapDeltaBytes": -45308692,
"heapUsedBytes": 164657512,
"domNodes": -8312,
"jsHeapTotalBytes": -12787712,
"scriptDurationMs": 701.704,
"eventListeners": -16387,
"totalBlockingTimeMs": 13,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16991.352000000006,
"styleRecalcs": 118,
"styleRecalcDurationMs": 13.183,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16962.946,
"heapDeltaBytes": -31795064,
"heapUsedBytes": 177740276,
"domNodes": -8312,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 696.2270000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 425.420000000031,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.752,
"layouts": 4,
"layoutDurationMs": 1.4480000000000002,
"taskDurationMs": 114.92699999999999,
"heapDeltaBytes": -15488944,
"heapUsedBytes": 51867644,
"domNodes": 134,
"jsHeapTotalBytes": 7458816,
"scriptDurationMs": 10.100999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 431.10699999988356,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.231,
"layouts": 2,
"layoutDurationMs": 0.361,
"taskDurationMs": 90.123,
"heapDeltaBytes": -15738116,
"heapUsedBytes": 51527884,
"domNodes": 125,
"jsHeapTotalBytes": 7720960,
"scriptDurationMs": 7.941,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
🌐 Website E2ETip All tests passed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.49 #14898 +/- ##
=============================================
Coverage ? 78.77%
=============================================
Files ? 1791
Lines ? 104559
Branches ? 32069
=============================================
Hits ? 82362
Misses ? 21767
Partials ? 430
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Pull request was closed
Backport of #14694 to
cloud/1.49Automatically created by backport workflow.