Repository navigation
test/images with tailor [4]: validate and fingerprint signing credentials - #899
Draft
bfjelds (bfjelds) wants to merge 1 commit into
Draft
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
Include effective signing settings and role-specific credential contents in cache fingerprints, follow key symlinks, and reject invalid signing configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6501a6e2-9ece-44f9-a91a-4d8e0c0e6d07
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
bfjelds (bfjelds)
changed the title
This was referenced Oct 26, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Credential path normalization can hash a different file from the signer, allowing credential rotation to reuse stale signed artifacts.
1 open issue
What changed in this PR
Part 4 of the Tailor migration adds signing-aware cache fingerprints so changes to signing profiles or local credentials invalidate cached image builds.
Changes:
- Resolve signing profiles during planning and fingerprint their settings and credential contents.
- Add uncached credential hashing and regression coverage for symlink rotation and fingerprint field separation.
- Correct the output documentation to describe slug-based filenames.
| File | Description |
|---|---|
| tools/tailor/docs/reference/image-yaml.md | Clarify output naming and remove the unsupported name override. |
| tools/tailor/crates/tailor-core/src/orchestrator.rs | Resolve signing profiles and hash credentials during planning. |
| tools/tailor/crates/tailor-core/src/hashcache.rs | Expose uncached file hashing within the crate. |
| tools/tailor/crates/tailor-core/src/fingerprint.rs | Include separate signing fields and credential hashes, with regression tests. |
| tools/tailor/crates/tailor-core/src/deps.rs | Add uncached dependency hashing and share hash composition. |
Review effort: Balanced
| let Some(path) = path else { | ||
| return Ok(None); | ||
| }; | ||
| let absolute = tailor_config::absolutize(path, workspace_root); |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate signing credentials and fingerprint their contents so signing changes invalidate cached builds.
Part 4 of the 16-PR Tailor migration stack. Depends on #898.
This split preserves the aggregate migration content; the original tooling, image-config, and final trees are unchanged.
Stack