Repository navigation
tests/images with tailor [4]: remove legacy image system - #845
Draft
bfjelds (bfjelds) wants to merge 1 commit into
Draft
bfjelds (bfjelds) wants to merge 1 commit into
bfjelds (bfjelds) wants to merge 1 commit into
Conversation
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
bfjelds (bfjelds)
changed the title
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 10, 2026 18:39
4c138ba to
6ee69f0
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 10, 2026 22:40
6ee69f0 to
0e22e61
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
3 times, most recently
from
October 11, 2026 00:41
7998119 to
24ef884
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 11, 2026 23:34
24ef884 to
8c47de9
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
3 times, most recently
from
October 12, 2026 17:04
6103dcf to
09522b2
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 12, 2026 17:23
09522b2 to
4832f21
Compare
This was referenced Oct 12, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Several maintained guides still direct users to the deleted tree and obsolete configuration filenames.
0 open findings
What changed in this PR
Removes the obsolete tests/images image-building system after migration to the Tailor workspace.
Changes:
- Deletes the legacy Python image builder and registry.
- Removes migrated image definitions, scripts, services, and documentation.
| File | Description |
|---|---|
tests/images/trident-vm-testimage/README.md |
Removes legacy VM image documentation. |
tests/images/trident-vm-testimage/base/updateimg-grub.yaml |
Removes legacy GRUB update config. |
tests/images/trident-vm-testimage/base/updateimg-grub-verity.yaml |
Removes legacy verity update config. |
tests/images/trident-vm-testimage/base/updateimg-grub-verity-azure.yaml |
Removes legacy Azure verity config. |
tests/images/trident-vm-testimage/base/updateimg-acl-agent.yaml |
Removes legacy ACL-agent update config. |
tests/images/trident-vm-testimage/base/scripts/update-os-release.sh |
Removes migrated customization script. |
tests/images/trident-vm-testimage/base/scripts/update-host-status.sh |
Removes migrated customization script. |
tests/images/trident-vm-testimage/base/scripts/ssh-move-host-keys.sh |
Removes migrated SSH helper. |
tests/images/trident-vm-testimage/base/scripts/prepare-update-config.sh |
Removes migrated update helper. |
tests/images/trident-vm-testimage/base/scripts/prepare-update-config-verity.sh |
Removes migrated verity helper. |
tests/images/trident-vm-testimage/base/scripts/prepare-update-config-usrverity.sh |
Removes migrated usr-verity helper. |
tests/images/trident-vm-testimage/base/scripts/post-install.sh |
Removes migrated post-install script. |
tests/images/trident-vm-testimage/base/scripts/lsblk.sh |
Removes legacy diagnostic script. |
tests/images/trident-vm-testimage/base/scripts/duid-type-to-link-layer.sh |
Removes migrated network helper. |
tests/images/trident-vm-testimage/base/scripts/create-ssh-dirs.sh |
Removes migrated SSH helper. |
tests/images/trident-vm-testimage/base/scripts/create-rw-overlay-dirs.sh |
Removes migrated overlay helper. |
tests/images/trident-vm-testimage/base/files/use-grpc-client-commit.conf |
Removes migrated service override. |
tests/images/trident-vm-testimage/base/files/trident-acl-agent-override.conf |
Removes migrated ACL-agent override. |
tests/images/trident-vm-testimage/base/files/trident-acl-agent-cert-install.service |
Removes migrated certificate service. |
tests/images/trident-vm-testimage/base/files/sudoers-wheel |
Removes migrated sudoers file. |
tests/images/trident-vm-testimage/base/files/sshd-keygen.service |
Removes migrated SSH service. |
tests/images/trident-vm-testimage/base/files/etc-mount.sh |
Removes migrated overlay script. |
tests/images/trident-vm-testimage/base/files/etc-mount.service |
Removes migrated overlay service. |
tests/images/trident-vm-testimage/base/files/etc-mount-mic.service |
Removes legacy overlay service. |
tests/images/trident-vm-testimage/base/files/99-dhcp-eth0.network |
Removes migrated network config. |
tests/images/trident-vm-testimage/base/files/.gitignore |
Removes legacy generated-file exclusions. |
tests/images/trident-vm-testimage/base/etc.mount |
Removes legacy mount unit. |
tests/images/trident-vm-testimage/base/baseimg-usr-verity.yaml |
Removes legacy usr-verity image config. |
tests/images/trident-vm-testimage/base/baseimg-root-verity.yaml |
Removes legacy root-verity image config. |
tests/images/trident-vm-testimage/base/baseimg-grub.yaml |
Removes legacy GRUB base config. |
tests/images/trident-vm-testimage/base/baseimg-grub-verity.yaml |
Removes legacy GRUB verity config. |
tests/images/trident-vm-testimage/base/baseimg-grub-verity-azure.yaml |
Removes legacy Azure base config. |
tests/images/trident-vm-testimage/base/baseimg-acl-agent.yaml |
Removes legacy ACL-agent base config. |
tests/images/trident-vm-testimage/base/.gitignore |
Removes legacy generated-file exclusion. |
tests/images/trident-verity-testimage/usr/host.yaml |
Removes legacy host usr-verity config. |
tests/images/trident-verity-testimage/usr/files/use-grpc-client-commit.conf |
Removes migrated service override. |
tests/images/trident-verity-testimage/usr/files/trident-container.service |
Removes migrated container service. |
tests/images/trident-verity-testimage/usr/files/sudoers-wheel |
Removes migrated sudoers file. |
tests/images/trident-verity-testimage/usr/files/dracut-nohostonly.conf |
Removes migrated dracut config. |
tests/images/trident-verity-testimage/usr/container.yaml |
Removes legacy container usr-verity config. |
tests/images/trident-verity-testimage/README.md |
Removes legacy verity image documentation. |
tests/images/trident-verity-testimage/base/trident-debug-log.sh |
Removes migrated debug helper. |
tests/images/trident-verity-testimage/base/sudoers-wheel |
Removes legacy sudoers file. |
tests/images/trident-verity-testimage/base/files/use-grpc-client-commit.conf |
Removes migrated service override. |
tests/images/trident-verity-testimage/base/files/trident-container.service |
Removes migrated container service. |
tests/images/trident-verity-testimage/base/etc.mount |
Removes legacy mount unit. |
tests/images/trident-verity-testimage/base/etc-mount.sh |
Removes migrated overlay script. |
tests/images/trident-verity-testimage/base/etc-mount.service |
Removes migrated overlay service. |
tests/images/trident-verity-testimage/base/create-web-dir.sh |
Removes migrated setup script. |
tests/images/trident-verity-testimage/base/baseimg.yaml |
Removes legacy root-verity config. |
tests/images/trident-verity-testimage/base/baseimg-container.yaml |
Removes legacy container verity config. |
tests/images/trident-testimage/README.md |
Removes legacy test-image documentation. |
tests/images/trident-testimage/base/post-install.sh |
Removes migrated post-install script. |
tests/images/trident-testimage/base/files/use-grpc-client-commit.conf |
Removes migrated service override. |
tests/images/trident-testimage/base/baseimg.yaml |
Removes legacy test-image config. |
tests/images/trident-mos/post-install.sh |
Removes obsolete MOS setup script. |
tests/images/trident-mos/iso.yaml |
Removes obsolete MOS ISO config. |
tests/images/trident-mos/files/serial-getty@.service |
Removes legacy console service. |
tests/images/trident-mos/files/root.profile |
Removes legacy root profile. |
tests/images/trident-mos/files/rcp-agent.yaml |
Removes legacy patch placeholder. |
tests/images/trident-mos/files/pre-trident-script.sh |
Removes legacy patch placeholder. |
tests/images/trident-mos/files/getty@.service |
Removes legacy console service. |
tests/images/trident-mos/files/download-trident-container.service |
Removes obsolete container service. |
tests/images/trident-mos/files/config-placeholder.yaml |
Removes legacy config placeholder. |
tests/images/trident-mos/files/.gitignore |
Removes legacy generated-file exclusion. |
tests/images/trident-mos/containerhost-iso.yaml |
Removes obsolete container-host ISO config. |
tests/images/trident-installer/README.md |
Removes legacy installer documentation. |
tests/images/trident-installer/base/post-install.sh |
Removes migrated installer script. |
tests/images/trident-installer/base/files/trident-split-install.service |
Removes migrated split-install service. |
tests/images/trident-installer/base/files/trident-install.service |
Removes migrated install service. |
tests/images/trident-installer/base/files/serial-getty@.service |
Removes legacy console service. |
tests/images/trident-installer/base/files/root.profile |
Removes migrated root profile. |
tests/images/trident-installer/base/files/rcp-agent.yaml |
Removes migrated patch placeholder. |
tests/images/trident-installer/base/files/pre-trident-script.sh |
Removes migrated patch placeholder. |
tests/images/trident-installer/base/files/override-placeholder.conf |
Removes migrated override placeholder. |
tests/images/trident-installer/base/files/getty@.service |
Removes legacy console service. |
tests/images/trident-installer/base/files/direct-streaming-placeholder.conf |
Removes migrated streaming placeholder. |
tests/images/trident-installer/base/files/config-placeholder.yaml |
Removes migrated config placeholder. |
tests/images/trident-installer/base/baseimg.yaml |
Removes legacy installer config. |
tests/images/trident-installer/base/baseimg-split.yaml |
Removes legacy split-installer config. |
tests/images/trident-installer/base/baseimg-direct-streaming.yaml |
Removes legacy streaming installer config. |
tests/images/trident-functest/base/baseimg.yaml |
Removes legacy functional-test image config. |
tests/images/trident-container-testimage/README.md |
Removes legacy container-image documentation. |
tests/images/trident-container-testimage/base/scripts/post-install.sh |
Removes migrated post-install script. |
tests/images/trident-container-testimage/base/scripts/load-containerd-selinux-fix.sh |
Removes migrated SELinux helper. |
tests/images/trident-container-testimage/base/files/trident-container.service |
Removes migrated container service. |
tests/images/trident-container-testimage/base/files/containerd-mmap-fix.cil |
Removes migrated SELinux policy. |
tests/images/trident-container-testimage/base/baseimg.yaml |
Removes legacy container image config. |
tests/images/trident-container-installer/README.md |
Removes legacy container-installer documentation. |
tests/images/trident-container-installer/base/scripts/post-install.sh |
Removes migrated installer script. |
tests/images/trident-container-installer/base/scripts/load-containerd-selinux-fix.sh |
Removes migrated SELinux helper. |
tests/images/trident-container-installer/base/files/trident-container.service |
Removes migrated container service. |
tests/images/trident-container-installer/base/files/serial-getty@.service |
Removes legacy console service. |
tests/images/trident-container-installer/base/files/root.profile |
Removes migrated root profile. |
tests/images/trident-container-installer/base/files/override-placeholder.conf |
Removes migrated override placeholder. |
tests/images/trident-container-installer/base/files/getty@.service |
Removes legacy console service. |
tests/images/trident-container-installer/base/files/containerd-mmap-fix.cil |
Removes migrated SELinux policy. |
tests/images/trident-container-installer/base/files/config-placeholder.yaml |
Removes migrated config placeholder. |
tests/images/trident-container-installer/base/baseimg.yaml |
Removes legacy container-installer config. |
tests/images/testimages.py |
Removes the legacy image registry and CLI entry point. |
tests/images/builder/utils.py |
Removes legacy builder path utilities. |
tests/images/builder/sign.py |
Removes legacy artifact-signing implementation. |
tests/images/builder/run.py |
Removes legacy build orchestration. |
tests/images/builder/README.md |
Removes legacy builder documentation. |
tests/images/builder/download.py |
Removes legacy base-image downloader. |
tests/images/builder/customize.py |
Removes legacy Image Customizer wrapper. |
tests/images/builder/convert.py |
Removes legacy image conversion wrapper. |
tests/images/builder/context_managers.py |
Removes legacy cleanup utilities. |
tests/images/builder/cli.py |
Removes legacy builder CLI. |
tests/images/builder/builder.py |
Removes legacy image build implementation. |
tests/images/builder/__init__.py |
Removes legacy builder models and configuration. |
tests/images/azurelinux-direct-streaming-testimage/base/post-install.sh |
Removes migrated post-install script. |
tests/images/azurelinux-direct-streaming-testimage/base/baseimg.yaml |
Removes legacy direct-streaming config. |
tests/images/azl-installer/mos/scripts/startup-command.sh |
Removes migrated installer startup script. |
tests/images/azl-installer/mos/scripts/installation.sh |
Removes migrated installer workflow. |
tests/images/azl-installer/mos/files/serial-getty@.service |
Removes legacy console service. |
tests/images/azl-installer/mos/files/getty@.service |
Removes legacy console service. |
tests/images/azl-installer/iso/files/config-placeholder.yaml |
Removes migrated config placeholder. |
tests/images/azl-installer/iso/.gitignore |
Removes legacy generated-file exclusions. |
tests/images/azl-installer/installer-iso.yaml |
Removes legacy AZL installer config. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 12, 2026 18:13
4832f21 to
88181bb
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 12, 2026 19:23
88181bb to
1c8eeef
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 13, 2026 16:47
dd8bdd1 to
c05b1b2
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 13, 2026 17:48
c05b1b2 to
b505daf
Compare
Member
Author
|
Addressed the recurring review summary finding: |
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 13, 2026 18:22
b505daf to
d05b33c
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 13, 2026 18:53
d05b33c to
3cb974c
Compare
bfjelds (bfjelds)
force-pushed
the
user/bfjelds/tailor-cleanup
branch
from
October 13, 2026 19:23
3cb974c to
1102036
Compare
Member
Author
Delete the remaining tests/images tree now that the live Makefile and pipeline entry points read exclusively from tests/tailor-images. This removes the old testimages.py builder, its helper package, the superseded Image Customizer YAML stack, and the duplicated support files that were copied into the tailor workspace earlier in the stack. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/images/tree now that the Makefile and pipeline cutover (tests/images with tailor [3]: build with tailor #844) no longer depend on itTrident-ACL-Agent.md,Testing.md, andtools/storm/aclagent(10 references total)Stack
Notes
Validation
[GITHUB]-trident-pr-e2e: https://dev.azure.com/mariner-org/ECF/_build/results?buildId=1223932 (run once on the last PR in the stack -- tests/images with tailor [5]: move tests/tailor-images to tests/images #846's branch contains every commit from this PR through tests/images with tailor [5]: move tests/tailor-images to tests/images #846, so one pipeline run validates the whole stack instead of 5 redundant ones)