Skip to content

tests/images with tailor [5]: move tests/tailor-images to tests/images - #846

Draft
bfjelds (bfjelds) wants to merge 1 commit into
user/bfjelds/tailor-cleanupfrom
user/bfjelds/tailor-images-rename
Draft

bfjelds (bfjelds) wants to merge 1 commit into
user/bfjelds/tailor-cleanupfrom
user/bfjelds/tailor-images-rename

Conversation

@bfjelds

@bfjelds bfjelds (bfjelds) commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Summary

  • rename tests/tailor-images/ to tests/images/
  • rewrite the remaining path references in Makefile, pipeline templates, and docs, including 6 moved README files' own internal self-references (git mv renames paths, not file content)
  • keep the rename branch logic-free apart from path updates

Stack

Validation

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@bfjelds bfjelds (bfjelds) changed the title tests: rename tailor workspace to images tests/images with tailor [5]: move tests/tailor-images to tests/images Oct 10, 2026
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 83471e4 to 4b632ee Compare October 10, 2026 22:44
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 4b632ee to 34842e7 Compare October 11, 2026 00:06
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 34842e7 to 21580fb Compare October 11, 2026 00:26
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 21580fb to 3f5356e Compare October 11, 2026 00:42
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 3f5356e to f9eff4a Compare October 11, 2026 23:34
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from f9eff4a to e36fbb8 Compare October 12, 2026 16:29
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from e36fbb8 to eb922af Compare October 12, 2026 16:43
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from eb922af to 3ce94e8 Compare October 12, 2026 17:04
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 3ce94e8 to ff7e57c Compare October 12, 2026 17:23
@bfjelds
bfjelds (bfjelds) requested a balanced review from Copilot October 12, 2026 17:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a consistent path-only relocation, with no stale tailor-images references or lost executable permissions found.

0 open findings

What changed in this PR

Relocates the Tailor test-image workspace from tests/tailor-images/ to tests/images/ while preserving image definitions and executable permissions.

Changes:

  • Moves Tailor manifests, image configurations, scripts, and supporting files.
  • Updates Makefile, pipeline, and documentation path references.
  • Preserves existing image behavior and artifact naming.
File Description
.pipelines/​templates/​stages/​azl_installer/​azl-installer.yml Updates installer workspace paths.
.pipelines/​templates/​stages/​build_image/​build-image-template.yml Updates Tailor manifest and artifact paths.
.pipelines/​templates/​stages/​trident_images/​trident-testimg-template.yml Updates build, certificate, and log paths.
Makefile Updates image workspace and manifest paths.
docs/​Development/​Testing/​E2E-Tests.md Updates documented Tailor paths.
docs/​Development/​Testing/​Functional-Tests.md Updates documented Tailor paths.
docs/​Development/​Testing/​Rollback-Tests.md Updates documented VM-image paths.
docs/​Development/​Testing/​Servicing-Tests.md Updates documented VM-image paths.
tests/​images/​README.md Relocates workspace documentation and updates commands.
tests/​images/​tailor.yaml Relocates the Tailor workspace manifest.
tests/​images/​targets.mk Relocates Tailor-backed image targets.
tests/​images/​common/​files/​config-placeholder.yaml Relocates shared configuration placeholder.
tests/​images/​common/​files/​containerd-mmap-fix.cil Relocates shared SELinux policy.
tests/​images/​common/​files/​getty@.service Relocates shared getty unit.
tests/​images/​common/​files/​override-placeholder.conf Relocates shared override placeholder.
tests/​images/​common/​files/​serial-getty@.service Relocates shared serial-getty unit.
tests/​images/​common/​files/​sudoers-wheel Relocates shared sudoers configuration.
tests/​images/​common/​files/​trident-container.service Relocates shared container unit.
tests/​images/​common/​files/​use-grpc-client-commit.conf Relocates shared Trident override.
tests/​images/​common/​matrix/​base-core-arm64.yaml Relocates shared ARM64 base selector.
tests/​images/​azl-installer/​image.yaml Relocates AZL installer image definition.
tests/​images/​azl-installer/​installer-iso.yaml Relocates AZL installer configuration.
tests/​images/​azl-installer/​iso/​.gitignore Relocates generated ISO exclusions.
tests/​images/​azl-installer/​iso/​files/​config-placeholder.yaml Relocates installer configuration placeholder.
tests/​images/​azl-installer/​mos/​scripts/​installation.sh Relocates installation script.
tests/​images/​azl-installer/​mos/​scripts/​startup-command.sh Relocates installer startup script.
tests/​images/​azurelinux-direct-streaming-testimage/​image.yaml Relocates direct-streaming image definition.
tests/​images/​azurelinux-direct-streaming-testimage/​tailor/​baseimg.yaml Relocates direct-streaming base configuration.
tests/​images/​azurelinux-direct-streaming-testimage/​by-arch/​arm64.yaml Relocates ARM64 override.
tests/​images/​foreign-direct-streaming-testimage/​image.yaml Relocates foreign-image conversion definition.
tests/​images/​foreign-direct-streaming-testimage/​by-source/​ubuntu-2404.yaml Relocates Ubuntu 24.04 override.
tests/​images/​foreign-direct-streaming-testimage/​by-source/​gb200-2404.yaml Relocates GB200 override.
tests/​images/​foreign-direct-streaming-testimage/​by-arch+source/​arm64+ubuntu-2204.yaml Relocates ARM64 Ubuntu 22.04 override.
tests/​images/​foreign-direct-streaming-testimage/​by-arch+source/​arm64+ubuntu-2404.yaml Relocates ARM64 Ubuntu 24.04 override.
tests/​images/​trident-container-installer/​README.md Relocates documentation and updates its command.
tests/​images/​trident-container-installer/​image.yaml Relocates container-installer definition.
tests/​images/​trident-container-installer/​tailor/​baseimg.yaml Relocates container-installer configuration.
tests/​images/​trident-container-installer/​base/​files/​root.profile Relocates installer root profile.
tests/​images/​trident-container-installer/​base/​files/​trident-container.service Relocates container service.
tests/​images/​trident-container-installer/​base/​scripts/​load-containerd-selinux-fix.sh Relocates SELinux setup script.
tests/​images/​trident-container-installer/​base/​scripts/​post-install.sh Relocates post-install script.
tests/​images/​trident-container-testimage/​README.md Relocates documentation and updates its command.
tests/​images/​trident-container-testimage/​image.yaml Relocates container test-image definition.
tests/​images/​trident-container-testimage/​tailor/​baseimg.yaml Relocates container test-image configuration.
tests/​images/​trident-container-testimage/​base/​files/​trident-container.service Relocates container service.
tests/​images/​trident-container-testimage/​base/​scripts/​load-containerd-selinux-fix.sh Relocates SELinux setup script.
tests/​images/​trident-container-testimage/​base/​scripts/​post-install.sh Relocates post-install script.
tests/​images/​trident-functest/​image.yaml Relocates functional-test image definition.
tests/​images/​trident-functest/​tailor/​baseimg.yaml Relocates functional-test image configuration.
tests/​images/​trident-installer/​README.md Relocates documentation and updates its command.
tests/​images/​trident-installer/​image.yaml Relocates installer image definition.
tests/​images/​trident-installer/​include/​common-files.yaml Relocates shared file list.
tests/​images/​trident-installer/​include/​common-packages.yaml Relocates shared package list.
tests/​images/​trident-installer/​include/​kernel-args.yaml Relocates kernel arguments.
tests/​images/​trident-installer/​include/​storage.yaml Relocates storage configuration.
tests/​images/​trident-installer/​by-arch/​arm64.yaml Relocates ARM64 override.
tests/​images/​trident-installer/​by-variant/​direct-streaming.yaml Relocates direct-streaming override.
tests/​images/​trident-installer/​by-variant/​split.yaml Relocates split-installer override.
tests/​images/​trident-installer/​base/​post-install.sh Relocates post-install script.
tests/​images/​trident-installer/​base/​files/​direct-streaming-placeholder.conf Relocates direct-streaming placeholder.
tests/​images/​trident-installer/​base/​files/​pre-trident-script.sh Relocates pre-Trident placeholder.
tests/​images/​trident-installer/​base/​files/​rcp-agent.yaml Relocates RCP agent placeholder.
tests/​images/​trident-installer/​base/​files/​root.profile Relocates installer root profile.
tests/​images/​trident-installer/​base/​files/​trident-install.service Relocates install service.
tests/​images/​trident-installer/​base/​files/​trident-split-install.service Relocates split-install service.
tests/​images/​trident-testimage/​README.md Relocates documentation and updates its command.
tests/​images/​trident-testimage/​image.yaml Relocates test-image definition.
tests/​images/​trident-testimage/​tailor/​baseimg.yaml Relocates test-image configuration.
tests/​images/​trident-testimage/​by-arch/​arm64.yaml Relocates ARM64 override.
tests/​images/​trident-testimage/​base/​post-install.sh Relocates post-install script.
tests/​images/​trident-verity-testimage/​README.md Relocates documentation and updates its command.
tests/​images/​trident-verity-testimage/​image.yaml Relocates verity image definition.
tests/​images/​trident-verity-testimage/​include/​root-os-common.yaml Relocates root-verity OS configuration.
tests/​images/​trident-verity-testimage/​include/​root-storage.yaml Relocates root-verity storage configuration.
tests/​images/​trident-verity-testimage/​include/​usr-os-common.yaml Relocates usr-verity OS configuration.
tests/​images/​trident-verity-testimage/​include/​usr-storage.yaml Relocates usr-verity storage configuration.
tests/​images/​trident-verity-testimage/​by-mode/​root.yaml Relocates root-mode override.
tests/​images/​trident-verity-testimage/​by-mode/​usr.yaml Relocates usr-mode override.
tests/​images/​trident-verity-testimage/​by-deployment/​host.yaml Relocates host deployment override.
tests/​images/​trident-verity-testimage/​by-deployment/​container.yaml Relocates container deployment override.
tests/​images/​trident-verity-testimage/​by-deployment+mode/​host+root.yaml Relocates host root-verity override.
tests/​images/​trident-verity-testimage/​by-deployment+mode/​host+usr.yaml Relocates host usr-verity override.
tests/​images/​trident-verity-testimage/​by-deployment+mode/​container+root.yaml Relocates container root-verity override.
tests/​images/​trident-verity-testimage/​by-deployment+mode/​container+usr.yaml Relocates container usr-verity override.
tests/​images/​trident-verity-testimage/​base/​create-web-dir.sh Relocates web-directory setup script.
tests/​images/​trident-verity-testimage/​base/​etc-mount.sh Relocates overlay-mount script.
tests/​images/​trident-verity-testimage/​base/​etc-mount.service Relocates overlay-mount service.
tests/​images/​trident-verity-testimage/​base/​trident-debug-log.sh Relocates debug-log setup script.
tests/​images/​trident-verity-testimage/​usr/​files/​dracut-nohostonly.conf Relocates dracut configuration.
tests/​images/​trident-vm-testimage/​README.md Relocates VM image documentation.
tests/​images/​trident-vm-testimage/​image.yaml Relocates VM image matrix.
tests/​images/​trident-vm-testimage/​include/​grub-scripts.yaml Relocates GRUB script list.
tests/​images/​trident-vm-testimage/​include/​grub-verity-base-os-common.yaml Relocates base GRUB-verity OS configuration.
tests/​images/​trident-vm-testimage/​include/​grub-verity-base-scripts.yaml Relocates base GRUB-verity scripts.
tests/​images/​trident-vm-testimage/​include/​grub-verity-os-common.yaml Relocates GRUB-verity OS configuration.
tests/​images/​trident-vm-testimage/​include/​grub-verity-scripts.yaml Relocates GRUB-verity scripts.
tests/​images/​trident-vm-testimage/​include/​storage-acl-agent.yaml Relocates ACL-agent storage configuration.
tests/​images/​trident-vm-testimage/​include/​storage-grub-verity-base.yaml Relocates base GRUB-verity storage configuration.
tests/​images/​trident-vm-testimage/​include/​storage-grub-verity.yaml Relocates GRUB-verity storage configuration.
tests/​images/​trident-vm-testimage/​include/​storage-grub.yaml Relocates GRUB storage configuration.
tests/​images/​trident-vm-testimage/​include/​storage-root-verity.yaml Relocates root-verity storage configuration.
tests/​images/​trident-vm-testimage/​include/​storage-usr-verity.yaml Relocates usr-verity storage configuration.
tests/​images/​trident-vm-testimage/​include/​uki-verity-os-common.yaml Relocates UKI-verity OS configuration.
tests/​images/​trident-vm-testimage/​include/​uki-verity-scripts.yaml Relocates UKI-verity scripts.
tests/​images/​trident-vm-testimage/​by-arch/​arm64.yaml Relocates VM ARM64 override.
tests/​images/​trident-vm-testimage/​by-arch+scenario/​arm64+grub-verity.yaml Relocates ARM64 GRUB-verity override.
tests/​images/​trident-vm-testimage/​by-scenario/​acl-agent.yaml Relocates ACL-agent scenario.
tests/​images/​trident-vm-testimage/​by-scenario/​grub.yaml Relocates GRUB scenario.
tests/​images/​trident-vm-testimage/​by-scenario/​grub-verity.yaml Relocates GRUB-verity update scenario.
tests/​images/​trident-vm-testimage/​by-scenario/​grub-verity-base.yaml Relocates GRUB-verity base scenario.
tests/​images/​trident-vm-testimage/​by-scenario/​grub-verity-azure.yaml Relocates Azure GRUB-verity scenario.
tests/​images/​trident-vm-testimage/​by-scenario/​grub-verity+grub-verity-azure.yaml Relocates shared GRUB-verity override.
tests/​images/​trident-vm-testimage/​by-scenario/​root-verity.yaml Relocates root-verity scenario.
tests/​images/​trident-vm-testimage/​by-scenario/​root-verity+usr-verity+acl-agent.yaml Relocates shared UKI scenario override.
tests/​images/​trident-vm-testimage/​by-scenario/​usr-verity.yaml Relocates usr-verity scenario.
tests/​images/​trident-vm-testimage/​base/​.gitignore Relocates generated base-file exclusion.
tests/​images/​trident-vm-testimage/​base/​files/​.gitignore Relocates generated VM-file exclusions.
tests/​images/​trident-vm-testimage/​base/​files/​99-dhcp-eth0.network Relocates network configuration.
tests/​images/​trident-vm-testimage/​base/​files/​etc-mount-mic.service Relocates MIC overlay-mount service.
tests/​images/​trident-vm-testimage/​base/​files/​etc-mount.service Relocates overlay-mount service.
tests/​images/​trident-vm-testimage/​base/​files/​etc-mount.sh Relocates executable overlay-mount script.
tests/​images/​trident-vm-testimage/​base/​files/​sshd-keygen.service Relocates SSH key generation service.
tests/​images/​trident-vm-testimage/​base/​files/​trident-acl-agent-cert-install.service Relocates test certificate service.
tests/​images/​trident-vm-testimage/​base/​files/​trident-acl-agent-override.conf Relocates ACL-agent override.
tests/​images/​trident-vm-testimage/​base/​scripts/​create-rw-overlay-dirs.sh Relocates overlay setup script.
tests/​images/​trident-vm-testimage/​base/​scripts/​create-ssh-dirs.sh Relocates SSH directory setup script.
tests/​images/​trident-vm-testimage/​base/​scripts/​duid-type-to-link-layer.sh Relocates network DUID script.
tests/​images/​trident-vm-testimage/​base/​scripts/​lsblk.sh Relocates block-device diagnostic script.
tests/​images/​trident-vm-testimage/​base/​scripts/​post-install.sh Relocates post-install script.
tests/​images/​trident-vm-testimage/​base/​scripts/​prepare-update-config.sh Relocates regular update setup script.
tests/​images/​trident-vm-testimage/​base/​scripts/​prepare-update-config-usrverity.sh Relocates usr-verity update setup script.
tests/​images/​trident-vm-testimage/​base/​scripts/​prepare-update-config-verity.sh Relocates verity update setup script.
tests/​images/​trident-vm-testimage/​base/​scripts/​ssh-move-host-keys.sh Relocates SSH host-key configuration script.
tests/​images/​trident-vm-testimage/​base/​scripts/​update-host-status.sh Relocates host-status update script.
tests/​images/​trident-vm-testimage/​base/​scripts/​update-os-release.sh Relocates OS-version update script.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The relocation is consistent, preserves file permissions, and leaves no stale old-workspace references.

0 open findings

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The relocation is content-preserving, references are consistently updated, and no unresolved issues were found.

0 open findings

🧠 Review effort: Balanced

@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 38fadb0 to fd0f438 Compare October 13, 2026 18:22
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from fd0f438 to 515014d Compare October 13, 2026 18:54
bfjelds (bfjelds) added a commit that referenced this pull request Oct 13, 2026
Trident-ACL-Agent.md referenced trident-vm-testimage/by-scenario/
acl-agent.yaml missing its tests/tailor-images/ prefix. Testing.md
pointed at tests/images/trident-vm-testimage/, which does not exist
yet at this point in the stack -- the tests/tailor-images -> tests/
images rename lands later, in #846. Both now point at the actual
current tests/tailor-images/trident-vm-testimage/ path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 515014d to 78a676b Compare October 13, 2026 19:24
@bfjelds
bfjelds (bfjelds) requested a balanced review from Copilot October 13, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Several moved READMEs still reference the removed tests/tailor-images path, leaving documented commands unusable.

0 open findings

🧠 Review effort: Balanced

bfjelds (bfjelds) added a commit that referenced this pull request Oct 13, 2026
Trident-ACL-Agent.md referenced trident-vm-testimage/by-scenario/
acl-agent.yaml missing its tests/tailor-images/ prefix. Testing.md
pointed at tests/images/trident-vm-testimage/, which does not exist
yet at this point in the stack -- the tests/tailor-images -> tests/
images rename lands later, in #846. Both now point at the actual
current tests/tailor-images/trident-vm-testimage/ path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bfjelds
bfjelds (bfjelds) force-pushed the user/bfjelds/tailor-images-rename branch from 78a676b to eae2561 Compare October 13, 2026 20:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The depth-preserving rename is consistently reflected across build, pipeline, and documentation references with no stale old paths remaining.

0 open findings

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The relocation is consistent and no stale old-workspace references or behavioral changes remain.

0 open findings

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The relocated workspace README incorrectly says the already-removed legacy image builder still runs alongside Tailor.

0 open findings

🧠 Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The relocation is consistent and behavior-preserving; the remaining README wording issue is non-blocking.

0 open findings

🧠 Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants