Repository navigation
fix(agent): don't report a 409 with no selection as another answer winning - #21320
Conversation
…nning A 409 conflict body may omit selected or send null. toAskResolution turns that into an empty answered selection, so the old code compared the user's choice against [] and showed "answered somewhere else" plus a superseded error report. Only compare when the conflict actually names a selection, which is the guard the 202 path already has.
📦 Bundle: 11.6 MB gzip 🔴 +25 BDetailsSummary
Category Glance App Entry Points — 6.9 kB (baseline 6.9 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.4 MB (baseline 3.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 787 kB (baseline 787 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 32 unchanged User & Accounts — 152 kB (baseline 152 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 362 kB (baseline 362 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 13 unchanged UI Components — 227 kB (baseline 227 kB) • ⚪ 0 BReusable component library chunks Status: 30 unchanged Data & Services — 1.22 MB (baseline 1.22 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 43 unchanged Utilities & Hooks — 1.02 MB (baseline 1.02 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 77 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.6 MB (baseline 20.6 MB) • 🔴 +69 BBundles that do not match a named category
Status: 2 added / 2 removed / 683 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-18T23:11:16.892Z",
"gitSha": "87bfdc2e5457356ca142b8bbdad3ff75516fe8d1",
"branch": "fix/agent-ask-409-no-selection",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.4879999999625,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6700000000000004,
"layouts": 10,
"layoutDurationMs": 2.6769999999999996,
"taskDurationMs": 421.5640000000001,
"heapDeltaBytes": -12046444,
"heapUsedBytes": 92084696,
"domNodes": -196,
"jsHeapTotalBytes": 1478656,
"scriptDurationMs": 9.557,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.556000000085,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6889999999999996,
"layouts": 9,
"layoutDurationMs": 2.5319999999999996,
"taskDurationMs": 589.158,
"heapDeltaBytes": -17777572,
"heapUsedBytes": 86415412,
"domNodes": -196,
"jsHeapTotalBytes": 2265088,
"scriptDurationMs": 10.517,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.263000000009,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.099,
"layouts": 10,
"layoutDurationMs": 2.9090000000000003,
"taskDurationMs": 797.2660000000001,
"heapDeltaBytes": -15496700,
"heapUsedBytes": 88670460,
"domNodes": -196,
"jsHeapTotalBytes": 2527232,
"scriptDurationMs": 166.829,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666981132075474,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.0819999999958,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.173,
"layouts": 10,
"layoutDurationMs": 3.172,
"taskDurationMs": 800.1809999999999,
"heapDeltaBytes": -8543480,
"heapUsedBytes": 95246100,
"domNodes": -176,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 169.20499999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0400000000354,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.094999999999999,
"layouts": 11,
"layoutDurationMs": 2.6799999999999997,
"taskDurationMs": 295.851,
"heapDeltaBytes": 1852080,
"heapUsedBytes": 106018952,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.679999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.7949999999719,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.411999999999999,
"layouts": 12,
"layoutDurationMs": 3.3689999999999998,
"taskDurationMs": 293.374,
"heapDeltaBytes": -522044,
"heapUsedBytes": 99224556,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.785999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 667.4499999999739,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.806,
"layouts": 10,
"layoutDurationMs": 2.673,
"taskDurationMs": 488.26399999999995,
"heapDeltaBytes": 6914488,
"heapUsedBytes": 110595180,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 163.44,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923078,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 699.2660000000797,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.726,
"layouts": 9,
"layoutDurationMs": 2.459,
"taskDurationMs": 499.363,
"heapDeltaBytes": 6963404,
"heapUsedBytes": 110636988,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 168.55100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1203.249000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 900.726,
"heapDeltaBytes": -3387036,
"heapUsedBytes": 101567620,
"domNodes": -206,
"jsHeapTotalBytes": 8368128,
"scriptDurationMs": 68.848,
"eventListeners": -168,
"totalBlockingTimeMs": 516,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1202.9390000000149,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 904.466,
"heapDeltaBytes": -2689008,
"heapUsedBytes": 102324780,
"domNodes": -206,
"jsHeapTotalBytes": 9678848,
"scriptDurationMs": 66.593,
"eventListeners": -168,
"totalBlockingTimeMs": 513,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.2290000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.4060000000006,
"heapDeltaBytes": -3718532,
"heapUsedBytes": 96204800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.72600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.762857142857136,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.0669999999291,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.1469999999999,
"heapDeltaBytes": -3378604,
"heapUsedBytes": 91605620,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.81799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11530.813999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10754.414999999999,
"heapDeltaBytes": 32908224,
"heapUsedBytes": 154388768,
"domNodes": -272,
"jsHeapTotalBytes": 44470272,
"scriptDurationMs": 8669.230000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1703,
"frameDurationMs": 31.989722222222227,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9501.437000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8683.126,
"heapDeltaBytes": 3768264,
"heapUsedBytes": 125372044,
"domNodes": -292,
"jsHeapTotalBytes": 28217344,
"scriptDurationMs": 7160.993,
"eventListeners": -130,
"totalBlockingTimeMs": 813,
"frameDurationMs": 31.77123745819398,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10048.767999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9255.776,
"heapDeltaBytes": 34472888,
"heapUsedBytes": 147399660,
"domNodes": -272,
"jsHeapTotalBytes": 25137152,
"scriptDurationMs": 7333.591,
"eventListeners": -130,
"totalBlockingTimeMs": 701,
"frameDurationMs": 31.306853582554517,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10265.885000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9430.146999999999,
"heapDeltaBytes": 22005636,
"heapUsedBytes": 144396212,
"domNodes": -272,
"jsHeapTotalBytes": 35098624,
"scriptDurationMs": 7526.669,
"eventListeners": -130,
"totalBlockingTimeMs": 746,
"frameDurationMs": 31.395412844036702,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 216.90300000000207,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.544,
"layouts": 12,
"layoutDurationMs": 3.2199999999999998,
"taskDurationMs": 163.565,
"heapDeltaBytes": 13274720,
"heapUsedBytes": 120321752,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.413,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "large-combo-open",
"durationMs": 208.71899999997368,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.67,
"layouts": 11,
"layoutDurationMs": 3.8220000000000005,
"taskDurationMs": 161.563,
"heapDeltaBytes": 13277296,
"heapUsedBytes": 118094624,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.463,
"eventListeners": 196,
"totalBlockingTimeMs": 5,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2005.5919999999787,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.908,
"layouts": 8,
"layoutDurationMs": 2.439,
"taskDurationMs": 470.68600000000004,
"heapDeltaBytes": 1378160,
"heapUsedBytes": 103923152,
"domNodes": -292,
"jsHeapTotalBytes": -4026368,
"scriptDurationMs": 29.703000000000007,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.9529999999922,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.239,
"layouts": 7,
"layoutDurationMs": 2.324,
"taskDurationMs": 674.108,
"heapDeltaBytes": -1601524,
"heapUsedBytes": 101549440,
"domNodes": -292,
"jsHeapTotalBytes": -618496,
"scriptDurationMs": 32.294,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2729.9090000000206,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.459,
"layouts": 7,
"layoutDurationMs": 1.905,
"taskDurationMs": 1704.7879999999998,
"heapDeltaBytes": -808936,
"heapUsedBytes": 99991724,
"domNodes": -272,
"jsHeapTotalBytes": -1441792,
"scriptDurationMs": 826.177,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2271.637999999939,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.179,
"layouts": 6,
"layoutDurationMs": 1.6409999999999998,
"taskDurationMs": 1567.759,
"heapDeltaBytes": 548268,
"heapUsedBytes": 103822288,
"domNodes": -292,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 827.571,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79029850746269,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3804.5829999999796,
"styleRecalcs": 71,
"styleRecalcDurationMs": 6.717,
"layouts": 64,
"layoutDurationMs": 9.992,
"taskDurationMs": 1765.1570000000004,
"heapDeltaBytes": -397600,
"heapUsedBytes": 105469304,
"domNodes": -268,
"jsHeapTotalBytes": -684032,
"scriptDurationMs": 757.017,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3876.3349999999264,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.292000000000001,
"layouts": 64,
"layoutDurationMs": 10.652999999999999,
"taskDurationMs": 1828.292,
"heapDeltaBytes": 4858300,
"heapUsedBytes": 109553304,
"domNodes": -248,
"jsHeapTotalBytes": -1273856,
"scriptDurationMs": 781.7879999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73793103448276,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3243.864999999971,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.890000000000001,
"layouts": 5,
"layoutDurationMs": 1.4620000000000006,
"taskDurationMs": 2097.205,
"heapDeltaBytes": 325612,
"heapUsedBytes": 106969856,
"domNodes": -272,
"jsHeapTotalBytes": 3076096,
"scriptDurationMs": 1035.382,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.838860103626942,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2880.700000000047,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.069,
"layouts": 5,
"layoutDurationMs": 1.5969999999999995,
"taskDurationMs": 1813.3729999999998,
"heapDeltaBytes": 17497720,
"heapUsedBytes": 123818140,
"domNodes": 0,
"jsHeapTotalBytes": 8286208,
"scriptDurationMs": 979.7459999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.861764705882354,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2028.6060000000248,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.165,
"layouts": 7,
"layoutDurationMs": 2.3109999999999995,
"taskDurationMs": 479.923,
"heapDeltaBytes": 7565668,
"heapUsedBytes": 110120972,
"domNodes": -272,
"jsHeapTotalBytes": -5599232,
"scriptDurationMs": 33.190000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.1720000000641,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3120000000000007,
"layouts": 8,
"layoutDurationMs": 1.996,
"taskDurationMs": 467.52399999999994,
"heapDeltaBytes": 3942628,
"heapUsedBytes": 106671628,
"domNodes": -292,
"jsHeapTotalBytes": -5337088,
"scriptDurationMs": 34.834999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.8219999999842,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.885000000000001,
"layouts": 10,
"layoutDurationMs": 2.8160000000000003,
"taskDurationMs": 452.75899999999996,
"heapDeltaBytes": 590356,
"heapUsedBytes": 106263508,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 149.25900000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.5620000000781,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.869,
"layouts": 9,
"layoutDurationMs": 2.668,
"taskDurationMs": 443.878,
"heapDeltaBytes": 3141388,
"heapUsedBytes": 109375624,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 145.36599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.1849999999886,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0360000000000005,
"layouts": 11,
"layoutDurationMs": 3.3479999999999994,
"taskDurationMs": 582.691,
"heapDeltaBytes": -15147396,
"heapUsedBytes": 90952808,
"domNodes": -214,
"jsHeapTotalBytes": 2002944,
"scriptDurationMs": 7.932999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.341999999957,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9790000000000005,
"layouts": 9,
"layoutDurationMs": 2.91,
"taskDurationMs": 539.045,
"heapDeltaBytes": 3455528,
"heapUsedBytes": 95891228,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.283000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.0020000000022,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.093,
"layouts": 9,
"layoutDurationMs": 2.4530000000000003,
"taskDurationMs": 656.104,
"heapDeltaBytes": 20889656,
"heapUsedBytes": 113921900,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 104.669,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1996.4899999999943,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.503,
"layouts": 8,
"layoutDurationMs": 2.4800000000000004,
"taskDurationMs": 1074.7469999999998,
"heapDeltaBytes": 19287716,
"heapUsedBytes": 111377808,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 113.574,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.8799999999933,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.791,
"layouts": 5,
"layoutDurationMs": 15.895000000000003,
"taskDurationMs": 1074.14,
"heapDeltaBytes": 4743468,
"heapUsedBytes": 123178984,
"domNodes": 15950,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 29.943999999999992,
"eventListeners": 3244,
"totalBlockingTimeMs": 160,
"frameDurationMs": 19.554666666666673,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10049.769000000026,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.796,
"layouts": 8,
"layoutDurationMs": 2.104,
"taskDurationMs": 5989.875,
"heapDeltaBytes": -7675168,
"heapUsedBytes": 111666548,
"domNodes": -272,
"jsHeapTotalBytes": -585728,
"scriptDurationMs": 2698.565,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72146422628952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10082.548000000088,
"styleRecalcs": 251,
"styleRecalcDurationMs": 17.643,
"layouts": 8,
"layoutDurationMs": 2.1769999999999996,
"taskDurationMs": 5993.073,
"heapDeltaBytes": -12859600,
"heapUsedBytes": 108298968,
"domNodes": -292,
"jsHeapTotalBytes": -61440,
"scriptDurationMs": 2688.806,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.721227197346604,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15236.091000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14702.172,
"heapDeltaBytes": -6842860,
"heapUsedBytes": 304851888,
"domNodes": -3330,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 235.01899999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.846440677966104,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 22893.88199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21961.440000000002,
"heapDeltaBytes": -32060380,
"heapUsedBytes": 287546720,
"domNodes": -3334,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 327.63,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.69326424870466,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 19091.136000000006,
"styleRecalcs": 167,
"styleRecalcDurationMs": 12.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18736.825,
"heapDeltaBytes": -12105104,
"heapUsedBytes": 293082568,
"domNodes": -3330,
"jsHeapTotalBytes": 21483520,
"scriptDurationMs": 827.468,
"eventListeners": -651,
"totalBlockingTimeMs": 16,
"frameDurationMs": 33.954626334519574,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19356.69800000005,
"styleRecalcs": 171,
"styleRecalcDurationMs": 12.81199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18933.188000000002,
"heapDeltaBytes": -10498604,
"heapUsedBytes": 309192460,
"domNodes": -3330,
"jsHeapTotalBytes": 15384576,
"scriptDurationMs": 871.561,
"eventListeners": -651,
"totalBlockingTimeMs": 18,
"frameDurationMs": 34.768402154398565,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5771.423000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.1,
"layouts": 20,
"layoutDurationMs": 22.396,
"taskDurationMs": 5626.449999999999,
"heapDeltaBytes": -31830868,
"heapUsedBytes": 293300716,
"domNodes": -3330,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 111.509,
"eventListeners": -653,
"totalBlockingTimeMs": 20,
"frameDurationMs": 32.95142857142857,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8155.90300000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.59000000000002,
"layouts": 20,
"layoutDurationMs": 22.133,
"taskDurationMs": 7981.211000000001,
"heapDeltaBytes": -30635184,
"heapUsedBytes": 289002848,
"domNodes": -3330,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 149.33,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.05243243243244,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11347.555999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10938.599999999999,
"heapDeltaBytes": -10171964,
"heapUsedBytes": 271187268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.87299999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.86815068493151,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11831.55499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11492.999,
"heapDeltaBytes": -12806556,
"heapUsedBytes": 525792304,
"domNodes": 0,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 162.501,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.523287671232886,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 506.41999999999143,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.706999999999999,
"layouts": 13,
"layoutDurationMs": 5.338000000000001,
"taskDurationMs": 160.258,
"heapDeltaBytes": -7758048,
"heapUsedBytes": 95156860,
"domNodes": 128,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 18.681000000000004,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 446.5139999999792,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.161999999999999,
"layouts": 12,
"layoutDurationMs": 3.09,
"taskDurationMs": 100.702,
"heapDeltaBytes": -13143884,
"heapUsedBytes": 88697612,
"domNodes": 95,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.312999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 437.4990000000025,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.716,
"layouts": 76,
"layoutDurationMs": 14.399000000000001,
"taskDurationMs": 392.58899999999994,
"heapDeltaBytes": 11647484,
"heapUsedBytes": 80988088,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 190.76800000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 459.8120000000563,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.003,
"layouts": 76,
"layoutDurationMs": 14.179,
"taskDurationMs": 416.899,
"heapDeltaBytes": -14155224,
"heapUsedBytes": 80511940,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 200.586,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 491.4969999999812,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.625,
"layouts": 76,
"layoutDurationMs": 14.305,
"taskDurationMs": 452.101,
"heapDeltaBytes": -4594032,
"heapUsedBytes": 102567284,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 181.372,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 588.436999999999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.631,
"layouts": 76,
"layoutDurationMs": 13.171999999999999,
"taskDurationMs": 530.3299999999999,
"heapDeltaBytes": 663060,
"heapUsedBytes": 117472084,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 213.12499999999997,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.675757575757554,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2933 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ae3f60fa8a2086e2f0aff2a6eae57bb94cb4f4db
Full docs: ADR-DEVEX-LINT-0015 |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21320 +/- ##
==========================================
+ Coverage 86.64% 87.46% +0.82%
==========================================
Files 3774 2697 -1077
Lines 178429 149762 -28667
Branches 49222 38944 -10278
==========================================
- Hits 154603 130994 -23609
+ Misses 21759 18378 -3381
+ Partials 2067 390 -1677
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1085 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit db24a82 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
…Org#21829) ## Summary Follow-up to Comfy-Org#21320. That PR stopped a 409 with no selection from raising a false "answered somewhere else" notice, but its guard only looked at `selected`. The ask conflict schema also allows a committed free-text-only answer (`status: answered`, `selected` null or omitted, `other_text` set). In that case the 409 does name the winning answer, and the user got no superseded notice and no telemetry. ## Change - One predicate, `namesCommittedAnswer`: a body names the committed answer when it carries a `selected` array or non-empty `other_text`. - The check moved inside `reportSupersededAnswer`, so all three sources share it: the 202 receipt, the 409 conflict and the `agent_ask_resolved` frame. The frame path had no guard before, so an answered frame with a null selection also raised a false superseded report. - Removes the `//` comment Comfy-Org#21320 added (AGENTS.md); the predicate name carries the reason. `selected: []` still counts as naming an answer, matching the existing `reports an empty committed answer that replaced this one` test and the schema ("empty when the answer was free text only"). ## Tests (written first) - `reports a 409 whose free text alone shows another answer won` (null and omitted `selected`): failed before, pass now. - `does not report an answered frame with a null selection as another answer winning`: failed before, passes now. - `reports / does not report a 202 that names only free text` and `... a free-text-only frame` (second commit, from review). Against main's source the 202 "reports" case fails; the others pin behavior that already held. - `useAgentSession.test.ts`: 261 pass. Agent suite: 4194 pass; the only failure is the known order-dependent `(g18)` test (FE-3485), which also fails on main. - typecheck, oxlint, eslint, format clean. ## Review A fresh Claude reviewer (adversarial-review, Skeptic + Minimalist; no cross-model CLI available on this host) found no blockers or majors. Its test-gap and duplicated-type notes are in the second commit. Not changed here: the superseded telemetry message (being rewritten in Comfy-Org#21327), and an answered frame with `selected: null` still renders as an empty answer (out of contract per the schema; unchanged). ## Review threads on Comfy-Org#21320 This addresses the Medium, the frame-path Low and the Nit. Replies on Comfy-Org#21320 explain the other two Lows. ## Overlap Comfy-Org#21327 edits the body of `reportSupersededAnswer` below the new guard. Whichever lands second needs a small rebase; no behavior conflict.
|
@christian-byrne Successfully backported to #21869 |
|
@christian-byrne Successfully backported to #21870 |
|
@christian-byrne Successfully backported to #21871 |
|
@christian-byrne Successfully backported to #21872 |
…, tested revision) (#21877) ## Summary `upload-e2e-coverage / package` fails on every PR to `cloud/1.57`: lcov 2.4 aborts the shard merge with `(inconsistent) duplicate function 'inner_clicked'` (LiteGraph has several same-named closures in one file). `main` (in #17623) and `core/1.57` already pass `--ignore-errors inconsistent,corrupt` to that merge. This brings the same two lines to `cloud/1.57`. Function coverage is not published; line data is kept. ## Changes - `scripts/cicd/package-e2e-coverage.sh`: the file now matches `core/1.57` byte for byte. ## Evidence Failing on the `cloud/1.57` backport of #21320: `lcov: ERROR: (corrupt) unable to read trace file ... duplicate function 'inner_clicked' starts on line "src/lib/litegraph/src/LGraphCanvas.ts":1431`. The same backport to `core/1.57` (#21869) passed this job. CI-only. No app code changes. Related: #21840 (the same fix for `main`, now redundant there).
… tested revision) (#21878) ## Summary `upload-e2e-coverage / package` fails on every PR to `core/1.58`: lcov 2.4 aborts the shard merge with `(inconsistent) duplicate function 'inner_clicked'` (LiteGraph has several same-named closures in one file). `main` (in #17623) and `core/1.57` already pass `--ignore-errors inconsistent,corrupt` to that merge. This brings the same two lines to `core/1.58`. Function coverage is not published; line data is kept. ## Changes - `scripts/cicd/package-e2e-coverage.sh`: the file now matches `core/1.57` byte for byte. ## Evidence Failing on the `core/1.58` backport of #21320: `lcov: ERROR: (corrupt) unable to read trace file ... duplicate function 'inner_clicked' starts on line "src/lib/litegraph/src/LGraphCanvas.ts":1431`. The same backport to `core/1.57` (#21869) passed this job. CI-only. No app code changes. Related: #21840 (the same fix for `main`, now redundant there).
…, tested revision) (#21879) ## Summary `upload-e2e-coverage / package` fails on every PR to `cloud/1.58`: lcov 2.4 aborts the shard merge with `(inconsistent) duplicate function 'inner_clicked'` (LiteGraph has several same-named closures in one file). `main` (in #17623) and `core/1.57` already pass `--ignore-errors inconsistent,corrupt` to that merge. This brings the same two lines to `cloud/1.58`. Function coverage is not published; line data is kept. ## Changes - `scripts/cicd/package-e2e-coverage.sh`: the file now matches `core/1.57` byte for byte. ## Evidence Failing on the `cloud/1.58` backport of #21320: `lcov: ERROR: (corrupt) unable to read trace file ... duplicate function 'inner_clicked' starts on line "src/lib/litegraph/src/LGraphCanvas.ts":1431`. The same backport to `core/1.57` (#21869) passed this job. CI-only. No app code changes. Related: #21840 (the same fix for `main`, now redundant there).
Summary
A 409 from the ask answer endpoint can come back with
selectedmissing ornull(AgentAskConflict.selectedis nullish).toAskResolutionturns that into an answered resolution withselected: [], and the 409 branch always ran the superseded check. So a user who picked an option got a false "answered somewhere else" notice and anagent_ask_answer_supersedederror report, even though nothing said another answer won.Fix: only run the superseded comparison when the conflict body actually carries a selection array. This is the same guard the 202 path already has (
receipt.selected !== undefined). The card is still retired with the conflict's status, as before.Found by the cursor-review panel on the 1.57 backports of #19981/#20092 (#21308, #21309). The code there is identical to main, so this fix goes to main first and is backported after those land.
Tests
does not report a 409 with no selection as another answer winningand... with a null selection ...inuseAgentSession.test.ts. Both fail on main before the fix (reportErrorcalled withagent_ask_answer_superseded) and pass after.shows the answer a 409 reports as already committed(409 that names another selection) still reports superseded.useAgentSession.test.ts: 253 pass. The one failure is the known order-dependent(g18)test, which fails on main without this change (https://linear.app/comfyorg/issue/FE-3485).