Repository navigation
[backport cloud/1.58] fix(agent): don't report a 409 with no selection as another answer winning - #21872
Conversation
…nning (#21320) ## Summary A 409 from the ask answer endpoint can come back with `selected` missing or `null` (`AgentAskConflict.selected` is nullish). `toAskResolution` turns that into an answered resolution with `selected: []`, and the 409 branch always ran the superseded check. So a user who picked an option got a false "answered somewhere else" notice and an `agent_ask_answer_superseded` error report, even though nothing said another answer won. Fix: only run the superseded comparison when the conflict body actually carries a selection array. This is the same guard the 202 path already has (`receipt.selected !== undefined`). The card is still retired with the conflict's status, as before. Found by the cursor-review panel on the 1.57 backports of #19981/#20092 (#21308, #21309). The code there is identical to main, so this fix goes to main first and is backported after those land. ## Tests - New: `does not report a 409 with no selection as another answer winning` and `... with a null selection ...` in `useAgentSession.test.ts`. Both fail on main before the fix (`reportError` called with `agent_ask_answer_superseded`) and pass after. - Existing `shows the answer a 409 reports as already committed` (409 that names another selection) still reports superseded. - `useAgentSession.test.ts`: 253 pass. The one failure is the known order-dependent `(g18)` test, which fails on main without this change (https://linear.app/comfyorg/issue/FE-3485).
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-24T02:31:56.804Z",
"gitSha": "136c61952dddaae1bbc0c0a3680fc4ae37da0cd1",
"branch": "backport-21320-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.6890000000235,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2569999999999997,
"layouts": 9,
"layoutDurationMs": 2.342,
"taskDurationMs": 403.72200000000004,
"heapDeltaBytes": 2672604,
"heapUsedBytes": 93349236,
"domNodes": -201,
"jsHeapTotalBytes": -466944,
"scriptDurationMs": 8.005999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2026.4720000000125,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2129999999999996,
"layouts": 9,
"layoutDurationMs": 2.424,
"taskDurationMs": 410.749,
"heapDeltaBytes": 6833600,
"heapUsedBytes": 97203396,
"domNodes": -180,
"jsHeapTotalBytes": 1630208,
"scriptDurationMs": 8.180999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1994.38600000002,
"styleRecalcs": 82,
"styleRecalcDurationMs": 12.885999999999997,
"layouts": 10,
"layoutDurationMs": 2.598,
"taskDurationMs": 1085.142,
"heapDeltaBytes": -23699648,
"heapUsedBytes": 81016240,
"domNodes": -200,
"jsHeapTotalBytes": 3215360,
"scriptDurationMs": 155.12599999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2009.736000000089,
"styleRecalcs": 84,
"styleRecalcDurationMs": 12.844000000000001,
"layouts": 10,
"layoutDurationMs": 2.5869999999999997,
"taskDurationMs": 1102.6689999999999,
"heapDeltaBytes": 485440,
"heapUsedBytes": 91160440,
"domNodes": -200,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 154.26800000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.3300000000186,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.6,
"layouts": 11,
"layoutDurationMs": 2.648,
"taskDurationMs": 285.98699999999997,
"heapDeltaBytes": -1262996,
"heapUsedBytes": 91013080,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.970999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1793.0850000000191,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.787000000000002,
"layouts": 11,
"layoutDurationMs": 2.785,
"taskDurationMs": 341.026,
"heapDeltaBytes": -1309920,
"heapUsedBytes": 89498308,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.921000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 678.2279999999901,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.49,
"layouts": 9,
"layoutDurationMs": 2.484,
"taskDurationMs": 506.44,
"heapDeltaBytes": 3923084,
"heapUsedBytes": 103746228,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 165.426,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 656.7469999999958,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6570000000000005,
"layouts": 9,
"layoutDurationMs": 2.2850000000000006,
"taskDurationMs": 484.93500000000006,
"heapDeltaBytes": 5862844,
"heapUsedBytes": 96522856,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 165.52100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1237.0169999999803,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 847.664,
"heapDeltaBytes": 12779276,
"heapUsedBytes": 131673876,
"domNodes": -230,
"jsHeapTotalBytes": 12804096,
"scriptDurationMs": 65.78399999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 590,
"frameDurationMs": 36.27058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1201.930999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 812.4209999999999,
"heapDeltaBytes": 8629396,
"heapUsedBytes": 127581364,
"domNodes": -171,
"jsHeapTotalBytes": 13590528,
"scriptDurationMs": 61.70400000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 556,
"frameDurationMs": 35.291176470588226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 831.1630000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.35100000000006,
"heapDeltaBytes": -2847408,
"heapUsedBytes": 97957464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.49699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 206,
"frameDurationMs": 24.508823529411796,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.2449999999826,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.7290000000003,
"heapDeltaBytes": -2825468,
"heapUsedBytes": 99270928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.51999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10566.536999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9761.438999999998,
"heapDeltaBytes": 47602872,
"heapUsedBytes": 162362808,
"domNodes": -296,
"jsHeapTotalBytes": 56942592,
"scriptDurationMs": 7654.994,
"eventListeners": -130,
"totalBlockingTimeMs": 745,
"frameDurationMs": 31.826204819277105,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9059.45700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8265.96,
"heapDeltaBytes": 25069568,
"heapUsedBytes": 128199788,
"domNodes": -276,
"jsHeapTotalBytes": 27844608,
"scriptDurationMs": 6839.007,
"eventListeners": -130,
"totalBlockingTimeMs": 510,
"frameDurationMs": 32.43620071684588,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9885.690000000011,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.040000000000000105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9098.057999999999,
"heapDeltaBytes": 35881764,
"heapUsedBytes": 150048068,
"domNodes": -276,
"jsHeapTotalBytes": 27152384,
"scriptDurationMs": 7271.728999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 637,
"frameDurationMs": 31.880645161290328,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9912.679000000026,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05199999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9091.197000000002,
"heapDeltaBytes": 45274248,
"heapUsedBytes": 148677968,
"domNodes": -296,
"jsHeapTotalBytes": 33611776,
"scriptDurationMs": 7598.822999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1084,
"frameDurationMs": 31.627795527156554,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 191.31299999997964,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.749,
"layouts": 10,
"layoutDurationMs": 2.744,
"taskDurationMs": 141.279,
"heapDeltaBytes": 13204164,
"heapUsedBytes": 120676128,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.488999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.925000000000068,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 292.8779999999733,
"styleRecalcs": 28,
"styleRecalcDurationMs": 13.3,
"layouts": 12,
"layoutDurationMs": 3.246,
"taskDurationMs": 240.612,
"heapDeltaBytes": 15688576,
"heapUsedBytes": 121283576,
"domNodes": 917,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 9.347000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.006666666666693,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2039.972999999975,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1980000000000004,
"layouts": 8,
"layoutDurationMs": 2.177,
"taskDurationMs": 482.63499999999993,
"heapDeltaBytes": 602444,
"heapUsedBytes": 111020220,
"domNodes": -300,
"jsHeapTotalBytes": -991232,
"scriptDurationMs": 30.839,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.7530000000188,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.152,
"layouts": 8,
"layoutDurationMs": 2.1990000000000003,
"taskDurationMs": 466.3219999999999,
"heapDeltaBytes": 294816,
"heapUsedBytes": 110829684,
"domNodes": -296,
"jsHeapTotalBytes": -1253376,
"scriptDurationMs": 27.561999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2256.4540000000193,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.886000000000001,
"layouts": 6,
"layoutDurationMs": 1.596,
"taskDurationMs": 1500.088,
"heapDeltaBytes": 831580,
"heapUsedBytes": 112395500,
"domNodes": -296,
"jsHeapTotalBytes": 20480,
"scriptDurationMs": 813.146,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.916541353383455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2226.054999999974,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.551,
"layouts": 7,
"layoutDurationMs": 1.8,
"taskDurationMs": 1500.69,
"heapDeltaBytes": 1891160,
"heapUsedBytes": 112820980,
"domNodes": -296,
"jsHeapTotalBytes": 282624,
"scriptDurationMs": 794.5899999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.920610687022897,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3482.0649999999773,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.268,
"layouts": 66,
"layoutDurationMs": 10.109,
"taskDurationMs": 1570.2889999999998,
"heapDeltaBytes": -1612296,
"heapUsedBytes": 111161028,
"domNodes": -252,
"jsHeapTotalBytes": -598016,
"scriptDurationMs": 762.032,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746634615384615,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3732.5049999999464,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.823,
"layouts": 64,
"layoutDurationMs": 9.877,
"taskDurationMs": 1746.831,
"heapDeltaBytes": 4923940,
"heapUsedBytes": 130104720,
"domNodes": 24,
"jsHeapTotalBytes": 25731072,
"scriptDurationMs": 773.015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666367713004487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2650.771999999961,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.527,
"layouts": 5,
"layoutDurationMs": 1.515,
"taskDurationMs": 1693.083,
"heapDeltaBytes": -12020544,
"heapUsedBytes": 102856344,
"domNodes": 0,
"jsHeapTotalBytes": 6033408,
"scriptDurationMs": 915.203,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.878343949044588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2689.0359999999873,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.358,
"layouts": 4,
"layoutDurationMs": 0.9959999999999999,
"taskDurationMs": 1675.741,
"heapDeltaBytes": 17210116,
"heapUsedBytes": 132253616,
"domNodes": 0,
"jsHeapTotalBytes": 6713344,
"scriptDurationMs": 920.602,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.982911392405065,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.4100000000371,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7990000000000002,
"layouts": 8,
"layoutDurationMs": 2.351,
"taskDurationMs": 637.0910000000001,
"heapDeltaBytes": -594992,
"heapUsedBytes": 112169300,
"domNodes": -296,
"jsHeapTotalBytes": -1777664,
"scriptDurationMs": 29.085999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.5609999999397,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0349999999999997,
"layouts": 8,
"layoutDurationMs": 2.1989999999999994,
"taskDurationMs": 490.08799999999997,
"heapDeltaBytes": -57424,
"heapUsedBytes": 113121452,
"domNodes": -296,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 32.29,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.9119999999793,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.366,
"layouts": 9,
"layoutDurationMs": 2.038,
"taskDurationMs": 431.809,
"heapDeltaBytes": -1152372,
"heapUsedBytes": 100926736,
"domNodes": 0,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 142.661,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.9579999999614,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.349,
"layouts": 9,
"layoutDurationMs": 2.078,
"taskDurationMs": 374.15,
"heapDeltaBytes": -624000,
"heapUsedBytes": 89846880,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 148.60999999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2016.7280000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.638000000000001,
"layouts": 10,
"layoutDurationMs": 2.795,
"taskDurationMs": 384.68299999999994,
"heapDeltaBytes": 4898720,
"heapUsedBytes": 107566180,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.259000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.983999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.32,
"layouts": 9,
"layoutDurationMs": 2.567,
"taskDurationMs": 423.111,
"heapDeltaBytes": -23715212,
"heapUsedBytes": 78179104,
"domNodes": -218,
"jsHeapTotalBytes": 1462272,
"scriptDurationMs": 7.304000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1994.9100000000044,
"styleRecalcs": 87,
"styleRecalcDurationMs": 12.836,
"layouts": 9,
"layoutDurationMs": 2.2830000000000004,
"taskDurationMs": 923.2909999999998,
"heapDeltaBytes": 427564,
"heapUsedBytes": 91290956,
"domNodes": -210,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 102.81099999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.5519999999779,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.681,
"layouts": 9,
"layoutDurationMs": 2.106,
"taskDurationMs": 773.9910000000001,
"heapDeltaBytes": -6407024,
"heapUsedBytes": 96379756,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 99.47800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.9339999999984,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.911999999999995,
"layouts": 5,
"layoutDurationMs": 16.466,
"taskDurationMs": 1015.3539999999998,
"heapDeltaBytes": 37924868,
"heapUsedBytes": 137013388,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 27.802,
"eventListeners": 3244,
"totalBlockingTimeMs": 146,
"frameDurationMs": 19.861643835616434,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8271.075999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.014,
"layouts": 7,
"layoutDurationMs": 2.174,
"taskDurationMs": 4913.69,
"heapDeltaBytes": -21304488,
"heapUsedBytes": 89069112,
"domNodes": -296,
"jsHeapTotalBytes": -991232,
"scriptDurationMs": 2580.159,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733198380566805,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8638.058,
"styleRecalcs": 249,
"styleRecalcDurationMs": 26.127000000000002,
"layouts": 8,
"layoutDurationMs": 1.9719999999999998,
"taskDurationMs": 5811.8189999999995,
"heapDeltaBytes": -3041168,
"heapUsedBytes": 107797832,
"domNodes": -296,
"jsHeapTotalBytes": -12288,
"scriptDurationMs": 2637.816,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69825918762089,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14968.286999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13911.602000000003,
"heapDeltaBytes": -1212104,
"heapUsedBytes": 303930964,
"domNodes": -307,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 201.915,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.877029360967185,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 15112.85799999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14335.445000000002,
"heapDeltaBytes": -52877700,
"heapUsedBytes": 272095440,
"domNodes": -3344,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 209.04899999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.883561643835616,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 26904.667999999958,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.762,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26452.759000000002,
"heapDeltaBytes": -19359552,
"heapUsedBytes": 285695504,
"domNodes": -3344,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 838.3589999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 39,
"frameDurationMs": 49.35596330275229,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27385.51200000006,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.160000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27007.055,
"heapDeltaBytes": -38600324,
"heapUsedBytes": 281172744,
"domNodes": -3344,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 856.6250000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 16,
"frameDurationMs": 49.665335753176045,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5537.621999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.73000000000001,
"layouts": 20,
"layoutDurationMs": 20.151000000000003,
"taskDurationMs": 5375.24,
"heapDeltaBytes": -37112704,
"heapUsedBytes": 273589648,
"domNodes": -3344,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 86.297,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.35789473684211,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5583.28599999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.65399999999999,
"layouts": 20,
"layoutDurationMs": 20.73499999999999,
"taskDurationMs": 5448.228,
"heapDeltaBytes": -22116492,
"heapUsedBytes": 297510676,
"domNodes": -3344,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 89.37500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 19,
"frameDurationMs": 32.36279069767442,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7232.669999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6798.8769999999995,
"heapDeltaBytes": 14766272,
"heapUsedBytes": 296168016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.82499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.272147651006705,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11040.37100000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10545.029999999999,
"heapDeltaBytes": 4761424,
"heapUsedBytes": 287525700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.36899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.3993220338983,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 470.7089999999994,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.515,
"layouts": 13,
"layoutDurationMs": 4.934,
"taskDurationMs": 135.559,
"heapDeltaBytes": 7370400,
"heapUsedBytes": 98158572,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.982000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 462.6100000000406,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.916,
"layouts": 13,
"layoutDurationMs": 4.574,
"taskDurationMs": 110.204,
"heapDeltaBytes": 6755616,
"heapUsedBytes": 96908460,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.860999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 450.72899999991023,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.606,
"layouts": 76,
"layoutDurationMs": 14.144,
"taskDurationMs": 405.59499999999997,
"heapDeltaBytes": -14203944,
"heapUsedBytes": 80024980,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 197.294,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 452.0670000000564,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.655,
"layouts": 76,
"layoutDurationMs": 13.88,
"taskDurationMs": 404.767,
"heapDeltaBytes": -14093144,
"heapUsedBytes": 80068652,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 194.804,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 465.2579999999489,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4580000000000002,
"layouts": 76,
"layoutDurationMs": 12.363000000000001,
"taskDurationMs": 426.18699999999995,
"heapDeltaBytes": -628792,
"heapUsedBytes": 116874708,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 171.724,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.260714285714293,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 575.5739999999605,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4580000000000002,
"layouts": 76,
"layoutDurationMs": 16.084999999999997,
"taskDurationMs": 530.9849999999999,
"heapDeltaBytes": 300512,
"heapUsedBytes": 117162868,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 212.96499999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.678787878787894,
"p95FrameDurationMs": 33.30000000000018
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2964 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6465ca75011f5c44be7a941e6ff3cef7751c92c3
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (120)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #21872 +/- ##
=============================================
Coverage ? 85.78%
=============================================
Files ? 2588
Lines ? 134836
Branches ? 41182
=============================================
Hits ? 115673
Misses ? 18746
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at exact head against the merged main parent #21320. The cherry-pick diff is byte-identical to the parent's: the 409 branch now only calls reportSupersededAnswer when the conflict body actually carries a selected array, while conversationStore.retireAsk still runs unconditionally, so a conflict that names no winner no longer surfaces a false "another answer won" notice. The added it.for case covers both the missing-selected and explicit-null bodies. Required checks (lint-and-format, test, e2e-status) are green; the only red check, upload-e2e-coverage / package, is not required by any branch ruleset. Merging under the standing Agent backport authority for the current release trains.
Backport of #21320 to
cloud/1.58Automatically created by backport workflow.