Skip to content

[backport cloud/1.57] feat(agent): ask_user question card and delete approval card (#19981, #20092) - #21309

Merged
comfy-pr-bot merged 2 commits into
cloud/1.57from
backport-19981-to-cloud-1.57
Oct 18, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.57from
backport-19981-to-cloud-1.57

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Manual backport of #19981 and its stacked follow-up #20092 to cloud/1.57. Two commits, in merge order, so 1.57 users get the real "Ask user" card and the delete-approval card.

Why

On 1.57 the agent panel cannot render an ask_user question, so a Desktop turn that asks one hangs with the spinner running until the user presses stop (https://linear.app/comfyorg/issue/PM-2127). The backport of both PRs to this line was approved by Christian on 2026-10-18.

What differs from the originals

  • Code, tests and snapshots are byte-identical to the merged commits.
  • Dropped: the docs/architecture/domains boundary edits from feat(agent): render ask_user questions and advertise ask_kinds #19981. On 1.57 the two records/*.domain.json files do not exist and boundaries.json has no agent or design-system rules, so there is nothing to approve.
  • One conflict in agentApiSchema.ts imports: 1.57 does not import zAgentAttachmentRejected; kept the line's imports plus the new ask schemas. @comfyorg/ingest-types on 1.57 already exports zAgentAskKind, zAgentPendingAskBase and zAgentAskResolvedData.

Verification

  • pnpm typecheck:app, pnpm typecheck:browser, oxlint, eslint, stylelint, oxfmt: clean (pre-commit).
  • vitest run src/workbench/extensions/agent: 164 files pass. One known order-dependent test, (g18) a history fetch that never answers is abandoned at the recovery deadline, fails when run alone on this line, on unchanged cloud/1.57 and on main alike, so it is not caused by this backport.

Do not merge one commit without the other: #20092 is stacked on #19981.

skishore23 and others added 2 commits October 18, 2026 22:05
## Summary

Renders the agent's `ask_user` question as a card on main, and sends
`ask_kinds` on each turn so the server parks a turn only on an ask this
panel can show. `paused` is the exception: the server raises it for
every client, and it gets the notice below. Supersedes #18298. The
delete approval card is #20092, stacked on this PR.

- `AskUserCard.vue` shows the prompt and the options. A required single
choice is radios (`AskUserRadioOptions`). Anything else is checkboxes
capped at `max_selections` (`AskUserCheckboxOptions`) with a hint. With
`allow_other`, an Other box counts as one more selection, matching the
server's `validateSelection`. The parser dedupes option ids, caps
options at 50, clips long text and caps `max_selections` at what can be
chosen. An ask with nothing to choose, or with bounds the card can't
satisfy (a minimum above what it can offer, or a maximum below one),
gets the notice instead of a card that could only draw 422s.
- The answer goes through `answerAsk` (`POST
/agent/threads/:id/asks/:ask_id/answer`) with the generated
`AgentAnswerRequest`. Outcomes by response:
- 202: the card shows the answer the receipt committed. A status-only
202 reads as "Answered" and leaves the comparison to the frame.
- 409: the card shows the stored outcome from `AgentAskConflict`, or "no
longer open here" when the body has none.
- 422: nothing was committed, so the card goes back into service and the
error overlay asks the user to change their choices or stop the turn.
  - 403/404/501: refusals, so the card is retired.
  - Any other failure, 400 included, reads as unconfirmed.
- When a committed answer from the receipt, the 409 body or the frame
differs from what this tab sent, in ids or in free text, the user gets
one "answered somewhere else" toast.
- A resolved card stays read-only and shows what the server committed. A
cancelled or expired ask reads "closed without an answer".
- Types come from `@comfyorg/ingest-types`. `AskUserResolution` is a
discriminated union, and only `answered` carries `selected`/`otherText`.
- Parse policy (differs from draft #20891): `kind` is `AgentAskKind |
'unknown'`, via `.catch('unknown')`. A kind this client predates, or
`paused`, shows the `askUnavailable` notice instead of failing the frame
or the transcript parse. The answer receipt keeps `selected` optional.
#20891 switches both to the strict generated schemas; whichever PR
merges second has to pick one policy.
- Coordination: #16949 and #18949 each add their own
`handleAnswerFailure`, and this PR adds a third. The three agree on 400
(unconfirmed). On the 202, this PR treats a receipt that carries
`selected` as the committed answer and defers a status-only 202 to the
frame. #18949's notice for a status-only 202 on a recovered card can sit
alongside that. This PR's `retireAsk(askId, resolution, owner?)` takes a
required resolution, and `answerAsk` takes an `AgentAnswerRequest`.
Whichever lands second merges the three handlers and updates those call
sites. #18949 also restores only `run_approval` asks and should widen
recovery to every pending ask kind.
- Boundaries: main now classifies every `src` file (#20802), so the
card's `Button`, `Input`, `Checkbox` and `RadioGroup` imports cross from
`agent` into `design-system`. This PR approves `agent` as a
`design-system` consumer in both records and regenerates
`boundaries.json`. It is the first dependency approval in the catalog,
so it needs a design-system owner's review.
- Known limitation: the server keeps `pending_ask` only while the ask is
pending, so a resolved card disappears when the thread is loaded again
(a reload, or opening another chat and coming back). The agent README
notes this.

## Verification

- Vitest: `pnpm exec vitest run src/workbench/extensions/agent`, 163
files, 3,416 tests. Each new test fails under the mutation it targets,
for example: the watchdog dropping the 202 receipt on a live turn, a 422
keeping the rejected answer, the old empty-answer guard, reporting a
status-only 202, 400 as a refusal, a one-way id comparison, clamping
unsatisfiable bounds and the single optional choice hint.
- Playwright: `agentRunApprovalConsent.spec.ts` (consent) and
`agentAskUserQuestion.spec.ts` (question). The question spec posts once
to its ask and reads back the committed answer, and screenshots each
card state (radio, in flight, closed, retired, unconfirmed) plus the
notice. The eight Linux baselines moved with the spec.
- `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, eslint, oxfmt and
knip are clean.

---------

Co-authored-by: github-actions <github-actions@github.com>

(cherry picked from commit 4659fc2)
## Summary

Renders the agent's `delete_approval` ask as its own card, so a delete
of nodes the user added waits for an explicit Delete or Keep. Stacked on
#19981.

- `DeleteApprovalCard.vue` is built like `RunApprovalCard.vue`. It shows
the host's prompt, the nodes it would remove (title, else type, and
`#id`), then Keep (secondary) and Delete (destructive). The answer goes
through the shared `answerAsk` path as `{ selected: ["delete" | "keep"]
}`, so it inherits #19981's handling: the committed 202/409 answer, 422
back into service, refusals retired.
- `context` is parsed with the generated `zAgentDeleteApprovalContext`.
The card lists the server's nodes (at most 50 by contract, unique by id)
and says "N more nodes not listed" from `hidden_node_count`, so the user
always knows how many nodes a Delete covers.
- Some asks fall back to the existing warning notice, so Delete is never
armed without the node list:
- options other than exactly `delete`/`keep` as one required choice, or
with free text allowed;
- a `context` the generated schema rejects (missing, empty, or a
malformed entry);
- a node with a blank id, which the client rejects in `toDeleteTargets`
because the generated `id` is a plain string.
- Once resolved the card stays read-only. An answer reads back the
committed choice ("Answered: delete them"). A server close, a local
retirement and an unconfirmed answer each have their own line, keyed by
status like `AskUserAnswer`.
- `RENDERED_ASK_KINDS` gains `delete_approval`, so `ask_kinds`
advertises it on each turn. Strings live under `agent.deleteApproval.*`.
- Backend: the server accepts `delete_approval` in `ask_kinds` but does
not raise this ask yet. The `ask_kinds` description in this repo's
`packages/ingest-types/src/types.gen.ts` says "`delete_approval` raises
no card yet", so the card is inert until that lands.
- Parse policy: like #19981, a rejected delete context degrades to the
notice for that ask. Draft #20891 parses ask frames with the strict
generated schema, under which the same context drops the live frame or
fails the history load. Whichever PR lands second picks one policy.

## Verification

- Vitest: `pnpm exec vitest run src/workbench/extensions/agent` (163
files, 3,434 tests):
- `agentMessageParts.test.ts`: parsing, `hidden_node_count`, notice
fallbacks, option shape, retirement;
- `AgentMessage.test.ts`: card, node list, answers, in flight, unlisted
count, every resolved readback;
- `agentConversationStore.test.ts`: settling drops a pending delete
card, and a retired one stays read-only through a refetch;
  - `agentRestClient.test.ts`: `ask_kinds` as literals.
- After merging #19981, making `retireAskParts` keep only `ask_user`
cards still fails the retention tests.
- Playwright, `browser_tests/tests/agent/agentAskConsent.spec.ts`
(renamed from `agentRunApprovalConsent.spec.ts`; it now covers every ask
card):
- The delete approval case lists the nodes, then one click posts once to
that ask with the card locked while in flight, then the resolved card
reads back the answer.
- The frame comes from `fixtures/data/agent/agentAskFrames.ts`, typed
against the generated `AgentAskFrame`. The turn harness is #19981's
`agentAskTurnFixture`.
  - All six cases pass locally against a cloud-mode dev server.
- Screenshot: `agent-delete-approval-card-cloud-linux.png`, the pending
card, recorded through the New Browser Test Expectations run:

![delete approval
card](https://github.com/Comfy-Org/ComfyUI_frontend/blob/56ccdbf2e547c2bd919133f00d7823fc67e90588/browser_tests/tests/agent/agentAskConsent.spec.ts-snapshots/agent-delete-approval-card-cloud-linux.png?raw=true)
- Storybook: `Agent/AgentMessage` has `DeleteApproval`,
`DeleteApprovalPending`, `DeleteApprovalLongList` (50 listed, 30
unlisted) and `DeleteApprovalResolved`.
- `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, oxfmt and knip are
clean.

---------

Co-authored-by: github-actions <github-actions@github.com>
(cherry picked from commit 6df2775)
@christian-byrne
christian-byrne requested a review from a team as a code owner October 18, 2026 22:14
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 18, 2026
@christian-byrne
christian-byrne requested a review from a team as a code owner October 18, 2026 22:14
@christian-byrne christian-byrne added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 18, 2026
@christian-byrne
christian-byrne requested a review from a team as a code owner October 18, 2026 22:14
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: dc8e7ea9-9242-44cf-8dea-ce0124b3bcf4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.0 MB heap
dom-widget-order-dense-n200-w200-i120: · 39.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 244ms TBT · 77.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 48.4 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 83ms TBT · 71.6 MB heap
extension-clean-combined-draw: · 51.9 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 35ms TBT · 78.3 MB heap
extension-rgthree-prototype-draw: · 51.8 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 92ms TBT · 82.7 MB heap
large-combo-open: · 49.5 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 75.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
subgraph-transition-enter: · 53.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 66ms TBT · 99.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
vue-large-graph-idle: · 38.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 277.8 MB heap
vue-large-graph-pan: · 32.0 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 8ms TBT · 257.7 MB heap
vue-node-resize-workload: · 33.2 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 262.0 MB heap
vue-zoom-out-idle: · 39.9 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 256.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.5 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 113.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 11
canvas-idle: style recalc count 11
canvas-idle: task duration 272ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 77.5 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 11
canvas-mouse-sweep: style recalc count 71
canvas-mouse-sweep: task duration 555ms
canvas-mouse-sweep: script duration 105ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 73.0 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 4ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 232ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.8 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 11
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 308ms
dom-widget-clipping: script duration 108ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 87.0 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 25ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 498ms
dom-widget-order-dense-n200-w200-i120: script duration 34ms
dom-widget-order-dense-n200-w200-i120: TBT 244ms
dom-widget-order-dense-n200-w200-i120: heap used 77.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -192
dom-widget-order-dense-n200-w200-i120: event listeners -106
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 254ms
dom-widget-order-sparse-n1000-w20-i120: script duration 90ms
dom-widget-order-sparse-n1000-w20-i120: TBT 83ms
dom-widget-order-sparse-n1000-w20-i120: heap used 71.6 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 4
extension-clean-combined-draw: style recalc count 4
extension-clean-combined-draw: task duration 5143ms
extension-clean-combined-draw: script duration 4034ms
extension-clean-combined-draw: TBT 35ms
extension-clean-combined-draw: heap used 78.3 MB
extension-clean-combined-draw: DOM nodes -258
extension-clean-combined-draw: event listeners -68
extension-rgthree-prototype-draw: avg frame time 19ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 1ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 4
extension-rgthree-prototype-draw: style recalc count 4
extension-rgthree-prototype-draw: task duration 5191ms
extension-rgthree-prototype-draw: script duration 4011ms
extension-rgthree-prototype-draw: TBT 92ms
extension-rgthree-prototype-draw: heap used 82.7 MB
extension-rgthree-prototype-draw: DOM nodes -258
extension-rgthree-prototype-draw: event listeners -68
large-combo-open: avg frame time 20ms
large-combo-open: p95 frame time 42ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 14ms
large-combo-open: layout count 13
large-combo-open: style recalc count 24
large-combo-open: task duration 130ms
large-combo-open: script duration 7ms
large-combo-open: TBT 0ms
large-combo-open: heap used 75.4 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 10
large-graph-idle: style recalc count 10
large-graph-idle: task duration 397ms
large-graph-idle: script duration 25ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 75.6 MB
large-graph-idle: DOM nodes -258
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1210ms
large-graph-pan: script duration 573ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 69.9 MB
large-graph-pan: DOM nodes -258
large-graph-pan: event listeners -66
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 68
large-graph-zoom: style recalc count 74
large-graph-zoom: task duration 1149ms
large-graph-zoom: script duration 497ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 65.8 MB
large-graph-zoom: DOM nodes -234
large-graph-zoom: event listeners -68
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 7
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1280ms
legacy-node-drag: script duration 635ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 9
minimap-idle: style recalc count 10
minimap-idle: task duration 382ms
minimap-idle: script duration 25ms
minimap-idle: TBT 0ms
minimap-idle: heap used 74.9 MB
minimap-idle: DOM nodes -258
minimap-idle: event listeners -68
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 275ms
subgraph-dom-widget-clipping: script duration 92ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 78.3 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 285ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 85.0 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 534ms
subgraph-mouse-sweep: script duration 82ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.1 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 17ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 670ms
subgraph-transition-enter: script duration 20ms
subgraph-transition-enter: TBT 66ms
subgraph-transition-enter: heap used 99.5 MB
subgraph-transition-enter: DOM nodes 15953
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 22ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 3693ms
viewport-pan-sweep: script duration 1756ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.8 MB
viewport-pan-sweep: DOM nodes -258
viewport-pan-sweep: event listeners -65
vue-large-graph-idle: avg frame time 26ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14288ms
vue-large-graph-idle: script duration 184ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 277.8 MB
vue-large-graph-idle: DOM nodes -3330
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 31ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 135
vue-large-graph-pan: task duration 16816ms
vue-large-graph-pan: script duration 585ms
vue-large-graph-pan: TBT 8ms
vue-large-graph-pan: heap used 257.7 MB
vue-large-graph-pan: DOM nodes -3330
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 30ms
vue-node-resize-workload: p95 frame time 58ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 48ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5035ms
vue-node-resize-workload: script duration 69ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 262.0 MB
vue-node-resize-workload: DOM nodes -3332
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 25ms
vue-zoom-out-idle: p95 frame time 42ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6914ms
vue-zoom-out-idle: script duration 88ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 256.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 8ms
workflow-execution: layout count 6
workflow-execution: style recalc count 7
workflow-execution: task duration 59ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.0 MB
workflow-execution: DOM nodes 107
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 9ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 142ms
agent-composer-empty-conversation-typing: script duration 61ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 88.5 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 9ms
agent-composer-long-conversation-typing: style recalc duration 1ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 190ms
agent-composer-long-conversation-typing: script duration 64ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 113.8 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-18T22:24:27.272Z",
  "gitSha": "8f8fcb36cdf10939141803e619fc4b5049327986",
  "branch": "backport-19981-to-cloud-1.57",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2010.263000000009,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.2689999999999997,
      "layouts": 11,
      "layoutDurationMs": 2.3160000000000003,
      "taskDurationMs": 280.35299999999995,
      "heapDeltaBytes": -901896,
      "heapUsedBytes": 74252456,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 7.3199999999999985,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66528925619835,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2010.3300000000672,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.2710000000000004,
      "layouts": 10,
      "layoutDurationMs": 2.104,
      "taskDurationMs": 263.181,
      "heapDeltaBytes": 22145600,
      "heapUsedBytes": 88320564,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 6.336000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1676.3070000000084,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 14.341,
      "layouts": 10,
      "layoutDurationMs": 2.521,
      "taskDurationMs": 595.55,
      "heapDeltaBytes": 15660440,
      "heapUsedBytes": 81422756,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 113.26499999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1679.787000000033,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 12.244,
      "layouts": 11,
      "layoutDurationMs": 2.3669999999999995,
      "taskDurationMs": 514.0579999999999,
      "heapDeltaBytes": -3022232,
      "heapUsedBytes": 71656144,
      "domNodes": 0,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 96.671,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663363,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1711.3620000000083,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.9079999999999995,
      "layouts": 12,
      "layoutDurationMs": 2.911,
      "taskDurationMs": 258.286,
      "heapDeltaBytes": -4447876,
      "heapUsedBytes": 69909680,
      "domNodes": 47,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 11.633,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.6540000000005,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.7160000000000006,
      "layouts": 12,
      "layoutDurationMs": 2.068,
      "taskDurationMs": 206.288,
      "heapDeltaBytes": 18778120,
      "heapUsedBytes": 84962424,
      "domNodes": 47,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 6.980000000000002,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475727,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 523.2640000000401,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.235,
      "layouts": 11,
      "layoutDurationMs": 3.047,
      "taskDurationMs": 321.313,
      "heapDeltaBytes": 25729548,
      "heapUsedBytes": 91435556,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 115.79700000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 444.10099999993236,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 2.814,
      "layouts": 11,
      "layoutDurationMs": 2.6560000000000006,
      "taskDurationMs": 295.045,
      "heapDeltaBytes": 25233732,
      "heapUsedBytes": 91036788,
      "domNodes": 0,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 100.50500000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 878.7690000000339,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.78499999999997,
      "heapDeltaBytes": -12594928,
      "heapUsedBytes": 81384520,
      "domNodes": -192,
      "jsHeapTotalBytes": 20455424,
      "scriptDurationMs": 33.022,
      "eventListeners": -106,
      "totalBlockingTimeMs": 240,
      "frameDurationMs": 25.23714285714285,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 879.0500000000065,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.31499999999994,
      "heapDeltaBytes": -12732560,
      "heapUsedBytes": 81379424,
      "domNodes": -192,
      "jsHeapTotalBytes": 19668992,
      "scriptDurationMs": 34.366,
      "eventListeners": -106,
      "totalBlockingTimeMs": 248,
      "frameDurationMs": 25.237142857142864,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 687.989000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 246.38899999999975,
      "heapDeltaBytes": -4460020,
      "heapUsedBytes": 75030604,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 90.98099999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 20.58529411764705,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 670.9560000000465,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 260.6220000000001,
      "heapDeltaBytes": -4415048,
      "heapUsedBytes": 75195220,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 88.41399999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 82,
      "frameDurationMs": 20.70606060606061,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6806.502999999964,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.8250000000000002,
      "layouts": 3,
      "layoutDurationMs": 0.8019999999999997,
      "taskDurationMs": 5736.065,
      "heapDeltaBytes": -26763504,
      "heapUsedBytes": 73372816,
      "domNodes": -258,
      "jsHeapTotalBytes": 15855616,
      "scriptDurationMs": 4438.435,
      "eventListeners": -68,
      "totalBlockingTimeMs": 51,
      "frameDurationMs": 20.408682634730535,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5640.287999999941,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.1580000000000001,
      "layouts": 4,
      "layoutDurationMs": 1.016,
      "taskDurationMs": 4549.179,
      "heapDeltaBytes": -9311624,
      "heapUsedBytes": 90759736,
      "domNodes": -258,
      "jsHeapTotalBytes": 5107712,
      "scriptDurationMs": 3630.518,
      "eventListeners": -68,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 18.112861736334402,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6667.654000000028,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.1089999999999998,
      "layouts": 4,
      "layoutDurationMs": 0.9489999999999997,
      "taskDurationMs": 5356.342000000001,
      "heapDeltaBytes": -14801840,
      "heapUsedBytes": 72200776,
      "domNodes": -258,
      "jsHeapTotalBytes": 7467008,
      "scriptDurationMs": 4151.98,
      "eventListeners": -68,
      "totalBlockingTimeMs": 24,
      "frameDurationMs": 19.723076923076924,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6088.981000000103,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.1900000000000002,
      "layouts": 4,
      "layoutDurationMs": 1.003,
      "taskDurationMs": 5026.297,
      "heapDeltaBytes": 1995940,
      "heapUsedBytes": 101317872,
      "domNodes": -258,
      "jsHeapTotalBytes": 6418432,
      "scriptDurationMs": 3870.45,
      "eventListeners": -67,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 18.88482972136223,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "large-combo-open",
      "durationMs": 211.95000000000164,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 16.416,
      "layouts": 12,
      "layoutDurationMs": 3.5769999999999995,
      "taskDurationMs": 148.617,
      "heapDeltaBytes": -8512836,
      "heapUsedBytes": 79059224,
      "domNodes": 917,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 8.042,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.66999999999998,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "large-combo-open",
      "durationMs": 164.15600000004815,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 11.951,
      "layouts": 14,
      "layoutDurationMs": 3.0700000000000007,
      "taskDurationMs": 110.67999999999999,
      "heapDeltaBytes": -8201692,
      "heapUsedBytes": 79118984,
      "domNodes": 917,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 6.167,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.75,
      "p95FrameDurationMs": 33.29999999999973
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.4940000000179,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.615999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.246,
      "taskDurationMs": 414.92799999999994,
      "heapDeltaBytes": -14570428,
      "heapUsedBytes": 82055476,
      "domNodes": -258,
      "jsHeapTotalBytes": 4096000,
      "scriptDurationMs": 26.478,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.1860000000233,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.32,
      "layouts": 10,
      "layoutDurationMs": 2.227,
      "taskDurationMs": 379.97900000000004,
      "heapDeltaBytes": -1989120,
      "heapUsedBytes": 76539364,
      "domNodes": -258,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 24.517000000000003,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760334,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2413.467999999966,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 7.248000000000001,
      "layouts": 7,
      "layoutDurationMs": 1.7389999999999997,
      "taskDurationMs": 1173.422,
      "heapDeltaBytes": -1782496,
      "heapUsedBytes": 77889584,
      "domNodes": -258,
      "jsHeapTotalBytes": 4284416,
      "scriptDurationMs": 563.4140000000001,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66551724137931,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2600.5779999999277,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 7.872000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.2509999999999994,
      "taskDurationMs": 1245.813,
      "heapDeltaBytes": -28670104,
      "heapUsedBytes": 68650956,
      "domNodes": -258,
      "jsHeapTotalBytes": 4882432,
      "scriptDurationMs": 583.006,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3519.0639999999576,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 9.048,
      "layouts": 67,
      "layoutDurationMs": 11.755999999999998,
      "taskDurationMs": 1236.2350000000001,
      "heapDeltaBytes": -31046004,
      "heapUsedBytes": 67566256,
      "domNodes": -234,
      "jsHeapTotalBytes": 6193152,
      "scriptDurationMs": 527.758,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665876777251185,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3121.719999999982,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 7.761,
      "layouts": 68,
      "layoutDurationMs": 10.775,
      "taskDurationMs": 1061.755,
      "heapDeltaBytes": -10995884,
      "heapUsedBytes": 70451404,
      "domNodes": -234,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 466.683,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66595744680851,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2719.1219999999703,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.618,
      "layouts": 7,
      "layoutDurationMs": 1.713,
      "taskDurationMs": 1271.6689999999999,
      "heapDeltaBytes": 11993920,
      "heapUsedBytes": 95837648,
      "domNodes": 0,
      "jsHeapTotalBytes": 5398528,
      "scriptDurationMs": 627.163,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66564417177914,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2604.3169999999236,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.601,
      "layouts": 7,
      "layoutDurationMs": 1.7100000000000002,
      "taskDurationMs": 1289.268,
      "heapDeltaBytes": 3484200,
      "heapUsedBytes": 87559584,
      "domNodes": 0,
      "jsHeapTotalBytes": 5730304,
      "scriptDurationMs": 642.995,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66602564102564,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.6990000000123,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.3939999999999992,
      "layouts": 9,
      "layoutDurationMs": 2.092,
      "taskDurationMs": 391.507,
      "heapDeltaBytes": -1865416,
      "heapUsedBytes": 78671700,
      "domNodes": -258,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 27.394000000000002,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.2039999999588,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.8269999999999997,
      "layouts": 9,
      "layoutDurationMs": 1.732,
      "taskDurationMs": 371.501,
      "heapDeltaBytes": -2350364,
      "heapUsedBytes": 78323724,
      "domNodes": -258,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 22.200000000000003,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66528925619835,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 430.11599999999817,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.1339999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.242,
      "taskDurationMs": 287.62,
      "heapDeltaBytes": 21548656,
      "heapUsedBytes": 88373540,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 95.455,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669230769230772,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 397.62199999995573,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.695,
      "layouts": 10,
      "layoutDurationMs": 2.284,
      "taskDurationMs": 261.991,
      "heapDeltaBytes": -1499808,
      "heapUsedBytes": 75829768,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 87.85200000000002,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.67083333333333,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.8189999999931,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.646,
      "layouts": 9,
      "layoutDurationMs": 2.3069999999999995,
      "taskDurationMs": 288.86699999999996,
      "heapDeltaBytes": 21610504,
      "heapUsedBytes": 88502428,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 10.507000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198342,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.4989999999816,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.032,
      "layouts": 10,
      "layoutDurationMs": 1.938,
      "taskDurationMs": 281.1940000000001,
      "heapDeltaBytes": 22465104,
      "heapUsedBytes": 89782476,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 6.573,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1679.4150000000059,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 15.208,
      "layouts": 10,
      "layoutDurationMs": 2.438999999999999,
      "taskDurationMs": 575.7829999999999,
      "heapDeltaBytes": -10984516,
      "heapUsedBytes": 65949808,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 88.964,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1678.03600000002,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 13.131,
      "layouts": 10,
      "layoutDurationMs": 2.11,
      "taskDurationMs": 492.637,
      "heapDeltaBytes": -6535304,
      "heapUsedBytes": 70545136,
      "domNodes": 0,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 75.70500000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663366,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 869.8520000000372,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 16.583000000000002,
      "layouts": 5,
      "layoutDurationMs": 9.206999999999999,
      "taskDurationMs": 669.635,
      "heapDeltaBytes": 7290092,
      "heapUsedBytes": 104295988,
      "domNodes": 15953,
      "jsHeapTotalBytes": 17440768,
      "scriptDurationMs": 19.645000000000003,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 66,
      "frameDurationMs": 18.839130434782607,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8455.538999999932,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 23.215999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.0889999999999995,
      "taskDurationMs": 3979.778,
      "heapDeltaBytes": 5807628,
      "heapUsedBytes": 84177860,
      "domNodes": -258,
      "jsHeapTotalBytes": 4284416,
      "scriptDurationMs": 1825.2110000000002,
      "eventListeners": -65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666141732283467,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8120.118000000048,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 20.535,
      "layouts": 9,
      "layoutDurationMs": 1.8349999999999997,
      "taskDurationMs": 3406.588,
      "heapDeltaBytes": 471324,
      "heapUsedBytes": 78899980,
      "domNodes": -258,
      "jsHeapTotalBytes": 4546560,
      "scriptDurationMs": 1685.932,
      "eventListeners": -65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665913757700206,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15586.409000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14768.741000000002,
      "heapDeltaBytes": 1886948,
      "heapUsedBytes": 298479344,
      "domNodes": -3330,
      "jsHeapTotalBytes": 39575552,
      "scriptDurationMs": 188.223,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.010344827586206,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14743.439999999964,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13807.267999999998,
      "heapDeltaBytes": 7871628,
      "heapUsedBytes": 284125688,
      "domNodes": -3330,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 179.928,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.32874354561101,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16788.575000000037,
      "styleRecalcs": 124,
      "styleRecalcDurationMs": 15.556000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16299.498,
      "heapDeltaBytes": -28824152,
      "heapUsedBytes": 267589360,
      "domNodes": -3330,
      "jsHeapTotalBytes": 12050432,
      "scriptDurationMs": 583.4749999999999,
      "eventListeners": -651,
      "totalBlockingTimeMs": 15,
      "frameDurationMs": 30.21474820143885,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17772.096000000034,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 11.882000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17332.047,
      "heapDeltaBytes": -18550520,
      "heapUsedBytes": 272872288,
      "domNodes": -3330,
      "jsHeapTotalBytes": 13361152,
      "scriptDurationMs": 586.287,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.30163636363636,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5007.988999999952,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 50.43399999999999,
      "layouts": 20,
      "layoutDurationMs": 21.990999999999996,
      "taskDurationMs": 4886.782999999999,
      "heapDeltaBytes": -5582660,
      "heapUsedBytes": 275962576,
      "domNodes": -3330,
      "jsHeapTotalBytes": 26730496,
      "scriptDurationMs": 67.161,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.21987951807229,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5315.961000000016,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 45.06400000000001,
      "layouts": 20,
      "layoutDurationMs": 19.155000000000005,
      "taskDurationMs": 5182.736,
      "heapDeltaBytes": -17684792,
      "heapUsedBytes": 273494472,
      "domNodes": -3334,
      "jsHeapTotalBytes": 36167680,
      "scriptDurationMs": 71.421,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.036723163841813,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7876.9210000000385,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7376.819000000001,
      "heapDeltaBytes": 11076856,
      "heapUsedBytes": 264187132,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 96.57299999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 26.542087542087543,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7152.197000000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6450.244999999999,
      "heapDeltaBytes": 2523804,
      "heapUsedBytes": 274161224,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 79.22299999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.596699669966995,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 90.137000000027,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 9.051,
      "layouts": 7,
      "layoutDurationMs": 2.412,
      "taskDurationMs": 63.903,
      "heapDeltaBytes": 4592596,
      "heapUsedBytes": 76254016,
      "domNodes": 97,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.664,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 73.77199999996265,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.233,
      "layouts": 5,
      "layoutDurationMs": 1.682,
      "taskDurationMs": 53.797,
      "heapDeltaBytes": -15573340,
      "heapUsedBytes": 68371120,
      "domNodes": 117,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 4.297,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.674999999999955,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 176.5219999999772,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.837,
      "layouts": 76,
      "layoutDurationMs": 8.915,
      "taskDurationMs": 139.19400000000002,
      "heapDeltaBytes": 8637196,
      "heapUsedBytes": 100287784,
      "domNodes": 4,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 59.605,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636382,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 190.586000000053,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.824,
      "layouts": 76,
      "layoutDurationMs": 9.020999999999999,
      "taskDurationMs": 145.74200000000002,
      "heapDeltaBytes": 8757824,
      "heapUsedBytes": 85291140,
      "domNodes": 4,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 63.285999999999994,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66363636363634,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 241.01299999995263,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.39,
      "layouts": 76,
      "layoutDurationMs": 9.520000000000001,
      "taskDurationMs": 200.072,
      "heapDeltaBytes": -3011536,
      "heapUsedBytes": 116329452,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 68.233,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000007,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 214.56899999998313,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.351,
      "layouts": 76,
      "layoutDurationMs": 8.767000000000001,
      "taskDurationMs": 179.073,
      "heapDeltaBytes": -2633512,
      "heapUsedBytes": 122281716,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 60.266,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.661538461538456,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge. Fix the failing shards and re-run coverage before using these totals for comparison.

Line coverage: 64.6%

Coverage totals
Metric Covered Total Pct
Lines 56130 86935 64.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.6% 1172
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.9% 375
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 47.5% 245
src/core/webSessionIdentity.ts 3.3% 231
src/core/graph/widgets/dynamicGroupWidget.ts 0.4% 224
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ❌ 2277 passed, 1 failed · 2 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 2255 / ❌ 1 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/18/2026, 10:16:15 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 6e030d288080921ce71578d6105a4c58bfd23150

Full docs: ADR-DEVEX-LINT-0015

@github-actions
github-actions Bot requested a review from thedatalife October 18, 2026 22:15
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 18, 2026
@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.76190% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sions/agent/stores/agent/agentConversationStore.ts 97.43% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.57   #21309   +/-   ##
=============================================
  Coverage              ?   87.21%           
=============================================
  Files                 ?     2636           
  Lines                 ?   148070           
  Branches              ?    38595           
=============================================
  Hits                  ?   129145           
  Misses                ?    18535           
  Partials              ?      390           
Flag Coverage Δ
e2e 64.56% <ø> (?)
unit 85.13% <99.76%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 94.90% <100.00%> (ø)
...h/extensions/agent/components/agent/AgentPanel.vue 100.00% <ø> (ø)
...nsions/agent/components/agent/ConversationView.vue 95.83% <100.00%> (ø)
...ns/agent/components/agent/message/AgentMessage.vue 100.00% <100.00%> (ø)
...ent/components/agent/message/AgentMessageGroup.vue 100.00% <100.00%> (ø)
...agent/components/agent/message/AgentNoticeCard.vue 100.00% <100.00%> (ø)
...s/agent/components/agent/message/AskUserAnswer.vue 100.00% <100.00%> (ø)
...ons/agent/components/agent/message/AskUserCard.vue 100.00% <100.00%> (ø)
...omponents/agent/message/AskUserCheckboxOptions.vue 100.00% <100.00%> (ø)
...nt/components/agent/message/AskUserOptionLabel.vue 100.00% <100.00%> (ø)
... and 12 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

datadog-official Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c0dcd64 | Docs | View more details | Give us feedback!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟡 Medium 1
🟢 Low 5
⚪ Nit 4

Panel: 6/6 reviewers contributed findings.

@comfy-pr-bot
comfy-pr-bot merged commit 306f9c7 into cloud/1.57 Oct 18, 2026
273 of 275 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-19981-to-cloud-1.57 branch October 18, 2026 22:48
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Cursor review triage. This PR is byte-identical to the merged code on main, so nothing changes here; fixes land on main first and follow by backport.

@cursor

cursor Bot commented Oct 18, 2026

Copy link
Copy Markdown

Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository.

christian-byrne added a commit that referenced this pull request Oct 19, 2026
…#21317)

Test-only. Ports the releases-request mock in
`browser_tests/tests/featureFlags.spec.ts` to `core/1.57`.

## Why

The spec opens a second page in the same browser context. That page's
release check calls `https://stagingapi.comfy.org/releases`, and the
network isolation fixture fails the test with "Unexpected external
requests. Add a local mock." It failed both attempts in shard 4 on
#21309
(https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39171356393/job/117806120609),
a change that does not touch feature flags.

`main` has had this exact mock since
#16914. That PR is a
feature and is not on the 1.57 line, so this ports only the eight-line
test hunk.

## Change

Adds the same `beforeEach` route mock as `main`. No app code changes.
christian-byrne added a commit that referenced this pull request Oct 19, 2026
#21318)

Test-only. Ports the releases-request mock in
`browser_tests/tests/featureFlags.spec.ts` to `cloud/1.57`.

## Why

The spec opens a second page in the same browser context. That page's
release check calls `https://stagingapi.comfy.org/releases`, and the
network isolation fixture fails the test with "Unexpected external
requests. Add a local mock." It failed both attempts in shard 4 on
#21309
(https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39171356393/job/117806120609),
a change that does not touch feature flags.

`main` has had this exact mock since
#16914. That PR is a
feature and is not on the 1.57 line, so this ports only the eight-line
test hunk.

## Change

Adds the same `beforeEach` route mock as `main`. No app code changes.
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 23, 2026
…nning (Comfy-Org#21320)

## Summary

A 409 from the ask answer endpoint can come back with `selected` missing
or `null` (`AgentAskConflict.selected` is nullish). `toAskResolution`
turns that into an answered resolution with `selected: []`, and the 409
branch always ran the superseded check. So a user who picked an option
got a false "answered somewhere else" notice and an
`agent_ask_answer_superseded` error report, even though nothing said
another answer won.

Fix: only run the superseded comparison when the conflict body actually
carries a selection array. This is the same guard the 202 path already
has (`receipt.selected !== undefined`). The card is still retired with
the conflict's status, as before.

Found by the cursor-review panel on the 1.57 backports of Comfy-Org#19981/Comfy-Org#20092
(Comfy-Org#21308,
Comfy-Org#21309). The code
there is identical to main, so this fix goes to main first and is
backported after those land.

## Tests

- New: `does not report a 409 with no selection as another answer
winning` and `... with a null selection ...` in
`useAgentSession.test.ts`. Both fail on main before the fix
(`reportError` called with `agent_ask_answer_superseded`) and pass
after.
- Existing `shows the answer a 409 reports as already committed` (409
that names another selection) still reports superseded.
- `useAgentSession.test.ts`: 253 pass. The one failure is the known
order-dependent `(g18)` test, which fails on main without this change
(https://linear.app/comfyorg/issue/FE-3485).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants