Repository navigation
[backport core/1.58] fix(agent): don't report a 409 with no selection as another answer winning - #21871
Conversation
…nning (#21320) ## Summary A 409 from the ask answer endpoint can come back with `selected` missing or `null` (`AgentAskConflict.selected` is nullish). `toAskResolution` turns that into an answered resolution with `selected: []`, and the 409 branch always ran the superseded check. So a user who picked an option got a false "answered somewhere else" notice and an `agent_ask_answer_superseded` error report, even though nothing said another answer won. Fix: only run the superseded comparison when the conflict body actually carries a selection array. This is the same guard the 202 path already has (`receipt.selected !== undefined`). The card is still retired with the conflict's status, as before. Found by the cursor-review panel on the 1.57 backports of #19981/#20092 (#21308, #21309). The code there is identical to main, so this fix goes to main first and is backported after those land. ## Tests - New: `does not report a 409 with no selection as another answer winning` and `... with a null selection ...` in `useAgentSession.test.ts`. Both fail on main before the fix (`reportError` called with `agent_ask_answer_superseded`) and pass after. - Existing `shows the answer a 409 reports as already committed` (409 that names another selection) still reports superseded. - `useAgentSession.test.ts`: 253 pass. The one failure is the known order-dependent `(g18)` test, which fails on main without this change (https://linear.app/comfyorg/issue/FE-3485).
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-24T02:31:59.469Z",
"gitSha": "baec42fc4f31833479df8b4577e58a4464a806ac",
"branch": "backport-21320-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2040.604999999971,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2239999999999998,
"layouts": 10,
"layoutDurationMs": 3.059,
"taskDurationMs": 648.789,
"heapDeltaBytes": -9141952,
"heapUsedBytes": 90535020,
"domNodes": -180,
"jsHeapTotalBytes": 7491584,
"scriptDurationMs": 11.405999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2045.5439999999498,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.249,
"layouts": 8,
"layoutDurationMs": 2.307,
"taskDurationMs": 565.048,
"heapDeltaBytes": -12031592,
"heapUsedBytes": 78153240,
"domNodes": -201,
"jsHeapTotalBytes": -2994176,
"scriptDurationMs": 9.271999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.970000000017,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.440000000000001,
"layouts": 10,
"layoutDurationMs": 3.234,
"taskDurationMs": 929.7039999999998,
"heapDeltaBytes": -2917428,
"heapUsedBytes": 96837272,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 173.995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1787.1900000000096,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.806000000000001,
"layouts": 9,
"layoutDurationMs": 2.5489999999999995,
"taskDurationMs": 932.2380000000002,
"heapDeltaBytes": -146744,
"heapUsedBytes": 90021136,
"domNodes": -200,
"jsHeapTotalBytes": 2416640,
"scriptDurationMs": 166.139,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.5320000000343,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.557,
"layouts": 11,
"layoutDurationMs": 2.5080000000000005,
"taskDurationMs": 395.6259999999999,
"heapDeltaBytes": -1366196,
"heapUsedBytes": 88876476,
"domNodes": 47,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 10.529999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.8100000000477,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.626,
"layouts": 11,
"layoutDurationMs": 2.738,
"taskDurationMs": 407.096,
"heapDeltaBytes": -1355788,
"heapUsedBytes": 88973212,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.289,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 743.9390000000117,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.568,
"layouts": 8,
"layoutDurationMs": 2.2520000000000002,
"taskDurationMs": 518.027,
"heapDeltaBytes": 3834868,
"heapUsedBytes": 96429620,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 177.07600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 628.3599999999296,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.6249999999999996,
"layouts": 9,
"layoutDurationMs": 2.331,
"taskDurationMs": 435.04900000000004,
"heapDeltaBytes": 4167764,
"heapUsedBytes": 94659880,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 165.91799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.759999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 877.807,
"heapDeltaBytes": -14952464,
"heapUsedBytes": 102072876,
"domNodes": -210,
"jsHeapTotalBytes": 15794176,
"scriptDurationMs": 72.68900000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 519,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1218.3390000000145,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 877.7040000000001,
"heapDeltaBytes": -16095860,
"heapUsedBytes": 101838180,
"domNodes": -230,
"jsHeapTotalBytes": 15269888,
"scriptDurationMs": 69.042,
"eventListeners": -168,
"totalBlockingTimeMs": 546,
"frameDurationMs": 33.79444444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 879.2709999999602,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.0750000000005,
"heapDeltaBytes": -2622820,
"heapUsedBytes": 98595036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.935,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.237142857142835,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.493000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.0509999999998,
"heapDeltaBytes": -4034192,
"heapUsedBytes": 97396200,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.868,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10584.159999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9702.245,
"heapDeltaBytes": 27056852,
"heapUsedBytes": 131056004,
"domNodes": -296,
"jsHeapTotalBytes": 29417472,
"scriptDurationMs": 8046.019999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1311,
"frameDurationMs": 32.264939024390245,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10354.84699999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9543.590999999999,
"heapDeltaBytes": 47407268,
"heapUsedBytes": 151191852,
"domNodes": -296,
"jsHeapTotalBytes": 36495360,
"scriptDurationMs": 7571.303999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 815,
"frameDurationMs": 31.029729729729727,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10200.266999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9402.101,
"heapDeltaBytes": 33542252,
"heapUsedBytes": 137332700,
"domNodes": -276,
"jsHeapTotalBytes": 29679616,
"scriptDurationMs": 7780.304,
"eventListeners": -130,
"totalBlockingTimeMs": 953,
"frameDurationMs": 32.07421383647799,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10130.990999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9367.151,
"heapDeltaBytes": 16015056,
"heapUsedBytes": 130177384,
"domNodes": -297,
"jsHeapTotalBytes": 30035968,
"scriptDurationMs": 7475.21,
"eventListeners": -130,
"totalBlockingTimeMs": 785,
"frameDurationMs": 30.987461773700304,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 254.23000000000684,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.085999999999999,
"layouts": 12,
"layoutDurationMs": 3.962,
"taskDurationMs": 197.256,
"heapDeltaBytes": 15529056,
"heapUsedBytes": 120979552,
"domNodes": 917,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.63,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 240.08200000002944,
"styleRecalcs": 26,
"styleRecalcDurationMs": 16.071,
"layouts": 12,
"layoutDurationMs": 3.718,
"taskDurationMs": 183.19500000000002,
"heapDeltaBytes": 13247344,
"heapUsedBytes": 118667688,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.539,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2054.7359999999912,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0210000000000004,
"layouts": 9,
"layoutDurationMs": 2.2399999999999998,
"taskDurationMs": 683.9190000000001,
"heapDeltaBytes": 1392748,
"heapUsedBytes": 111421024,
"domNodes": -276,
"jsHeapTotalBytes": -1253376,
"scriptDurationMs": 32.224000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.259999999923,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0740000000000003,
"layouts": 8,
"layoutDurationMs": 2.2300000000000004,
"taskDurationMs": 481.4639999999999,
"heapDeltaBytes": 683236,
"heapUsedBytes": 111223908,
"domNodes": -296,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 30.358000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2256.234999999947,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.185,
"layouts": 6,
"layoutDurationMs": 1.698,
"taskDurationMs": 1531.2060000000001,
"heapDeltaBytes": 2052880,
"heapUsedBytes": 113396900,
"domNodes": -296,
"jsHeapTotalBytes": -1028096,
"scriptDurationMs": 844.3470000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.918939393939397,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2278.521000000069,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.646999999999998,
"layouts": 7,
"layoutDurationMs": 1.975,
"taskDurationMs": 1526.948,
"heapDeltaBytes": -10326252,
"heapUsedBytes": 113305588,
"domNodes": -296,
"jsHeapTotalBytes": -372736,
"scriptDurationMs": 807.52,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788888888888888,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3625.4030000000057,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.235999999999999,
"layouts": 64,
"layoutDurationMs": 10.087,
"taskDurationMs": 1767.1529999999998,
"heapDeltaBytes": -22261164,
"heapUsedBytes": 90862052,
"domNodes": -281,
"jsHeapTotalBytes": 188416,
"scriptDurationMs": 759.81,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742396313364058,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3538.5899999999992,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.527000000000001,
"layouts": 65,
"layoutDurationMs": 10.884000000000002,
"taskDurationMs": 1564.204,
"heapDeltaBytes": -25082896,
"heapUsedBytes": 88277680,
"domNodes": -272,
"jsHeapTotalBytes": 712704,
"scriptDurationMs": 766.783,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66556603773585,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3038.8000000000375,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.2700000000000005,
"layouts": 5,
"layoutDurationMs": 1.5239999999999998,
"taskDurationMs": 1978.4909999999998,
"heapDeltaBytes": -11766480,
"heapUsedBytes": 102787500,
"domNodes": 0,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 965.262,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.943333333333328,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2729.8399999999674,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.857,
"layouts": 4,
"layoutDurationMs": 1.098,
"taskDurationMs": 1736.2989999999998,
"heapDeltaBytes": -11751040,
"heapUsedBytes": 102828772,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 952.853,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.871604938271602,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.249000000022,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9240000000000004,
"layouts": 7,
"layoutDurationMs": 1.732,
"taskDurationMs": 648.5500000000001,
"heapDeltaBytes": -147368,
"heapUsedBytes": 112491788,
"domNodes": -296,
"jsHeapTotalBytes": -466944,
"scriptDurationMs": 37.973,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.3709999999273,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0730000000000004,
"layouts": 7,
"layoutDurationMs": 1.8889999999999996,
"taskDurationMs": 478.84799999999996,
"heapDeltaBytes": -25098680,
"heapUsedBytes": 98963192,
"domNodes": -296,
"jsHeapTotalBytes": -2695168,
"scriptDurationMs": 30.404000000000007,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 549.2669999999862,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.739,
"layouts": 8,
"layoutDurationMs": 2.4180000000000006,
"taskDurationMs": 384.694,
"heapDeltaBytes": 316688,
"heapUsedBytes": 91559516,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 147.71699999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.8189999999349,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.7139999999999995,
"layouts": 9,
"layoutDurationMs": 2.4610000000000003,
"taskDurationMs": 434.08500000000004,
"heapDeltaBytes": 3368272,
"heapUsedBytes": 112508460,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 143.668,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662857142857163,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2041.7659999999955,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1599999999999997,
"layouts": 11,
"layoutDurationMs": 3.0219999999999994,
"taskDurationMs": 450.33200000000005,
"heapDeltaBytes": 5398828,
"heapUsedBytes": 97371576,
"domNodes": -219,
"jsHeapTotalBytes": -204800,
"scriptDurationMs": 9.629000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2058.328000000074,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.973,
"layouts": 10,
"layoutDurationMs": 2.731,
"taskDurationMs": 594.5400000000001,
"heapDeltaBytes": -13832752,
"heapUsedBytes": 86764660,
"domNodes": -198,
"jsHeapTotalBytes": 1724416,
"scriptDurationMs": 8.626,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.351999999969,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.892,
"layouts": 9,
"layoutDurationMs": 2.6850000000000005,
"taskDurationMs": 876.1170000000001,
"heapDeltaBytes": -4809596,
"heapUsedBytes": 87644860,
"domNodes": -198,
"jsHeapTotalBytes": 5394432,
"scriptDurationMs": 111.60499999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.195999999959,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.164,
"layouts": 10,
"layoutDurationMs": 2.6099999999999994,
"taskDurationMs": 724.5899999999999,
"heapDeltaBytes": -1522944,
"heapUsedBytes": 89841080,
"domNodes": -210,
"jsHeapTotalBytes": 2416640,
"scriptDurationMs": 108.848,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 999.7269999999503,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.931,
"layouts": 5,
"layoutDurationMs": 17.016,
"taskDurationMs": 810.217,
"heapDeltaBytes": 33369856,
"heapUsedBytes": 137393324,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 25.918000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 170,
"frameDurationMs": 21.274468085106374,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8224.777999999958,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.095000000000002,
"layouts": 8,
"layoutDurationMs": 2.039,
"taskDurationMs": 5136.82,
"heapDeltaBytes": 3199256,
"heapUsedBytes": 113297656,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 2672.63,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8286.845999999969,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.428,
"layouts": 8,
"layoutDurationMs": 2.065,
"taskDurationMs": 5102.923000000001,
"heapDeltaBytes": -9946404,
"heapUsedBytes": 112026740,
"domNodes": -296,
"jsHeapTotalBytes": -110592,
"scriptDurationMs": 2652.788,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15497.206000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14717.962000000001,
"heapDeltaBytes": -24648320,
"heapUsedBytes": 299960576,
"domNodes": -3344,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 223.28599999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.376149914821124,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 15749.298000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14831.733,
"heapDeltaBytes": -39152104,
"heapUsedBytes": 290456744,
"domNodes": -3344,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 228.769,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.648730964467006,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 18671.109,
"styleRecalcs": 159,
"styleRecalcDurationMs": 14.24600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18311.948999999997,
"heapDeltaBytes": -2086324,
"heapUsedBytes": 303138912,
"domNodes": -3344,
"jsHeapTotalBytes": 22794240,
"scriptDurationMs": 802.886,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 33.78408679927667,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27777.938000000064,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27389.269,
"heapDeltaBytes": -39996676,
"heapUsedBytes": 265913368,
"domNodes": -3344,
"jsHeapTotalBytes": -12288,
"scriptDurationMs": 903.509,
"eventListeners": -651,
"totalBlockingTimeMs": 87,
"frameDurationMs": 50.97651376146789,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 5780.625000000044,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.3,
"layouts": 20,
"layoutDurationMs": 23.442000000000004,
"taskDurationMs": 5645.8820000000005,
"heapDeltaBytes": -7330036,
"heapUsedBytes": 303658212,
"domNodes": -3344,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 114.56299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 17,
"frameDurationMs": 33.33179190751446,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8358.690999999908,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.95400000000001,
"layouts": 20,
"layoutDurationMs": 20.943000000000016,
"taskDurationMs": 8266.407000000001,
"heapDeltaBytes": 137797592,
"heapUsedBytes": 512909772,
"domNodes": -3344,
"jsHeapTotalBytes": 159109120,
"scriptDurationMs": 143.437,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.646368715083796,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11307.986999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10796.151,
"heapDeltaBytes": 3695556,
"heapUsedBytes": 281956120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.94199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.56713286713287,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7772.212999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7313.561,
"heapDeltaBytes": 14597672,
"heapUsedBytes": 299003620,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.65799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.11744966442953,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 495.83599999999706,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.618000000000002,
"layouts": 14,
"layoutDurationMs": 5.26,
"taskDurationMs": 160.201,
"heapDeltaBytes": -12329384,
"heapUsedBytes": 89890708,
"domNodes": 128,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 16.634,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.39000000000487,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.899,
"layouts": 8,
"layoutDurationMs": 3.06,
"taskDurationMs": 78.94999999999999,
"heapDeltaBytes": 4667276,
"heapUsedBytes": 95174984,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.947999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 412.2780000000148,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.648,
"layouts": 76,
"layoutDurationMs": 13.539000000000001,
"taskDurationMs": 367.36,
"heapDeltaBytes": -14179596,
"heapUsedBytes": 81167680,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 176.157,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 438.8380000000325,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.637,
"layouts": 76,
"layoutDurationMs": 14.183,
"taskDurationMs": 383.5,
"heapDeltaBytes": -14513128,
"heapUsedBytes": 78482204,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 180.975,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 498.18300000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.673,
"layouts": 76,
"layoutDurationMs": 13.5,
"taskDurationMs": 463.656,
"heapDeltaBytes": -4572992,
"heapUsedBytes": 103039380,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 185.259,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 543.032999999923,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.528,
"layouts": 76,
"layoutDurationMs": 13.257,
"taskDurationMs": 503.52699999999993,
"heapDeltaBytes": 618224,
"heapUsedBytes": 118027512,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 208.456,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2963 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c6995b2736d902205e145c991110c784ddf8206a
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (116)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21871 +/- ##
============================================
Coverage 84.49% 84.49%
============================================
Files 2931 2931
Lines 160912 160913 +1
Branches 39201 41402 +2201
============================================
+ Hits 135962 135963 +1
Misses 24559 24559
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at exact head against the merged main parent #21320. The cherry-pick diff is byte-identical to the parent's: the 409 branch now only calls reportSupersededAnswer when the conflict body actually carries a selected array, while conversationStore.retireAsk still runs unconditionally, so a conflict that names no winner no longer surfaces a false "another answer won" notice. The added it.for case covers both the missing-selected and explicit-null bodies. Required checks (lint-and-format, test, e2e-status) are green; the only red check, upload-e2e-coverage / package, is not required by any branch ruleset. Merging under the standing Agent backport authority for the current release trains.
Backport of #21320 to
core/1.58Automatically created by backport workflow.