Repository navigation
[backport cloud/1.57] fix(agent): don't report a 409 with no selection as another answer winning - #21870
Conversation
…nning (#21320) ## Summary A 409 from the ask answer endpoint can come back with `selected` missing or `null` (`AgentAskConflict.selected` is nullish). `toAskResolution` turns that into an answered resolution with `selected: []`, and the 409 branch always ran the superseded check. So a user who picked an option got a false "answered somewhere else" notice and an `agent_ask_answer_superseded` error report, even though nothing said another answer won. Fix: only run the superseded comparison when the conflict body actually carries a selection array. This is the same guard the 202 path already has (`receipt.selected !== undefined`). The card is still retired with the conflict's status, as before. Found by the cursor-review panel on the 1.57 backports of #19981/#20092 (#21308, #21309). The code there is identical to main, so this fix goes to main first and is backported after those land. ## Tests - New: `does not report a 409 with no selection as another answer winning` and `... with a null selection ...` in `useAgentSession.test.ts`. Both fail on main before the fix (`reportError` called with `agent_ask_answer_superseded`) and pass after. - Existing `shows the answer a 409 reports as already committed` (409 that names another selection) still reports superseded. - `useAgentSession.test.ts`: 253 pass. The one failure is the known order-dependent `(g18)` test, which fails on main without this change (https://linear.app/comfyorg/issue/FE-3485).
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-24T02:29:11.187Z",
"gitSha": "be7aa3d1a99f51dcfd1cad62032e59be1415f822",
"branch": "backport-21320-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.884999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.875,
"layouts": 10,
"layoutDurationMs": 2.5719999999999996,
"taskDurationMs": 302.57500000000005,
"heapDeltaBytes": -811664,
"heapUsedBytes": 74458240,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.985000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2009.633000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.124,
"layouts": 10,
"layoutDurationMs": 2.0340000000000003,
"taskDurationMs": 298.42,
"heapDeltaBytes": 22091632,
"heapUsedBytes": 88438416,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.744999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1944.4459999999992,
"styleRecalcs": 81,
"styleRecalcDurationMs": 13.931000000000001,
"layouts": 9,
"layoutDurationMs": 2.0149999999999997,
"taskDurationMs": 741.578,
"heapDeltaBytes": 15087076,
"heapUsedBytes": 81360140,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 104.458,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1672.7500000000077,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.801,
"layouts": 10,
"layoutDurationMs": 2.1189999999999998,
"taskDurationMs": 471.708,
"heapDeltaBytes": 15645120,
"heapUsedBytes": 81044416,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 88.12599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.1610000000278,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.6989999999999994,
"layouts": 13,
"layoutDurationMs": 2.095,
"taskDurationMs": 204.098,
"heapDeltaBytes": 18327220,
"heapUsedBytes": 84562020,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6.706,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1809.9819999999909,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.56,
"layouts": 13,
"layoutDurationMs": 2.77,
"taskDurationMs": 296.38200000000006,
"heapDeltaBytes": -4535940,
"heapUsedBytes": 70452116,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.046999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064224,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 414.8130000000094,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8669999999999995,
"layouts": 10,
"layoutDurationMs": 2.372,
"taskDurationMs": 290.96299999999997,
"heapDeltaBytes": 25231396,
"heapUsedBytes": 91029044,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 99.872,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 510.7119999999554,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.887,
"layouts": 10,
"layoutDurationMs": 2.4499999999999997,
"taskDurationMs": 344.289,
"heapDeltaBytes": 24818596,
"heapUsedBytes": 91122676,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 121.041,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 892.8949999999816,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.144,
"heapDeltaBytes": -12530016,
"heapUsedBytes": 81590828,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 39.928,
"eventListeners": -106,
"totalBlockingTimeMs": 247,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 882.0330000000354,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.237,
"heapDeltaBytes": -12726020,
"heapUsedBytes": 81312680,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 34.027,
"eventListeners": -106,
"totalBlockingTimeMs": 250,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.5320000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.981,
"heapDeltaBytes": -5240848,
"heapUsedBytes": 76137956,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 88.29799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 86,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 677.1700000000465,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 250.47600000000037,
"heapDeltaBytes": -4494908,
"heapUsedBytes": 76472784,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 80.81099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 79,
"frameDurationMs": 20.097058823529416,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5853.550000000013,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.112,
"layouts": 5,
"layoutDurationMs": 1.1949999999999998,
"taskDurationMs": 4779.109,
"heapDeltaBytes": -8509972,
"heapUsedBytes": 90459652,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 3860.964,
"eventListeners": -68,
"totalBlockingTimeMs": 51,
"frameDurationMs": 19.242434210526312,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5180.034000000034,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2510000000000003,
"layouts": 5,
"layoutDurationMs": 1.2249999999999999,
"taskDurationMs": 4271.116,
"heapDeltaBytes": -10851088,
"heapUsedBytes": 87848276,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 3466.35,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.33724832214765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6322.046999999998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2589999999999997,
"layouts": 4,
"layoutDurationMs": 1.0480000000000003,
"taskDurationMs": 5247.09,
"heapDeltaBytes": 1255356,
"heapUsedBytes": 88492476,
"domNodes": -258,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 4116.932999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 68,
"frameDurationMs": 19.61583850931677,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5301.875999999993,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.849,
"layouts": 3,
"layoutDurationMs": 0.7560000000000001,
"taskDurationMs": 4392.773,
"heapDeltaBytes": -13684096,
"heapUsedBytes": 85938132,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 3449.423,
"eventListeners": -67,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.376721311475407,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-combo-open",
"durationMs": 141.04599999998868,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.97,
"layouts": 12,
"layoutDurationMs": 2.661,
"taskDurationMs": 102.101,
"heapDeltaBytes": -8061592,
"heapUsedBytes": 79595272,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5.774000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 142.6789999999869,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.596,
"layouts": 12,
"layoutDurationMs": 2.8040000000000003,
"taskDurationMs": 96.72399999999999,
"heapDeltaBytes": 13094336,
"heapUsedBytes": 90144328,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 5.838,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2026.4080000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4739999999999998,
"layouts": 9,
"layoutDurationMs": 2.2520000000000002,
"taskDurationMs": 363.73499999999996,
"heapDeltaBytes": -2330744,
"heapUsedBytes": 76654468,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 20.816000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2026.3679999999908,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8599999999999997,
"layouts": 10,
"layoutDurationMs": 1.8039999999999998,
"taskDurationMs": 344.5690000000001,
"heapDeltaBytes": -2402952,
"heapUsedBytes": 76664076,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 17.957000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2197.4329999999895,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.337,
"layouts": 9,
"layoutDurationMs": 2.082,
"taskDurationMs": 1062.9550000000002,
"heapDeltaBytes": -29004632,
"heapUsedBytes": 68167212,
"domNodes": -258,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 521.993,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666412213740458,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2114.9599999999964,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.833,
"layouts": 9,
"layoutDurationMs": 1.9329999999999998,
"taskDurationMs": 1027.382,
"heapDeltaBytes": -28846644,
"heapUsedBytes": 68403180,
"domNodes": -258,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 528.106,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666929133858265,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3111.2620000000106,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.2010000000000005,
"layouts": 65,
"layoutDurationMs": 10.003,
"taskDurationMs": 1019.8390000000002,
"heapDeltaBytes": 1629848,
"heapUsedBytes": 82690596,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 473.40000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666310160427805,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3172.699000000023,
"styleRecalcs": 74,
"styleRecalcDurationMs": 7.742000000000001,
"layouts": 67,
"layoutDurationMs": 10.842,
"taskDurationMs": 1119.561,
"heapDeltaBytes": -10282796,
"heapUsedBytes": 72397836,
"domNodes": -234,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 506.951,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66544502617801,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2200.3349999999955,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.295,
"layouts": 7,
"layoutDurationMs": 1.6,
"taskDurationMs": 1181.9950000000001,
"heapDeltaBytes": 1440732,
"heapUsedBytes": 78756420,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 609.158,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2138.2299999999645,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.319000000000001,
"layouts": 7,
"layoutDurationMs": 1.63,
"taskDurationMs": 1044.223,
"heapDeltaBytes": 4072080,
"heapUsedBytes": 86930572,
"domNodes": 0,
"jsHeapTotalBytes": 5992448,
"scriptDurationMs": 582.8950000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666406249999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2021.5749999999844,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6090000000000002,
"layouts": 9,
"layoutDurationMs": 1.5679999999999998,
"taskDurationMs": 355.221,
"heapDeltaBytes": -2547028,
"heapUsedBytes": 78388116,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 18.497000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.3130000000206,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8400000000000003,
"layouts": 9,
"layoutDurationMs": 2.4699999999999998,
"taskDurationMs": 473.867,
"heapDeltaBytes": -2489944,
"heapUsedBytes": 78725380,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 29.14599999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.2779999999716,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.46,
"layouts": 10,
"layoutDurationMs": 2.327,
"taskDurationMs": 259.572,
"heapDeltaBytes": 3093064,
"heapUsedBytes": 80053872,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 89.358,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.2889999999925,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.323,
"layouts": 11,
"layoutDurationMs": 2.771,
"taskDurationMs": 294.17400000000004,
"heapDeltaBytes": 20325724,
"heapUsedBytes": 86858660,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 100.296,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2027.25700000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.17,
"layouts": 10,
"layoutDurationMs": 1.944,
"taskDurationMs": 329.352,
"heapDeltaBytes": -17132080,
"heapUsedBytes": 58949320,
"domNodes": -180,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 7.599,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.7830000000508,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.966,
"layouts": 10,
"layoutDurationMs": 1.8519999999999999,
"taskDurationMs": 260.35,
"heapDeltaBytes": 22441208,
"heapUsedBytes": 89864660,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 5.081,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.9459999999963,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.319,
"layouts": 10,
"layoutDurationMs": 2.077,
"taskDurationMs": 464.90400000000005,
"heapDeltaBytes": 11148940,
"heapUsedBytes": 78517204,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 72.048,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.290000000004,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.087999999999997,
"layouts": 10,
"layoutDurationMs": 2.0030000000000006,
"taskDurationMs": 451.315,
"heapDeltaBytes": 11659036,
"heapUsedBytes": 78988036,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 68.17300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.3760000000243,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.410999999999998,
"layouts": 5,
"layoutDurationMs": 9.266999999999998,
"taskDurationMs": 579.5819999999999,
"heapDeltaBytes": 7452208,
"heapUsedBytes": 99299112,
"domNodes": 15953,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 17.152,
"eventListeners": 3244,
"totalBlockingTimeMs": 71,
"frameDurationMs": 18.990697674418602,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8135.244999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.829,
"layouts": 9,
"layoutDurationMs": 1.9909999999999997,
"taskDurationMs": 3453.9680000000003,
"heapDeltaBytes": -7912512,
"heapUsedBytes": 88257888,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 1731.855,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618852459016,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8409.197000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.793999999999997,
"layouts": 8,
"layoutDurationMs": 2.0220000000000002,
"taskDurationMs": 3817.309,
"heapDeltaBytes": -14890944,
"heapUsedBytes": 83136360,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 1856.011,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699007936507936,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14634.151999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13620.655999999999,
"heapDeltaBytes": 32753276,
"heapUsedBytes": 312056432,
"domNodes": -3330,
"jsHeapTotalBytes": 52154368,
"scriptDurationMs": 166.458,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.985059422750428,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 16533.33200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15536.874999999998,
"heapDeltaBytes": -7761004,
"heapUsedBytes": 288987140,
"domNodes": -3330,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 223.461,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.435223367697592,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 17420.43799999999,
"styleRecalcs": 154,
"styleRecalcDurationMs": 12.325000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17002.238,
"heapDeltaBytes": -4247148,
"heapUsedBytes": 277682436,
"domNodes": -3330,
"jsHeapTotalBytes": 10477568,
"scriptDurationMs": 566.513,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.46678700361011,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 18928.205999999933,
"styleRecalcs": 143,
"styleRecalcDurationMs": 15.05999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18578.054,
"heapDeltaBytes": -3825192,
"heapUsedBytes": 278045064,
"domNodes": -3330,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 660.32,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 35.19089219330855,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5168.549000000041,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.53299999999999,
"layouts": 20,
"layoutDurationMs": 17.502000000000002,
"taskDurationMs": 5037.982000000001,
"heapDeltaBytes": 25363056,
"heapUsedBytes": 297859688,
"domNodes": -3330,
"jsHeapTotalBytes": 36167680,
"scriptDurationMs": 67.06599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.937125748502993,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 5933.219000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.782999999999994,
"layouts": 20,
"layoutDurationMs": 22.311999999999998,
"taskDurationMs": 5821.973999999999,
"heapDeltaBytes": 4975324,
"heapUsedBytes": 286740292,
"domNodes": -3330,
"jsHeapTotalBytes": 33546240,
"scriptDurationMs": 85.984,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.31666666666666,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7224.385999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6558.646,
"heapDeltaBytes": -26999472,
"heapUsedBytes": 265437652,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 75.06800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.110000000000007,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8409.934000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8064.026999999999,
"heapDeltaBytes": 14556436,
"heapUsedBytes": 284730332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.991,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.92199312714777,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 90.77099999996108,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.037,
"layouts": 6,
"layoutDurationMs": 1.2090000000000003,
"taskDurationMs": 57.260000000000005,
"heapDeltaBytes": -15488232,
"heapUsedBytes": 68137920,
"domNodes": 97,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.772,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 88.10300000004645,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.591999999999999,
"layouts": 6,
"layoutDurationMs": 2.062,
"taskDurationMs": 62.416,
"heapDeltaBytes": -15503668,
"heapUsedBytes": 68783564,
"domNodes": 117,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.183,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 264.61200000005647,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.27,
"layouts": 76,
"layoutDurationMs": 13.044,
"taskDurationMs": 214.36899999999997,
"heapDeltaBytes": 9528472,
"heapUsedBytes": 93896896,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 92.74099999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 234.5300000000634,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0230000000000001,
"layouts": 76,
"layoutDurationMs": 11.977,
"taskDurationMs": 192.796,
"heapDeltaBytes": 9109604,
"heapUsedBytes": 94500624,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 82.107,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 319.35599999997066,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2169999999999996,
"layouts": 76,
"layoutDurationMs": 13.053,
"taskDurationMs": 277.156,
"heapDeltaBytes": -6675180,
"heapUsedBytes": 108005020,
"domNodes": 4,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 95.773,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 335.61699999995653,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2,
"layouts": 76,
"layoutDurationMs": 13.495999999999999,
"taskDurationMs": 286.876,
"heapDeltaBytes": -1087840,
"heapUsedBytes": 125097340,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.554,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 56d6f68564f812c7df1ab4c8bd50a8bfafd7cdfe
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21870 +/- ##
=============================================
Coverage ? 85.20%
=============================================
Files ? 2522
Lines ? 132940
Branches ? 38259
=============================================
Hits ? 113266
Misses ? 19258
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at exact head. The cherry-pick is byte-identical to the already-merged core/1.57 carrier #21869 (same 1.57-line context), which itself matches merged main #21320: the 409 branch only reports a superseded answer when the conflict body carries a selected array, and retireAsk still runs unconditionally, so a selection-less 409 no longer shows a false "another answer won" notice. Required checks (lint-and-format, test, e2e-status) are green; upload-e2e-coverage / package is not a required check. Merging under the standing Agent backport authority for the current release trains.
Backport of #21320 to
cloud/1.57Automatically created by backport workflow.