Repository navigation
[backport core/1.57] feat(agent): ask_user question card and delete approval card (#19981, #20092) - #21308
Conversation
## Summary Renders the agent's `ask_user` question as a card on main, and sends `ask_kinds` on each turn so the server parks a turn only on an ask this panel can show. `paused` is the exception: the server raises it for every client, and it gets the notice below. Supersedes #18298. The delete approval card is #20092, stacked on this PR. - `AskUserCard.vue` shows the prompt and the options. A required single choice is radios (`AskUserRadioOptions`). Anything else is checkboxes capped at `max_selections` (`AskUserCheckboxOptions`) with a hint. With `allow_other`, an Other box counts as one more selection, matching the server's `validateSelection`. The parser dedupes option ids, caps options at 50, clips long text and caps `max_selections` at what can be chosen. An ask with nothing to choose, or with bounds the card can't satisfy (a minimum above what it can offer, or a maximum below one), gets the notice instead of a card that could only draw 422s. - The answer goes through `answerAsk` (`POST /agent/threads/:id/asks/:ask_id/answer`) with the generated `AgentAnswerRequest`. Outcomes by response: - 202: the card shows the answer the receipt committed. A status-only 202 reads as "Answered" and leaves the comparison to the frame. - 409: the card shows the stored outcome from `AgentAskConflict`, or "no longer open here" when the body has none. - 422: nothing was committed, so the card goes back into service and the error overlay asks the user to change their choices or stop the turn. - 403/404/501: refusals, so the card is retired. - Any other failure, 400 included, reads as unconfirmed. - When a committed answer from the receipt, the 409 body or the frame differs from what this tab sent, in ids or in free text, the user gets one "answered somewhere else" toast. - A resolved card stays read-only and shows what the server committed. A cancelled or expired ask reads "closed without an answer". - Types come from `@comfyorg/ingest-types`. `AskUserResolution` is a discriminated union, and only `answered` carries `selected`/`otherText`. - Parse policy (differs from draft #20891): `kind` is `AgentAskKind | 'unknown'`, via `.catch('unknown')`. A kind this client predates, or `paused`, shows the `askUnavailable` notice instead of failing the frame or the transcript parse. The answer receipt keeps `selected` optional. #20891 switches both to the strict generated schemas; whichever PR merges second has to pick one policy. - Coordination: #16949 and #18949 each add their own `handleAnswerFailure`, and this PR adds a third. The three agree on 400 (unconfirmed). On the 202, this PR treats a receipt that carries `selected` as the committed answer and defers a status-only 202 to the frame. #18949's notice for a status-only 202 on a recovered card can sit alongside that. This PR's `retireAsk(askId, resolution, owner?)` takes a required resolution, and `answerAsk` takes an `AgentAnswerRequest`. Whichever lands second merges the three handlers and updates those call sites. #18949 also restores only `run_approval` asks and should widen recovery to every pending ask kind. - Boundaries: main now classifies every `src` file (#20802), so the card's `Button`, `Input`, `Checkbox` and `RadioGroup` imports cross from `agent` into `design-system`. This PR approves `agent` as a `design-system` consumer in both records and regenerates `boundaries.json`. It is the first dependency approval in the catalog, so it needs a design-system owner's review. - Known limitation: the server keeps `pending_ask` only while the ask is pending, so a resolved card disappears when the thread is loaded again (a reload, or opening another chat and coming back). The agent README notes this. ## Verification - Vitest: `pnpm exec vitest run src/workbench/extensions/agent`, 163 files, 3,416 tests. Each new test fails under the mutation it targets, for example: the watchdog dropping the 202 receipt on a live turn, a 422 keeping the rejected answer, the old empty-answer guard, reporting a status-only 202, 400 as a refusal, a one-way id comparison, clamping unsatisfiable bounds and the single optional choice hint. - Playwright: `agentRunApprovalConsent.spec.ts` (consent) and `agentAskUserQuestion.spec.ts` (question). The question spec posts once to its ask and reads back the committed answer, and screenshots each card state (radio, in flight, closed, retired, unconfirmed) plus the notice. The eight Linux baselines moved with the spec. - `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, eslint, oxfmt and knip are clean. --------- Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit 4659fc2)
## Summary Renders the agent's `delete_approval` ask as its own card, so a delete of nodes the user added waits for an explicit Delete or Keep. Stacked on #19981. - `DeleteApprovalCard.vue` is built like `RunApprovalCard.vue`. It shows the host's prompt, the nodes it would remove (title, else type, and `#id`), then Keep (secondary) and Delete (destructive). The answer goes through the shared `answerAsk` path as `{ selected: ["delete" | "keep"] }`, so it inherits #19981's handling: the committed 202/409 answer, 422 back into service, refusals retired. - `context` is parsed with the generated `zAgentDeleteApprovalContext`. The card lists the server's nodes (at most 50 by contract, unique by id) and says "N more nodes not listed" from `hidden_node_count`, so the user always knows how many nodes a Delete covers. - Some asks fall back to the existing warning notice, so Delete is never armed without the node list: - options other than exactly `delete`/`keep` as one required choice, or with free text allowed; - a `context` the generated schema rejects (missing, empty, or a malformed entry); - a node with a blank id, which the client rejects in `toDeleteTargets` because the generated `id` is a plain string. - Once resolved the card stays read-only. An answer reads back the committed choice ("Answered: delete them"). A server close, a local retirement and an unconfirmed answer each have their own line, keyed by status like `AskUserAnswer`. - `RENDERED_ASK_KINDS` gains `delete_approval`, so `ask_kinds` advertises it on each turn. Strings live under `agent.deleteApproval.*`. - Backend: the server accepts `delete_approval` in `ask_kinds` but does not raise this ask yet. The `ask_kinds` description in this repo's `packages/ingest-types/src/types.gen.ts` says "`delete_approval` raises no card yet", so the card is inert until that lands. - Parse policy: like #19981, a rejected delete context degrades to the notice for that ask. Draft #20891 parses ask frames with the strict generated schema, under which the same context drops the live frame or fails the history load. Whichever PR lands second picks one policy. ## Verification - Vitest: `pnpm exec vitest run src/workbench/extensions/agent` (163 files, 3,434 tests): - `agentMessageParts.test.ts`: parsing, `hidden_node_count`, notice fallbacks, option shape, retirement; - `AgentMessage.test.ts`: card, node list, answers, in flight, unlisted count, every resolved readback; - `agentConversationStore.test.ts`: settling drops a pending delete card, and a retired one stays read-only through a refetch; - `agentRestClient.test.ts`: `ask_kinds` as literals. - After merging #19981, making `retireAskParts` keep only `ask_user` cards still fails the retention tests. - Playwright, `browser_tests/tests/agent/agentAskConsent.spec.ts` (renamed from `agentRunApprovalConsent.spec.ts`; it now covers every ask card): - The delete approval case lists the nodes, then one click posts once to that ask with the card locked while in flight, then the resolved card reads back the answer. - The frame comes from `fixtures/data/agent/agentAskFrames.ts`, typed against the generated `AgentAskFrame`. The turn harness is #19981's `agentAskTurnFixture`. - All six cases pass locally against a cloud-mode dev server. - Screenshot: `agent-delete-approval-card-cloud-linux.png`, the pending card, recorded through the New Browser Test Expectations run:  - Storybook: `Agent/AgentMessage` has `DeleteApproval`, `DeleteApprovalPending`, `DeleteApprovalLongList` (50 listed, 30 unlisted) and `DeleteApprovalResolved`. - `pnpm typecheck`, `pnpm typecheck:browser`, oxlint, oxfmt and knip are clean. --------- Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit 6df2775)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-18T22:27:56.898Z",
"gitSha": "e327ca20b5955d8f144d6d48676d2693d35dd74a",
"branch": "backport-19981-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.2040000000065,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2439999999999993,
"layouts": 9,
"layoutDurationMs": 2.3919999999999995,
"taskDurationMs": 494.111,
"heapDeltaBytes": 22154752,
"heapUsedBytes": 87536900,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.208,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2009.7839999999678,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2969999999999997,
"layouts": 9,
"layoutDurationMs": 2.489,
"taskDurationMs": 337.065,
"heapDeltaBytes": 22111072,
"heapUsedBytes": 88045468,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.886000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.0279999999989,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.247000000000002,
"layouts": 9,
"layoutDurationMs": 2.277,
"taskDurationMs": 703.0110000000001,
"heapDeltaBytes": 15167584,
"heapUsedBytes": 81413600,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 161.34799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1976.4750000000504,
"styleRecalcs": 84,
"styleRecalcDurationMs": 16.389,
"layouts": 10,
"layoutDurationMs": 3.207,
"taskDurationMs": 1064.6200000000001,
"heapDeltaBytes": -8250200,
"heapUsedBytes": 66697636,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 164.69299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66638655462185,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.0000000000173,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.465,
"layouts": 11,
"layoutDurationMs": 2.8649999999999993,
"taskDurationMs": 376.18299999999994,
"heapDeltaBytes": 18784184,
"heapUsedBytes": 84571872,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.346999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1808.905999999979,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.437000000000001,
"layouts": 11,
"layoutDurationMs": 3.0730000000000004,
"taskDurationMs": 329.594,
"heapDeltaBytes": 18716128,
"heapUsedBytes": 85416828,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.332,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678898,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.9939999999751,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.723,
"layouts": 10,
"layoutDurationMs": 2.7030000000000003,
"taskDurationMs": 514.338,
"heapDeltaBytes": 3531860,
"heapUsedBytes": 78810920,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 174.077,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 659.1920000000755,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.339000000000001,
"layouts": 10,
"layoutDurationMs": 3.0230000000000006,
"taskDurationMs": 454.09200000000004,
"heapDeltaBytes": 25257148,
"heapUsedBytes": 91500636,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 172.16199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923077,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.5339999999815,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 903.7940000000001,
"heapDeltaBytes": -3493856,
"heapUsedBytes": 80978216,
"domNodes": -192,
"jsHeapTotalBytes": 13115392,
"scriptDurationMs": 67.066,
"eventListeners": -106,
"totalBlockingTimeMs": 536,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1226.3370000000577,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 915.654,
"heapDeltaBytes": -11443560,
"heapUsedBytes": 81171776,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 67.49000000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 545,
"frameDurationMs": 33.33513513513515,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.9820000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.83700000000016,
"heapDeltaBytes": -4803432,
"heapUsedBytes": 76894716,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 154.17799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 211,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.5179999999746,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.43400000000025,
"heapDeltaBytes": -5278564,
"heapUsedBytes": 76275892,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 162.54000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10438.742999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9528.364,
"heapDeltaBytes": -16105556,
"heapUsedBytes": 83134252,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 7704.022999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 832,
"frameDurationMs": 31.424397590361444,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10639.869999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9767.041000000001,
"heapDeltaBytes": -13945180,
"heapUsedBytes": 85652648,
"domNodes": -258,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 7974.084000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1093,
"frameDurationMs": 31.457988165680476,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9643.883000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8824.586,
"heapDeltaBytes": -2658776,
"heapUsedBytes": 96387568,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 7101.504,
"eventListeners": -68,
"totalBlockingTimeMs": 610,
"frameDurationMs": 31.58360655737705,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10440.650000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9634.793,
"heapDeltaBytes": -5281940,
"heapUsedBytes": 82434196,
"domNodes": -258,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 7757.73,
"eventListeners": -68,
"totalBlockingTimeMs": 1017,
"frameDurationMs": 31.05029761904762,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 218.17800000002308,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.175,
"layouts": 11,
"layoutDurationMs": 2.941,
"taskDurationMs": 165.016,
"heapDeltaBytes": -8062596,
"heapUsedBytes": 79439172,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.246,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 207.53799999999956,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.097000000000001,
"layouts": 11,
"layoutDurationMs": 3.4149999999999996,
"taskDurationMs": 152.00400000000002,
"heapDeltaBytes": 12964156,
"heapUsedBytes": 91875768,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 8.427,
"eventListeners": 195,
"totalBlockingTimeMs": 1,
"frameDurationMs": 24.055555555555557,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2042.1429999999532,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3690000000000007,
"layouts": 8,
"layoutDurationMs": 2.357,
"taskDurationMs": 444.27399999999994,
"heapDeltaBytes": -2106524,
"heapUsedBytes": 77485040,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 31.998000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.643999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.817,
"layouts": 7,
"layoutDurationMs": 1.63,
"taskDurationMs": 606.0429999999999,
"heapDeltaBytes": -3322520,
"heapUsedBytes": 75758928,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 39.17100000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2512.089000000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.917000000000001,
"layouts": 7,
"layoutDurationMs": 2.009,
"taskDurationMs": 1673.6769999999997,
"heapDeltaBytes": -5588916,
"heapUsedBytes": 92306840,
"domNodes": -278,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 825.706,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2480.639999999994,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.971,
"layouts": 6,
"layoutDurationMs": 1.752,
"taskDurationMs": 1682.6470000000002,
"heapDeltaBytes": -29345540,
"heapUsedBytes": 68972444,
"domNodes": -258,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 814.365,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779054054054054,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3639.671000000021,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.114000000000001,
"layouts": 64,
"layoutDurationMs": 10.657,
"taskDurationMs": 1763.17,
"heapDeltaBytes": -9353064,
"heapUsedBytes": 72185048,
"domNodes": -254,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 792.006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3597.3260000000664,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.883000000000001,
"layouts": 66,
"layoutDurationMs": 11.028,
"taskDurationMs": 1739.687,
"heapDeltaBytes": -5780528,
"heapUsedBytes": 72486000,
"domNodes": -254,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 766.301,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2852.7049999999576,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.917000000000001,
"layouts": 5,
"layoutDurationMs": 1.418,
"taskDurationMs": 1747.031,
"heapDeltaBytes": 5141780,
"heapUsedBytes": 88186768,
"domNodes": 0,
"jsHeapTotalBytes": 7041024,
"scriptDurationMs": 954.8349999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86272189349112,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2927.6889999999867,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.4559999999999995,
"layouts": 4,
"layoutDurationMs": 0.9940000000000001,
"taskDurationMs": 1878.8869999999997,
"heapDeltaBytes": 15771292,
"heapUsedBytes": 98635452,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 940.0750000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76057142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.7829999999858,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2949999999999995,
"layouts": 7,
"layoutDurationMs": 2.3109999999999995,
"taskDurationMs": 634.1249999999999,
"heapDeltaBytes": -16737328,
"heapUsedBytes": 81526648,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 32.218999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.3820000000833,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9230000000000003,
"layouts": 7,
"layoutDurationMs": 1.8639999999999999,
"taskDurationMs": 614.0079999999999,
"heapDeltaBytes": -27463904,
"heapUsedBytes": 71511988,
"domNodes": -278,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 30.660999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 657.1509999999989,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.872999999999999,
"layouts": 10,
"layoutDurationMs": 2.7860000000000005,
"taskDurationMs": 460.391,
"heapDeltaBytes": -1859844,
"heapUsedBytes": 74536584,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 150.356,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.1419999999962,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.482000000000001,
"layouts": 9,
"layoutDurationMs": 2.679,
"taskDurationMs": 425.674,
"heapDeltaBytes": 21547216,
"heapUsedBytes": 88588200,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 143.88899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.885999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.514999999999999,
"layouts": 9,
"layoutDurationMs": 2.8699999999999997,
"taskDurationMs": 353.29699999999997,
"heapDeltaBytes": 22439268,
"heapUsedBytes": 89706952,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.552,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.6960000000763,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6319999999999997,
"layouts": 9,
"layoutDurationMs": 2.641,
"taskDurationMs": 343.971,
"heapDeltaBytes": 21987168,
"heapUsedBytes": 89397488,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.126,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1972.7000000000317,
"styleRecalcs": 87,
"styleRecalcDurationMs": 16.12,
"layouts": 10,
"layoutDurationMs": 2.4769999999999994,
"taskDurationMs": 1024.062,
"heapDeltaBytes": 11654940,
"heapUsedBytes": 78973916,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 109.63,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.3310000000201,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.026,
"layouts": 10,
"layoutDurationMs": 2.713,
"taskDurationMs": 1005.884,
"heapDeltaBytes": -11368756,
"heapUsedBytes": 65644776,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 110.046,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.2369999999723,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.534999999999997,
"layouts": 5,
"layoutDurationMs": 16.389999999999997,
"taskDurationMs": 1034.603,
"heapDeltaBytes": 7383904,
"heapUsedBytes": 105101224,
"domNodes": 15953,
"jsHeapTotalBytes": 17965056,
"scriptDurationMs": 27.753000000000007,
"eventListeners": 3244,
"totalBlockingTimeMs": 152,
"frameDurationMs": 19.863013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8991.36100000004,
"styleRecalcs": 248,
"styleRecalcDurationMs": 17.657,
"layouts": 6,
"layoutDurationMs": 1.681,
"taskDurationMs": 5811.848,
"heapDeltaBytes": -14217716,
"heapUsedBytes": 82803372,
"domNodes": -258,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2690.0269999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759328358208958,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9253.126000000066,
"styleRecalcs": 249,
"styleRecalcDurationMs": 17.967,
"layouts": 7,
"layoutDurationMs": 1.6929999999999998,
"taskDurationMs": 5855.926,
"heapDeltaBytes": 14236972,
"heapUsedBytes": 93297204,
"domNodes": -258,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 2729.505,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72644927536232,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16703.171,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15674.93,
"heapDeltaBytes": -8585616,
"heapUsedBytes": 272829704,
"domNodes": -3330,
"jsHeapTotalBytes": 24109056,
"scriptDurationMs": 309.88899999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.862629757785463,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 16759.627999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15867.777,
"heapDeltaBytes": -5683712,
"heapUsedBytes": 285224932,
"domNodes": -2268,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 238.47000000000003,
"eventListeners": -423,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.057192374350088,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 27904.54299999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.769999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27498.446,
"heapDeltaBytes": -19392672,
"heapUsedBytes": 275890012,
"domNodes": -3330,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 855.7320000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 28,
"frameDurationMs": 51.409760589318594,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28569.280999999934,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.31100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28143.337,
"heapDeltaBytes": -639712,
"heapUsedBytes": 275806428,
"domNodes": -3330,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 897.057,
"eventListeners": -651,
"totalBlockingTimeMs": 90,
"frameDurationMs": 52.41376146788991,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8193.304000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.58499999999998,
"layouts": 20,
"layoutDurationMs": 22.124999999999993,
"taskDurationMs": 8055.437000000002,
"heapDeltaBytes": -19792232,
"heapUsedBytes": 276306104,
"domNodes": -3330,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 126.90500000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.494886363636354,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8612.659000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.388,
"layouts": 20,
"layoutDurationMs": 25.22999999999999,
"taskDurationMs": 8473.838,
"heapDeltaBytes": -40708412,
"heapUsedBytes": 255012980,
"domNodes": -3330,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 165.244,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.58531073446328,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11397.41399999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11005.625000000002,
"heapDeltaBytes": -24788880,
"heapUsedBytes": 248941324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.68000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.33992932862191,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8288.68799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7889.267999999999,
"heapDeltaBytes": -8861304,
"heapUsedBytes": 258826636,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.1690000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.077966101694916,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 518.6630000000036,
"styleRecalcs": 23,
"styleRecalcDurationMs": 20.179,
"layouts": 11,
"layoutDurationMs": 4.893,
"taskDurationMs": 169.274,
"heapDeltaBytes": 7262192,
"heapUsedBytes": 80337104,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 23.097999999999995,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 146.69399999991128,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.314999999999998,
"layouts": 8,
"layoutDurationMs": 3.707,
"taskDurationMs": 93.326,
"heapDeltaBytes": 4470472,
"heapUsedBytes": 77219360,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.151999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 465.2889999999843,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9259999999999999,
"layouts": 76,
"layoutDurationMs": 14.205,
"taskDurationMs": 411.006,
"heapDeltaBytes": -21753736,
"heapUsedBytes": 71707868,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 192.17100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 477.03100000001086,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.306,
"layouts": 76,
"layoutDurationMs": 15.51,
"taskDurationMs": 415.231,
"heapDeltaBytes": 11228944,
"heapUsedBytes": 81829612,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 197.27100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 493.3520000000726,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8359999999999999,
"layouts": 76,
"layoutDurationMs": 14.151,
"taskDurationMs": 458.834,
"heapDeltaBytes": -343360,
"heapUsedBytes": 116081872,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 185.26700000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 660.2090000000089,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.942,
"layouts": 76,
"layoutDurationMs": 15.356,
"taskDurationMs": 620.523,
"heapDeltaBytes": -9005480,
"heapUsedBytes": 141570772,
"domNodes": 4,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 247.994,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.523076923076935,
"p95FrameDurationMs": 33.29999999999927
}
]
}🎭 Playwright: ✅ 2280 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 04577355d1c067cad84b4233f78dd44d4f93211c
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.57 #21308 +/- ##
=============================================
+ Coverage 87.17% 87.19% +0.02%
=============================================
Files 2616 2624 +8
Lines 147152 147451 +299
Branches 40361 40498 +137
=============================================
+ Hits 128275 128573 +298
- Misses 18489 18490 +1
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 5 |
| ⚪ Nit | 2 |
Panel: 6/6 reviewers contributed findings.
|
Cursor review triage. This PR is byte-identical to the merged code on
|
|
Skipping Bugbot: Unable to authenticate your request. Please make sure Bugbot is properly installed and configured for this repository. |
…nning (Comfy-Org#21320) ## Summary A 409 from the ask answer endpoint can come back with `selected` missing or `null` (`AgentAskConflict.selected` is nullish). `toAskResolution` turns that into an answered resolution with `selected: []`, and the 409 branch always ran the superseded check. So a user who picked an option got a false "answered somewhere else" notice and an `agent_ask_answer_superseded` error report, even though nothing said another answer won. Fix: only run the superseded comparison when the conflict body actually carries a selection array. This is the same guard the 202 path already has (`receipt.selected !== undefined`). The card is still retired with the conflict's status, as before. Found by the cursor-review panel on the 1.57 backports of Comfy-Org#19981/Comfy-Org#20092 (Comfy-Org#21308, Comfy-Org#21309). The code there is identical to main, so this fix goes to main first and is backported after those land. ## Tests - New: `does not report a 409 with no selection as another answer winning` and `... with a null selection ...` in `useAgentSession.test.ts`. Both fail on main before the fix (`reportError` called with `agent_ask_answer_superseded`) and pass after. - Existing `shows the answer a 409 reports as already committed` (409 that names another selection) still reports superseded. - `useAgentSession.test.ts`: 253 pass. The one failure is the known order-dependent `(g18)` test, which fails on main without this change (https://linear.app/comfyorg/issue/FE-3485).
Manual backport of #19981 and its stacked follow-up #20092 to
core/1.57. Two commits, in merge order, so 1.57 users get the real "Ask user" card and the delete-approval card.Why
On 1.57 the agent panel cannot render an
ask_userquestion, so a Desktop turn that asks one hangs with the spinner running until the user presses stop (https://linear.app/comfyorg/issue/PM-2127). The backport of both PRs to this line was approved by Christian on 2026-10-18.What differs from the originals
docs/architecture/domainsboundary edits from feat(agent): render ask_user questions and advertise ask_kinds #19981. On 1.57 the tworecords/*.domain.jsonfiles do not exist andboundaries.jsonhas noagentordesign-systemrules, so there is nothing to approve.agentApiSchema.tsimports: 1.57 does not importzAgentAttachmentRejected; kept the line's imports plus the new ask schemas.@comfyorg/ingest-typeson 1.57 already exportszAgentAskKind,zAgentPendingAskBaseandzAgentAskResolvedData.Verification
pnpm typecheck:app,pnpm typecheck:browser, oxlint, eslint, stylelint, oxfmt: clean (pre-commit).vitest run src/workbench/extensions/agent: 164 files pass. One known order-dependent test,(g18) a history fetch that never answers is abandoned at the recovery deadline, fails when run alone on this line, on unchangedcore/1.57and onmainalike, so it is not caused by this backport.Do not merge one commit without the other: #20092 is stacked on #19981.