Repository navigation
fix(agent): report a free-text-only answer that won elsewhere - #21829
Conversation
#21320 skipped the superseded check on a 409 unless the conflict body carried a `selected` array. The schema allows a committed free-text-only answer (`status: answered`, `selected` null or omitted, `other_text` set), so a user whose answer lost to someone else's free text got no "answered somewhere else" notice and no telemetry. The rule "a body that names no answer cannot show another answer won" now lives in one predicate, `namesCommittedAnswer` (a `selected` array or non-empty `other_text`), checked inside `reportSupersededAnswer`, so the 202 receipt, the 409 conflict and the `agent_ask_resolved` frame all use it. The frame path previously had no guard, so an answered frame with a null selection also raised a false superseded report. Follow-up to the cursor-review findings on #21320.
📦 Bundle: 12 MB gzip 🟢 -516 BDetailsSummary
Category Glance App Entry Points — 6.74 kB (baseline 6.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 160 kB (baseline 160 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 19 unchanged Panels & Settings — 871 kB (baseline 871 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 149 kB (baseline 149 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 252 kB (baseline 252 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 16 unchanged UI Components — 318 kB (baseline 318 kB) • ⚪ 0 BReusable component library chunks Status: 29 unchanged Data & Services — 1.82 MB (baseline 1.82 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 40 unchanged Utilities & Hooks — 1.31 MB (baseline 1.31 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 75 unchanged Vendor & Third-Party — 10.2 MB (baseline 10.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.9 MB (baseline 34.9 MB) • 🟢 -2.03 kBBundles that do not match a named category
Status: 2 added / 2 removed / 749 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T20:25:15.223Z",
"gitSha": "9a5a9beb03fb641d1139b65f67c3974d8dc2d25c",
"branch": "cbyrne/agent-ask-superseded-free-text",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.0500000000256,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.72,
"layouts": 9,
"layoutDurationMs": 2.4189999999999996,
"taskDurationMs": 395.39000000000004,
"heapDeltaBytes": 3672068,
"heapUsedBytes": 78369500,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.754999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2007.5600000000122,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.692,
"layouts": 10,
"layoutDurationMs": 2.379,
"taskDurationMs": 453.18600000000004,
"heapDeltaBytes": 3643368,
"heapUsedBytes": 78363300,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.330000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.59400000003,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.156999999999998,
"layouts": 9,
"layoutDurationMs": 2.367,
"taskDurationMs": 780.6840000000001,
"heapDeltaBytes": -5062372,
"heapUsedBytes": 69733916,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 132.374,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.2819999999829,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.864,
"layouts": 10,
"layoutDurationMs": 2.463,
"taskDurationMs": 751.695,
"heapDeltaBytes": -5132616,
"heapUsedBytes": 69663912,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 127.83200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6809999999518,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.579000000000001,
"layouts": 10,
"layoutDurationMs": 2.487,
"taskDurationMs": 367.68300000000005,
"heapDeltaBytes": -2203108,
"heapUsedBytes": 72415132,
"domNodes": 56,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 13.244,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.2150000000192,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.899,
"layouts": 11,
"layoutDurationMs": 2.2899999999999996,
"taskDurationMs": 320.25000000000006,
"heapDeltaBytes": -2208280,
"heapUsedBytes": 72459144,
"domNodes": 56,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 9.043,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 600.6849999999986,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9830000000000005,
"layouts": 9,
"layoutDurationMs": 2.4789999999999996,
"taskDurationMs": 442.257,
"heapDeltaBytes": 3659864,
"heapUsedBytes": 78099432,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 143.304,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 632.7140000000782,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5380000000000003,
"layouts": 8,
"layoutDurationMs": 1.9680000000000002,
"taskDurationMs": 460.06899999999996,
"heapDeltaBytes": 2009852,
"heapUsedBytes": 76809984,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 142.668,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621621,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1065.2900000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 750.0080000000002,
"heapDeltaBytes": 24333600,
"heapUsedBytes": 104144528,
"domNodes": 0,
"jsHeapTotalBytes": 19824640,
"scriptDurationMs": 52.61300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 434,
"frameDurationMs": 31.37058823529413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1035.176999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 699.188,
"heapDeltaBytes": 20656660,
"heapUsedBytes": 100506004,
"domNodes": 0,
"jsHeapTotalBytes": 19824640,
"scriptDurationMs": 53.62800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 401,
"frameDurationMs": 30.391176470588242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.7789999999582,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.2440000000002,
"heapDeltaBytes": -2513740,
"heapUsedBytes": 86452920,
"domNodes": 0,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 144.944,
"eventListeners": 0,
"totalBlockingTimeMs": 183,
"frameDurationMs": 23.52647058823531,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 794.514999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.55999999999995,
"heapDeltaBytes": -4625344,
"heapUsedBytes": 85715360,
"domNodes": 0,
"jsHeapTotalBytes": 4460544,
"scriptDurationMs": 129.74799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 168,
"frameDurationMs": 23.529411764705884,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7614.049999999992,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.294,
"layouts": 1,
"layoutDurationMs": 0.2819999999999997,
"taskDurationMs": 6712.151000000001,
"heapDeltaBytes": -3662412,
"heapUsedBytes": 86319776,
"domNodes": -141,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 5173.621,
"eventListeners": -49,
"totalBlockingTimeMs": 48,
"frameDurationMs": 23.801250000000003,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8190.313000000004,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.34100000000000014,
"layouts": 1,
"layoutDurationMs": 0.20499999999999988,
"taskDurationMs": 7352.223999999999,
"heapDeltaBytes": -12095388,
"heapUsedBytes": 78535576,
"domNodes": -141,
"jsHeapTotalBytes": 11399168,
"scriptDurationMs": 5815.611,
"eventListeners": -49,
"totalBlockingTimeMs": 64,
"frameDurationMs": 24.28189910979229,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7590.002999999968,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.791,
"layouts": 3,
"layoutDurationMs": 0.7139999999999997,
"taskDurationMs": 6694.5650000000005,
"heapDeltaBytes": -2408296,
"heapUsedBytes": 87761840,
"domNodes": -141,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 5171.363,
"eventListeners": -53,
"totalBlockingTimeMs": 52,
"frameDurationMs": 23.89874213836478,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8687.344999999994,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3549999999999994,
"layouts": 2,
"layoutDurationMs": 0.4469999999999999,
"taskDurationMs": 7772.722,
"heapDeltaBytes": -11579364,
"heapUsedBytes": 78848376,
"domNodes": -141,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 6236.273999999999,
"eventListeners": -53,
"totalBlockingTimeMs": 62,
"frameDurationMs": 25.31486880466473,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 195.2309999999784,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.873,
"layouts": 11,
"layoutDurationMs": 3.1710000000000003,
"taskDurationMs": 145.773,
"heapDeltaBytes": 14610096,
"heapUsedBytes": 89901016,
"domNodes": 936,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.748999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 186.18100000003324,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.548999999999998,
"layouts": 10,
"layoutDurationMs": 2.9279999999999995,
"taskDurationMs": 149.323,
"heapDeltaBytes": 14556488,
"heapUsedBytes": 89855484,
"domNodes": 936,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.518999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2025.4469999999856,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9160000000000004,
"layouts": 9,
"layoutDurationMs": 2.6020000000000003,
"taskDurationMs": 555.43,
"heapDeltaBytes": -6986176,
"heapUsedBytes": 86021240,
"domNodes": 0,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 32.954,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.5330000000567,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5580000000000003,
"layouts": 8,
"layoutDurationMs": 2.246,
"taskDurationMs": 522.2450000000001,
"heapDeltaBytes": -7020688,
"heapUsedBytes": 84528848,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 32.436,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2727.2689999999784,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.663,
"layouts": 8,
"layoutDurationMs": 1.9880000000000002,
"taskDurationMs": 1460.5810000000001,
"heapDeltaBytes": -4717392,
"heapUsedBytes": 88584104,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 693.465,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76871165644172,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2601.992999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.709000000000001,
"layouts": 8,
"layoutDurationMs": 1.8740000000000003,
"taskDurationMs": 1435.4909999999998,
"heapDeltaBytes": -5070136,
"heapUsedBytes": 87642560,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 705.7900000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3944.7250000000054,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.186,
"layouts": 66,
"layoutDurationMs": 11.360999999999999,
"taskDurationMs": 1591.5759999999998,
"heapDeltaBytes": 5058456,
"heapUsedBytes": 77279548,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 700.871,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666244725738395,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3680.3800000000138,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.412,
"layouts": 65,
"layoutDurationMs": 10.544,
"taskDurationMs": 1520.367,
"heapDeltaBytes": 5818228,
"heapUsedBytes": 77871308,
"domNodes": 24,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 684.704,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742272727272727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2957.99199999999,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.042000000000001,
"layouts": 6,
"layoutDurationMs": 1.5800000000000003,
"taskDurationMs": 1735.8179999999998,
"heapDeltaBytes": 22286536,
"heapUsedBytes": 94097492,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 849.1390000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759887005649716,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2438.16199999992,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.357000000000001,
"layouts": 5,
"layoutDurationMs": 1.1250000000000002,
"taskDurationMs": 1692.605,
"heapDeltaBytes": 18090584,
"heapUsedBytes": 89856132,
"domNodes": 0,
"jsHeapTotalBytes": 4612096,
"scriptDurationMs": 819.148,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78137931034483,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2908.492000000024,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.15,
"layouts": 7,
"layoutDurationMs": 1.827,
"taskDurationMs": 589.4079999999999,
"heapDeltaBytes": 388600,
"heapUsedBytes": 72648436,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 309.456,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666285714285713,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3021.840999999995,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.975,
"layouts": 7,
"layoutDurationMs": 1.667,
"taskDurationMs": 640.989,
"heapDeltaBytes": 26750384,
"heapUsedBytes": 98455676,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 316.69599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574585635359,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.6170000000152,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.476,
"layouts": 8,
"layoutDurationMs": 1.9959999999999996,
"taskDurationMs": 510.317,
"heapDeltaBytes": 15643228,
"heapUsedBytes": 87874108,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 33.416999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.3159999999652,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8389999999999995,
"layouts": 8,
"layoutDurationMs": 1.714,
"taskDurationMs": 472.34299999999996,
"heapDeltaBytes": 15810536,
"heapUsedBytes": 88840932,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 28.740999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2713.1430000000023,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.270999999999999,
"layouts": 7,
"layoutDurationMs": 2.5149999999999992,
"taskDurationMs": 493.64199999999994,
"heapDeltaBytes": 4476120,
"heapUsedBytes": 76491568,
"domNodes": 19,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 160.972,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665644171779142,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2702.635999999984,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.810999999999998,
"layouts": 7,
"layoutDurationMs": 1.572,
"taskDurationMs": 470.6730000000001,
"heapDeltaBytes": 4448800,
"heapUsedBytes": 76046932,
"domNodes": 19,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 160.608,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 3121.436000000017,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4720000000000013,
"layouts": 8,
"layoutDurationMs": 2.217,
"taskDurationMs": 787.146,
"heapDeltaBytes": 8284460,
"heapUsedBytes": 79854904,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 309.0810000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3067.5899999999956,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.94,
"layouts": 7,
"layoutDurationMs": 1.646,
"taskDurationMs": 749.5869999999999,
"heapDeltaBytes": 9718508,
"heapUsedBytes": 81317192,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 302.78700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.2389999999627,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.553999999999999,
"layouts": 10,
"layoutDurationMs": 2.544,
"taskDurationMs": 393.616,
"heapDeltaBytes": -905180,
"heapUsedBytes": 77016492,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 126.07199999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.394999999995,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.66,
"layouts": 10,
"layoutDurationMs": 2.039,
"taskDurationMs": 352.539,
"heapDeltaBytes": -1152536,
"heapUsedBytes": 76249344,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 118.37599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.9870000000142,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6499999999999995,
"layouts": 9,
"layoutDurationMs": 2.238,
"taskDurationMs": 482.276,
"heapDeltaBytes": 3589816,
"heapUsedBytes": 80172828,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.879000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.7520000000723,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3870000000000005,
"layouts": 9,
"layoutDurationMs": 2.0829999999999997,
"taskDurationMs": 445.192,
"heapDeltaBytes": 3557380,
"heapUsedBytes": 80538540,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 8.464,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.196000000024,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.009,
"layouts": 9,
"layoutDurationMs": 2.0420000000000003,
"taskDurationMs": 761.087,
"heapDeltaBytes": -8432128,
"heapUsedBytes": 68576472,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 96.981,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8669999999547,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.668999999999999,
"layouts": 10,
"layoutDurationMs": 2.169,
"taskDurationMs": 742.99,
"heapDeltaBytes": -8116488,
"heapUsedBytes": 68331764,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 97.33200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.6660000000147,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.468,
"layouts": 5,
"layoutDurationMs": 12.240999999999998,
"taskDurationMs": 959.6780000000002,
"heapDeltaBytes": 11616252,
"heapUsedBytes": 117377468,
"domNodes": 16030,
"jsHeapTotalBytes": 16388096,
"scriptDurationMs": 30.465999999999994,
"eventListeners": 3246,
"totalBlockingTimeMs": 123,
"frameDurationMs": 18.917567567567573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10163.040999999965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.743,
"layouts": 9,
"layoutDurationMs": 2.105,
"taskDurationMs": 5174.928000000001,
"heapDeltaBytes": -12583832,
"heapUsedBytes": 78998872,
"domNodes": -141,
"jsHeapTotalBytes": 6909952,
"scriptDurationMs": 2324.6290000000004,
"eventListeners": -51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69326765188834,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10515.087999999992,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.663,
"layouts": 8,
"layoutDurationMs": 1.923,
"taskDurationMs": 5289.349999999999,
"heapDeltaBytes": -358332,
"heapUsedBytes": 92329380,
"domNodes": -141,
"jsHeapTotalBytes": 6909952,
"scriptDurationMs": 2421.5579999999995,
"eventListeners": -51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576862123613,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20869.416999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20205.131,
"heapDeltaBytes": -15555756,
"heapUsedBytes": 264768196,
"domNodes": -3245,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 275.39799999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.67100175746924,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 14828.366999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14338.497,
"heapDeltaBytes": -1077220,
"heapUsedBytes": 275571528,
"domNodes": -3245,
"jsHeapTotalBytes": 33292288,
"scriptDurationMs": 211.73,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.629802513464995,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 25394.469000000016,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.327999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25115.605,
"heapDeltaBytes": 6619728,
"heapUsedBytes": 287955172,
"domNodes": -3245,
"jsHeapTotalBytes": 29097984,
"scriptDurationMs": 789.0020000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 48.13225806451614,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 23790.32099999995,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.484,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23530.474000000002,
"heapDeltaBytes": -7087028,
"heapUsedBytes": 279606804,
"domNodes": -3245,
"jsHeapTotalBytes": 30408704,
"scriptDurationMs": 749.097,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.33161904761905,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7092.9740000000265,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.32099999999998,
"layouts": 20,
"layoutDurationMs": 22.128999999999984,
"taskDurationMs": 7019.393000000001,
"heapDeltaBytes": 5162988,
"heapUsedBytes": 290762948,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 107.45900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.54716981132076,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 5271.066000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.375,
"layouts": 20,
"layoutDurationMs": 20.961000000000006,
"taskDurationMs": 5173.960999999999,
"heapDeltaBytes": -8955732,
"heapUsedBytes": 287156080,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 79.992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.70058479532164,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10903.579000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10666.653999999999,
"heapDeltaBytes": -16384728,
"heapUsedBytes": 289723956,
"domNodes": -3245,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 148.38399999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.20719424460431,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10171.610999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9858.769,
"heapDeltaBytes": -17396364,
"heapUsedBytes": 289098360,
"domNodes": -3245,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 133.40600000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.10328467153285,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 115.03999999996495,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.963,
"layouts": 8,
"layoutDurationMs": 3.2560000000000002,
"taskDurationMs": 85.78000000000002,
"heapDeltaBytes": 4900936,
"heapUsedBytes": 78608908,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.027999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 99.16299999997591,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.475,
"layouts": 6,
"layoutDurationMs": 2.1260000000000003,
"taskDurationMs": 69.56599999999999,
"heapDeltaBytes": 4690776,
"heapUsedBytes": 77166400,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.0760000000000005,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 315.9049999999297,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8400000000000001,
"layouts": 76,
"layoutDurationMs": 12.158000000000001,
"taskDurationMs": 268.617,
"heapDeltaBytes": -5014312,
"heapUsedBytes": 36274572,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 121.912,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 303.4949999999981,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.625,
"layouts": 76,
"layoutDurationMs": 11.365,
"taskDurationMs": 257.766,
"heapDeltaBytes": -5667372,
"heapUsedBytes": 36309868,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 116.90100000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 354.492999999934,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.609,
"layouts": 76,
"layoutDurationMs": 12.001,
"taskDurationMs": 318.364,
"heapDeltaBytes": -5473256,
"heapUsedBytes": 80805728,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 121.394,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 363.10100000002876,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.1220000000000003,
"layouts": 76,
"layoutDurationMs": 11.924000000000001,
"taskDurationMs": 326.051,
"heapDeltaBytes": -697504,
"heapUsedBytes": 98269344,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 115.613,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 3076 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8c0219bc32ea5792758756d7d78e13e891e39a89
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (161)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: 🔵 Low · up to
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
Panel: 6/6 reviewers contributed findings.
Covers the 202 receipt that names only free text (now reported when it differs) and the documented free-text-only frame shape (selected [] plus other_text). Derives the source type from toAskResolution instead of repeating its Pick.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21829 +/- ##
==========================================
+ Coverage 86.66% 87.62% +0.95%
==========================================
Files 3910 2751 -1159
Lines 182231 151826 -30405
Branches 49642 41007 -8635
==========================================
- Hits 157936 133041 -24895
+ Misses 21840 18110 -3730
+ Partials 2455 675 -1780
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1160 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…known A source that names free text but no selection array cannot show the user's options lost, so only the free text is compared. Without this, a 409, frame or 202 naming the user's own free text with no selection raised a false superseded notice.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 8338ce5 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
|
@christian-byrne Successfully backported to #21880 |
|
@christian-byrne Successfully backported to #21988 |
|
@christian-byrne Successfully backported to #21989 |
|
@christian-byrne Successfully backported to #21990 |
|
1 similar comment
|
…g#21994) ## ELI5 When a merged change is copied to an extra release branch later, the automation also tried again to copy it to branches that had already received it. Those retries failed and posted "please do it by hand" messages, which could lead people to make duplicate copies. Now branches that already got the change are skipped. ## Summary PR Backport's filter step only skipped a target with an **open** backport PR. Bot backport PRs are squash-merged and their branch is deleted, so once one merged, adding another target label put the finished target back into the pending list. It then conflicted and posted a misleading "Backport to <target> failed" comment (seen on Comfy-Org#21829: core/1.57 was already backported via Comfy-Org#21880). - The filter step now also skips a target when a **merged** PR exists with head `backport-<PR>-to-<safe target>` and base `<target>`. That target is recorded in the `already-exists` output as `<target> (merged PR #N)`, so no backport is attempted and no failure comment is posted. The match ignores PRs from forks (`isCrossRepository`), so a fork reusing the branch name cannot hide a missing backport. - When every requested target is skipped as already merged, the filter emits `all-merged=true` and `needs-backport` is removed, so the label does not keep re-triggering the job. A skip caused by an open backport PR still leaves the label on. - `force_rerun` still bypasses the check, so a forced retry still works. - `REQUESTED_TARGETS` moved from inline `${{ }}` interpolation into the step `env`, so the test can run the step script as-is. The all-skipped warning now reads "All backport targets already handled" because the skip is no longer only about existing branches. - The conflict-comment text and the later `git branch -r --contains` guard are unchanged. ## Verification - New `scripts/cicd/pr-backport-filter.test.ts` runs the real `filter-targets` script from the YAML against stub `gh`/`git` on PATH. The `gh` stub returns only the requested `--json` fields and applies the step's real `--jq` filter. Cases: merged A + new B -> only B pending, A listed as already handled, `all-merged=false`; merged A + open B -> `skip=true`, `all-merged=false`; all merged -> `skip=true`, `all-merged=true`; a merged PR into a different base -> not skipped; a merged fork PR with the same branch name -> not skipped; `force_rerun` -> retried; open PR -> still skipped, `all-merged=false`. - Red/green: against the old step logic, the merged-PR cases fail. Without the `isCrossRepository` filter, the fork case fails. Dropping `isCrossRepository` from the `--json` request fails the fork case, and treating any merged target as complete fails both mixed cases. With this change all 7 pass. `vitest run scripts/cicd/`: 31 files / 385 tests pass. oxfmt, oxlint and `typecheck:scripts` are clean (pre-commit hook). yamllint is not installed locally, so I did not run it; CI will. - Live read-only check of the new query on this repo for Comfy-Org#21829: `gh pr list --state merged --head backport-21829-to-<t> --base <t>` returns `21880` for core/1.57 and nothing for cloud/1.57, core/1.58 and cloud/1.58. That matches the intended skip/attempt split. - Doc-drift sweep: 22 references checked (the workflow-related hits in `docs/release-process.md` and `.claude/skills/backport-management/`, plus the identifiers it printed), 0 updated. No doc describes the open-PR-only skip rule. Most of the sweep's 2532 hits are test-helper names (`beforeEach`, `afterEach`, `workflowSchema`) and were not judged individually. ## Residual - I did not do the manual check the ticket asks for: re-running PR Backport on Comfy-Org#21829 via `workflow_dispatch` without `force_rerun` and confirming core/1.57 is reported as already backported. A dispatch on main runs the workflow from main, so it only proves something after this merges. It can also create backport PRs and post comments on Comfy-Org#21829 for the not-yet-done targets. Do it after merge. Expected result: the `filter-targets` log/output lists `core/1.57 (merged PR Comfy-Org#21880)`. - Not changed, per the ticket's scope: the `git branch -r --contains "${MERGE_COMMIT}"` guard in the backport step never fires for squash-merged bot backports. A manual (non-bot-branch) backport that merged is still not detected and would be retried. Detecting that would need matching on PR title or cherry-pick trailers. - Related but separate: duplicate conflict comments posted on each labeled event. ## Provenance - **Authored by:** agent-work loop - **Verified:** - `pr-backport-filter.test.ts`: 7/7 pass at head; red on the old logic, and red when the cross-repo field/filter is dropped or completion means "any target merged" - oxfmt, oxlint and `typecheck:scripts`: clean (pre-commit hook) - Live read-only query for Comfy-Org#21829 returns a merged PR only for core/1.57 - Not run locally: yamllint, actionlint, an actual workflow run - **Deviations:** - Moved `REQUESTED_TARGETS` into step `env` (not requested) so the test can run the step script unmodified, and reworded one `::warning::` line - Review follow-up: added the fork exclusion and label removal when all targets are already merged. Prefix-named manual backport branches are not matched; the reason is in the review thread. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#21327) ## ELI5 When an answer to one of the agent's questions gets overridden by an answer given somewhere else, we log an error. That error used to include the agent's own option text, which could contain parts of the user's prompt and split identical errors into thousands of separate buckets. Now it logs a fixed message plus how many options each answer picked, whether the picked options, the typed text, or both changed, and whether the server said which options won at all. ## Summary `agent_ask_answer_superseded` built its `Error` message from the raw option ids of both answers. `ask_user` option ids are free-form text the agent writes, so the message could carry prompt-derived content, and each distinct id pair grouped as its own error. The message is now the fixed string `agent ask resolved with a different answer`, and the detail moves into bounded tags: `committed_selected_count` / `submitted_selected_count`, plus `selection_changed` / `other_text_changed` booleans from the same comparison that decides supersession, so a same-length selection change and a free-text-only change stay distinguishable. `selection_known` says whether the committed body carried a `selected` array; when it did not, `committed_selected_count` is omitted so "the server did not say" is not read as "the winner picked nothing". The user-facing "answered somewhere else" notice and the supersede detection are unchanged. Risk: telemetry only. A dashboard or alert that matches on the old `agent ask resolved as …` text needs the new message; grouping by `errorType` is unaffected. ## Verification - Rebased onto main after #21829 (free-text-only committed answers). Its "selection known" guard is kept: when the committed body carries no `selected` array, `selection_changed` is `false`, `selection_known` is `false` and `committed_selected_count` is omitted, and only `other_text_changed` can fire, so the report still matches main's supersede rule. - `useAgentSession.test.ts`: 275 pass (1 expected fail). `reports the answer the 202 committed when another one won` asserts the exact fixed message and all four tags; the run-approval superseded test asserts the tags; the table of superseding answers and the 409 free-text-only test (null and missing `selected`) asserts the full tag set, including `selection_known: false` and no committed count. - `pnpm typecheck`, oxfmt, oxlint, eslint: clean. - Doc-drift sweep: no doc, fixture or spec quotes the old message, the `agent_ask_answer_superseded` slug or the new tag names. The other matches were generic `agent`/`reportError` mentions. ## Provenance - **Authored by:** agent-work loop - **Verified:** - Rebased onto current main; the merge with main's free-text-only guard keeps both behaviours - `useAgentSession.test.ts` 275 pass at head, including the exact-message, change-tag and `selection_known` assertions - The updated superseded tests failed against the old message code - `pnpm typecheck`, oxfmt, oxlint and eslint are clean at head - Doc-drift sweep: nothing outside the changed code mentions the message, slug or tag names - **Deviations:** - The ticket gives "ask kind" as an example field. I left it out because the report site only has the ask id and the resolution, not the card type, so adding it would mean a new store lookup just for telemetry. I added the selected-id counts and the two change booleans (the booleans came from review). ## Residual - The ask kind (run approval vs `ask_user`) is not on the report. Adding it would need a lookup of the card type by ask id at the report site. - I could not see any dashboards or alerts that match on the old message text. Whoever owns agent error monitoring should check them.
…22241) ## Summary The backport bot skips a release branch once its own backport PR merged (Comfy-Org#21994). A backport someone made by hand, from a branch the bot did not create, was not seen, so the bot retried that branch. This counts a merged PR to the target as done when: - its title starts with `[backport <target>]` or `[<target>]`, and - it is not a revert and not the bot's backport of another PR (`backport-<M>-to-*`), and - it says it carries the source PR: the title ends with `(#N)`, the head branch has `N` next to `backport` (`backport-N...`, `.../N-backport...`), or a body line starts with `Backport of #N` / `Backport of https://github.com/Comfy-Org/ComfyUI_frontend/pull/N`, and - it is not from a fork. A body or title that only mentions the PR ("Not included: #N", "follow-up to the backport of #N", a PR in another repo) does not count, and neither does a ticket number in a branch name (`be-22010-...` is not FE PR 22010). A false match would skip a needed backport and drop `needs-backport`, so the rule leans toward missing a hand-made backport (old behaviour: retry) over a false skip. Candidates come from listing up to 300 merged PRs on the target (core/1.58 has 64 today), not the search API, so a PR named only in its branch is found and there is no index lag. The target name is compared case-insensitively. The run log shows it as `core/1.58 (merged PR Comfy-Org#21580, made by hand)`. `force_rerun` still retries everything. Fixes FRONT-3651 ## Testing - `scripts/cicd/pr-backport-filter.test.ts`: the match cases were red before the workflow change, and the three mention-only cases were red against the first, broader rule. 28/28 green now; each tightening was red against the commit before it. - Ran the query against real merged PRs. Correct matches: Comfy-Org#21579 to Comfy-Org#21580 and Comfy-Org#21694 to Comfy-Org#21799 (both made by hand, core/1.58), Comfy-Org#21708 to Comfy-Org#21798, Comfy-Org#21285 to Comfy-Org#22223, Comfy-Org#21686 to Comfy-Org#21782. Correctly no match: Comfy-Org#21841 on core/1.57 (Comfy-Org#22051 says "Not included: Comfy-Org#21841") and Comfy-Org#21532 on core/1.58 (Comfy-Org#22232 says it is not on that line), and Comfy-Org#22010 on core/1.58 (Comfy-Org#21580's branch `be-22010-...` is a ticket key). - The existing skip of bot backports was re-checked live: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40871266552 skipped all four targets of Comfy-Org#21829. ## Known limit A hand-made backport whose title has no target prefix, or that does not name the source PR, is still not detected. The bot then retries it as before, and the cherry-pick either conflicts or finds the commit already present.
…#22488) Running the PR Backport workflow by hand on a PR the bot already finished fails at "Validate inputs", because the bot removes `needs-backport` once every target has landed. So the simple re-check, "run it and see every target reported as handled", was impossible without re-adding the label first. This drops that one check from the manual path. The other guards stay: the PR must be merged, and "Collect backport targets" still fails a PR with no release label. The docs now describe the re-check. One behaviour to know: a run by hand on a merged PR that has a release label but never had `needs-backport` will now cherry-pick to that target. A run by hand is an explicit request, so that matches intent, and the docs say so. Seen on Comfy-Org#21829: run https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40871194371 failed; re-adding the label ran https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40871266552 , which skipped all four targets. Test: `scripts/cicd/pr-backport-dispatch.test.ts` runs the real step with a stubbed `gh`. The finished-PR case fails before the fix. Fixes https://linear.app/comfyorg/issue/FRONT-3706 --------- Co-authored-by: GitHub Action <action@github.com>
Summary
Follow-up to #21320. That PR stopped a 409 with no selection from raising a false "answered somewhere else" notice, but its guard only looked at
selected. The ask conflict schema also allows a committed free-text-only answer (status: answered,selectednull or omitted,other_textset). In that case the 409 does name the winning answer, and the user got no superseded notice and no telemetry.Change
namesCommittedAnswer: a body names the committed answer when it carries aselectedarray or non-emptyother_text.reportSupersededAnswer, so all three sources share it: the 202 receipt, the 409 conflict and theagent_ask_resolvedframe. The frame path had no guard before, so an answered frame with a null selection also raised a false superseded report.//comment fix(agent): don't report a 409 with no selection as another answer winning #21320 added (AGENTS.md); the predicate name carries the reason.selected: []still counts as naming an answer, matching the existingreports an empty committed answer that replaced this onetest and the schema ("empty when the answer was free text only").Tests (written first)
reports a 409 whose free text alone shows another answer won(null and omittedselected): failed before, pass now.does not report an answered frame with a null selection as another answer winning: failed before, passes now.reports / does not report a 202 that names only free textand... a free-text-only frame(second commit, from review). Against main's source the 202 "reports" case fails; the others pin behavior that already held.useAgentSession.test.ts: 261 pass. Agent suite: 4194 pass; the only failure is the known order-dependent(g18)test (FE-3485), which also fails on main.Review
A fresh Claude reviewer (adversarial-review, Skeptic + Minimalist; no cross-model CLI available on this host) found no blockers or majors. Its test-gap and duplicated-type notes are in the second commit. Not changed here: the superseded telemetry message (being rewritten in #21327), and an answered frame with
selected: nullstill renders as an empty answer (out of contract per the schema; unchanged).Review threads on #21320
This addresses the Medium, the frame-path Low and the Nit. Replies on #21320 explain the other two Lows.
Overlap
#21327 edits the body of
reportSupersededAnswerbelow the new guard. Whichever lands second needs a small rebase; no behavior conflict.