Repository navigation
[backport core/1.57] fix(agent): don't report a 409 with no selection as another answer winning - #21869
Conversation
…nning (#21320) ## Summary A 409 from the ask answer endpoint can come back with `selected` missing or `null` (`AgentAskConflict.selected` is nullish). `toAskResolution` turns that into an answered resolution with `selected: []`, and the 409 branch always ran the superseded check. So a user who picked an option got a false "answered somewhere else" notice and an `agent_ask_answer_superseded` error report, even though nothing said another answer won. Fix: only run the superseded comparison when the conflict body actually carries a selection array. This is the same guard the 202 path already has (`receipt.selected !== undefined`). The card is still retired with the conflict's status, as before. Found by the cursor-review panel on the 1.57 backports of #19981/#20092 (#21308, #21309). The code there is identical to main, so this fix goes to main first and is backported after those land. ## Tests - New: `does not report a 409 with no selection as another answer winning` and `... with a null selection ...` in `useAgentSession.test.ts`. Both fail on main before the fix (`reportError` called with `agent_ask_answer_superseded`) and pass after. - Existing `shows the answer a 409 reports as already committed` (409 that names another selection) still reports superseded. - `useAgentSession.test.ts`: 253 pass. The one failure is the known order-dependent `(g18)` test, which fails on main without this change (https://linear.app/comfyorg/issue/FE-3485).
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-24T02:29:13.853Z",
"gitSha": "1cb21f8437c62ae0b858037fb2733a006451201d",
"branch": "backport-21320-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.6420000000041,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0660000000000003,
"layouts": 10,
"layoutDurationMs": 2.641,
"taskDurationMs": 346.509,
"heapDeltaBytes": 22111140,
"heapUsedBytes": 87918012,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.099,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.8279999999704,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.366,
"layouts": 10,
"layoutDurationMs": 2.058,
"taskDurationMs": 276.445,
"heapDeltaBytes": 22110424,
"heapUsedBytes": 88402772,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 5.633000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.8789999999901,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.177999999999999,
"layouts": 10,
"layoutDurationMs": 2.675,
"taskDurationMs": 576.3729999999999,
"heapDeltaBytes": -3389092,
"heapUsedBytes": 71649196,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 107.808,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.0370000000175,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.035000000000002,
"layouts": 10,
"layoutDurationMs": 2.691,
"taskDurationMs": 460.03700000000003,
"heapDeltaBytes": 15628604,
"heapUsedBytes": 81873376,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 101.68599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.4720000000289,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.985999999999999,
"layouts": 11,
"layoutDurationMs": 3.2600000000000002,
"taskDurationMs": 247.92,
"heapDeltaBytes": 18748984,
"heapUsedBytes": 84967020,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 10.877,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.3649999999911,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.68,
"layouts": 12,
"layoutDurationMs": 2.499,
"taskDurationMs": 225.499,
"heapDeltaBytes": 18681196,
"heapUsedBytes": 84580732,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.574000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 516.4190000000133,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8120000000000003,
"layouts": 9,
"layoutDurationMs": 2.4270000000000005,
"taskDurationMs": 327.73600000000005,
"heapDeltaBytes": -1000124,
"heapUsedBytes": 65175680,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 110.193,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 527.5729999999612,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.5869999999999997,
"layouts": 10,
"layoutDurationMs": 2.452,
"taskDurationMs": 353.911,
"heapDeltaBytes": 6634100,
"heapUsedBytes": 81710392,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 108.57499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 951.5109999999822,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.971,
"heapDeltaBytes": -2483268,
"heapUsedBytes": 81652856,
"domNodes": -192,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 39.471000000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 296,
"frameDurationMs": 26.38888888888889,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 956.1659999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.6569999999999,
"heapDeltaBytes": 1685864,
"heapUsedBytes": 81465392,
"domNodes": -192,
"jsHeapTotalBytes": 14688256,
"scriptDurationMs": 42.401999999999994,
"eventListeners": -106,
"totalBlockingTimeMs": 311,
"frameDurationMs": 26.852777777777774,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 699.9230000000125,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.7080000000002,
"heapDeltaBytes": -4761848,
"heapUsedBytes": 76492520,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 90.34400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.5860000000202,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 244.8960000000002,
"heapDeltaBytes": -4362632,
"heapUsedBytes": 76831056,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 87.61899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6777.107000000001,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8789999999999996,
"layouts": 3,
"layoutDurationMs": 0.758,
"taskDurationMs": 5609.106000000001,
"heapDeltaBytes": -4705520,
"heapUsedBytes": 94835452,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 4308.845,
"eventListeners": -68,
"totalBlockingTimeMs": 36,
"frameDurationMs": 20.369369369369366,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6062.010000000044,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8660000000000004,
"layouts": 3,
"layoutDurationMs": 0.7170000000000002,
"taskDurationMs": 4901.228000000001,
"heapDeltaBytes": -23998204,
"heapUsedBytes": 75904892,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 3768.9939999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.78173374613003,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6420.687999999984,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1920000000000004,
"layouts": 4,
"layoutDurationMs": 1.0170000000000001,
"taskDurationMs": 5217.433,
"heapDeltaBytes": -9184728,
"heapUsedBytes": 90178096,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 4016.5069999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.62201834862385,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6031.090000000006,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8830000000000001,
"layouts": 3,
"layoutDurationMs": 0.7460000000000001,
"taskDurationMs": 5062.582,
"heapDeltaBytes": -1383956,
"heapUsedBytes": 98324436,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 3899.2909999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 13,
"frameDurationMs": 18.912852664576803,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 217.69400000002292,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.236,
"layouts": 12,
"layoutDurationMs": 3.892,
"taskDurationMs": 156.04100000000003,
"heapDeltaBytes": -8144124,
"heapUsedBytes": 79615668,
"domNodes": 917,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.520999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.700000000000024,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-combo-open",
"durationMs": 146.97100000000773,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.364,
"layouts": 13,
"layoutDurationMs": 3.0889999999999995,
"taskDurationMs": 111.794,
"heapDeltaBytes": -8221416,
"heapUsedBytes": 79106944,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.116999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2026.5950000000146,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.771,
"layouts": 10,
"layoutDurationMs": 2.486,
"taskDurationMs": 424.189,
"heapDeltaBytes": -8717584,
"heapUsedBytes": 88897316,
"domNodes": -258,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 29.73,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.7449999999722,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.541,
"layouts": 8,
"layoutDurationMs": 1.538,
"taskDurationMs": 366.4479999999999,
"heapDeltaBytes": -1350812,
"heapUsedBytes": 77887516,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 20.301,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2287.8280000000186,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.882,
"layouts": 8,
"layoutDurationMs": 2.0860000000000003,
"taskDurationMs": 1170.8220000000001,
"heapDeltaBytes": 10854720,
"heapUsedBytes": 90772236,
"domNodes": -278,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 563.5169999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666423357664236,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2232.4720000000298,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.477,
"layouts": 9,
"layoutDurationMs": 1.9950000000000003,
"taskDurationMs": 1103.597,
"heapDeltaBytes": -10615384,
"heapUsedBytes": 69757020,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 540.9079999999999,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66641791044776,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3437.636999999995,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.126000000000001,
"layouts": 66,
"layoutDurationMs": 12.202,
"taskDurationMs": 1284.828,
"heapDeltaBytes": 10501892,
"heapUsedBytes": 90022700,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 554.661,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3139.1669999999863,
"styleRecalcs": 74,
"styleRecalcDurationMs": 8.310000000000002,
"layouts": 67,
"layoutDurationMs": 11.142,
"taskDurationMs": 1148.434,
"heapDeltaBytes": -8109432,
"heapUsedBytes": 70824788,
"domNodes": -234,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 503.81999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2390.2100000000246,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.032,
"layouts": 7,
"layoutDurationMs": 1.798,
"taskDurationMs": 1355.3000000000002,
"heapDeltaBytes": 3496724,
"heapUsedBytes": 87407860,
"domNodes": 0,
"jsHeapTotalBytes": 5992448,
"scriptDurationMs": 680.0070000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665277777777774,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2216.2460000000124,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.5409999999999995,
"layouts": 7,
"layoutDurationMs": 1.532,
"taskDurationMs": 1210.134,
"heapDeltaBytes": 2042324,
"heapUsedBytes": 79759604,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 634.1419999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2037.1539999999868,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7099999999999995,
"layouts": 10,
"layoutDurationMs": 2.451,
"taskDurationMs": 400.472,
"heapDeltaBytes": -1856636,
"heapUsedBytes": 79680880,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 25.513,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.1050000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5330000000000006,
"layouts": 8,
"layoutDurationMs": 1.326,
"taskDurationMs": 348.758,
"heapDeltaBytes": -1448156,
"heapUsedBytes": 79789152,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 19.841,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 464.730999999972,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.566000000000001,
"layouts": 10,
"layoutDurationMs": 2.6060000000000003,
"taskDurationMs": 304.22800000000007,
"heapDeltaBytes": 3199580,
"heapUsedBytes": 79915632,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 100.069,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 513.6469999999917,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.823,
"layouts": 10,
"layoutDurationMs": 2.6310000000000007,
"taskDurationMs": 322.979,
"heapDeltaBytes": -1111004,
"heapUsedBytes": 75894852,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 104.42,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.6750000000109,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.3569999999999998,
"layouts": 11,
"layoutDurationMs": 2.992,
"taskDurationMs": 347.82800000000003,
"heapDeltaBytes": -598976,
"heapUsedBytes": 76413420,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.825,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.4799999999964,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0039999999999996,
"layouts": 10,
"layoutDurationMs": 1.829,
"taskDurationMs": 286.97499999999997,
"heapDeltaBytes": 3911276,
"heapUsedBytes": 80802704,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 4.852,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.9789999999934,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.150999999999998,
"layouts": 9,
"layoutDurationMs": 2.139,
"taskDurationMs": 569.1379999999999,
"heapDeltaBytes": 11637728,
"heapUsedBytes": 78522680,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 89.09900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.4070000000165,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.515000000000002,
"layouts": 10,
"layoutDurationMs": 2.0879999999999996,
"taskDurationMs": 488.84499999999997,
"heapDeltaBytes": -11337456,
"heapUsedBytes": 65608780,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 73.684,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.9780000000133,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.948999999999998,
"layouts": 5,
"layoutDurationMs": 17.349999999999998,
"taskDurationMs": 684.2709999999998,
"heapDeltaBytes": 7748388,
"heapUsedBytes": 103209712,
"domNodes": 15953,
"jsHeapTotalBytes": 16912384,
"scriptDurationMs": 24.389,
"eventListeners": 3244,
"totalBlockingTimeMs": 95,
"frameDurationMs": 20.075000000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8305.142999999987,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.971999999999998,
"layouts": 9,
"layoutDurationMs": 2.1980000000000004,
"taskDurationMs": 3953.663,
"heapDeltaBytes": 3775956,
"heapUsedBytes": 83453796,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 1858.8179999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66613226452906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8436.397999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.023000000000003,
"layouts": 9,
"layoutDurationMs": 2.2459999999999996,
"taskDurationMs": 3917.754,
"heapDeltaBytes": -9229624,
"heapUsedBytes": 87457728,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 1856.8360000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587771203156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16631.014999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15487.383000000002,
"heapDeltaBytes": -11856632,
"heapUsedBytes": 264499000,
"domNodes": -3330,
"jsHeapTotalBytes": 14934016,
"scriptDurationMs": 221.049,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.36354344122658,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 16299.200999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15269.554,
"heapDeltaBytes": -16382976,
"heapUsedBytes": 260535680,
"domNodes": -3330,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 226.06600000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.607445008460235,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 18199.502999999993,
"styleRecalcs": 153,
"styleRecalcDurationMs": 14.452999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17769.752,
"heapDeltaBytes": 16315504,
"heapUsedBytes": 288679572,
"domNodes": -3330,
"jsHeapTotalBytes": 10670080,
"scriptDurationMs": 632.937,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.702222222222225,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18357.267000000036,
"styleRecalcs": 157,
"styleRecalcDurationMs": 13.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17961.59,
"heapDeltaBytes": -209412,
"heapUsedBytes": 276275856,
"domNodes": -3330,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 600.1979999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.331941923774956,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5789.392999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.10500000000002,
"layouts": 20,
"layoutDurationMs": 26.776999999999994,
"taskDurationMs": 5623.894,
"heapDeltaBytes": -35649248,
"heapUsedBytes": 260198716,
"domNodes": -3330,
"jsHeapTotalBytes": 24895488,
"scriptDurationMs": 82.40599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.30837988826816,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5832.57100000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.04299999999997,
"layouts": 20,
"layoutDurationMs": 20.996000000000016,
"taskDurationMs": 5657.263000000001,
"heapDeltaBytes": -15935656,
"heapUsedBytes": 285716080,
"domNodes": -307,
"jsHeapTotalBytes": 34070528,
"scriptDurationMs": 85.97100000000002,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.819298245614036,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8224.406999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7701.721,
"heapDeltaBytes": 4599920,
"heapUsedBytes": 287506672,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.75699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.908474576271185,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7873.868000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7473.794,
"heapDeltaBytes": 8681448,
"heapUsedBytes": 271514444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.66799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.27647058823529,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 105.06399999997029,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.559000000000001,
"layouts": 7,
"layoutDurationMs": 2.095,
"taskDurationMs": 75.116,
"heapDeltaBytes": -15264148,
"heapUsedBytes": 68200832,
"domNodes": 97,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.305999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.39799999993647,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.403000000000002,
"layouts": 6,
"layoutDurationMs": 2.0540000000000003,
"taskDurationMs": 58.943999999999996,
"heapDeltaBytes": 4497220,
"heapUsedBytes": 77049540,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.879,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 206.90700000000106,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8899999999999999,
"layouts": 76,
"layoutDurationMs": 10.944,
"taskDurationMs": 174.759,
"heapDeltaBytes": 8990104,
"heapUsedBytes": 100029168,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 76.11800000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66153846153849,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 211.12200000004577,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.09,
"layouts": 76,
"layoutDurationMs": 10.588999999999999,
"taskDurationMs": 168.013,
"heapDeltaBytes": 8904208,
"heapUsedBytes": 84355412,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 72.844,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 256.93699999999353,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.663,
"layouts": 76,
"layoutDurationMs": 10.095,
"taskDurationMs": 220.331,
"heapDeltaBytes": -1720524,
"heapUsedBytes": 124716820,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 72.263,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 228.79499999999098,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.35,
"layouts": 76,
"layoutDurationMs": 9.482000000000001,
"taskDurationMs": 196.367,
"heapDeltaBytes": -7445232,
"heapUsedBytes": 107427536,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 66.356,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 245684972323768fd1350c2a02b19e3ee6186623
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21869 +/- ##
=============================================
- Coverage 84.12% 84.11% -0.01%
=============================================
Files 2840 2840
Lines 158059 158060 +1
Branches 40597 38432 -2165
=============================================
- Hits 132962 132959 -3
- Misses 24708 24712 +4
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Clean cherry-pick of #21320 (diff identical to the main commit). Required checks green at this head.
…, tested revision) (#21877) ## Summary `upload-e2e-coverage / package` fails on every PR to `cloud/1.57`: lcov 2.4 aborts the shard merge with `(inconsistent) duplicate function 'inner_clicked'` (LiteGraph has several same-named closures in one file). `main` (in #17623) and `core/1.57` already pass `--ignore-errors inconsistent,corrupt` to that merge. This brings the same two lines to `cloud/1.57`. Function coverage is not published; line data is kept. ## Changes - `scripts/cicd/package-e2e-coverage.sh`: the file now matches `core/1.57` byte for byte. ## Evidence Failing on the `cloud/1.57` backport of #21320: `lcov: ERROR: (corrupt) unable to read trace file ... duplicate function 'inner_clicked' starts on line "src/lib/litegraph/src/LGraphCanvas.ts":1431`. The same backport to `core/1.57` (#21869) passed this job. CI-only. No app code changes. Related: #21840 (the same fix for `main`, now redundant there).
… tested revision) (#21878) ## Summary `upload-e2e-coverage / package` fails on every PR to `core/1.58`: lcov 2.4 aborts the shard merge with `(inconsistent) duplicate function 'inner_clicked'` (LiteGraph has several same-named closures in one file). `main` (in #17623) and `core/1.57` already pass `--ignore-errors inconsistent,corrupt` to that merge. This brings the same two lines to `core/1.58`. Function coverage is not published; line data is kept. ## Changes - `scripts/cicd/package-e2e-coverage.sh`: the file now matches `core/1.57` byte for byte. ## Evidence Failing on the `core/1.58` backport of #21320: `lcov: ERROR: (corrupt) unable to read trace file ... duplicate function 'inner_clicked' starts on line "src/lib/litegraph/src/LGraphCanvas.ts":1431`. The same backport to `core/1.57` (#21869) passed this job. CI-only. No app code changes. Related: #21840 (the same fix for `main`, now redundant there).
…, tested revision) (#21879) ## Summary `upload-e2e-coverage / package` fails on every PR to `cloud/1.58`: lcov 2.4 aborts the shard merge with `(inconsistent) duplicate function 'inner_clicked'` (LiteGraph has several same-named closures in one file). `main` (in #17623) and `core/1.57` already pass `--ignore-errors inconsistent,corrupt` to that merge. This brings the same two lines to `cloud/1.58`. Function coverage is not published; line data is kept. ## Changes - `scripts/cicd/package-e2e-coverage.sh`: the file now matches `core/1.57` byte for byte. ## Evidence Failing on the `cloud/1.58` backport of #21320: `lcov: ERROR: (corrupt) unable to read trace file ... duplicate function 'inner_clicked' starts on line "src/lib/litegraph/src/LGraphCanvas.ts":1431`. The same backport to `core/1.57` (#21869) passed this job. CI-only. No app code changes. Related: #21840 (the same fix for `main`, now redundant there).
Backport of #21320 to
core/1.57Automatically created by backport workflow.