Repository navigation
fix(agent): say when the open chat's target workflow is deleted - #19240
Conversation
Keep the history row loading in place until its chat and target workflow are ready, then update Current and reveal the conversation. Opening failures now stay in history for retry, which updates the existing failure assertions. Preserve interrupted history navigation across panel remounts, commit saved session identity only after readiness, and prevent Back from resurrecting a deleted conversation. Wait for completed callbacks and rendering in stale result regressions. Workflow-close behavior remains outside this change.
A chat whose recorded workflow is absent from a successful Cloud listing now opens without a target and says so in the composer tip. Other restoration failures keep the history row as their only feedback; restorations without a loading row toast that the workflow could not be opened.
…n-chat-workflow # Conflicts: # src/workbench/extensions/agent/stores/agent/agentPanelStore.ts
…n-chat-workflow Reconcile AgentPanel.test.ts with #16376: drop the duplicate nextTick import, build history groups with createHistoryGroups(), and route the history-selection assertion through the selectHistory callback this branch uses instead of the selectHistory event.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe agent panel tracks open and detached workflow targets, follows saved-path changes, and marks deleted targets unavailable. Unit and browser tests cover target selection and the unavailable notice. ChangesAgent workflow target lifecycle
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change tracks saved workflow targets through closure and deletion, and the supplied unit, history, and browser-test summaries cover the unavailable notice. No actionable merge-blocking risk is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 2161 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 49b09747e7471d3fe9fdbfeaefdc00cf851b1c68
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 10.1 MB gzip 🔴 +209 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 150 kB (baseline 150 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 9 unchanged Data & Services — 4.1 MB (baseline 4.1 MB) • 🔴 +1.14 kBStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18 MB (baseline 18 MB) • ⚪ 0 BBundles that do not match a named category
Status: 76 added / 76 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T18:58:04.231Z",
"gitSha": "58e6067dddbcde99d6859ebdbf4e991adabcc0db",
"branch": "ryan-di/pm-1640-deleted-target-notice",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.4120000000312,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.101999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.168,
"heapDeltaBytes": -37473476,
"heapUsedBytes": 61010296,
"domNodes": -228,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.379000000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.2230000000345,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.002999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.89000000000004,
"heapDeltaBytes": -1773816,
"heapUsedBytes": 77116092,
"domNodes": -228,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.116,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1866.388000000029,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.096,
"layouts": 12,
"layoutDurationMs": 4.559,
"taskDurationMs": 827.768,
"heapDeltaBytes": -2842588,
"heapUsedBytes": 76740076,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 151.21200000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665178571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1827.8740000000653,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.240000000000002,
"layouts": 12,
"layoutDurationMs": 3.975,
"taskDurationMs": 824.316,
"heapDeltaBytes": -610248,
"heapUsedBytes": 78377884,
"domNodes": -228,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 144.94099999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.975,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.3509999999706,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.153000000000002,
"layouts": 6,
"layoutDurationMs": 1.3110000000000002,
"taskDurationMs": 362.656,
"heapDeltaBytes": 2116288,
"heapUsedBytes": 81208848,
"domNodes": 53,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.706999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.9229999999807,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.301999999999998,
"layouts": 6,
"layoutDurationMs": 1.252,
"taskDurationMs": 354.116,
"heapDeltaBytes": 2174660,
"heapUsedBytes": 80879508,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.87,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 701.453000000015,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.281999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.63100000000003,
"heapDeltaBytes": 18723108,
"heapUsedBytes": 97543456,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 165.087,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 687.012999999979,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.3749999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.249,
"heapDeltaBytes": 18414700,
"heapUsedBytes": 97493792,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 158.95,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.3859999999872,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.6790000000001,
"heapDeltaBytes": 10020012,
"heapUsedBytes": 85691416,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 56.757000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 34.34242424242425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1140.3669999999693,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.404,
"heapDeltaBytes": 9581952,
"heapUsedBytes": 86811216,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 60.99800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 523,
"frameDurationMs": 34.339393939393936,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.6050000000109,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.36499999999967,
"heapDeltaBytes": 17179012,
"heapUsedBytes": 91424784,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 145.465,
"eventListeners": 0,
"totalBlockingTimeMs": 189,
"frameDurationMs": 23.611111111111086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 831.3110000000279,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.5790000000004,
"heapDeltaBytes": 13606240,
"heapUsedBytes": 92104552,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 144.72600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 191,
"frameDurationMs": 23.808571428571433,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9959.25299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8958.297,
"heapDeltaBytes": 11110496,
"heapUsedBytes": 91643868,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 7173.695,
"eventListeners": 0,
"totalBlockingTimeMs": 583,
"frameDurationMs": 32.0958064516129,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9235.027000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8424.96,
"heapDeltaBytes": 3067956,
"heapUsedBytes": 84422344,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 6698.5109999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 442,
"frameDurationMs": 31.72852233676976,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8872.862999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8065.522,
"heapDeltaBytes": -13718984,
"heapUsedBytes": 67185876,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 6343.617,
"eventListeners": 0,
"totalBlockingTimeMs": 242,
"frameDurationMs": 30.621453287197234,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8934.640000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8118.233,
"heapDeltaBytes": 1705560,
"heapUsedBytes": 82687028,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 6395.405999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 168,
"frameDurationMs": 30.85259515570935,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-graph-idle",
"durationMs": 2076.5350000000353,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.379,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.7499999999999,
"heapDeltaBytes": -37074060,
"heapUsedBytes": 82924476,
"domNodes": -228,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 31.908000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2063.2589999999027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8539999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.3570000000001,
"heapDeltaBytes": -36189508,
"heapUsedBytes": 83118056,
"domNodes": -228,
"jsHeapTotalBytes": 950272,
"scriptDurationMs": 32.70900000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2972.2060000000283,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1743.33,
"heapDeltaBytes": 2577892,
"heapUsedBytes": 64961284,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 876.7040000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666292134831462,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2621.3849999999184,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1643.0559999999998,
"heapDeltaBytes": -56245836,
"heapUsedBytes": 64028816,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 799.8009999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771974522292993,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3890.7780000000116,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.763000000000002,
"layouts": 60,
"layoutDurationMs": 14.635000000000002,
"taskDurationMs": 1739.246,
"heapDeltaBytes": 11901736,
"heapUsedBytes": 77597240,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 777.551,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666239316239313,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3775.555000000054,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.600999999999999,
"layouts": 60,
"layoutDurationMs": 13.807,
"taskDurationMs": 1664.3719999999998,
"heapDeltaBytes": 8539180,
"heapUsedBytes": 72936480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 757.3190000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665638766519827,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3136.5829999999733,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.896999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1952.359,
"heapDeltaBytes": 27531848,
"heapUsedBytes": 92291928,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 948.4680000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75537634408602,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3118.2830000000195,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.0870000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1921.226,
"heapDeltaBytes": -1053228,
"heapUsedBytes": 66476960,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 933.872,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675676,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.8589999999836,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.568000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.606,
"heapDeltaBytes": -37689080,
"heapUsedBytes": 83985028,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 33.520999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.0229999999056,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.4990000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.4509999999999,
"heapDeltaBytes": -37811472,
"heapUsedBytes": 84367744,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 38.415000000000006,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 650.2989999999613,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.994999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.996,
"heapDeltaBytes": 12356488,
"heapUsedBytes": 93979376,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 144.49399999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923078,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.0579999999627,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.48699999999997,
"heapDeltaBytes": 12814848,
"heapUsedBytes": 94230764,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 143.16700000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2024.2590000000291,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.92600000000004,
"heapDeltaBytes": -27714136,
"heapUsedBytes": 53507388,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 9.004000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2055.7400000000143,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7090000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.94999999999993,
"heapDeltaBytes": -13382168,
"heapUsedBytes": 67656364,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.775,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1750.552999999968,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.291,
"layouts": 16,
"layoutDurationMs": 6.2700000000000005,
"taskDurationMs": 835.1510000000001,
"heapDeltaBytes": -6158252,
"heapUsedBytes": 75301704,
"domNodes": -244,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 105.77499999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.6050000000405,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.338,
"layouts": 16,
"layoutDurationMs": 6.2250000000000005,
"taskDurationMs": 809.46,
"heapDeltaBytes": -17279540,
"heapUsedBytes": 62776380,
"domNodes": -215,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 103.658,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.826923076923077,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1352.341000000024,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.183999999999997,
"layouts": 5,
"layoutDurationMs": 10.745000000000001,
"taskDurationMs": 877.58,
"heapDeltaBytes": 23238708,
"heapUsedBytes": 105016476,
"domNodes": 13667,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.039,
"eventListeners": 2383,
"totalBlockingTimeMs": 124,
"frameDurationMs": 18.98055555555556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8910.78600000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.608,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5825.294,
"heapDeltaBytes": -31287740,
"heapUsedBytes": 88236600,
"domNodes": -228,
"jsHeapTotalBytes": 618496,
"scriptDurationMs": 2709.842,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610486891386,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9177.482000000055,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.339,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5990.543,
"heapDeltaBytes": -29779304,
"heapUsedBytes": 90158044,
"domNodes": -228,
"jsHeapTotalBytes": -692224,
"scriptDurationMs": 2807.991,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14986.912000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14799.62,
"heapDeltaBytes": -28331452,
"heapUsedBytes": 169845848,
"domNodes": -3045,
"jsHeapTotalBytes": 10690560,
"scriptDurationMs": 261.664,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.538666666666664,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 15228.570999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15079.516000000001,
"heapDeltaBytes": -82578896,
"heapUsedBytes": 170149324,
"domNodes": -8049,
"jsHeapTotalBytes": -23339008,
"scriptDurationMs": 231.42999999999998,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.723425196850393,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 18217.94,
"styleRecalcs": 123,
"styleRecalcDurationMs": 15.788999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18096.591999999997,
"heapDeltaBytes": -11814992,
"heapUsedBytes": 190341692,
"domNodes": -3042,
"jsHeapTotalBytes": 13037568,
"scriptDurationMs": 861.718,
"eventListeners": -14905,
"totalBlockingTimeMs": 34,
"frameDurationMs": 35.96173570019724,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 18119.27700000001,
"styleRecalcs": 127,
"styleRecalcDurationMs": 15.900999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18039.103,
"heapDeltaBytes": -22983052,
"heapUsedBytes": 178880132,
"domNodes": -3046,
"jsHeapTotalBytes": 6995968,
"scriptDurationMs": 941.2,
"eventListeners": -14915,
"totalBlockingTimeMs": 67,
"frameDurationMs": 35.83517786561264,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5757.589999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.55999999999999,
"layouts": 20,
"layoutDurationMs": 25.201,
"taskDurationMs": 5719.649,
"heapDeltaBytes": -67222992,
"heapUsedBytes": 169540932,
"domNodes": -8049,
"jsHeapTotalBytes": 8978432,
"scriptDurationMs": 100.731,
"eventListeners": -14923,
"totalBlockingTimeMs": 390,
"frameDurationMs": 34.73795180722892,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5502.806000000078,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.61599999999999,
"layouts": 20,
"layoutDurationMs": 24.832999999999995,
"taskDurationMs": 5475.921,
"heapDeltaBytes": 21055624,
"heapUsedBytes": 221859052,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 101.731,
"eventListeners": 0,
"totalBlockingTimeMs": 311,
"frameDurationMs": 35.03057324840765,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7845.7180000000335,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7722.187999999999,
"heapDeltaBytes": -7987756,
"heapUsedBytes": 163383676,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 118.54599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.36046511627907,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7662.554999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7562.87,
"heapDeltaBytes": 1711444,
"heapUsedBytes": 196063372,
"domNodes": -3045,
"jsHeapTotalBytes": 7245824,
"scriptDurationMs": 126.21100000000007,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.185294117647064,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 140.2439999999956,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.325,
"layouts": 3,
"layoutDurationMs": 1.0719999999999998,
"taskDurationMs": 111.515,
"heapDeltaBytes": -16551604,
"heapUsedBytes": 80259428,
"domNodes": 98,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.685000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 480.5229999999483,
"styleRecalcs": 21,
"styleRecalcDurationMs": 17.680999999999997,
"layouts": 3,
"layoutDurationMs": 1.488,
"taskDurationMs": 135.45000000000002,
"heapDeltaBytes": -14423892,
"heapUsedBytes": 82643180,
"domNodes": 126,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.793000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 944.6619999999939,
"styleRecalcs": 78,
"styleRecalcDurationMs": 108.131,
"layouts": 76,
"layoutDurationMs": 28.111,
"taskDurationMs": 904.52,
"heapDeltaBytes": 17977380,
"heapUsedBytes": 89988296,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 355.0930000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1019.3040000000337,
"styleRecalcs": 78,
"styleRecalcDurationMs": 115.731,
"layouts": 76,
"layoutDurationMs": 28.608,
"taskDurationMs": 968.904,
"heapDeltaBytes": 18239036,
"heapUsedBytes": 90220880,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 386.592,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.527586206896558,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1458.2850000000462,
"styleRecalcs": 78,
"styleRecalcDurationMs": 247.742,
"layouts": 76,
"layoutDurationMs": 28.094,
"taskDurationMs": 1445.1000000000001,
"heapDeltaBytes": -717208,
"heapUsedBytes": 129217528,
"domNodes": 76,
"jsHeapTotalBytes": -3973120,
"scriptDurationMs": 441.301,
"eventListeners": -826,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.254117647058827,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1517.857000000049,
"styleRecalcs": 78,
"styleRecalcDurationMs": 263.27,
"layouts": 76,
"layoutDurationMs": 30.631999999999998,
"taskDurationMs": 1493.873,
"heapDeltaBytes": -8279800,
"heapUsedBytes": 121645916,
"domNodes": 76,
"jsHeapTotalBytes": -4235264,
"scriptDurationMs": 498.25,
"eventListeners": -912,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.957500000000003,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19240 +/- ##
==========================================
+ Coverage 84.48% 85.21% +0.73%
==========================================
Files 3345 2357 -988
Lines 161322 135304 -26018
Branches 43860 34536 -9324
==========================================
- Hits 136290 115301 -20989
+ Misses 23136 19641 -3495
+ Partials 1896 362 -1534
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 995 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…n-chat-workflow Keep this branch's startup restoration (restoreInitialThread), history navigation guard, and persisting a history selection only after success, together with main's stashedTurn telemetry, malformed stream reporting, and history-load error reporting. The 404 path still clears the stored thread pointer only when it names the failed thread. Keep both warnRestoreFailed and main's trackWorkflowOpenFailure.
…n-chat-workflow Combine AgentPanel's vue imports (this branch's onScopeDispose with main's watch). Main's standing credits paywall (#18967) renders as an alert in a fresh chat when the test workspace has no funds, so the Current-switch "leave history" test now asserts that the history open-failure message is absent instead of any alert.
christian-byrne
left a comment
There was a problem hiding this comment.
agentPanelStore keeps the entire closed ComfyWorkflow in singleton targetTracking.closed only to recognize a later delete. Closing a temporary workflow removes it from the workflow lookup without unloading it, so this strong reference can retain its loaded graph and change tracker until the target/chat changes. Please retain a lightweight stable identity for delete matching instead, with a regression that proves the closed workflow object is released.
This user-visible deletion notice also still lacks black-box coverage. Please add a browser journey that deletes the open chat's target and asserts the unavailable notice, then verify the stacked base first and rebase the stack onto current main before landing.
Keep only the saved path of a closed target, following renames, instead of the closed workflow object, so a closed unsaved workflow can be released. Discarding an unsaved target only closes it and shows no deletion notice. Adds a browser journey that deletes the chat's target from the Workflows sidebar and expects the unavailable notice.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 3 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
A reopened workflow is just another tab, so deleting it later no longer reports the detached chat's target as unavailable. The retained target type now only allows a closed path or unavailable marker without a workflow.
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head 16c70fa. The six-file deleted-target notice change, resolved review findings, durable browser proof, and focused unit coverage are sound; all required exact-head checks are green.
|
|
…copy for payment_failed renewals (#19677) (#19748) *PR Created by the Glary-Bot Agent* --- Manual backport of #19677 to `cloud/1.55`, from the v1.56.2 backport-status report. Companion to #19746 (`core/1.55`). Cherry-picked from upstream merge commit `13a9333e54`. Requested in [#frontend-releases](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790847308032919) as a cherry-pick "carrier" backport, one per target branch. #19677 is the only PR the report flags for `cloud/1.55` that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below. ## Why For a `payment_failed` renewal the run button is already locked, but the settings banner said "Update payment to avoid a pause" — copy describing a warning stage that does not exist, because the backend never sets `paused` on renewal failure (BE-6970). `payment_failed` now reads as paused, and the member paused banner gets the informational grey icon. ## Conflict resolution Identical to #19746: `BillingStatusBanner.vue` and `BillingStatusBanner.test.ts` are **byte-identical** between `core/1.55` and `cloud/1.55` at their bases (verified by blob hash), so this is the same resolution. `cloud/1.55` predates main's refactor of this banner into per-kind view factories, and has no renewal-invoice support: `BannerView` has no `payInvoiceUrl`, the template has no Pay invoice button, there is no `payInvoice` string, and `useBillingContext` does not expose `renewalInvoice`. The upstream diff was applied as behaviour, not as text. - **`BillingStatusBanner.vue`** — kept this branch's single `switch`-based `banner` computed rather than main's `pausedView()`/`paymentFailedView()` factories. Accept-theirs would have produced a broken hybrid and dragged in an unrelated `isEnterprisePlan` ending-copy change not on this branch. `paymentFailed` now shares the `paused` case, and `paused` is muted for members. The Pay invoice branch is omitted — that feature does not exist here. - **`BillingStatusBanner.test.ts`** — dropped upstream's edits to the `renewal invoice` describe block; that block does not exist on this branch. Kept the renamed payment_failed test and its updated paused-copy assertions. - **`src/locales/en/main.json`** — removed the now-unused `billingStatus.warning` strings. This file is *not* identical between the 1.55 branches, so the conflict was resolved in place rather than by reusing the `core/1.55` blob; the `billingStatus` sub-tree is identical (verified by hash) and the banner was the strings' only consumer. Semantics preserved exactly: upstream's `pausedView()` is `{ muted: !canManage, title: paused.title, body: canManage ? paused.body : paused.memberBody, action: canManage ? 'updatePayment' : null, dismissible: false }`, and the merged `case 'paused'/'paymentFailed'` arm reproduces that. `useBillingBanner` gates `paymentFailed` on `canManage`, so the newly-gated `action` and `muted` resolve to the same values upstream produces. No backport-only compatibility shim was needed; no public API shape or callback signature changed. The resulting net diff is identical to #19746 (3 files, +7/−24). ## Validation - `pnpm test:unit BillingStatusBanner.test.ts` — 20/20 passing - `pnpm typecheck` — exit 0 - `pnpm exec oxfmt --check` on changed files — clean - Rendered verification was done on the identical `core/1.55` component tree (see #19746 for screenshots and the live-DOM icon-class/colour table): `payment_failed` owner flips from "Payment failed / …avoid a pause" to "Subscription paused / …Update payment to resume", and the paused **member** icon flips from amber `icon-[lucide--triangle-alert]` `rgb(252,191,100)` to grey `icon-[lucide--circle-alert]` `rgb(73,74,80)`, with the paused owner unchanged. No E2E added — matching upstream, which notes Playwright cannot put a real workspace into these billing states. ## Why this carrier holds one commit The report flagged four PRs as "❗ Need backport". Two cannot be carried: - **#19053** ("restore live turn after panel remount", PM-1776) — **not merged.** Only `refs/pull/19053/head` exists; it is 69 commits ahead of `main` with no squash commit, which is why the report listed it without a `(#NNNNN)` suffix. There is nothing to cherry-pick. - **#19240** ("say when the open workflow is deleted") — flagged for `cloud/1.55`, but its **prerequisite is missing on every target branch.** Its mechanism marks the target unavailable so the in-chat notice from #18866 renders. Neither `markWorkflowTargetUnavailable`/`targetUnavailable` nor the `targetWorkflowUnavailable` string exists on `core/1.54`, `cloud/1.54`, `core/1.55` or `cloud/1.55`, and the 1.55 branches still use the older `WorkflowTargetSelection` model instead of `TargetTracking` — so the cherry-pick does not even apply here. Carrying it would set a state nothing renders, a silent no-op defeating the fix. It needs #18866 backported first. #18074 is labelled `core/1.54` + `cloud/1.54` only, so it is not in this branch's scope. Original PR: #19677 / Original commit: `13a9333e5426d6e2e2f5f61d3da72a8184176a75` Justification: Standing Agent release-backport grant; independent exact-head audit found faithful cloud/1.55 adaptation, all hosted checks are terminal green at aed7958, and the live target advanced by three commits with zero changed-file overlap. REVIEW_REQUIRED alone is not an added approval requirement for this grant. Co-authored-by: Dante <bunggl@naver.com>
The prerequisite carrier landed as #19734 (22e29bc), which re-derived #18866 against this branch's files after the first attempt (eee88dc, the second commit on this branch) resolved its conflicts by taking main's copy wholesale. Both now sit on the same branch, which is what GitHub reported as CONFLICTING. Resolution: take cloud/1.54's content for every file the two prerequisites share, then re-apply #19240's own hunks on top. The merged tree therefore equals origin/cloud/1.54 plus exactly the six-file #19240 delta and nothing else — eee88dc's main-only context (workspace-scoped agent storage keys, ComfyApi.serverFeatureFlagsSettled, three main-only test modules, 27 ADR index rows for ADRs absent here) is gone. Verified before commit: git diff --cached --stat origin/cloud/1.54 -> the 6 files of d46c6ed only, +371/-9 No force-push: this is a merge, so the previously reviewed head d46c6ed remains in the history.
Two main-only assumptions travelled with the backport and are why the browser coverage never executed and `typecheck` was red at d46c6ed: - `AgentPanel.open()` returns `Promise<Locator>` on `main` and `Promise<void>` here, so `const panel = await agentPanel.open()` did not compile (`error TS2339: Property 'getByText' does not exist on type 'void'`, reproduced by restoring the old file). The spec uses `agentPanel.root` instead, which both branches expose. - `TabLinkCard.test.ts` stubs `useWorkflowStore` by hand on this branch where `main` uses the real store, so the panel store's new `$onAction` subscription threw `workflowStore.$onAction is not a function` and took all 11 of its tests down. The stub now offers the subscription. Neither changes production code: this is the backport adaptation #19734's message describes, applied to the dependent carrier. Verified at this tree: typecheck, typecheck:browser, format:check, lint (0 errors), knip, adr:check, locale:check; full unit suite 1583/1583 files and 22490 tests; `playwright --project=cloud browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts` green, which it had never been. The spec also gains a second case, `gives a workflow saved at the deleted path its own identity`, which saves a replacement workflow at the deleted target's name and asserts the chat's next turn carries the replacement's own cloud id. It is the black-box answer to the reviewers' overwrite-vs-delete and recycled-path questions, and it fails against the fixture's old id scheme (it posts the deleted workflow's id, `…000000000001`).
Fixture, both findings confirmed real and now proven by the browser case in the previous commit: - Cloud ids came from `workflows.length + 1`, but entries leave `workflows` on delete and on a refused turn, so a workflow saved after either one was reissued a live entry's id. Ids now come from a counter that only moves forward. The existing `…000000000001` assertion in `agentWorkflowSelection.spec.ts` is unchanged by this. - The listing name was derived with `slice(…, -'.json'.length)` guarded only by the `workflows/` prefix, in both the POST and the DELETE handler, so any other path under that directory became a prefix of some unrelated entry's name and could splice it out. `workflowNameFromPath` requires the suffix and both handlers use it. This fixes the POST side too, which the review comment's route-level guard would not have. Ordering, dispositioned rather than changed. A delete that settles while the chat is still `restoring` is invisible to the panel store — there is no retained target to match — so the store cannot own that outcome. The restoration does, from the Cloud listing, and it cannot commit the deleted workflow behind the notice because `isCurrent()` requires the mode to still be `restoring`. Two rows record that boundary where each half is observable: the store row asserts no notice from the store, and `useAgentWorkflowSelection.test.ts` asserts the notice the restoration reports. The selection test fails if `markWorkflowTargetUnavailable()` is removed from `onWorkflowRestored`. #19240's production delta is applied verbatim: `agentPanelStore.ts` here differs from `origin/main` only in the two pre-existing branch lines (`api.serverFeatureFlagsSettled` / `flagsSettled`) that `main` has and this release line does not, plus import order. Every finding that asks for a behaviour change — reporting an overwrite-save as a deletion, observing a remote or cross-tab delete, reacting to a durable mutation whose later cleanup rejects, and unbinding the chat/tab record on delete — was raised and dispositioned on that PR with a reviewer's sign-off, or is pre-existing behaviour this change does not touch. Diverging the release carrier from the approved parent is the thing this backport must not do; the detail per finding is in the PR thread replies and in reports/jobs/op228-fe19735-stackrepair-1.md.
…9240 This carrier forked from the #18866 branch at 9d6c35a - the first, bad attempt at the prerequisite, before both its a4ce50f repair and the target merge. Its 45-file / -4478-line diff against the current base was therefore mostly the base's own later content being undone; the carrier's real payload is #19240's 6-file, +371/-9 delta. Re-derived onto the repaired base: take that base's content wholesale and apply exactly #19240's delta on top. Two adaptations this release line needs, both of the same main-only-API class: - agentDeletedTargetNotice.spec.ts did `const panel = await agentPanel.open()` and then `panel.getByText(...)`. AgentPanel.open() returns Promise<Locator> on main and Promise<void> here, so the browser coverage this carrier exists to add could never have compiled. It now reads agentPanel.root, which both branches expose. The assertion is unchanged. - agentPanelStore no longer exposed `targetTracking`, which #19240's agentPanelTarget.test.ts asserts against. main has exported it since #18693 (facbca7); #19240 did not add it. Carried as the missing prerequisite rather than weakening the test. Verified: the merged tree is the repaired base plus exactly #19240's 6-file delta, matching the upstream 2595efc file set.
…19735) Stacked manual backport of #19240 on the #18866 `cloud/1.54` carrier. This makes an open Agent chat explicitly report when its target workflow was deleted, and includes the source unit and browser coverage. Original: #19240 ## Repaired after the prerequisite landed The prerequisite shipped as #19734 (`22e29bc9`), which re-derived #18866 against this branch's files after the first attempt — `eee88dc3`, still the second commit on this branch — resolved its conflicts by taking `main`'s copy wholesale. Both versions then sat on the same branch, which is what GitHub reported as `CONFLICTING`. `0f2d27d1` merges `cloud/1.54` in rather than force-pushing, so the previously reviewed head `d46c6ed9` stays in the history. The resolution takes `cloud/1.54`'s content for every file the two prerequisites share and re-applies #19240's own hunks on top, so the merged tree equals `origin/cloud/1.54` plus exactly the six-file #19240 delta and nothing else (`git diff --cached --stat origin/cloud/1.54` → +371/-9 across those six files). Two `main`-only assumptions then had to be adapted, and they are why `typecheck` was red and the browser coverage never executed at the old head: - `AgentPanel.open()` returns `Promise<Locator>` on `main` and `Promise<void>` here, so `const panel = await agentPanel.open()` did not compile. The spec uses `agentPanel.root`. - `TabLinkCard.test.ts` hand-stubs `useWorkflowStore` on this branch where `main` uses the real store, so the panel store's new `$onAction` subscription threw and took all 11 of its tests down. The stub now offers the subscription. `agentPanelStore.ts` differs from `origin/main` only in the pre-existing `api.serverFeatureFlagsSettled` lines that `main` has and this release line does not; #19240's production delta is applied verbatim. ## Review findings All seven threads are answered inline and resolved. Two were real and are fixed in the browser fixture — cloud ids came from `workflows.length + 1`, which reissued a live entry's id to a workflow saved after a delete or a refused turn, and the listing name was sliced on the `workflows/` prefix alone without requiring the `.json` suffix, in both the POST and the DELETE handler. The rest were raised and dispositioned on #19240 itself, or describe pre-existing behaviour this change does not touch; a release carrier is not the place to diverge production behaviour from the approved parent. One genuinely new finding — `renameWorkflow` rejecting after it has already swapped the path leaves `closedPath` stale — is recorded for `main` rather than fixed here. ## Proof at this head - `agentDeletedTargetNotice.spec.ts` gains "gives a workflow saved at the deleted path its own identity": it saves a replacement at the deleted target's name and asserts the chat's next turn carries the replacement's own cloud id. It fails against the old fixture id scheme, where the turn posted the deleted workflow's `…000000000001`. - `useAgentWorkflowSelection.test.ts` gains the delete-settles-mid-restoration ordering, which fails if `markWorkflowTargetUnavailable()` is removed from `onWorkflowRestored`. - `agentPanelTarget.test.ts` records the store-side boundary for that same ordering. - Green locally at `c2e6b2b6`: `typecheck`, `typecheck:browser`, `format:check`, `lint` (0 errors), `knip`, `adr:check`, `locale:check`; full unit suite 1583/1583 files and 22490 tests; and `playwright --project=cloud` over `agentDeletedTargetNotice`, `agentWorkflowSelection`, `agentHistoryReopensClosedWorkflow` and `agentStaleWorkflowTabBinding` — 12 passed. --- Justification: Release-branch backport merged by its author under this program's standing Agent 1.54/1.55 backport grant (Christian, 2026-09-16, extended 2026-09-27), which authorizes the carrier's own author to merge once their own gates pass — GitHub cannot accept an author's self-approval, so no pre-merge approval record exists. What limits the blast radius: the change is confined to `cloud/1.54` at +526/-13 across 8 files (one production file, `agentPanelStore.ts`, plus its own tests, one browser fixture, one spec and one ADR); the target refresh is provably content-neutral, with the carrier patch byte-identical to the previously reviewed head (sha256 `60d6f077a45ed4ed8fa563defbfe8c0dcc947a95f208b7c8ca7f3f870ce88a6b`); there is zero file overlap with the untested target delta; every required check is green at the exact merged head; and the user-visible behaviour was proven on this carrier through the black-box harness (`browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts`). Post-merge peer review is still owed under SOC 2 CC8.1 and is NOT waived by this line; it routes to @DrJKL for `ComfyUI_frontend`. --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
#19732 squash-landed as e9a89db, so this carrier's base branch is gone and GitHub retargeted it to cloud/1.55. That left it CONFLICTING: the merge base falls back to 9a5ce83, before the squash, so git tried to re-merge #18866's content against the copy this branch already carries. Resolving that merge directly produced real damage - a duplicated markWorkflowTargetUnavailable and a mangled TargetTracking union. Re-derived instead, on the proof that e9a89db's tree is byte-identical to the reviewed 3dff667 (both f622a76): take the landed tip's content wholesale and apply exactly #19240's delta on top, with the same two release-line adaptations as before - agentPanel.root in place of the Promise<Locator> return main's AgentPanel.open() has, and the targetTracking export main has carried since #18693. The tree is therefore cloud/1.55 plus exactly #19240's 6-file delta, matching the upstream 2595efc file set.
…19733) Stacked manual backport of #19240 on the #18866 cloud/1.55 carrier. This makes an open Agent chat explicitly report when its target workflow was deleted and includes the source unit and browser coverage. The base will be retargeted to cloud/1.55 after the prerequisite carrier lands.\n\nOriginal: #19240 Justification: Exact head 186452c has DrJKL approval and all required checks green. cloud/1.55 advanced by two commits after CI; the exact-head gate measured zero changed-file overlap with that target delta, so the stale-base exception is narrowly applied for this authorized release backport. --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: GitHub Action <action@github.com>
…oss a rewire (#18074) (#19750) *PR Created by the Glary-Bot Agent* --- Manual backport of #18074 to `cloud/1.54`, from the v1.56.2 backport-status report. Companion to #19749 (`core/1.54`). Cherry-picked from upstream merge commit `9ee67cb17b`. Requested in [#frontend-releases](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790847308032919) as a cherry-pick "carrier" backport, one per target branch. #18074 is the only PR the report flags for `cloud/1.54` that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below. ## Why Rewiring the interior link behind one promoted subgraph widget (e.g. dragging a new node onto an already-promoted widget's socket) could drop or visually duplicate the host node's *other* promoted widgets, and make the rewired widget itself disappear. `SubgraphInputNode`'s `'input-disconnected'` handler demoted the widget **synchronously** while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick `hostNode.widgets.length` and the store's tracked id count disagreed — and the Vue widget grid reads its render *order* from the store and its liveness *filter* from `hostNode.widgets`, i.e. from both sides of that disagreement. The fix defers the demotion itself by a microtask with a per-input cancellation token, which `'input-connected'` clears on a same-tick reconnect, so a rewire never drops the widget at all. - Fixes #14495 ## Conflict resolution **The fix itself (`SubgraphNode.ts`, `interfaces.ts`) cherry-picked clean.** `SubgraphNode.ts` differs slightly between `core/1.54` and `cloud/1.54`, but the fix applied cleanly to both and the resulting hunks are identical. Only two test files conflicted — the same two as on #19749, and those two files are **byte-identical between `core/1.54` and `cloud/1.54` at their merge base** (verified by blob hash), so this is the same resolution, reusing the exact same resolved blobs: - **`useErrorClearingHooks.test.ts`** — the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", which `main` gained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted" `async` and `await` the now-deferred demotion. - **`SubgraphWidgetPromotion.test.ts`** — import-only conflict. Accepted the three new imports (`WidgetValue`, `createPromotedMultilineWidget`, `useDomWidgetStore`) required by the new PM-1328 describe block, after verifying all three modules and symbols exist on this branch. The new block also uses `LegacyWidget`, which `main` imports from the litegraph barrel in a *neighbouring non-conflicting* import hunk — so this branch's version won and left it out, failing with `ReferenceError: LegacyWidget is not defined` until it was added to the barrel import. `LegacyWidget` already exists and is exported from the barrel here, so this is an import fix, not new code. No backport-only compatibility shim was needed, and no public API shape or callback signature changed. The deliberate timing change this PR documents — a genuine disconnect becomes observable on `hostNode.widgets` one microtask later — is carried as-is rather than shimmed: the surrounding machinery (`SubgraphInputNode.ts`, `SubgraphInputEventMap.ts`) is byte-identical between this branch and `main`, so a literal cherry-pick cannot recreate the original bug for an old-contract consumer, and deviating would leave this branch running demotion logic `main`'s CI has never exercised. Changed-file set is **exactly** the same 7 files as upstream `9ee67cb17b` — no unrelated drift smuggled in. ## Validation - `pnpm test:unit` on the suites upstream used to validate the fix — **527/527 passing across 24 files** (`src/lib/litegraph/src/subgraph/`, `useErrorClearingHooks.test.ts`, `promotionUtils.test.ts`, `multilineTextarea.promoted.test.ts`, `widgetValueStore.test.ts`, `domWidgetStore.test.ts`). This includes the PR's own regression case, "keeps every promoted widget present while rewiring the interior link behind one of them", which asserts `hostNode.widgets.length` stays at 4 throughout a rewire — i.e. the exact mechanism, proven fixed on this branch. - `pnpm typecheck` — exit 0 - `pnpm exec eslint` on changed files — **0 errors**, 6 warnings, all pre-existing `import-x/no-restricted-paths` on `src/lib/` (upstream carries the same; `pnpm lint` sets no `--max-warnings`) - `pnpm exec oxfmt --check` on changed files — clean ###⚠️ Please let CI run the E2E before merging This PR lands `subgraphPromotedWidgetRewireDuplication.spec.ts` and flips `test.fail()` → `test()` in `subgraphPromotion.spec.ts`. Upstream justified those flips with CI evidence gathered on `main` ([run 35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)); **there is no equivalent evidence for `cloud/1.54` yet**, and the Playwright suite needs a live ComfyUI backend plus a built frontend, which I could not stand up in the sandbox. The unit-level regression above proves the mechanism on this branch, but per `SKILL.md` ("NEVER merge a backport PR without all CI checks passing") the flipped e2e should be confirmed green here before merge. Kept as a draft for that reason. ## Why this carrier holds one commit The report flagged four PRs as "❗ Need backport". Two cannot be carried: - **#19053** ("restore live turn after panel remount", PM-1776) — **not merged.** Only `refs/pull/19053/head` exists; it is 69 commits ahead of `main` with no squash commit, which is why the report listed it without a `(#NNNNN)` suffix. There is nothing to cherry-pick. - **#19240** ("say when the open workflow is deleted") — flagged for `cloud/1.54`, but its **prerequisite is missing.** Its mechanism marks the target unavailable so the in-chat notice from #18866 renders. This branch has the `TargetTracking` model but **no** `markWorkflowTargetUnavailable`/`targetUnavailable` and no `targetWorkflowUnavailable` string — the only "unavailable" path here is an unrelated *toast* fired on navigation failure (`agent.targetNavigationUnavailable`), a different mechanism for a different trigger. Carrying #19240 alone would set a state nothing renders — a silent no-op defeating the fix. It needs #18866 backported first. (Same gap on all four target branches.) #19677 is labelled `core/1.55` + `cloud/1.55` only, so it is not in this branch's scope. Original PR: #18074 / Original commit: `9ee67cb17b` --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Summary
Deleting the saved file of the open chat's target workflow now shows the existing in-chat notice ("The target workflow is no longer available.") instead of silently dropping the target.
PM-1640
Changes
workflowStore.deleteWorkflow. When the delete of a saved workflow finishes and that workflow is still the chat's target, the store marks the target unavailable, which shows the notice from fix(agent): reopen saved workflows from chat history #18866. A target whose tab has closed is known by its saved path, which follows renames, so the store does not keep the closed workflow object. Closing the tab, or deleting an unsaved target, only clears the target. Deleting another workflow, deleting after the chat picked another target, and deleting after the closed target was reopened change nothing. A fresh chat that follows the visible tab is unaffected.Review Focus
$onAction, as inmintPortWiring.ts). Leaving the workflow lookup is not a reliable signal, because a closed temporary tab also leaves it while its Cloud document may still exist.main: a delete from another tab or device (syncWorkflows) shows no live notice, and a delete whose bookmark cleanup rejects after the server delete leaves the workflow listed.Validation
agentPanelTarget.test.ts(real stores): saved target deleted after close and while open, unsaved target deleted, a saved workflow deleted at a closed unsaved target's path, closed target renamed then deleted, closed target reopened then deleted, target cleared mid-delete, target committed by a restoring chat mid-delete, close only, another workflow, a following chat, a changed target. A second table checks that a closed target keeps no workflow object. The positive rows fail against the base store.AgentPanelRoot.test.ts: the mounted panel shows the notice after the target is deleted.browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts(cloud): picks and saves a target, deletes it from the Workflows sidebar, then checks the notice and the picker's "Select a workflow…" text. Runs in CI.