Skip to content

[backport cloud/1.54] carrier: keep promoted subgraph widgets present across a rewire (#18074) - #19744

Closed
christian-byrne wants to merge 1 commit into
cloud/1.54from
glary/backport-carrier-cloud-1.54
Closed

christian-byrne wants to merge 1 commit into
cloud/1.54from
glary/backport-carrier-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Carrier backport onto cloud/1.54, from the v1.56.2 backport-status report. Sibling of #19743 (core/1.54); both carriers resolved identically.

What's carried

Only one of the four PRs flagged Need backport in that report is cherry-pickable today — see "Not carried" below.

Backport adaptations

Two test-only conflicts; the fix itself (SubgraphNode.ts, interfaces.ts) applied cleanly.

  • src/composables/graph/useErrorClearingHooks.test.ts — dropped the retires an absorbed promoted media error when its host is deleted case from the picked hunk. It was added on main by an unbackported PR and does not exist on this branch; only fix: keep promoted subgraph widgets present across a rewire #18074's own async/await Promise.resolve() change to the surviving case is applied.
  • src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts — added LegacyWidget to the existing @/lib/litegraph/src/litegraph value import. main's copy already imported it for cases that do not exist on this branch; the new rewire-desync test needs it.

No other deviation from upstream.

Validation

  • pnpm typecheck — exit 0
  • pnpm test:unit src/lib/litegraph/src/subgraph/ src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts src/renderer/.../multilineTextarea.promoted.test.ts src/core/graph/subgraph/ — 561/561 passing, 32 files
  • pnpm exec eslint <7 changed files> — 0 errors (6 import-x/no-restricted-paths warnings, test-only, identical to upstream)
  • pnpm exec oxfmt --check — clean

The two e2e specs in this pick were not run here: they need a live ComfyUI backend and a browser harness that is not available in this environment. They ran green on upstream CI (run 35419314544).

Blocking: two defects inherited from upstream #18074

Both are in the payload, byte-identical to main, and already shipped in v1.56.2. They are not introduced by this backport, and deliberately not patched here — fixing them only on the release line would diverge it from main. Flagging so the call is explicit before this merges. Full detail in #19743; summary:

1. SubgraphNode.ts:359-366 — store cleanup suppressed by an ordering inversion. The deferred demotion evaluates if (id && !this.inputs.some((i) => i.widgetId === id)) before clearing input.widgetId. Pre-#18074 the clear was synchronous and the check ran later, so the predicate asked "does some other surviving input still claim this id?". Now the input's own un-cleared widgetId matches and deleteWidget(id) never fires where the host input survives. The resulting retention is load-bearing for the flipped #14495 e2e case, so a bare reorder reintroduces #14495.

2. SubgraphNode.ts:316-317 — demotion cancelled by a reconnect carrying no widget. input._pendingDemotionToken = undefined runs before the if (!e.detail.widget || !e.detail.node) return guard, so a widgetless input-connected (dispatched by SubgraphInput.connect() when the newly connected interior input has no widget) cancels the demotion without calling _setWidget — leaving stale widgetId/widget/_widget and the row still in hostNode.widgets. Persists and serialises.

Suggested order: fix both on main, then re-cut both carriers from the corrected commit.

Also noted

#18074 makes a disconnect observable on hostNode.widgets one microtask later than before. AGENTS.md flags node.widgets as affecting 40+ custom-node repos. The exposure is identical on main, so no backport-only shim was added — recording the decision per the backport skill.

Not carried (blocked on unbackported prerequisites)

PR Targets Missing prerequisite
#19053 restore live turn after panel remount core/1.54, cloud/1.54, core/1.55, cloud/1.55 readyThreadId/threadStorageKey from #18866; turnStartedAt from #18665; on the 1.54 pair also hydratedTurnIds from #18152, whose backports #19696/#19697 are still open
#19240 say when the open workflow is deleted cloud/1.54, cloud/1.55 targetUnavailable/markWorkflowTargetUnavailable from #18866
#19677 FE-3135 show SCA/payment_failed renewals core/1.55, cloud/1.55 renewalInvoice on useBillingContext, pausedView/safeInvoiceUrl/payInvoiceUrl from #19435

Backport of #18074 to cloud/1.54.

Defers promoted-widget demotion by a microtask (cancelled by a same-tick
reconnect) so rewiring the interior link behind one promoted widget no
longer drops it from hostNode.widgets.

Backport adaptations:
- src/composables/graph/useErrorClearingHooks.test.ts: dropped the
  'retires an absorbed promoted media error when its host is deleted'
  case from the picked hunk. It was added on main by an unbackported PR
  and is not present on this branch; only the async/await change #18074
  makes to the surviving case is applied.
- src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts: added
  LegacyWidget to the existing '@/lib/litegraph/src/litegraph' value
  import. main's copy of this file already imported it for other cases
  that do not exist on this branch; the new rewire-desync test needs it.

(cherry picked from commit 9ee67cb)
@vercel

vercel Bot commented Oct 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 1, 2026 10:32am UTC
billing-web-test Ignored Ignored Oct 1, 2026 10:32am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 2acebebd-7433-424c-9e04-728b92f8276a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@glary-bot

glary-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

No action taken on this one — it's a status notice, not a finding.

CodeRabbit skipped because .coderabbit.yaml lists '[backport' under reviews.auto_review.ignore_title_keywords (alongside '[release]'), and this PR is titled [backport core/1.54] …. That's deliberate repo policy for backport PRs, so I'm not renaming the title or forcing @coderabbitai review to work around it.

Worth flagging for whoever picks this up, since the usual automated pass didn't run: this carrier is a faithful cherry-pick of #18074, but the payload carries two defects inherited from upstream (ordering inversion at SubgraphNode.ts:359-366, and the demotion token cleared before the guard at :316-317). Both are byte-identical to main and already shipped in v1.56.2. They're written up in the PR description under "Blocking: two defects inherited from upstream #18074" and are the reason this is a draft — the suggested order is to fix main first, then re-cut the carrier.

Human review still needed here; the skip shouldn't be read as a clean bill of health.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1984 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1963 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/01/2026, 10:34:11 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 152ms TBT · 85.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.3 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 269ms TBT · 167.6 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 522ms TBT · 169.0 MB heap
vue-zoom-out-idle: · 54.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 540ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.6 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 990ms
canvas-mouse-sweep: script duration 172ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.0 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 395ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 557ms
dom-widget-clipping: script duration 195ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.3 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 661ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.3 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -179
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1898ms
large-graph-pan: script duration 965ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.6 MB
large-graph-pan: DOM nodes -285
large-graph-pan: event listeners -175
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1906ms
large-graph-zoom: script duration 886ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.3 MB
large-graph-zoom: DOM nodes -281
large-graph-zoom: event listeners -74
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2246ms
legacy-node-drag: script duration 1147ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 96.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 2
minimap-idle: task duration 642ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.1 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 480ms
subgraph-dom-widget-clipping: script duration 164ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.5 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 540ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.3 MB
subgraph-idle: DOM nodes -299
subgraph-idle: event listeners -228
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 80
subgraph-mouse-sweep: task duration 980ms
subgraph-mouse-sweep: script duration 123ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 75.0 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -211
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 967ms
subgraph-transition-enter: script duration 37ms
subgraph-transition-enter: TBT 152ms
subgraph-transition-enter: heap used 85.1 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 44ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6781ms
viewport-pan-sweep: script duration 3242ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.7 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -142
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17871ms
vue-large-graph-idle: script duration 313ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.3 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14929
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 26ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 25189ms
vue-large-graph-pan: script duration 1178ms
vue-large-graph-pan: TBT 269ms
vue-large-graph-pan: heap used 167.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14926
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6685ms
vue-node-resize-workload: script duration 128ms
vue-node-resize-workload: TBT 522ms
vue-node-resize-workload: heap used 169.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8652ms
vue-zoom-out-idle: script duration 160ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 25ms
workflow-execution: layout count 3
workflow-execution: style recalc count 16
workflow-execution: task duration 135ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.5 MB
workflow-execution: DOM nodes 145
workflow-execution: event listeners 67
Raw data
{
  "timestamp": "2026-10-01T10:44:13.533Z",
  "gitSha": "06deb0ea224d8fc3d53c56b8b6aebfa61ba79cac",
  "branch": "glary/backport-carrier-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2092.090999999982,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.067,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.0740000000001,
      "heapDeltaBytes": -5357192,
      "heapUsedBytes": 65313344,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.977000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2084.171999999967,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.9319999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 534.351,
      "heapDeltaBytes": 9741652,
      "heapUsedBytes": 80689024,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.469999999999999,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1900.2630000000522,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.037,
      "layouts": 14,
      "layoutDurationMs": 4.123,
      "taskDurationMs": 919.173,
      "heapDeltaBytes": 6405000,
      "heapUsedBytes": 76852792,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 165.102,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2058.983000000012,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.70399999999999,
      "layouts": 14,
      "layoutDurationMs": 4.554,
      "taskDurationMs": 1061.079,
      "heapDeltaBytes": -6841624,
      "heapUsedBytes": 63551876,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 178.307,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1736.9689999999878,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.886999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.258,
      "taskDurationMs": 422.71000000000004,
      "heapDeltaBytes": 4694512,
      "heapUsedBytes": 75873260,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.717000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.5779999999904,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.337,
      "layouts": 6,
      "layoutDurationMs": 1.3699999999999999,
      "taskDurationMs": 366.799,
      "heapDeltaBytes": 4517636,
      "heapUsedBytes": 75913668,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.649999999999997,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 818.8879999999585,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.501,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 547.715,
      "heapDeltaBytes": -7397836,
      "heapUsedBytes": 63267264,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 192.661,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 806.8640000000187,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.831000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.3140000000001,
      "heapDeltaBytes": -6834648,
      "heapUsedBytes": 63274692,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 196.417,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.895000000021,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 7.064000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 682.221,
      "heapDeltaBytes": 7093948,
      "heapUsedBytes": 83588412,
      "domNodes": -282,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 33.910999999999994,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2047.4520000000211,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 5.7360000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 638.7840000000001,
      "heapDeltaBytes": 10496712,
      "heapUsedBytes": 86938792,
      "domNodes": -272,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 33.44899999999999,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3008.376999999996,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.209,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1881.7279999999998,
      "heapDeltaBytes": 16370932,
      "heapUsedBytes": 94401252,
      "domNodes": -278,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 975.3279999999999,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3081.5109999999777,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.468000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1913.318,
      "heapDeltaBytes": 3319816,
      "heapUsedBytes": 80951792,
      "domNodes": -292,
      "jsHeapTotalBytes": 647168,
      "scriptDurationMs": 954.4580000000001,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4107.202000000029,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 13.152000000000001,
      "layouts": 60,
      "layoutDurationMs": 16.409,
      "taskDurationMs": 2096.3059999999996,
      "heapDeltaBytes": 10179144,
      "heapUsedBytes": 76661364,
      "domNodes": -280,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 976.288,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3724.034999999958,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.318000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.859,
      "taskDurationMs": 1715.0979999999997,
      "heapDeltaBytes": 9800656,
      "heapUsedBytes": 77062368,
      "domNodes": -281,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 794.712,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3515.053000000023,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 6.703,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2227.0450000000005,
      "heapDeltaBytes": 31893128,
      "heapUsedBytes": 100119976,
      "domNodes": 0,
      "jsHeapTotalBytes": 3301376,
      "scriptDurationMs": 1131.414,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3483.3489999999756,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 6.196,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2265.1189999999997,
      "heapDeltaBytes": 33229592,
      "heapUsedBytes": 101293088,
      "domNodes": 0,
      "jsHeapTotalBytes": 4087808,
      "scriptDurationMs": 1162.39,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2078.5769999999957,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.287000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 719.4699999999999,
      "heapDeltaBytes": 6870284,
      "heapUsedBytes": 86289172,
      "domNodes": -279,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 36.079000000000015,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.902999999962,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 1.2390000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.0679999999999,
      "heapDeltaBytes": 10304424,
      "heapUsedBytes": 87925860,
      "domNodes": -277,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 30.02199999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 752.2369999999796,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.699,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.412,
      "heapDeltaBytes": 15470796,
      "heapUsedBytes": 88933788,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 171.934,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 631.1779999999771,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.521000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.85299999999995,
      "heapDeltaBytes": 14710184,
      "heapUsedBytes": 88257448,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 156.605,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.787999999996,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.697000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.571,
      "heapDeltaBytes": 6339608,
      "heapUsedBytes": 79770168,
      "domNodes": -300,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.225000000000002,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.8200000000288,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.671,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 525.1179999999999,
      "heapDeltaBytes": -9244088,
      "heapUsedBytes": 63510324,
      "domNodes": -298,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.188,
      "eventListeners": -244,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1769.6149999999875,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 30.014000000000003,
      "layouts": 18,
      "layoutDurationMs": 5.218999999999999,
      "taskDurationMs": 921.5519999999999,
      "heapDeltaBytes": 9605000,
      "heapUsedBytes": 82868436,
      "domNodes": -297,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 117.218,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1908.4739999999556,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 32.821000000000005,
      "layouts": 18,
      "layoutDurationMs": 5.731,
      "taskDurationMs": 1038.934,
      "heapDeltaBytes": 1029600,
      "heapUsedBytes": 74489424,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 128.84,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.3829999999725,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 34.186,
      "layouts": 14,
      "layoutDurationMs": 15.923000000000004,
      "taskDurationMs": 967.1750000000001,
      "heapDeltaBytes": -5294552,
      "heapUsedBytes": 89191660,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 36.927,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 152,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11828.98499999999,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 47.803,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7380.022000000001,
      "heapDeltaBytes": -8984224,
      "heapUsedBytes": 68038748,
      "domNodes": -273,
      "jsHeapTotalBytes": 421888,
      "scriptDurationMs": 3570.965,
      "eventListeners": -138,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8899.490000000014,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 40.506,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6182.711,
      "heapDeltaBytes": 14105152,
      "heapUsedBytes": 90724280,
      "domNodes": -270,
      "jsHeapTotalBytes": -172032,
      "scriptDurationMs": 2913.335,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19316.395999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18592.242,
      "heapDeltaBytes": -56131320,
      "heapUsedBytes": 179170276,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15421440,
      "scriptDurationMs": 323.53200000000004,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17846.670000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17148.937,
      "heapDeltaBytes": -46217944,
      "heapUsedBytes": 182161180,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14368768,
      "scriptDurationMs": 303.257,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 27184.395999999993,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 27.48999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 26920.824,
      "heapDeltaBytes": -56399752,
      "heapUsedBytes": 171514396,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14553088,
      "scriptDurationMs": 1252.327,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 399,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23725.327000000107,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 23.668999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23458.036,
      "heapDeltaBytes": -38532056,
      "heapUsedBytes": 180066204,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10235904,
      "scriptDurationMs": 1103.001,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 17.77666666666652,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7205.89000000001,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.55499999999999,
      "layouts": 20,
      "layoutDurationMs": 26.636000000000006,
      "taskDurationMs": 7137.649,
      "heapDeltaBytes": -46544188,
      "heapUsedBytes": 176867364,
      "domNodes": -8068,
      "jsHeapTotalBytes": 8790016,
      "scriptDurationMs": 136.45899999999997,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 612,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6341.182000000003,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.82000000000001,
      "layouts": 20,
      "layoutDurationMs": 23.575999999999986,
      "taskDurationMs": 6232.14,
      "heapDeltaBytes": -40598264,
      "heapUsedBytes": 177614000,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12570624,
      "scriptDurationMs": 120.226,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 431,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9097.072000000026,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8805.04,
      "heapDeltaBytes": 21173384,
      "heapUsedBytes": 177740008,
      "domNodes": 0,
      "jsHeapTotalBytes": -8912896,
      "scriptDurationMs": 155.86100000000002,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8818.779000000064,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8498.589,
      "heapDeltaBytes": -1883240,
      "heapUsedBytes": 180281292,
      "domNodes": 0,
      "jsHeapTotalBytes": -7864320,
      "scriptDurationMs": 163.659,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 522.7150000000051,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 26.697000000000003,
      "layouts": 3,
      "layoutDurationMs": 1.8030000000000002,
      "taskDurationMs": 151.58400000000003,
      "heapDeltaBytes": 4982856,
      "heapUsedBytes": 74360196,
      "domNodes": 143,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.853000000000002,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 463.74200000002475,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 22.817,
      "layouts": 2,
      "layoutDurationMs": 1.1099999999999999,
      "taskDurationMs": 119.287,
      "heapDeltaBytes": 5030696,
      "heapUsedBytes": 73583636,
      "domNodes": 146,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 10.312,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50776 76068 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@glary-bot

glary-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

No action taken — this is a status notice, not a finding.

CodeRabbit skipped because .coderabbit.yaml (lines 14-16) lists '[backport' under reviews.auto_review.ignore_title_keywords, alongside '[release]'. This PR is titled [backport core/1.54] …, so the skip is deliberate repo policy for backport PRs. I'm not renaming the title or forcing @coderabbitai review to work around the repo's own configuration.

Since the usual automated pass didn't run, flagging for whoever picks this up: the cherry-pick itself is faithful to #18074 and verified green (pnpm typecheck exit 0; 561/561 unit tests across 32 files; eslint 0 errors; oxfmt clean). But the payload carries two defects inherited from upstream — the ordering inversion at SubgraphNode.ts:359-366 and the demotion token cleared before the guard at :316-317. Both are byte-identical to main and already shipped in v1.56.2, so they are not introduced here. They're written up in the PR description under "Blocking: two defects inherited from upstream #18074", and they are why this is a draft — suggested order is to fix main first, then re-cut this carrier.

Human review still needed; the skip shouldn't be read as a clean bill of health.

@glary-bot

glary-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

Correction to my comment above: it says this PR is titled [backport core/1.54] …. That's wrong — this is the cloud/1.54 carrier, titled [backport cloud/1.54] …. The comment was meant for the sibling PR #19743 and landed here by mistake.

Everything else in it stands and applies equally to this PR: the CodeRabbit skip is deliberate repo policy (.coderabbit.yaml lines 14-16 ignore '[backport' titles), the cherry-pick is faithful to #18074 and verified green here (pnpm typecheck exit 0; 561/561 unit tests across 32 files; eslint 0 errors; oxfmt clean), and the two upstream-inherited defects at SubgraphNode.ts:359-366 and :316-317 are the reason this is a draft.

#19743 now has its own copy of the note.

@glary-bot

glary-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

Cleanup of my own comment noise on this PR — apologies, three of the comments above are mine and two of them were meant for #19743.

What happened: my commenting tool targets the most recently created PR in my session (#19744), not the branch I have checked out. I assumed it resolved by branch, so two notes written for the core/1.54 carrier (#19743) landed here instead. Both can be recognised by their reference to [backport core/1.54] …, which is not this PR's title.

Also correcting myself: my previous comment claimed "#19743 now has its own copy of the note". That is not true — #19743 has none of these comments, and I can't reach it from this session. Sorry for the misinformation.

Net state, to be unambiguous:

No code changed for any of this; it was comment routing only.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19744   +/-   ##
=============================================
  Coverage              ?   84.01%           
=============================================
  Files                 ?     2122           
  Lines                 ?   127088           
  Branches              ?    34403           
=============================================
  Hits                  ?   106771           
  Misses                ?    20138           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.80% <100.00%> (?)
unit 79.18% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/subgraph/SubgraphNode.ts 89.09% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing because the core/cloud 1.54 trains are retired as of 2026-10-09. Any still-applicable change should be carried to the current 1.55 and 1.56 targets instead.

@glary-bot

glary-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

Acknowledged. I'm leaving this closed and won't push any more changes to this branch.

This PR carried one change: #18074 (fix: keep promoted subgraph widgets present across a rewire). Here is where that fix stands on the current targets:

  • core/1.56 and cloud/1.56: already present, as 9ee67cb17b. Nothing needs carrying.
  • core/1.55 and cloud/1.55: not present. If the fix is wanted on 1.55, the usual route is to add the 1.55 backport labels to fix: keep promoted subgraph widgets present across a rewire #18074 so the backport workflow opens those PRs. That's better than retargeting this 1.54 branch, which sits on the 1.54.10 base.

I haven't opened any 1.55 PRs from this thread. If you want me to do that, let me know.

@glary-bot

glary-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

Acknowledged. I'm leaving this closed and won't push any more changes to this branch.

This PR carried one change, a cherry-pick of #18074 (fix: keep promoted subgraph widgets present across a rewire). Here is where that fix stands on the current targets:

  • cloud/1.56 and core/1.56: already present, as 9ee67cb17b. Nothing needs carrying.
  • cloud/1.55 and core/1.55: not present. If the fix is wanted on 1.55, the usual route is to add the 1.55 backport labels to fix: keep promoted subgraph widgets present across a rewire #18074 so the backport workflow opens those PRs. That's better than retargeting this branch, which sits on the 1.54.17 base.

The same applies to the core twin, #19744's sibling #19743. I haven't opened any 1.55 PRs from this thread. If you want me to do that, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant