Repository navigation
[backport cloud/1.54] carrier: keep promoted subgraph widgets present across a rewire (#18074) - #19744
[backport cloud/1.54] carrier: keep promoted subgraph widgets present across a rewire (#18074)#19744christian-byrne wants to merge 1 commit into
Conversation
Backport of #18074 to cloud/1.54. Defers promoted-widget demotion by a microtask (cancelled by a same-tick reconnect) so rewiring the interior link behind one promoted widget no longer drops it from hostNode.widgets. Backport adaptations: - src/composables/graph/useErrorClearingHooks.test.ts: dropped the 'retires an absorbed promoted media error when its host is deleted' case from the picked hunk. It was added on main by an unbackported PR and is not present on this branch; only the async/await change #18074 makes to the surviving case is applied. - src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts: added LegacyWidget to the existing '@/lib/litegraph/src/litegraph' value import. main's copy of this file already imported it for other cases that do not exist on this branch; the new rewire-desync test needs it. (cherry picked from commit 9ee67cb)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
No action taken on this one — it's a status notice, not a finding. CodeRabbit skipped because Worth flagging for whoever picks this up, since the usual automated pass didn't run: this carrier is a faithful cherry-pick of #18074, but the payload carries two defects inherited from upstream (ordering inversion at Human review still needed here; the skip shouldn't be read as a clean bill of health. |
🎭 Playwright: ✅ 1984 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T10:44:13.533Z",
"gitSha": "06deb0ea224d8fc3d53c56b8b6aebfa61ba79cac",
"branch": "glary/backport-carrier-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2092.090999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.067,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.0740000000001,
"heapDeltaBytes": -5357192,
"heapUsedBytes": 65313344,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.977000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2084.171999999967,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.9319999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.351,
"heapDeltaBytes": 9741652,
"heapUsedBytes": 80689024,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.469999999999999,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1900.2630000000522,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.037,
"layouts": 14,
"layoutDurationMs": 4.123,
"taskDurationMs": 919.173,
"heapDeltaBytes": 6405000,
"heapUsedBytes": 76852792,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 165.102,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2058.983000000012,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.70399999999999,
"layouts": 14,
"layoutDurationMs": 4.554,
"taskDurationMs": 1061.079,
"heapDeltaBytes": -6841624,
"heapUsedBytes": 63551876,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 178.307,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.9689999999878,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.886999999999999,
"layouts": 6,
"layoutDurationMs": 1.258,
"taskDurationMs": 422.71000000000004,
"heapDeltaBytes": 4694512,
"heapUsedBytes": 75873260,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.717000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.5779999999904,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.337,
"layouts": 6,
"layoutDurationMs": 1.3699999999999999,
"taskDurationMs": 366.799,
"heapDeltaBytes": 4517636,
"heapUsedBytes": 75913668,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.649999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 818.8879999999585,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.501,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.715,
"heapDeltaBytes": -7397836,
"heapUsedBytes": 63267264,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 192.661,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 806.8640000000187,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.831000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.3140000000001,
"heapDeltaBytes": -6834648,
"heapUsedBytes": 63274692,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 196.417,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.895000000021,
"styleRecalcs": 4,
"styleRecalcDurationMs": 7.064000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 682.221,
"heapDeltaBytes": 7093948,
"heapUsedBytes": 83588412,
"domNodes": -282,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 33.910999999999994,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2047.4520000000211,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.7360000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.7840000000001,
"heapDeltaBytes": 10496712,
"heapUsedBytes": 86938792,
"domNodes": -272,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 33.44899999999999,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3008.376999999996,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.209,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1881.7279999999998,
"heapDeltaBytes": 16370932,
"heapUsedBytes": 94401252,
"domNodes": -278,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 975.3279999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3081.5109999999777,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.468000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1913.318,
"heapDeltaBytes": 3319816,
"heapUsedBytes": 80951792,
"domNodes": -292,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 954.4580000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 4107.202000000029,
"styleRecalcs": 60,
"styleRecalcDurationMs": 13.152000000000001,
"layouts": 60,
"layoutDurationMs": 16.409,
"taskDurationMs": 2096.3059999999996,
"heapDeltaBytes": 10179144,
"heapUsedBytes": 76661364,
"domNodes": -280,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 976.288,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3724.034999999958,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.318000000000001,
"layouts": 60,
"layoutDurationMs": 12.859,
"taskDurationMs": 1715.0979999999997,
"heapDeltaBytes": 9800656,
"heapUsedBytes": 77062368,
"domNodes": -281,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 794.712,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3515.053000000023,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.703,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2227.0450000000005,
"heapDeltaBytes": 31893128,
"heapUsedBytes": 100119976,
"domNodes": 0,
"jsHeapTotalBytes": 3301376,
"scriptDurationMs": 1131.414,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3483.3489999999756,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.196,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2265.1189999999997,
"heapDeltaBytes": 33229592,
"heapUsedBytes": 101293088,
"domNodes": 0,
"jsHeapTotalBytes": 4087808,
"scriptDurationMs": 1162.39,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2078.5769999999957,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.287000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.4699999999999,
"heapDeltaBytes": 6870284,
"heapUsedBytes": 86289172,
"domNodes": -279,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 36.079000000000015,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.902999999962,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.2390000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.0679999999999,
"heapDeltaBytes": 10304424,
"heapUsedBytes": 87925860,
"domNodes": -277,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 30.02199999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 752.2369999999796,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.699,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.412,
"heapDeltaBytes": 15470796,
"heapUsedBytes": 88933788,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 171.934,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.1779999999771,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.521000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.85299999999995,
"heapDeltaBytes": 14710184,
"heapUsedBytes": 88257448,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 156.605,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.787999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.697000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.571,
"heapDeltaBytes": 6339608,
"heapUsedBytes": 79770168,
"domNodes": -300,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.225000000000002,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2017.8200000000288,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.1179999999999,
"heapDeltaBytes": -9244088,
"heapUsedBytes": 63510324,
"domNodes": -298,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.188,
"eventListeners": -244,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.6149999999875,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.014000000000003,
"layouts": 18,
"layoutDurationMs": 5.218999999999999,
"taskDurationMs": 921.5519999999999,
"heapDeltaBytes": 9605000,
"heapUsedBytes": 82868436,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 117.218,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1908.4739999999556,
"styleRecalcs": 81,
"styleRecalcDurationMs": 32.821000000000005,
"layouts": 18,
"layoutDurationMs": 5.731,
"taskDurationMs": 1038.934,
"heapDeltaBytes": 1029600,
"heapUsedBytes": 74489424,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 128.84,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.3829999999725,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.186,
"layouts": 14,
"layoutDurationMs": 15.923000000000004,
"taskDurationMs": 967.1750000000001,
"heapDeltaBytes": -5294552,
"heapUsedBytes": 89191660,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 36.927,
"eventListeners": 2387,
"totalBlockingTimeMs": 152,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11828.98499999999,
"styleRecalcs": 245,
"styleRecalcDurationMs": 47.803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7380.022000000001,
"heapDeltaBytes": -8984224,
"heapUsedBytes": 68038748,
"domNodes": -273,
"jsHeapTotalBytes": 421888,
"scriptDurationMs": 3570.965,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8899.490000000014,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6182.711,
"heapDeltaBytes": 14105152,
"heapUsedBytes": 90724280,
"domNodes": -270,
"jsHeapTotalBytes": -172032,
"scriptDurationMs": 2913.335,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19316.395999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18592.242,
"heapDeltaBytes": -56131320,
"heapUsedBytes": 179170276,
"domNodes": -8068,
"jsHeapTotalBytes": -15421440,
"scriptDurationMs": 323.53200000000004,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17846.670000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17148.937,
"heapDeltaBytes": -46217944,
"heapUsedBytes": 182161180,
"domNodes": -8068,
"jsHeapTotalBytes": -14368768,
"scriptDurationMs": 303.257,
"eventListeners": -14927,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 27184.395999999993,
"styleRecalcs": 182,
"styleRecalcDurationMs": 27.48999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26920.824,
"heapDeltaBytes": -56399752,
"heapUsedBytes": 171514396,
"domNodes": -8068,
"jsHeapTotalBytes": -14553088,
"scriptDurationMs": 1252.327,
"eventListeners": -14927,
"totalBlockingTimeMs": 399,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23725.327000000107,
"styleRecalcs": 180,
"styleRecalcDurationMs": 23.668999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23458.036,
"heapDeltaBytes": -38532056,
"heapUsedBytes": 180066204,
"domNodes": -8068,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 1103.001,
"eventListeners": -14925,
"totalBlockingTimeMs": 138,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 7205.89000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.55499999999999,
"layouts": 20,
"layoutDurationMs": 26.636000000000006,
"taskDurationMs": 7137.649,
"heapDeltaBytes": -46544188,
"heapUsedBytes": 176867364,
"domNodes": -8068,
"jsHeapTotalBytes": 8790016,
"scriptDurationMs": 136.45899999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 612,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6341.182000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.82000000000001,
"layouts": 20,
"layoutDurationMs": 23.575999999999986,
"taskDurationMs": 6232.14,
"heapDeltaBytes": -40598264,
"heapUsedBytes": 177614000,
"domNodes": -8068,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 120.226,
"eventListeners": -14931,
"totalBlockingTimeMs": 431,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9097.072000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8805.04,
"heapDeltaBytes": 21173384,
"heapUsedBytes": 177740008,
"domNodes": 0,
"jsHeapTotalBytes": -8912896,
"scriptDurationMs": 155.86100000000002,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8818.779000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8498.589,
"heapDeltaBytes": -1883240,
"heapUsedBytes": 180281292,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 163.659,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 522.7150000000051,
"styleRecalcs": 13,
"styleRecalcDurationMs": 26.697000000000003,
"layouts": 3,
"layoutDurationMs": 1.8030000000000002,
"taskDurationMs": 151.58400000000003,
"heapDeltaBytes": 4982856,
"heapUsedBytes": 74360196,
"domNodes": 143,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.853000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 463.74200000002475,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.817,
"layouts": 2,
"layoutDurationMs": 1.1099999999999999,
"taskDurationMs": 119.287,
"heapDeltaBytes": 5030696,
"heapUsedBytes": 73583636,
"domNodes": 146,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.312,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
No action taken — this is a status notice, not a finding. CodeRabbit skipped because Since the usual automated pass didn't run, flagging for whoever picks this up: the cherry-pick itself is faithful to #18074 and verified green ( Human review still needed; the skip shouldn't be read as a clean bill of health. |
|
Correction to my comment above: it says this PR is titled Everything else in it stands and applies equally to this PR: the CodeRabbit skip is deliberate repo policy ( #19743 now has its own copy of the note. |
|
Cleanup of my own comment noise on this PR — apologies, three of the comments above are mine and two of them were meant for #19743. What happened: my commenting tool targets the most recently created PR in my session (#19744), not the branch I have checked out. I assumed it resolved by branch, so two notes written for the Also correcting myself: my previous comment claimed "#19743 now has its own copy of the note". That is not true — #19743 has none of these comments, and I can't reach it from this session. Sorry for the misinformation. Net state, to be unambiguous:
No code changed for any of this; it was comment routing only. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19744 +/- ##
=============================================
Coverage ? 84.01%
=============================================
Files ? 2122
Lines ? 127088
Branches ? 34403
=============================================
Hits ? 106771
Misses ? 20138
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Closing because the core/cloud 1.54 trains are retired as of 2026-10-09. Any still-applicable change should be carried to the current 1.55 and 1.56 targets instead. |
|
Acknowledged. I'm leaving this closed and won't push any more changes to this branch. This PR carried one change: #18074 (fix: keep promoted subgraph widgets present across a rewire). Here is where that fix stands on the current targets:
I haven't opened any 1.55 PRs from this thread. If you want me to do that, let me know. |
|
Acknowledged. I'm leaving this closed and won't push any more changes to this branch. This PR carried one change, a cherry-pick of #18074 (fix: keep promoted subgraph widgets present across a rewire). Here is where that fix stands on the current targets:
The same applies to the core twin, #19744's sibling #19743. I haven't opened any 1.55 PRs from this thread. If you want me to do that, let me know. |
PR Created by the Glary-Bot Agent
Carrier backport onto
cloud/1.54, from the v1.56.2 backport-status report. Sibling of #19743 (core/1.54); both carriers resolved identically.What's carried
fix: keep promoted subgraph widgets present across a rewire(fix: keep promoted subgraph widgets present across a rewire #18074), cherry-picked from9ee67cb17b.Only one of the four PRs flagged Need backport in that report is cherry-pickable today — see "Not carried" below.
Backport adaptations
Two test-only conflicts; the fix itself (
SubgraphNode.ts,interfaces.ts) applied cleanly.src/composables/graph/useErrorClearingHooks.test.ts— dropped theretires an absorbed promoted media error when its host is deletedcase from the picked hunk. It was added onmainby an unbackported PR and does not exist on this branch; only fix: keep promoted subgraph widgets present across a rewire #18074's ownasync/await Promise.resolve()change to the surviving case is applied.src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts— addedLegacyWidgetto the existing@/lib/litegraph/src/litegraphvalue import.main's copy already imported it for cases that do not exist on this branch; the new rewire-desync test needs it.No other deviation from upstream.
Validation
pnpm typecheck— exit 0pnpm test:unit src/lib/litegraph/src/subgraph/ src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts src/renderer/.../multilineTextarea.promoted.test.ts src/core/graph/subgraph/— 561/561 passing, 32 filespnpm exec eslint <7 changed files>— 0 errors (6import-x/no-restricted-pathswarnings, test-only, identical to upstream)pnpm exec oxfmt --check— cleanThe two e2e specs in this pick were not run here: they need a live ComfyUI backend and a browser harness that is not available in this environment. They ran green on upstream CI (run 35419314544).
Blocking: two defects inherited from upstream #18074
Both are in the payload, byte-identical to
main, and already shipped inv1.56.2. They are not introduced by this backport, and deliberately not patched here — fixing them only on the release line would diverge it frommain. Flagging so the call is explicit before this merges. Full detail in #19743; summary:1.
SubgraphNode.ts:359-366— store cleanup suppressed by an ordering inversion. The deferred demotion evaluatesif (id && !this.inputs.some((i) => i.widgetId === id))before clearinginput.widgetId. Pre-#18074 the clear was synchronous and the check ran later, so the predicate asked "does some other surviving input still claim this id?". Now the input's own un-clearedwidgetIdmatches anddeleteWidget(id)never fires where the host input survives. The resulting retention is load-bearing for the flipped #14495 e2e case, so a bare reorder reintroduces #14495.2.
SubgraphNode.ts:316-317— demotion cancelled by a reconnect carrying no widget.input._pendingDemotionToken = undefinedruns before theif (!e.detail.widget || !e.detail.node) returnguard, so a widgetlessinput-connected(dispatched bySubgraphInput.connect()when the newly connected interior input has no widget) cancels the demotion without calling_setWidget— leaving stalewidgetId/widget/_widgetand the row still inhostNode.widgets. Persists and serialises.Suggested order: fix both on
main, then re-cut both carriers from the corrected commit.Also noted
#18074 makes a disconnect observable on
hostNode.widgetsone microtask later than before.AGENTS.mdflagsnode.widgetsas affecting 40+ custom-node repos. The exposure is identical onmain, so no backport-only shim was added — recording the decision per the backport skill.Not carried (blocked on unbackported prerequisites)
readyThreadId/threadStorageKeyfrom #18866;turnStartedAtfrom #18665; on the 1.54 pair alsohydratedTurnIdsfrom #18152, whose backports #19696/#19697 are still opentargetUnavailable/markWorkflowTargetUnavailablefrom #18866renewalInvoiceonuseBillingContext,pausedView/safeInvoiceUrl/payInvoiceUrlfrom #19435