Repository navigation
[backport core/1.54] carrier: keep promoted subgraph widgets present across a rewire (#18074) - #19743
christian-byrne wants to merge 1 commit into
Conversation
Backport of #18074 to core/1.54. Defers promoted-widget demotion by a microtask (cancelled by a same-tick reconnect) so rewiring the interior link behind one promoted widget no longer drops it from hostNode.widgets. Backport adaptations: - src/composables/graph/useErrorClearingHooks.test.ts: dropped the 'retires an absorbed promoted media error when its host is deleted' case from the picked hunk. It was added on main by an unbackported PR and is not present on this branch; only the async/await change #18074 makes to the surviving case is applied. - src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts: added LegacyWidget to the existing '@/lib/litegraph/src/litegraph' value import. main's copy of this file already imported it for other cases that do not exist on this branch; the new rewire-desync test needs it. (cherry picked from commit 9ee67cb)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1982 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T10:42:44.459Z",
"gitSha": "b5e840211c633176684468ca579f7fb75a4aef97",
"branch": "glary/backport-carrier-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2119.1460000000006,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.115,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.006,
"heapDeltaBytes": 8244720,
"heapUsedBytes": 78499032,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.588999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.144000000041,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.700999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.83,
"heapDeltaBytes": -11275888,
"heapUsedBytes": 58390856,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 13.312000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2102.732999999944,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.789,
"layouts": 14,
"layoutDurationMs": 4.678,
"taskDurationMs": 1105.5980000000002,
"heapDeltaBytes": 13013608,
"heapUsedBytes": 84235200,
"domNodes": -282,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 208.476,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1900.0539999999546,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.685,
"layouts": 14,
"layoutDurationMs": 4.542999999999999,
"taskDurationMs": 995.9419999999999,
"heapDeltaBytes": 11594860,
"heapUsedBytes": 82490820,
"domNodes": -280,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 176.96300000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1600000000171,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.008999999999997,
"layouts": 6,
"layoutDurationMs": 1.2640000000000002,
"taskDurationMs": 424.379,
"heapDeltaBytes": 4630552,
"heapUsedBytes": 75602816,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.716999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.8859999999368,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.995,
"layouts": 6,
"layoutDurationMs": 1.1070000000000002,
"taskDurationMs": 446.893,
"heapDeltaBytes": 4825960,
"heapUsedBytes": 76131260,
"domNodes": 72,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.334,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 710.6519999999819,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.808000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.571,
"heapDeltaBytes": -7533372,
"heapUsedBytes": 63167872,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 167.272,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 744.2190000000437,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.031,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.62600000000003,
"heapDeltaBytes": 18686256,
"heapUsedBytes": 88882120,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 176.081,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2063.725999999974,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.596000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.7209999999999,
"heapDeltaBytes": 5421044,
"heapUsedBytes": 82080804,
"domNodes": -281,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 35.602999999999994,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.6930000000048,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.2029999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 784.707,
"heapDeltaBytes": 10630272,
"heapUsedBytes": 87172380,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 42.849,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2450.951000000032,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.777000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1773.036,
"heapDeltaBytes": 12749128,
"heapUsedBytes": 89555900,
"domNodes": -272,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 849.3000000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3110.157000000072,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.707999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.734,
"heapDeltaBytes": 27372668,
"heapUsedBytes": 93341828,
"domNodes": -11,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 945.1350000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3877.8200000000425,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.277000000000001,
"layouts": 60,
"layoutDurationMs": 12.283999999999999,
"taskDurationMs": 1846.0810000000001,
"heapDeltaBytes": 8450564,
"heapUsedBytes": 75900816,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 835.3689999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4039.1270000000077,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.010999999999996,
"layouts": 60,
"layoutDurationMs": 13.211999999999998,
"taskDurationMs": 2002.801,
"heapDeltaBytes": 14142520,
"heapUsedBytes": 92386840,
"domNodes": -288,
"jsHeapTotalBytes": 2781184,
"scriptDurationMs": 865.749,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3206.7030000000614,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.816,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2102.68,
"heapDeltaBytes": 12240,
"heapUsedBytes": 80249572,
"domNodes": -290,
"jsHeapTotalBytes": 4247552,
"scriptDurationMs": 1015.531,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3142.19300000002,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.672,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2083.48,
"heapDeltaBytes": 24689044,
"heapUsedBytes": 92350128,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1025.2379999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2024.6700000000146,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.222,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.607,
"heapDeltaBytes": 9694216,
"heapUsedBytes": 87839488,
"domNodes": -271,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 32.80799999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.1969999999483,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.974,
"heapDeltaBytes": 21779844,
"heapUsedBytes": 88654528,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 45.09800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.0060000000794,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.736999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.199,
"heapDeltaBytes": 15059744,
"heapUsedBytes": 88341684,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.54500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 677.8089999999111,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.354000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.40900000000005,
"heapDeltaBytes": 14256544,
"heapUsedBytes": 86824000,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.971,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.5369999999666,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.937,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.086,
"heapDeltaBytes": -15108476,
"heapUsedBytes": 58120292,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.850999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2032.7219999999215,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.868,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.21,
"heapDeltaBytes": -3141472,
"heapUsedBytes": 69468704,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.903,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.5329999999894,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.879,
"layouts": 18,
"layoutDurationMs": 5.118,
"taskDurationMs": 896.371,
"heapDeltaBytes": -9481216,
"heapUsedBytes": 63056248,
"domNodes": -294,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 117.501,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1804.004999999961,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.104,
"layouts": 18,
"layoutDurationMs": 5.162,
"taskDurationMs": 926.6460000000001,
"heapDeltaBytes": 9989088,
"heapUsedBytes": 83275352,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 127.17299999999997,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.2069999999012,
"styleRecalcs": 18,
"styleRecalcDurationMs": 35.19799999999999,
"layouts": 14,
"layoutDurationMs": 16.731,
"taskDurationMs": 1078.0529999999999,
"heapDeltaBytes": 21688056,
"heapUsedBytes": 107001860,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 36.946000000000005,
"eventListeners": 2387,
"totalBlockingTimeMs": 168,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9181.590999999913,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.492,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6217.9619999999995,
"heapDeltaBytes": 1030960,
"heapUsedBytes": 76728436,
"domNodes": -283,
"jsHeapTotalBytes": 90112,
"scriptDurationMs": 2794.39,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11129.672999999912,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.396,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7008.307,
"heapDeltaBytes": 30498632,
"heapUsedBytes": 107369540,
"domNodes": -270,
"jsHeapTotalBytes": 2711552,
"scriptDurationMs": 3318.482,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17967.049999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17251.843,
"heapDeltaBytes": -56746152,
"heapUsedBytes": 182340580,
"domNodes": -8068,
"jsHeapTotalBytes": -13570048,
"scriptDurationMs": 306.404,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18367.963000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17611.945000000003,
"heapDeltaBytes": -36801596,
"heapUsedBytes": 182302564,
"domNodes": -8068,
"jsHeapTotalBytes": -6086656,
"scriptDurationMs": 305.91999999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22149.581000000013,
"styleRecalcs": 167,
"styleRecalcDurationMs": 23.050000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21825.376,
"heapDeltaBytes": -43331888,
"heapUsedBytes": 183542432,
"domNodes": -8068,
"jsHeapTotalBytes": -17453056,
"scriptDurationMs": 968.516,
"eventListeners": -14925,
"totalBlockingTimeMs": 133,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22800.118,
"styleRecalcs": 175,
"styleRecalcDurationMs": 25.233000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22532.587,
"heapDeltaBytes": -45940424,
"heapUsedBytes": 180455436,
"domNodes": -8068,
"jsHeapTotalBytes": -16732160,
"scriptDurationMs": 1021.914,
"eventListeners": -14931,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6422.182000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.32000000000001,
"layouts": 20,
"layoutDurationMs": 24.444000000000006,
"taskDurationMs": 6295.420999999999,
"heapDeltaBytes": -50206340,
"heapUsedBytes": 185927012,
"domNodes": -3070,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 158.04999999999995,
"eventListeners": -14925,
"totalBlockingTimeMs": 448,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6626.427000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.60200000000002,
"layouts": 20,
"layoutDurationMs": 32.583,
"taskDurationMs": 6542.812,
"heapDeltaBytes": -39954828,
"heapUsedBytes": 178010916,
"domNodes": -8068,
"jsHeapTotalBytes": 11476992,
"scriptDurationMs": 149.214,
"eventListeners": -14931,
"totalBlockingTimeMs": 657,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9140.218000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8919.181999999999,
"heapDeltaBytes": 1993220,
"heapUsedBytes": 178497432,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 224.306,
"eventListeners": -13,
"totalBlockingTimeMs": 12,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9207.74999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8956.652000000002,
"heapDeltaBytes": -5645736,
"heapUsedBytes": 165040372,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 188.662,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 465.96199999999044,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.751,
"layouts": 3,
"layoutDurationMs": 1.509,
"taskDurationMs": 114.529,
"heapDeltaBytes": 4900156,
"heapUsedBytes": 73870088,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.992,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 106.16800000002513,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.730999999999998,
"layouts": 2,
"layoutDurationMs": 0.776,
"taskDurationMs": 75.18900000000001,
"heapDeltaBytes": 3009836,
"heapUsedBytes": 72338696,
"domNodes": 106,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 5.124999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19743 +/- ##
============================================
Coverage 84.17% 84.17%
============================================
Files 2113 2113
Lines 126608 126613 +5
Branches 32190 34060 +1870
============================================
+ Hits 106568 106575 +7
+ Misses 19854 19852 -2
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing because the core/cloud 1.54 trains are retired as of 2026-10-09. Any still-applicable change should be carried to the current 1.55 and 1.56 targets instead. |
PR Created by the Glary-Bot Agent
Carrier backport onto
core/1.54, from the v1.56.2 backport-status report.What's carried
fix: keep promoted subgraph widgets present across a rewire(fix: keep promoted subgraph widgets present across a rewire #18074), cherry-picked from9ee67cb17b.Only one of the four PRs flagged Need backport in that report is cherry-pickable today — see "Not carried" below.
Backport adaptations
Two test-only conflicts; the fix itself (
SubgraphNode.ts,interfaces.ts) applied cleanly.src/composables/graph/useErrorClearingHooks.test.ts— dropped theretires an absorbed promoted media error when its host is deletedcase from the picked hunk. It was added onmainby an unbackported PR and does not exist on this branch; only fix: keep promoted subgraph widgets present across a rewire #18074's ownasync/await Promise.resolve()change to the surviving case is applied.src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts— addedLegacyWidgetto the existing@/lib/litegraph/src/litegraphvalue import.main's copy already imported it for cases that do not exist on this branch; the new rewire-desync test needs it.No other deviation from upstream. The
core/1.54andcloud/1.54carriers resolved identically.Validation
pnpm typecheck— exit 0pnpm test:unit src/lib/litegraph/src/subgraph/ src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts src/renderer/.../multilineTextarea.promoted.test.ts src/core/graph/subgraph/— 561/561 passing, 32 filespnpm exec eslint <7 changed files>— 0 errors (6import-x/no-restricted-pathswarnings, test-only, identical to upstream)pnpm exec oxfmt --check— cleanThe two e2e specs in this pick were not run here: they need a live ComfyUI backend and a browser harness that is not available in this environment. They ran green on upstream CI (run 35419314544).
Blocking: two defects inherited from upstream #18074
Both are in the payload, byte-identical to
main, and already shipped inv1.56.2. They are not introduced by this backport, and deliberately not patched here — fixing them only on the release line would diverge it frommain. Flagging so the call is explicit before this merges.1.
SubgraphNode.ts:359-366— store cleanup suppressed by an ordering inversion. The deferred demotion evaluatesif (id && !this.inputs.some((i) => i.widgetId === id))before clearinginput.widgetId. Pre-#18074,input.widgetId = undefinedran synchronously and the.some()check ran later in the microtask, so the predicate asked "does some other surviving input still claim this id?". Collapsing both into one microtask inverted that: where the host input survives demotion,.some()now matches the input's own un-clearedwidgetIdand thedeleteWidget(id)never fires, leaking entries for the session.Note the retention is load-bearing:
widgetIdis deterministic (graphId:nodeId:name), so a leaked entry is recovered verbatim on re-promotion, and that is what makes the flipped #14495 e2e case pass. Simply reordering the assignments reintroduces #14495 — the retention needs to be made explicit and intentional, not just reordered.2.
SubgraphNode.ts:316-317— demotion cancelled by a reconnect carrying no widget.input._pendingDemotionToken = undefinedruns before theif (!e.detail.widget || !e.detail.node) returnguard.SubgraphInput.connect()dispatchesinput-connectedwith nowidget/nodewhenever the newly connected interior input has no widget, so on that path the demotion is cancelled but_setWidgetis never called — leavingwidgetId/widget/_widgetpointing at the just-disconnected widget, with the row still inhostNode.widgets. The state persists and serialises; pre-#18074 the synchronous demotion had already torn it down. The new unit test only rewires widget-to-widget, so it cannot catch this.Suggested order: fix both on
main, then re-cut this carrier from the corrected commit.Also noted
#18074 makes a disconnect observable on
hostNode.widgetsone microtask later than before (previously synchronous).AGENTS.mdflagsnode.widgetsas affecting 40+ custom-node repos. The exposure is identical onmain, so it is not release-branch-specific and no backport-only shim was added — recording the decision here per the backport skill.Not carried (blocked on unbackported prerequisites)
The other three PRs flagged Need backport in the v1.56.2 report cannot be cherry-picked yet; each references machinery that does not exist on its target branch.
readyThreadId/threadStorageKeyfrom #18866;turnStartedAtfrom #18665; on the 1.54 pair alsohydratedTurnIdsfrom #18152, whose backports #19696/#19697 are still opentargetUnavailable/markWorkflowTargetUnavailablefrom #18866renewalInvoiceonuseBillingContext,pausedView/safeInvoiceUrl/payInvoiceUrlfrom #19435