Repository navigation
[backport core/1.54] fix: keep promoted subgraph widgets present across a rewire (#18074) - #19749
christian-byrne wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1982 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T12:14:37.432Z",
"gitSha": "8492782596a1e73fedb2fc4645f019b18c55ab86",
"branch": "glary/carrier-backport-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2112.932999999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.9190000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.87,
"heapDeltaBytes": -9648860,
"heapUsedBytes": 60611756,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.6,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2072.056000000032,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.691,
"heapDeltaBytes": 11172820,
"heapUsedBytes": 81987168,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.719999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.6960000000327,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.691,
"layouts": 14,
"layoutDurationMs": 4.268,
"taskDurationMs": 902.9099999999999,
"heapDeltaBytes": -11987748,
"heapUsedBytes": 59153800,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 163.52,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1951.6179999999963,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.037,
"layouts": 14,
"layoutDurationMs": 4.5729999999999995,
"taskDurationMs": 969.8979999999999,
"heapDeltaBytes": -3842796,
"heapUsedBytes": 66965496,
"domNodes": -283,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 175.08599999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2470000000108,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.535999999999998,
"layouts": 6,
"layoutDurationMs": 1.1320000000000001,
"taskDurationMs": 371.339,
"heapDeltaBytes": 4329880,
"heapUsedBytes": 74657288,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.469999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.4360000000688,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.675000000000004,
"layouts": 6,
"layoutDurationMs": 1.2239999999999998,
"taskDurationMs": 406.95,
"heapDeltaBytes": 4559368,
"heapUsedBytes": 75880804,
"domNodes": 74,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.606000000000003,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 719.68099999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.128999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.819,
"heapDeltaBytes": -7584976,
"heapUsedBytes": 63381816,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 170.186,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 705.8819999999741,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.534,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.001,
"heapDeltaBytes": 18339792,
"heapUsedBytes": 88850568,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 163.99800000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2077.2650000000112,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.58,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.113,
"heapDeltaBytes": 10320900,
"heapUsedBytes": 86910076,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 35.117999999999995,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.382000000055,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.928000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.0140000000001,
"heapDeltaBytes": 10361728,
"heapUsedBytes": 86774208,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 37.517999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2432.298000000003,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.528000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1732.903,
"heapDeltaBytes": 1819180,
"heapUsedBytes": 79558332,
"domNodes": -286,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 852.884,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2789.8400000000265,
"styleRecalcs": 67,
"styleRecalcDurationMs": 18.075999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1875.4309999999998,
"heapDeltaBytes": 11820044,
"heapUsedBytes": 88925880,
"domNodes": -243,
"jsHeapTotalBytes": 1171456,
"scriptDurationMs": 893.405,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3702.7610000000095,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.067000000000002,
"layouts": 60,
"layoutDurationMs": 12.749,
"taskDurationMs": 1823.406,
"heapDeltaBytes": -2326820,
"heapUsedBytes": 75996020,
"domNodes": -290,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 803.1270000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3786.2270000000535,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.612,
"layouts": 60,
"layoutDurationMs": 13.104000000000001,
"taskDurationMs": 1840.4059999999997,
"heapDeltaBytes": 10599240,
"heapUsedBytes": 77648792,
"domNodes": -280,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 835.312,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3097.6689999999962,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2008.0489999999998,
"heapDeltaBytes": 21774080,
"heapUsedBytes": 90355048,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1013.416,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3228.0830000000833,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2148.8889999999997,
"heapDeltaBytes": -873580,
"heapUsedBytes": 69264616,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1078.435,
"eventListeners": 190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2044.70299999997,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.945000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.96,
"heapDeltaBytes": 10029620,
"heapUsedBytes": 87694384,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 39.506,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2029.826000000071,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7240000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.327,
"heapDeltaBytes": 9907668,
"heapUsedBytes": 88275864,
"domNodes": -270,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 36.858000000000004,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.080000000049,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.149000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.81800000000004,
"heapDeltaBytes": 14666188,
"heapUsedBytes": 87926068,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 151.752,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.5829999999924,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.520999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.951,
"heapDeltaBytes": 15007404,
"heapUsedBytes": 87235072,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 146.55599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2013.6430000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.989000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.99100000000004,
"heapDeltaBytes": -579436,
"heapUsedBytes": 71711568,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.150999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.5729999999894,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.201,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.5160000000001,
"heapDeltaBytes": -9149964,
"heapUsedBytes": 63454772,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.874000000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1777.971999999977,
"styleRecalcs": 80,
"styleRecalcDurationMs": 32.7,
"layouts": 18,
"layoutDurationMs": 5.143,
"taskDurationMs": 877.432,
"heapDeltaBytes": -889764,
"heapUsedBytes": 72090284,
"domNodes": -299,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 118.051,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1784.4559999999774,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.933999999999997,
"layouts": 18,
"layoutDurationMs": 5.378000000000001,
"taskDurationMs": 914.551,
"heapDeltaBytes": -2179832,
"heapUsedBytes": 70422860,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 125.78299999999997,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1432.916999999975,
"styleRecalcs": 17,
"styleRecalcDurationMs": 33.89399999999999,
"layouts": 13,
"layoutDurationMs": 16.313,
"taskDurationMs": 997.539,
"heapDeltaBytes": 22166016,
"heapUsedBytes": 105967428,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 34.74,
"eventListeners": 2387,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8771.239999999978,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6145.412,
"heapDeltaBytes": 24285000,
"heapUsedBytes": 100425804,
"domNodes": -281,
"jsHeapTotalBytes": 1925120,
"scriptDurationMs": 2855.485,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9369.049000000017,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6309.449,
"heapDeltaBytes": 13163584,
"heapUsedBytes": 89748356,
"domNodes": -270,
"jsHeapTotalBytes": -1220608,
"scriptDurationMs": 2812.849,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17839.59200000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17199.149999999998,
"heapDeltaBytes": -46962816,
"heapUsedBytes": 177055376,
"domNodes": -8068,
"jsHeapTotalBytes": -14163968,
"scriptDurationMs": 329.86400000000003,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18382.097000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17646.255999999998,
"heapDeltaBytes": -45378216,
"heapUsedBytes": 166994912,
"domNodes": -8068,
"jsHeapTotalBytes": -6828032,
"scriptDurationMs": 307.438,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22229.738999999994,
"styleRecalcs": 174,
"styleRecalcDurationMs": 22.10200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21965.214000000004,
"heapDeltaBytes": -33470416,
"heapUsedBytes": 179554084,
"domNodes": -8068,
"jsHeapTotalBytes": -12333056,
"scriptDurationMs": 957.136,
"eventListeners": -14929,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 21846.89900000001,
"styleRecalcs": 166,
"styleRecalcDurationMs": 20.321000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21493.757,
"heapDeltaBytes": -53267516,
"heapUsedBytes": 165777444,
"domNodes": -8068,
"jsHeapTotalBytes": -11591680,
"scriptDurationMs": 950.3610000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 53,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6371.355999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 102.59200000000001,
"layouts": 20,
"layoutDurationMs": 29.532000000000018,
"taskDurationMs": 6267.8859999999995,
"heapDeltaBytes": -40810096,
"heapUsedBytes": 178146164,
"domNodes": -8068,
"jsHeapTotalBytes": 9146368,
"scriptDurationMs": 140.79600000000002,
"eventListeners": -14927,
"totalBlockingTimeMs": 623,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6522.718999999938,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.19699999999996,
"layouts": 20,
"layoutDurationMs": 24.075999999999986,
"taskDurationMs": 6410.154,
"heapDeltaBytes": -62157680,
"heapUsedBytes": 177229620,
"domNodes": -8068,
"jsHeapTotalBytes": 5341184,
"scriptDurationMs": 117.10500000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 425,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9069.944000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8780.414999999999,
"heapDeltaBytes": -527728,
"heapUsedBytes": 179922600,
"domNodes": 0,
"jsHeapTotalBytes": -22544384,
"scriptDurationMs": 147.81100000000004,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9156.459999999925,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8823.687,
"heapDeltaBytes": 10706404,
"heapUsedBytes": 179440608,
"domNodes": 0,
"jsHeapTotalBytes": -21495808,
"scriptDurationMs": 155.84600000000003,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 461.5490000000477,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.632,
"layouts": 3,
"layoutDurationMs": 0.9209999999999999,
"taskDurationMs": 109.44500000000001,
"heapDeltaBytes": 4783920,
"heapUsedBytes": 74150184,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.796000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 115.73799999996481,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.965000000000002,
"layouts": 2,
"layoutDurationMs": 0.5550000000000002,
"taskDurationMs": 78.044,
"heapDeltaBytes": 3009444,
"heapUsedBytes": 72356620,
"domNodes": 108,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.3660000000000005,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
No action needed — this is CodeRabbit's "review skipped" status note, not a finding. The skip is intentional: this repo's Coverage for this change:
One thing genuinely still outstanding, flagged in the PR description rather than hidden: this PR flips |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19749 +/- ##
=============================================
+ Coverage 84.17% 84.18% +0.01%
=============================================
Files 2112 2113 +1
Lines 126575 126816 +241
Branches 34051 34124 +73
=============================================
+ Hits 106547 106766 +219
- Misses 19842 19864 +22
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes 🚀 New features to boost your workflow:
|
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- (cherry picked from commit 9ee67cb) ## Backport adaptation (core/1.54) The fix itself (`SubgraphNode.ts`, `interfaces.ts`) cherry-picked clean and is byte-identical to upstream. Only two test files conflicted, both because the cherry-pick's context included neighbouring code that is not on this branch: - `useErrorClearingHooks.test.ts` — the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", which main gained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted" async and await the deferred demotion. - `SubgraphWidgetPromotion.test.ts` — import-only conflict. Accepted the three new imports (`WidgetValue`, `createPromotedMultilineWidget`, `useDomWidgetStore`) required by the new PM-1328 describe block; verified all three modules and symbols exist on this branch. The new block also uses `LegacyWidget`, which main imports from the litegraph barrel in a neighbouring non-conflicting import hunk, so this branch's version of that hunk won and left it out; the test failed with `ReferenceError: LegacyWidget is not defined` until it was added to the barrel import. `LegacyWidget` already exists and is exported from the barrel on this branch. No backport-only compatibility shim was needed and no public API shape or callback signature changed. The deliberate timing change this PR documents (a genuine disconnect becomes observable on `hostNode.widgets` one microtask later) is carried as-is.
9816e98 to
8453d95
Compare
…oss a rewire (#18074) (#19750) *PR Created by the Glary-Bot Agent* --- Manual backport of #18074 to `cloud/1.54`, from the v1.56.2 backport-status report. Companion to #19749 (`core/1.54`). Cherry-picked from upstream merge commit `9ee67cb17b`. Requested in [#frontend-releases](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790847308032919) as a cherry-pick "carrier" backport, one per target branch. #18074 is the only PR the report flags for `cloud/1.54` that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below. ## Why Rewiring the interior link behind one promoted subgraph widget (e.g. dragging a new node onto an already-promoted widget's socket) could drop or visually duplicate the host node's *other* promoted widgets, and make the rewired widget itself disappear. `SubgraphInputNode`'s `'input-disconnected'` handler demoted the widget **synchronously** while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick `hostNode.widgets.length` and the store's tracked id count disagreed — and the Vue widget grid reads its render *order* from the store and its liveness *filter* from `hostNode.widgets`, i.e. from both sides of that disagreement. The fix defers the demotion itself by a microtask with a per-input cancellation token, which `'input-connected'` clears on a same-tick reconnect, so a rewire never drops the widget at all. - Fixes #14495 ## Conflict resolution **The fix itself (`SubgraphNode.ts`, `interfaces.ts`) cherry-picked clean.** `SubgraphNode.ts` differs slightly between `core/1.54` and `cloud/1.54`, but the fix applied cleanly to both and the resulting hunks are identical. Only two test files conflicted — the same two as on #19749, and those two files are **byte-identical between `core/1.54` and `cloud/1.54` at their merge base** (verified by blob hash), so this is the same resolution, reusing the exact same resolved blobs: - **`useErrorClearingHooks.test.ts`** — the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", which `main` gained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted" `async` and `await` the now-deferred demotion. - **`SubgraphWidgetPromotion.test.ts`** — import-only conflict. Accepted the three new imports (`WidgetValue`, `createPromotedMultilineWidget`, `useDomWidgetStore`) required by the new PM-1328 describe block, after verifying all three modules and symbols exist on this branch. The new block also uses `LegacyWidget`, which `main` imports from the litegraph barrel in a *neighbouring non-conflicting* import hunk — so this branch's version won and left it out, failing with `ReferenceError: LegacyWidget is not defined` until it was added to the barrel import. `LegacyWidget` already exists and is exported from the barrel here, so this is an import fix, not new code. No backport-only compatibility shim was needed, and no public API shape or callback signature changed. The deliberate timing change this PR documents — a genuine disconnect becomes observable on `hostNode.widgets` one microtask later — is carried as-is rather than shimmed: the surrounding machinery (`SubgraphInputNode.ts`, `SubgraphInputEventMap.ts`) is byte-identical between this branch and `main`, so a literal cherry-pick cannot recreate the original bug for an old-contract consumer, and deviating would leave this branch running demotion logic `main`'s CI has never exercised. Changed-file set is **exactly** the same 7 files as upstream `9ee67cb17b` — no unrelated drift smuggled in. ## Validation - `pnpm test:unit` on the suites upstream used to validate the fix — **527/527 passing across 24 files** (`src/lib/litegraph/src/subgraph/`, `useErrorClearingHooks.test.ts`, `promotionUtils.test.ts`, `multilineTextarea.promoted.test.ts`, `widgetValueStore.test.ts`, `domWidgetStore.test.ts`). This includes the PR's own regression case, "keeps every promoted widget present while rewiring the interior link behind one of them", which asserts `hostNode.widgets.length` stays at 4 throughout a rewire — i.e. the exact mechanism, proven fixed on this branch. - `pnpm typecheck` — exit 0 - `pnpm exec eslint` on changed files — **0 errors**, 6 warnings, all pre-existing `import-x/no-restricted-paths` on `src/lib/` (upstream carries the same; `pnpm lint` sets no `--max-warnings`) - `pnpm exec oxfmt --check` on changed files — clean ###⚠️ Please let CI run the E2E before merging This PR lands `subgraphPromotedWidgetRewireDuplication.spec.ts` and flips `test.fail()` → `test()` in `subgraphPromotion.spec.ts`. Upstream justified those flips with CI evidence gathered on `main` ([run 35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)); **there is no equivalent evidence for `cloud/1.54` yet**, and the Playwright suite needs a live ComfyUI backend plus a built frontend, which I could not stand up in the sandbox. The unit-level regression above proves the mechanism on this branch, but per `SKILL.md` ("NEVER merge a backport PR without all CI checks passing") the flipped e2e should be confirmed green here before merge. Kept as a draft for that reason. ## Why this carrier holds one commit The report flagged four PRs as "❗ Need backport". Two cannot be carried: - **#19053** ("restore live turn after panel remount", PM-1776) — **not merged.** Only `refs/pull/19053/head` exists; it is 69 commits ahead of `main` with no squash commit, which is why the report listed it without a `(#NNNNN)` suffix. There is nothing to cherry-pick. - **#19240** ("say when the open workflow is deleted") — flagged for `cloud/1.54`, but its **prerequisite is missing.** Its mechanism marks the target unavailable so the in-chat notice from #18866 renders. This branch has the `TargetTracking` model but **no** `markWorkflowTargetUnavailable`/`targetUnavailable` and no `targetWorkflowUnavailable` string — the only "unavailable" path here is an unrelated *toast* fired on navigation failure (`agent.targetNavigationUnavailable`), a different mechanism for a different trigger. Carrying #19240 alone would set a state nothing renders — a silent no-op defeating the fix. It needs #18866 backported first. (Same gap on all four target branches.) #19677 is labelled `core/1.55` + `cloud/1.55` only, so it is not in this branch's scope. Original PR: #18074 / Original commit: `9ee67cb17b` --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
Closing because the core/cloud 1.54 trains are retired as of 2026-10-09. Any still-applicable change should be carried to the current 1.55 and 1.56 targets instead. |
PR Created by the Glary-Bot Agent
Manual backport of #18074 to
core/1.54, from the v1.56.2 backport-status report.Cherry-picked from upstream merge commit
9ee67cb17b.Requested in #frontend-releases as a cherry-pick "carrier" backport, one per target branch. #18074 is the only PR the report flags for
core/1.54that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below.Why
Rewiring the interior link behind one promoted subgraph widget (e.g. dragging a new node onto an already-promoted widget's socket) could drop or visually duplicate the host node's other promoted widgets, and make the rewired widget itself disappear.
SubgraphInputNode's'input-disconnected'handler demoted the widget synchronously while deferring the matchingwidgetValueStorecleanup to aqueueMicrotask. For one tickhostNode.widgets.lengthand the store's tracked id count disagreed — and the Vue widget grid reads its render order from the store and its liveness filter fromhostNode.widgets, i.e. from both sides of that disagreement. The fix defers the demotion itself by a microtask with a per-input cancellation token, which'input-connected'clears on a same-tick reconnect, so a rewire never drops the widget at all.Conflict resolution
The fix itself (
SubgraphNode.ts,interfaces.ts) cherry-picked clean and is byte-identical to upstream. Only two test files conflicted, both because the cherry-pick's context included neighbouring code that is not on this branch:useErrorClearingHooks.test.ts— the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", whichmaingained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted"asyncandawaitthe now-deferred demotion.SubgraphWidgetPromotion.test.ts— import-only conflict. Accepted the three new imports (WidgetValue,createPromotedMultilineWidget,useDomWidgetStore) required by the new PM-1328 describe block, after verifying all three modules and symbols exist on this branch.LegacyWidget, whichmainimports from the litegraph barrel in a neighbouring non-conflicting import hunk — so this branch's version of that hunk won and silently left it out. The suite failed withReferenceError: LegacyWidget is not defineduntil it was added to the barrel import.LegacyWidgetalready exists and is exported from the barrel here, so this is an import fix, not new code.No backport-only compatibility shim was needed, and no public API shape or callback signature changed. The deliberate timing change this PR documents — a genuine disconnect becomes observable on
hostNode.widgetsone microtask later — is carried as-is rather than shimmed, deliberately: the surrounding machinery (SubgraphInputNode.ts,SubgraphInputEventMap.ts) is byte-identical between this branch andmain, so a literal cherry-pick cannot recreate the original bug for an old-contract consumer, and deviating would leave this branch running demotion logicmain's CI has never exercised.Changed-file set is exactly the same 7 files as upstream
9ee67cb17b— no unrelated drift smuggled in.Validation
pnpm test:uniton the suites upstream used to validate the fix — 527/527 passing across 24 files (src/lib/litegraph/src/subgraph/,useErrorClearingHooks.test.ts,promotionUtils.test.ts,multilineTextarea.promoted.test.ts,widgetValueStore.test.ts,domWidgetStore.test.ts). This includes the PR's own regression case, "keeps every promoted widget present while rewiring the interior link behind one of them", which assertshostNode.widgets.lengthstays at 4 throughout a rewire — i.e. the exact mechanism, proven fixed on this branch.pnpm typecheck— exit 0pnpm exec eslinton changed files — 0 errors, 6 warnings, all pre-existingimport-x/no-restricted-pathsonsrc/lib/(baseline on untouchedorigin/core/1.54is 4 of the same; the 2 extra are upstream's own import lines, identical tomain, andpnpm lintsets no--max-warnings)pnpm exec oxfmt --checkon changed files — cleanThis PR lands
subgraphPromotedWidgetRewireDuplication.spec.tsand flipstest.fail()→test()insubgraphPromotion.spec.ts. Upstream justified those flips with CI evidence gathered onmain(run 35419314544); there is no equivalent evidence forcore/1.54yet, and the Playwright suite needs a live ComfyUI backend plus a built frontend, which I could not stand up in the sandbox. The unit-level regression above proves the mechanism on this branch, but perSKILL.md("NEVER merge a backport PR without all CI checks passing") the flipped e2e should be confirmed green here before merge. Kept as a draft for that reason.Why this carrier holds one commit
The report flagged four PRs as "❗ Need backport". Two cannot be carried:
refs/pull/19053/headexists; it is 69 commits ahead ofmainwith no squash commit, which is why the report listed it without a(#NNNNN)suffix. There is nothing to cherry-pick.markWorkflowTargetUnavailable/targetUnavailablenor thetargetWorkflowUnavailablestring exists oncore/1.54,cloud/1.54,core/1.55orcloud/1.55. (cloud/1.54has only an unrelated toast on navigation failure.) Carrying it would set a state nothing renders — a silent no-op defeating the fix. It needs fix(agent): reopen saved workflows from chat history #18866 backported first.#19677 is labelled
core/1.55+cloud/1.55only, so it is not in this branch's scope.Original PR: #18074 / Original commit:
9ee67cb17b