Repository navigation
[backport cloud/1.55] fix(agent): show deleted target workflow state - #19733
Conversation
Selecting an Agent history chat now reopens its saved workflow when the tab is closed. History stays visible until the conversation and workflow are ready, then the selected chat becomes Current. [PM-1640](https://linear.app/comfyorg/issue/PM-1640) - Resolve saved targets through the workflow catalog and reuse known open targets to avoid redundant requests. - Reuse an already loaded Current conversation when returning from history. - Show accessible row loading and retry; preserve navigation across panel remounts and guard superseded workflow opens. - Preserve Current and its persisted session when deleting a different chat that failed to open. Missing/deleted targets, rapid selections, Back, retry, and panel remounts. Graph activation uses the existing serialized loader; cancellation guards run before activation, without adding rollback once activation starts. - Affected unit/component suites pass, covering saved-workflow reopening, cancellation, loading/retry, remounts, and Current identity (two existing expected failures retained). - Full lint, typecheck, Knip, Fallow audit, formatting, and ADR checks passed. - No new Playwright regression: deferred REST/catalog/workflow responses and panel remounts are covered by mounted Root tests using the real session and stores; workflow-service tests cover activation cancellation. These deterministic lower-level boundaries reproduce the failures without another browser fixture duplicating them. Browser/assistive-technology validation was not run at the author’s request; human UX review remains pending.
## Summary
Deleting the saved file of the open chat's target workflow now shows the
existing in-chat notice ("The target workflow is no longer available.")
instead of silently dropping the target.
[PM-1640](https://linear.app/comfyorg/issue/PM-1640)
## Changes
- **What**: The panel store subscribes to
`workflowStore.deleteWorkflow`. When the delete of a saved workflow
finishes and that workflow is still the chat's target, the store marks
the target unavailable, which shows the notice from #18866. A target
whose tab has closed is known by its saved path, which follows renames,
so the store does not keep the closed workflow object. Closing the tab,
or deleting an unsaved target, only clears the target. Deleting another
workflow, deleting after the chat picked another target, and deleting
after the closed target was reopened change nothing. A fresh chat that
follows the visible tab is unaffected.
## Review Focus
- Deletion is detected through the explicit store action (`$onAction`,
as in `mintPortWiring.ts`). Leaving the workflow lookup is not a
reliable signal, because a closed temporary tab also leaves it while its
Cloud document may still exist.
- The target is compared when the delete finishes, not when it starts,
so a chat that clears its target mid-delete gets no notice and a
restoring chat that commits the workflow mid-delete does.
- Save As overwriting the chat's target file also counts as deletion,
since that document is gone.
- Out of scope, same as `main`: a delete from another tab or device
(`syncWorkflows`) shows no live notice, and a delete whose bookmark
cleanup rejects after the server delete leaves the workflow listed.
## Validation
- `agentPanelTarget.test.ts` (real stores): saved target deleted after
close and while open, unsaved target deleted, a saved workflow deleted
at a closed unsaved target's path, closed target renamed then deleted,
closed target reopened then deleted, target cleared mid-delete, target
committed by a restoring chat mid-delete, close only, another workflow,
a following chat, a changed target. A second table checks that a closed
target keeps no workflow object. The positive rows fail against the base
store.
- `AgentPanelRoot.test.ts`: the mounted panel shows the notice after the
target is deleted.
- `browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts` (cloud):
picks and saves a target, deletes it from the Workflows sidebar, then
checks the notice and the picker's "Select a workflow…" text. Runs in
CI.
- Agent and workflow unit suites, typecheck, lint, Knip, oxfmt, ADR
check and the Fallow audit pass.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2144 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9a89db79ad9f2148d39946a56dd1b68afcb9fc8
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-02T01:31:38.074Z",
"gitSha": "094cfd7d878821ba633aa52fc4f454058164e9cf",
"branch": "backport-19240-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.6610000000128,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.242,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.375,
"heapDeltaBytes": 2734908,
"heapUsedBytes": 70533868,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.918000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2022.2799999999097,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.814000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.513,
"heapDeltaBytes": -3455484,
"heapUsedBytes": 64361240,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.642,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1786.738000000014,
"styleRecalcs": 44,
"styleRecalcDurationMs": 15.322999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 858.6210000000001,
"heapDeltaBytes": 9740732,
"heapUsedBytes": 77576180,
"domNodes": -265,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 167.49800000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.3669999999602,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.265000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 847.3670000000001,
"heapDeltaBytes": 7823696,
"heapUsedBytes": 75687476,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 168.53,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.5970000000311,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.787,
"layouts": 6,
"layoutDurationMs": 1.2320000000000002,
"taskDurationMs": 405.35299999999995,
"heapDeltaBytes": 2721452,
"heapUsedBytes": 69610712,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.541,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.0350000000717,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.883000000000003,
"layouts": 6,
"layoutDurationMs": 1.116,
"taskDurationMs": 400.68,
"heapDeltaBytes": 3068292,
"heapUsedBytes": 71132368,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.643999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 677.7229999999577,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.408,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.4529999999999,
"heapDeltaBytes": 18994408,
"heapUsedBytes": 86703632,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 167.125,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 665.8689999999297,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.307,
"heapDeltaBytes": 18634972,
"heapUsedBytes": 86417432,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1183.6959999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 866.265,
"heapDeltaBytes": 38280936,
"heapUsedBytes": 104905912,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 75.97099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 563,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1243.7170000000606,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 937.022,
"heapDeltaBytes": 14391764,
"heapUsedBytes": 104537316,
"domNodes": -296,
"jsHeapTotalBytes": 21909504,
"scriptDurationMs": 68.122,
"eventListeners": -195,
"totalBlockingTimeMs": 612,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 854.8910000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.5250000000003,
"heapDeltaBytes": 15312604,
"heapUsedBytes": 92270700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.723,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.7050000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.66799999999955,
"heapDeltaBytes": 15337476,
"heapUsedBytes": 92117992,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.10600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 240,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10803.27699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9775.316,
"heapDeltaBytes": -14331948,
"heapUsedBytes": 68625804,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8303.17,
"eventListeners": 0,
"totalBlockingTimeMs": 1599,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11408.164999999939,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10490.719000000001,
"heapDeltaBytes": 17183280,
"heapUsedBytes": 99767476,
"domNodes": -14,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 8773.608000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1750,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11104.788999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10228.064999999999,
"heapDeltaBytes": 11312388,
"heapUsedBytes": 93502704,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8490.47,
"eventListeners": 0,
"totalBlockingTimeMs": 1381,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11132.345999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10229.662,
"heapDeltaBytes": -8341316,
"heapUsedBytes": 69576312,
"domNodes": -268,
"jsHeapTotalBytes": 2875392,
"scriptDurationMs": 8455.283,
"eventListeners": -174,
"totalBlockingTimeMs": 1582,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2032.0929999999748,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.194999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.649,
"heapDeltaBytes": -3990764,
"heapUsedBytes": 83282016,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.834,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2072.407999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 732.6490000000001,
"heapDeltaBytes": -6236584,
"heapUsedBytes": 81384808,
"domNodes": -248,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 41.519,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2616.341000000034,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1815.4519999999998,
"heapDeltaBytes": -12149496,
"heapUsedBytes": 75575908,
"domNodes": -253,
"jsHeapTotalBytes": 2875392,
"scriptDurationMs": 900.8009999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2327.511999999956,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.227,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1627.0919999999999,
"heapDeltaBytes": -8005568,
"heapUsedBytes": 79863192,
"domNodes": -250,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 900.7339999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3721.5569999999616,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.248999999999999,
"layouts": 60,
"layoutDurationMs": 14.213,
"taskDurationMs": 1849.128,
"heapDeltaBytes": 10107684,
"heapUsedBytes": 75498152,
"domNodes": -254,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 851.8059999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3655.6060000000343,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.382999999999997,
"layouts": 60,
"layoutDurationMs": 14.346999999999998,
"taskDurationMs": 1797.419,
"heapDeltaBytes": 7523432,
"heapUsedBytes": 74113304,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 827.0419999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3187.9369999999767,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.6759999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2069.371,
"heapDeltaBytes": -1812448,
"heapUsedBytes": 66183532,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1062.403,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3177.4449999999206,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.467999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2000.1639999999998,
"heapDeltaBytes": 23591212,
"heapUsedBytes": 89875680,
"domNodes": 2,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1027.039,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2063.0580000000123,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.460000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.8849999999999,
"heapDeltaBytes": -6882168,
"heapUsedBytes": 82202092,
"domNodes": -249,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.483000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.225000000034,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.554999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.6500000000001,
"heapDeltaBytes": 20604512,
"heapUsedBytes": 84718692,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 40.301,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.0709999999617,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.481000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.256,
"heapDeltaBytes": 13692112,
"heapUsedBytes": 83781572,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.633,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.8579999999583,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.48800000000006,
"heapDeltaBytes": 14044164,
"heapUsedBytes": 83237356,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 151.734,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.3529999999764,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.326,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.8009999999999,
"heapDeltaBytes": -11555244,
"heapUsedBytes": 58283936,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.681,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.1149999999461,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.955000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.7049999999999,
"heapDeltaBytes": 4594584,
"heapUsedBytes": 68650884,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.124000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.5489999999813,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.673,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 776.2800000000001,
"heapDeltaBytes": 6505080,
"heapUsedBytes": 76727680,
"domNodes": -285,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 114.18299999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.8890000000229,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.931,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.794,
"heapDeltaBytes": 4662828,
"heapUsedBytes": 74077856,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 113.79700000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3599999999542,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.347000000000005,
"layouts": 5,
"layoutDurationMs": 13.566000000000003,
"taskDurationMs": 991.8829999999998,
"heapDeltaBytes": 20288704,
"heapUsedBytes": 103992732,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 33.296,
"eventListeners": 2383,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8415.621999999985,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.202,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5456.639,
"heapDeltaBytes": -6920036,
"heapUsedBytes": 80310456,
"domNodes": -242,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2886.157,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8504.14699999999,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.921,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5598.646000000001,
"heapDeltaBytes": -6283388,
"heapUsedBytes": 80323540,
"domNodes": -244,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 2928.386,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17316.95099999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17067.212000000003,
"heapDeltaBytes": -44376848,
"heapUsedBytes": 181592564,
"domNodes": -8061,
"jsHeapTotalBytes": -11804672,
"scriptDurationMs": 306.798,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17402.65899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17145.503999999997,
"heapDeltaBytes": -41253604,
"heapUsedBytes": 199214360,
"domNodes": -8061,
"jsHeapTotalBytes": -15360000,
"scriptDurationMs": 281.911,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44333333333331,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20922.66900000004,
"styleRecalcs": 155,
"styleRecalcDurationMs": 19.701000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20785.106,
"heapDeltaBytes": -28258836,
"heapUsedBytes": 190484124,
"domNodes": -8061,
"jsHeapTotalBytes": -15544320,
"scriptDurationMs": 912.731,
"eventListeners": -14928,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20981.382000000052,
"styleRecalcs": 148,
"styleRecalcDurationMs": 19.542999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20819.492000000002,
"heapDeltaBytes": -61455920,
"heapUsedBytes": 179378272,
"domNodes": -8061,
"jsHeapTotalBytes": -20078592,
"scriptDurationMs": 969.4309999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6300.682000000052,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.89699999999999,
"layouts": 20,
"layoutDurationMs": 25.193999999999996,
"taskDurationMs": 6248.111,
"heapDeltaBytes": -49860148,
"heapUsedBytes": 190504372,
"domNodes": -8065,
"jsHeapTotalBytes": 4038656,
"scriptDurationMs": 148.721,
"eventListeners": -14928,
"totalBlockingTimeMs": 459,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6322.24199999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.02399999999999,
"layouts": 20,
"layoutDurationMs": 26.899000000000008,
"taskDurationMs": 6274.425,
"heapDeltaBytes": -43458028,
"heapUsedBytes": 196795500,
"domNodes": -8060,
"jsHeapTotalBytes": 11116544,
"scriptDurationMs": 115.46400000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 499,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8734.940999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8524.710000000001,
"heapDeltaBytes": 3566752,
"heapUsedBytes": 181095856,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 135.64100000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8625.755000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8425.582999999999,
"heapDeltaBytes": -1631404,
"heapUsedBytes": 185196788,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 139.328,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 126.66000000001532,
"styleRecalcs": 8,
"styleRecalcDurationMs": 22.476000000000003,
"layouts": 4,
"layoutDurationMs": 1.949,
"taskDurationMs": 98.73600000000002,
"heapDeltaBytes": 3214368,
"heapUsedBytes": 68982108,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.113999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 476.10499999996136,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.273999999999997,
"layouts": 3,
"layoutDurationMs": 1.7460000000000002,
"taskDurationMs": 132.92399999999998,
"heapDeltaBytes": 5130400,
"heapUsedBytes": 67423500,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.943,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Drafting while the release dependency chain is reconciled. The source snapshot depends on APIs not present on this release line (including the Agent telemetry/storage contract from #18665 and #18978); CI correctly caught the missing contracts. This carrier will not be marked ready until those prerequisites are either safely backported or the change is adapted without them. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 3 |
| 🟢 Low | 3 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Restore the release-compatible agent session and test implementations while preserving the history-reopen behavior from #18866.
…-18866-to-cloud-1.55 # Conflicts: # src/workbench/extensions/agent/composables/agent/useAgentSession.ts
The carrier had resolved its conflicts by taking main's copy of the shared files wholesale, which carried main-only context that does not exist on this release line: workspace-scoped agent storage keys (StorageKeys.agentThread / agentWorkflowTabBindings, clearLegacyAgentStorage), api.serverFeatureFlagsSettled / flagsSettled, the deferred pendingSend / reportPendingSend send-reporting path, a duplicate trackWorkflowOpenFailure, and 96 ADR index rows for ADRs absent here. That is what made the whole tree fail to build. Re-derived instead: take cloud/1.55's content for every shared file and re-apply only #18866's own delta on top, adapted to this branch's idioms - THREAD_STORAGE_KEY for the thread key, `connection` rather than `everLive`, the module-level workflowService helper, and reconcileLiveTurns() kept in hydrateFromServer. docs/adr/README.md now gains exactly the one AGENT-HISTORY-0038 row. The two large test files had diverged too far for hunk application, so they were merged whole-file against #18866's parent: AgentPanelRoot.test.ts by diff3, and AgentPanel.test.ts by adding the five history-selection tests #18866 introduces plus its mountHistory helper, since this branch deliberately carries a trimmed suite. Verified: the merged tree is cloud/1.55 plus exactly #18866's 25-file delta, 21 of those files matching the upstream delta line-for-line.
…9240 This carrier forked from the #18866 branch at 9d6c35a - the first, bad attempt at the prerequisite, before both its a4ce50f repair and the target merge. Its 45-file / -4478-line diff against the current base was therefore mostly the base's own later content being undone; the carrier's real payload is #19240's 6-file, +371/-9 delta. Re-derived onto the repaired base: take that base's content wholesale and apply exactly #19240's delta on top. Two adaptations this release line needs, both of the same main-only-API class: - agentDeletedTargetNotice.spec.ts did `const panel = await agentPanel.open()` and then `panel.getByText(...)`. AgentPanel.open() returns Promise<Locator> on main and Promise<void> here, so the browser coverage this carrier exists to add could never have compiled. It now reads agentPanel.root, which both branches expose. The assertion is unchanged. - agentPanelStore no longer exposed `targetTracking`, which #19240's agentPanelTarget.test.ts asserts against. main has exported it since #18693 (facbca7); #19240 did not add it. Carried as the missing prerequisite rather than weakening the test. Verified: the merged tree is the repaired base plus exactly #19240's 6-file delta, matching the upstream 2595efc file set.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19733 +/- ##
=============================================
Coverage ? 84.91%
=============================================
Files ? 2318
Lines ? 132700
Branches ? 35509
=============================================
Hits ? 112679
Misses ? 19660
Partials ? 361
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
#19732 squash-landed as e9a89db, so this carrier's base branch is gone and GitHub retargeted it to cloud/1.55. That left it CONFLICTING: the merge base falls back to 9a5ce83, before the squash, so git tried to re-merge #18866's content against the copy this branch already carries. Resolving that merge directly produced real damage - a duplicated markWorkflowTargetUnavailable and a mangled TargetTracking union. Re-derived instead, on the proof that e9a89db's tree is byte-identical to the reviewed 3dff667 (both f622a76): take the landed tip's content wholesale and apply exactly #19240's delta on top, with the same two release-line adaptations as before - agentPanel.root in place of the Promise<Locator> return main's AgentPanel.open() has, and the targetTracking export main has carried since #18693. The tree is therefore cloud/1.55 plus exactly #19240's 6-file delta, matching the upstream 2595efc file set.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
The 1.55 store intentionally keeps targetTracking private; the adjacent public-behavior cases cover the same temporary and saved target deletion paths.
This comment has been minimized.
This comment has been minimized.
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 9 prior finding(s) across 1 round(s) (0 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 6 |
| 🟢 Low | 3 |
Panel: 7/8 reviewers contributed findings.
Reviewers that did not contribute: gemini-3.1-pro:edge-case (error)
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/workbench/extensions/agent/composables/agent/useAgentSession.ts:563— 🟠 High —stop()no longer incrementsloadGeneration, so thegeneration !== loadGenerationguard inperformSendstops tripping after teardown: a POST that resolves once the session has stopped now reachesacceptTurn, which writes the thread id to localStorage, callsonThreadActivatedon a dead host, and callsconversationStore.startTurnafterabortActiveTurn/dropBackgroundTurnsalready ran. The regression test that pinned this (does not persist a send that resolves after the session stops) is deleted in the same diff, as are the tests for two other behaviours this diff reverts, which is worth checking against the intended base.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
src/platform/auth/unified/remintRetry.ts:146— 🟡 Medium —clearInitialTimeout()cancels the request's only deadline, but the replacement signal is not created until afterawait tryRemintToken(...), which has no timeout of its own. A re-mint that stalls therefore leaves the request with no deadline at all and a caller that passedtimeoutMsnever settles; before this change the still-armed timer at least aborted the retry signal. Start the retry timer before the re-mint, or wraptryRemintTokenin the same budget.Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial).
src/platform/assets/composables/useUploadModelWizard.ts:391— 🟡 Medium — DroppingstopAsyncWatch()from the terminal-failure branch leaves nothing to stop this watcher: it is created inside an async continuation (afterawait uploadAssetAsync), so no effect scope owns it and it is not disposed whenUploadModelDialogunmounts, andresetWizardonly runs on "Import another". Closing the dialog on the error screen therefore leaks a watcher that re-scansassetDownloadStore.downloadListon every progress message and writesuploadStatus/uploadErroron a destroyed component, one more per failed import. Keeping the recovery path is reasonable, but the watcher needs a scope or unmount owner.Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
src/workbench/extensions/agent/AgentPanelRoot.vue:1753— 🟡 Medium — RemovingonAttachFilesand this@attach-filesbinding, together with theattachFilesemit onAgentPanelandComposer, drops paste-to-attach entirely: pasted files are no longer forwarded touseAttachment.addFiles(), which now returns a boolean no caller consumes, and the three AgentPanelRoot tests covering pasted screenshots are deleted in the same diff. Confirm this is intended divergence rather than a bad rebase.Raised by 1 of 8 reviewers (gemini-3.1-pro edge-case).
src/workbench/extensions/agent/composables/agent/useAgentSession.ts:130— 🟡 Medium — The persisted thread id moves from the workspace-scopedStorageKeys.agentThread(getWorkspaceId())to a single origin-wideComfy.Agent.ThreadId, so a logout/login or workspace switch restores the previous principal's thread id and sends it straight togetThreadHistory. The two tests that pinned that isolation (ignores an unscoped thread from an unknown account,restores only the active team workspace thread) are deleted here. Keep the key scoped to the authenticated user/workspace and clear it on identity transitions, or confirm this branch deliberately predates the scoping.Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).
src/platform/assets/composables/useUploadModelWizard.ts:384— 🟡 Medium —stopAsyncWatchis a single shared slot and thecompletedbranch stops it only afterawait refreshModelCaches(), so it stops whichever watcher occupies the slot by then rather than its own. If task A completes whileupdateModelsForNodeTypeis still pending, then "Import another" starts task B, A's continuation stops B's watcher and B's latercompleted/failedupdates leave the wizard stuck onprocessing. Capture the stop handle in a local and call that one.Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
src/workbench/extensions/agent/composables/agent/useAgentWorkflowSelection.ts:91— 🟡 Medium —previousWorkflowIdis now derived fromselectedTargetinsidecommitWorkflowTarget, which runs afteronSelectWorkflowTargethas already awaitedworkflowService.openWorkflow(tab). In following modeselectedTargettracks the active workflow, so it already equals the just-opened tab,workflowId === previousWorkflowId, and the guard below suppressesonTargetBound— theagent_workflow_boundevent withbind_source: 'selector_chip'is never emitted for an explicit picker retarget, which is exactly the transition ADR-AGENT-TARGET-0037 says retains selector-chip attribution. Capture the previous id before the open, as the removed parameter did.Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
src/workbench/extensions/agent/composables/agent/useAgentSession.ts:1337— 🟢 Low — When recovery discovers the active thread was deleted server-side,forgetDeletedThreadresets the conversation, clearsboundWorkflowId/rememberedWorkflowIdand removes the thread key, but unlikenewChat()it never callsonThreadActivated?.(null). The host's chat-history UI keeps the deleted thread selected, so panel and host disagree about the active thread until some other action re-notifies.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
src/stores/assetDownloadStore.ts:139— 🟢 Low —noteUnresolvedCancellationcounts every unresolved reconciliation towardMAX_CANCELLATION_RECONCILE_ATTEMPTS, including transient network/5xx failures and responses that still sayrunning— none of which prove the task was cancelled. After six such attempts the entry is finalized ascancelled, which is not recheckable, so polling stops permanently; if the eventualcompletedWebSocket message is then missed, a download that actually succeeded reports as Cancelled and the model caches are never refreshed. Consider only counting authoritative non-terminal reads toward the bound.Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
src/renderer/core/layout/operations/graphLayoutAttachment.ts:229— 🟢 Low —clearContentSizeis a required method on the layout store, so casting toPartial<typeof layoutStore>to call it with?.only buys silence: if it is renamed, or this attachment is handed a store without it, the stale DOM measurement survives and theMath.max(explicitSize, contentSize)ratchet silently prevents the node from shrinking again, with no type error. Call the method directly so the contract is enforced at compile time.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
Stacked manual backport of #19240 on the #18866 cloud/1.55 carrier. This makes an open Agent chat explicitly report when its target workflow was deleted and includes the source unit and browser coverage. The base will be retargeted to cloud/1.55 after the prerequisite carrier lands.\n\nOriginal: #19240
Justification: Exact head 186452c has DrJKL approval and all required checks green. cloud/1.55 advanced by two commits after CI; the exact-head gate measured zero changed-file overlap with that target delta, so the stale-base exception is narrowly applied for this authorized release backport.