Skip to content

[backport cloud/1.54] fix(agent): show deleted target workflow state - #19735

Merged
christian-byrne merged 7 commits into
cloud/1.54from
backport-19240-to-cloud-1.54
Oct 1, 2026
Merged

christian-byrne merged 7 commits into
cloud/1.54from
backport-19240-to-cloud-1.54

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Stacked manual backport of #19240 on the #18866 cloud/1.54 carrier. This makes an open Agent chat explicitly report when its target workflow was deleted, and includes the source unit and browser coverage.

Original: #19240

Repaired after the prerequisite landed

The prerequisite shipped as #19734 (22e29bc9), which re-derived #18866 against this branch's files after the first attempt — eee88dc3, still the second commit on this branch — resolved its conflicts by taking main's copy wholesale. Both versions then sat on the same branch, which is what GitHub reported as CONFLICTING.

0f2d27d1 merges cloud/1.54 in rather than force-pushing, so the previously reviewed head d46c6ed9 stays in the history. The resolution takes cloud/1.54's content for every file the two prerequisites share and re-applies #19240's own hunks on top, so the merged tree equals origin/cloud/1.54 plus exactly the six-file #19240 delta and nothing else (git diff --cached --stat origin/cloud/1.54 → +371/-9 across those six files).

Two main-only assumptions then had to be adapted, and they are why typecheck was red and the browser coverage never executed at the old head:

  • AgentPanel.open() returns Promise<Locator> on main and Promise<void> here, so const panel = await agentPanel.open() did not compile. The spec uses agentPanel.root.
  • TabLinkCard.test.ts hand-stubs useWorkflowStore on this branch where main uses the real store, so the panel store's new $onAction subscription threw and took all 11 of its tests down. The stub now offers the subscription.

agentPanelStore.ts differs from origin/main only in the pre-existing api.serverFeatureFlagsSettled lines that main has and this release line does not; #19240's production delta is applied verbatim.

Review findings

All seven threads are answered inline and resolved. Two were real and are fixed in the browser fixture — cloud ids came from workflows.length + 1, which reissued a live entry's id to a workflow saved after a delete or a refused turn, and the listing name was sliced on the workflows/ prefix alone without requiring the .json suffix, in both the POST and the DELETE handler. The rest were raised and dispositioned on #19240 itself, or describe pre-existing behaviour this change does not touch; a release carrier is not the place to diverge production behaviour from the approved parent. One genuinely new finding — renameWorkflow rejecting after it has already swapped the path leaves closedPath stale — is recorded for main rather than fixed here.

Proof at this head

  • agentDeletedTargetNotice.spec.ts gains "gives a workflow saved at the deleted path its own identity": it saves a replacement at the deleted target's name and asserts the chat's next turn carries the replacement's own cloud id. It fails against the old fixture id scheme, where the turn posted the deleted workflow's …000000000001.
  • useAgentWorkflowSelection.test.ts gains the delete-settles-mid-restoration ordering, which fails if markWorkflowTargetUnavailable() is removed from onWorkflowRestored.
  • agentPanelTarget.test.ts records the store-side boundary for that same ordering.
  • Green locally at c2e6b2b6: typecheck, typecheck:browser, format:check, lint (0 errors), knip, adr:check, locale:check; full unit suite 1583/1583 files and 22490 tests; and playwright --project=cloud over agentDeletedTargetNotice, agentWorkflowSelection, agentHistoryReopensClosedWorkflow and agentStaleWorkflowTabBinding — 12 passed.

Justification: Release-branch backport merged by its author under this program's standing Agent 1.54/1.55 backport grant (Christian, 2026-09-16, extended 2026-09-27), which authorizes the carrier's own author to merge once their own gates pass — GitHub cannot accept an author's self-approval, so no pre-merge approval record exists. What limits the blast radius: the change is confined to cloud/1.54 at +526/-13 across 8 files (one production file, agentPanelStore.ts, plus its own tests, one browser fixture, one spec and one ADR); the target refresh is provably content-neutral, with the carrier patch byte-identical to the previously reviewed head (sha256 60d6f077a45ed4ed8fa563defbfe8c0dcc947a95f208b7c8ca7f3f870ce88a6b); there is zero file overlap with the untested target delta; every required check is green at the exact merged head; and the user-visible behaviour was proven on this carrier through the black-box harness (browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts). Post-merge peer review is still owed under SOC 2 CC8.1 and is NOT waived by this line; it routes to @DrJKL for ComfyUI_frontend.

Selecting an Agent history chat now reopens its saved workflow when the
tab is closed. History stays visible until the conversation and workflow
are ready, then the selected chat becomes Current.

[PM-1640](https://linear.app/comfyorg/issue/PM-1640)

- Resolve saved targets through the workflow catalog and reuse known
open targets to avoid redundant requests.
- Reuse an already loaded Current conversation when returning from
history.
- Show accessible row loading and retry; preserve navigation across
panel remounts and guard superseded workflow opens.
- Preserve Current and its persisted session when deleting a different
chat that failed to open.

Missing/deleted targets, rapid selections, Back, retry, and panel
remounts. Graph activation uses the existing serialized loader;
cancellation guards run before activation, without adding rollback once
activation starts.

- Affected unit/component suites pass, covering saved-workflow
reopening, cancellation, loading/retry, remounts, and Current identity
(two existing expected failures retained).
- Full lint, typecheck, Knip, Fallow audit, formatting, and ADR checks
passed.
- No new Playwright regression: deferred REST/catalog/workflow responses
and panel remounts are covered by mounted Root tests using the real
session and stores; workflow-service tests cover activation
cancellation. These deterministic lower-level boundaries reproduce the
failures without another browser fixture duplicating them.
Browser/assistive-technology validation was not run at the author’s
request; human UX review remains pending.
Deleting the saved file of the open chat's target workflow now shows the
existing in-chat notice ("The target workflow is no longer available.")
instead of silently dropping the target.

[PM-1640](https://linear.app/comfyorg/issue/PM-1640)

- **What**: The panel store subscribes to
`workflowStore.deleteWorkflow`. When the delete of a saved workflow
finishes and that workflow is still the chat's target, the store marks
the target unavailable, which shows the notice from #18866. A target
whose tab has closed is known by its saved path, which follows renames,
so the store does not keep the closed workflow object. Closing the tab,
or deleting an unsaved target, only clears the target. Deleting another
workflow, deleting after the chat picked another target, and deleting
after the closed target was reopened change nothing. A fresh chat that
follows the visible tab is unaffected.

- Deletion is detected through the explicit store action (`$onAction`,
as in `mintPortWiring.ts`). Leaving the workflow lookup is not a
reliable signal, because a closed temporary tab also leaves it while its
Cloud document may still exist.
- The target is compared when the delete finishes, not when it starts,
so a chat that clears its target mid-delete gets no notice and a
restoring chat that commits the workflow mid-delete does.
- Save As overwriting the chat's target file also counts as deletion,
since that document is gone.
- Out of scope, same as `main`: a delete from another tab or device
(`syncWorkflows`) shows no live notice, and a delete whose bookmark
cleanup rejects after the server delete leaves the workflow listed.

- `agentPanelTarget.test.ts` (real stores): saved target deleted after
close and while open, unsaved target deleted, a saved workflow deleted
at a closed unsaved target's path, closed target renamed then deleted,
closed target reopened then deleted, target cleared mid-delete, target
committed by a restoring chat mid-delete, close only, another workflow,
a following chat, a changed target. A second table checks that a closed
target keeps no workflow object. The positive rows fail against the base
store.
- `AgentPanelRoot.test.ts`: the mounted panel shows the notice after the
target is deleted.
- `browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts` (cloud):
picks and saves a target, deletes it from the Workflows sidebar, then
checks the notice and the picker's "Select a workflow…" text. Runs in
CI.
- Agent and workflow unit suites, typecheck, lint, Knip, oxfmt, ADR
check and the Fallow audit pass.
@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 1, 2026 11:12pm UTC
billing-web-test Ignored Ignored Oct 1, 2026 11:12pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 383d62f9-12fb-4c12-8ab1-f54714a04047

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/01/2026, 11:15:14 PM UTC

Links

🎭 Playwright: ✅ 1980 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1959 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 18ms TBT · 80.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 151ms TBT · 99.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.1 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 59ms TBT · 165.4 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 375ms TBT · 174.7 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 542ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.7 MB
canvas-idle: DOM nodes -139
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 27ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 876ms
canvas-mouse-sweep: script duration 163ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 54.7 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -166
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 350ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 457ms
dom-widget-clipping: script duration 166ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.6 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 598ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.0 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -162
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1648ms
large-graph-pan: script duration 820ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 72.9 MB
large-graph-pan: DOM nodes -264
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1730ms
large-graph-zoom: script duration 789ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 68.9 MB
large-graph-zoom: DOM nodes -145
large-graph-zoom: event listeners -95
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1961ms
legacy-node-drag: script duration 999ms
legacy-node-drag: TBT 18ms
legacy-node-drag: heap used 80.9 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 187
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 582ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.2 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 405ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.3 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 486ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.8 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 799ms
subgraph-mouse-sweep: script duration 107ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.7 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -211
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 904ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 151ms
subgraph-transition-enter: heap used 99.9 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5819ms
viewport-pan-sweep: script duration 2710ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 74.4 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16204ms
vue-large-graph-idle: script duration 275ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 20378ms
vue-large-graph-pan: script duration 905ms
vue-large-graph-pan: TBT 59ms
vue-large-graph-pan: heap used 165.4 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6071ms
vue-node-resize-workload: script duration 108ms
vue-node-resize-workload: TBT 375ms
vue-node-resize-workload: heap used 174.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14927
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8344ms
vue-zoom-out-idle: script duration 149ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 78ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.9 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-10-01T23:23:58.802Z",
  "gitSha": "244f91d6d55f7daef190e395104b796e74ab4c8a",
  "branch": "backport-19240-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2149.588000000051,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.785000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 590.6089999999999,
      "heapDeltaBytes": -10754808,
      "heapUsedBytes": 59811336,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.358000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2031.949999999938,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.715,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.794,
      "heapDeltaBytes": -12858108,
      "heapUsedBytes": 56943628,
      "domNodes": 2,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.932000000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1906.3770000000204,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 28.252,
      "layouts": 14,
      "layoutDurationMs": 4,
      "taskDurationMs": 907.2,
      "heapDeltaBytes": -13681332,
      "heapUsedBytes": 57419348,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 170.202,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1781.7290000000412,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 25.894000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.8789999999999996,
      "taskDurationMs": 844.643,
      "heapDeltaBytes": -13755688,
      "heapUsedBytes": 57250552,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 155.835,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1663.80300000003,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.349,
      "layouts": 6,
      "layoutDurationMs": 1.009,
      "taskDurationMs": 355.464,
      "heapDeltaBytes": 4586176,
      "heapUsedBytes": 75753836,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.613000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1680.0029999999424,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.589,
      "layouts": 6,
      "layoutDurationMs": 0.9439999999999998,
      "taskDurationMs": 345.12399999999997,
      "heapDeltaBytes": 4520892,
      "heapUsedBytes": 75884376,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.061999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 681.9110000000137,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.160999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.82800000000003,
      "heapDeltaBytes": -7681160,
      "heapUsedBytes": 62943212,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 168.313,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 634.4269999999597,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.292000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.11099999999993,
      "heapDeltaBytes": 18395188,
      "heapUsedBytes": 89248840,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 162.75400000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.0610000000324,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.551000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.1210000000001,
      "heapDeltaBytes": -16983296,
      "heapUsedBytes": 86995332,
      "domNodes": -269,
      "jsHeapTotalBytes": -1376256,
      "scriptDurationMs": 35.012,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.6410000000415,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.218,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 601.891,
      "heapDeltaBytes": 11293312,
      "heapUsedBytes": 87123600,
      "domNodes": -274,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 33.138,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2338.819000000001,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.906,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1709.7789999999998,
      "heapDeltaBytes": 8282904,
      "heapUsedBytes": 85896380,
      "domNodes": -252,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 836.491,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2171.156999999994,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 9.418000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1586.7289999999998,
      "heapDeltaBytes": 828836,
      "heapUsedBytes": 66886520,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 804.087,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3571.9990000000053,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.039999999999996,
      "layouts": 60,
      "layoutDurationMs": 12.063,
      "taskDurationMs": 1773.021,
      "heapDeltaBytes": -11899380,
      "heapUsedBytes": 67274452,
      "domNodes": -291,
      "jsHeapTotalBytes": 3829760,
      "scriptDurationMs": 784.816,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3547.02199999997,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 9.737000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.369,
      "taskDurationMs": 1686.512,
      "heapDeltaBytes": 9296312,
      "heapUsedBytes": 77203136,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 792.822,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3143.2249999999726,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.821000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1945.281,
      "heapDeltaBytes": 25378916,
      "heapUsedBytes": 93718608,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 977.6089999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3147.442000000069,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.835999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1976.7479999999998,
      "heapDeltaBytes": -4453864,
      "heapUsedBytes": 75928464,
      "domNodes": 8,
      "jsHeapTotalBytes": 5890048,
      "scriptDurationMs": 1019.9849999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 35,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.550999999979,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 5.2589999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 591.8180000000001,
      "heapDeltaBytes": 7839868,
      "heapUsedBytes": 86761568,
      "domNodes": -276,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 37.758,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.082999999986,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.512000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.894,
      "heapDeltaBytes": 9858172,
      "heapUsedBytes": 87795888,
      "domNodes": -268,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 36.49099999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 580.6919999999991,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.451999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.25199999999995,
      "heapDeltaBytes": 15130844,
      "heapUsedBytes": 88671772,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 143.791,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 593.5969999999315,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.163000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.702,
      "heapDeltaBytes": 15271424,
      "heapUsedBytes": 88019560,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 144.52499999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.149000000013,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.636000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.13300000000004,
      "heapDeltaBytes": -10674368,
      "heapUsedBytes": 62137640,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.073,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.5429999999888,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.427000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.48699999999997,
      "heapDeltaBytes": -6754724,
      "heapUsedBytes": 65393336,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.936000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.3679999999745,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 29.088,
      "layouts": 18,
      "layoutDurationMs": 4.764,
      "taskDurationMs": 822.342,
      "heapDeltaBytes": 5253024,
      "heapUsedBytes": 78432292,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 112.50699999999999,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.6350000000957,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.022999999999996,
      "layouts": 18,
      "layoutDurationMs": 4.081,
      "taskDurationMs": 776.2929999999999,
      "heapDeltaBytes": -13779496,
      "heapUsedBytes": 59381244,
      "domNodes": -295,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 102.262,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.6380000000718,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.054,
      "layouts": 15,
      "layoutDurationMs": 15.250999999999998,
      "taskDurationMs": 903.6059999999999,
      "heapDeltaBytes": 20281028,
      "heapUsedBytes": 104777328,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 30.336000000000002,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 151,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8351.994999999988,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.47,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5864.9,
      "heapDeltaBytes": 9348156,
      "heapUsedBytes": 85950000,
      "domNodes": -271,
      "jsHeapTotalBytes": -663552,
      "scriptDurationMs": 2693.104,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8456.552000000102,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 34.981,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5773.789,
      "heapDeltaBytes": -6611152,
      "heapUsedBytes": 70096148,
      "domNodes": -281,
      "jsHeapTotalBytes": 3305472,
      "scriptDurationMs": 2727.8540000000003,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17053.336000000058,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16589.433,
      "heapDeltaBytes": -51942040,
      "heapUsedBytes": 179397460,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13082624,
      "scriptDurationMs": 268.66200000000003,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16657.411000000026,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15818.839,
      "heapDeltaBytes": -62930680,
      "heapUsedBytes": 177282976,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18288640,
      "scriptDurationMs": 281.532,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20990.528000000042,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 18.235,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20630.409999999996,
      "heapDeltaBytes": -41755140,
      "heapUsedBytes": 180226636,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11034624,
      "scriptDurationMs": 908.0490000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 114,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20541.480999999978,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.146999999999966,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20125.61,
      "heapDeltaBytes": -51752848,
      "heapUsedBytes": 166618608,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10526720,
      "scriptDurationMs": 902.57,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6068.021000000044,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.18199999999997,
      "layouts": 20,
      "layoutDurationMs": 21.536,
      "taskDurationMs": 5931.713,
      "heapDeltaBytes": -40216848,
      "heapUsedBytes": 183930732,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15056896,
      "scriptDurationMs": 107.569,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 317,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6341.0539999999855,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.05800000000002,
      "layouts": 20,
      "layoutDurationMs": 25.06800000000001,
      "taskDurationMs": 6210.396000000001,
      "heapDeltaBytes": -45798364,
      "heapUsedBytes": 182533552,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12173312,
      "scriptDurationMs": 108.541,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 433,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8830.079999999953,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8467.115,
      "heapDeltaBytes": 16369992,
      "heapUsedBytes": 177481472,
      "domNodes": 0,
      "jsHeapTotalBytes": -18087936,
      "scriptDurationMs": 168.08299999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8498.432999999977,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8221.339,
      "heapDeltaBytes": 19831572,
      "heapUsedBytes": 179248424,
      "domNodes": 0,
      "jsHeapTotalBytes": -11796480,
      "scriptDurationMs": 130.30600000000004,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 106.3130000000001,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.71,
      "layouts": 2,
      "layoutDurationMs": 0.9989999999999999,
      "taskDurationMs": 67.055,
      "heapDeltaBytes": 3080272,
      "heapUsedBytes": 71990364,
      "domNodes": 127,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 6.432,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 127.66000000010536,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 17.072,
      "layouts": 2,
      "layoutDurationMs": 1.129,
      "taskDurationMs": 88.093,
      "heapDeltaBytes": 2993880,
      "heapUsedBytes": 72557704,
      "domNodes": 128,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.037,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50821 76114 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from ryan-di October 1, 2026 09:03
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Drafting while the release dependency chain is reconciled. The source snapshot depends on APIs not present on this release line (including the Agent telemetry/storage contract from #18665 and #18978); CI correctly caught the missing contracts. This carrier will not be marked ready until those prerequisites are either safely backported or the change is adapted without them.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🟡 Medium 3
🟢 Low 3
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@DrJKL
DrJKL self-requested a review October 1, 2026 09:21
Base automatically changed from backport-18866-to-cloud-1.54 to cloud/1.54 October 1, 2026 10:56
@datadog-official

This comment has been minimized.

The prerequisite carrier landed as #19734 (22e29bc), which re-derived
#18866 against this branch's files after the first attempt (eee88dc, the
second commit on this branch) resolved its conflicts by taking main's copy
wholesale. Both now sit on the same branch, which is what GitHub reported
as CONFLICTING.

Resolution: take cloud/1.54's content for every file the two prerequisites
share, then re-apply #19240's own hunks on top. The merged tree therefore
equals origin/cloud/1.54 plus exactly the six-file #19240 delta and nothing
else — eee88dc's main-only context (workspace-scoped agent storage keys,
ComfyApi.serverFeatureFlagsSettled, three main-only test modules, 27 ADR
index rows for ADRs absent here) is gone.

Verified before commit:
  git diff --cached --stat origin/cloud/1.54
    -> the 6 files of d46c6ed only, +371/-9

No force-push: this is a merge, so the previously reviewed head d46c6ed
remains in the history.
Two main-only assumptions travelled with the backport and are why the
browser coverage never executed and `typecheck` was red at d46c6ed:

- `AgentPanel.open()` returns `Promise<Locator>` on `main` and
  `Promise<void>` here, so `const panel = await agentPanel.open()` did not
  compile (`error TS2339: Property 'getByText' does not exist on type
  'void'`, reproduced by restoring the old file). The spec uses
  `agentPanel.root` instead, which both branches expose.
- `TabLinkCard.test.ts` stubs `useWorkflowStore` by hand on this branch
  where `main` uses the real store, so the panel store's new `$onAction`
  subscription threw `workflowStore.$onAction is not a function` and took
  all 11 of its tests down. The stub now offers the subscription.

Neither changes production code: this is the backport adaptation #19734's
message describes, applied to the dependent carrier.

Verified at this tree: typecheck, typecheck:browser, format:check, lint
(0 errors), knip, adr:check, locale:check; full unit suite 1583/1583 files
and 22490 tests; `playwright --project=cloud
browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts` green, which it
had never been.

The spec also gains a second case, `gives a workflow saved at the deleted
path its own identity`, which saves a replacement workflow at the deleted
target's name and asserts the chat's next turn carries the replacement's own
cloud id. It is the black-box answer to the reviewers' overwrite-vs-delete
and recycled-path questions, and it fails against the fixture's old id
scheme (it posts the deleted workflow's id, `…000000000001`).
Fixture, both findings confirmed real and now proven by the browser case in
the previous commit:

- Cloud ids came from `workflows.length + 1`, but entries leave `workflows`
  on delete and on a refused turn, so a workflow saved after either one was
  reissued a live entry's id. Ids now come from a counter that only moves
  forward. The existing `…000000000001` assertion in
  `agentWorkflowSelection.spec.ts` is unchanged by this.
- The listing name was derived with `slice(…, -'.json'.length)` guarded only
  by the `workflows/` prefix, in both the POST and the DELETE handler, so any
  other path under that directory became a prefix of some unrelated entry's
  name and could splice it out. `workflowNameFromPath` requires the suffix and
  both handlers use it. This fixes the POST side too, which the review
  comment's route-level guard would not have.

Ordering, dispositioned rather than changed. A delete that settles while the
chat is still `restoring` is invisible to the panel store — there is no
retained target to match — so the store cannot own that outcome. The
restoration does, from the Cloud listing, and it cannot commit the deleted
workflow behind the notice because `isCurrent()` requires the mode to still
be `restoring`. Two rows record that boundary where each half is observable:
the store row asserts no notice from the store, and
`useAgentWorkflowSelection.test.ts` asserts the notice the restoration
reports. The selection test fails if
`markWorkflowTargetUnavailable()` is removed from `onWorkflowRestored`.

#19240's production delta is applied verbatim: `agentPanelStore.ts` here
differs from `origin/main` only in the two pre-existing branch lines
(`api.serverFeatureFlagsSettled` / `flagsSettled`) that `main` has and this
release line does not, plus import order. Every finding that asks for a behaviour change — reporting an
overwrite-save as a deletion, observing a remote or cross-tab delete,
reacting to a durable mutation whose later cleanup rejects, and unbinding the
chat/tab record on delete — was raised and dispositioned on that PR with a
reviewer's sign-off, or is pre-existing behaviour this change does not
touch. Diverging the release carrier from the approved parent is the thing
this backport must not do; the detail per finding is in the PR thread
replies and in reports/jobs/op228-fe19735-stackrepair-1.md.
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 1, 2026
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...h/extensions/agent/stores/agent/agentPanelStore.ts 97.36% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19735   +/-   ##
=============================================
  Coverage              ?   84.05%           
=============================================
  Files                 ?     2123           
  Lines                 ?   127507           
  Branches              ?    32677           
=============================================
  Hits                  ?   107177           
  Misses                ?    20151           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.82% <69.23%> (?)
unit 79.25% <97.36%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...h/extensions/agent/stores/agent/agentPanelStore.ts 97.35% <97.36%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the target refresh, under the standing Agent 1.54/1.55 release-backport grant (Christian, 2026-09-16, extended 2026-09-27). Posting this as a COMMENT rather than an approval because I am the author of the carrier and GitHub cannot accept a self-approval. This is explicitly not the independent human review — that is still owed post-merge and is not waived.

What moved, and why

cloud/1.54 advanced 3 commits past this carrier's merge base, so the target-aware gate refused on tip staleness alone — not on any adverse check and not on any human objection. Refreshed by merging the target branch in (not rebasing, not force-pushing), so the previously reviewed head e4f39a49ce1b36d08a43f70cfde3a711eb629c52 stays in the history, consistent with how 0f2d27d1 and e4f39a49 were handled on this branch.

  • previous reviewed head: e4f39a49ce1b36d08a43f70cfde3a711eb629c52
  • target merged in: ce5b5954c529a6e3939b556feae0a116a8c48018
  • new head: b4882265e585de43872f909014dd7f423bb18572 (parents, in order: previous head, then target)

The merge was clean — no conflicts, so no conflict resolution to review.

Proof the refresh is content-neutral

The carrier patch is byte-identical across the refresh:

  • old: git diff --binary 8a160ce919 e4f39a49ce
  • new: git diff --binary ce5b5954c5 b4882265e5
  • both sha256 60d6f077a45ed4ed8fa563defbfe8c0dcc947a95f208b7c8ca7f3f870ce88a6b; cmp clean.

git diff --stat origin/cloud/1.54 b4882265e5 → the same 8 files, +526, −13. So the merged tree equals origin/cloud/1.54 plus exactly this carrier's own delta and nothing else. No product behaviour was introduced or adapted by the refresh.

Interaction risk with the untested delta

The 3 target commits touch 14 files (agentConversationStore, useAgentSession, agentTranscript, agentRestClient, ingest-types, and two socket-drop specs). Zero overlap with this carrier's 8 files, which the gate confirms independently. I also checked the render path this fix depends on is present and unchanged on the refreshed carrier — targetUnavailable / markWorkflowTargetUnavailable in agentPanelStore.ts, consumed by AgentPanelRoot.vue and AgentPanel.vue, with the targetWorkflowUnavailable string in en/main.json. (Worth noting because #19750's body argues #19240 is uncarriable here for want of prerequisite #18866; that applies to an automatic cherry-pick, not to this manual carrier, which includes the mechanism and proves it in the harness.)

Evidence at this exact head

  • check-merge-ready.sh --target-branch cloud/1.54 → MERGE READY; base is an ancestor of the head, 92 checks completed with success/neutral/skipped only, test receipts newer than the base commit (2026-10-01T22:03:33Z), no unresolved threads, no later reviewer objection.
  • All three commit statuses green at this head, including Vercel – billing-web-test. The branch-wide waiver recorded for that status (sunset 2026-10-09) was therefore not invoked — nothing on this PR was waived.
  • All 7 earlier review threads remain resolved; the refresh did not reopen any.
  • User-visible behaviour was proven on this carrier through the black-box harness, browser_tests/tests/agent/agentDeletedTargetNotice.spec.ts, and that spec runs green in the hosted playwright-tests (cloud) job at this head.

What I did not do

I did not re-derive #19240's product design from scratch; that was reviewed on the parent and its findings are dispositioned in the body above. My review covers the refresh, the tree-equality proof, the interaction surface against the untested delta, and the gate evidence at b4882265e5.

@christian-byrne
christian-byrne merged commit ee2b847 into cloud/1.54 Oct 1, 2026
97 checks passed
@christian-byrne
christian-byrne deleted the backport-19240-to-cloud-1.54 branch October 1, 2026 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants