Repository navigation
[backport cloud/1.55] FE-3135 fix(billing): show Subscription paused copy for payment_failed renewals (#19677) - #19748
Conversation
…d renewals (#19677) Show the Subscription paused copy for `payment_failed` renewals instead of "update payment to avoid a pause", and give the member Subscription paused banner the informational (grey) icon. `v1_payment_recovery` went to 100% in prod today, so this banner is live. For a `payment_failed` renewal the run button is already locked (`CloudRunButtonWrapper` locks on `payment_failed` regardless of the flag), yet the settings banner says "Update payment to avoid a pause", which describes a warning stage that does not exist. Per design review (Alex), until BE-6970 records failed renewals as `paused`, `payment_failed` should read as paused. About 850 workspaces are in `payment_failed` today. The banner copy for `payment_failed` was written for a dunning model where a failed payment is a warning before a pause. The backend never set `paused` on renewal failure (BE-6970), so `payment_failed` is the blocked state in practice, and the copy disagrees with the run lock. - **What**: - `paymentFailedView` reuses `pausedView` (title, body, Update payment) and keeps Pay invoice when a hosted https invoice URL exists. - Paused member banner is muted (grey circle-alert), matching the design reference; owner stays amber. - Removes the now-unused `billingStatus.warning` strings and the invoice amount formatting (Stripe decimal tables) that only fed that copy. - Who sees it is unchanged: `payment_failed` is still owner-only. - Temporary mapping, tied to BE-6970 in a one-line comment. When failed renewals arrive as `paused`, `payment_failed` stops being the blocked state and this can be revisited. - No E2E added: this is copy and icon selection inside the settings banner, driven by billing state that Playwright cannot put a real workspace into; `BillingStatusBanner.test.ts` covers the payment_failed copy and actions. - Design reference: [Subscription paused, owner](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30645), [member](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30669). | # | Step | Status | |---|------|--------| | 1 | Ramp `v1_payment_recovery` to 100% | done | | **2** | **Payment failed reads as paused; member paused icon grey (this PR)** | **this PR** | | 3 | Split Members credit limits off `billing_control_enabled` (#19641) | in review | | 4 | `billing_control_enabled` banner copy/roles per design review | next | | 5 | New "Plan ended" banner + Members footer | after 4 | | 6 | Ramp `billing_control_enabled`, then remove both gates | after 3-5 | ```mermaid flowchart LR A[1 ramp v1_payment_recovery] --> B[2 payment_failed copy - this PR]:::me C[3 split flags #19641] --> D[4 banner copy fixes] D --> F[6 ramp + remove gates] E[5 Plan ended banner] --> F B --> F classDef me fill:#3b5bdb,color:#fff ``` **AS IS** — `payment_failed`, owner: "Payment failed … update payment to avoid a pause". Paused member: amber icon. Captured from Storybook (`DISTRIBUTION=cloud`): real banner logic, demo billing data. `payment_failed`, owner (old): <img width="900" alt="AS IS payment_failed owner" src="https://github.com/user-attachments/assets/6c46c7dc-99ae-4f75-b3a8-d2c93157e236" /> Paused, member (old): <img width="900" alt="AS IS paused member" src="https://github.com/user-attachments/assets/d8bf876f-cfc5-4db9-9ad3-7127bd8e621c" /> **TO BE** — `payment_failed`, owner: "Subscription paused … Update payment to resume". Paused member: grey icon. `payment_failed`, owner (new): <img width="900" alt="TO BE payment_failed owner" src="https://github.com/user-attachments/assets/36cbf1db-c745-44e7-a74b-b776aecfd253" /> Paused, member (new): <img width="900" alt="TO BE paused member" src="https://github.com/user-attachments/assets/deedd2e7-4c1d-4f8d-8568-e192fa0bcd72" /> - Fixes FE-3135 (cherry picked from commit 13a9333) (cloud/1.55's BillingStatusBanner.vue and BillingStatusBanner.test.ts are byte-identical to core/1.55's, so this is the same resolution as the core/1.55 carrier.)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2138 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (7 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4698ff509ec91cc527a26f4bc3c8f421d7b49274
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T11:26:17.202Z",
"gitSha": "40460bd542c27319a54f5297734db97c3ff3caef",
"branch": "glary/carrier-backport-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.3300000000286,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.503000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.682,
"heapDeltaBytes": 4034916,
"heapUsedBytes": 71768048,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.418000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.8170000000218,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.233,
"heapDeltaBytes": 9876612,
"heapUsedBytes": 77549628,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.305999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.2879999999973,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.24,
"heapDeltaBytes": -6328020,
"heapUsedBytes": 61377680,
"domNodes": -259,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 158.244,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1766.9399999999769,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.886999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 844.37,
"heapDeltaBytes": 11514060,
"heapUsedBytes": 79299360,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 166.249,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.9929999999972,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.168999999999999,
"layouts": 6,
"layoutDurationMs": 1.0439999999999998,
"taskDurationMs": 242.81900000000005,
"heapDeltaBytes": 3013104,
"heapUsedBytes": 70658116,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.416,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6250000000837,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.608999999999998,
"layouts": 6,
"layoutDurationMs": 1.1190000000000002,
"taskDurationMs": 329.29300000000006,
"heapDeltaBytes": 2678020,
"heapUsedBytes": 70435012,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.957,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 623.8199999999665,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.979000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.82899999999995,
"heapDeltaBytes": 18956156,
"heapUsedBytes": 86314792,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 162.769,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 640.3149999999869,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.697,
"heapDeltaBytes": 18513920,
"heapUsedBytes": 86438256,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 166.548,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1164.3810000000485,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.0059999999999,
"heapDeltaBytes": 35443024,
"heapUsedBytes": 107106952,
"domNodes": 0,
"jsHeapTotalBytes": 20606976,
"scriptDurationMs": 66.692,
"eventListeners": 0,
"totalBlockingTimeMs": 558,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1165.728999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 822.8930000000001,
"heapDeltaBytes": 38402076,
"heapUsedBytes": 107696568,
"domNodes": 0,
"jsHeapTotalBytes": 20869120,
"scriptDurationMs": 71.85600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 553,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.4650000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.5059999999992,
"heapDeltaBytes": 14280732,
"heapUsedBytes": 90638100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.476,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 831.4770000000635,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.5089999999998,
"heapDeltaBytes": 14377232,
"heapUsedBytes": 90660624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.887,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10365.715000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9448.196000000002,
"heapDeltaBytes": -9515284,
"heapUsedBytes": 72574216,
"domNodes": -14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8008.193,
"eventListeners": 0,
"totalBlockingTimeMs": 1304,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8985.534000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8162.032999999999,
"heapDeltaBytes": 11655288,
"heapUsedBytes": 93836524,
"domNodes": -14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6915.581,
"eventListeners": 0,
"totalBlockingTimeMs": 743,
"frameDurationMs": 20.003333333333345,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10632.138999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9737.342999999999,
"heapDeltaBytes": 11844328,
"heapUsedBytes": 93711888,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8070.005,
"eventListeners": 0,
"totalBlockingTimeMs": 1200,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.99999999999818
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10066.350000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9204.945,
"heapDeltaBytes": 10189628,
"heapUsedBytes": 85861088,
"domNodes": -4,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7635.995999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 900,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2073.138999999969,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.920999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.773,
"heapDeltaBytes": -6044720,
"heapUsedBytes": 80620424,
"domNodes": -245,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.407000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.2189999999455,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.886999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.412,
"heapDeltaBytes": -3356616,
"heapUsedBytes": 83609592,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 36.089999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2207.140000000038,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.214000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1615.5300000000002,
"heapDeltaBytes": 15546644,
"heapUsedBytes": 80172332,
"domNodes": -246,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 852.553,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2296.30300000008,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.883000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1636.9540000000002,
"heapDeltaBytes": 2122540,
"heapUsedBytes": 84477996,
"domNodes": -244,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 843.183,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3440.8860000000345,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.099999999999998,
"layouts": 60,
"layoutDurationMs": 12.597999999999999,
"taskDurationMs": 1633.6779999999999,
"heapDeltaBytes": 8294196,
"heapUsedBytes": 74598772,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.274,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3537.4510000000328,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.679999999999998,
"layouts": 60,
"layoutDurationMs": 12.722999999999999,
"taskDurationMs": 1664.6480000000001,
"heapDeltaBytes": 7762524,
"heapUsedBytes": 74434532,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 794.659,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3024.622000000022,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.355999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.018,
"heapDeltaBytes": 21352064,
"heapUsedBytes": 87238312,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 970.153,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3094.149000000016,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.079999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1882.372,
"heapDeltaBytes": 17285072,
"heapUsedBytes": 83488432,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 968.2979999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.7160000000408,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.809000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.2979999999999,
"heapDeltaBytes": -4783200,
"heapUsedBytes": 84315896,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 27.810000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2001.1329999999816,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.2039999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.36,
"heapDeltaBytes": 20112064,
"heapUsedBytes": 84793224,
"domNodes": -3,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.854999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.7110000000221,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.373000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.041,
"heapDeltaBytes": 13680416,
"heapUsedBytes": 83660012,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 141.447,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.3629999999284,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.31,
"heapDeltaBytes": 14000360,
"heapUsedBytes": 84052240,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.035,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.812000000025,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.488000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.47999999999996,
"heapDeltaBytes": -11956064,
"heapUsedBytes": 57872920,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.538000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.1820000000334,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.042000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.813,
"heapDeltaBytes": 10394440,
"heapUsedBytes": 79571324,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.676,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.34200000002,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.732000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.36,
"heapDeltaBytes": -7632728,
"heapUsedBytes": 62435140,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 99.247,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.412999999986,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.471,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 784.7800000000001,
"heapDeltaBytes": 10220592,
"heapUsedBytes": 79743300,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 111.827,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5510000000113,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.032000000000007,
"layouts": 5,
"layoutDurationMs": 12.905,
"taskDurationMs": 866.3629999999999,
"heapDeltaBytes": 23220056,
"heapUsedBytes": 96133512,
"domNodes": 13667,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 28.936000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8431.87899999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5911.945000000001,
"heapDeltaBytes": -2193360,
"heapUsedBytes": 84619736,
"domNodes": -240,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 2799.514,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8505.429999999933,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.676,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5902.862,
"heapDeltaBytes": -5979488,
"heapUsedBytes": 81087748,
"domNodes": -223,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2887.372,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15488.292000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14892.747,
"heapDeltaBytes": -30292436,
"heapUsedBytes": 191340348,
"domNodes": -8061,
"jsHeapTotalBytes": -10293248,
"scriptDurationMs": 223.99599999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16546.157999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15864.275000000003,
"heapDeltaBytes": -56261132,
"heapUsedBytes": 184236232,
"domNodes": -8061,
"jsHeapTotalBytes": -14536704,
"scriptDurationMs": 253.77099999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20347.34400000002,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.440000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20007.859,
"heapDeltaBytes": -53148812,
"heapUsedBytes": 181308384,
"domNodes": -8061,
"jsHeapTotalBytes": -13934592,
"scriptDurationMs": 887.3249999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20551.701999999976,
"styleRecalcs": 158,
"styleRecalcDurationMs": 17.371000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20273.322999999997,
"heapDeltaBytes": -42848816,
"heapUsedBytes": 171882220,
"domNodes": -8065,
"jsHeapTotalBytes": -12652544,
"scriptDurationMs": 901.369,
"eventListeners": -14928,
"totalBlockingTimeMs": 120,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5785.385000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.70000000000002,
"layouts": 20,
"layoutDurationMs": 22.48,
"taskDurationMs": 5680.617000000001,
"heapDeltaBytes": -48116020,
"heapUsedBytes": 175433024,
"domNodes": -8061,
"jsHeapTotalBytes": 10002432,
"scriptDurationMs": 99.10300000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 452,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6095.626000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.271,
"layouts": 20,
"layoutDurationMs": 22.616999999999997,
"taskDurationMs": 6002.229,
"heapDeltaBytes": -46123492,
"heapUsedBytes": 182164080,
"domNodes": -8061,
"jsHeapTotalBytes": 10285056,
"scriptDurationMs": 110.80000000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 358,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7863.427999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7458.161,
"heapDeltaBytes": -7018324,
"heapUsedBytes": 175726160,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 114.38700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8497.33399999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8228.075,
"heapDeltaBytes": -6642848,
"heapUsedBytes": 178282924,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 134.6719999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 474.435000000085,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.327000000000005,
"layouts": 4,
"layoutDurationMs": 1.7239999999999998,
"taskDurationMs": 129.899,
"heapDeltaBytes": 5273988,
"heapUsedBytes": 67357644,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.594999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 481.09599999997954,
"styleRecalcs": 21,
"styleRecalcDurationMs": 26.855000000000004,
"layouts": 5,
"layoutDurationMs": 2.359,
"taskDurationMs": 137.083,
"heapDeltaBytes": 5124256,
"heapUsedBytes": 70807172,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.625,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No action needed — same as on #19746, this is CodeRabbit's "review skipped" status note rather than a finding. The skip is intentional: this repo's Coverage for this change:
Leaving this to CI to gate as normal. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19748 +/- ##
=============================================
Coverage ? 84.63%
=============================================
Files ? 2315
Lines ? 132047
Branches ? 33393
=============================================
Hits ? 111762
Misses ? 19925
Partials ? 360
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…opy for payment_failed renewals (#19677) (#19746) Manual backport of #19677 to `core/1.55`. Companion to #19748 (`cloud/1.55`). Cherry-picked from upstream merge commit `13a9333e5426d6e2e2f5f61d3da72a8184176a75` (squashed onto main as `aed795880dc552b53d8fd55bd7c1adc099d07c1c`). ## Why For a `payment_failed` renewal the run button is already locked, but the settings banner said "Update payment to avoid a pause" - copy describing a warning stage that does not exist, because the backend never sets `paused` on renewal failure (BE-6970). `payment_failed` now reads as paused, and the member paused banner gets the informational grey icon. ## Target refresh The carrier was 2 commits behind `core/1.55` and the target-aware guard refused on target-tip staleness alone. The target branch was merged in - no rebase, no force-push, no conflicts. - previous head `6fc92b38b2c726d8df6ea807673d39d0bfe938f3` - merged-in `core/1.55` tip `cc2945c0325048da3fa43d9d6b11959dc6205539` - reviewed head `b5f4303dd827196e45bd18bc17cab5c652733028` `git diff --stat origin/core/1.55 b5f4303` is unchanged from the pre-merge delta (3 files, +7/-24), so the target merge contributed no payload. That delta is byte-identical to the upstream source commit `aed795880d` on main and to the already-merged `cloud/1.55` twin `26c10985c6`. ## Validation at the reviewed head - `vitest run BillingStatusBanner.test.ts` - 20/20 passing. It asserts rendered DOM via `screen.getByRole('status')`, so it pins the user-visible copy rather than an internal call. - `vue-tsc --noEmit` - exit 0. - No black-box coverage exists for these banner states on any branch; upstream added none, noting Playwright cannot drive a real workspace into these billing states. Nothing was skipped or weakened. - All hosted checks terminal at the reviewed head: 90 pass, 15 skipped, 0 failures. No `Vercel - billing-web-test` status is present on this carrier, so the `core/1.54`/`cloud/1.54` waiver was neither relied on nor extended to the 1.55 line. Original PR: #19677 / Original commit: `13a9333e5426d6e2e2f5f61d3da72a8184176a75` Justification: Standing Agent release-backport grant for the 1.54 and 1.55 trains (program/active-authority.md, effective 2026-09-27 for 1.55). Independent exact-head audit found the backport byte-identical to the upstream source and to the already- merged cloud/1.55 twin; all hosted checks are terminal green at b5f4303 with zero failures; the target-aware guard reports MERGE READY with no unresolved threads and no reviewer objections. Reviewed by COMMENT rather than approval because the merging identity is the PR author and the grant forbids manufacturing an approval record. REVIEW_REQUIRED alone is not an added approval requirement under this grant.
PR Created by the Glary-Bot Agent
Manual backport of #19677 to
cloud/1.55, from the v1.56.2 backport-status report. Companion to #19746 (core/1.55).Cherry-picked from upstream merge commit
13a9333e54.Requested in #frontend-releases as a cherry-pick "carrier" backport, one per target branch. #19677 is the only PR the report flags for
cloud/1.55that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below.Why
For a
payment_failedrenewal the run button is already locked, but the settings banner said "Update payment to avoid a pause" — copy describing a warning stage that does not exist, because the backend never setspausedon renewal failure (BE-6970).payment_failednow reads as paused, and the member paused banner gets the informational grey icon.Conflict resolution
Identical to #19746:
BillingStatusBanner.vueandBillingStatusBanner.test.tsare byte-identical betweencore/1.55andcloud/1.55at their bases (verified by blob hash), so this is the same resolution.cloud/1.55predates main's refactor of this banner into per-kind view factories, and has no renewal-invoice support:BannerViewhas nopayInvoiceUrl, the template has no Pay invoice button, there is nopayInvoicestring, anduseBillingContextdoes not exposerenewalInvoice. The upstream diff was applied as behaviour, not as text.BillingStatusBanner.vue— kept this branch's singleswitch-basedbannercomputed rather than main'spausedView()/paymentFailedView()factories. Accept-theirs would have produced a broken hybrid and dragged in an unrelatedisEnterprisePlanending-copy change not on this branch.paymentFailednow shares thepausedcase, andpausedis muted for members. The Pay invoice branch is omitted — that feature does not exist here.BillingStatusBanner.test.ts— dropped upstream's edits to therenewal invoicedescribe block; that block does not exist on this branch. Kept the renamed payment_failed test and its updated paused-copy assertions.src/locales/en/main.json— removed the now-unusedbillingStatus.warningstrings. This file is not identical between the 1.55 branches, so the conflict was resolved in place rather than by reusing thecore/1.55blob; thebillingStatussub-tree is identical (verified by hash) and the banner was the strings' only consumer.Semantics preserved exactly: upstream's
pausedView()is{ muted: !canManage, title: paused.title, body: canManage ? paused.body : paused.memberBody, action: canManage ? 'updatePayment' : null, dismissible: false }, and the mergedcase 'paused'/'paymentFailed'arm reproduces that.useBillingBannergatespaymentFailedoncanManage, so the newly-gatedactionandmutedresolve to the same values upstream produces.No backport-only compatibility shim was needed; no public API shape or callback signature changed. The resulting net diff is identical to #19746 (3 files, +7/−24).
Validation
pnpm test:unit BillingStatusBanner.test.ts— 20/20 passingpnpm typecheck— exit 0pnpm exec oxfmt --checkon changed files — cleancore/1.55component tree (see [backport core/1.55] FE-3135 fix(billing): show Subscription paused copy for payment_failed renewals (#19677) #19746 for screenshots and the live-DOM icon-class/colour table):payment_failedowner flips from "Payment failed / …avoid a pause" to "Subscription paused / …Update payment to resume", and the paused member icon flips from ambericon-[lucide--triangle-alert]rgb(252,191,100)to greyicon-[lucide--circle-alert]rgb(73,74,80), with the paused owner unchanged.No E2E added — matching upstream, which notes Playwright cannot put a real workspace into these billing states.
Why this carrier holds one commit
The report flagged four PRs as "❗ Need backport". Two cannot be carried:
refs/pull/19053/headexists; it is 69 commits ahead ofmainwith no squash commit, which is why the report listed it without a(#NNNNN)suffix. There is nothing to cherry-pick.cloud/1.55, but its prerequisite is missing on every target branch. Its mechanism marks the target unavailable so the in-chat notice from fix(agent): reopen saved workflows from chat history #18866 renders. NeithermarkWorkflowTargetUnavailable/targetUnavailablenor thetargetWorkflowUnavailablestring exists oncore/1.54,cloud/1.54,core/1.55orcloud/1.55, and the 1.55 branches still use the olderWorkflowTargetSelectionmodel instead ofTargetTracking— so the cherry-pick does not even apply here. Carrying it would set a state nothing renders, a silent no-op defeating the fix. It needs fix(agent): reopen saved workflows from chat history #18866 backported first.#18074 is labelled
core/1.54+cloud/1.54only, so it is not in this branch's scope.Original PR: #19677 / Original commit:
13a9333e5426d6e2e2f5f61d3da72a8184176a75Justification: Standing Agent release-backport grant; independent exact-head audit found faithful cloud/1.55 adaptation, all hosted checks are terminal green at aed7958, and the live target advanced by three commits with zero changed-file overlap. REVIEW_REQUIRED alone is not an added approval requirement for this grant.