Repository navigation
refactor: let billing rails announce refreshes instead of reading the context - #19148
Conversation
📦 Bundle: 9.45 MB gzip 🔴 +8.57 kBDetailsSummary
Category Glance App Entry Points — 5.21 kB (baseline 4.98 kB) • 🔴 +229 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.45 MB (baseline 2.45 MB) • 🔴 +1.3 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • 🔴 +132 BTop-level views, pages, and routed surfaces
Status: 6 added / 6 removed / 12 unchanged Panels & Settings — 670 kB (baseline 670 kB) • 🔴 +296 BConfiguration panels, inspectors, and settings screens
Status: 3 added / 3 removed / 26 unchanged User & Accounts — 289 kB (baseline 277 kB) • 🔴 +12.4 kBAuthentication, profile, and account management bundles
Status: 4 added / 3 removed / 14 unchanged Editors & Dialogs — 345 kB (baseline 340 kB) • 🔴 +5.07 kBModals, dialogs, drawers, and in-app editors
Status: 6 added / 5 removed / 7 unchanged UI Components — 212 kB (baseline 212 kB) • 🔴 +123 BReusable component library chunks
Status: 3 added / 3 removed / 21 unchanged Data & Services — 2.17 MB (baseline 2.17 MB) • 🔴 +184 BStores, services, APIs, and repositories
Status: 2 added / 2 removed / 22 unchanged Utilities & Hooks — 984 kB (baseline 1 MB) • 🟢 -16.3 kBHelpers, composables, and utility bundles
Status: 19 added / 14 removed / 49 unchanged Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 19.4 MB (baseline 19.4 MB) • 🔴 +14.2 kBBundles that do not match a named category
Status: 53 added / 49 removed / 299 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-14T21:05:48.515Z",
"gitSha": "25822e3dd762f77e9d1f4e25d72ebb998c04e17b",
"branch": "drjkl/billing-layering",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.7589999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.89,
"layouts": 10,
"layoutDurationMs": 3.006,
"taskDurationMs": 568.298,
"heapDeltaBytes": -4468456,
"heapUsedBytes": 74234988,
"domNodes": -182,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.594000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.7980000000089,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.723,
"layouts": 9,
"layoutDurationMs": 2.6,
"taskDurationMs": 538.676,
"heapDeltaBytes": 2491660,
"heapUsedBytes": 80984564,
"domNodes": -162,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.869999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.4240000000364,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.983,
"layouts": 11,
"layoutDurationMs": 2.9570000000000003,
"taskDurationMs": 748.601,
"heapDeltaBytes": 1564084,
"heapUsedBytes": 79873856,
"domNodes": -162,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 158.184,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.8310000000083,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.796999999999999,
"layouts": 10,
"layoutDurationMs": 2.8720000000000003,
"taskDurationMs": 877.281,
"heapDeltaBytes": -1982604,
"heapUsedBytes": 76422368,
"domNodes": -162,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 155.808,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0360000000455,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.987,
"layouts": 11,
"layoutDurationMs": 2.817999999999999,
"taskDurationMs": 406.84299999999996,
"heapDeltaBytes": 22051304,
"heapUsedBytes": 85981960,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.355000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4439999999486,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.57,
"layouts": 12,
"layoutDurationMs": 3.3799999999999994,
"taskDurationMs": 299.765,
"heapDeltaBytes": -2542712,
"heapUsedBytes": 75735428,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.296000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 679.0060000000153,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.501,
"layouts": 9,
"layoutDurationMs": 2.406,
"taskDurationMs": 493.98,
"heapDeltaBytes": 5843308,
"heapUsedBytes": 84253684,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 169.46,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926833,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 709.4160000000329,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.646,
"layouts": 9,
"layoutDurationMs": 2.255,
"taskDurationMs": 523.771,
"heapDeltaBytes": 5914804,
"heapUsedBytes": 84234496,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 178.12,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.070731707317076,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1237.6529999999661,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 951.8350000000002,
"heapDeltaBytes": 16598896,
"heapUsedBytes": 96391096,
"domNodes": 0,
"jsHeapTotalBytes": 18776064,
"scriptDurationMs": 75.01799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 598,
"frameDurationMs": 36.27352941176471,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1187.1210000000474,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.247,
"heapDeltaBytes": 16796052,
"heapUsedBytes": 96657824,
"domNodes": 0,
"jsHeapTotalBytes": 16154624,
"scriptDurationMs": 67.823,
"eventListeners": 0,
"totalBlockingTimeMs": 551,
"frameDurationMs": 34.80294117647057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.4560000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.5599999999999,
"heapDeltaBytes": -5243552,
"heapUsedBytes": 73385476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.95900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 828.5359999999855,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.9530000000002,
"heapDeltaBytes": -4745692,
"heapUsedBytes": 73792960,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.64299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 205,
"frameDurationMs": 24.51176470588237,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9755.349000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8800.602,
"heapDeltaBytes": 11888108,
"heapUsedBytes": 94839916,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7397.654,
"eventListeners": 0,
"totalBlockingTimeMs": 1010,
"frameDurationMs": 32.716778523489936,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9499.923999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8687.871,
"heapDeltaBytes": 9525260,
"heapUsedBytes": 92888180,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6988.417,
"eventListeners": 0,
"totalBlockingTimeMs": 642,
"frameDurationMs": 31.248355263157894,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10308.465000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9472.021,
"heapDeltaBytes": 10287588,
"heapUsedBytes": 94104516,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7760.347,
"eventListeners": 0,
"totalBlockingTimeMs": 951,
"frameDurationMs": 31.022891566265063,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9148.725000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8348.108,
"heapDeltaBytes": -12420032,
"heapUsedBytes": 70993968,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7038.295,
"eventListeners": 0,
"totalBlockingTimeMs": 761,
"frameDurationMs": 31.880139372822303,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 214.16399999998248,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.604000000000001,
"layouts": 8,
"layoutDurationMs": 2.342,
"taskDurationMs": 153.72299999999998,
"heapDeltaBytes": 13145656,
"heapUsedBytes": 77399064,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.636,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 204.9289999999928,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.491000000000001,
"layouts": 8,
"layoutDurationMs": 2.404,
"taskDurationMs": 146.132,
"heapDeltaBytes": 13028004,
"heapUsedBytes": 75948604,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.6,
"eventListeners": 195,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2037.0919999999728,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1860000000000004,
"layouts": 8,
"layoutDurationMs": 2.4599999999999995,
"taskDurationMs": 625.9709999999999,
"heapDeltaBytes": -28281564,
"heapUsedBytes": 70766324,
"domNodes": -258,
"jsHeapTotalBytes": -749568,
"scriptDurationMs": 37.99100000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.1080000000647,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.396,
"layouts": 8,
"layoutDurationMs": 2.646,
"taskDurationMs": 451.05799999999994,
"heapDeltaBytes": -14433996,
"heapUsedBytes": 70621888,
"domNodes": -258,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 31.72200000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2457.898,
"styleRecalcs": 65,
"styleRecalcDurationMs": 4.953,
"layouts": 4,
"layoutDurationMs": 1.0730000000000002,
"taskDurationMs": 1593.0559999999998,
"heapDeltaBytes": 14571240,
"heapUsedBytes": 79942712,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 805.964,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665986394557827,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2448.6689999999953,
"styleRecalcs": 64,
"styleRecalcDurationMs": 4.629,
"layouts": 3,
"layoutDurationMs": 0.6219999999999998,
"taskDurationMs": 1635.7189999999998,
"heapDeltaBytes": 11049912,
"heapUsedBytes": 76240632,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 797.7800000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3753.8710000000037,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.907000000000001,
"layouts": 60,
"layoutDurationMs": 9.250000000000002,
"taskDurationMs": 1728.6520000000003,
"heapDeltaBytes": -1001588,
"heapUsedBytes": 66436584,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.09,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666371681415928,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3587.53999999999,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.075999999999998,
"layouts": 61,
"layoutDurationMs": 9.399,
"taskDurationMs": 1659.381,
"heapDeltaBytes": -1030836,
"heapUsedBytes": 66026940,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 742.5070000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665581395348834,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3062.033999999983,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.589,
"layouts": 2,
"layoutDurationMs": 0.3830000000000001,
"taskDurationMs": 1950.6819999999998,
"heapDeltaBytes": 4033564,
"heapUsedBytes": 71170512,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 977.6610000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.849723756906073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3068.7980000000152,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.6830000000000007,
"layouts": 1,
"layoutDurationMs": 0.24100000000000077,
"taskDurationMs": 1983.8700000000001,
"heapDeltaBytes": 13009716,
"heapUsedBytes": 82485344,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 994.803,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.850276243093926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.1099999999647,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0690000000000004,
"layouts": 4,
"layoutDurationMs": 1.0779999999999996,
"taskDurationMs": 570.5269999999999,
"heapDeltaBytes": 6776988,
"heapUsedBytes": 72096792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.900000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.5590000000257,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.849,
"layouts": 6,
"layoutDurationMs": 1.9960000000000004,
"taskDurationMs": 466.255,
"heapDeltaBytes": -33354920,
"heapUsedBytes": 71453280,
"domNodes": -258,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 36.025,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.5630000000019,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.52,
"layouts": 9,
"layoutDurationMs": 2.8879999999999995,
"taskDurationMs": 408.85600000000005,
"heapDeltaBytes": -222656,
"heapUsedBytes": 80038292,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 155.09300000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.2839999999496,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.057999999999999,
"layouts": 9,
"layoutDurationMs": 2.8440000000000003,
"taskDurationMs": 439.80400000000003,
"heapDeltaBytes": -232060,
"heapUsedBytes": 80149184,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 146.73,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.7679999999946,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.946999999999999,
"layouts": 10,
"layoutDurationMs": 3.162,
"taskDurationMs": 412.40500000000003,
"heapDeltaBytes": -21685392,
"heapUsedBytes": 58528280,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8.735,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.94200000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.503,
"layouts": 9,
"layoutDurationMs": 2.517,
"taskDurationMs": 553.945,
"heapDeltaBytes": 634540,
"heapUsedBytes": 81038520,
"domNodes": -180,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.235000000000001,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.0700000000065,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.411,
"layouts": 10,
"layoutDurationMs": 2.6519999999999997,
"taskDurationMs": 717.981,
"heapDeltaBytes": -1030460,
"heapUsedBytes": 79182344,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 110.28299999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.329000000027,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.369999999999997,
"layouts": 10,
"layoutDurationMs": 2.463,
"taskDurationMs": 841.737,
"heapDeltaBytes": -3218112,
"heapUsedBytes": 77129184,
"domNodes": -180,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 106.906,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1437.5800000000254,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.525999999999993,
"layouts": 5,
"layoutDurationMs": 15.874000000000002,
"taskDurationMs": 1061.5259999999998,
"heapDeltaBytes": 7633220,
"heapUsedBytes": 103664800,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 27.378999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 154,
"frameDurationMs": 19.333333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9492.781000000035,
"styleRecalcs": 246,
"styleRecalcDurationMs": 16.918999999999997,
"layouts": 4,
"layoutDurationMs": 1.0019999999999998,
"taskDurationMs": 5785.544,
"heapDeltaBytes": 25415984,
"heapUsedBytes": 89981080,
"domNodes": 0,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2666.3320000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69542253521127,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8277.145000000019,
"styleRecalcs": 248,
"styleRecalcDurationMs": 17.299000000000003,
"layouts": 6,
"layoutDurationMs": 1.6450000000000002,
"taskDurationMs": 4897.708,
"heapDeltaBytes": 21642228,
"heapUsedBytes": 85677568,
"domNodes": -258,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 2625.6589999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699797570850205,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22815.206999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21945.095,
"heapDeltaBytes": -48827844,
"heapUsedBytes": 258839992,
"domNodes": -3330,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 316.355,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.47370242214534,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 22768.471999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21872.329999999998,
"heapDeltaBytes": 19642228,
"heapUsedBytes": 271714244,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 308.316,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.049399656946825,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19032.272999999976,
"styleRecalcs": 164,
"styleRecalcDurationMs": 12.961,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18640.775,
"heapDeltaBytes": -10411596,
"heapUsedBytes": 273303904,
"domNodes": -3330,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 941.7660000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 30,
"frameDurationMs": 35.31113172541743,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27576.587000000018,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.174999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27171.18,
"heapDeltaBytes": -43609412,
"heapUsedBytes": 253915020,
"domNodes": -3330,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 927.203,
"eventListeners": -651,
"totalBlockingTimeMs": 52,
"frameDurationMs": 51.33240223463687,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 5927.385999999956,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.06,
"layouts": 20,
"layoutDurationMs": 22.924,
"taskDurationMs": 5794.156999999999,
"heapDeltaBytes": -17110276,
"heapUsedBytes": 270973384,
"domNodes": -3330,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 146.26,
"eventListeners": -653,
"totalBlockingTimeMs": 149,
"frameDurationMs": 35.10710059171598,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8177.5989999999865,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.186,
"layouts": 20,
"layoutDurationMs": 29.42,
"taskDurationMs": 7986.952999999999,
"heapDeltaBytes": -13722420,
"heapUsedBytes": 274720052,
"domNodes": -3330,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 148.506,
"eventListeners": -653,
"totalBlockingTimeMs": 103,
"frameDurationMs": 45.97191011235955,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11654.371999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11327.571,
"heapDeltaBytes": 14180300,
"heapUsedBytes": 258912760,
"domNodes": 0,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 157.43699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.89554794520548,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11526.414999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11134.233000000002,
"heapDeltaBytes": 33056688,
"heapUsedBytes": 287662276,
"domNodes": 0,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 162.97399999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.4958904109589,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 157.41499999990083,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.019999999999998,
"layouts": 10,
"layoutDurationMs": 4.216,
"taskDurationMs": 107.43499999999999,
"heapDeltaBytes": 4645208,
"heapUsedBytes": 80570736,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.112,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 468.8099999999622,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.069,
"layouts": 12,
"layoutDurationMs": 3.9299999999999993,
"taskDurationMs": 120.822,
"heapDeltaBytes": -13199784,
"heapUsedBytes": 63006468,
"domNodes": 95,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.061000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 468.00999999993564,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.856,
"layouts": 76,
"layoutDurationMs": 14.668000000000001,
"taskDurationMs": 426.211,
"heapDeltaBytes": 11573860,
"heapUsedBytes": 101522992,
"domNodes": 4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 211.391,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662068965517236,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 455.6330000000344,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.055,
"layouts": 76,
"layoutDurationMs": 14.78,
"taskDurationMs": 409.415,
"heapDeltaBytes": 11265588,
"heapUsedBytes": 98181944,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 196.585,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 532.1199999999635,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8010000000000002,
"layouts": 76,
"layoutDurationMs": 13.423,
"taskDurationMs": 492.02000000000004,
"heapDeltaBytes": 116308,
"heapUsedBytes": 119578516,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 202.141,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 634.0509999999995,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8519999999999999,
"layouts": 76,
"layoutDurationMs": 14.843,
"taskDurationMs": 589.982,
"heapDeltaBytes": 775852,
"heapUsedBytes": 117334160,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 253.58400000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.594444444444434,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d0afe383f4c79f20617902007463929b160cd073
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19148 +/- ##
==========================================
+ Coverage 86.40% 87.19% +0.79%
==========================================
Files 3680 2622 -1058
Lines 175372 146963 -28409
Branches 48395 40298 -8097
==========================================
- Hits 151532 128146 -23386
+ Misses 21798 18429 -3369
+ Partials 2042 388 -1654
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1071 files with indirect coverage changes 🚀 New features to boost your workflow:
|
967724a to
ef85a04
Compare
6dfa999 to
724c342
Compare
ef85a04 to
1a51249
Compare
This comment has been minimized.
This comment has been minimized.
1a51249 to
e3f6d62
Compare
724c342 to
b63ac2e
Compare
e3f6d62 to
dec93c7
Compare
dec93c7 to
460bc03
Compare
460bc03 to
4e14412
Compare
## Summary `types/comfy.ts` is the public extension contract, yet it imported `scripts/widgets`, `scripts/ui`, and the workflow store, so every module that typed against `ComfyApp` was pulled into the app's largest import cycle. This PR makes `types/comfy.ts`, `types/extensionTypes.ts`, and `comfyWorkflow.ts` leaves: they no longer reach `scripts/appInstance`. Before the review fixes, depcruise measured the 273-module app SCC splitting into 119 + 58 modules. Import-cycle measurements before the review fixes: 371 -> 341 cyclic modules, largest SCC 154 -> 154 (litegraph), 1451 -> 1335 cyclic edges, on `main` df4ea6d (Comfy-Org#19143 merged as cdc9fe0). These counts have not been remeasured after restoring the extension hooks. `workflowStoreTypes.ts` carries main's `nodeLocatorIdToNodeId: ... => NodeId | null` signature, which landed on `main` after the interface moved. Targets `main` directly, rebased onto df4ea6d after Comfy-Org#19143 merged (cdc9fe0). Tracks FE-2769 / FE-3037. ## Changes - `ComfyWidgetConstructor` / `CustomComfyWidgetConstructor` are declared in `types/comfy.ts`; `scripts/widgets.ts` imports them. `ComfyApp.widgets` is typed as `Record<string, ComfyWidgetConstructor | CustomComfyWidgetConstructor>` instead of `typeof ComfyWidgets`, and `dynamicComboWidget` narrows the result of `app.widgets.COMBO`. - `MissingModelPipelineResult` moves to `platform/missingModel/types.ts`; `groupCandidatesByName` moves into `missingModelGrouping.ts` so grouping stops importing scan. - `scripts/ui.ts`: `ComfyUI(app, host)` takes the app and a `LegacyMenuHost` (`resetView`, `restoreOutputs`, `trackRunButton`, `enterFocusMode`) instead of calling `useApp()`, `litegraphService`, `nodeOutputStore`, `workspaceStore`, and `useRunButtonTelemetry`. `app.ts` wires the host. - `comfyWorkflow.ts` becomes a leaf. `WorkflowChangeTracker` is an interface `ChangeTracker` implements. A `WorkflowRuntime` (`createChangeTracker`, draft get/remove/markUsed, `isDraftPersistenceEnabled`) is registered by `workflowStore.ts` at module scope, replacing the dynamic `import('@/scripts/changeTracker')` and the direct settings/draft-store imports. - `ComfyWorkflow.promptSave()` remains an extension override point. Its default delegates to the registered `WorkflowRuntime`, which opens the dialog using `saveNamePrompt` i18n keys, overridden by `SubgraphBlueprint`. `workflowService.saveWorkflowAs` continues calling the hook. - Clipspace editor save honors `ComfyApp.pasteFromClipspace` overrides. Image paste updates store-backed outputs without requiring legacy previews and skips absent selections while still pasting widget values. - New leaf `workflowStoreTypes.ts` exports the `WorkflowStore` interface; `ExtensionManager.workflow` is typed as `WorkflowStore`. - New leaf `services/dialogServiceTypes.ts` with `CoreDialogService`, `ExtensionDialogService`, `ConfirmOptions`, `ExecutionErrorDialogInput`; `useDialogService()` returns `CoreDialogService` and `extensionTypes.ts` imports the leaf. `ExtensionDialogService` carries main's current signatures (`showCancelSubscriptionDialog` scope/confirmed args, `paymentIntentSource`, `showInviteLinkInvalidDialog`, `showInviteWrongAccountDialog`). - `comfyWorkflow.test.ts` deleted (it tested the dynamic-import failure path that no longer exists); `workflowService.test.ts` mocks `useDialogService().prompt` and asserts the save-name copy; `ui.test.ts` / `ui.setStatus.test.ts` pass the app and a stub host. ## Review Focus - `ComfyApp.widgets` loses the `typeof ComfyWidgets` key typing. Core widget constructors are still reachable as `useWidgetStore().coreWidgets`; extension code indexing `app.widgets.<Name>` now gets the union type. - `ExtensionManager.workflow` no longer exposes Pinia `$`-methods on the public type. Extensions calling `app.extensionManager.workflow.$patch` would be a type break (runtime unchanged). - `ComfyWorkflow.promptSave` is preserved because [RigShare](https://github.com/xiaodoudou/ComfyUI-RigShare/blob/3de3cc32e2a5bd266879dd6b346f8960ad4dd619/web/rigshare/save-dialog.js#L22) and [Bada-Utils](https://github.com/bada-ya/ComfyUI-Bada-Utils/blob/0898b33e803df8e169501d8fe0cf1fd04044f7bf/web/workflow_organizer.js#L2996) wrap its prototype implementation to customize Save As. A regression test checks that an override's filename reaches the save path. - `workflowStore.ts` now imports `ChangeTracker` statically. fallow sees the previously dynamic `comfyWorkflow -> workflowStore -> changeTracker` 3-cycle reshaped into two short `workflowStore <-> changeTracker` cycles; this plus 28 pre-existing cycles fallow newly enumerates (auth/session, api <-> authStore <-> dialogService, promotionUtils through canvasStore and litegraphService, useAppMode -> workflowStore -> changeTracker -> executionStore, workflowStore <-> executionStore, canvasStore <-> litegraphUtil) are baselined in `.fallow-baselines/dead-code.json`. Breaking `changeTracker -> workflowStore` needs a host injection into `ChangeTracker` and a rewrite of its 1400-line test, so it is left for a follow-up. - `dynamicComboWidget` keeps the runtime lookup through `app.widgets.COMBO`. A static import of `useComboWidget` or `widgetStore` from `dynamicWidgets.ts` creates a module-evaluation cycle with `scripts/widgets.ts` (`...dynamicWidgets` spread sees an uninitialised binding), which is why the assert-based narrowing is used instead. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352 | 172 -> 149 | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | **Comfy-Org#19153** (this PR) | **Comfy-Org#19148** | **`types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves** | **324 -> 293** | **149 (baseline)** | | Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end --> --------- Co-authored-by: Amp <amp@ampcode.com>
Import cycles: 361 -> 323 cyclic modules, 14 -> 4 cycles, largest SCC 153 -> 153. Breaks the small strongly connected components outside litegraph and the app core by extracting leaf modules and inverting dependencies: - scripts/ui: `LegacyUIApp` interface typed on ComfyUI/ComfyList; the unused `app` field/ctor param dropped from ComfySettingsDialog and ComfyAppMenu; button.ts and applyTextReplacements take narrow shapes. - telemetry: `platform/telemetry/types` takes `TierKey`/`BillingCycle` from `@comfyorg/account-core/billing` instead of the subscription modules. - nodeDef: `ComfyNodeDefImpl` moved to `core/graph/nodeDef/ComfyNodeDefImpl.ts`; `NodeLibrarySection` moved to nodeOrganizationTypes; `useNodeFrequencyStore` split into its own leaf store and `topNodeDefs` moved onto useNodeDefStore. - QuadTree: `Bounds` moved to `types/spatialIndex.ts`. - settings: `ServerConfigValue` moved to `platform/settings/types.ts`. - domWidget: widget interfaces moved to `types/domWidget.ts`. - maskEditor: `useCanvasHistory` takes its layers as an argument. - widgetInputs: `nodeTypeGuards.ts` removed; `isPrimitiveNode` made private. - searchbox: `FilterChip` moved to `components/searchbox/v2/filterChip.ts`; searchBoxStore declares a local `SearchBoxPopover` interface. - keybinding: dialog state moved to `editKeybindingDialogState.ts`. - auth dialogs: `updatePassword` moved to `useUpdatePassword(requestSignIn)`; UpdatePasswordContent takes a `requestSignIn` prop. - menu: `MenuOption`/`SubMenuOption`/`BadgeVariant` moved to `composables/graph/menuOption.ts`. - billingOperationStore: `pollPendingOperations` no longer exposed. Deferred: load3d (3), auth/api (53), app (114), litegraph (153). Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
… context The SDK store, the operation store, and the hosted-tab opener settled a billing mutation by calling `useBillingContext()` to refetch status, balance, or the reconciled subscription, which put the readers of billing state underneath the rails that feed them. They now call `refreshBilling(scope)` (`account`, `subscription`) from the new leaf `platform/workspace/billing/billingRefresh`, in the same position and order inside the same `Promise.allSettled` as before, and the context registers the listener, released with its scope. The hosted tab's pending-operation watch reads the checkout operation through the same leaf; the context registers that reader. Capability refreshes are unchanged and still call `useBillingCapabilities()` directly. `showSubscriptionDialog` and `requireActiveSubscription` leave the `BillingActions` facade and `useSubscription`. The context's `showSubscriptionDialog` moves unchanged to `useSubscriptionPaywall` (wait for the workspace type, then the workspace pricing dialog or the legacy `showSubscriptionRequiredDialog`), which its six callers use; the context exposes `whenRoutingKnown` for it. `requireActiveSubscription` had no callers. `canPurchaseCredits` and the `purchaseCreditsDirect` guard move from `useAuthActions` to the two callers, `useLegacyBilling.topup` and the legacy top-up dialog, reading the same `canAccessSubscriptionFeatures`, so auth actions no longer read the billing context. Import cycles: 302 -> 272 cyclic modules, 5 -> 6 cycles, largest SCC 154 -> 154. The 43-module billing SCC splits into 10 (dialogs) and 3 (SDK store, capabilities, read rail). The fallow baseline drops the 16 billing cycles this removes and adds two through `useSubscriptionPaywall`, `SubscribeButton`, `SubscriptionRequiredDialogContent` and `useSubscriptionDialog`: the paywall renders the button that opens it. Those cycles ran through `useBillingContext` before.
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: the refactor preserves refresh and hosted-return behavior while keeping paywall selection tied to the resolved billing rail.
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 94213c40cd4f4d110db7a6ec4f5c3b5abd03bca2: no blocking finding. The extraction preserves account versus checkout reconciliation, removes the consumer imports from the rails, and keeps top-up eligibility at both live callers. GraphView retains the shared billing context through useCoreCommands; registration and disposal were exercised. New types describe frontend refresh/routing lifecycle, not copied API responses or reconstructed server facts.
Own exact-head validation with its own frozen-lockfile install: 842 unit/component tests in 17 files; app typecheck; Cloud production build; changed-file type-aware lint, ESLint (16 test files are excluded by repo config) and format. Chrome production-build verification passed 14/14 with retries disabled: legacy/workspace and SDK reads, paywall routing, hosted-tab return refresh and pending-operation recovery. Core bootstrap used an isolated local ComfyUI backend; billing/auth replies were controlled fixtures, not real account/payment validation.
Disposable safety checks: baseline/restored 77/77 including four independent transport assertions. Removing account refresh failed 3 rows (74 survived); subscription refresh 3 (74); workspace paywall 2 (75); legacy paywall 1 (76); disposal 8 (69). Removing each top-up guard separately failed its denied-purchase test, with 21/18 surviving tests. Sources were restored and the exact-head checkout remained clean. Initial browser failures were harness issues: overlapping runs shared an artifact directory, and the hosted test build lacked its documented VITE_BILLING_WEB_URL; a corrected single run passed all 14.
Five latest required contexts are successful, with completed run heads matching this SHA. No website build/output changes or performance claims are involved, so website gates and performance benchmarking were not run. No real charge or subscription/account mutation was performed.
Summary
Move billing refresh notifications into
billingRefreshand paywall opening intouseSubscriptionPaywall, so billing rails no longer import their consumers.Stack:
main→ #19189 → #19148 → #20777 → #20782 → #20799. The auth consolidation in #20777 includes #20771 and #20774. Tracks FE-2769 / FE-3037.Evidence
Merge Danger
Door: two-way. Blast Radius: billing.
Refresh notifications and checkout reads require a live billing context;
GraphViewretains it throughuseCoreCommands. Top-up guards now live at their callers, and paywall routing waits for the workspace type before choosing the legacy or workspace dialog. Review those lifetimes and routing contracts when evaluating the extraction.