Repository navigation
refactor: break the workbench import cycles - #19186
Conversation
📦 Bundle: 9.49 MB gzip 🟢 -5.11 kBDetailsSummary
Category Glance App Entry Points — 5.05 kB (baseline 5.55 kB) • 🟢 -505 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.45 MB (baseline 2.16 MB) • 🔴 +292 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 16 added / 16 removed / 2 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 18 unchanged User & Accounts — 275 kB (baseline 275 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 6 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 1 unchanged UI Components — 212 kB (baseline 211 kB) • 🔴 +971 BReusable component library chunks
Status: 24 added / 24 removed Data & Services — 2.17 MB (baseline 2.17 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 20 added / 20 removed / 4 unchanged Utilities & Hooks — 998 kB (baseline 1.29 MB) • 🟢 -296 kBHelpers, composables, and utility bundles
Status: 34 added / 34 removed / 29 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 1 added / 1 removed / 17 unchanged Other — 19.4 MB (baseline 19.4 MB) • 🟢 -6.04 kBBundles that do not match a named category
Status: 148 added / 150 removed / 201 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-13T20:14:43.100Z",
"gitSha": "a1bf92d7d40479b9007b693fac8d65811f4dddab",
"branch": "drjkl/workbench-cycles",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.6439999999802,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6099999999999994,
"layouts": 9,
"layoutDurationMs": 2.617,
"taskDurationMs": 349.775,
"heapDeltaBytes": 21998820,
"heapUsedBytes": 87826836,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.882000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2021.513999999911,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.563,
"layouts": 10,
"layoutDurationMs": 2.8849999999999993,
"taskDurationMs": 493.91100000000006,
"heapDeltaBytes": -1305604,
"heapUsedBytes": 73158356,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.183,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.8009999999622,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.338,
"layouts": 10,
"layoutDurationMs": 2.627,
"taskDurationMs": 826.986,
"heapDeltaBytes": -7827328,
"heapUsedBytes": 66677928,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 140.30900000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1991.3540000000012,
"styleRecalcs": 85,
"styleRecalcDurationMs": 16.301,
"layouts": 10,
"layoutDurationMs": 2.6020000000000003,
"taskDurationMs": 1035.86,
"heapDeltaBytes": -8024092,
"heapUsedBytes": 67295268,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 149.034,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487393,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.566999999979,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.170000000000001,
"layouts": 12,
"layoutDurationMs": 2.7939999999999996,
"taskDurationMs": 377.24500000000006,
"heapDeltaBytes": -4504484,
"heapUsedBytes": 70356828,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.214000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7980000000116,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.607,
"layouts": 11,
"layoutDurationMs": 2.8470000000000004,
"taskDurationMs": 392.246,
"heapDeltaBytes": -4558152,
"heapUsedBytes": 70389380,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.853,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 646.7300000000478,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.9320000000000004,
"layouts": 10,
"layoutDurationMs": 2.66,
"taskDurationMs": 482.993,
"heapDeltaBytes": 6675376,
"heapUsedBytes": 81629320,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 165.87099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 636.3810000000285,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.88,
"layouts": 9,
"layoutDurationMs": 2.5989999999999998,
"taskDurationMs": 460.646,
"heapDeltaBytes": -1046200,
"heapUsedBytes": 65202884,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 170.844,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.7599999999875,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 871.7550000000001,
"heapDeltaBytes": -11393444,
"heapUsedBytes": 81142000,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 60.522999999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 492,
"frameDurationMs": 31.98108108108106,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.7869999999566,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 865.186,
"heapDeltaBytes": -3396476,
"heapUsedBytes": 80981384,
"domNodes": -192,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 59.230999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 488,
"frameDurationMs": 31.532432432432426,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.2629999999081,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.39300000000014,
"heapDeltaBytes": -5202820,
"heapUsedBytes": 75652240,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 139.97099999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.1519999999846,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.9869999999995,
"heapDeltaBytes": -3570136,
"heapUsedBytes": 76158968,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 138.07299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9513.83599999997,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.27999999999999986,
"layouts": 1,
"layoutDurationMs": 0.28999999999999987,
"taskDurationMs": 8599.532,
"heapDeltaBytes": -28102936,
"heapUsedBytes": 71510956,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 6751.32,
"eventListeners": -68,
"totalBlockingTimeMs": 260,
"frameDurationMs": 28.022418879056048,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8665.636999999948,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.30200000000000016,
"layouts": 1,
"layoutDurationMs": 0.219,
"taskDurationMs": 7765.377999999999,
"heapDeltaBytes": -15967108,
"heapUsedBytes": 83232280,
"domNodes": -258,
"jsHeapTotalBytes": 11399168,
"scriptDurationMs": 6434.424,
"eventListeners": -68,
"totalBlockingTimeMs": 192,
"frameDurationMs": 29.221621621621615,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9371.102000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8478.432,
"heapDeltaBytes": -1512732,
"heapUsedBytes": 86604084,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 6770.464,
"eventListeners": -68,
"totalBlockingTimeMs": 167,
"frameDurationMs": 27.579941002949855,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8822.148999999969,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3110000000000005,
"layouts": 1,
"layoutDurationMs": 0.22300000000000011,
"taskDurationMs": 7849.074,
"heapDeltaBytes": -22094620,
"heapUsedBytes": 75103148,
"domNodes": -278,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 6227.367,
"eventListeners": -68,
"totalBlockingTimeMs": 58,
"frameDurationMs": 27.550937499999996,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 259.584000000018,
"styleRecalcs": 26,
"styleRecalcDurationMs": 16.304,
"layouts": 11,
"layoutDurationMs": 3.335,
"taskDurationMs": 208.20899999999997,
"heapDeltaBytes": -7627168,
"heapUsedBytes": 79732616,
"domNodes": 917,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.056,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.5153846153846,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 212.75600000001305,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.773,
"layouts": 11,
"layoutDurationMs": 3.0939999999999994,
"taskDurationMs": 161.849,
"heapDeltaBytes": -8073956,
"heapUsedBytes": 79267640,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.209,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2008.6140000000796,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.092,
"layouts": 8,
"layoutDurationMs": 2.052,
"taskDurationMs": 453.9620000000001,
"heapDeltaBytes": -3810776,
"heapUsedBytes": 75223068,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 32.788000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.6330000000708,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4070000000000014,
"layouts": 9,
"layoutDurationMs": 2.4619999999999997,
"taskDurationMs": 470.02600000000007,
"heapDeltaBytes": -5253180,
"heapUsedBytes": 73903824,
"domNodes": -278,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 33.15200000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2194.0009999999575,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.173000000000001,
"layouts": 7,
"layoutDurationMs": 1.7360000000000002,
"taskDurationMs": 1389.1560000000002,
"heapDeltaBytes": 11378208,
"heapUsedBytes": 91926492,
"domNodes": -268,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 766.1329999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665648854961837,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2338.557000000037,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.6160000000000005,
"layouts": 7,
"layoutDurationMs": 1.633,
"taskDurationMs": 1618.02,
"heapDeltaBytes": -30027152,
"heapUsedBytes": 68575040,
"domNodes": -258,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 782.6379999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3617.872000000034,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.9,
"layouts": 65,
"layoutDurationMs": 11.344,
"taskDurationMs": 1732.519,
"heapDeltaBytes": -32057848,
"heapUsedBytes": 67463444,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 758.372,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74259259259259,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3505.4249999999456,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.939,
"layouts": 64,
"layoutDurationMs": 11.363999999999999,
"taskDurationMs": 1663.9219999999998,
"heapDeltaBytes": -2834944,
"heapUsedBytes": 97053184,
"domNodes": 24,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 765.5320000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.745454545454546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2944.6400000000494,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.789999999999999,
"layouts": 5,
"layoutDurationMs": 1.344,
"taskDurationMs": 1864.331,
"heapDeltaBytes": 62776,
"heapUsedBytes": 83924364,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 920.3209999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.855999999999995,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2941.547000000014,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.648,
"layouts": 4,
"layoutDurationMs": 1.1100000000000003,
"taskDurationMs": 1919.6730000000002,
"heapDeltaBytes": 11011496,
"heapUsedBytes": 94948276,
"domNodes": 0,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 959.25,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85657142857143,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.0480000000225,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8020000000000007,
"layouts": 7,
"layoutDurationMs": 1.823,
"taskDurationMs": 617.7929999999999,
"heapDeltaBytes": -24024616,
"heapUsedBytes": 74537948,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 33.677,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.2370000000374,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7420000000000004,
"layouts": 7,
"layoutDurationMs": 1.683,
"taskDurationMs": 610.2559999999999,
"heapDeltaBytes": -3909216,
"heapUsedBytes": 77246080,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.04299999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.7040000000343,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.445,
"layouts": 9,
"layoutDurationMs": 2.1609999999999996,
"taskDurationMs": 363.34600000000006,
"heapDeltaBytes": 20218388,
"heapUsedBytes": 86933080,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 142.453,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.1400000000285,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.854,
"layouts": 9,
"layoutDurationMs": 2.5230000000000006,
"taskDurationMs": 430.79699999999997,
"heapDeltaBytes": -2353028,
"heapUsedBytes": 74121220,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 145.21599999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.5559999999186,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.470999999999999,
"layouts": 10,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 496.95599999999996,
"heapDeltaBytes": -1519672,
"heapUsedBytes": 75718232,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.126000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.442999999982,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8889999999999993,
"layouts": 10,
"layoutDurationMs": 2.628,
"taskDurationMs": 533.2209999999999,
"heapDeltaBytes": -1893072,
"heapUsedBytes": 75076728,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.607000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.997000000044,
"styleRecalcs": 88,
"styleRecalcDurationMs": 15.893999999999998,
"layouts": 10,
"layoutDurationMs": 2.521,
"taskDurationMs": 990.966,
"heapDeltaBytes": -11769884,
"heapUsedBytes": 65551200,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 99.232,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666949152542376,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.4879999999648,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.702,
"layouts": 9,
"layoutDurationMs": 2.4619999999999997,
"taskDurationMs": 999.207,
"heapDeltaBytes": 11228160,
"heapUsedBytes": 78585324,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 100.803,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.2899999999327,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.060000000000006,
"layouts": 5,
"layoutDurationMs": 15.216999999999999,
"taskDurationMs": 1018.9959999999998,
"heapDeltaBytes": 9559420,
"heapUsedBytes": 110238508,
"domNodes": 15953,
"jsHeapTotalBytes": 18489344,
"scriptDurationMs": 29.479000000000006,
"eventListeners": 3244,
"totalBlockingTimeMs": 156,
"frameDurationMs": 19.367567567567566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8354.629000000044,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.62,
"layouts": 8,
"layoutDurationMs": 2,
"taskDurationMs": 5592.422,
"heapDeltaBytes": -13663952,
"heapUsedBytes": 82860092,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2559.408,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699201596806386,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8402.40700000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.393,
"layouts": 7,
"layoutDurationMs": 1.9900000000000004,
"taskDurationMs": 5522.191000000001,
"heapDeltaBytes": 5529380,
"heapUsedBytes": 85024420,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2503.158,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732470119521913,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17067.348000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16458.053,
"heapDeltaBytes": -17600008,
"heapUsedBytes": 273174608,
"domNodes": -311,
"jsHeapTotalBytes": 19390464,
"scriptDurationMs": 266.034,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.525951557093425,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 23220.19599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22723.639000000003,
"heapDeltaBytes": -39199672,
"heapUsedBytes": 265069952,
"domNodes": -3330,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 349.997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.48708551483421,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 20022.951000000034,
"styleRecalcs": 157,
"styleRecalcDurationMs": 14.274000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19708.472999999998,
"heapDeltaBytes": -26791772,
"heapUsedBytes": 272814968,
"domNodes": -3334,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 838.2919999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 37.37406716417911,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28853.789000000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.765000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28478.440000000002,
"heapDeltaBytes": -20464648,
"heapUsedBytes": 256464604,
"domNodes": -3330,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 995.77,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 54.66950757575758,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 8466.618000000039,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.56300000000002,
"layouts": 20,
"layoutDurationMs": 28.912999999999993,
"taskDurationMs": 8377.022,
"heapDeltaBytes": -15102036,
"heapUsedBytes": 267157616,
"domNodes": -3330,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 126.27499999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.205027932960895,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8391.82900000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.01499999999997,
"layouts": 20,
"layoutDurationMs": 24.671999999999986,
"taskDurationMs": 8304.196000000002,
"heapDeltaBytes": -36977408,
"heapUsedBytes": 253913324,
"domNodes": -3334,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 131.05499999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.90285714285715,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11548.038999999902,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11277.648,
"heapDeltaBytes": -11109996,
"heapUsedBytes": 252333252,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.81599999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.09423728813559,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11539.091999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11315.906000000003,
"heapDeltaBytes": -612672,
"heapUsedBytes": 250179128,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.32499999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.768275862068975,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 516.1840000000666,
"styleRecalcs": 20,
"styleRecalcDurationMs": 14.539,
"layouts": 12,
"layoutDurationMs": 4.770999999999999,
"taskDurationMs": 142.97500000000002,
"heapDeltaBytes": 6996248,
"heapUsedBytes": 79685092,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.171000000000003,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 122.68800000003921,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.062999999999999,
"layouts": 8,
"layoutDurationMs": 2.987,
"taskDurationMs": 88.538,
"heapDeltaBytes": -15720092,
"heapUsedBytes": 67971628,
"domNodes": 116,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.905,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 495.1849999999922,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.346,
"layouts": 76,
"layoutDurationMs": 16.383000000000003,
"taskDurationMs": 446.324,
"heapDeltaBytes": 11820380,
"heapUsedBytes": 82276604,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 213.21,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 478.9989999999307,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9990000000000001,
"layouts": 76,
"layoutDurationMs": 15.54,
"taskDurationMs": 436.45900000000006,
"heapDeltaBytes": 11598136,
"heapUsedBytes": 88372764,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 210.476,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 519.602999999961,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.22,
"layouts": 76,
"layoutDurationMs": 14.354000000000001,
"taskDurationMs": 484.15799999999996,
"heapDeltaBytes": 86064,
"heapUsedBytes": 118445300,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 190.34400000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.20322580645162,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 656.003999999939,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.3800000000000003,
"layouts": 76,
"layoutDurationMs": 16.094,
"taskDurationMs": 606.432,
"heapDeltaBytes": 10146804,
"heapUsedBytes": 151058088,
"domNodes": 4,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 237.055,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.542105263157904,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 36f7c162787e4e29c18dd9dfa39432bf3f59688f
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19186 +/- ##
==========================================
+ Coverage 86.34% 87.16% +0.82%
==========================================
Files 3665 2613 -1052
Lines 175106 146873 -28233
Branches 48310 38270 -10040
==========================================
- Hits 151192 128029 -23163
+ Misses 21898 18456 -3442
+ Partials 2016 388 -1628
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1065 files with indirect coverage changes 🚀 New features to boost your workflow:
|
40cadf9 to
72f88c8
Compare
|
Fixed in 266cbbc: Christian’s review-body finding about event-time manager watchers is addressed by disposing the temporary state scope immediately after reading it. The repeated-open regression fails before the fix and passes after it; all 35 manager tests pass. Format, lint, application typecheck, Knip, and the pre-push Fallow audit passed. No threads were resolved. Commits pushed: 266cbbc. Hosted CI has not been verified for this new head. |
266cbbc to
9f5ff6f
Compare
9f5ff6f to
78503d6
Compare
Manager: `useManagerState` keeps only the UI-state derivations and the once-per-session upgrade toast; `openManager` moves to `useManagerDialog`, which already owns showing the dialog. Callers open the manager through `useManagerDialog().openManager`. This removes the useManagerState -> useManagerDialog -> ManagerDialog.vue back-edge that made the 28 manager modules one cycle. Agent: the CRDT follower's `AgentCrdtStatus` and outcome counters live in a new `crdt/agentCrdtStatus.ts` leaf so `crdtSnapshot` does not depend on the composable. The `ComposerAttachment` leaf already landed on main. Import cycles: 391 -> 361 cyclic modules, 16 -> 14 cycles, largest SCC 153 -> 153. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
78503d6 to
f4c0229
Compare
This comment has been minimized.
This comment has been minimized.
christian-byrne
left a comment
There was a problem hiding this comment.
The event-time state read now emits the incompatible warning before the explicit user-action warning. Please make the state lookup side-effect free so one click produces one actionable toast.
| async function openManager(options?: OpenManagerOptions): Promise<void> { | ||
| const scope = effectScope() | ||
| const managerUIState = scope.run( | ||
| () => useManagerState().managerUIState.value |
There was a problem hiding this comment.
useManagerState() installs its immediate incompatibility watcher here, so on an incompatible backend it emits a warning before this call reaches showIncompatibleManagerToast({ force: true }) and emits another. This is observable from callers that no longer own useManagerState, such as ComfyMenuButton, where one Manager click now creates two identical upgrade toasts. The new test only asserts that the toast count grows by one between calls, so it accepts the extra toast. Please read the manager state without registering the watcher, and assert one toast per incompatible open.
There was a problem hiding this comment.
Fixed in 1d3eec7: openManager() now reads the existing state calculation directly, without creating a watcher or effect scope. Component consumers retain their automatic warning. The existing regression now requires exactly one toast after the first incompatible open and two after the second. It failed on the reviewed head with two toasts on the first open and passes with the fix. All 34 manager tests and 71 related consumer tests pass. A temporary DOM check also confirmed one rendered toast after the first open and two after the second.
Commit: 1d3eec79b2.
|
Fixed in 1d3eec7: Christian's review-body finding about the extra event-time warning is addressed by reading manager state without registering its watcher. The strengthened existing test fails before the fix and passes afterward, requiring one warning per incompatible open. All 105 tests across six affected suites passed, as did formatting, lint and application typecheck. Commits pushed: 1d3eec79b2. Hosted CI has not been verified for this new head. No threads were resolved. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approved after rechecking the manager-state refactor and both resolved requested changes at the current head.
Summary
Removes the import cycles left inside
src/workbench: the 28-module manager cycle and the agent CRDT status cycle.workbench/is now cycle-free, which is a prerequisite for giving it its own TypeScript project reference.Import cycles: 341 -> 311 cyclic modules, 20 -> 18 cycles, largest SCC 154 -> 154 (litegraph), 1335 -> 1262 cyclic edges, on top of #19153 (rebased onto
maindf4ea6d).Stacked on #19153 (rebased onto the
drjkl/comfy-types-leafchain). Tracks FE-2769 / FE-3037.Changes
useManagerStatehad two responsibilities, deriving the manager UI state and opening the manager. Opening needsuseManagerDialog, which importsManagerDialog.vue, whose subtree importsuseManagerStateagain.openManagermoves touseManagerDialog, which already ownsshow()/hide().useManagerStatekeeps the state derivations and the once-per-session upgrade toast, and exportsshowIncompatibleManagerToast({ force })so the explicit-click re-emit lives withopenManager.useCoreCommands,TopMenuSection,ComfyMenuButton,HelpCenterMenuContent,ErrorGroupList,MissingPackGroupRow) calluseManagerDialog().openManager(...).ComfyMenuButtonno longer needsuseManagerState. The legacy-menu error toast inopenManageruses theuseToast()API from [Phase 6a] Replace PrimeVue Toast with design-system toast #16313, asuseManagerStatedoes onmain.openManagercoverage moves fromuseManagerState.test.tstouseManagerDialog.test.tsand now covers all four states (DISABLED, INCOMPATIBLE, LEGACY_UI with and withoutshowToastOnLegacyError, NEW_UI with and withoutisLegacyOnly) by driving the realuseManagerStatethroughsystemStatsStoreand spiedapifeature flags. The shared__mocks__/useManagerState.tsdropsopenManager; a new__mocks__/useManagerDialog.tscovers component tests.ComposerAttachmentleaf this PR originally introduced already landed on main (types/composerAttachment.ts), so that part is dropped.AgentCrdtStatusandAgentCrdtOutcomeCountersmove to a new leafcrdt/agentCrdtStatus.tssocrdtSnapshot.tsstops importinguseAgentCrdtFollower.ts.dead-code.jsonis unchanged (the stale manager entries stay as unused baseline rows); thecrap_highentry foropenManagermoves fromuseManagerState.tstouseManagerDialog.tsinhealth.json(same function, new file).Review Focus
openManagernow callsuseManagerState()per invocation. Itswatch(..., { immediate: true })runs once per call and can fire the once-per-session INCOMPATIBLE toast if no component had instantiated the composable yet. That matches the previous behaviour, where every caller instantiateduseManagerState()before callingopenManager.useManagerDialognow importsuseManagerState; the dependency direction is dialog -> state, matchinguseManagerDialog -> ManagerDialog.vue -> ... -> useManagerState.Stack
Import-cycle progress for FE-3037, measured with
pnpm lint:cycles(dependency-cruiser onsrc).Standalone PRs targeting
mainEach is one commit on current
mainand can merge on its own. Numbers are that PR alone againstorigin/main(1027 cyclic modules, largest cycle 983, 4562 cyclic edges).mainServerFeatureFlagenum to a leaf modulemainappModeStoremainComfy.MaskEditorextensionmainPositionConfigand layer editor dialog key to leaf modulesmainsettingStoreoffscripts/app;$elto a leafmainMissingNodeTypeto the nodeReplacement leafmainnodeDefStoremainAll eight together on
main, plus #19091, #19107, #19108, #19111, #19116 and #19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges.Remaining stack
Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older
mainthe stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses.#19091, #19107, #19111, #19113 and #19131 still carry the old commits of the PRs they were moved off (#19131 carries #19122, #19124, #19125 and #19127), so their GitHub diffs are wider than one PR until the stack is rebased.
mainpnpm lint:cycles)interfaces.tsinto leaf typessidebarTabStoreextensionServicescripts/widgets.tsregistry, types, helpersexecutionStoremain.tsmain.tsdialogServicescripts/appbehinduseApp()types/comfy,comfyWorkflow, dialog/workflow contracts as leavesopenManagerontouseManagerDialog, agent leaves