Repository navigation
refactor: break auth cycles and remove obsolete lazy imports - #20777
Conversation
📦 Bundle: 9.45 MB gzip 🔴 +1.87 kBDetailsSummary
Category Glance App Entry Points — 5.36 kB (baseline 5.21 kB) • 🔴 +153 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.45 MB (baseline 2.45 MB) • 🔴 +712 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • 🔴 +90 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 670 kB (baseline 670 kB) • 🔴 +236 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 18 unchanged User & Accounts — 123 kB (baseline 289 kB) • 🟢 -166 kBAuthentication, profile, and account management bundles
Status: 8 added / 9 removed / 9 unchanged Editors & Dialogs — 345 kB (baseline 345 kB) • 🔴 +258 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 4 unchanged UI Components — 212 kB (baseline 212 kB) • 🔴 +3 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 2.34 MB (baseline 2.17 MB) • 🔴 +167 kBStores, services, APIs, and repositories
Status: 21 added / 21 removed / 3 unchanged Utilities & Hooks — 991 kB (baseline 984 kB) • 🔴 +7.12 kBHelpers, composables, and utility bundles
Status: 35 added / 34 removed / 34 unchanged Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 19.4 MB (baseline 19.4 MB) • 🟢 -6.57 kBBundles that do not match a named category
Status: 92 added / 92 removed / 260 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-14T22:43:14.369Z",
"gitSha": "5f16f0fe96713cc482db74939e03b7e853e7a354",
"branch": "drjkl/auth-store-cycles",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.6960000000195,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.84,
"layouts": 9,
"layoutDurationMs": 2.907,
"taskDurationMs": 408.62,
"heapDeltaBytes": 2565852,
"heapUsedBytes": 80868576,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.293999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.648999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.665,
"layouts": 9,
"layoutDurationMs": 2.7089999999999996,
"taskDurationMs": 585.054,
"heapDeltaBytes": -1973864,
"heapUsedBytes": 76801260,
"domNodes": -182,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.14,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.7920000000227,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.303,
"layouts": 9,
"layoutDurationMs": 2.751,
"taskDurationMs": 890.2260000000001,
"heapDeltaBytes": -539736,
"heapUsedBytes": 77769192,
"domNodes": -162,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 159.384,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1846.021999999948,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.912999999999998,
"layouts": 9,
"layoutDurationMs": 2.5049999999999994,
"taskDurationMs": 943.714,
"heapDeltaBytes": -1681676,
"heapUsedBytes": 76803288,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 171.82500000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.7830000000022,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.854,
"layouts": 11,
"layoutDurationMs": 2.5990000000000006,
"taskDurationMs": 395.3059999999999,
"heapDeltaBytes": -1643472,
"heapUsedBytes": 76630176,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.643999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.2799999999743,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.260999999999999,
"layouts": 11,
"layoutDurationMs": 3.3630000000000004,
"taskDurationMs": 300.823,
"heapDeltaBytes": -2119292,
"heapUsedBytes": 76185168,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.368,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 665.1699999999892,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.241,
"layouts": 11,
"layoutDurationMs": 3.0709999999999997,
"taskDurationMs": 496.1139999999999,
"heapDeltaBytes": 5542860,
"heapUsedBytes": 83894688,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 165.926,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 669.2219999999907,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1529999999999996,
"layouts": 9,
"layoutDurationMs": 2.8680000000000003,
"taskDurationMs": 496.956,
"heapDeltaBytes": 5914720,
"heapUsedBytes": 84320496,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 167.36900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.8149999999853,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 844.0070000000001,
"heapDeltaBytes": 15182164,
"heapUsedBytes": 95413024,
"domNodes": 0,
"jsHeapTotalBytes": 15892480,
"scriptDurationMs": 70.08100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 529,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1180.813999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 812.2239999999999,
"heapDeltaBytes": 16108696,
"heapUsedBytes": 95995240,
"domNodes": 0,
"jsHeapTotalBytes": 17465344,
"scriptDurationMs": 71.443,
"eventListeners": 0,
"totalBlockingTimeMs": 550,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.7190000000169,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.86800000000017,
"heapDeltaBytes": -4583744,
"heapUsedBytes": 74299248,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.58099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 210,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.6309999999785,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.7989999999995,
"heapDeltaBytes": -3603684,
"heapUsedBytes": 74020284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.45600000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9792.494000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8931.548,
"heapDeltaBytes": 2123320,
"heapUsedBytes": 86185860,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7196.719,
"eventListeners": 0,
"totalBlockingTimeMs": 778,
"frameDurationMs": 31.515705128205127,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10459.754000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9565.379,
"heapDeltaBytes": -11948488,
"heapUsedBytes": 72082544,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8136.822,
"eventListeners": 0,
"totalBlockingTimeMs": 1288,
"frameDurationMs": 32.05398773006135,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9742.020999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8886.059000000001,
"heapDeltaBytes": -1368356,
"heapUsedBytes": 82073000,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7545.783,
"eventListeners": 0,
"totalBlockingTimeMs": 1004,
"frameDurationMs": 31.703257328990226,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9405.254000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8572.634,
"heapDeltaBytes": 11905640,
"heapUsedBytes": 95171496,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7218.738,
"eventListeners": 0,
"totalBlockingTimeMs": 786,
"frameDurationMs": 32.30103092783505,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 210.9230000000082,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.733000000000002,
"layouts": 9,
"layoutDurationMs": 3.1729999999999996,
"taskDurationMs": 151.90400000000002,
"heapDeltaBytes": 13116884,
"heapUsedBytes": 76628480,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.918,
"eventListeners": 195,
"totalBlockingTimeMs": 8,
"frameDurationMs": 24.066666666666606,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 209.00899999998046,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.298000000000002,
"layouts": 8,
"layoutDurationMs": 2.326,
"taskDurationMs": 153.634,
"heapDeltaBytes": 13158488,
"heapUsedBytes": 76848812,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.382999999999997,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2020.0289999999654,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1309999999999991,
"layouts": 4,
"layoutDurationMs": 1.329,
"taskDurationMs": 579.8389999999999,
"heapDeltaBytes": 6783584,
"heapUsedBytes": 70869320,
"domNodes": -258,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.667,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2044.7780000000648,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3149999999999995,
"layouts": 8,
"layoutDurationMs": 2.594,
"taskDurationMs": 613.0350000000001,
"heapDeltaBytes": -28718612,
"heapUsedBytes": 70700032,
"domNodes": -268,
"jsHeapTotalBytes": -487424,
"scriptDurationMs": 33.209999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2521.7480000000023,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.28,
"layouts": 4,
"layoutDurationMs": 0.928,
"taskDurationMs": 1632.9250000000002,
"heapDeltaBytes": 11235424,
"heapUsedBytes": 76233596,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 808.619,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2638.253999999961,
"styleRecalcs": 64,
"styleRecalcDurationMs": 4.988,
"layouts": 3,
"layoutDurationMs": 0.7760000000000002,
"taskDurationMs": 1644.5119999999997,
"heapDeltaBytes": 14623976,
"heapUsedBytes": 79840628,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 813.2779999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77151898734177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3802.4500000000216,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.087000000000001,
"layouts": 60,
"layoutDurationMs": 9.578,
"taskDurationMs": 1734.346,
"heapDeltaBytes": 3200012,
"heapUsedBytes": 69742856,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.3409999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3908.904000000007,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.142,
"layouts": 61,
"layoutDurationMs": 9.590000000000002,
"taskDurationMs": 1761.18,
"heapDeltaBytes": -285728,
"heapUsedBytes": 66647712,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.706,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665531914893617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3089.650000000006,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.775,
"layouts": 1,
"layoutDurationMs": 0.30500000000000016,
"taskDurationMs": 1897.59,
"heapDeltaBytes": 5529668,
"heapUsedBytes": 74138500,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 935.272,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75737704918033,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3024.7940000000426,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.5720000000000005,
"layouts": 1,
"layoutDurationMs": 0.2889999999999993,
"taskDurationMs": 1922.2200000000003,
"heapDeltaBytes": 14646072,
"heapUsedBytes": 83262704,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 950.2739999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.851111111111116,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.3400000000097,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2319999999999987,
"layouts": 4,
"layoutDurationMs": 1.146,
"taskDurationMs": 592.9939999999999,
"heapDeltaBytes": 7285796,
"heapUsedBytes": 71836260,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.830000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.012999999958,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3909999999999998,
"layouts": 4,
"layoutDurationMs": 1.2139999999999997,
"taskDurationMs": 393.571,
"heapDeltaBytes": 6819540,
"heapUsedBytes": 71850968,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.10099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.684999999999,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.8069999999999995,
"layouts": 9,
"layoutDurationMs": 2.464,
"taskDurationMs": 446.423,
"heapDeltaBytes": 159556,
"heapUsedBytes": 80919744,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 145.15699999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 632.0019999999431,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.1240000000000006,
"layouts": 10,
"layoutDurationMs": 2.7039999999999997,
"taskDurationMs": 453.68699999999995,
"heapDeltaBytes": 236988,
"heapUsedBytes": 80619672,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 146.968,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2037.3120000000426,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9090000000000003,
"layouts": 10,
"layoutDurationMs": 3.358,
"taskDurationMs": 555.851,
"heapDeltaBytes": 1880800,
"heapUsedBytes": 82233784,
"domNodes": -180,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.314,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.237999999992,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.967,
"layouts": 10,
"layoutDurationMs": 3.186,
"taskDurationMs": 404.202,
"heapDeltaBytes": -23460576,
"heapUsedBytes": 56876668,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 9.604999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.371999999993,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.944999999999999,
"layouts": 10,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 871.3059999999999,
"heapDeltaBytes": -2875164,
"heapUsedBytes": 77565580,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 110.155,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.2800000000507,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.786,
"layouts": 9,
"layoutDurationMs": 2.8240000000000003,
"taskDurationMs": 857.105,
"heapDeltaBytes": 11885112,
"heapUsedBytes": 77227804,
"domNodes": -180,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 112.689,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.5429999999956,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.692999999999994,
"layouts": 5,
"layoutDurationMs": 16.220000000000002,
"taskDurationMs": 1070.0949999999998,
"heapDeltaBytes": 561724,
"heapUsedBytes": 94538216,
"domNodes": 15950,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 29.160999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 164,
"frameDurationMs": 19.59324324324325,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 10025.09299999997,
"styleRecalcs": 246,
"styleRecalcDurationMs": 17.236,
"layouts": 3,
"layoutDurationMs": 0.843,
"taskDurationMs": 5888.880999999999,
"heapDeltaBytes": 25477252,
"heapUsedBytes": 89793972,
"domNodes": -259,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2706.321,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589018302829,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10007.632999999942,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.414,
"layouts": 5,
"layoutDurationMs": 1.6639999999999997,
"taskDurationMs": 6004.147,
"heapDeltaBytes": -8309984,
"heapUsedBytes": 90797444,
"domNodes": -258,
"jsHeapTotalBytes": -32768,
"scriptDurationMs": 2736.7059999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749498327759195,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23008.91200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22168.361999999997,
"heapDeltaBytes": -1209356,
"heapUsedBytes": 282057324,
"domNodes": -3330,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 321.602,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.51735395189004,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 16237.820000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15206.07,
"heapDeltaBytes": -22246852,
"heapUsedBytes": 266290088,
"domNodes": -3330,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 291.847,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.653662691652467,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 26991.878999999983,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.313999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26667.903000000002,
"heapDeltaBytes": -30842268,
"heapUsedBytes": 266840472,
"domNodes": -3330,
"jsHeapTotalBytes": 3919872,
"scriptDurationMs": 834.04,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 49.96722222222222,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28251.486999999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.497999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27911.771999999997,
"heapDeltaBytes": -18522928,
"heapUsedBytes": 275255076,
"domNodes": -3330,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 890.472,
"eventListeners": -651,
"totalBlockingTimeMs": 87,
"frameDurationMs": 51.832844036697246,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8304.756999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.325,
"layouts": 20,
"layoutDurationMs": 24.352999999999987,
"taskDurationMs": 8213.063000000002,
"heapDeltaBytes": -5919968,
"heapUsedBytes": 278407128,
"domNodes": -3330,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 127.077,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.89039548022598,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8220.754000000055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 94.87700000000002,
"layouts": 20,
"layoutDurationMs": 28.379,
"taskDurationMs": 8096.262,
"heapDeltaBytes": -14237180,
"heapUsedBytes": 279577616,
"domNodes": -3330,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 133.99700000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.64611111111112,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12178.379000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11762.38,
"heapDeltaBytes": -9823620,
"heapUsedBytes": 273449044,
"domNodes": -3232,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 177.40599999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.52286689419794,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8413.15499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7831.87,
"heapDeltaBytes": 6173924,
"heapUsedBytes": 282022824,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 149.79000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.337710437710435,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 487.04500000002326,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.120000000000001,
"layouts": 12,
"layoutDurationMs": 4.3740000000000006,
"taskDurationMs": 149.01999999999998,
"heapDeltaBytes": -7822272,
"heapUsedBytes": 63888416,
"domNodes": 124,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 15.71,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 468.61999999998716,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.543000000000003,
"layouts": 11,
"layoutDurationMs": 3.3699999999999997,
"taskDurationMs": 111.78600000000002,
"heapDeltaBytes": -13262912,
"heapUsedBytes": 62837640,
"domNodes": 95,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.979999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 441.90100000002985,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.036,
"layouts": 76,
"layoutDurationMs": 14.854,
"taskDurationMs": 392.54100000000005,
"heapDeltaBytes": -22245704,
"heapUsedBytes": 68260000,
"domNodes": 4,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 187.612,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 446.08199999993303,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.044,
"layouts": 76,
"layoutDurationMs": 15.275,
"taskDurationMs": 399.219,
"heapDeltaBytes": 11060300,
"heapUsedBytes": 83140920,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 189.71600000000004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 608.8439999999764,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.362,
"layouts": 76,
"layoutDurationMs": 14.535,
"taskDurationMs": 568.086,
"heapDeltaBytes": 847932,
"heapUsedBytes": 116977904,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 237.334,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 565.6719999999495,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.264,
"layouts": 76,
"layoutDurationMs": 14.741999999999999,
"taskDurationMs": 531.76,
"heapDeltaBytes": 586248,
"heapUsedBytes": 111522632,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 220.369,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15588235294118,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2276 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (36 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d7930f0bbb493fe73e29fd8ac0706b116e689e9d
Full docs: ADR-DEVEX-LINT-0015 |
7a9f6a4 to
3251a72
Compare
0f19f7d to
5071bb8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20777 +/- ##
==========================================
+ Coverage 86.40% 87.20% +0.79%
==========================================
Files 3690 2627 -1063
Lines 175493 146982 -28511
Branches 46353 40296 -6057
==========================================
- Hits 151637 128177 -23460
+ Misses 21804 18417 -3387
+ Partials 2052 388 -1664
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1071 files with indirect coverage changes 🚀 New features to boost your workflow:
|
3251a72 to
92d42e9
Compare
5071bb8 to
9f4b641
Compare
This comment has been minimized.
This comment has been minimized.
AustinMroz
left a comment
There was a problem hiding this comment.
This one is real ugly. I get the impression that it's just hiding the tangling instead of actually unwinding.
It's still an improvement and I'm confident it doesn't introduce any regressions, so it gets my approval.
There was a problem hiding this comment.
The naming here feels particularly awkward. 'ensure' is the property of the function that will be called. That function is not guaranteed by types to have been initialized.
It'd still be a noisy failure from attempted to invoke undefined, but it feels like the function isn't quite delivering on the promise of 'by calling this function, guarantee that initialization has occured'
There was a problem hiding this comment.
Fixed in b617b95: ensureSessionCookie is now a function rather than an export let binding. The provided function is held as possibly undefined, and ensureSessionCookie() asserts it was provided before calling it, the same way comfyWorkflow reads its registered runtime (assert from @/base/assert). A call before authStore loads now fails as a named assertion instead of "is not a function", and the types no longer claim the binding is always set. authStoreAccess, currentUserAccess and teamWorkspaceStoreAccess had the same export let shape and got the same change. In the app, authStore is in main.ts's static import graph, so the assertion never fires there. typecheck:app and the auth, workspace, store and cloud unit tests pass (245 files).
b617b95
|
Review feedback round for b617b95.
Commits pushed to
|
34850e9 to
3f8b424
Compare
3f8b424 to
ce3195c
Compare
ce3195c to
8f2f807
Compare
8f2f807 to
a5c5db2
Compare
a5c5db2 to
7bdf4d7
Compare
The base branch was changed.
missingModelScan imported assetsStore lazily, and remintRetry imported useFeatureFlags and ssoRequired lazily. None of these targets reaches the importer through static imports any more, and each target's chunk is already loaded with the importer's chunk, so the lazy imports defer nothing. Import them statically. remintRetry keeps its lazy workspaceAuthStore import (workspaceAuthStore -> authStore -> remintRetry), and useBillingDialogs keeps its lazy useSubscriptionDialog import, which still splits a chunk.
…andidates No caller passes it, so the scan always used useAssetsStore(). The real store's getAssets never returns undefined, so the ?? [] fallback that existed for the parameter's looser type goes too.
remintRetry re-minted through a lazy import of workspaceAuthStore, which reaches remintRetry through authStore. workspaceAuthStore now installs its re-mint into remintRetry when it loads. It is always loaded at startup through authStore, so every retry still reaches the same store. SsoRequiredContext moves to a leaf, so ssoRequiredInline and useContinueWithSso no longer type-import ssoRequired. The task response schema and TaskStatus move to a taskSchema leaf, so the websocket message types no longer type-import taskService, which imports scripts/api.
The stores that authStore imports (workspaceAuthStore, teamWorkspaceStore, apiKeyAuthStore, cloudWebSessionStore) and useSessionCookie called back into authStore, useCurrentUser and teamWorkspaceStore, which kept 12 modules in one import cycle. Those callers now import small access modules instead. authStore, useCurrentUser and teamWorkspaceStore provide themselves to them when their modules load, and authStore provides the on-demand ensureSessionCookie that the workspace stores used to import lazily. All three providers are in main.ts's static import graph, so they are in place before any store runs.
The access modules exported `let` bindings typed as always-set functions, so a call before the owning module loaded failed as "is not a function" and the types did not say it could happen. Each one now keeps the provided function as possibly undefined and exports a function that asserts it was provided before calling it, the same way comfyWorkflow reads its registered runtime.
7bdf4d7 to
cede879
Compare
## Summary Break the small app import cycles through leaf types and explicit inputs. Rebased onto `main` after Comfy-Org#19186 merged; its old manager commits are no longer replayed. ```text main → Comfy-Org#19189 → Comfy-Org#19148 → Comfy-Org#20777 → Comfy-Org#20782 → Comfy-Org#20799 ``` The cuts cover legacy UI, node definitions and frequency, telemetry, spatial bounds, settings types, DOM-widget types, mask-editor history, search, keybindings, password recovery, and menu types. Tracks FE-2769 / FE-3037. ## Evidence - Before restacking: 181 files, including already-merged workbench changes. After: 158 files. - Password-recovery and manager suites: 4 files, 41 tests passed, without retries. - The rebase preserves `main`'s `getManagerUIState()` path and its exact toast-count assertions. CI results from the previous head do not cover the rebased head. ## Merge Danger **Door:** two-way. **Blast Radius:** extensions. The existing compatibility decisions remain open: `app.ui.app` has the narrower `LegacyUIApp` type; `app.menu.app` and `app.ui.settings.app` are removed; the former deep DOM-widget type exports moved. No affected custom-node consumer was verified, which does not prove absence. The rebase does not decide these contracts or resolve their review threads. --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Consolidates #20771, #20774, and #20777. Their individual commits remain in order; review history remains on the original PRs.
Includes the unused missing-model
assetsStoreparameter removal and the guarded auth-access follow-up. Stack:main→ #19189 → #19148 → #20777 → #20782 → #20799. Tracks FE-2769 / FE-3037.Evidence
Merge Danger
Door: two-way. Blast Radius: authentication.
Provider modules must register before consumers call the access functions. The guarded access functions retain their assertions. Session-cookie loading remains on demand, while feature flags and SSO presentation use direct imports. This changes module dependencies and load order; it does not remove the runtime relationships between stores. Prior review discussion about the access-module design remains relevant.