Repository navigation
refactor: break the remaining import cycles outside the litegraph core - #20782
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Adr Compliance For Entity/Litegraph Changes | ADR-LAYOUT violation remains. The changed src/utils/createNode.ts adds createNode, which directly assigns node.pos from canvas mouse coordinates before graph insertion. This is an imperative spa… |
Move node placement and graph insertion into a serializable, deterministic command or store operation. Remove the direct node.pos mutation from createNode. Add coverage for repeatable command execution. See docs/adr/ for … |

Passed checks: 6 passed
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
ADR-LAYOUT violation remains. The changed
src/utils/createNode.tsaddscreateNode, which directly assignsnode.posfrom canvas mouse coordinates before graph insertion. This is an imperative spatial mutation outside a serializable, deterministic command or store operation. The change is related to graph entities, so the check applies.Resolution
Move node placement and graph insertion into a serializable, deterministic command or store operation. Remove the direct
node.posmutation fromcreateNode. Add coverage for repeatable command execution. Seedocs/adr/for the proposed ADR-LAYOUT context.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
📦 Bundle: 9.49 MB gzip 🔴 +20.3 kBDetailsSummary
Category Glance App Entry Points — 6.62 kB (baseline 5.4 kB) • 🔴 +1.22 kBMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.46 MB (baseline 2.46 MB) • 🔴 +1 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • 🔴 +117 BTop-level views, pages, and routed surfaces
Status: 16 added / 16 removed / 2 unchanged Panels & Settings — 670 kB (baseline 670 kB) • 🔴 +16 BConfiguration panels, inspectors, and settings screens
Status: 13 added / 13 removed / 16 unchanged User & Accounts — 151 kB (baseline 123 kB) • 🔴 +28 kBAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 6 unchanged Editors & Dialogs — 359 kB (baseline 345 kB) • 🔴 +13.8 kBModals, dialogs, drawers, and in-app editors
Status: 11 added / 12 removed / 1 unchanged UI Components — 212 kB (baseline 212 kB) • 🔴 +332 BReusable component library chunks
Status: 24 added / 24 removed Data & Services — 1.11 MB (baseline 2.37 MB) • 🟢 -1.26 MBStores, services, APIs, and repositories
Status: 34 added / 22 removed / 3 unchanged Utilities & Hooks — 998 kB (baseline 991 kB) • 🔴 +6.96 kBHelpers, composables, and utility bundles
Status: 49 added / 46 removed / 23 unchanged Vendor & Third-Party — 13.9 MB (baseline 13.9 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 2 added / 2 removed / 15 unchanged Other — 19.7 MB (baseline 19.5 MB) • 🔴 +238 kBBundles that do not match a named category
Status: 170 added / 156 removed / 196 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-15T22:38:47.185Z",
"gitSha": "6e3806583701d652a1f7f9e95cc4783f3b4dff0c",
"branch": "drjkl/remaining-cycles",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.9560000000452,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.503,
"layouts": 9,
"layoutDurationMs": 2.803,
"taskDurationMs": 580.762,
"heapDeltaBytes": 18295648,
"heapUsedBytes": 81755504,
"domNodes": -162,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.018,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.6949999999752,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.007,
"layouts": 9,
"layoutDurationMs": 3.275,
"taskDurationMs": 619.515,
"heapDeltaBytes": -20082356,
"heapUsedBytes": 58552856,
"domNodes": -162,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.597000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1821.0700000000202,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.008,
"layouts": 9,
"layoutDurationMs": 2.621,
"taskDurationMs": 951.03,
"heapDeltaBytes": 1624572,
"heapUsedBytes": 80358468,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 166.624,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1828.3419999999069,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.534999999999998,
"layouts": 8,
"layoutDurationMs": 2.4070000000000005,
"taskDurationMs": 937.7840000000001,
"heapDeltaBytes": 17453548,
"heapUsedBytes": 80890736,
"domNodes": -162,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 166.46800000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.9840000000163,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.815,
"layouts": 12,
"layoutDurationMs": 3.6100000000000003,
"taskDurationMs": 345.82800000000003,
"heapDeltaBytes": -147668,
"heapUsedBytes": 78454768,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.508000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.7209999999977,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.799,
"layouts": 11,
"layoutDurationMs": 3.1569999999999996,
"taskDurationMs": 305.17499999999995,
"heapDeltaBytes": 24046036,
"heapUsedBytes": 88251180,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.187,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 692.9439999999545,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.516,
"layouts": 8,
"layoutDurationMs": 2.405,
"taskDurationMs": 499.08,
"heapDeltaBytes": 6560652,
"heapUsedBytes": 85168448,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 167.70000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.07560975609755,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 728.9749999999913,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.923,
"layouts": 9,
"layoutDurationMs": 3.0989999999999998,
"taskDurationMs": 506.09499999999997,
"heapDeltaBytes": 26716376,
"heapUsedBytes": 90214000,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 172.06500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.7720000000222,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 834.955,
"heapDeltaBytes": 14206060,
"heapUsedBytes": 94598404,
"domNodes": 0,
"jsHeapTotalBytes": 16678912,
"scriptDurationMs": 66.666,
"eventListeners": 0,
"totalBlockingTimeMs": 515,
"frameDurationMs": 33.82058823529413,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1182.7220000000125,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.83,
"heapDeltaBytes": 17480308,
"heapUsedBytes": 97071088,
"domNodes": 0,
"jsHeapTotalBytes": 16678912,
"scriptDurationMs": 68.882,
"eventListeners": 0,
"totalBlockingTimeMs": 547,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.8039999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.03099999999984,
"heapDeltaBytes": -4240124,
"heapUsedBytes": 73692028,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.148,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.6419999999043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.578,
"heapDeltaBytes": -4432288,
"heapUsedBytes": 74337312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.09699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11165.856999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10325.003,
"heapDeltaBytes": -11074804,
"heapUsedBytes": 72238748,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8409.898,
"eventListeners": 0,
"totalBlockingTimeMs": 1359,
"frameDurationMs": 31.903428571428574,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10881.538999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10022.966999999999,
"heapDeltaBytes": 1514956,
"heapUsedBytes": 84546500,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8187.598000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1078,
"frameDurationMs": 31.00541310541311,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10333.93000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9512.536,
"heapDeltaBytes": -2104200,
"heapUsedBytes": 80832916,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7755.807000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 859,
"frameDurationMs": 31.311818181818182,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9630.110999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8824.913,
"heapDeltaBytes": -9560844,
"heapUsedBytes": 74199048,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7038.387000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 599,
"frameDurationMs": 31.27564935064935,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 208.90500000001566,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.851999999999999,
"layouts": 10,
"layoutDurationMs": 2.646,
"taskDurationMs": 154.985,
"heapDeltaBytes": 13378608,
"heapUsedBytes": 77110268,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.703000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.670000000000073,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 209.30400000003146,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.781,
"layouts": 9,
"layoutDurationMs": 2.589,
"taskDurationMs": 146.54399999999998,
"heapDeltaBytes": 13222276,
"heapUsedBytes": 77792704,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.579999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2047.173999999984,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6760000000000004,
"layouts": 6,
"layoutDurationMs": 1.541,
"taskDurationMs": 646.152,
"heapDeltaBytes": -24156408,
"heapUsedBytes": 75429544,
"domNodes": -258,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.329,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.1720000000214,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7590000000000001,
"layouts": 6,
"layoutDurationMs": 1.7020000000000004,
"taskDurationMs": 510.132,
"heapDeltaBytes": -27957960,
"heapUsedBytes": 74673664,
"domNodes": -259,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 35.397,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2743.479000000036,
"styleRecalcs": 64,
"styleRecalcDurationMs": 5.089,
"layouts": 3,
"layoutDurationMs": 0.7450000000000004,
"taskDurationMs": 1668.575,
"heapDeltaBytes": 15452548,
"heapUsedBytes": 81480068,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 808.419,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2696.0639999999785,
"styleRecalcs": 64,
"styleRecalcDurationMs": 5.242999999999999,
"layouts": 3,
"layoutDurationMs": 0.8640000000000002,
"taskDurationMs": 1751.3649999999998,
"heapDeltaBytes": 15457636,
"heapUsedBytes": 81139452,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 849.466,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.874374999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3519.043999999951,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.020000000000001,
"layouts": 60,
"layoutDurationMs": 9.454,
"taskDurationMs": 1626.2789999999998,
"heapDeltaBytes": 4870904,
"heapUsedBytes": 72119428,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 829.668,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665402843601893,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3551.9259999999804,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.358,
"layouts": 61,
"layoutDurationMs": 10.157,
"taskDurationMs": 1595.6999999999998,
"heapDeltaBytes": 4151872,
"heapUsedBytes": 71608056,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 793.0090000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66525821596244,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3160.573999999997,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.9290000000000003,
"layouts": 2,
"layoutDurationMs": 0.5170000000000001,
"taskDurationMs": 2018.3969999999997,
"heapDeltaBytes": 10841784,
"heapUsedBytes": 78758620,
"domNodes": 0,
"jsHeapTotalBytes": 3371008,
"scriptDurationMs": 1017.1080000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.02192513368984,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3030.713999999989,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.626000000000001,
"layouts": 2,
"layoutDurationMs": 0.4680000000000001,
"taskDurationMs": 1830.086,
"heapDeltaBytes": 8244020,
"heapUsedBytes": 75113032,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 996.381,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.852513966480448,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.2400000000011,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2349999999999999,
"layouts": 4,
"layoutDurationMs": 1.2690000000000001,
"taskDurationMs": 447.5520000000001,
"heapDeltaBytes": 10480704,
"heapUsedBytes": 75798588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.129000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.3449999999966,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2129999999999987,
"layouts": 4,
"layoutDurationMs": 1.0340000000000003,
"taskDurationMs": 577.444,
"heapDeltaBytes": 10470944,
"heapUsedBytes": 75843240,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.74799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.496999999958,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.482,
"layouts": 10,
"layoutDurationMs": 3.3829999999999996,
"taskDurationMs": 454.1039999999999,
"heapDeltaBytes": 2106692,
"heapUsedBytes": 82748584,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 142.786,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.7130000000425,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.773000000000001,
"layouts": 9,
"layoutDurationMs": 2.7110000000000003,
"taskDurationMs": 453.62500000000006,
"heapDeltaBytes": 20574792,
"heapUsedBytes": 85559108,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 150.984,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.890000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1759999999999993,
"layouts": 10,
"layoutDurationMs": 2.9960000000000004,
"taskDurationMs": 446.923,
"heapDeltaBytes": -20580236,
"heapUsedBytes": 60157944,
"domNodes": -180,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.182,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.1489999999794,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6479999999999992,
"layouts": 9,
"layoutDurationMs": 2.458,
"taskDurationMs": 418.0659999999999,
"heapDeltaBytes": -3658124,
"heapUsedBytes": 61330992,
"domNodes": -180,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 10.069999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.8710000000406,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.9,
"layouts": 10,
"layoutDurationMs": 2.9479999999999995,
"taskDurationMs": 901.286,
"heapDeltaBytes": 505804,
"heapUsedBytes": 81127956,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 111.4,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.3690000000906,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.290000000000001,
"layouts": 10,
"layoutDurationMs": 2.8390000000000004,
"taskDurationMs": 903.751,
"heapDeltaBytes": 449676,
"heapUsedBytes": 81160780,
"domNodes": -180,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 111.231,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1454.3749999999704,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.823999999999998,
"layouts": 5,
"layoutDurationMs": 15.882,
"taskDurationMs": 1075.841,
"heapDeltaBytes": 11790616,
"heapUsedBytes": 110208928,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 29.056000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 153,
"frameDurationMs": 19.553333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10620.384999999998,
"styleRecalcs": 248,
"styleRecalcDurationMs": 19.163,
"layouts": 5,
"layoutDurationMs": 1.4880000000000002,
"taskDurationMs": 6083.711,
"heapDeltaBytes": -22293672,
"heapUsedBytes": 76987824,
"domNodes": -258,
"jsHeapTotalBytes": -32768,
"scriptDurationMs": 2740.245,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.692295597484275,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10497.08499999997,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.753,
"layouts": 7,
"layoutDurationMs": 1.9529999999999998,
"taskDurationMs": 6103.494,
"heapDeltaBytes": -25869320,
"heapUsedBytes": 77269716,
"domNodes": -263,
"jsHeapTotalBytes": -32768,
"scriptDurationMs": 2717.368,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22936.902999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22078.55,
"heapDeltaBytes": -19652116,
"heapUsedBytes": 259163208,
"domNodes": -3330,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 302.968,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.67543252595156,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15110.514999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14619.804000000002,
"heapDeltaBytes": -3152160,
"heapUsedBytes": 286169852,
"domNodes": -3330,
"jsHeapTotalBytes": 21483520,
"scriptDurationMs": 214.819,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.30574912891986,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 27534.843000000023,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.17400000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27191.438999999995,
"heapDeltaBytes": 1166560,
"heapUsedBytes": 285150768,
"domNodes": -3334,
"jsHeapTotalBytes": 8044544,
"scriptDurationMs": 918.129,
"eventListeners": -651,
"totalBlockingTimeMs": 115,
"frameDurationMs": 51.36623134328357,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 26879.418999999983,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.730999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26490.474000000002,
"heapDeltaBytes": 9560972,
"heapUsedBytes": 281427512,
"domNodes": 0,
"jsHeapTotalBytes": -6623232,
"scriptDurationMs": 849.557,
"eventListeners": 2,
"totalBlockingTimeMs": 15,
"frameDurationMs": 49.05529197080293,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8139.279999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 93.43599999999999,
"layouts": 20,
"layoutDurationMs": 28.392,
"taskDurationMs": 7976.972000000001,
"heapDeltaBytes": -55478116,
"heapUsedBytes": 247284504,
"domNodes": -3330,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 117.579,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.28546511627907,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8124.1509999999835,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.75500000000001,
"layouts": 20,
"layoutDurationMs": 21.96600000000001,
"taskDurationMs": 7962.187000000001,
"heapDeltaBytes": -12843856,
"heapUsedBytes": 276913356,
"domNodes": -3330,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 120.897,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.18388888888888,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11584.365000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11051.775000000001,
"heapDeltaBytes": 17883644,
"heapUsedBytes": 264160276,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 157.19100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.47508532423208,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7829.820999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7388.285,
"heapDeltaBytes": 18817420,
"heapUsedBytes": 298211192,
"domNodes": 0,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 115.74299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.73255033557047,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 482.874000000038,
"styleRecalcs": 14,
"styleRecalcDurationMs": 12.217,
"layouts": 13,
"layoutDurationMs": 4.975999999999999,
"taskDurationMs": 142.924,
"heapDeltaBytes": -12932912,
"heapUsedBytes": 63427836,
"domNodes": 100,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.322000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 115.42500000007294,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.637999999999998,
"layouts": 8,
"layoutDurationMs": 3.5860000000000007,
"taskDurationMs": 94.59899999999999,
"heapDeltaBytes": -11879468,
"heapUsedBytes": 64124052,
"domNodes": 117,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 6.324999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 449.73400000003494,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.718,
"layouts": 76,
"layoutDurationMs": 14.751,
"taskDurationMs": 406.24,
"heapDeltaBytes": -15556400,
"heapUsedBytes": 77304328,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 196.416,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 506.7830000000413,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8170000000000001,
"layouts": 76,
"layoutDurationMs": 16.903000000000002,
"taskDurationMs": 459.3,
"heapDeltaBytes": 11660496,
"heapUsedBytes": 87314076,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 220.157,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 566.5079999999989,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.4450000000000003,
"layouts": 76,
"layoutDurationMs": 13.893,
"taskDurationMs": 526.3009999999999,
"heapDeltaBytes": 253792,
"heapUsedBytes": 117944260,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 214.484,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 578.0179999999291,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.19,
"layouts": 76,
"layoutDurationMs": 14.206,
"taskDurationMs": 532.061,
"heapDeltaBytes": 614376,
"heapUsedBytes": 117000468,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 216.99500000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.152941176470584,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2283 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8bdadd52e74507f2d5da7ed259213c4e6ca60c07
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #20782 +/- ##
==========================================
+ Coverage 86.46% 87.27% +0.81%
==========================================
Files 3712 2649 -1063
Lines 176549 148007 -28542
Branches 48791 38539 -10252
==========================================
- Hits 152655 129175 -23480
+ Misses 21836 18442 -3394
+ Partials 2058 390 -1668
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1077 files with indirect coverage changes 🚀 New features to boost your workflow:
|
5071bb8 to
9f4b641
Compare
c4e515c to
9052096
Compare
9052096 to
41275bf
Compare
This comment has been minimized.
This comment has been minimized.
4419166 to
832dd75
Compare
41275bf to
fc4679c
Compare
There was a problem hiding this comment.
Surface here is narrower than expected. Leads me to believe there's potential for further refactoring in the future.
There was a problem hiding this comment.
Answer: The narrow surface is on purpose. LitegraphServiceAccess lists only what the four modules below litegraphService call: addNodeInput (dynamicWidgets, dynamicGroupWidget), updatePreviews (promotionUtils) and fitView (subgraphNavigationStore). useLitegraphService returns ten members. Since only those three cross the cycle, they could later move out of litegraphService into modules the callers import directly, and then this access module could be deleted. That would be a separate change; this PR doesn't change their behaviour.
There was a problem hiding this comment.
This function has been on my TODO list to fully delete.
There was a problem hiding this comment.
Answer: This PR moves createNode out of litegraphUtil unchanged, only to take litegraphUtil out of the useNodeZIndex -> canvasStore -> litegraphUtil cycle. Its remaining callers are usePaste (LoadImage, LoadAudio and LoadVideo on paste) and app.ts (handleFile, handleMeshFile and handleFileList). Now that it sits in its own utils/createNode.ts with those two importers, deleting it later only means replacing those six calls.
|
Review feedback round at fc4679c:
There are no review-body items or top-level comments to answer. No commits pushed. |
fc4679c to
9cbf7e5
Compare
832dd75 to
8481017
Compare
9cbf7e5 to
866fd13
Compare
createNode was the only litegraphUtil function that needed useNodeZIndex, which imports canvasStore, which imports litegraphUtil. Moving it to its own module takes litegraphUtil out of that cycle. Its two callers, app and usePaste, import it from the new module.
dynamicWidgets, dynamicGroupWidget, promotionUtils and subgraphNavigationStore called useLitegraphService(), and litegraphService imports each of them back, directly or through the stores it uses. They now call useLitegraphServiceAccess() from core/graph/litegraphServiceAccess, which litegraphService fills with useLitegraphService when it loads. litegraphService is in main.ts's static import graph, so the access is in place before any of them runs.
workflowStore constructed ChangeTracker and executionErrorStore read ChangeTracker.isLoadingGraph, while changeTracker imports workflowStore and, through executionStore, executionErrorStore. Both now use ChangeTrackerAccess from scripts/changeTrackerAccess, which changeTracker sets to the ChangeTracker class when it loads, so they still construct the same class and read the same static flag. changeTracker is in main.ts's static import graph. Two workflow tests that loaded changeTracker only through workflowStore now import it themselves.
…dule TaskItemImpl called useExtensionService().invokeExtensions, and extensionService reaches queueStore back through widgetStore, the widget constructors and assetsStore. queueStore now calls useExtensionServiceAccess() from services/extensionServiceAccess, which extensionService fills with useExtensionService when it loads. extensionService is in main.ts's static import graph. Two store tests that loaded changeTracker only through this import now import it themselves, and the queue test provides its stub through the access module.
…ores they use canvasStore called promoteRecommendedWidgets from promotionUtils, which imports canvasStore. subgraphNavigationStore called useWorkflowService().openWorkflow, and workflowService imports subgraphNavigationStore. canvasStore now exports providePromoteRecommendedWidgets and subgraphNavigationStore exports provideWorkflowService. promotionUtils and workflowService call them when they load, with the same function they used to be imported for. Both providers are in main.ts's static import graph. Four tests that loaded changeTracker only through one of the removed imports now import it themselves.
useWorkflowThumbnail took the ComfyWorkflow type from workflowStore, which imports useWorkflowThumbnail; it now takes it from comfyWorkflow, where it is declared. jobOutputCache took the TaskItemImpl type from queueStore, which imports jobOutputCache; it now declares the four members it reads.
nodeSizeUtil imported the litegraph barrel for LiteGraph.NODE_TITLE_HEIGHT, which pulled layoutStore and the layout operations into the litegraph import cycle. It now reads the same singleton through litegraph() from litegraphInstance, which the barrel registers when it constructs it.
648f407 to
522f5fa
Compare
…rg#20777) ## Summary Consolidates Comfy-Org#20771, Comfy-Org#20774, and Comfy-Org#20777. Their individual commits remain in order; review history remains on the original PRs. ```text obsolete lazy imports → direct imports remint caller → registered workspace remint function auth consumers → access modules ← provider registration SSO and task types → leaf modules ``` Includes the unused missing-model `assetsStore` parameter removal and the guarded auth-access follow-up. Stack: `main` → Comfy-Org#19189 → Comfy-Org#19148 → **Comfy-Org#20777** → Comfy-Org#20782 → Comfy-Org#20799. Tracks FE-2769 / FE-3037. ## Evidence - Before: three PR boundaries. After: one 32-file diff against Comfy-Org#19148, +226/−126 lines. - Auth, workspace stores, password dialogs, and missing-model suites: 46 files, 1,541 tests passed, without retries. - Previous-head CI results do not cover this rebased head. ## Merge Danger **Door:** two-way. **Blast Radius:** authentication. Provider modules must register before consumers call the access functions. The guarded access functions retain their assertions. Session-cookie loading remains on demand, while feature flags and SSO presentation use direct imports. This changes module dependencies and load order; it does not remove the runtime relationships between stores. Prior review discussion about the access-module design remains relevant.
christian-byrne
left a comment
There was a problem hiding this comment.
Approving. This is a large stacked import-cycle refactor (risk:xhigh) already carrying Austin Mroz's approval and several CodeRabbit/mrseek-reviews rounds; I focused my own pass on the billing-adjacent surface since that's the account-layer angle Christian is requested for here.
What I checked beyond the existing threads:
- The three new "registered access module" patterns this PR introduces for breaking cycles (
useBillingReadRail/billingSdkStore,billingDialogsAccess/useBillingDialogs, plus the litegraph/extension/changeTracker ones Austin already covered) all share the same shape: a provider callsprovideX(...)at its own module's top level, and a consumer calls the registered function later inside a composable body. That only works if the provider's module is guaranteed to load before any consumer call fires. - Traced the static import graph for both billing patterns.
billingSdkStore.ts's registration is reached eagerly through the always-mounted topbar (WorkflowTabs.vue→TopbarSubscribeButton.vue→useSubscriptionDialog.ts).useBillingDialogs.ts's registration is reached throughextensionDialogService.tsanduseWorkspaceMenuItems.ts, both core/eager infra. The consumers that worried me at first (useBillingCapabilities.ts,useSubscription.ts,useBillingPlans.ts,UsageLogsTable.vue,useSubscriptionCheckout.ts's downgrade path) don't themselves import the providers, but none of them can run before the app shell mounts, so the ordering holds in practice.playwright-tests-cloud-shardedand the billing e2e/unit gates are green, which is real coverage of this exact path. - Spot-checked two of the "not changed, outside this PR's scope" CodeRabbit threads (
billingRefresh.ts,TopUpCreditsDialogContentLegacy.vue) againstmaindirectly — both diffs are empty, confirming mrseek-reviews's replies are accurate and those findings are pre-existing, not introduced here.
No correctness issue found on the billing-touched files. Leaving the litegraph/graph-service judgment calls to Austin's domain, since his approval already covers that ground and his two open threads there read as forward-looking notes rather than blockers.
…rg#20799) ## Summary Consolidates Comfy-Org#20786 and Comfy-Org#20799: remove litegraph runtime imports through registered access points, then remove type-import cycles through exact merged entity interfaces. The ordered runtime and type commits remain separate for review. Tracks FE-2769 / FE-3037. ```text runtime consumers → leaf helpers / registered class access type consumers → entityRegistry ← concrete class augmentations published declarations → exact provider type re-exports ``` Stack: `main` → Comfy-Org#19189 → Comfy-Org#19148 → Comfy-Org#20777 → Comfy-Org#20782 → **Comfy-Org#20799**. The declaration-bundling prerequisite and isolated consumer test are included. The proposed type contract is documented in ADR-TYPES-LITEGRAPH-0044. ## Evidence - Before restacking: a stale 426-file diff containing duplicate ancestor history. After: 131 files against Comfy-Org#20782, +1,450/−561 lines. - The only discarded own commit edited the ADR index deleted on `main`. All eight remaining type-series patches are preserved, apart from removing their obsolete index entry. - Dependency-cruiser plus strongly connected component analysis: zero cyclic modules and zero cycles for all edges, runtime edges, and static runtime edges. - Combined targeted run: 195 test files passed; 3,515 tests passed, 8 expected failures, 5 skipped. The isolated declaration-publishing test also passed separately. No retries. - Application and scripts typechecks, scoped conflict-resolution lint, and ADR naming validation passed. Previous-head CI results do not cover this rebased head. ## Merge Danger **Door:** two-way. **Blast Radius:** litegraph. Runtime providers must load before class consumers. Type providers must remain reachable through the public barrel. Recursive type relationships remain, and published declarations require the transformation that replaces internal augmentations with exact type re-exports. The isolated declaration test passed; the previously reported package-wide declaration diagnostics remain outside its coverage. No extension callback, serialization, or public class identity policy is intentionally changed. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
Summary
Break the remaining import cycles outside litegraph through ten ordered commits covering load3d, billing SDK and dialogs, node creation, graph services, ChangeTracker, extension callbacks, workflow navigation, and layout types.
Stack:
main→ #19189 → #19148 → #20777 → #20782 → #20799. Tracks FE-2769 / FE-3037.Evidence
main's current model disposal, independent geometry/material/texture ownership, cancellation outcome, and skeleton-display restoration intocopyLoad3dState's new owner.Merge Danger
Door: two-way. Blast Radius: workflows.
Provider registration must precede consumer calls.
useSubscriptionDialognow loads eagerly throughuseBillingDialogs; the pricing-dialog components remain lazy. ChangeTracker construction and its loading flag, extension callbacks, canvas promotion, and workflow navigation retain their existing implementations through the registered access points.