Skip to content

refactor: split litegraph interfaces into leaf and graph-bound types - #19088

Merged
DrJKL merged 2 commits into
mainfrom
drjkl/litegraph-interfaces-split
Oct 8, 2026
Merged

DrJKL merged 2 commits into
mainfrom
drjkl/litegraph-interfaces-split

Conversation

@DrJKL

@DrJKL DrJKL commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Second slice of FE-3037. src/lib/litegraph/src/interfaces.ts (589 lines) mixed geometry primitives, utility types, slot data, link-network contracts, context-menu options, panel widgets, and node-creation options. Its type imports of LGraphNode, LLink, Reroute, ContextMenu, Rectangle, types/widgets and types/events put every importer of Point or ReadOnlyRect into the largest import cycle.

This PR keeps interfaces.ts as a leaf (it now imports only branded IDs from src/types/* and types/globalEnums) and moves the graph-bound contracts into files named by responsibility.

Measured with dependency-cruiser on src (the #19085 config, run locally), rebased on main at 03bca8a: cyclic modules 660 -> 653, largest SCC 444 (unchanged), cyclic edges 2577 -> 2520. Originally cycle-free after this slice, before the merged slices above it moved the numbers: Rectangle, measure, ConstrainedSize, LGraphBadge, LGraphButton, node/SlotBase, interfaces inside litegraph; linkStore, rerouteStore, linkTopology, mathUtil, positionBounds, nodeDefUtil, boundsCalculator, marqueeSelectionUtil, useAssetGridSelection, useTimelineScrub, gradients, GradientSlider.vue, NodeBadge.vue, GizmoManager, load3dViewport in the app.

Rebased onto main after #19085 was closed in favour of #20461 (warn-only pnpm deps:audit). Targets main directly; the rest of the stack (#19092 and up) is rebased on this branch.

Tracks FE-2769 / FE-3037.

Changes

  • interfaces.ts: leaf. Keeps Point, Size, Rect, ReadOnlyRect, Positionable, HasBoundingRect, INodeSlot, INodeFlags, ISlotType, IWidgetLocator, LinkSegment, DefaultConnectionColors, colour and utility types. LinkId/RerouteId now come from @/types/linkId and @/types/rerouteId instead of via LLink/Reroute.
  • types/slots.ts: INodeInputSlot, INodeOutputSlot, IWidgetInputSlot, ISubgraphInput, IFoundSlot, INodeSlotContextItem, ConnectingLink. INodeInputSlot cannot be a leaf because _widget?: IBaseWidget references types/widgets, which references LGraphNode/LGraphCanvas.
  • types/linkNetwork.ts: LinkNetwork, ReadonlyLinkNetwork, ItemLocator.
  • types/contextMenu.ts: IContextMenuOptions, IContextMenuValue, ContextMenuDivElement.
  • types/panel.ts: Panel*.
  • CreateNodeOptions -> LiteGraphGlobal.ts; NewNodePosition, IBoundaryNodes -> utils/arrange.ts; Hoverable -> types/events.ts.
  • 94 files repointed (98 changed, 4 new), including node/widgetsView.ts, contextMenuFilter.ts, and the agent CRDT files added on main since the branch forked. Declarations moved verbatim. The litegraph.ts barrel exports the same names, so the extension API is unchanged.

Review Focus

  • pnpm typecheck, oxlint --type-aware, eslint (warnings only, same as main), pnpm knip, fallow audit, litegraph and touched-area unit tests (217 files) pass on the rebased head.
  • git diff -M --stat is mostly import-line churn; the only new code is import headers in the four new files.
  • Rebase conflicts resolved by hand: interfaces.ts re-applies main's ISlotType = number | string | string[] and slot_index?: SlotIndex on INodeSlot; types/slots.ts carries main's _pendingDemotionToken on INodeInputSlot; types/panel.ts carries main's widened PanelWidgetOptions.values; nodeDataStore.ts is taken from main.
  • Next slice: types/widgets.ts (657 lines) and the simplifiedWidget two-cycle, which is what keeps INodeInputSlot and the ~26 widget classes in the SCC.

Stack

Import-cycle progress for FE-3037, measured with pnpm lint:cycles (dependency-cruiser on src).

Standalone PRs targeting main

Each is one commit on current main and can merge on its own. Numbers are that PR alone against origin/main (1027 cyclic modules, largest cycle 983, 4562 cyclic edges).

PR Base Change Cyclic modules Largest cycle Cyclic edges
#19089 main ServerFeatureFlag enum to a leaf module 1027 -> 884 983 -> 677 4562 -> 3382
#19094 main Empty-workflow dialog out of appModeStore 1027 -> 1026 983 -> 982 4562 -> 4558
#19109 main Mask editor menu item into Comfy.MaskEditor extension 1027 -> 1027 983 -> 983 4562 -> 4562
#19112 main PositionConfig and layer editor dialog key to leaf modules 1027 -> 1027 983 -> 983 4562 -> 4558
#19122 main settingStore off scripts/app; $el to a leaf 1027 -> 1025 983 -> 981 4562 -> 4552
#19124 main MissingNodeType to the nodeReplacement leaf 1027 -> 1027 983 -> 983 4562 -> 4555
#19125 main Blueprint node defs owned by nodeDefStore 1027 -> 1027 983 -> 983 4562 -> 4561
#19127 main Thumbnail and minimap data from explicit inputs 1027 -> 1027 983 -> 983 4562 -> 4561

All eight together on main, plus #19091, #19107, #19108, #19111, #19116 and #19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges.

Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older main the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses.

#19091, #19107, #19111, #19113 and #19131 still carry the old commits of the PRs they were moved off (#19131 carries #19122, #19124, #19125 and #19127), so their GitHub diffs are wider than one PR until the stack is rebased.

PR Base Change Cyclic modules Largest cycle
#19085 main Import-cycle baseline check (pnpm lint:cycles) 967 (baseline) 923 (baseline)
#19088 (this PR) #19085 Split litegraph interfaces.ts into leaf types 967 -> 949 923 -> 905
#19091 #19088 (measured on #19089) Register core sidebar tabs outside sidebarTabStore 816 -> 669 618 -> 465
#19092 #19091 Load extensions from bootstrap, not extensionService 669 -> 580 465 -> 371
#19093 #19092 Split scripts/widgets.ts registry, types, helpers 580 -> 566 371 -> 357
#19107 #19093 (measured on #19094) Register settings dialog from the app shell 558 -> 509 349 -> 297
#19108 #19107 Register asset browser modal from the app shell 509 -> 496 297 -> 284
#19111 #19108 (measured on #19109) Register core bottom panel tabs from GraphView 484 -> 476 272 -> 264
#19113 #19111 (measured on #19112) Model library asset-browser routing onto the sidebar tab 471 -> 467 257 -> 253
#19116 #19113 Progress text previews out of executionStore 467 -> 464 253 -> 250
#19118 #19116 Inject the api auth provider from main.ts 464 -> 447 250 -> 233
#19121 #19118 Install workspace api credentials from main.ts 447 -> 428 233 -> 214
#19131 #19121 (measured on #19127) Feature dialogs out of dialogService 400 -> 391 181 -> 172
#19143 #19131 Invert scripts/app behind useApp() 391 -> 352 172 -> 149
#19148 #19143 Billing rails announce refreshes; dialogs above the facade 352 -> 324 149 (baseline)
#19153 #19148 types/comfy, comfyWorkflow, dialog/workflow contracts as leaves 324 -> 293 149 (baseline)
#19186 #19153 Workbench cycles: openManager onto useManagerDialog, agent leaves 293 -> 259 149 (baseline)
#19189 #19186 Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more 259 -> 211 149 (baseline)

@DrJKL
DrJKL requested review from a team, bigcat88, jojodecayz and jtydhr88 as code owners September 27, 2026 08:38
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 5be42ea0-8bc5-42b8-98d9-e6e26fd92a74
📥 Commits

Reviewing files that changed from the base of the PR and between 84bb457 and 8d57382.

📒 Files selected for processing (1)
  • src/extensions/core/maskeditor.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC.


📝 Walkthrough

Walkthrough

LiteGraph type declarations move into dedicated modules or their owning modules. Imports and barrel exports across LiteGraph and its application consumers now reference those locations. The summaries report no runtime behavior changes.

Changes

LiteGraph type modules

Layer / File(s) Summary
Define and export focused type contracts
src/lib/litegraph/src/types/*, src/lib/litegraph/src/interfaces.ts, src/lib/litegraph/src/utils/arrange.ts, src/lib/litegraph/src/LiteGraphGlobal.ts, src/lib/litegraph/src/litegraph.ts
Adds dedicated slot, context-menu, link-network, and panel declarations, and adds Hoverable to the events module. Relocates arrangement and node-creation types, removes relocated declarations from interfaces.ts, and updates public exports.
Update LiteGraph implementation imports
src/lib/litegraph/src/*, src/lib/litegraph/src/canvas/*, src/lib/litegraph/src/node/*, src/lib/litegraph/src/subgraph/*, src/lib/litegraph/src/widgets/*
LiteGraph implementation and test files import types from their dedicated modules.
Update application and renderer imports
src/components/*, src/composables/*, src/core/*, src/extensions/*, src/platform/*, src/renderer/*, src/scripts/*, src/types/*, src/utils/*, src/workbench/*
Application, renderer, extension, workbench, and test files update slot and context-menu type imports.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Suggested reviewers: ryan-di

Merge Risk: ⚪ Minimal · up to 8d573

This test-only import change presents no identified user-facing or operational risk and is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 6 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The PR contains a bug-fix signal (fix: import ContextMenuDivElement from types/contextMenu) and changes many src/ files, with no listed browser_tests/ file. However, the PR description is explic… Provide the complete PR description, or confirm that it contains no concrete explanation for omitting a Playwright regression test under browser_tests/.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: splitting LiteGraph interfaces into leaf and graph-bound types.
Description check ✅ Passed The description provides a detailed summary, design rationale, scope, dependency-cycle measurements, review focus, verification results, risks, and follow-up work. It does not use the template's exact…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage ✅ Passed No changed files are under apps/website/src/ or apps/website/public/. The PR changes LiteGraph type declarations and imports, with no website runtime behavior change. Website end-to-end coverage i…
Adr Compliance For Entity/Litegraph Changes ✅ Passed PASS. The PR changes src/lib/litegraph/ and is therefore applicable. The supplied diff summary shows type-only import rewrites and relocation of existing interfaces into types/slots.ts, `types/lin…
Full details: End-To-End Regression Coverage For Fixes

Explanation

The PR contains a bug-fix signal (fix: import ContextMenuDivElement from types/contextMenu) and changes many src/ files, with no listed browser_tests/ file. However, the PR description is explicitly truncated, so the full description may contain the required concrete explanation for not adding an end-to-end regression test.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2243 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2221 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/08/2026, 07:39:50 AM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 6b0f2bd013fa16c33932085ba519cf8967b03fa7

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle: 9.35 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 40.4 MB baseline 40.4 MB — ⚪ 0 B
  • Gzip: 9.35 MB baseline 9.35 MB — ⚪ 0 B
  • Brotli: 7.23 MB baseline 7.23 MB — ⚪ 0 B
  • Bundles: 542 current • 542 baseline

Category Glance
Other ⚪ 0 B (18.7 MB) · Vendor & Third-Party ⚪ 0 B (14.2 MB) · Data & Services ⚪ 0 B (3.07 MB) · Graph Workspace ⚪ 0 B (2.14 MB) · Utilities & Hooks ⚪ 0 B (812 kB) · Panels & Settings ⚪ 0 B (671 kB) · + 5 more

App Entry Points — 4.43 kB (baseline 4.43 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 2.14 MB (baseline 2.14 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 154 kB (baseline 154 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 19 unchanged

Panels & Settings — 671 kB (baseline 671 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 30 unchanged

User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 15 unchanged

Editors & Dialogs — 325 kB (baseline 325 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 13 unchanged

UI Components — 201 kB (baseline 201 kB) • ⚪ 0 B

Reusable component library chunks

Status: 24 unchanged

Data & Services — 3.07 MB (baseline 3.07 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 22 unchanged

Utilities & Hooks — 812 kB (baseline 812 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 50 unchanged

Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 18.7 MB (baseline 18.7 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 347 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 31.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 437ms TBT · 94.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 44.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 135ms TBT · 77.6 MB heap
extension-clean-combined-draw: · 38.1 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 144ms TBT · 85.8 MB heap
extension-rgthree-prototype-draw: · 40.1 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 65ms TBT · 85.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
subgraph-transition-enter: · 48.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 115ms TBT · 108.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.6 MB heap
vue-large-graph-idle: · 45.4 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 176.0 MB heap
vue-large-graph-pan: · 35.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 181.1 MB heap
vue-node-resize-workload: · 35.3 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 3ms TBT · 210.3 MB heap
vue-zoom-out-idle: · 44.4 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 177.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.3 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
agent-composer-long-conversation-typing: · 59.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 111.9 MB heap

⚠️ 2 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
dom-widget-clipping: heap used 68.9 MB 89.6 MB +30% ⚠️ z=2.6
workflow-execution: heap used 62.2 MB 85.3 MB +37% ⚠️ z=6.6
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=0.7
canvas-idle: p95 frame time 17ms 17ms +0% z=-1.8
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 4ms 3ms -14% z=-1.2
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 11 +22% z=0.3
canvas-idle: task duration 537ms 444ms -17% z=-0.1
canvas-idle: script duration 13ms 9ms -32% z=-0.6
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 79.2 MB 58.2 MB -27% z=-0.4
canvas-idle: DOM nodes 0 -212 — z=-0.9
canvas-idle: event listeners 0 -148 — z=-0.9
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms -0% z=0.4
canvas-mouse-sweep: layout duration 5ms 4ms -32% z=-2.6
canvas-mouse-sweep: style recalc duration 19ms 12ms -35% z=-2.0
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 79 72 -9% z=-0.2
canvas-mouse-sweep: task duration 905ms 619ms -32% z=-1.3
canvas-mouse-sweep: script duration 172ms 115ms -33% z=-1.2
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 63.1 MB 68.7 MB +9% z=-0.6
canvas-mouse-sweep: DOM nodes 0 0 +0% z=1.9
canvas-mouse-sweep: event listeners 0 0 +0% z=1.9
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.6
canvas-zoom-sweep: p95 frame time 17ms 17ms +1% z=1.7
canvas-zoom-sweep: layout duration 1ms 1ms +5% z=0.5
canvas-zoom-sweep: style recalc duration 7ms 5ms -22% z=-1.5
canvas-zoom-sweep: layout count 3 3 +0% —
canvas-zoom-sweep: style recalc count 19 18 -5% z=-2.3
canvas-zoom-sweep: task duration 442ms 305ms -31% z=-1.2
canvas-zoom-sweep: script duration 13ms 10ms -24% z=-1.0
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 60.8 MB 64.4 MB +6% z=-0.2
canvas-zoom-sweep: DOM nodes -167 -61 -63% z=0.2
canvas-zoom-sweep: event listeners -109 -35 -68% z=0.1
dom-widget-clipping: avg frame time 17ms 17ms +0% z=-0.5
dom-widget-clipping: p95 frame time 17ms 17ms -0% z=-1.5
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 4ms 3ms -23% z=-2.5
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 14 15 +4% z=0.1
dom-widget-clipping: task duration 497ms 335ms -33% z=-2.0
dom-widget-clipping: script duration 174ms 130ms -25% z=-1.1
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 68.9 MB 89.6 MB +30% ⚠️ z=2.6
dom-widget-clipping: DOM nodes 0 0 +0% z=1.8
dom-widget-clipping: event listeners 0 0 +0% z=1.9
dom-widget-order-dense-n200-w200-i120: avg frame time 35ms 32ms -10% z=-0.3
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms 17ms +0% z=0.9
dom-widget-order-dense-n200-w200-i120: layout duration 0ms 0ms +0% —
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms 0ms +0% —
dom-widget-order-dense-n200-w200-i120: layout count 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: style recalc count 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: task duration 886ms 690ms -22% z=-0.5
dom-widget-order-dense-n200-w200-i120: script duration 75ms 50ms -33% z=-0.8
dom-widget-order-dense-n200-w200-i120: TBT 549ms 437ms -20% z=-0.4
dom-widget-order-dense-n200-w200-i120: heap used 89.8 MB 94.7 MB +5% z=1.4
dom-widget-order-dense-n200-w200-i120: DOM nodes 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: event listeners 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms 22ms -12% z=-1.0
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms 17ms +0% z=-0.2
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms 0ms +0% —
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms 0ms +0% —
dom-widget-order-sparse-n1000-w20-i120: layout count 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: task duration 529ms 353ms -33% z=-1.1
dom-widget-order-sparse-n1000-w20-i120: script duration 183ms 111ms -39% z=-1.2
dom-widget-order-sparse-n1000-w20-i120: TBT 235ms 135ms -43% z=-1.1
dom-widget-order-sparse-n1000-w20-i120: heap used 78.5 MB 77.6 MB -1% z=-1.0
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: event listeners 0 0 +0% —
extension-clean-combined-draw: avg frame time 32ms 26ms -19% z=-0.7
extension-clean-combined-draw: p95 frame time 67ms 42ms -37% z=-0.6
extension-clean-combined-draw: layout duration 0ms 0ms +0% —
extension-clean-combined-draw: style recalc duration 0ms 1ms +107% variance too high
extension-clean-combined-draw: layout count 0 0 +0% —
extension-clean-combined-draw: style recalc count 1 4 +250% variance too high
extension-clean-combined-draw: task duration 10250ms 6318ms -38% z=-1.0
extension-clean-combined-draw: script duration 8473ms 5182ms -39% z=-0.9
extension-clean-combined-draw: TBT 1409ms 144ms -90% variance too high
extension-clean-combined-draw: heap used 86.0 MB 85.8 MB -0% z=1.3
extension-clean-combined-draw: DOM nodes -141 -142 +1% z=-2.4
extension-clean-combined-draw: event listeners -65 -73 +12% z=-2.6
extension-rgthree-prototype-draw: avg frame time 32ms 25ms -22% z=-0.9
extension-rgthree-prototype-draw: p95 frame time 67ms 33ms -50% z=-1.5
extension-rgthree-prototype-draw: layout duration 0ms 0ms +0% —
extension-rgthree-prototype-draw: style recalc duration 0ms 1ms — variance too high
extension-rgthree-prototype-draw: layout count 0 0 +0% —
extension-rgthree-prototype-draw: style recalc count 0 3 — variance too high
extension-rgthree-prototype-draw: task duration 10126ms 5985ms -41% z=-1.2
extension-rgthree-prototype-draw: script duration 8361ms 4642ms -44% z=-1.3
extension-rgthree-prototype-draw: TBT 1267ms 65ms -95% variance too high
extension-rgthree-prototype-draw: heap used 83.2 MB 85.6 MB +3% z=1.6
extension-rgthree-prototype-draw: DOM nodes -141 -71 -50% z=-0.2
extension-rgthree-prototype-draw: event listeners -69 -35 -50% z=-0.3
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms -1% z=-1.4
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 4ms 2ms -41% z=-1.8
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 8 9 +6% z=-0.5
large-graph-idle: task duration 593ms 466ms -21% z=-0.7
large-graph-idle: script duration 35ms 29ms -19% z=-0.9
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 80.4 MB 82.1 MB +2% z=1.0
large-graph-idle: DOM nodes 0 -154 — z=0.6
large-graph-idle: event listeners 0 -74 — z=0.6
large-graph-pan: avg frame time 17ms 17ms -1% z=-0.6
large-graph-pan: p95 frame time 17ms 17ms +0% z=-0.0
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 8ms 5ms -38% z=-2.0
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 67 -1% z=-0.6
large-graph-pan: task duration 1707ms 1220ms -29% z=-1.2
large-graph-pan: script duration 874ms 629ms -28% z=-1.1
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 81.7 MB 82.3 MB +1% z=1.1
large-graph-pan: DOM nodes 0 0 +0% z=1.2
large-graph-pan: event listeners 2 2 +0% z=1.0
large-graph-zoom: avg frame time 17ms 17ms +0% z=-0.4
large-graph-zoom: p95 frame time 17ms 17ms +0% z=-1.1
large-graph-zoom: layout duration 18ms 15ms -18% z=-1.9
large-graph-zoom: style recalc duration 9ms 7ms -28% z=-1.7
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 71 71 +0% z=0.4
large-graph-zoom: task duration 1818ms 1358ms -25% z=-1.1
large-graph-zoom: script duration 842ms 601ms -29% z=-1.4
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 72.1 MB 70.4 MB -2% z=-1.9
large-graph-zoom: DOM nodes 24 24 +0% variance too high
large-graph-zoom: event listeners 0 0 +0% z=0.3
legacy-node-drag: avg frame time 17ms 17ms +0% z=0.2
legacy-node-drag: p95 frame time 17ms 17ms -1% z=-1.5
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 6ms 4ms -42% z=-2.3
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 45 43 -6% z=-1.0
legacy-node-drag: task duration 1989ms 1435ms -28% z=-1.3
legacy-node-drag: script duration 1017ms 692ms -32% z=-1.7
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 83.8 MB 77.8 MB -7% z=-0.3
legacy-node-drag: DOM nodes 0 -154 — z=-3.7
legacy-node-drag: event listeners 182 182 +0% —
minimap-idle: avg frame time 17ms 17ms +0% z=-0.2
minimap-idle: p95 frame time 17ms 17ms +0% z=0.5
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 3ms 2ms -50% z=-1.4
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 7 7 +0% z=0.1
minimap-idle: task duration 626ms 436ms -30% z=-0.7
minimap-idle: script duration 38ms 29ms -22% z=-0.7
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 84.6 MB 84.8 MB +0% z=1.1
minimap-idle: DOM nodes -308 -308 +0% z=-1.5
minimap-idle: event listeners 0 -74 — z=-0.0
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.2
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% z=-1.2
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 7ms 4ms -37% z=-2.8
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 48 +1% z=0.8
subgraph-dom-widget-clipping: task duration 443ms 336ms -24% z=-1.1
subgraph-dom-widget-clipping: script duration 152ms 111ms -27% z=-1.1
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 64.8 MB 61.9 MB -4% z=-2.7
subgraph-dom-widget-clipping: DOM nodes 0 0 +0% z=1.8
subgraph-dom-widget-clipping: event listeners 46 46 +0% z=1.7
subgraph-idle: avg frame time 17ms 17ms +0% z=0.8
subgraph-idle: p95 frame time 17ms 17ms +0% z=-1.2
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 4ms 2ms -43% z=-2.4
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 11 +17% z=0.2
subgraph-idle: task duration 494ms 355ms -28% z=-1.4
subgraph-idle: script duration 10ms 8ms -21% z=-0.9
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 72.2 MB 66.7 MB -8% z=0.7
subgraph-idle: DOM nodes 0 -115 — z=0.2
subgraph-idle: event listeners 0 -97 — z=0.0
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% z=0.7
subgraph-mouse-sweep: layout duration 7ms 5ms -28% z=-1.3
subgraph-mouse-sweep: style recalc duration 18ms 14ms -26% z=-1.4
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 76 70 -9% z=-2.2
subgraph-mouse-sweep: task duration 822ms 669ms -19% z=-0.6
subgraph-mouse-sweep: script duration 121ms 81ms -34% z=-1.5
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 74.2 MB 68.3 MB -8% z=-0.8
subgraph-mouse-sweep: DOM nodes 0 -115 — z=-0.2
subgraph-mouse-sweep: event listeners 0 -97 — z=-0.3
subgraph-transition-enter: avg frame time 20ms 21ms +6% z=1.3
subgraph-transition-enter: p95 frame time 17ms 17ms -1% z=-0.7
subgraph-transition-enter: layout duration 16ms 10ms -36% z=-1.2
subgraph-transition-enter: style recalc duration 31ms 24ms -23% z=-0.6
subgraph-transition-enter: layout count 6 6 +0% —
subgraph-transition-enter: style recalc count 19 18 -5% z=-1.3
subgraph-transition-enter: task duration 1003ms 753ms -25% z=-0.6
subgraph-transition-enter: script duration 33ms 26ms -21% z=-0.4
subgraph-transition-enter: TBT 139ms 115ms -17% z=-0.0
subgraph-transition-enter: heap used 108.4 MB 108.9 MB +0% z=1.3
subgraph-transition-enter: DOM nodes 14650 14650 +0% —
subgraph-transition-enter: event listeners 2456 2456 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% z=-0.8
viewport-pan-sweep: p95 frame time 17ms 17ms -0% z=-0.1
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 22ms 14ms -38% z=-2.9
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 251 251 -0% z=0.8
viewport-pan-sweep: task duration 5967ms 4479ms -25% z=-1.2
viewport-pan-sweep: script duration 2854ms 2045ms -28% z=-1.6
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 86.6 MB 86.6 MB +0% z=1.5
viewport-pan-sweep: DOM nodes 0 -154 — z=0.2
viewport-pan-sweep: event listeners 2 -72 -3700% z=0.1
vue-large-graph-idle: avg frame time 33ms 22ms -34% z=-1.5
vue-large-graph-idle: p95 frame time 67ms 33ms -50% z=-1.8
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 18487ms 12334ms -33% z=-1.4
vue-large-graph-idle: script duration 304ms 187ms -38% z=-1.4
vue-large-graph-idle: TBT 0ms 0ms +0% variance too high
vue-large-graph-idle: heap used 176.2 MB 176.0 MB -0% z=-0.5
vue-large-graph-idle: DOM nodes -3046 -3046 +0% z=0.3
vue-large-graph-idle: event listeners -14915 -14915 +0% z=-0.3
vue-large-graph-pan: avg frame time 45ms 28ms -37% z=-1.2
vue-large-graph-pan: p95 frame time 83ms 67ms -20% z=-0.5
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 20ms 9ms -54% z=-1.3
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 181 96 -47% z=-1.1
vue-large-graph-pan: task duration 23699ms 15466ms -35% z=-1.1
vue-large-graph-pan: script duration 926ms 735ms -21% z=-0.8
vue-large-graph-pan: TBT 15ms 0ms -100% variance too high
vue-large-graph-pan: heap used 181.5 MB 181.1 MB -0% z=-0.8
vue-large-graph-pan: DOM nodes -3046 -3046 +0% z=0.6
vue-large-graph-pan: event listeners -14913 -14913 +0% —
vue-node-resize-workload: avg frame time 40ms 28ms -29% z=-1.3
vue-node-resize-workload: p95 frame time 83ms 50ms -40% z=-1.4
vue-node-resize-workload: layout duration 27ms 23ms -16% z=-1.6
vue-node-resize-workload: style recalc duration 79ms 58ms -27% z=-1.0
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6841ms 4720ms -31% z=-1.2
vue-node-resize-workload: script duration 122ms 83ms -32% z=-1.1
vue-node-resize-workload: TBT 0ms 3ms — variance too high
vue-node-resize-workload: heap used 206.4 MB 210.3 MB +2% z=0.9
vue-node-resize-workload: DOM nodes 0 0 +0% —
vue-node-resize-workload: event listeners 0 0 +0% —
vue-zoom-out-idle: avg frame time 33ms 23ms -33% z=-1.4
vue-zoom-out-idle: p95 frame time 67ms 33ms -50% z=-1.9
vue-zoom-out-idle: layout duration 0ms 0ms +0% —
vue-zoom-out-idle: style recalc duration 0ms 0ms +0% —
vue-zoom-out-idle: layout count 0 0 +0% —
vue-zoom-out-idle: style recalc count 0 0 +0% —
vue-zoom-out-idle: task duration 9414ms 6310ms -33% z=-1.3
vue-zoom-out-idle: script duration 155ms 106ms -32% z=-1.4
vue-zoom-out-idle: TBT 0ms 0ms +0% variance too high
vue-zoom-out-idle: heap used 175.8 MB 177.3 MB +1% z=0.6
vue-zoom-out-idle: DOM nodes -3046 -3046 +0% z=0.0
vue-zoom-out-idle: event listeners -14915 -14915 +0% z=-0.3
workflow-execution: avg frame time 17ms 17ms -0% z=-0.8
workflow-execution: p95 frame time 17ms 17ms -1% z=-0.7
workflow-execution: layout duration 2ms 2ms -13% z=-0.2
workflow-execution: style recalc duration 13ms 14ms +9% z=-0.3
workflow-execution: layout count 3 4 +33% z=1.3
workflow-execution: style recalc count 8 15 +88% z=0.6
workflow-execution: task duration 89ms 113ms +28% z=-0.8
workflow-execution: script duration 7ms 9ms +30% z=-0.1
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 62.2 MB 85.3 MB +37% ⚠️ z=6.6
workflow-execution: DOM nodes 98 118 +20% variance too high
workflow-execution: event listeners 33 57 +73% z=1.7
agent-composer-empty-conversation-typing: avg frame time 17ms 17ms -1% z=-0.6
agent-composer-empty-conversation-typing: p95 frame time 17ms 17ms -1% z=-0.4
agent-composer-empty-conversation-typing: layout duration 31ms 17ms -43% z=-2.5
agent-composer-empty-conversation-typing: style recalc duration 107ms 69ms -35% z=-2.0
agent-composer-empty-conversation-typing: layout count 76 76 +0% —
agent-composer-empty-conversation-typing: style recalc count 77 77 +0% z=-1.0
agent-composer-empty-conversation-typing: task duration 1090ms 452ms -59% z=-1.7
agent-composer-empty-conversation-typing: script duration 452ms 166ms -63% z=-1.6
agent-composer-empty-conversation-typing: TBT 0ms 0ms +0% —
agent-composer-empty-conversation-typing: heap used 91.9 MB 81.5 MB -11% z=-0.6
agent-composer-empty-conversation-typing: DOM nodes 77 77 +0% z=1.0
agent-composer-empty-conversation-typing: event listeners 876 876 +0% —
agent-composer-long-conversation-typing: avg frame time 19ms 17ms -10% z=-1.0
agent-composer-long-conversation-typing: p95 frame time 33ms 17ms -50% z=-1.1
agent-composer-long-conversation-typing: layout duration 32ms 18ms -44% z=-2.8
agent-composer-long-conversation-typing: style recalc duration 270ms 191ms -29% z=-2.3
agent-composer-long-conversation-typing: layout count 76 76 +0% —
agent-composer-long-conversation-typing: style recalc count 77 77 +0% z=-1.0
agent-composer-long-conversation-typing: task duration 1493ms 815ms -45% z=-2.2
agent-composer-long-conversation-typing: script duration 517ms 234ms -55% z=-1.9
agent-composer-long-conversation-typing: TBT 0ms 0ms +0% —
agent-composer-long-conversation-typing: heap used 120.2 MB 111.9 MB -7% z=-1.0
agent-composer-long-conversation-typing: DOM nodes 77 77 +0% z=1.0
agent-composer-long-conversation-typing: event listeners 876 876 +0% —
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: p95 frame time 17ms 0ms 0.2%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 5ms 1ms 25.3%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 9.1%
canvas-idle: task duration 454ms 72ms 15.8%
canvas-idle: script duration 10ms 2ms 19.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: heap used 60.7 MB 6.3 MB 10.4%
canvas-idle: DOM nodes -137 87 0.0%
canvas-idle: event listeners -92 61 0.0%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.1%
canvas-mouse-sweep: p95 frame time 17ms 0ms 0.2%
canvas-mouse-sweep: layout duration 5ms 0ms 8.7%
canvas-mouse-sweep: style recalc duration 16ms 2ms 10.8%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 73 4 5.1%
canvas-mouse-sweep: task duration 772ms 117ms 15.2%
canvas-mouse-sweep: script duration 143ms 24ms 16.7%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: heap used 71.5 MB 5.0 MB 7.0%
canvas-mouse-sweep: DOM nodes -117 62 0.0%
canvas-mouse-sweep: event listeners -82 44 0.0%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: p95 frame time 17ms 0ms 0.2%
canvas-zoom-sweep: layout duration 1ms 0ms 6.2%
canvas-zoom-sweep: style recalc duration 7ms 1ms 11.8%
canvas-zoom-sweep: layout count 3 0 0.0%
canvas-zoom-sweep: style recalc count 19 0 1.6%
canvas-zoom-sweep: task duration 373ms 57ms 15.3%
canvas-zoom-sweep: script duration 12ms 2ms 15.6%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: heap used 65.7 MB 6.9 MB 10.5%
canvas-zoom-sweep: DOM nodes -73 63 0.0%
canvas-zoom-sweep: event listeners -40 45 0.0%
dom-widget-clipping: avg frame time 17ms 0ms 0.5%
dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 4ms 1ms 12.2%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 14 1 8.3%
dom-widget-clipping: task duration 457ms 62ms 13.6%
dom-widget-clipping: script duration 156ms 23ms 14.9%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: heap used 69.4 MB 7.7 MB 11.1%
dom-widget-clipping: DOM nodes -118 64 0.0%
dom-widget-clipping: event listeners -79 41 0.0%
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms 3ms 9.5%
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms 0ms 0.1%
dom-widget-order-dense-n200-w200-i120: layout duration 0ms 0ms 0.0%
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms 0ms 0.0%
dom-widget-order-dense-n200-w200-i120: layout count 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: style recalc count 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: task duration 761ms 130ms 17.1%
dom-widget-order-dense-n200-w200-i120: script duration 60ms 12ms 20.2%
dom-widget-order-dense-n200-w200-i120: TBT 478ms 102ms 21.2%
dom-widget-order-dense-n200-w200-i120: heap used 90.7 MB 2.8 MB 3.1%
dom-widget-order-dense-n200-w200-i120: DOM nodes 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: event listeners 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: avg frame time 24ms 2ms 6.6%
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms 1ms 8.3%
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms 0ms 0.0%
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms 0ms 0.0%
dom-widget-order-sparse-n1000-w20-i120: layout count 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: task duration 436ms 77ms 17.6%
dom-widget-order-sparse-n1000-w20-i120: script duration 145ms 28ms 19.1%
dom-widget-order-sparse-n1000-w20-i120: TBT 187ms 49ms 26.1%
dom-widget-order-sparse-n1000-w20-i120: heap used 84.7 MB 7.1 MB 8.4%
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: event listeners 0 0 0.0%
extension-clean-combined-draw: avg frame time 29ms 4ms 14.6%
extension-clean-combined-draw: p95 frame time 48ms 10ms 20.0%
extension-clean-combined-draw: layout duration 0ms 0ms 0.0%
extension-clean-combined-draw: style recalc duration 0ms 0ms 138.8%
extension-clean-combined-draw: layout count 0 0 0.0%
extension-clean-combined-draw: style recalc count 1 1 120.5%
extension-clean-combined-draw: task duration 7940ms 1595ms 20.1%
extension-clean-combined-draw: script duration 6502ms 1402ms 21.6%
extension-clean-combined-draw: TBT 579ms 435ms 75.2%
extension-clean-combined-draw: heap used 78.8 MB 5.3 MB 6.7%
extension-clean-combined-draw: DOM nodes -38 44 0.0%
extension-clean-combined-draw: event listeners -18 21 0.0%
extension-rgthree-prototype-draw: avg frame time 29ms 4ms 14.8%
extension-rgthree-prototype-draw: p95 frame time 47ms 9ms 19.4%
extension-rgthree-prototype-draw: layout duration 0ms 0ms 0.0%
extension-rgthree-prototype-draw: style recalc duration 0ms 0ms 96.2%
extension-rgthree-prototype-draw: layout count 0 0 0.0%
extension-rgthree-prototype-draw: style recalc count 1 1 83.2%
extension-rgthree-prototype-draw: task duration 8009ms 1621ms 20.2%
extension-rgthree-prototype-draw: script duration 6531ms 1454ms 22.3%
extension-rgthree-prototype-draw: TBT 578ms 468ms 80.9%
extension-rgthree-prototype-draw: heap used 76.9 MB 5.4 MB 7.0%
extension-rgthree-prototype-draw: DOM nodes -61 47 0.0%
extension-rgthree-prototype-draw: event listeners -28 21 0.0%
large-graph-idle: avg frame time 17ms 0ms 0.1%
large-graph-idle: p95 frame time 17ms 0ms 0.2%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 3ms 1ms 19.5%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 9 1 8.0%
large-graph-idle: task duration 526ms 85ms 16.2%
large-graph-idle: script duration 32ms 4ms 11.8%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: heap used 80.6 MB 1.5 MB 1.8%
large-graph-idle: DOM nodes -214 92 0.0%
large-graph-idle: event listeners -101 44 0.0%
large-graph-pan: avg frame time 17ms 0ms 0.3%
large-graph-pan: p95 frame time 17ms 0ms 0.2%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 7ms 1ms 13.7%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 68 1 1.5%
large-graph-pan: task duration 1476ms 217ms 14.7%
large-graph-pan: script duration 763ms 118ms 15.5%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: heap used 77.5 MB 4.2 MB 5.4%
large-graph-pan: DOM nodes -117 95 0.0%
large-graph-pan: event listeners -43 46 0.0%
large-graph-zoom: avg frame time 17ms 0ms 0.1%
large-graph-zoom: p95 frame time 17ms 0ms 0.2%
large-graph-zoom: layout duration 17ms 1ms 6.1%
large-graph-zoom: style recalc duration 8ms 1ms 10.7%
large-graph-zoom: layout count 60 0 0.0%
large-graph-zoom: style recalc count 71 1 1.6%
large-graph-zoom: task duration 1576ms 204ms 13.0%
large-graph-zoom: script duration 734ms 96ms 13.0%
large-graph-zoom: TBT 0ms 0ms 0.0%
large-graph-zoom: heap used 76.8 MB 3.4 MB 4.4%
large-graph-zoom: DOM nodes 10 36 350.3%
large-graph-zoom: event listeners -3 13 0.0%
legacy-node-drag: avg frame time 17ms 0ms 0.3%
legacy-node-drag: p95 frame time 17ms 0ms 0.2%
legacy-node-drag: layout duration 0ms 0ms 0.0%
legacy-node-drag: style recalc duration 5ms 1ms 13.9%
legacy-node-drag: layout count 0 0 0.0%
legacy-node-drag: style recalc count 44 1 2.4%
legacy-node-drag: task duration 1738ms 231ms 13.3%
legacy-node-drag: script duration 899ms 123ms 13.7%
legacy-node-drag: TBT 0ms 0ms 0.0%
legacy-node-drag: heap used 79.3 MB 4.6 MB 5.7%
legacy-node-drag: DOM nodes -14 37 0.0%
legacy-node-drag: event listeners 182 0 0.0%
minimap-idle: avg frame time 17ms 0ms 0.1%
minimap-idle: p95 frame time 17ms 0ms 0.2%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 2ms 1ms 22.8%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 7 1 16.9%
minimap-idle: task duration 494ms 86ms 17.3%
minimap-idle: script duration 32ms 4ms 10.9%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: heap used 82.2 MB 2.5 MB 3.0%
minimap-idle: DOM nodes -192 76 0.0%
minimap-idle: event listeners -72 44 0.0%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 6ms 1ms 9.7%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 47 1 2.0%
subgraph-dom-widget-clipping: task duration 400ms 57ms 14.3%
subgraph-dom-widget-clipping: script duration 134ms 20ms 15.1%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: heap used 67.3 MB 2.0 MB 2.9%
subgraph-dom-widget-clipping: DOM nodes -125 71 0.0%
subgraph-dom-widget-clipping: event listeners -44 54 0.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: p95 frame time 17ms 0ms 0.2%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 4ms 1ms 14.7%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 10 1 9.2%
subgraph-idle: task duration 447ms 68ms 15.2%
subgraph-idle: script duration 9ms 2ms 19.3%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: heap used 63.0 MB 5.4 MB 8.6%
subgraph-idle: DOM nodes -128 86 0.0%
subgraph-idle: event listeners -99 69 0.0%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: p95 frame time 17ms 0ms 0.2%
subgraph-mouse-sweep: layout duration 6ms 1ms 9.9%
subgraph-mouse-sweep: style recalc duration 16ms 2ms 10.3%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 75 3 3.4%
subgraph-mouse-sweep: task duration 726ms 97ms 13.4%
subgraph-mouse-sweep: script duration 100ms 13ms 12.7%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: heap used 71.3 MB 3.6 MB 5.0%
subgraph-mouse-sweep: DOM nodes -103 75 0.0%
subgraph-mouse-sweep: event listeners -77 60 0.0%
subgraph-transition-enter: avg frame time 20ms 1ms 4.0%
subgraph-transition-enter: p95 frame time 22ms 8ms 36.3%
subgraph-transition-enter: layout duration 13ms 2ms 18.1%
subgraph-transition-enter: style recalc duration 27ms 4ms 14.4%
subgraph-transition-enter: layout count 6 0 0.0%
subgraph-transition-enter: style recalc count 19 1 4.0%
subgraph-transition-enter: task duration 837ms 140ms 16.7%
subgraph-transition-enter: script duration 28ms 4ms 14.6%
subgraph-transition-enter: TBT 115ms 28ms 23.9%
subgraph-transition-enter: heap used 106.9 MB 1.6 MB 1.5%
subgraph-transition-enter: DOM nodes 14650 0 0.0%
subgraph-transition-enter: event listeners 2456 0 0.0%
viewport-pan-sweep: avg frame time 17ms 0ms 0.1%
viewport-pan-sweep: p95 frame time 17ms 0ms 0.2%
viewport-pan-sweep: layout duration 0ms 0ms 0.0%
viewport-pan-sweep: style recalc duration 21ms 2ms 11.7%
viewport-pan-sweep: layout count 0 0 0.0%
viewport-pan-sweep: style recalc count 250 1 0.2%
viewport-pan-sweep: task duration 5271ms 687ms 13.0%
viewport-pan-sweep: script duration 2567ms 330ms 12.8%
viewport-pan-sweep: TBT 0ms 0ms 0.0%
viewport-pan-sweep: heap used 79.2 MB 5.0 MB 6.3%
viewport-pan-sweep: DOM nodes -172 101 0.0%
viewport-pan-sweep: event listeners -77 45 0.0%
vue-large-graph-idle: avg frame time 28ms 4ms 15.0%
vue-large-graph-idle: p95 frame time 53ms 11ms 21.1%
vue-large-graph-idle: layout duration 0ms 0ms 0.0%
vue-large-graph-idle: style recalc duration 0ms 0ms 0.0%
vue-large-graph-idle: layout count 0 0 0.0%
vue-large-graph-idle: style recalc count 0 0 0.0%
vue-large-graph-idle: task duration 15722ms 2350ms 14.9%
vue-large-graph-idle: script duration 253ms 46ms 18.1%
vue-large-graph-idle: TBT 0ms 1ms 267.7%
vue-large-graph-idle: heap used 177.0 MB 2.2 MB 1.2%
vue-large-graph-idle: DOM nodes -3046 0 0.0%
vue-large-graph-idle: event listeners -14915 1 0.0%
vue-large-graph-pan: avg frame time 37ms 7ms 18.8%
vue-large-graph-pan: p95 frame time 73ms 13ms 18.4%
vue-large-graph-pan: layout duration 0ms 0ms 0.0%
vue-large-graph-pan: style recalc duration 14ms 3ms 25.1%
vue-large-graph-pan: layout count 0 0 0.0%
vue-large-graph-pan: style recalc count 142 43 30.3%
vue-large-graph-pan: task duration 19556ms 3676ms 18.8%
vue-large-graph-pan: script duration 818ms 110ms 13.4%
vue-large-graph-pan: TBT 17ms 12ms 73.0%
vue-large-graph-pan: heap used 182.1 MB 1.3 MB 0.7%
vue-large-graph-pan: DOM nodes -3046 0 0.0%
vue-large-graph-pan: event listeners -14913 0 0.0%
vue-node-resize-workload: avg frame time 34ms 4ms 12.8%
vue-node-resize-workload: p95 frame time 66ms 11ms 17.1%
vue-node-resize-workload: layout duration 25ms 1ms 6.0%
vue-node-resize-workload: style recalc duration 68ms 11ms 15.5%
vue-node-resize-workload: layout count 20 0 0.0%
vue-node-resize-workload: style recalc count 20 0 0.0%
vue-node-resize-workload: task duration 5775ms 848ms 14.7%
vue-node-resize-workload: script duration 100ms 16ms 16.3%
vue-node-resize-workload: TBT 0ms 1ms 321.4%
vue-node-resize-workload: heap used 208.1 MB 2.3 MB 1.1%
vue-node-resize-workload: DOM nodes 0 0 0.0%
vue-node-resize-workload: event listeners 0 0 0.0%
vue-zoom-out-idle: avg frame time 28ms 4ms 14.8%
vue-zoom-out-idle: p95 frame time 55ms 12ms 20.9%
vue-zoom-out-idle: layout duration 0ms 0ms 0.0%
vue-zoom-out-idle: style recalc duration 0ms 0ms 0.0%
vue-zoom-out-idle: layout count 0 0 0.0%
vue-zoom-out-idle: style recalc count 0 0 0.0%
vue-zoom-out-idle: task duration 7925ms 1201ms 15.2%
vue-zoom-out-idle: script duration 132ms 19ms 14.5%
vue-zoom-out-idle: TBT 0ms 1ms 283.8%
vue-zoom-out-idle: heap used 176.0 MB 2.0 MB 1.2%
vue-zoom-out-idle: DOM nodes -3046 0 0.0%
vue-zoom-out-idle: event listeners -14915 0 0.0%
workflow-execution: avg frame time 17ms 1ms 4.0%
workflow-execution: p95 frame time 19ms 4ms 18.4%
workflow-execution: layout duration 2ms 1ms 38.5%
workflow-execution: style recalc duration 14ms 3ms 17.3%
workflow-execution: layout count 3 0 14.8%
workflow-execution: style recalc count 13 3 26.3%
workflow-execution: task duration 145ms 41ms 28.6%
workflow-execution: script duration 10ms 2ms 23.1%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: heap used 61.2 MB 3.7 MB 6.0%
workflow-execution: DOM nodes 32 57 176.6%
workflow-execution: event listeners -5 37 0.0%
agent-composer-empty-conversation-typing: avg frame time 17ms 0ms 1.2%
agent-composer-empty-conversation-typing: p95 frame time 17ms 2ms 11.1%
agent-composer-empty-conversation-typing: layout duration 27ms 4ms 14.5%
agent-composer-empty-conversation-typing: style recalc duration 92ms 11ms 12.4%
agent-composer-empty-conversation-typing: layout count 76 0 0.0%
agent-composer-empty-conversation-typing: style recalc count 78 1 0.7%
agent-composer-empty-conversation-typing: task duration 841ms 232ms 27.6%
agent-composer-empty-conversation-typing: script duration 336ms 108ms 32.0%
agent-composer-empty-conversation-typing: TBT 0ms 0ms 0.0%
agent-composer-empty-conversation-typing: heap used 85.2 MB 6.5 MB 7.6%
agent-composer-empty-conversation-typing: DOM nodes 76 1 0.7%
agent-composer-empty-conversation-typing: event listeners 876 0 0.0%
agent-composer-long-conversation-typing: avg frame time 18ms 1ms 5.4%
agent-composer-long-conversation-typing: p95 frame time 26ms 8ms 30.3%
agent-composer-long-conversation-typing: layout duration 29ms 4ms 13.7%
agent-composer-long-conversation-typing: style recalc duration 260ms 30ms 11.6%
agent-composer-long-conversation-typing: layout count 76 0 0.0%
agent-composer-long-conversation-typing: style recalc count 78 1 0.7%
agent-composer-long-conversation-typing: task duration 1311ms 223ms 17.0%
agent-composer-long-conversation-typing: script duration 428ms 104ms 24.2%
agent-composer-long-conversation-typing: TBT 0ms 0ms 0.0%
agent-composer-long-conversation-typing: heap used 118.1 MB 6.0 MB 5.1%
agent-composer-long-conversation-typing: DOM nodes 76 1 0.7%
agent-composer-long-conversation-typing: event listeners 876 0 0.0%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▄▂▁▄█▂█▆▃▇▃▂▂▄▂ ➡️ 17ms
canvas-idle: p95 frame time ▁▆▁▆▆▃▆▃▃█▆▆▃▆▃ ➡️ 17ms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▂▂▄▅▁▃▄▃█▄▆▇▂▂▂ 📈 4ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count ▅▅█▄▇▆▆▅▆▅▅▆▆▃▁ ➡️ 8
canvas-idle: task duration ▅▄▁▆▃▅▅▄▅▄█▅▂▅▆ ➡️ 529ms
canvas-idle: script duration ▄▃▁▅▄▄▃▆▄▄██▃▄▇ 📈 13ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ▃▅▁▃▁▁▂▆▁▄▂▂▂▄█ ➡️ 76.4 MB
canvas-idle: DOM nodes ▆█▁▆▁▁▃█▁▃▁▁▁▃█ 📈 0
canvas-idle: event listeners ▆█▁▆▁▁▃█▁▃▁▁▁▆█ 📈 0
canvas-mouse-sweep: avg frame time ▁▁▁▁▁▁▁██▁▁▁▁▁▁ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ▁▁██▄▄▄▁▄██▁█▄█ ➡️ 17ms
canvas-mouse-sweep: layout duration ▇▅▂▅▁▄▃▅▆▄▅▅▂▄█ ➡️ 5ms
canvas-mouse-sweep: style recalc duration █▆▂▅▁▃▃▆▆▄▆▇▂▆█ ➡️ 18ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count ▇▅▅▆▅▆▁▃▂▅▆▅▄▁█ ➡️ 79
canvas-mouse-sweep: task duration ▇▆▁▇▃▇▆▇▇▅▇▄▄▅█ ➡️ 922ms
canvas-mouse-sweep: script duration ▆▇▁▆▂▆▆▆▇▆▇▃▃▇█ 📈 172ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ▇▅▇▃▆█▄▇▄▆▇█▆▂▁ ➡️ 61.0 MB
canvas-mouse-sweep: DOM nodes ▁▃▃█▃▁▆▃▁▆▆▃▆▆▆ 📉 -71
canvas-mouse-sweep: event listeners ▁▃▃█▃▁▆▃▁▆▆▃▆▆▆ 📉 -49
canvas-zoom-sweep: avg frame time ▃▂█▄▄▆▃▅▅▄▅▃▁▇▅ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ▆█▃▁▆▃▆▆▆▆▃▆▆▁▁ ➡️ 17ms
canvas-zoom-sweep: layout duration ▃▂▂█▄▃▄▆▇▁▅▇▃▅▄ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▅▆▄▇▁▇▂▅▅▂█▇▄█▇ ➡️ 7ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 3
canvas-zoom-sweep: style recalc count ███▁█▅▁█▁▅█▁▁▅█ ➡️ 19
canvas-zoom-sweep: task duration ▆▅▁▇▃▄▄▇▇▅█▄▄▇▇ 📈 438ms
canvas-zoom-sweep: script duration ▅▄▁▆▂▁▂▆▃▅▇█▃▆▅ 📈 13ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used █▃▁▃▄▁▆▃▂▃▁▃▄▄▂ ➡️ 62.3 MB
canvas-zoom-sweep: DOM nodes █▆▁▃▃▃█▃▃▆▁▃▆▃▃ 📈 -96
canvas-zoom-sweep: event listeners █▆▁▃▃▃█▆▃▆▁▃▆▃▃ 📈 -60
dom-widget-clipping: avg frame time ▁▁▁▁▁▁▁▄▅▁█▁▁▁▁ ➡️ 17ms
dom-widget-clipping: p95 frame time ▃▃▆▆▃▆▆▃▁▁▆█▁▆▃ ➡️ 17ms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▂▄▃▄▂▁▃▅▂█▆▄▃▄▃ 📈 4ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▂▄█▂▇▄▃▁▁▄▁▆▅▄▂ ➡️ 14
dom-widget-clipping: task duration ▆▇▁▇▄▅▇█▇██▂▅▇█ ➡️ 508ms
dom-widget-clipping: script duration ▆▇▁▇▂▆▇▇█▇▇▂▄▇█ ➡️ 175ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ▄▄█▄▃▁▃▃▅▃▄▄▄▃▃ ➡️ 67.2 MB
dom-widget-clipping: DOM nodes ▆▃▆▁▁█▃▃▆▁▃▆▃▆▆ ➡️ -71
dom-widget-clipping: event listeners ▆▃▆▃▁█▃▃▆▁▃▆▃▆▆ ➡️ -49
dom-widget-order-dense-n200-w200-i120: avg frame time ▆▆▁▇▃▆▆▇▇▆█▁▃▇█ ➡️ 36ms
dom-widget-order-dense-n200-w200-i120: p95 frame time ▁██▁█▅▅▅▅▅██▅██ ➡️ 17ms
dom-widget-order-dense-n200-w200-i120: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-dense-n200-w200-i120: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: task duration ▆▆▁▆▃▆▆▇▇▇█▂▃▇█ ➡️ 909ms
dom-widget-order-dense-n200-w200-i120: script duration ▅▆▁▆▂▇▆▆█▇█▂▂▇█ 📈 73ms
dom-widget-order-dense-n200-w200-i120: TBT ▆▆▁▇▃▆▆▇▇▇█▁▃▇█ ➡️ 570ms
dom-widget-order-dense-n200-w200-i120: heap used ▅▄▂▆▁▇▃▂▂▅▅▂▂█▄ ➡️ 91.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time ▆█▁▆▂▇█▆█▇█▁▅██ ➡️ 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time ▁▁▁▁▁▁▁▁▁▁▁█▁▁▁ ➡️ 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: task duration ▆▆▁▆▂▆▆▆▇▆▇▂▄▆█ ➡️ 534ms
dom-widget-order-sparse-n1000-w20-i120: script duration ▅▆▁▅▂▆▆▅▇▆▇▂▃▇█ 📈 182ms
dom-widget-order-sparse-n1000-w20-i120: TBT ▅▇▁▆▂▇▇▆▇▇█▁▄▇█ 📈 236ms
dom-widget-order-sparse-n1000-w20-i120: heap used ▆▁▇▆▄▂▄█▃▂▄▁▄▆▂ ➡️ 78.9 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-clean-combined-draw: avg frame time ██▁▆▂██████▁▃██ ➡️ 32ms
extension-clean-combined-draw: p95 frame time ▅▅▁▅▁▅▇▇▇▅▇▁▁▅█ ➡️ 61ms
extension-clean-combined-draw: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
extension-clean-combined-draw: style recalc duration ▂▁█▃▂▁▁▁▁▁▂▆▆▁▃ 📈 0ms
extension-clean-combined-draw: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-clean-combined-draw: style recalc count ▂▁█▃▄▁▁▁▁▁▂▅▅▂▃ ➡️ 1
extension-clean-combined-draw: task duration ▅▆▁▆▂▆▇▆█▆▇▁▂▆█ ➡️ 9900ms
extension-clean-combined-draw: script duration ▅▇▁▅▁▆▇▆▇▆▇▁▃▆█ ➡️ 8225ms
extension-clean-combined-draw: TBT ▃▆▁▂▁▅▅▄▇▅▆▁▁▅█ 📈 1305ms
extension-clean-combined-draw: heap used ▇▄▅▃▃▂▃▇▃▆▇▁▇▂█ ➡️ 86.8 MB
extension-clean-combined-draw: DOM nodes ▆█▆▁██████▆▆▃▆▃ 📈 -94
extension-clean-combined-draw: event listeners ▆█▆▁██████▆▆▃▆▃ 📈 -45
extension-rgthree-prototype-draw: avg frame time ▆█▁▇▃██▆██▇▂▄██ ➡️ 32ms
extension-rgthree-prototype-draw: p95 frame time ▅▅▁▅▁▅▅▅▇▇▅▁▁▅█ ➡️ 61ms
extension-rgthree-prototype-draw: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
extension-rgthree-prototype-draw: style recalc duration ▂▄▅▂▂▃▁▂▃▂▁█▄▂▃ 📈 0ms
extension-rgthree-prototype-draw: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-rgthree-prototype-draw: style recalc count ▂▄▇▂▄▃▂▂▄▂▁█▅▂▃ ➡️ 1
extension-rgthree-prototype-draw: task duration ▆▇▁▆▂▆▆▆█▇▇▁▃▇█ ➡️ 9663ms
extension-rgthree-prototype-draw: script duration ▅▇▁▆▂▆▆▆█▇▇▁▃▇█ 📈 8057ms
extension-rgthree-prototype-draw: TBT ▂▅▁▃▁▅▅▂█▇▆▁▁▇█ 📈 1279ms
extension-rgthree-prototype-draw: heap used ▂█▂▆▄█▆▆▇█▁▄▃▇▇ ➡️ 81.2 MB
extension-rgthree-prototype-draw: DOM nodes ▆▄█▆█▃▆▆▁▆█▄▆▆▁ 📈 -141
extension-rgthree-prototype-draw: event listeners ▆▃█▆█▄▆▆▂▆█▄▆▆▁ 📈 -69
large-graph-idle: avg frame time █▁▁▁▁▁▁▁▁▁▁▁▁▁▁ ➡️ 17ms
large-graph-idle: p95 frame time ▁▁▆▆▁█▃▃▁▆▆▆▃▆▆ ➡️ 17ms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▃▅▁▃▃▅▆█▆▇▂▇▇ 📈 4ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count ▅▃▅▃▄▃▁▁▄▃▃█▂▅▁ ➡️ 8
large-graph-idle: task duration ▇▇▁▇▃▆▆█▆▇█▄▄▅█ ➡️ 615ms
large-graph-idle: script duration ▆▇▁▇▃▅▇▇▇▇█▆▅██ 📈 36ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ▁▄▄▂▆▆▆▂█▄▄▄▆▇▆ ➡️ 81.3 MB
large-graph-idle: DOM nodes ▃▁▁▄▁▁▁▄▄▄▄▆▄█▆ 📉 -103
large-graph-idle: event listeners ▄▁▁▄▁▁▁▃▃▃▃▆▃█▆ 📉 -49
large-graph-pan: avg frame time █▁▁▁▁▁▁█▃▁▃▁▁▁▅ ➡️ 17ms
large-graph-pan: p95 frame time ▃▆▆█▃▃▆██▁▆▃▁▃▃ ➡️ 17ms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▄▄▅▃▁▂▄▄▂▄█▄▅▅ 📈 8ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▃▅▃▆▇▁▃▅▂▂▆█▇█▆ ➡️ 68
large-graph-pan: task duration ▇▇▁█▂▅▆██▇█▄▄▇█ ➡️ 1683ms
large-graph-pan: script duration ▆▆▁▆▁▆▆▆▇▆▇▃▄▇█ ➡️ 909ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ▃▃▃▁▅▇▅█▄▆▂▃▄██ ➡️ 83.9 MB
large-graph-pan: DOM nodes ▆▁▆▃▃▆▃█▆▃██▆▆█ 📉 0
large-graph-pan: event listeners ▆▁█▃▃▆▆██▃██▆▆█ 📉 2
large-graph-zoom: avg frame time ▁▁▁▁▁▁▁▄▁▁▁▄█▁▁ ➡️ 17ms
large-graph-zoom: p95 frame time ▃▆▃▆▃▃▁▁█▁▆█▃▁▁ ➡️ 17ms
large-graph-zoom: layout duration ▃▃▅▃▄▂▁▄▆▄▅█▃▃▇ ➡️ 18ms
large-graph-zoom: style recalc duration ▂▃▇▃▄▂▁▅▅▆▅█▅▄▆ 📈 9ms
large-graph-zoom: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 60
large-graph-zoom: style recalc count ▁▂█▂▅▄▁▃▃▅▃▅▄▄▃ ➡️ 70
large-graph-zoom: task duration ▇▆▁▆▂▆▄▆▇▇▇▃▄▇█ ➡️ 1832ms
large-graph-zoom: script duration ▆▆▁▆▃▆▆▇█▇▇▂▄▇█ ➡️ 841ms
large-graph-zoom: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-zoom: heap used ▁▅▅▂▅█▁▅▂▆▄▃█▅▁ ➡️ 72.7 MB
large-graph-zoom: DOM nodes ▁███████▁██████ ➡️ 24
large-graph-zoom: event listeners ████████▁██████ ➡️ 0
legacy-node-drag: avg frame time ▄█▁▅▄█▇▅▅▅▄▁▅▅▅ ➡️ 17ms
legacy-node-drag: p95 frame time ▁█▃▆▆▆▃▆▁▃▁▆▃▆█ ➡️ 17ms
legacy-node-drag: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: style recalc duration ▂▂▄▁▂▂▁▃▄▄▄█▄▄▄ 📈 6ms
legacy-node-drag: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: style recalc count ▃▄█▁▃▃▃▃▃▅▅▇▆▅▄ ➡️ 43
legacy-node-drag: task duration ▇▆▁▇▂▆▆█▆▆▇▃▄▇█ ➡️ 1999ms
legacy-node-drag: script duration ▇▇▁▇▁▇▇▇██▇▃▄▇█ ➡️ 1014ms
legacy-node-drag: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: heap used ▄▅▁▇▃███▆▆▃▇▇▄▆ ➡️ 80.2 MB
legacy-node-drag: DOM nodes ███▁███▁███████ 📉 0
legacy-node-drag: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 182
minimap-idle: avg frame time ▁▁▁▁▁▁▁▁█▁▁▁▁▁▁ ➡️ 17ms
minimap-idle: p95 frame time █▁█▄▄▁▁▁█▄██▄▄▄ ➡️ 17ms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▅█▄▇▃▂▃▆▄▆█▄▁▁▆ ➡️ 3ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▅██▇▆▅▆▆▅▆▇▅▃▁▅ 📉 6
minimap-idle: task duration ▇▅▁█▃▄▅▅▇▅█▄▄▆█ 📈 609ms
minimap-idle: script duration ▅▅▁▇▄▃▄▆▆▅▆▃▄▆█ ➡️ 38ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ▅▁▅▄██▅▃▄▇█▇▇▇▇ ➡️ 83.9 MB
minimap-idle: DOM nodes ▁█▁▁▅█▅▅▅█▅██▅▅ 📉 -205
minimap-idle: event listeners ▃▆▁▁▃▆▆▃▃▆▃▆██▆ 📉 -49
subgraph-dom-widget-clipping: avg frame time ▇▁▄▇▆▆▆▄▇█▃▇▄▆█ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ▁▃▃▁▃▆▆▆█▃█▃▁▁▃ ➡️ 17ms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▆▆▅▆▁▄▆▇▅▄▇█▇▇█ ➡️ 6ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▄▄▄▄▅▁▅▂▁▃▃▄█▄▅ ➡️ 47
subgraph-dom-widget-clipping: task duration ▇▆▁▇▂▆▆██▆█▂▅▇▇ ➡️ 439ms
subgraph-dom-widget-clipping: script duration ▇█▁▇▁▇▇▇█▇█▂▄▇█ ➡️ 151ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ▄▄▁█▆▃▄▂▂▄▅▆▂▂▃ ➡️ 66.5 MB
subgraph-dom-widget-clipping: DOM nodes ▆█▁▅▆▆▆▃▂▆▃▃▁▁▆ 📈 -77
subgraph-dom-widget-clipping: event listeners ▆█▁▆▆▆▆▃▃▆▆▆▁▃▆ 📈 -19
subgraph-idle: avg frame time ▄▃▅▆▃▅█▄▄▅▃▇▂▂▁ ➡️ 17ms
subgraph-idle: p95 frame time ▃▆▆▁▃█▁▃▃▃▁▃▆▃▁ ➡️ 17ms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▅█▃▇▂▁▆▄▄▅▇▇▃▅▇ ➡️ 4ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▅▆▇▃█▃▇▁▃▃▃█▅▅▃ ➡️ 10
subgraph-idle: task duration ▅▆▁█▃▄██▇██▅▅▇█ 📈 507ms
subgraph-idle: script duration ▅▃▁▆▃▂▄▇▄▆██▅▆▆ 📈 10ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used █▁▁▂▄▅▁▂▇▄▇▁▆▆▆ ➡️ 67.0 MB
subgraph-idle: DOM nodes █▁▁▁▃▆▁▃▆▃█▃▃▆█ 📉 0
subgraph-idle: event listeners █▁▁▃▃▆▁▆▆▃█▃▃▆█ 📉 0
subgraph-mouse-sweep: avg frame time ▂▄▄▅▅▁▃█▃▂▃▂▃▅▂ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time █▅▁█▁▁▅█▄▅▁▅▁▄█ ➡️ 17ms
subgraph-mouse-sweep: layout duration ▄▄▅▅▁▅▅▆▆▆▅▆▄▅█ 📈 7ms
subgraph-mouse-sweep: style recalc duration ▅▅▄▆▁▃▅▆▇▅▇█▄▆█ 📈 18ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count █▂▆▂▇▁█▁▂▆▇▇▆▆▆ ➡️ 76
subgraph-mouse-sweep: task duration ▆▆▁▇▂▄▆█▆▆█▄▄▆█ ➡️ 822ms
subgraph-mouse-sweep: script duration ▅▆▂▅▁▅▅▆▆▆▇▆▄▆█ 📈 120ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ▄▁▃▇█▅▇▅▇▆▂▇▅▄█ ➡️ 75.4 MB
subgraph-mouse-sweep: DOM nodes ▃▆▆▁▁█▃▆▃▆▆▃▆██ 📉 0
subgraph-mouse-sweep: event listeners ▃▆▆▁▃█▃▆▃█▆▃▆██ 📉 0
subgraph-transition-enter: avg frame time ▂▃▁▂▅▂▂█▂█▃▂▄▇▃ ➡️ 20ms
subgraph-transition-enter: p95 frame time ▁█▁▁▁▁▁█▁█▁█▁█▁ 📈 17ms
subgraph-transition-enter: layout duration ▅▇▂▄▂▆▆▅▇▆▇▁▃▇█ ➡️ 16ms
subgraph-transition-enter: style recalc duration ▄▇▁▄▂▆▆▅█▆▇▁▃██ ➡️ 31ms
subgraph-transition-enter: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
subgraph-transition-enter: style recalc count ▃▃█▃▃▃▃▁▆▃▁▃▁▃▃ ➡️ 19
subgraph-transition-enter: task duration ▆█▁▆▂▆▆▃▇▂█▂▃▃█ ➡️ 1003ms
subgraph-transition-enter: script duration ▆█▂▇▁▅▆▆▇▄▇▁▁▃█ ➡️ 33ms
subgraph-transition-enter: TBT ▆█▁▆▅▇▇▆▇▇█▁▃██ ➡️ 139ms
subgraph-transition-enter: heap used ▇▇▂▃▄▁▃▇▃█▇▅▇▆▇ ➡️ 108.4 MB
subgraph-transition-enter: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 14650
subgraph-transition-enter: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 2456
viewport-pan-sweep: avg frame time ▆▁▁▅▁▁▃▅█▃▁▁▁▃▃ ➡️ 17ms
viewport-pan-sweep: p95 frame time ▆▆█▃█▁▆▆▃▃▆▆▃▁▆ ➡️ 17ms
viewport-pan-sweep: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: style recalc duration ▃▃▆▃▃▁▂▃▄▃▄█▄▃▅ 📈 22ms
viewport-pan-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
viewport-pan-sweep: style recalc count ▆▇▇▁▇█▇▆▆▂▆▆▇▆█ ➡️ 251
viewport-pan-sweep: task duration ▇▇▁█▃▆▇██▇▇▄▄▆█ ➡️ 5781ms
viewport-pan-sweep: script duration ▇▇▁▇▂█▇▇█▇█▃▄▇█ ➡️ 2842ms
viewport-pan-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: heap used ▃▅▄▁▇▆▆▅▄▇▇▂▂▄█ ➡️ 86.8 MB
viewport-pan-sweep: DOM nodes ▃▃▁▁▁▃█▃▃▆▃▆█▆▆ 📉 -103
viewport-pan-sweep: event listeners ▃▃▁▃▁▃█▃▃▆▃▆█▆▆ 📉 -47
vue-large-graph-idle: avg frame time ▆▇▁▆▁▅▇▆█▇▆▂▅▄█ ➡️ 33ms
vue-large-graph-idle: p95 frame time ▅█▂▅▁▅█▅██▆▂▄▄█ 📈 67ms
vue-large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: task duration ▅▇▁▅▁▅▇▅█▇▆▂▄▄█ ➡️ 18554ms
vue-large-graph-idle: script duration ▅▆▁▅▁▄▆▆█▆▅▂▄▅█ 📈 325ms
vue-large-graph-idle: TBT ▁▁▁▁▁▁▁█▁▁▁▁▁▁▆ 📈 3ms
vue-large-graph-idle: heap used ▄▄▄█▄▄█▄▄▇▆▁▅▆▄ ➡️ 175.8 MB
vue-large-graph-idle: DOM nodes ███▁███████████ ➡️ -3046
vue-large-graph-idle: event listeners ▁▂▁▁▁▁█▁▁▁▁▁▁▁▁ ➡️ -14915
vue-large-graph-pan: avg frame time ▄▇▂▅▁▇▇▅█▆█▃▃▇▇ 📈 41ms
vue-large-graph-pan: p95 frame time ▃▇▁▅▁▇▇▆█▆▇▂▃▇▆ ➡️ 78ms
vue-large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-pan: style recalc duration ▃▆▁▄▁▅▅▅▇▅█▃▂▅▇ 📈 18ms
vue-large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-pan: style recalc count ▄█▁▆▁██▆█▆█▂▄█▇ 📈 169
vue-large-graph-pan: task duration ▄▇▂▅▁▆▇▅█▆▇▃▃▇▆ 📈 21559ms
vue-large-graph-pan: script duration ▆▇▁▆▃▆▆▇█▇█▂▃▆█ ➡️ 932ms
vue-large-graph-pan: TBT ▇▃▁▃▁▂▅▅█▃▄▅▂▅█ 📈 38ms
vue-large-graph-pan: heap used ▂▁▃▁▆▂▂▂▃▃▂▅▃█▂ ➡️ 181.7 MB
vue-large-graph-pan: DOM nodes ███▁██▄███▄▄▄██ ➡️ -3046
vue-large-graph-pan: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ -14913
vue-node-resize-workload: avg frame time ▄▅▂▅▁▆▆▆█▇▆▃▅▅█ 📈 40ms
vue-node-resize-workload: p95 frame time ▄▅▂▅▁▅▅▅█▆▇▂▅▅█ 📈 83ms
vue-node-resize-workload: layout duration ▆▄▂▇▄▁▃▆▇▆▇▆▃▃█ ➡️ 27ms
vue-node-resize-workload: style recalc duration ▅▇▁▆▁▆▆▆█▇▇▁▃▇█ ➡️ 79ms
vue-node-resize-workload: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: task duration ▄▅▂▅▁▆▇▆█▇▆▃▅▆█ 📈 6833ms
vue-node-resize-workload: script duration ▄▅▁▅▁▅▆▅█▆▆▂▄▅▇ 📈 123ms
vue-node-resize-workload: TBT ▁█▁▁▃▁▁▁▁▁▁▁▁▁▁ 📉 0ms
vue-node-resize-workload: heap used ▆▄▁█▇▃▇▅▅▅▃▅▁▅▆ ➡️ 210.1 MB
vue-node-resize-workload: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-node-resize-workload: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: avg frame time ▄▇▂▆▁▆▇▆█▇▆▂▄▄█ ➡️ 34ms
vue-zoom-out-idle: p95 frame time ▃▇▃▄▁▆▇▅█▇▆▃▃▄▇ 📈 67ms
vue-zoom-out-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: task duration ▄▇▂▅▁▆▇▆██▆▂▄▄█ ➡️ 9445ms
vue-zoom-out-idle: script duration ▃▆▄▅▁▄▆▇▇▆▆▂▅▄█ 📈 162ms
vue-zoom-out-idle: TBT ▁▁▁▁▁▁▁▄▁▁▁▁█▁▁ 📈 0ms
vue-zoom-out-idle: heap used ▆▇▃▅▅▇▅▆▅█▇▇▁▇▆ ➡️ 176.0 MB
vue-zoom-out-idle: DOM nodes ▁▁▃▃█▃▃▃▃▃▃▃▃▃▃ ➡️ -3046
vue-zoom-out-idle: event listeners ▁▁▁▁▁▁▁▁▁▁▁▁▁▁█ ➡️ -14915
workflow-execution: avg frame time ▂█▁▁▃▁▃▂▆▂▄▁▁▂▄ ➡️ 18ms
workflow-execution: p95 frame time ▁█▁▁▅▁▅▁▅▁▅▁▁▁▄ ➡️ 22ms
workflow-execution: layout duration ▆▃▁▄▁▃▂▃▄█▂▁▂▂▃ ➡️ 2ms
workflow-execution: style recalc duration █▅▁▇▂▆▄▄▆▅▅▄▃▅▅ ➡️ 15ms
workflow-execution: layout count █▅▁▅▁█▆▅██▃▁▃▅▅ ➡️ 3
workflow-execution: style recalc count ▇▄▁█▃█▆▃▅▆▄▄▃▇▄ ➡️ 12
workflow-execution: task duration █▇▁▆▃▇▇▅▇▅▇▄▃▇▃ ➡️ 107ms
workflow-execution: script duration ▇▆▁▇▂█▇▆▇▆▇▃▁▇▅ ➡️ 9ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ▄▁▆▄█▄▂▅▄▅▇▇▅▃▅ ➡️ 61.9 MB
workflow-execution: DOM nodes ▃▁█▅█▂▂▅▃▅▅▅█▅▅ 📈 40
workflow-execution: event listeners ▅▁▇▇▅▅▅▅▄▆▆▆▇▆█ 📉 49
agent-composer-empty-conversation-typing: avg frame time ▁▂▁█▁▁▁▂▅▂▁▁▁▁▇ ➡️ 17ms
agent-composer-empty-conversation-typing: p95 frame time ▁▁▁█▁▁▁▁▁▁▁▁▁▁█ ➡️ 22ms
agent-composer-empty-conversation-typing: layout duration ▇▅▅█▁▄▅▆▇▆▆▇▃▅▇ ➡️ 31ms
agent-composer-empty-conversation-typing: style recalc duration ▆▅▄▇▁▅▅▆█▇▆▅▂▅▇ ➡️ 103ms
agent-composer-empty-conversation-typing: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 76
agent-composer-empty-conversation-typing: style recalc count ████████▁▁▁▁▁▁▁ ➡️ 77
agent-composer-empty-conversation-typing: task duration ▇▅▂█▁▅▅▇█▆▆▂▂▅▇ ➡️ 1049ms
agent-composer-empty-conversation-typing: script duration ▇▆▁█▁▅▅▇█▇▆▂▂▆▇ ➡️ 429ms
agent-composer-empty-conversation-typing: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
agent-composer-empty-conversation-typing: heap used ▆▆▂█▁▇▇▄▂█▇▅▄▇█ ➡️ 92.1 MB
agent-composer-empty-conversation-typing: DOM nodes ▁▁▁▁▁▁▁▁███████ ➡️ 77
agent-composer-empty-conversation-typing: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 876
agent-composer-long-conversation-typing: avg frame time ▆▄▁▇▁▂▂▅█▄▄▁▁▅▇ ➡️ 19ms
agent-composer-long-conversation-typing: p95 frame time █▆▁█▁▁▁██▆▆▁▁██ 📈 33ms
agent-composer-long-conversation-typing: layout duration ▇▆▇▇▁▅▅▆█▆▆▇▄▆█ ➡️ 33ms
agent-composer-long-conversation-typing: style recalc duration ▆▅█▇▁▅▄▆▇▅▆▇▄▆▇ ➡️ 280ms
agent-composer-long-conversation-typing: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 76
agent-composer-long-conversation-typing: style recalc count ████████▁▁▁▁▁▁▁ ➡️ 77
agent-composer-long-conversation-typing: task duration ▇▇▄█▁▆▆▇█▇▇▄▄▇█ ➡️ 1514ms
agent-composer-long-conversation-typing: script duration ▇▇▃█▁▇▇▇███▂▄██ ➡️ 513ms
agent-composer-long-conversation-typing: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
agent-composer-long-conversation-typing: heap used ▄█▃▁▃▃▄▂▄▄▂▁▂▄▅ ➡️ 122.8 MB
agent-composer-long-conversation-typing: DOM nodes ▁▁▁▁▁▁▁▁███████ ➡️ 77
agent-composer-long-conversation-typing: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 876
Raw data
{
  "timestamp": "2026-10-08T07:50:03.906Z",
  "gitSha": "ec654bf9fa2181cc001738b5d035a8bab88d3434",
  "branch": "drjkl/litegraph-interfaces-split",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2023.1660000000034,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.7619999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.1410000000001,
      "heapDeltaBytes": -50102236,
      "heapUsedBytes": 60480412,
      "domNodes": -212,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 9.161000000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2043.1310000000167,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.8210000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.47499999999997,
      "heapDeltaBytes": -49204128,
      "heapUsedBytes": 61510064,
      "domNodes": -212,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 8.987,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1694.7999999999865,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 12.455,
      "layouts": 12,
      "layoutDurationMs": 3.272,
      "taskDurationMs": 564.95,
      "heapDeltaBytes": 7602876,
      "heapUsedBytes": 78021608,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 113.703,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665686274509806,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1695.7599999999502,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 12.032,
      "layouts": 12,
      "layoutDurationMs": 3.768,
      "taskDurationMs": 672.4010000000001,
      "heapDeltaBytes": 3454480,
      "heapUsedBytes": 66146804,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 116.86700000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1728.1189999999924,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.173000000000001,
      "layouts": 3,
      "layoutDurationMs": 0.949,
      "taskDurationMs": 231.566,
      "heapDeltaBytes": 9151472,
      "heapUsedBytes": 73422312,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.467999999999998,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.9519999999402,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.769,
      "layouts": 3,
      "layoutDurationMs": 1.0170000000000001,
      "taskDurationMs": 377.877,
      "heapDeltaBytes": -49245816,
      "heapUsedBytes": 61662356,
      "domNodes": -167,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 10.299,
      "eventListeners": -109,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846145,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 544.3919999999594,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 3.9060000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 340.95699999999994,
      "heapDeltaBytes": 2009400,
      "heapUsedBytes": 111817928,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 132.556,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662499999999994,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 538.4290000000647,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 1.9540000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.75600000000003,
      "heapDeltaBytes": 19190028,
      "heapUsedBytes": 76045916,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 127.586,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1078.6359999999604,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 717.6039999999999,
      "heapDeltaBytes": 14557356,
      "heapUsedBytes": 94653172,
      "domNodes": 0,
      "jsHeapTotalBytes": 4096000,
      "scriptDurationMs": 51.775,
      "eventListeners": 0,
      "totalBlockingTimeMs": 450,
      "frameDurationMs": 31.858823529411787,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1058.2709999999906,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 662.073,
      "heapDeltaBytes": 18161296,
      "heapUsedBytes": 103908524,
      "domNodes": 0,
      "jsHeapTotalBytes": 1474560,
      "scriptDurationMs": 49.139,
      "eventListeners": 0,
      "totalBlockingTimeMs": 424,
      "frameDurationMs": 31.818181818181817,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 763.9320000000112,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 354.91800000000006,
      "heapDeltaBytes": -7666728,
      "heapUsedBytes": 81825168,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 119.86100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 142,
      "frameDurationMs": 22.549999999999994,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 743.7979999999698,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.18200000000024,
      "heapDeltaBytes": -8339168,
      "heapUsedBytes": 80939480,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 102.53699999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 22.058823529411764,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7707.367000000033,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.8390000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6839.610000000001,
      "heapDeltaBytes": 2395868,
      "heapUsedBytes": 92771900,
      "domNodes": -143,
      "jsHeapTotalBytes": -659456,
      "scriptDurationMs": 5647.183999999999,
      "eventListeners": -77,
      "totalBlockingTimeMs": 239,
      "frameDurationMs": 27.40142348754448,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6495.033999999919,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.9099999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5797.384,
      "heapDeltaBytes": 12410348,
      "heapUsedBytes": 87152308,
      "domNodes": -141,
      "jsHeapTotalBytes": -10883072,
      "scriptDurationMs": 4716.956999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 49,
      "frameDurationMs": 25.128682170542636,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6789.577000000008,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.1960000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6051.987999999999,
      "heapDeltaBytes": 9927924,
      "heapUsedBytes": 84033124,
      "domNodes": -141,
      "jsHeapTotalBytes": -11145216,
      "scriptDurationMs": 4704.446,
      "eventListeners": -69,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 25.215613382899633,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6674.472000000037,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.18400000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5918.6269999999995,
      "heapDeltaBytes": 11884240,
      "heapUsedBytes": 95576428,
      "domNodes": 0,
      "jsHeapTotalBytes": -21495808,
      "scriptDurationMs": 4579.358,
      "eventListeners": 0,
      "totalBlockingTimeMs": 41,
      "frameDurationMs": 24.69074074074074,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2030.326999999943,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.6539999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.098,
      "heapDeltaBytes": -18815712,
      "heapUsedBytes": 87478032,
      "domNodes": -308,
      "jsHeapTotalBytes": -5378048,
      "scriptDurationMs": 27.283999999999995,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.7689999999156,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.581,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 457.894,
      "heapDeltaBytes": 884736,
      "heapUsedBytes": 84606036,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 30.126999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2114.4039999999222,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 5.92,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1163.221,
      "heapDeltaBytes": -397700,
      "heapUsedBytes": 83542500,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 639.4040000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666141732283467,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2115.605999999957,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 3.7890000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1276.683,
      "heapDeltaBytes": 22843000,
      "heapUsedBytes": 89067612,
      "domNodes": 0,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 618.424,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665354330708663,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3193.61600000002,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 5.925,
      "layouts": 60,
      "layoutDurationMs": 13.700000000000001,
      "taskDurationMs": 1336.946,
      "heapDeltaBytes": 10178872,
      "heapUsedBytes": 76706848,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 589.4820000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665968586387432,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3205.8529999999337,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 7.401000000000002,
      "layouts": 60,
      "layoutDurationMs": 15.714000000000002,
      "taskDurationMs": 1379.1890000000003,
      "heapDeltaBytes": -15308544,
      "heapUsedBytes": 71000700,
      "domNodes": 24,
      "jsHeapTotalBytes": 299008,
      "scriptDurationMs": 611.93,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2222.065999999927,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 3.842000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1470.8279999999997,
      "heapDeltaBytes": 19781136,
      "heapUsedBytes": 87232500,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 714.744,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.791666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2166.6230000000724,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 3.1849999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1398.9769999999999,
      "heapDeltaBytes": 9279812,
      "heapUsedBytes": 75893784,
      "domNodes": -308,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 668.825,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.794573643410853,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.6039999999775,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.3640000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.949,
      "heapDeltaBytes": 23410560,
      "heapUsedBytes": 89126628,
      "domNodes": -308,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.074000000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.7020000000284,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.8859999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.949,
      "heapDeltaBytes": 23480420,
      "heapUsedBytes": 88804392,
      "domNodes": -308,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.900000000000002,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 494.78099999998904,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 3.865,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.31399999999996,
      "heapDeltaBytes": -8095968,
      "heapUsedBytes": 64632864,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 107.096,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 529.0219999999408,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.496,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 342.888,
      "heapDeltaBytes": -8022540,
      "heapUsedBytes": 65227576,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 114.801,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.7269999999944,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.458,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 321.218,
      "heapDeltaBytes": -48904384,
      "heapUsedBytes": 63780084,
      "domNodes": -230,
      "jsHeapTotalBytes": -3670016,
      "scriptDurationMs": 7.920000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.5019999999977,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.3129999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.791,
      "heapDeltaBytes": 9448196,
      "heapUsedBytes": 76145588,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.324000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1733.9489999999387,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 13.681,
      "layouts": 16,
      "layoutDurationMs": 5.322,
      "taskDurationMs": 700.011,
      "heapDeltaBytes": -12184544,
      "heapUsedBytes": 80086180,
      "domNodes": -230,
      "jsHeapTotalBytes": -5242880,
      "scriptDurationMs": 81.919,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.7570000000287,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 13.688,
      "layouts": 16,
      "layoutDurationMs": 5.098,
      "taskDurationMs": 638.2280000000001,
      "heapDeltaBytes": -240336,
      "heapUsedBytes": 63164148,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 79.232,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 916.217999999958,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 24.081,
      "layouts": 6,
      "layoutDurationMs": 10.391999999999998,
      "taskDurationMs": 752.977,
      "heapDeltaBytes": 33933892,
      "heapUsedBytes": 114192336,
      "domNodes": 14650,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 25.862999999999996,
      "eventListeners": 2456,
      "totalBlockingTimeMs": 115,
      "frameDurationMs": 20.829545454545453,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8201.748999999949,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 13.494000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4404.347,
      "heapDeltaBytes": -12940196,
      "heapUsedBytes": 93534832,
      "domNodes": -308,
      "jsHeapTotalBytes": -2301952,
      "scriptDurationMs": 1997.553,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666056910569107,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8145.528000000013,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 13.924000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4553.528,
      "heapDeltaBytes": 7767848,
      "heapUsedBytes": 88156200,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 2093.347,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665848670756645,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12988.471000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12156.696,
      "heapDeltaBytes": -45943356,
      "heapUsedBytes": 185992916,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7884800,
      "scriptDurationMs": 179.702,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.71036789297659,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13328.836000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12510.395,
      "heapDeltaBytes": -45952556,
      "heapUsedBytes": 183083920,
      "domNodes": -3046,
      "jsHeapTotalBytes": 1855488,
      "scriptDurationMs": 194.40400000000002,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.34261744966443,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15647.557000000006,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 8.154999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15182.185999999998,
      "heapDeltaBytes": -29480332,
      "heapUsedBytes": 190799528,
      "domNodes": -3046,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 735.665,
      "eventListeners": -14913,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.79626998223801,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16291.780000000017,
      "styleRecalcs": 110,
      "styleRecalcDurationMs": 9.941000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15748.944000000001,
      "heapDeltaBytes": -41341156,
      "heapUsedBytes": 188932732,
      "domNodes": -3046,
      "jsHeapTotalBytes": 8728576,
      "scriptDurationMs": 734.65,
      "eventListeners": -14913,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.674868189806674,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4851.49899999999,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 56.005,
      "layouts": 20,
      "layoutDurationMs": 22.58099999999999,
      "taskDurationMs": 4696.292,
      "heapDeltaBytes": 1230848,
      "heapUsedBytes": 221218612,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 83.91100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 26.647802197802207,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4908.731999999986,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.15199999999998,
      "layouts": 20,
      "layoutDurationMs": 23.022000000000002,
      "taskDurationMs": 4742.811000000001,
      "heapDeltaBytes": 1269572,
      "heapUsedBytes": 219777556,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 82.16,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.978048780487814,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6890.848000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6456.210999999999,
      "heapDeltaBytes": -40737492,
      "heapUsedBytes": 186084504,
      "domNodes": -3046,
      "jsHeapTotalBytes": 1417216,
      "scriptDurationMs": 111.35000000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.38915254237288,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6497.281999999927,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6163.432000000002,
      "heapDeltaBytes": -30383324,
      "heapUsedBytes": 185653788,
      "domNodes": -3046,
      "jsHeapTotalBytes": 8773632,
      "scriptDurationMs": 99.83400000000003,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.665666666666663,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.3969999999581,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 19.724,
      "layouts": 5,
      "layoutDurationMs": 2.575999999999999,
      "taskDurationMs": 140.35000000000002,
      "heapDeltaBytes": 6739512,
      "heapUsedBytes": 67254940,
      "domNodes": 138,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 13.746,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.3289999999406,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.856999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.7619999999999999,
      "taskDurationMs": 86.59400000000001,
      "heapDeltaBytes": 4168772,
      "heapUsedBytes": 111575328,
      "domNodes": 98,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 5.104000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.650000000000016,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 468.77900000004047,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 67.048,
      "layouts": 76,
      "layoutDurationMs": 16.762,
      "taskDurationMs": 425.932,
      "heapDeltaBytes": 14082220,
      "heapUsedBytes": 84004224,
      "domNodes": 77,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 158.23999999999998,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664285714285693,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 511.3560000000916,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 71.816,
      "layouts": 76,
      "layoutDurationMs": 18.118,
      "taskDurationMs": 477.343,
      "heapDeltaBytes": 14521344,
      "heapUsedBytes": 86893112,
      "domNodes": 77,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 173.38400000000001,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483896,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 879.3709999999919,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 197.584,
      "layouts": 76,
      "layoutDurationMs": 18.270000000000003,
      "taskDurationMs": 854.029,
      "heapDeltaBytes": 6973212,
      "heapUsedBytes": 120157548,
      "domNodes": 77,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 247.458,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.9811320754717,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 803.9750000000367,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 184.975,
      "layouts": 76,
      "layoutDurationMs": 17.358999999999998,
      "taskDurationMs": 776.663,
      "heapDeltaBytes": -16167952,
      "heapUsedBytes": 114545484,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 219.89399999999998,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665306122448968,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 54739 84610 64.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.6% 1172
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.6% 377
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/stores/teamWorkspaceStore.ts 37.6% 280
src/LGraph.ts 78.9% 274
src/scripts/app.ts 73.0% 255
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19088      +/-   ##
==========================================
+ Coverage   85.82%   86.65%   +0.82%     
==========================================
  Files        3586     2531    -1055     
  Lines      171877   143637   -28240     
  Branches    47151    39121    -8030     
==========================================
- Hits       147521   124472   -23049     
+ Misses      22341    18779    -3562     
+ Partials     2015      386    -1629     
Flag Coverage Δ
billing-web-unit ?
e2e 64.69% <ø> (-0.03%) ⬇️
unit 84.35% <ø> (-0.01%) ⬇️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/rightSidePanel/subgraph/SubgraphEditor.vue 86.60% <ø> (ø)
src/composables/graph/contextMenuConverter.ts 63.50% <ø> (ø)
src/composables/node/useNodePricing.ts 92.30% <ø> (ø)
src/core/graph/nodeShell/nodeShellState.ts 100.00% <ø> (ø)
...rc/core/graph/subgraph/adoptPromotedWidgetValue.ts 100.00% <ø> (ø)
...e/graph/subgraph/migration/proxyWidgetMigration.ts 91.66% <ø> (ø)
src/core/graph/subgraph/promotedInputWidget.ts 87.23% <ø> (ø)
...core/graph/subgraph/resolvePromotedWidgetSource.ts 85.00% <ø> (ø)
...rc/core/graph/subgraph/resolveSubgraphInputLink.ts 100.00% <ø> (ø)
src/core/graph/widgets/dynamicWidgets.ts 95.07% <ø> (ø)
... and 59 more

... and 1062 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 27, 2026
This was referenced Sep 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 8, 2026
ampagent and others added 2 commits October 8, 2026 07:34
interfaces.ts now imports only branded IDs and enums, so Rectangle, measure,
ConstrainedSize, LGraphBadge, LGraphButton, SlotBase and 15 app modules
(linkStore, rerouteStore, ...) leave the import-cycle SCC (923 -> 905).

Graph-bound contracts move to types/slots.ts, types/linkNetwork.ts,
types/contextMenu.ts, types/panel.ts; CreateNodeOptions to LiteGraphGlobal,
NewNodePosition/IBoundaryNodes to utils/arrange, Hoverable to types/events.
The litegraph barrel exports are unchanged.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
@DrJKL
DrJKL force-pushed the drjkl/litegraph-interfaces-split branch from 84bb457 to 8d57382 Compare October 8, 2026 07:37
@DrJKL DrJKL assigned christian-byrne and unassigned DrJKL Oct 8, 2026
@DrJKL
DrJKL requested a review from christian-byrne October 8, 2026 09:35
@DrJKL
DrJKL enabled auto-merge October 8, 2026 09:35

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface relocation preserves the LiteGraph type contracts and public barrel exports. I verified the current head, the type-only migration, and the required checks.

@DrJKL
DrJKL added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit 1013267 Oct 8, 2026
128 checks passed
@DrJKL
DrJKL deleted the drjkl/litegraph-interfaces-split branch October 8, 2026 12:31
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…sion (Comfy-Org#19109)

## Summary

Cuts `services/litegraphService.ts ->
composables/maskeditor/useMaskEditor.ts`, the edge that pulled the mask
editor composables and components into the services import cycle. Import
cycles in the original stack, on top of Comfy-Org#19108: 496 -> 484 cyclic
modules, largest SCC 284 -> 272; frees 12 modules
(`composables/maskeditor/*`, `components/maskeditor/*`). Alone on
current `main` the counts do not change (1027 cyclic modules, largest
SCC 983, 4562 cyclic edges).

Targets `main` directly; in the original stack it sat on Comfy-Org#19108. Tracks
FE-2769 / FE-3037.

## Changes

- `Comfy.MaskEditor` extension contributes the "Open in MaskEditor |
Image Canvas" node menu item from `beforeRegisterNodeDef`, wrapping
`nodeType.prototype.getExtraMenuOptions` (calls the existing handler,
keeps its return value, then pushes the item), with the same
`clipspace_return_node` and `isImageNode` guards and the same
`'preview'` media-action marking.
- `litegraphService.ts` drops the item and the `useMaskEditor` import.
- `maskeditor.test.ts` covers the guards, the callback target, the
preview marking, and chaining with an existing `getExtraMenuOptions`
handler.

## Review Focus

- Extension contract: the item stays in the `options` array that
`getExtraMenuOptions` fills, so custom nodes that wrap
`getExtraMenuOptions` and look the item up by label
(ComfyUI-prompt-formula, ComfyUI-PreviewBridgeExtended) keep working.
Core extensions register before custom ones, so `litegraphService`
installs the prototype handler, this wrapper runs next, and later
wrappers see the item. Menu position is unchanged in both the litegraph
and the Vue menu.
- Blueprint subgraph node classes (`litegraphService` creates them
without calling `beforeRegisterNodeDef`) do not get the item. Before,
they got it only with an image preview, which blueprints do not have.
- `filterUnavailableCoreMediaMenuActions` in `useMoreOptionsMenu` still
hides the item when the node has no preview, because the callback keeps
the `'preview'` mark.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| **Comfy-Org#19109** (this PR) | **`main`** | **Mask editor menu item into
`Comfy.MaskEditor` extension** | **1027 -> 1027** | **983 -> 983** |
**4562 -> 4562** |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
AkiEvansDev pushed a commit to AkiEvansDev/ComfyUI-Frontend that referenced this pull request Oct 8, 2026
…ab (Comfy-Org#19113)

## Summary

Stacked on Comfy-Org#19111, in a chain rooted on `main` (Comfy-Org#19091 -> Comfy-Org#19107 ->
Comfy-Org#19108 -> Comfy-Org#19111 -> Comfy-Org#19113). In the original stack it sat on Comfy-Org#19112.
Tracks FE-2769 / FE-3037.

`sidebarTabStore` hard-coded the model-library tab: when
`Comfy.ModelLibrary.UseAssetBrowser` and the `assetsEnabled` flag were
set, its toggle command opened the asset browser instead of the sidebar.
That single tab pulled `openModelLibraryBrowser`, `useFeatureFlags`, and
`settingStore` into the store and into the stores/scripts import cycle.

Import cycles, measured with dependency-cruiser on `src` (the `pnpm
lint:cycles` script arrives with Comfy-Org#19085) against Comfy-Org#19111's branch: cyclic
modules 751 -> 747, largest cycle 698 -> 694, cyclic edges 3480 -> 3460.

## Changes

- `SidebarTabExtension` gains an optional `onToggle?: () => boolean |
Promise<boolean>` hook. The toggle command calls it first and only
toggles the sidebar when the hook returns false or is absent.
- `useModelLibrarySidebarTab` sets `onToggle` with the asset browser
routing that used to live in the store.
- `sidebarTabStore` loses the tab-id special case and its three imports.
- Tests: the model-library cases move to
`useModelLibrarySidebarTab.test.ts`; `sidebarTabStore.test.ts` covers
the hook contract (absent, declines, handles) as a table.

## Review Focus

- `onToggle` is new public API: `SidebarTabExtension` is exported from
`src/types`, so the field ships in the published types package.
Extensions that register a sidebar tab can now intercept the toggle by
returning true; nothing else changes for them.
- The routing now belongs to the core tab object, not to the
`model-library` id. A tab registered under that id by anything other
than `useModelLibrarySidebarTab` no longer opens the asset browser.
- The tab and its `Workspace.ToggleSidebarTab.model-library` command
keep their ids, so the keybinding default is unaffected.
`missingModelDownload` sets `activeSidebarTabId` directly and never ran
the toggle command, so it opens the sidebar tree as before.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| **Comfy-Org#19113** (this PR) | **Comfy-Org#19111 (measured on Comfy-Org#19112)** | **Model
library asset-browser routing onto the sidebar tab** | **471 -> 467** |
**257 -> 253** |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 9, 2026
…ce (Comfy-Org#19092)

## Summary

Targets `main` (Comfy-Org#19088, Comfy-Org#19089 and Comfy-Org#19091 merged; rebased onto `main` at
0ef0276). Moves `loadExtensions` out of `extensionService` into
`src/services/extensionLoader.ts`, called from `GraphCanvas.vue` before
`app.setup()`.

`extensionService` imported `extensions/core/index` so `loadExtensions`
could pull the core extensions in. Every core extension imports `app`,
which imports `extensionService`, so the whole `extensions/core` tree
and the UI it reaches (load3d, mask editor, painter, image compare,
agent panel, ...) sat in the same import cycle as the app object.
`GraphCanvas.vue` already owns the bootstrap sequence and is outside the
cycle, so it is the right owner of the "load extensions" step.

Measured with dependency-cruiser on `src` (the Comfy-Org#19085 config, run
locally), against `main` at 0ef0276:

| | before | after |
| --- | --- | --- |
| modules in any cycle | 631 | 500 |
| largest cycle | 421 | 285 |
| cyclic edges | 2451 | 2034 |

Tracks FE-2769 / FE-3037.

## Changes

- New `src/services/extensionLoader.ts` with `loadExtensions()`,
`shouldLoadExtension()`, `importCustomExtension()` and
`reportExtensionLoadFailures()` (moved verbatim from `main`, including
the `extensions-load-core` / `extensions-load-custom` subphases from
Comfy-Org#19888 and the aggregate failure report). `extensionService.test.ts`
becomes `extensionLoader.test.ts`.
- `extensionService` drops `loadExtensions` and its `api`,
`bootstrapTracer`, `reportError` and `getErrorMessage` imports; it keeps
`registerExtension`, `invokeExtensions`, `invokeExtensionsAsync`.
- Comfy-Org#19730 (subphase timings, previously merged into this branch) is
dropped from the branch because `main` carries the same instrumentation
via Comfy-Org#19888.
- `GraphCanvas.vue` runs
`bootstrapTracer.settle('bootstrap/extensions-load', loadExtensions)`
right before `comfyApp.setup()`. `app.setup()` no longer loads
extensions.
- `GraphCanvas.test.ts` mocks the loader; `SelectionToolbox.test.ts`
drops `loadExtensions` from its service mock.
- `browser_tests/types/globals.d.ts` imports `@/types` explicitly. The
browser typecheck (`lint-pr / typecheck-aux`) only reached the app's
`Window` augmentation through `app -> extensionService ->
extensions/core`, and that path is gone.

## Review Focus

- Ordering change: extension modules now import before `app.setup()`
runs `syncWorkflows()` and `fetchSubgraphs()` and before
`bodyTop`/`canvasContainer`/`canvasElRef` are assigned, instead of
after. Extension hooks (`init`, `setup`, `registerCustomNodes`,
`addCustomNodeDefs`) still run inside `app.setup()` exactly as before,
so an extension only notices if it reads those at module top level.
Nothing in `extensions/core` does.
- The `bootstrap/extensions-load` tracer phase keeps its name and
position between `workflows` and `extensions-init`.
- `src/services/` is a frozen directory per the pre-commit hook; the
loader sits next to `extensionService`, which it was split from.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| **Comfy-Org#19092** (this PR) | **Comfy-Org#19091** | **Load extensions from bootstrap,
not `extensionService`** | **669 -> 580** | **465 -> 371** |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…fy-Org#19118)

## Summary

Re-implemented on current `main` (the original commit no longer applied
after `api.ts` gained `authCredential`, the web-session fetch and
unified remint). Now targets `main` directly. Tracks FE-2769 / FE-3037.

`ComfyApi` reached into the auth layer itself: it lazily imported
`authStore` for the Firebase header and WebSocket token, and imported
`remintRetry` for the 401 re-mint fetch. Both pull the cloud auth graph
(workspace store, session cookie, feature flags, SSO dialogs) into
`api.ts`, the most imported module in `src/`. The client now takes an
`ApiAuthProvider`; the cloud provider is installed from `main.ts`.

Import cycles (dependency-cruiser on `src`, against `main` at
18a9c42): 511 -> 457 cyclic modules, largest SCC 296 -> 232, cyclic
edges 2121 -> 1811 (15 -> 17 cycles: the big SCC splits).

## Changes

- `src/platform/auth/apiAuthProvider.ts` (leaf): `ApiAuthProvider`
interface (`waitForInitialization`, `getAuthHeader`, `getAuthToken`,
`shouldRetryOn401`, `fetch`), `RetrySignalLifecycle`, and
`anonymousApiAuthProvider` (no header, no token, no retry, plain
`fetch`).
- `src/platform/auth/cloudApiAuthProvider.ts`: the moved token logic
(auth-store wait bounded by `AUTH_INIT_TIMEOUT_MS` from
`@/scripts/apiTimeouts`, header/token lookup with the same
`console.warn` fallbacks, WebSocket token telemetry,
`shouldRemintCloudRequest`, `fetchWithUnifiedRemint`).
`installCloudApiAuth()` sets it on `api`.
- `api.ts`: `setAuthProvider`; `addCloudAuthHeader`, `addSocketAuth` and
the token-path `fetch` delegate to the provider. No more `authStore` or
`remintRetry` imports. The web-session path (`webSessionRequests`,
`scopeMediaRoute`), `authCredentialOf` / `notifyAuthCredential`
reporting and the `isCloud` gates stay where they are: those modules are
leaves.
- `main.ts`: `installCloudApiAuth()` in the existing `isCloud` block,
before any request.
- `remintRetry.ts` imports `RetrySignalLifecycle` from the leaf instead
of declaring it.
- Second commit: `ToastAction` / `ToastOptions` move from
`types/extensionTypes.ts` to a new leaf `types/toastOptions.ts`
(`extensionTypes` re-exports them, so `@/types` is unchanged). Comfy-Org#16313
made `api.ts` import `components/ui/toast/toastStore`, which took these
types from `extensionTypes`, and `extensionTypes` reaches
`workflowStore`, `dialogService` and `commandStore` through type
imports. Without this move the provider split leaves `api.ts` inside the
application SCC and the numbers above do not change at all.
- Tests: cloud integration suites (`api.fetchApi`, `api.socketReset`,
`webSessionFlagOff`, `webSessionFlagOn`, `nonWebClientsStayOnTokens`)
call `installCloudApiAuth()` where they previously relied on the lazy
import; the localhost row installs the anonymous provider, as a local
build does. New `it.for` table in `api.fetchApi.test.ts` checks the
header is applied, the retry decision is consulted only for
authenticated requests, and the request goes through the provider's
`fetch`.

## Review Focus

- Install ordering. Requests made before `installCloudApiAuth()` are
anonymous. `main.ts` installs it first thing in the cloud block;
`refreshRemoteConfig({ useAuth: false })` uses bare `fetch`, so nothing
earlier needs credentials.
- Difference from the first version of this PR: `fetchApi` and
`createSocket` keep their `isCloud` gates. On `main` the web session is
switched on by a server feature flag, not by distribution, so dropping
the gate could route a local build's requests through the session.
Keeping it also leaves the local `createSocket` path synchronous, so
`api.featureFlags.test.ts` needs no change.
- Behavior moved, not changed: same timeout, warnings, and telemetry
event for a missing WebSocket token. The telemetry import in the
provider is static; `api.ts` already imported `useTelemetry` statically,
so the old dynamic import saved nothing.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| **Comfy-Org#19118** (this PR) | **Comfy-Org#19116** | **Inject the api auth provider
from `main.ts`** | **464 -> 447** | **250 -> 233** |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 10, 2026
… of scripts/widgets (Comfy-Org#19093)

## Summary

Targets `main` (Comfy-Org#19092 merged). Splits `src/scripts/widgets.ts` into the
`ComfyWidgets` registry, a leaf type module, and the
control_after_generate helpers.

`widgets.ts` imported all 22 widget composables to build the registry,
and every composable imported `ComfyWidgetConstructorV2` from
`widgets.ts`. That type edge put the whole
`vueNodes/widgets/composables` tree into the app import cycle even
though the type only needs `LGraphNode`, `InputSpec` and `IBaseWidget`.

Measured with dependency-cruiser on `src` (the Comfy-Org#19085 config, run
locally), against `main` at 18a9c42:

| | before | after |
| --- | --- | --- |
| modules in any cycle | 511 | 496 |
| largest cycle | 296 | 281 |
| cyclic edges | 2121 | 2085 |

Tracks FE-2769 / FE-3037.

## Changes

- New `src/types/widgetConstructor.ts` with `ComfyWidgetConstructorV2`.
The 22 composables and `widgets.ts` import it from there.
`ComfyWidgetConstructor` (V1) and `CustomComfyWidgetConstructor` stay in
`widgets.ts` because they take `ComfyApp`.
- New `src/core/graph/widgets/valueControlWidgets.ts` with
`addValueControlWidget`, `addValueControlWidgets`,
`updateControlWidgetLabel` and their private helpers, moved verbatim
from current `main` (including `controlAfterGenerateNameOverride` and
the `isValueControlMode` handling added since the branch forked).
`useIntWidget`, `useFloatWidget`, `useComboWidget`, `widgetInputs.ts`
and `GraphCanvas.vue` import from it.
`widgets.controlAfterGenerateName.test.ts` moves with them as
`valueControlWidgets.controlAfterGenerateName.test.ts`.
- `useLightInfoWidget.ts` (added on `main` since the original PR)
imports `ComfyWidgetConstructorV2` from `@/types/widgetConstructor` like
the other composables.
- `widgets.ts` no longer re-exports `IS_CONTROL_WIDGET`;
`GraphCanvas.vue` imports it from
`core/graph/widgets/controlWidgetMarker`.
- `valueControl.ts`, `controlWidgetMarker.ts` and
`promotedWidgetControl.ts` move out of `scripts/` into
`core/graph/widgets` and `core/graph/subgraph`; `health.json` follows
`valueControl.ts`.
- `widgets.ts` keeps `export const` declarations of the three
value-control helpers because `comfyAPIPlugin` only exposes declarations
through the `scripts/widgets.js` shim that custom nodes import
(`.fallowrc.jsonc` lists them as public,
`build/plugins/comfyAPIPlugin.test.ts` asserts them).
`useComboWidget.test.ts` mocks all three, since the shim reads them at
module load.
- `useIntWidget.test.ts` and `useFloatWidget.test.ts` add
`vi.mock(import('@/scripts/app'))` (the repo's manual mock). Their old
`vi.mock('@/scripts/widgets')` had also been preventing the registry
from evaluating; with the registry no longer mocked, the pre-existing
`settingStore -> app -> extensionService -> widgetStore -> widgets`
runtime cycle reached `useIntWidget()` before its definition. Production
import order is unaffected: `app.ts` is entered first there, as before.

## Review Focus

- `valueControlWidgets.ts` stays in the cycle (it needs
`useSettingStore`); it did not go into `valueControl.ts` because that
would have pulled `valueControl.ts` and `promotedWidgetControl.ts` into
the cycle too.
- The 7 composables still in the cycle (`useComboWidget`,
`useIntWidget`, `useFloatWidget`, `useImageUploadWidget`, ...) reach it
through `settingStore`, `assetService` or node output stores, not
through `widgets.ts`.
- `src/types/` was chosen for the type because `simplifiedWidget.ts` and
`widgetState.ts` already live there as widget leaf types.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| **Comfy-Org#19093** (this PR) | **Comfy-Org#19092** | **Split `scripts/widgets.ts`
registry, types, helpers** | **580 -> 566** | **371 -> 357** |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…Comfy-Org#19121)

## Summary

Re-implemented on current `main` (the original commit no longer applied
after `workspaceApi` gained the web-session adapter path). Comfy-Org#19118 has
merged, so this is now one commit on `main`. Tracks FE-2769 / FE-3037.

`workspaceApi` imported `authStore` for its request headers and
`remintRetry` to attach the 401 re-mint interceptor at module load. Both
edges put the workspace billing SDK, capability composables, and
churnkey modules inside the auth cycle. The client now receives its
credentials through `setWorkspaceApiAuth`, wired from `main.ts`, the
same shape as Comfy-Org#19118.

Import cycles (dependency-cruiser on `src`, against `origin/main` at
b835c9d): 459 -> 439 cyclic modules, largest SCC 234 -> 214, cyclic
edges 1815 -> 1730.

## Changes

- `workspaceApi.ts`: module-private `WorkspaceApiAuth`
(`getWorkspaceAuthHeader`, `getFirebaseAuthHeader`,
`attachRetryInterceptor`) and exported `setWorkspaceApiAuth`, which
stores the auth and attaches the interceptor to the axios client.
`requestAuth` keeps its web-session adapter branch and falls back to the
installed workspace header; `acceptInvite` uses the installed Firebase
header. Calls that reach the token path before installation throw
`WorkspaceApiError('Workspace API auth is not installed', 401)`. No more
`authStore` or `remintRetry` imports; `capabilityRevision` still
attaches at module load because it has no auth dependency.
- New `workspaceApiAuth.ts`: `installWorkspaceApiAuth()` binds the
auth-store `*OrThrow` getters and `attachUnifiedRemintInterceptor`.
- `main.ts` calls `installWorkspaceApiAuth()` on every distribution,
right after the cloud block. It cannot share the `isCloud` gate with
`installCloudApiAuth()`: `authStore.getWorkspaceAuthToken` initializes
`teamWorkspaceStore` (and so calls `workspaceApi.list()`) for a
signed-in user on desktop/local too.
- `workspaceApi.test.ts` installs the auth once at module scope; the
store actions it stubs are the same ones the installer binds.
`webSessionFlagOn.test.ts` installs it next to `installCloudApiAuth()`
so the suite runs the production wiring.

## Review Focus

- The interceptor is attached in `setWorkspaceApiAuth`, so calling it
twice attaches two re-mint interceptors. `main.ts` calls it once; the
test files install once at module scope for the same reason.
- Unconfigured state only exists before `main.ts` runs. Previously a
header lookup in that window would have thrown `AuthStoreError`; it now
throws `WorkspaceApiError`. The web-session path never needed the auth
store and is unaffected.
- `WorkspaceApiAuth` is module-private; nothing outside
`workspaceApi.ts` names the type.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| **Comfy-Org#19121** (this PR) | **Comfy-Org#19118** | **Install workspace api
credentials from `main.ts`** | **447 -> 428** | **233 -> 214** |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…g#19116)

## Summary

Targets `main`; the rest of this chain (Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19113) has merged. Tracks FE-2769 / FE-3037.

`executionStore` drove the node text preview widget itself: it bound the
`progress_text` socket event, resolved the node on the canvas, called
`showTextPreview`, and on job reset walked the job's nodes to
`removeTextPreview`. That pulled `useNodeProgressText` (and through it
the widget layer and `app`) plus `canvasStore` into the store.
Separately, `workflowStore` imported `executionStore` to rewrite session
job paths on rename, while `executionStore` imports `workflowStore`;
fallow flags that two-module cycle once this PR touches
`executionStore`.

Import cycles, measured with dependency-cruiser on `src` (the `pnpm
lint:cycles` script arrives with Comfy-Org#19085) against `main`: cyclic modules
421 -> 418, largest cycle 196 -> 193, cyclic edges 1687 -> 1679. The
rename change removes one of those edges; both stores stay in the large
cycle through other paths.

## Changes

- `executionStore` exposes `onJobReset` (vueuse `createEventHook`) and
triggers it with the finished `QueuedJob` inside `resetExecutionState`,
before the job is dropped. `QueuedJob` is exported for the listener
type. The store no longer imports `useNodeProgressText`, `canvasStore`,
or `parseNodeId`, and `progress_text` is no longer bound in
`bindExecutionEvents`.
- New `useProgressTextPreviews` composable listens to `api`
`progress_text` and `executionStore.onJobReset` and owns the widget
calls. GraphView mounts it next to `useProgressFavicon`.
`GraphView.test.ts` is unchanged.
- `workflowStore` no longer imports `executionStore`. `renameWorkflow`
triggers a new `onWorkflowRenamed` hook where it used to call
`rewriteSessionWorkflowPaths`, and `executionStore` subscribes in its
setup. `rewriteSessionWorkflowPaths` is now private.
- Tests: the progress_text and widget-removal cases move to
`useProgressTextPreviews.test.ts` (real execution store, the shared
`api` automock, fixtures built in each test, scope stopped with
`onTestFinished`), which adds cases for the active-prompt filter, for
mapping a nested execution id, and for disposal removing both listeners.
Removal there is driven through `clearActiveJobIfStale`.
`executionStore.test.ts` keeps one table asserting `onJobReset` fires
with the job after success, interrupt, and error, and drops
`progress_text` from the unbind list. Its session-path tests now drive a
real `renameWorkflow`; the matching rename test in
`workflowStore.test.ts` is removed and its duplicate-graph-id case lives
in `executionStore.test.ts`.
- E2E: the Flux2 rerun spec's progress-text test now checks the status
line is visible on the node while it runs, then hidden and gone from the
widget store after `execution_success`. Before, it only checked removal,
so it passed even if the preview never appeared.

## Review Focus

- `createEventHook` follows the existing pattern in
`cloudWebSessionStore` (`onSignedOutElsewhere`). Its `on`
auto-unsubscribes when the calling scope (GraphView) is disposed, and
`trigger` calls listeners synchronously, so the listener sees the job
before `resetExecutionState` deletes it.
- Listener lifetime: `useEventListener(api, 'progress_text')` binds at
GraphView setup and unbinds when GraphView's scope is disposed. Before,
the store bound it in `bindExecutionEvents` (GraphView `onMounted`) and
unbound it in `unbindExecutionEvents` (`onBeforeUnmount`).
`progress_text` only matters once the canvas exists, and the handler
already ignores events with no canvas.
- Rename timing: the hook fires synchronously at the point the direct
call ran, right after `workflow.rename` and before the lookup swap and
bookmark awaits, so linear-mode outputs keep matching the renamed
workflow. When `executionStore` does not exist yet there is no session
state to rewrite.
- Behavior is otherwise unchanged. The filters (active prompt only,
nested execution ids mapped through `workflowStore`, active workflow
only on reset) keep the same logic; node lookup is now one shared
`findNode` helper.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| **Comfy-Org#19116** (this PR) | **Comfy-Org#19113** | **Progress text previews out of
`executionStore`** | **467 -> 464** | **253 -> 250** |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 10, 2026
## Summary

Targets `main` directly, rebased onto cb72d45 after Comfy-Org#19093 merged
(6067dee). The original sat on Comfy-Org#19121; Comfy-Org#19118 and Comfy-Org#19121 are no
longer in this chain. Tracks FE-2769 / FE-3037.

`dialogService` bundled the core prompt/confirm/error dialogs with every
auth, billing, workspace, cloud-notification and ComfyHub dialog. Any
module that called `confirm()` transitively imported the billing and
workspace layers, and `workspaceStore -> dialogService ->
useBillingContext -> ... -> workspaceStore` held the whole platform
layer in the app SCC.

The core service keeps `showExecutionErrorDialog`, `showErrorDialog`,
`prompt`, `confirm`, `showExtensionDialog`, `showLayoutDialog` and
`showSmallLayoutDialog`. Feature dialogs move verbatim into per-feature
composables. Extensions still see every dialog on
`app.extensionManager.dialog`.

Import cycles on `main` cb72d45: 421 -> 412 cyclic modules, largest
SCC 196 -> 187, 1687 -> 1648 cyclic edges.

## Changes

- `dialogService.ts`: core dialogs only. Declares
`ExtensionDialogService` (core + feature signatures, leaf types only),
`registerExtensionDialogService()` and `useExtensionDialogService()`.
- `extensionDialogService.ts`: `createExtensionDialogService()` spreads
the core service and the feature composables. `App.vue` registers it
before `useWorkspaceStore()` is created; `workspaceStore.dialog` reads
the registry. `ExtensionManager.dialog` is typed
`ExtensionDialogService`.
- New composables, functions moved unchanged:
`composables/auth/useAuthDialogs.ts`,
`composables/billing/useBillingDialogs.ts`,
`platform/workspace/composables/useWorkspaceDialogs.ts`,
`platform/cloud/notification/composables/useCloudNotificationDialog.ts`;
`showPublishDialog` joins `useComfyHubPublishDialog`. The shared
`workspaceDialogProps` object becomes `SELF_STYLED_PANEL_DIALOG_PROPS`
in `components/ui/dialog/dialog.variants.ts`, next to
`HUG_CONTENT_CLASS` and `SELF_STYLED_PANEL_CONTENT_CLASS`, which `main`
already has there.
- `composables/billing/types.ts` gains `TopUpCreditsDialogOptions`,
`SubscriptionDialogOptions`, `DowngradeToPersonalResult`.
`ConfirmationDialogType` moves to
`components/dialog/content/confirmationDialogTypes.ts`.
- `useSettingsDialog` calls `dialogStore.showDialog` directly with the
same renderer/headless/closable props `showLayoutDialog` applied.
- Callers switch from `useDialogService().showX` to the owning
composable. Tests get a `__mocks__` per feature composable; billing
dialog tests move next to `useBillingDialogs` (`git mv`), and the two
`showCancelSubscriptionDialog` guard tests move from
`dialogService.concurrency.test.ts` into
`useBillingDialogs.cancelSubscription.test.ts`. `useInviteUrlLoader` and
`UserPanel` (added on `main` since the original) switch to
`useWorkspaceDialogs` / `useAuthDialogs` too. The downgrade-failure
toast in `useBillingDialogs` uses the `useToast()` API from Comfy-Org#16313, as
the moved code on `main` does.

## Review Focus

- Registry over direct import: `workspaceStore` importing the aggregator
directly keeps every feature composable in the SCC (in the original
stack, simulated 185 vs 172). The registry is a module-level `let`
guarded by `assert` from `@/base/assert`; `App.vue` is the only
registration site.
- `useExtensionDialogService()` before registration is a programming
error: `assert` throws in DEV and reports in production.
- Browser test fixtures (`PublishDialog.ts`, `CloudNotification.ts`)
call
`window.app.extensionManager.dialog.showPublishDialog/showCloudNotification`;
both remain on the extension surface.
- Feature dialog composables are still in the SCC through their dialog
components, which import `app`. That is the next PR (`app` -> root graph
leaf).
- `.fallow-baselines/health.json`: one `crap_high` entry added for
`useBillingDialogs.ts`; `showTopUpCreditsDialog` moved verbatim, fallow
re-estimates coverage per file from export references, and the
composable has fewer importers than `dialogService`.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| **Comfy-Org#19131** (this PR) | **Comfy-Org#19121 (measured on Comfy-Org#19127)** | **Feature
dialogs out of `dialogService`** | **400 -> 391** | **181 -> 172** |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 11, 2026
…omfy-Org#19143)

## Summary

Modules below `scripts/app.ts` in the import graph stop importing the
`app` value from it. They call `useApp()` from `scripts/appInstance`,
which reads a registry that `app.ts` fills right after constructing
`ComfyApp`. Type-only consumers import the new `ComfyApp` interface from
`types/comfy`. Clipspace state moves out of the class into
`scripts/clipspace`.

Import cycles: 409 -> 371 cyclic modules, largest SCC 184 -> 154
(litegraph is now the largest), 1640 -> 1451 cyclic edges, measured with
dependency-cruiser on `main` a2dba8f.

Targets `main` directly, rebased onto a2dba8f. Tracks FE-2769 /
FE-3037.

## Changes

- `types/comfy.ts`: `ComfyApp` interface (public instance surface),
`QueuePromptOptions`, `LoadGraphDataOptions`. `types/index.ts`
re-exports the type from here instead of from `scripts/app`.
- `scripts/appRegistry.ts`: `registerApp` / `useApp` (asserts
registration). `scripts/appInstance.ts` re-exports `useApp` as the
consumer-facing seam so tests can mock it without re-entering `app.ts`.
- `scripts/clipspace.ts`: clipspace state plus `copyToClipspace` /
`pasteFromClipspace`. `ComfyApp` statics stay as accessors for
custom-node compatibility; `litegraphService` and `changeTracker` use
the leaf directly.
- `class ComfyApp implements ComfyApp` (aliased `IComfyApp` inside
`app.ts`). `ANIM_PREVIEW_WIDGET` now lives in `useNodeAnimatedImage.ts`
and is re-exported from `app.ts`.
- ~40 SCC importers switched to `useApp()` (all call sites are inside
functions). On the current base that includes the mask editor
composables, `useNodeProgressText` and `useProgressTextWidget`, which
joined the SCC after the original PR. Type positions use
`ComfyApp['rootGraph']` / `Parameters<ComfyApp['loadGraphData']>[0]`.
- `commandStore.loadExtensionCommands` takes `{ name; commands? }` so it
no longer imports `ComfyExtension`.
- `vitest.setup.ts`: global mock of `@/scripts/appInstance` that
resolves `useApp()` to whatever `@/scripts/app` is in the test file
(real or per-file mock), awaited in `beforeAll` / `beforeEach`.
`firstRunEntry.test.ts`'s `createSharedComposable` stand-in now resets
every composable it created rather than only the last one registered.
- `scripts/README.md`: documents the interface / `useApp()` / clipspace
pattern.
- Baselines: `.fallow-baselines/dead-code.json` gains 32 pre-existing
cycles (auth, billing, `workflowStore` <-> `executionStore`, the billing
paths through `useBillingDialogs`, and `comfyWorkflow -> changeTracker
-> workflowStore`) that fallow only enumerates once the hub edges are
gone; every entry's modules sit in one SCC on `main`; the entries use
fallow's sorted-path key. `health.json` entry for `clipspace.ts`.

## Review Focus

- Only modules below `app.ts` use `useApp()`. Top-level code
(extensions, components, `App.vue`) keeps `import { app }`.
- `useApp()` asserts that `registerApp` has run; every migrated call
site runs after `app.ts` evaluates. `appRegistry.test.ts` covers both
branches.
- The vitest bridge loads `@/scripts/app` asynchronously, so modules in
its tree now evaluate after the test subject's imports.
`firstRunEntry.test.ts` was the one test sensitive to that ordering.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| **Comfy-Org#19143** (this PR) | **Comfy-Org#19131** | **Invert `scripts/app` behind
`useApp()`** | **391 -> 352** | **172 -> 149** |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 13, 2026
## Summary

`types/comfy.ts` is the public extension contract, yet it imported
`scripts/widgets`, `scripts/ui`, and the workflow store, so every module
that typed against `ComfyApp` was pulled into the app's largest import
cycle. This PR makes `types/comfy.ts`, `types/extensionTypes.ts`, and
`comfyWorkflow.ts` leaves: they no longer reach `scripts/appInstance`.
Before the review fixes, depcruise measured the 273-module app SCC
splitting into 119 + 58 modules.

Import-cycle measurements before the review fixes: 371 -> 341 cyclic
modules, largest SCC 154 -> 154 (litegraph), 1451 -> 1335 cyclic edges,
on `main` df4ea6d (Comfy-Org#19143 merged as cdc9fe0). These counts have
not been remeasured after restoring the extension hooks.
`workflowStoreTypes.ts` carries main's `nodeLocatorIdToNodeId: ... =>
NodeId | null` signature, which landed on `main` after the interface
moved.

Targets `main` directly, rebased onto df4ea6d after Comfy-Org#19143 merged
(cdc9fe0). Tracks FE-2769 / FE-3037.

## Changes

- `ComfyWidgetConstructor` / `CustomComfyWidgetConstructor` are declared
in `types/comfy.ts`; `scripts/widgets.ts` imports them.
`ComfyApp.widgets` is typed as `Record<string, ComfyWidgetConstructor |
CustomComfyWidgetConstructor>` instead of `typeof ComfyWidgets`, and
`dynamicComboWidget` narrows the result of `app.widgets.COMBO`.
- `MissingModelPipelineResult` moves to
`platform/missingModel/types.ts`; `groupCandidatesByName` moves into
`missingModelGrouping.ts` so grouping stops importing scan.
- `scripts/ui.ts`: `ComfyUI(app, host)` takes the app and a
`LegacyMenuHost` (`resetView`, `restoreOutputs`, `trackRunButton`,
`enterFocusMode`) instead of calling `useApp()`, `litegraphService`,
`nodeOutputStore`, `workspaceStore`, and `useRunButtonTelemetry`.
`app.ts` wires the host.
- `comfyWorkflow.ts` becomes a leaf. `WorkflowChangeTracker` is an
interface `ChangeTracker` implements. A `WorkflowRuntime`
(`createChangeTracker`, draft get/remove/markUsed,
`isDraftPersistenceEnabled`) is registered by `workflowStore.ts` at
module scope, replacing the dynamic `import('@/scripts/changeTracker')`
and the direct settings/draft-store imports.
- `ComfyWorkflow.promptSave()` remains an extension override point. Its
default delegates to the registered `WorkflowRuntime`, which opens the
dialog using `saveNamePrompt` i18n keys, overridden by
`SubgraphBlueprint`. `workflowService.saveWorkflowAs` continues calling
the hook.
- Clipspace editor save honors `ComfyApp.pasteFromClipspace` overrides.
Image paste updates store-backed outputs without requiring legacy
previews and skips absent selections while still pasting widget values.
- New leaf `workflowStoreTypes.ts` exports the `WorkflowStore`
interface; `ExtensionManager.workflow` is typed as `WorkflowStore`.
- New leaf `services/dialogServiceTypes.ts` with `CoreDialogService`,
`ExtensionDialogService`, `ConfirmOptions`, `ExecutionErrorDialogInput`;
`useDialogService()` returns `CoreDialogService` and `extensionTypes.ts`
imports the leaf. `ExtensionDialogService` carries main's current
signatures (`showCancelSubscriptionDialog` scope/confirmed args,
`paymentIntentSource`, `showInviteLinkInvalidDialog`,
`showInviteWrongAccountDialog`).
- `comfyWorkflow.test.ts` deleted (it tested the dynamic-import failure
path that no longer exists); `workflowService.test.ts` mocks
`useDialogService().prompt` and asserts the save-name copy; `ui.test.ts`
/ `ui.setStatus.test.ts` pass the app and a stub host.

## Review Focus

- `ComfyApp.widgets` loses the `typeof ComfyWidgets` key typing. Core
widget constructors are still reachable as
`useWidgetStore().coreWidgets`; extension code indexing
`app.widgets.<Name>` now gets the union type.
- `ExtensionManager.workflow` no longer exposes Pinia `$`-methods on the
public type. Extensions calling `app.extensionManager.workflow.$patch`
would be a type break (runtime unchanged).
- `ComfyWorkflow.promptSave` is preserved because
[RigShare](https://github.com/xiaodoudou/ComfyUI-RigShare/blob/3de3cc32e2a5bd266879dd6b346f8960ad4dd619/web/rigshare/save-dialog.js#L22)
and
[Bada-Utils](https://github.com/bada-ya/ComfyUI-Bada-Utils/blob/0898b33e803df8e169501d8fe0cf1fd04044f7bf/web/workflow_organizer.js#L2996)
wrap its prototype implementation to customize Save As. A regression
test checks that an override's filename reaches the save path.
- `workflowStore.ts` now imports `ChangeTracker` statically. fallow sees
the previously dynamic `comfyWorkflow -> workflowStore -> changeTracker`
3-cycle reshaped into two short `workflowStore <-> changeTracker`
cycles; this plus 28 pre-existing cycles fallow newly enumerates
(auth/session, api <-> authStore <-> dialogService, promotionUtils
through canvasStore and litegraphService, useAppMode -> workflowStore ->
changeTracker -> executionStore, workflowStore <-> executionStore,
canvasStore <-> litegraphUtil) are baselined in
`.fallow-baselines/dead-code.json`. Breaking `changeTracker ->
workflowStore` needs a host injection into `ChangeTracker` and a rewrite
of its 1400-line test, so it is left for a follow-up.
- `dynamicComboWidget` keeps the runtime lookup through
`app.widgets.COMBO`. A static import of `useComboWidget` or
`widgetStore` from `dynamicWidgets.ts` creates a module-evaluation cycle
with `scripts/widgets.ts` (`...dynamicWidgets` spread sees an
uninitialised binding), which is why the assert-based narrowing is used
instead.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| **Comfy-Org#19153** (this PR) | **Comfy-Org#19148** | **`types/comfy`, `comfyWorkflow`,
dialog/workflow contracts as leaves** | **324 -> 293** | **149
(baseline)** |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
xmarre pushed a commit to xmarre/ComfyUI_frontend that referenced this pull request Oct 14, 2026
## Summary

Removes the import cycles left inside `src/workbench`: the 28-module
manager cycle and the agent CRDT status cycle. `workbench/` is now
cycle-free, which is a prerequisite for giving it its own TypeScript
project reference.

Import cycles: 341 -> 311 cyclic modules, 20 -> 18 cycles, largest SCC
154 -> 154 (litegraph), 1335 -> 1262 cyclic edges, on top of Comfy-Org#19153
(rebased onto `main` df4ea6d).

Stacked on Comfy-Org#19153 (rebased onto the `drjkl/comfy-types-leaf` chain).
Tracks FE-2769 / FE-3037.

## Changes

- Manager: `useManagerState` had two responsibilities, deriving the
manager UI state and opening the manager. Opening needs
`useManagerDialog`, which imports `ManagerDialog.vue`, whose subtree
imports `useManagerState` again. `openManager` moves to
`useManagerDialog`, which already owns `show()`/`hide()`.
`useManagerState` keeps the state derivations and the once-per-session
upgrade toast, and exports `showIncompatibleManagerToast({ force })` so
the explicit-click re-emit lives with `openManager`.
- Callers (`useCoreCommands`, `TopMenuSection`, `ComfyMenuButton`,
`HelpCenterMenuContent`, `ErrorGroupList`, `MissingPackGroupRow`) call
`useManagerDialog().openManager(...)`. `ComfyMenuButton` no longer needs
`useManagerState`. The legacy-menu error toast in `openManager` uses the
`useToast()` API from Comfy-Org#16313, as `useManagerState` does on `main`.
- Tests: `openManager` coverage moves from `useManagerState.test.ts` to
`useManagerDialog.test.ts` and now covers all four states (DISABLED,
INCOMPATIBLE, LEGACY_UI with and without `showToastOnLegacyError`,
NEW_UI with and without `isLegacyOnly`) by driving the real
`useManagerState` through `systemStatsStore` and spied `api` feature
flags. The shared `__mocks__/useManagerState.ts` drops `openManager`; a
new `__mocks__/useManagerDialog.ts` covers component tests.
- Agent composer: the `ComposerAttachment` leaf this PR originally
introduced already landed on main (`types/composerAttachment.ts`), so
that part is dropped.
- Agent CRDT: `AgentCrdtStatus` and `AgentCrdtOutcomeCounters` move to a
new leaf `crdt/agentCrdtStatus.ts` so `crdtSnapshot.ts` stops importing
`useAgentCrdtFollower.ts`.
- fallow baselines: `dead-code.json` is unchanged (the stale manager
entries stay as unused baseline rows); the `crap_high` entry for
`openManager` moves from `useManagerState.ts` to `useManagerDialog.ts`
in `health.json` (same function, new file).

## Review Focus

- `openManager` now calls `useManagerState()` per invocation. Its
`watch(..., { immediate: true })` runs once per call and can fire the
once-per-session INCOMPATIBLE toast if no component had instantiated the
composable yet. That matches the previous behaviour, where every caller
instantiated `useManagerState()` before calling `openManager`.
- `useManagerDialog` now imports `useManagerState`; the dependency
direction is dialog -> state, matching `useManagerDialog ->
ManagerDialog.vue -> ... -> useManagerState`.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| **Comfy-Org#19186** (this PR) | **Comfy-Org#19153** | **Workbench cycles: `openManager`
onto `useManagerDialog`, agent leaves** | **293 -> 259** | **149
(baseline)** |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
DrJKL added a commit to mcmerdith/ComfyUI_frontend that referenced this pull request Oct 19, 2026
Resolve conflicts with Comfy-Org#19088, which split litegraph interfaces into leaf
and graph-bound modules: move the INodeOutputSlot.widget declaration to
types/slots.ts and point the src/types/litegraph.ts re-exports at the
modules that now own each type. Drop the deleted
litegraph-augmentation.d.ts from the extension-runtime architecture
record and regenerate boundaries.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor-gordian-knot Import-cycle untangling stack (FE-3037) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants