Repository navigation
refactor: split feature dialogs out of dialogService - #19131
Conversation
🎭 Playwright: ✅ 2246 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (85 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since cb72d4536abcfc8ad4f1f7cd043023065c091e85
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 9.36 MB gzip 🔴 +1.99 kBDetailsSummary
Category Glance App Entry Points — 4.81 kB (baseline 4.6 kB) • 🔴 +208 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • 🟢 -6 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 146 kB (baseline 156 kB) • 🟢 -10.1 kBTop-level views, pages, and routed surfaces
Status: 16 added / 17 removed / 2 unchanged Panels & Settings — 670 kB (baseline 671 kB) • 🟢 -916 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 12 removed / 18 unchanged User & Accounts — 54.3 kB (baseline 54.3 kB) • 🔴 +5 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 6 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • 🔴 +365 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 12 removed / 1 unchanged UI Components — 201 kB (baseline 201 kB) • 🟢 -1 BReusable component library chunks
Status: 24 added / 24 removed Data & Services — 3.07 MB (baseline 3.06 MB) • 🔴 +8.84 kBStores, services, APIs, and repositories
Status: 20 added / 20 removed / 2 unchanged Utilities & Hooks — 824 kB (baseline 823 kB) • 🔴 +1.14 kBHelpers, composables, and utility bundles
Status: 28 added / 27 removed / 27 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 1 added / 1 removed / 17 unchanged Other — 18.8 MB (baseline 18.8 MB) • 🔴 +1.7 kBBundles that do not match a named category
Status: 151 added / 151 removed / 195 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-09T22:45:59.801Z",
"gitSha": "bbbe5d940745a5e8cea8f140d11cf1b7889133a9",
"branch": "drjkl/dialog-service-split",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.1070000000336,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1879999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.10699999999997,
"heapDeltaBytes": 5483072,
"heapUsedBytes": 62066928,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.206999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2022.6030000000037,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.697000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.60299999999995,
"heapDeltaBytes": 5545260,
"heapUsedBytes": 62201372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.928999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.272000000024,
"styleRecalcs": 55,
"styleRecalcDurationMs": 15.301,
"layouts": 12,
"layoutDurationMs": 3.281,
"taskDurationMs": 864.3820000000001,
"heapDeltaBytes": -42467800,
"heapUsedBytes": 56646020,
"domNodes": -217,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 159.65500000000003,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.9510000000328,
"styleRecalcs": 52,
"styleRecalcDurationMs": 14.750000000000002,
"layouts": 12,
"layoutDurationMs": 3.4419999999999997,
"taskDurationMs": 825.918,
"heapDeltaBytes": 1276712,
"heapUsedBytes": 58232168,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 157.301,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.7209999999586,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.146,
"layouts": 3,
"layoutDurationMs": 0.558,
"taskDurationMs": 269.521,
"heapDeltaBytes": 6426520,
"heapUsedBytes": 62913988,
"domNodes": 47,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.712,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.0030000000006,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.551000000000001,
"layouts": 3,
"layoutDurationMs": 0.558,
"taskDurationMs": 355.825,
"heapDeltaBytes": -37731428,
"heapUsedBytes": 62337268,
"domNodes": -170,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 14.578000000000001,
"eventListeners": -87,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 667.9250000000252,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4349999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.12100000000004,
"heapDeltaBytes": 17443164,
"heapUsedBytes": 73993516,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.19600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.1790000000237,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.254999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.0089999999999,
"heapDeltaBytes": -34911864,
"heapUsedBytes": 71455984,
"domNodes": -217,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 163.15099999999998,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307678,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1173.3849999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 839.469,
"heapDeltaBytes": 12757548,
"heapUsedBytes": 95870568,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 65.86600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.9569999999549,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 847.2500000000001,
"heapDeltaBytes": 13616392,
"heapUsedBytes": 97459844,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 68.064,
"eventListeners": 0,
"totalBlockingTimeMs": 569,
"frameDurationMs": 35.291176470588226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.5360000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.67999999999955,
"heapDeltaBytes": 18774976,
"heapUsedBytes": 97043456,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 169.296,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.876999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.8400000000004,
"heapDeltaBytes": 20360692,
"heapUsedBytes": 107929236,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 175.96,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10472.36700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9567.083999999999,
"heapDeltaBytes": 1301976,
"heapUsedBytes": 90265552,
"domNodes": -141,
"jsHeapTotalBytes": -2756608,
"scriptDurationMs": 8200.528,
"eventListeners": -69,
"totalBlockingTimeMs": 1408,
"frameDurationMs": 32.403405572755425,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10396.612000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9462.741000000002,
"heapDeltaBytes": 10444260,
"heapUsedBytes": 93559840,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 7765.836,
"eventListeners": 0,
"totalBlockingTimeMs": 884,
"frameDurationMs": 31.418731117824773,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10173.439999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9304.995,
"heapDeltaBytes": -2007112,
"heapUsedBytes": 81494248,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 7666.022,
"eventListeners": 0,
"totalBlockingTimeMs": 967,
"frameDurationMs": 31.769687500000003,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10907.664999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10113.676,
"heapDeltaBytes": 2837044,
"heapUsedBytes": 86963272,
"domNodes": 0,
"jsHeapTotalBytes": -17563648,
"scriptDurationMs": 8356.795,
"eventListeners": 0,
"totalBlockingTimeMs": 1280,
"frameDurationMs": 31.410951008645533,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 215.5740000000037,
"styleRecalcs": 25,
"styleRecalcDurationMs": 17.198999999999998,
"layouts": 5,
"layoutDurationMs": 1.645,
"taskDurationMs": 156.532,
"heapDeltaBytes": 12046340,
"heapUsedBytes": 78065452,
"domNodes": 918,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.583,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.680000000000017,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 206.69199999997545,
"styleRecalcs": 23,
"styleRecalcDurationMs": 18.200999999999997,
"layouts": 5,
"layoutDurationMs": 1.6939999999999997,
"taskDurationMs": 150.19499999999996,
"heapDeltaBytes": 12050304,
"heapUsedBytes": 77659900,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.734,
"eventListeners": 202,
"totalBlockingTimeMs": 3,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2049.98999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.157,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.2370000000001,
"heapDeltaBytes": -39676980,
"heapUsedBytes": 85357816,
"domNodes": -313,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 30.962000000000003,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2060.9539999999242,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6749999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.068,
"heapDeltaBytes": -39498628,
"heapUsedBytes": 85397948,
"domNodes": -313,
"jsHeapTotalBytes": -2719744,
"scriptDurationMs": 35.286,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2406.3019999999824,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.687,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1620.3820000000003,
"heapDeltaBytes": 20709872,
"heapUsedBytes": 85810976,
"domNodes": -313,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 811.606,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.782517482517488,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2410.957999999937,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.718,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1684.0520000000004,
"heapDeltaBytes": -39498756,
"heapUsedBytes": 85313220,
"domNodes": -313,
"jsHeapTotalBytes": -4329472,
"scriptDurationMs": 821.021,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78368794326241,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3472.519000000034,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.424999999999999,
"layouts": 60,
"layoutDurationMs": 9.305000000000001,
"taskDurationMs": 1470.383,
"heapDeltaBytes": 8285956,
"heapUsedBytes": 76048776,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 755.429,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3697.1640000000434,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.6229999999999976,
"layouts": 60,
"layoutDurationMs": 9.627,
"taskDurationMs": 1759.6410000000003,
"heapDeltaBytes": 8231444,
"heapUsedBytes": 75886432,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 796.407,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666063348416294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2913.3489999999824,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.869999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1882.787,
"heapDeltaBytes": 23238080,
"heapUsedBytes": 89927756,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.9380000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.762068965517244,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3078.345000000013,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.431000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1964.016,
"heapDeltaBytes": 24588064,
"heapUsedBytes": 91507540,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 997.3140000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.848087431693987,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.4720000000416,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.491,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.3270000000001,
"heapDeltaBytes": -40689596,
"heapUsedBytes": 85831104,
"domNodes": -313,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 30.486,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2038.7319999999818,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5839999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.2530000000002,
"heapDeltaBytes": -40481352,
"heapUsedBytes": 85846476,
"domNodes": -313,
"jsHeapTotalBytes": -2457600,
"scriptDurationMs": 39.825,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.8489999999874,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.78499999999997,
"heapDeltaBytes": -38415652,
"heapUsedBytes": 68900672,
"domNodes": -233,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 142.01,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 633.4100000000262,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.2589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.08200000000005,
"heapDeltaBytes": -39887328,
"heapUsedBytes": 68103868,
"domNodes": -255,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 150.71400000000003,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2042.6479999999856,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.873,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.77700000000004,
"heapDeltaBytes": -39053480,
"heapUsedBytes": 62378196,
"domNodes": -233,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 8.910000000000002,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.453000000046,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7020000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.8669999999999,
"heapDeltaBytes": 5543336,
"heapUsedBytes": 62263100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.482000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.896000000001,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.215,
"layouts": 16,
"layoutDurationMs": 4.372,
"taskDurationMs": 689.137,
"heapDeltaBytes": -22522156,
"heapUsedBytes": 79386416,
"domNodes": -235,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 108.901,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1984.17900000004,
"styleRecalcs": 87,
"styleRecalcDurationMs": 18.33,
"layouts": 16,
"layoutDurationMs": 4.419999999999999,
"taskDurationMs": 921.816,
"heapDeltaBytes": -27100196,
"heapUsedBytes": 81032396,
"domNodes": -233,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 112.63900000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1168.0770000000393,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.14100000000001,
"layouts": 5,
"layoutDurationMs": 14.825999999999999,
"taskDurationMs": 796.297,
"heapDeltaBytes": 31914540,
"heapUsedBytes": 110095584,
"domNodes": 14650,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 30.297000000000004,
"eventListeners": 2456,
"totalBlockingTimeMs": 134,
"frameDurationMs": 20.055932203389848,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "viewport-pan-sweep",
"durationMs": 8310.571000000038,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.776,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5022.183,
"heapDeltaBytes": -43579072,
"heapUsedBytes": 87226820,
"domNodes": -313,
"jsHeapTotalBytes": -1740800,
"scriptDurationMs": 2681.216,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767070707070708,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9201.202999999965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.532999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5941.660000000001,
"heapDeltaBytes": -39687372,
"heapUsedBytes": 86158024,
"domNodes": -313,
"jsHeapTotalBytes": -3575808,
"scriptDurationMs": 2756.9469999999997,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696181818181817,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18658.176999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17937.599,
"heapDeltaBytes": -41024492,
"heapUsedBytes": 183664320,
"domNodes": -3046,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 276.09099999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.20932642487047,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 14313.320999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13326.839000000002,
"heapDeltaBytes": -26922096,
"heapUsedBytes": 189124588,
"domNodes": -3046,
"jsHeapTotalBytes": 12865536,
"scriptDurationMs": 248.59799999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.182432432432435,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 23599.368000000028,
"styleRecalcs": 179,
"styleRecalcDurationMs": 17.996000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23165.889999999996,
"heapDeltaBytes": -26279452,
"heapUsedBytes": 190564308,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 893.4680000000001,
"eventListeners": -14913,
"totalBlockingTimeMs": 14,
"frameDurationMs": 43.38051470588236,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 16791.922,
"styleRecalcs": 120,
"styleRecalcDurationMs": 11.91500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16397.097999999998,
"heapDeltaBytes": -39138208,
"heapUsedBytes": 189178632,
"domNodes": -3046,
"jsHeapTotalBytes": 8192000,
"scriptDurationMs": 840.2499999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 26,
"frameDurationMs": 30.737545787545788,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 6718.296000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.26000000000002,
"layouts": 20,
"layoutDurationMs": 22.634000000000015,
"taskDurationMs": 6602.098,
"heapDeltaBytes": 15251344,
"heapUsedBytes": 217123820,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 110.77999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.16079545454545,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5226.047999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.571,
"layouts": 20,
"layoutDurationMs": 26.58300000000001,
"taskDurationMs": 5147.607,
"heapDeltaBytes": 3542160,
"heapUsedBytes": 222919644,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 103.42699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.904000000000003,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9607.56200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9321.067,
"heapDeltaBytes": -36418512,
"heapUsedBytes": 183560052,
"domNodes": -3046,
"jsHeapTotalBytes": 4624384,
"scriptDurationMs": 149.8600000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.988316151202746,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9824.211999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9535.412,
"heapDeltaBytes": -35985244,
"heapUsedBytes": 184770336,
"domNodes": -3046,
"jsHeapTotalBytes": 5701632,
"scriptDurationMs": 155.01600000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.084374999999994,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 144.0900000000056,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.780000000000003,
"layouts": 5,
"layoutDurationMs": 2.5029999999999997,
"taskDurationMs": 108.525,
"heapDeltaBytes": 4470296,
"heapUsedBytes": 61264708,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.924000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 119.50200000001132,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.039,
"layouts": 4,
"layoutDurationMs": 1.6880000000000002,
"taskDurationMs": 88.48900000000002,
"heapDeltaBytes": 4063836,
"heapUsedBytes": 60411924,
"domNodes": 118,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.473000000000003,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428674,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 895.0709999999162,
"styleRecalcs": 77,
"styleRecalcDurationMs": 89.69000000000001,
"layouts": 76,
"layoutDurationMs": 19.544,
"taskDurationMs": 861.2429999999999,
"heapDeltaBytes": 17978920,
"heapUsedBytes": 95323600,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 350.57700000000006,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 878.8320000001022,
"styleRecalcs": 77,
"styleRecalcDurationMs": 91.767,
"layouts": 76,
"layoutDurationMs": 19.2,
"taskDurationMs": 850.3340000000001,
"heapDeltaBytes": 17973052,
"heapUsedBytes": 91886716,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 345.79900000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1480.450000000019,
"styleRecalcs": 77,
"styleRecalcDurationMs": 267.494,
"layouts": 76,
"layoutDurationMs": 20.432,
"taskDurationMs": 1459.3719999999998,
"heapDeltaBytes": -19041400,
"heapUsedBytes": 119249576,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 501.7940000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.54124999999999,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1473.4929999999622,
"styleRecalcs": 77,
"styleRecalcDurationMs": 271.316,
"layouts": 76,
"layoutDurationMs": 20.961000000000002,
"taskDurationMs": 1451.206,
"heapDeltaBytes": -19041956,
"heapUsedBytes": 119211024,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 487.53599999999994,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.08780487804879,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19131 +/- ##
==========================================
+ Coverage 85.98% 86.82% +0.84%
==========================================
Files 3627 2575 -1052
Lines 173537 145060 -28477
Branches 47909 37790 -10119
==========================================
- Hits 149214 125954 -23260
+ Misses 22296 18718 -3578
+ Partials 2027 388 -1639
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1069 files with indirect coverage changes 🚀 New features to boost your workflow:
|
AustinMroz
left a comment
There was a problem hiding this comment.
Lot of lines changed, but I didn't see anything actually scary or particularly ick compared to the preceeding PRs. Mostly just extractions that aren't welly conveyed through diffs.
`dialogService` bundled the core prompt/confirm/error dialogs with every auth, billing, workspace, cloud-notification and ComfyHub dialog, so the core service pulled the whole platform layer into the app SCC and every consumer of `confirm()` transitively imported billing. The core service keeps `showExecutionErrorDialog`, `showErrorDialog`, `prompt`, `confirm`, `showExtensionDialog`, `showLayoutDialog` and `showSmallLayoutDialog`. Feature dialogs move verbatim into `useAuthDialogs`, `useBillingDialogs`, `useWorkspaceDialogs`, `useCloudNotificationDialog` and `useComfyHubPublishDialog.showPublishDialog`; callers import the composable they need. Extensions still reach every dialog through `app.extensionManager.dialog`. `ExtensionDialogService` declares that surface with leaf types only; `createExtensionDialogService()` assembles it and `App.vue` registers it before the workspace store is created, so `workspaceStore` no longer imports the feature composables directly. `ConfirmationDialogType` moves to a leaf module and `useSettingsDialog` calls `dialogStore.showDialog` directly instead of `showLayoutDialog`. The shared `workspaceDialogProps` object becomes `SELF_STYLED_PANEL_DIALOG_PROPS` in `dialog.variants.ts`, next to the content classes it wraps. Billing dialog tests move next to `useBillingDialogs` (including the two cancel-subscription guard tests from `dialogService.concurrency.test.ts`); a new `__mocks__` per feature composable replaces the monolithic dialogService mock in the affected tests. The health baseline entry for `showTopUpCreditsDialog` moves with it. Import cycles: 521 -> 512 cyclic modules, largest SCC 307 -> 298, 2095 -> 2065 cyclic edges. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
c72a6d5 to
39a21f5
Compare
…fy-Org#19118) ## Summary Re-implemented on current `main` (the original commit no longer applied after `api.ts` gained `authCredential`, the web-session fetch and unified remint). Now targets `main` directly. Tracks FE-2769 / FE-3037. `ComfyApi` reached into the auth layer itself: it lazily imported `authStore` for the Firebase header and WebSocket token, and imported `remintRetry` for the 401 re-mint fetch. Both pull the cloud auth graph (workspace store, session cookie, feature flags, SSO dialogs) into `api.ts`, the most imported module in `src/`. The client now takes an `ApiAuthProvider`; the cloud provider is installed from `main.ts`. Import cycles (dependency-cruiser on `src`, against `main` at 18a9c42): 511 -> 457 cyclic modules, largest SCC 296 -> 232, cyclic edges 2121 -> 1811 (15 -> 17 cycles: the big SCC splits). ## Changes - `src/platform/auth/apiAuthProvider.ts` (leaf): `ApiAuthProvider` interface (`waitForInitialization`, `getAuthHeader`, `getAuthToken`, `shouldRetryOn401`, `fetch`), `RetrySignalLifecycle`, and `anonymousApiAuthProvider` (no header, no token, no retry, plain `fetch`). - `src/platform/auth/cloudApiAuthProvider.ts`: the moved token logic (auth-store wait bounded by `AUTH_INIT_TIMEOUT_MS` from `@/scripts/apiTimeouts`, header/token lookup with the same `console.warn` fallbacks, WebSocket token telemetry, `shouldRemintCloudRequest`, `fetchWithUnifiedRemint`). `installCloudApiAuth()` sets it on `api`. - `api.ts`: `setAuthProvider`; `addCloudAuthHeader`, `addSocketAuth` and the token-path `fetch` delegate to the provider. No more `authStore` or `remintRetry` imports. The web-session path (`webSessionRequests`, `scopeMediaRoute`), `authCredentialOf` / `notifyAuthCredential` reporting and the `isCloud` gates stay where they are: those modules are leaves. - `main.ts`: `installCloudApiAuth()` in the existing `isCloud` block, before any request. - `remintRetry.ts` imports `RetrySignalLifecycle` from the leaf instead of declaring it. - Second commit: `ToastAction` / `ToastOptions` move from `types/extensionTypes.ts` to a new leaf `types/toastOptions.ts` (`extensionTypes` re-exports them, so `@/types` is unchanged). Comfy-Org#16313 made `api.ts` import `components/ui/toast/toastStore`, which took these types from `extensionTypes`, and `extensionTypes` reaches `workflowStore`, `dialogService` and `commandStore` through type imports. Without this move the provider split leaves `api.ts` inside the application SCC and the numbers above do not change at all. - Tests: cloud integration suites (`api.fetchApi`, `api.socketReset`, `webSessionFlagOff`, `webSessionFlagOn`, `nonWebClientsStayOnTokens`) call `installCloudApiAuth()` where they previously relied on the lazy import; the localhost row installs the anonymous provider, as a local build does. New `it.for` table in `api.fetchApi.test.ts` checks the header is applied, the retry decision is consulted only for authenticated requests, and the request goes through the provider's `fetch`. ## Review Focus - Install ordering. Requests made before `installCloudApiAuth()` are anonymous. `main.ts` installs it first thing in the cloud block; `refreshRemoteConfig({ useAuth: false })` uses bare `fetch`, so nothing earlier needs credentials. - Difference from the first version of this PR: `fetchApi` and `createSocket` keep their `isCloud` gates. On `main` the web session is switched on by a server feature flag, not by distribution, so dropping the gate could route a local build's requests through the session. Keeping it also leaves the local `createSocket` path synchronous, so `api.featureFlags.test.ts` needs no change. - Behavior moved, not changed: same timeout, warnings, and telemetry event for a missing WebSocket token. The telemetry import in the provider is static; `api.ts` already imported `useTelemetry` statically, so the old dynamic import saved nothing. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | **Comfy-Org#19118** (this PR) | **Comfy-Org#19116** | **Inject the api auth provider from `main.ts`** | **464 -> 447** | **250 -> 233** | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352 | 172 -> 149 | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves | 324 -> 293 | 149 (baseline) | | Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end -->
… of scripts/widgets (Comfy-Org#19093) ## Summary Targets `main` (Comfy-Org#19092 merged). Splits `src/scripts/widgets.ts` into the `ComfyWidgets` registry, a leaf type module, and the control_after_generate helpers. `widgets.ts` imported all 22 widget composables to build the registry, and every composable imported `ComfyWidgetConstructorV2` from `widgets.ts`. That type edge put the whole `vueNodes/widgets/composables` tree into the app import cycle even though the type only needs `LGraphNode`, `InputSpec` and `IBaseWidget`. Measured with dependency-cruiser on `src` (the Comfy-Org#19085 config, run locally), against `main` at 18a9c42: | | before | after | | --- | --- | --- | | modules in any cycle | 511 | 496 | | largest cycle | 296 | 281 | | cyclic edges | 2121 | 2085 | Tracks FE-2769 / FE-3037. ## Changes - New `src/types/widgetConstructor.ts` with `ComfyWidgetConstructorV2`. The 22 composables and `widgets.ts` import it from there. `ComfyWidgetConstructor` (V1) and `CustomComfyWidgetConstructor` stay in `widgets.ts` because they take `ComfyApp`. - New `src/core/graph/widgets/valueControlWidgets.ts` with `addValueControlWidget`, `addValueControlWidgets`, `updateControlWidgetLabel` and their private helpers, moved verbatim from current `main` (including `controlAfterGenerateNameOverride` and the `isValueControlMode` handling added since the branch forked). `useIntWidget`, `useFloatWidget`, `useComboWidget`, `widgetInputs.ts` and `GraphCanvas.vue` import from it. `widgets.controlAfterGenerateName.test.ts` moves with them as `valueControlWidgets.controlAfterGenerateName.test.ts`. - `useLightInfoWidget.ts` (added on `main` since the original PR) imports `ComfyWidgetConstructorV2` from `@/types/widgetConstructor` like the other composables. - `widgets.ts` no longer re-exports `IS_CONTROL_WIDGET`; `GraphCanvas.vue` imports it from `core/graph/widgets/controlWidgetMarker`. - `valueControl.ts`, `controlWidgetMarker.ts` and `promotedWidgetControl.ts` move out of `scripts/` into `core/graph/widgets` and `core/graph/subgraph`; `health.json` follows `valueControl.ts`. - `widgets.ts` keeps `export const` declarations of the three value-control helpers because `comfyAPIPlugin` only exposes declarations through the `scripts/widgets.js` shim that custom nodes import (`.fallowrc.jsonc` lists them as public, `build/plugins/comfyAPIPlugin.test.ts` asserts them). `useComboWidget.test.ts` mocks all three, since the shim reads them at module load. - `useIntWidget.test.ts` and `useFloatWidget.test.ts` add `vi.mock(import('@/scripts/app'))` (the repo's manual mock). Their old `vi.mock('@/scripts/widgets')` had also been preventing the registry from evaluating; with the registry no longer mocked, the pre-existing `settingStore -> app -> extensionService -> widgetStore -> widgets` runtime cycle reached `useIntWidget()` before its definition. Production import order is unaffected: `app.ts` is entered first there, as before. ## Review Focus - `valueControlWidgets.ts` stays in the cycle (it needs `useSettingStore`); it did not go into `valueControl.ts` because that would have pulled `valueControl.ts` and `promotedWidgetControl.ts` into the cycle too. - The 7 composables still in the cycle (`useComboWidget`, `useIntWidget`, `useFloatWidget`, `useImageUploadWidget`, ...) reach it through `settingStore`, `assetService` or node output stores, not through `widgets.ts`. - `src/types/` was chosen for the type because `simplifiedWidget.ts` and `widgetState.ts` already live there as widget leaf types. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | **Comfy-Org#19093** (this PR) | **Comfy-Org#19092** | **Split `scripts/widgets.ts` registry, types, helpers** | **580 -> 566** | **371 -> 357** | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352 | 172 -> 149 | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves | 324 -> 293 | 149 (baseline) | | Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end --> --------- Co-authored-by: Amp <amp@ampcode.com>
…Comfy-Org#19121) ## Summary Re-implemented on current `main` (the original commit no longer applied after `workspaceApi` gained the web-session adapter path). Comfy-Org#19118 has merged, so this is now one commit on `main`. Tracks FE-2769 / FE-3037. `workspaceApi` imported `authStore` for its request headers and `remintRetry` to attach the 401 re-mint interceptor at module load. Both edges put the workspace billing SDK, capability composables, and churnkey modules inside the auth cycle. The client now receives its credentials through `setWorkspaceApiAuth`, wired from `main.ts`, the same shape as Comfy-Org#19118. Import cycles (dependency-cruiser on `src`, against `origin/main` at b835c9d): 459 -> 439 cyclic modules, largest SCC 234 -> 214, cyclic edges 1815 -> 1730. ## Changes - `workspaceApi.ts`: module-private `WorkspaceApiAuth` (`getWorkspaceAuthHeader`, `getFirebaseAuthHeader`, `attachRetryInterceptor`) and exported `setWorkspaceApiAuth`, which stores the auth and attaches the interceptor to the axios client. `requestAuth` keeps its web-session adapter branch and falls back to the installed workspace header; `acceptInvite` uses the installed Firebase header. Calls that reach the token path before installation throw `WorkspaceApiError('Workspace API auth is not installed', 401)`. No more `authStore` or `remintRetry` imports; `capabilityRevision` still attaches at module load because it has no auth dependency. - New `workspaceApiAuth.ts`: `installWorkspaceApiAuth()` binds the auth-store `*OrThrow` getters and `attachUnifiedRemintInterceptor`. - `main.ts` calls `installWorkspaceApiAuth()` on every distribution, right after the cloud block. It cannot share the `isCloud` gate with `installCloudApiAuth()`: `authStore.getWorkspaceAuthToken` initializes `teamWorkspaceStore` (and so calls `workspaceApi.list()`) for a signed-in user on desktop/local too. - `workspaceApi.test.ts` installs the auth once at module scope; the store actions it stubs are the same ones the installer binds. `webSessionFlagOn.test.ts` installs it next to `installCloudApiAuth()` so the suite runs the production wiring. ## Review Focus - The interceptor is attached in `setWorkspaceApiAuth`, so calling it twice attaches two re-mint interceptors. `main.ts` calls it once; the test files install once at module scope for the same reason. - Unconfigured state only exists before `main.ts` runs. Previously a header lookup in that window would have thrown `AuthStoreError`; it now throws `WorkspaceApiError`. The web-session path never needed the auth store and is unaffected. - `WorkspaceApiAuth` is module-private; nothing outside `workspaceApi.ts` names the type. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | **Comfy-Org#19121** (this PR) | **Comfy-Org#19118** | **Install workspace api credentials from `main.ts`** | **447 -> 428** | **233 -> 214** | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352 | 172 -> 149 | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves | 324 -> 293 | 149 (baseline) | | Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end -->
…g#19116) ## Summary Targets `main`; the rest of this chain (Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19113) has merged. Tracks FE-2769 / FE-3037. `executionStore` drove the node text preview widget itself: it bound the `progress_text` socket event, resolved the node on the canvas, called `showTextPreview`, and on job reset walked the job's nodes to `removeTextPreview`. That pulled `useNodeProgressText` (and through it the widget layer and `app`) plus `canvasStore` into the store. Separately, `workflowStore` imported `executionStore` to rewrite session job paths on rename, while `executionStore` imports `workflowStore`; fallow flags that two-module cycle once this PR touches `executionStore`. Import cycles, measured with dependency-cruiser on `src` (the `pnpm lint:cycles` script arrives with Comfy-Org#19085) against `main`: cyclic modules 421 -> 418, largest cycle 196 -> 193, cyclic edges 1687 -> 1679. The rename change removes one of those edges; both stores stay in the large cycle through other paths. ## Changes - `executionStore` exposes `onJobReset` (vueuse `createEventHook`) and triggers it with the finished `QueuedJob` inside `resetExecutionState`, before the job is dropped. `QueuedJob` is exported for the listener type. The store no longer imports `useNodeProgressText`, `canvasStore`, or `parseNodeId`, and `progress_text` is no longer bound in `bindExecutionEvents`. - New `useProgressTextPreviews` composable listens to `api` `progress_text` and `executionStore.onJobReset` and owns the widget calls. GraphView mounts it next to `useProgressFavicon`. `GraphView.test.ts` is unchanged. - `workflowStore` no longer imports `executionStore`. `renameWorkflow` triggers a new `onWorkflowRenamed` hook where it used to call `rewriteSessionWorkflowPaths`, and `executionStore` subscribes in its setup. `rewriteSessionWorkflowPaths` is now private. - Tests: the progress_text and widget-removal cases move to `useProgressTextPreviews.test.ts` (real execution store, the shared `api` automock, fixtures built in each test, scope stopped with `onTestFinished`), which adds cases for the active-prompt filter, for mapping a nested execution id, and for disposal removing both listeners. Removal there is driven through `clearActiveJobIfStale`. `executionStore.test.ts` keeps one table asserting `onJobReset` fires with the job after success, interrupt, and error, and drops `progress_text` from the unbind list. Its session-path tests now drive a real `renameWorkflow`; the matching rename test in `workflowStore.test.ts` is removed and its duplicate-graph-id case lives in `executionStore.test.ts`. - E2E: the Flux2 rerun spec's progress-text test now checks the status line is visible on the node while it runs, then hidden and gone from the widget store after `execution_success`. Before, it only checked removal, so it passed even if the preview never appeared. ## Review Focus - `createEventHook` follows the existing pattern in `cloudWebSessionStore` (`onSignedOutElsewhere`). Its `on` auto-unsubscribes when the calling scope (GraphView) is disposed, and `trigger` calls listeners synchronously, so the listener sees the job before `resetExecutionState` deletes it. - Listener lifetime: `useEventListener(api, 'progress_text')` binds at GraphView setup and unbinds when GraphView's scope is disposed. Before, the store bound it in `bindExecutionEvents` (GraphView `onMounted`) and unbound it in `unbindExecutionEvents` (`onBeforeUnmount`). `progress_text` only matters once the canvas exists, and the handler already ignores events with no canvas. - Rename timing: the hook fires synchronously at the point the direct call ran, right after `workflow.rename` and before the lookup swap and bookmark awaits, so linear-mode outputs keep matching the renamed workflow. When `executionStore` does not exist yet there is no session state to rewrite. - Behavior is otherwise unchanged. The filters (active prompt only, nested execution ids mapped through `workflowStore`, active workflow only on reset) keep the same logic; node lookup is now one shared `findNode` helper. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | **Comfy-Org#19116** (this PR) | **Comfy-Org#19113** | **Progress text previews out of `executionStore`** | **467 -> 464** | **253 -> 250** | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352 | 172 -> 149 | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves | 324 -> 293 | 149 (baseline) | | Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end --> --------- Co-authored-by: Amp <amp@ampcode.com>
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed under frontend authority per DrJKL's explicit #christian-requests flag (outside account-layer scope but assigned+requested).
Spot-checked the account-layer-relevant slices for fidelity to the "moved verbatim" claim: useAuthDialogs.ts and useBillingDialogs.ts are byte-identical to the old dialogService.ts bodies (only workspaceDialogProps was renamed to the shared SELF_STYLED_PANEL_DIALOG_PROPS constant, itself unchanged). extensionDialogService.ts assembles the full extension surface, and App.vue calls registerExtensionDialogService(createExtensionDialogService()) before useWorkspaceStore() is constructed, so the module-level assert in useExtensionDialogService() can't fire on the real boot path — confirmed workspaceStore.dialog reads it lazily via computed(), not at module eval, and that useExtensionDialogService has no other call site. __mocks__/dialogService.ts was trimmed to match the narrowed core surface.
Zero open review threads, CodeRabbit APPROVED, CI fully green (no cancelled/skipped-as-failure gates). Mechanism matches the description.
Approving.
…omfy-Org#19143) ## Summary Modules below `scripts/app.ts` in the import graph stop importing the `app` value from it. They call `useApp()` from `scripts/appInstance`, which reads a registry that `app.ts` fills right after constructing `ComfyApp`. Type-only consumers import the new `ComfyApp` interface from `types/comfy`. Clipspace state moves out of the class into `scripts/clipspace`. Import cycles: 409 -> 371 cyclic modules, largest SCC 184 -> 154 (litegraph is now the largest), 1640 -> 1451 cyclic edges, measured with dependency-cruiser on `main` a2dba8f. Targets `main` directly, rebased onto a2dba8f. Tracks FE-2769 / FE-3037. ## Changes - `types/comfy.ts`: `ComfyApp` interface (public instance surface), `QueuePromptOptions`, `LoadGraphDataOptions`. `types/index.ts` re-exports the type from here instead of from `scripts/app`. - `scripts/appRegistry.ts`: `registerApp` / `useApp` (asserts registration). `scripts/appInstance.ts` re-exports `useApp` as the consumer-facing seam so tests can mock it without re-entering `app.ts`. - `scripts/clipspace.ts`: clipspace state plus `copyToClipspace` / `pasteFromClipspace`. `ComfyApp` statics stay as accessors for custom-node compatibility; `litegraphService` and `changeTracker` use the leaf directly. - `class ComfyApp implements ComfyApp` (aliased `IComfyApp` inside `app.ts`). `ANIM_PREVIEW_WIDGET` now lives in `useNodeAnimatedImage.ts` and is re-exported from `app.ts`. - ~40 SCC importers switched to `useApp()` (all call sites are inside functions). On the current base that includes the mask editor composables, `useNodeProgressText` and `useProgressTextWidget`, which joined the SCC after the original PR. Type positions use `ComfyApp['rootGraph']` / `Parameters<ComfyApp['loadGraphData']>[0]`. - `commandStore.loadExtensionCommands` takes `{ name; commands? }` so it no longer imports `ComfyExtension`. - `vitest.setup.ts`: global mock of `@/scripts/appInstance` that resolves `useApp()` to whatever `@/scripts/app` is in the test file (real or per-file mock), awaited in `beforeAll` / `beforeEach`. `firstRunEntry.test.ts`'s `createSharedComposable` stand-in now resets every composable it created rather than only the last one registered. - `scripts/README.md`: documents the interface / `useApp()` / clipspace pattern. - Baselines: `.fallow-baselines/dead-code.json` gains 32 pre-existing cycles (auth, billing, `workflowStore` <-> `executionStore`, the billing paths through `useBillingDialogs`, and `comfyWorkflow -> changeTracker -> workflowStore`) that fallow only enumerates once the hub edges are gone; every entry's modules sit in one SCC on `main`; the entries use fallow's sorted-path key. `health.json` entry for `clipspace.ts`. ## Review Focus - Only modules below `app.ts` use `useApp()`. Top-level code (extensions, components, `App.vue`) keeps `import { app }`. - `useApp()` asserts that `registerApp` has run; every migrated call site runs after `app.ts` evaluates. `appRegistry.test.ts` covers both branches. - The vitest bridge loads `@/scripts/app` asynchronously, so modules in its tree now evaluate after the test subject's imports. `firstRunEntry.test.ts` was the one test sensitive to that ordering. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | **Comfy-Org#19143** (this PR) | **Comfy-Org#19131** | **Invert `scripts/app` behind `useApp()`** | **391 -> 352** | **172 -> 149** | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves | 324 -> 293 | 149 (baseline) | | Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end --> --------- Co-authored-by: Amp <amp@ampcode.com>
## Summary `types/comfy.ts` is the public extension contract, yet it imported `scripts/widgets`, `scripts/ui`, and the workflow store, so every module that typed against `ComfyApp` was pulled into the app's largest import cycle. This PR makes `types/comfy.ts`, `types/extensionTypes.ts`, and `comfyWorkflow.ts` leaves: they no longer reach `scripts/appInstance`. Before the review fixes, depcruise measured the 273-module app SCC splitting into 119 + 58 modules. Import-cycle measurements before the review fixes: 371 -> 341 cyclic modules, largest SCC 154 -> 154 (litegraph), 1451 -> 1335 cyclic edges, on `main` df4ea6d (Comfy-Org#19143 merged as cdc9fe0). These counts have not been remeasured after restoring the extension hooks. `workflowStoreTypes.ts` carries main's `nodeLocatorIdToNodeId: ... => NodeId | null` signature, which landed on `main` after the interface moved. Targets `main` directly, rebased onto df4ea6d after Comfy-Org#19143 merged (cdc9fe0). Tracks FE-2769 / FE-3037. ## Changes - `ComfyWidgetConstructor` / `CustomComfyWidgetConstructor` are declared in `types/comfy.ts`; `scripts/widgets.ts` imports them. `ComfyApp.widgets` is typed as `Record<string, ComfyWidgetConstructor | CustomComfyWidgetConstructor>` instead of `typeof ComfyWidgets`, and `dynamicComboWidget` narrows the result of `app.widgets.COMBO`. - `MissingModelPipelineResult` moves to `platform/missingModel/types.ts`; `groupCandidatesByName` moves into `missingModelGrouping.ts` so grouping stops importing scan. - `scripts/ui.ts`: `ComfyUI(app, host)` takes the app and a `LegacyMenuHost` (`resetView`, `restoreOutputs`, `trackRunButton`, `enterFocusMode`) instead of calling `useApp()`, `litegraphService`, `nodeOutputStore`, `workspaceStore`, and `useRunButtonTelemetry`. `app.ts` wires the host. - `comfyWorkflow.ts` becomes a leaf. `WorkflowChangeTracker` is an interface `ChangeTracker` implements. A `WorkflowRuntime` (`createChangeTracker`, draft get/remove/markUsed, `isDraftPersistenceEnabled`) is registered by `workflowStore.ts` at module scope, replacing the dynamic `import('@/scripts/changeTracker')` and the direct settings/draft-store imports. - `ComfyWorkflow.promptSave()` remains an extension override point. Its default delegates to the registered `WorkflowRuntime`, which opens the dialog using `saveNamePrompt` i18n keys, overridden by `SubgraphBlueprint`. `workflowService.saveWorkflowAs` continues calling the hook. - Clipspace editor save honors `ComfyApp.pasteFromClipspace` overrides. Image paste updates store-backed outputs without requiring legacy previews and skips absent selections while still pasting widget values. - New leaf `workflowStoreTypes.ts` exports the `WorkflowStore` interface; `ExtensionManager.workflow` is typed as `WorkflowStore`. - New leaf `services/dialogServiceTypes.ts` with `CoreDialogService`, `ExtensionDialogService`, `ConfirmOptions`, `ExecutionErrorDialogInput`; `useDialogService()` returns `CoreDialogService` and `extensionTypes.ts` imports the leaf. `ExtensionDialogService` carries main's current signatures (`showCancelSubscriptionDialog` scope/confirmed args, `paymentIntentSource`, `showInviteLinkInvalidDialog`, `showInviteWrongAccountDialog`). - `comfyWorkflow.test.ts` deleted (it tested the dynamic-import failure path that no longer exists); `workflowService.test.ts` mocks `useDialogService().prompt` and asserts the save-name copy; `ui.test.ts` / `ui.setStatus.test.ts` pass the app and a stub host. ## Review Focus - `ComfyApp.widgets` loses the `typeof ComfyWidgets` key typing. Core widget constructors are still reachable as `useWidgetStore().coreWidgets`; extension code indexing `app.widgets.<Name>` now gets the union type. - `ExtensionManager.workflow` no longer exposes Pinia `$`-methods on the public type. Extensions calling `app.extensionManager.workflow.$patch` would be a type break (runtime unchanged). - `ComfyWorkflow.promptSave` is preserved because [RigShare](https://github.com/xiaodoudou/ComfyUI-RigShare/blob/3de3cc32e2a5bd266879dd6b346f8960ad4dd619/web/rigshare/save-dialog.js#L22) and [Bada-Utils](https://github.com/bada-ya/ComfyUI-Bada-Utils/blob/0898b33e803df8e169501d8fe0cf1fd04044f7bf/web/workflow_organizer.js#L2996) wrap its prototype implementation to customize Save As. A regression test checks that an override's filename reaches the save path. - `workflowStore.ts` now imports `ChangeTracker` statically. fallow sees the previously dynamic `comfyWorkflow -> workflowStore -> changeTracker` 3-cycle reshaped into two short `workflowStore <-> changeTracker` cycles; this plus 28 pre-existing cycles fallow newly enumerates (auth/session, api <-> authStore <-> dialogService, promotionUtils through canvasStore and litegraphService, useAppMode -> workflowStore -> changeTracker -> executionStore, workflowStore <-> executionStore, canvasStore <-> litegraphUtil) are baselined in `.fallow-baselines/dead-code.json`. Breaking `changeTracker -> workflowStore` needs a host injection into `ChangeTracker` and a rewrite of its 1400-line test, so it is left for a follow-up. - `dynamicComboWidget` keeps the runtime lookup through `app.widgets.COMBO`. A static import of `useComboWidget` or `widgetStore` from `dynamicWidgets.ts` creates a module-evaluation cycle with `scripts/widgets.ts` (`...dynamicWidgets` spread sees an uninitialised binding), which is why the assert-based narrowing is used instead. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352 | 172 -> 149 | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | **Comfy-Org#19153** (this PR) | **Comfy-Org#19148** | **`types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves** | **324 -> 293** | **149 (baseline)** | | Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end --> --------- Co-authored-by: Amp <amp@ampcode.com>
## Summary Removes the import cycles left inside `src/workbench`: the 28-module manager cycle and the agent CRDT status cycle. `workbench/` is now cycle-free, which is a prerequisite for giving it its own TypeScript project reference. Import cycles: 341 -> 311 cyclic modules, 20 -> 18 cycles, largest SCC 154 -> 154 (litegraph), 1335 -> 1262 cyclic edges, on top of Comfy-Org#19153 (rebased onto `main` df4ea6d). Stacked on Comfy-Org#19153 (rebased onto the `drjkl/comfy-types-leaf` chain). Tracks FE-2769 / FE-3037. ## Changes - Manager: `useManagerState` had two responsibilities, deriving the manager UI state and opening the manager. Opening needs `useManagerDialog`, which imports `ManagerDialog.vue`, whose subtree imports `useManagerState` again. `openManager` moves to `useManagerDialog`, which already owns `show()`/`hide()`. `useManagerState` keeps the state derivations and the once-per-session upgrade toast, and exports `showIncompatibleManagerToast({ force })` so the explicit-click re-emit lives with `openManager`. - Callers (`useCoreCommands`, `TopMenuSection`, `ComfyMenuButton`, `HelpCenterMenuContent`, `ErrorGroupList`, `MissingPackGroupRow`) call `useManagerDialog().openManager(...)`. `ComfyMenuButton` no longer needs `useManagerState`. The legacy-menu error toast in `openManager` uses the `useToast()` API from Comfy-Org#16313, as `useManagerState` does on `main`. - Tests: `openManager` coverage moves from `useManagerState.test.ts` to `useManagerDialog.test.ts` and now covers all four states (DISABLED, INCOMPATIBLE, LEGACY_UI with and without `showToastOnLegacyError`, NEW_UI with and without `isLegacyOnly`) by driving the real `useManagerState` through `systemStatsStore` and spied `api` feature flags. The shared `__mocks__/useManagerState.ts` drops `openManager`; a new `__mocks__/useManagerDialog.ts` covers component tests. - Agent composer: the `ComposerAttachment` leaf this PR originally introduced already landed on main (`types/composerAttachment.ts`), so that part is dropped. - Agent CRDT: `AgentCrdtStatus` and `AgentCrdtOutcomeCounters` move to a new leaf `crdt/agentCrdtStatus.ts` so `crdtSnapshot.ts` stops importing `useAgentCrdtFollower.ts`. - fallow baselines: `dead-code.json` is unchanged (the stale manager entries stay as unused baseline rows); the `crap_high` entry for `openManager` moves from `useManagerState.ts` to `useManagerDialog.ts` in `health.json` (same function, new file). ## Review Focus - `openManager` now calls `useManagerState()` per invocation. Its `watch(..., { immediate: true })` runs once per call and can fire the once-per-session INCOMPATIBLE toast if no component had instantiated the composable yet. That matches the previous behaviour, where every caller instantiated `useManagerState()` before calling `openManager`. - `useManagerDialog` now imports `useManagerState`; the dependency direction is dialog -> state, matching `useManagerDialog -> ManagerDialog.vue -> ... -> useManagerState`. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352 | 172 -> 149 | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves | 324 -> 293 | 149 (baseline) | | **Comfy-Org#19186** (this PR) | **Comfy-Org#19153** | **Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves** | **293 -> 259** | **149 (baseline)** | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end --> --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Targets
maindirectly, rebased onto cb72d45 after #19093 merged (6067dee). The original sat on #19121; #19118 and #19121 are no longer in this chain. Tracks FE-2769 / FE-3037.dialogServicebundled the core prompt/confirm/error dialogs with every auth, billing, workspace, cloud-notification and ComfyHub dialog. Any module that calledconfirm()transitively imported the billing and workspace layers, andworkspaceStore -> dialogService -> useBillingContext -> ... -> workspaceStoreheld the whole platform layer in the app SCC.The core service keeps
showExecutionErrorDialog,showErrorDialog,prompt,confirm,showExtensionDialog,showLayoutDialogandshowSmallLayoutDialog. Feature dialogs move verbatim into per-feature composables. Extensions still see every dialog onapp.extensionManager.dialog.Import cycles on
maincb72d45: 421 -> 412 cyclic modules, largest SCC 196 -> 187, 1687 -> 1648 cyclic edges.Changes
dialogService.ts: core dialogs only. DeclaresExtensionDialogService(core + feature signatures, leaf types only),registerExtensionDialogService()anduseExtensionDialogService().extensionDialogService.ts:createExtensionDialogService()spreads the core service and the feature composables.App.vueregisters it beforeuseWorkspaceStore()is created;workspaceStore.dialogreads the registry.ExtensionManager.dialogis typedExtensionDialogService.composables/auth/useAuthDialogs.ts,composables/billing/useBillingDialogs.ts,platform/workspace/composables/useWorkspaceDialogs.ts,platform/cloud/notification/composables/useCloudNotificationDialog.ts;showPublishDialogjoinsuseComfyHubPublishDialog. The sharedworkspaceDialogPropsobject becomesSELF_STYLED_PANEL_DIALOG_PROPSincomponents/ui/dialog/dialog.variants.ts, next toHUG_CONTENT_CLASSandSELF_STYLED_PANEL_CONTENT_CLASS, whichmainalready has there.composables/billing/types.tsgainsTopUpCreditsDialogOptions,SubscriptionDialogOptions,DowngradeToPersonalResult.ConfirmationDialogTypemoves tocomponents/dialog/content/confirmationDialogTypes.ts.useSettingsDialogcallsdialogStore.showDialogdirectly with the same renderer/headless/closable propsshowLayoutDialogapplied.useDialogService().showXto the owning composable. Tests get a__mocks__per feature composable; billing dialog tests move next touseBillingDialogs(git mv), and the twoshowCancelSubscriptionDialogguard tests move fromdialogService.concurrency.test.tsintouseBillingDialogs.cancelSubscription.test.ts.useInviteUrlLoaderandUserPanel(added onmainsince the original) switch touseWorkspaceDialogs/useAuthDialogstoo. The downgrade-failure toast inuseBillingDialogsuses theuseToast()API from [Phase 6a] Replace PrimeVue Toast with design-system toast #16313, as the moved code onmaindoes.Review Focus
workspaceStoreimporting the aggregator directly keeps every feature composable in the SCC (in the original stack, simulated 185 vs 172). The registry is a module-levelletguarded byassertfrom@/base/assert;App.vueis the only registration site.useExtensionDialogService()before registration is a programming error:assertthrows in DEV and reports in production.PublishDialog.ts,CloudNotification.ts) callwindow.app.extensionManager.dialog.showPublishDialog/showCloudNotification; both remain on the extension surface.app. That is the next PR (app-> root graph leaf)..fallow-baselines/health.json: onecrap_highentry added foruseBillingDialogs.ts;showTopUpCreditsDialogmoved verbatim, fallow re-estimates coverage per file from export references, and the composable has fewer importers thandialogService.Stack
Import-cycle progress for FE-3037, measured with
pnpm lint:cycles(dependency-cruiser onsrc).Standalone PRs targeting
mainEach is one commit on current
mainand can merge on its own. Numbers are that PR alone againstorigin/main(1027 cyclic modules, largest cycle 983, 4562 cyclic edges).mainServerFeatureFlagenum to a leaf modulemainappModeStoremainComfy.MaskEditorextensionmainPositionConfigand layer editor dialog key to leaf modulesmainsettingStoreoffscripts/app;$elto a leafmainMissingNodeTypeto the nodeReplacement leafmainnodeDefStoremainAll eight together on
main, plus #19091, #19107, #19108, #19111, #19116 and #19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges.Remaining stack
Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older
mainthe stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses.#19091, #19107, #19111, #19113 and #19131 still carry the old commits of the PRs they were moved off (#19131 carries #19122, #19124, #19125 and #19127), so their GitHub diffs are wider than one PR until the stack is rebased.
mainpnpm lint:cycles)interfaces.tsinto leaf typessidebarTabStoreextensionServicescripts/widgets.tsregistry, types, helpersexecutionStoremain.tsmain.tsdialogServicescripts/appbehinduseApp()types/comfy,comfyWorkflow, dialog/workflow contracts as leavesopenManagerontouseManagerDialog, agent leaves